[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc marked an inline comment as done. mibintc added inline comments. Comment at: clang/docs/LanguageExtensions.rst:3197 +by the pragma behaves as though the command-line option + ``-ffp-exception-behavior=strict`` is enabled, +when ``pragma float_control(precise, off)`` is en

[PATCH] D78827: Add support for #pragma clang fp allow_reassociation(on|off) -- floating point control of associative math transformations

mibintc updated this revision to Diff 260381. mibintc retitled this revision from "Add support for #pragma clang fp reassoc(on|off) -- floating point control of associative math transformations" to "Add support for #pragma clang fp allow_reassociation(on|off) -- floating point control of associa

[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc marked 5 inline comments as done. mibintc added a comment. A couple replies to @erichkeane Comment at: clang/include/clang/AST/Expr.h:2251 + /// allocated in Trailing Storage + void setHasStoredFPFeatures(bool B) { UnaryOperatorBits.HasFPFeatures = B; } + bool hasSto

[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc marked an inline comment as done. mibintc added inline comments. Comment at: clang/include/clang/AST/Expr.h:2701 + FPOptions FPFeatures; + mibintc wrote: > erichkeane wrote: > > This type already has trailing-storage type stuff. I think in the past >

[PATCH] D78827: Add support for #pragma clang fp reassoc(on|off) -- floating point control of associative math transformations

mibintc updated this revision to Diff 261036. mibintc added a comment. Thanks for your review @sepavloff and @erichkeane, I have responded to your feedback and reverted the name back to reassoc which is what Serge prefers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc marked an inline comment as done. mibintc added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:870 +def err_pragma_fenv_requires_precise : Error< + "'#pragma STDC FENV_ACCESS ON' is illegal when precise is disabled">; def warn_cxx_ms_struc

[PATCH] D78827: Add support for #pragma clang fp reassociate(on|off) -- floating point control of associative math transformations

mibintc marked 4 inline comments as done. mibintc added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:186 +FPM_Fast }; rjmccall wrote: > I'm not sure I think this fusion was an improvement; the net effect was to > remove a few lin

[PATCH] D78827: Add support for #pragma clang fp reassociate(on|off) -- floating point control of associative math transformations

mibintc updated this revision to Diff 261875. mibintc retitled this revision from "Add support for #pragma clang fp reassoc(on|off) -- floating point control of associative math transformations" to "Add support for #pragma clang fp reassociate(on|off) -- floating point control of associative mat

[PATCH] D78827: Add support for #pragma clang fp reassociate(on|off) -- floating point control of associative math transformations

mibintc marked an inline comment as done. mibintc added a comment. A reply to @scanon Comment at: clang/docs/LanguageExtensions.rst:3182 +enabled for the translation unit with the ``-fassociative-math`` flag. +The pragma can take two values: ``on`` and ``off``. + --

[PATCH] D78827: Add support for #pragma clang fp reassociate(on|off) -- floating point control of associative math transformations

mibintc updated this revision to Diff 261921. mibintc added a comment. I fixed the issues that @rjmccall mentioned. I don't yet have an answer for @scanon, need to get back to you about that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78827/new

[PATCH] D78827: Add support for #pragma clang fp reassociate(fast|off) -- floating point control of associative math transformations

mibintc added a comment. I checked with FPGA folks and confirm what @scanon says is correct, the reassoc fast math flag enables reassociation across multiple statements, so i changed the syntax to use 'fast' and 'off', and changed the documentation Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D78827: Add support for #pragma clang fp reassociate(fast|off) -- floating point control of associative math transformations

mibintc updated this revision to Diff 262108. mibintc retitled this revision from "Add support for #pragma clang fp reassociate(on|off) -- floating point control of associative math transformations" to "Add support for #pragma clang fp reassociate(fast|off) -- floating point control of associati

[PATCH] D78827: Add support for #pragma clang fp reassociate(on|off) -- floating point control of associative math transformations

mibintc updated this revision to Diff 262217. mibintc retitled this revision from "Add support for #pragma clang fp reassociate(fast|off) -- floating point control of associative math transformations" to "Add support for #pragma clang fp reassociate(on|off) -- floating point control of associati

[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc added a comment. In D72841#2022354 , @uabelho wrote: > It seems to be this change in SemaStmt.cpp that makes the FENV-pragma have > some effect regardless of the warning saying that the pragma doesn't have > any effect: > > index aa0d89ac09c3.

[PATCH] D78827: Add support for #pragma clang fp reassociate(on|off) -- floating point control of associative math transformations

This revision was automatically updated to reflect the committed changes. Closed by commit rGc355bec749e9: Add support for #pragma clang fp reassociate(on|off) (authored by mibintc). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78827/new/ https://r

[PATCH] D79510: [PATCH] When pragma FENV_ACCESS is ignored do not modify Sema.CurFPFeatures

mibintc created this revision. mibintc added reviewers: uabelho, rjmccall, erichkeane. Herald added a project: clang. Herald added a subscriber: cfe-commits. Bug reported by @uabelho against reviews.llvm.org/D72841 pragma STDC FENV_ACCESS ON is ignored, but the f

[PATCH] D79510: [PATCH] When pragma FENV_ACCESS is ignored do not modify Sema.CurFPFeatures

mibintc marked 2 inline comments as done. mibintc added inline comments. Comment at: clang/lib/Parse/ParsePragma.cpp:111 PP.Diag(Tok, diag::warn_stdc_fenv_access_not_supported); + return; } Modified this to return instead of making changes which

[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc added a comment. I posted a patch to fix the bug reported by @uabelho here https://reviews.llvm.org/D79510 @rjmccall I used check-clang and check-all on D71841 from my linux x86-64 server before submitting, and the testing was clear. Maybe your branch

[PATCH] D78827: Add support for #pragma clang fp reassociate(on|off) -- floating point control of associative math transformations

mibintc added a comment. BTW there is a proposal http://www.open-std.org/jtc1/sc22/wg14/www/docs/n2421.pdf at the ISO C meeting to support some new floating point pragmas including #pragma STDC FENV_ALLOW_ASSOCIATIVE_LAW on-off-switch The committee wants to see an implementation(s) to ensure th

[PATCH] D78827: Add support for #pragma clang fp reassociate(on|off) -- floating point control of associative math transformations

mibintc added a comment. The ISO C proposal is here http://www.open-std.org/jtc1/sc22/wg14/www/docs/n2407.pdf but the details are in the IEEE standards documents. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78827/new/ https://reviews.llvm.org/D

[PATCH] D79510: [PATCH] When pragma FENV_ACCESS is ignored do not modify Sema.CurFPFeatures

This revision was automatically updated to reflect the committed changes. Closed by commit rGe5578013b199: When pragma FENV_ACCESS is ignored do not modify Sema.CurFPFeatures Bug… (authored by mibintc). Changed prior to commit: https://reviews.llvm.org/D79510?vs=262434&id=262467#toc Repository

[PATCH] D79631: #pragma float_control should be permitted at namespace scope

mibintc created this revision. mibintc added reviewers: rjmccall, erichkeane. Herald added a project: clang. Herald added a subscriber: cfe-commits. I got a bug report from Intel that https://reviews.llvm.org/D72841 was causing a crash on Windows in vs2017 header in /std:c++17 mode, because #p

[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc added a comment. I got a report that this patch was causing a problem with Windows header because #pragma float_control should be supported in namespace context. I've posted a patch for review here https://reviews.llvm.org/D79631 Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D79631: #pragma float_control should be permitted at namespace scope

mibintc added a comment. No this patch isn't ready yet. i see an assertion if try to instantiate a template function when the template has enabled floating point settings Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79631/new/ https://reviews.llv

[PATCH] D79631: #pragma float_control should be permitted at namespace scope

mibintc updated this revision to Diff 263020. mibintc added a comment. I corrected the assertion error by propagating usesFPIntrin flag from the template function to the template instantiation and added a test case. Ready for review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc added a comment. I will work @rjmccall comment about codegen vs langopt - can you leave it in place for now? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72841/new/ https://reviews.llvm.org/D72841 __

[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc marked 2 inline comments as done. mibintc added a comment. Some inline replies/comments to @rjmccall and @plotfi Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3185 Opts.FiniteMathOnly = Args.hasArg(OPT_ffinite_math_only) || Args.hasArg(OPT_cl_finite_ma

[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc added a comment. @rjmccall Uncertain how to proceed, can you recommend? If I recall correctly, I added the lines in CompilerOptions because there were many failing lit tests, i could have fixed the lit fails by adding the lang options to the lit tests. (of course that change could have

[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3192 + Opts.NoHonorNaNs = + Opts.FastMath || CGOpts.NoNaNsFPMath || Opts.FiniteMathOnly; + Opts.NoHonorInfs = @rjmccall I could set these by using Args.hasArg instead of C

[PATCH] D79735: FP LangOpts should not be dependent on CGOpts

mibintc created this revision. mibintc added reviewers: plotfi, rjmccall. Herald added a project: clang. Herald added a subscriber: cfe-commits. This bug was observed by Apple since their compiler processes LangOpts and CGOpts in a different order Repository: rG LLVM Github Monorepo https://

[PATCH] D79735: FP LangOpts should not be dependent on CGOpts

This revision was automatically updated to reflect the committed changes. Closed by commit rG01dc694ccb86: FP LangOpts should not be dependent on CGOpt This bug was observed by Apple… (authored by mibintc). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc added a comment. In D72841#2029821 , @plotfi wrote: > @ab @rjmccall @mibintc Posted D79730 for > consideration. > @mibintc can you produce a version of _this_ diff that works with D79730 >

[PATCH] D79631: #pragma float_control should be permitted at namespace scope

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG7f2db9935009: [PATCH] #pragma float_control should be permitted in namespace scope. (authored by mibintc). Repository:

[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:227 + FMF.setAllowContract(FPFeatures.allowFPContractAcrossStatement() || + FPFeatures.allowFPContractWithinStatement()); } michele.scandale wrote: > I'm not con

[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc marked an inline comment as done. mibintc added inline comments. Comment at: clang/lib/Serialization/ASTReader.cpp:7899 +if (FpPragmaCurrentLocation.isInvalid()) { + assert(*FpPragmaCurrentValue == SemaObj->FpPragmaStack.DefaultValue && + "Expected a

[PATCH] D79903: FastMathFlags.allowContract should be init from FPFeatures.allowFPContractAcrossStatement

mibintc created this revision. mibintc added reviewers: rjmccall, scanon. Herald added a project: clang. mibintc marked 3 inline comments as done. mibintc added a comment. added some inline explanation Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2943 + if (Opts.FastR

[PATCH] D79903: FastMathFlags.allowContract should be init from FPFeatures.allowFPContractAcrossStatement

mibintc marked 3 inline comments as done. mibintc added a comment. added some inline explanation Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2943 + if (Opts.FastRelaxedMath) +Opts.setDefaultFPContractMode(LangOptions::FPM_Fast); Opts.HexagonQdsp6Compat = Args.

[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc marked 2 inline comments as done. mibintc added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:227 + FMF.setAllowContract(FPFeatures.allowFPContractAcrossStatement() || + FPFeatures.allowFPContractWithinStatement()); }

[PATCH] D79903: FastMathFlags.allowContract should be init from FPFeatures.allowFPContractAcrossStatement

mibintc marked an inline comment as done. mibintc added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2943 + if (Opts.FastRelaxedMath) +Opts.setDefaultFPContractMode(LangOptions::FPM_Fast); Opts.HexagonQdsp6Compat = Args.hasArg(OPT_mqdsp6_compat);

[PATCH] D79903: FastMathFlags.allowContract should be init from FPFeatures.allowFPContractAcrossStatement

mibintc marked 2 inline comments as done. mibintc added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2943 + if (Opts.FastRelaxedMath) +Opts.setDefaultFPContractMode(LangOptions::FPM_Fast); Opts.HexagonQdsp6Compat = Args.hasArg(OPT_mqdsp6_compat);

[PATCH] D79903: FastMathFlags.allowContract should be init from FPFeatures.allowFPContractAcrossStatement

mibintc marked an inline comment as done. mibintc added a comment. reply about the incorrect setting of 'fast' during OpenCL compilation with option -cl-fast-relaxed-math Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2943 + if (Opts.FastRelaxedMath) +Opts.setDefau

[PATCH] D79903: FastMathFlags.allowContract should be init from FPFeatures.allowFPContractAcrossStatement

mibintc marked an inline comment as done. mibintc added a subscriber: Anastasia. mibintc added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2943 + if (Opts.FastRelaxedMath) +Opts.setDefaultFPContractMode(LangOptions::FPM_Fast); Opts.HexagonQdsp6C

[PATCH] D79903: FastMathFlags.allowContract should be init from FPFeatures.allowFPContractAcrossStatement

mibintc updated this revision to Diff 264241. mibintc marked an inline comment as done. mibintc added a comment. This is the same as the previous patch, except I removed the fix for pragma push-pop that John said should be committed separately Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D79903: FastMathFlags.allowContract should be init from FPFeatures.allowFPContractAcrossStatement

mibintc added a subscriber: arsenm. mibintc added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2943 + if (Opts.FastRelaxedMath) +Opts.setDefaultFPContractMode(LangOptions::FPM_Fast); Opts.HexagonQdsp6Compat = Args.hasArg(OPT_mqdsp6_compat); -

[PATCH] D34158: For Linux/gnu compatibility, preinclude if the file is available

mibintc reopened this revision. mibintc added a comment. Hi. I also posted this question on IRC @erichkeane pushed a fix for https://reviews.llvm.org/D34158 which on Linux does a preinclude of stdc-predef.h; on Monday. Later on Monday he pulled it out because it caused 3 test failures and word

[PATCH] D40673: Add _Float128 as alias to __float128 to enable compilations on Fedora27/glibc2-26

mibintc created this revision. mibintc added a project: clang. Fedora27 is using a new version of glibc that refers to the _Float128 type. This patch adds that name as an alias to __float128. I also added some predefined macro values for the digits, mantissa, epilon, etc (FloatMacros). For the

[PATCH] D40673: Add _Float128 as alias to __float128 to enable compilations on Fedora27/glibc2-26

mibintc abandoned this revision. mibintc added a comment. Thanks for all your reviews https://reviews.llvm.org/D40673 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40673: Add _Float128 as alias to __float128 to enable compilations on Fedora27/glibc2-26

mibintc updated this revision to Diff 125211. mibintc added a comment. I changed the patch to enable _Float128 only as keyword in mode "nocxx" - this is the same mode being used by _Bool. I changed the test from .cpp to .c; I run check-all and saw only the usual suspects fail. What do you think

[PATCH] D40673: Add _Float128 as alias to __float128 to enable compilations on Fedora27/glibc2-26

mibintc updated this revision to Diff 125378. mibintc added a subscriber: eli.friedman. mibintc added a comment. I responded to comments from @eli.friedman and @hubert.reinterpretcast : I added FIXME comment regarding the "Q" suffix on the float 128 literals (gcc uses https://reviews.llvm.org/F

[PATCH] D40673: Add _Float128 as alias to __float128 to enable compilations on Fedora27/glibc2-26

mibintc marked 3 inline comments as done. mibintc added a comment. added inline replies to Eli and Hubert Comment at: lib/Frontend/InitPreprocessor.cpp:817 DefineFloatMacros(Builder, "LDBL", &TI.getLongDoubleFormat(), "L"); + DefineFloatMacros(Builder, "FLT128", &TI.getFloa

[PATCH] D105951: [clang] P2266 implicit moves STL workaround

mibintc added a comment. Intel compiles VS2019 #include files regularly with clang, and the file compiled with -std:c++latest encounters this error report, which @aaron.ballman suggests is related to this effort. In file included from tst_incl_filesystem.cpp:2: c:/Program files (x86)/Micro

[PATCH] D102343: [clang][patch][FPEnv} Initialization of C++ globals not strictfp aware

mibintc updated this revision to Diff 359772. mibintc added a reviewer: zahiraam. mibintc added a comment. Respond to @aaron.ballman 's review, rebased & used clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102343/new/ https://reviews.ll

[PATCH] D102343: [clang][patch][FPEnv} Initialization of C++ globals not strictfp aware

mibintc marked an inline comment as done. mibintc added inline comments. Comment at: clang/lib/Sema/SemaLambda.cpp:395 MethodNameLoc), - MethodType, MethodTypeInfo, SC_None, + MethodType, MethodTypeInfo, SC_None, /*UsesFPIntrin*/ false,

[PATCH] D93769: [clang] Add support for option -ffp-eval-method and extend #pragma float_control similarly

mibintc updated this revision to Diff 359847. mibintc marked 3 inline comments as done. mibintc added a reviewer: zahiraam. mibintc added a comment. I've rebased and applied clang-format. I'd like to push this, looking for your +1, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D105997: Implement _ExtInt conversion rules

mibintc accepted this revision. mibintc added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105997/new/ https://reviews.llvm.org/D105997 ___ cfe-commits mailing list cfe-commits

[PATCH] D102343: [clang][patch][FPEnv} Initialization of C++ globals not strictfp aware

mibintc updated this revision to Diff 360222. mibintc added a comment. Partially respond to @aaron.ballman 's review by refactoring a change into a separate commit, but I'll push back on another request, I'll add that reply inline. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D102343: [clang][patch][FPEnv} Initialization of C++ globals not strictfp aware

mibintc marked an inline comment as done. mibintc added a comment. Question for Aaron Comment at: clang/include/clang/AST/Decl.h:1993 const DeclarationNameInfo &NameInfo, QualType T, - TypeSourceInfo *TInfo, StorageClass S, bool isInlineSpecified,

[PATCH] D102343: [clang][patch][FPEnv} Initialization of C++ globals not strictfp aware

mibintc updated this revision to Diff 360225. mibintc added a comment. Removed use of auto, and used different capitalization for local var name Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102343/new/ https://reviews.llvm.org/D102343 Files: cl

[PATCH] D93769: [clang] Add support for option -ffp-eval-method and extend #pragma float_control similarly

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGce8024e8ff76: [CLANG][PATCH][FPEnv] Add support for option -ffp-eval-method and extend… (authored by mibintc). Repository: rG LLVM Github Monorepo

[PATCH] D93769: [clang] Add support for option -ffp-eval-method and extend #pragma float_control similarly

mibintc added a comment. In D93769#2891545 , @MaskRay wrote: > This breaks `clang/test/Index/preamble-reparse-changed-module.m` > > http://45.33.8.238/linux/51638/step_7.txt I saw this fail on console when i do "ninja check-clang" but when I run each ste

[PATCH] D93769: [clang] Add support for option -ffp-eval-method and extend #pragma float_control similarly

mibintc added inline comments. Comment at: clang/test/Preprocessor/predefined-flteval-macro.c:332 +// RUN: %clang_cc1 -std=c11 -ffreestanding -triple=riscv64 -fsyntax-only %s +// RUN: %clang_cc1 -std=c11 -ffreestanding -triple=riscv64-unknown-linux -fsyntax-only %s +#ifndef FE

[PATCH] D93769: [clang] Add support for option -ffp-eval-method and extend #pragma float_control similarly

mibintc added a comment. In D93769#2891552 , @MaskRay wrote: > In D93769#2891549 , @mibintc wrote: > >> In D93769#2891545 , @MaskRay wrote: >> >>> This breaks `clang/test/Ind

[PATCH] D95159: [ASTReader] Allow controlling separately whether validation should be disabled for a PCH vs a module file

mibintc added a comment. The newly added test case clang/test/Index/preamble-reparse-changed-module.m is failing on the patch that I'm trying to commit, https://reviews.llvm.org/D93769 Actually the result of the test is a bit flaky, when I build the Debug version on Linux, running ninja check-c

[PATCH] D95159: [ASTReader] Allow controlling separately whether validation should be disabled for a PCH vs a module file

mibintc added a subscriber: aaron.ballman. mibintc added a comment. @aaron.ballman suggested I may have made a mistake adding the new option, I'll look there. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95159/new/ https://reviews.llvm.org/D95159

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

This revision was automatically updated to reflect the committed changes. Closed by commit rGb9b696bba670: [clang][fpenv][patch] Change clang option -ffp-model=precise to select ffp… (authored by mibintc). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

mibintc reopened this revision. mibintc added a comment. This revision is now accepted and ready to land. I had to revert again, it's still failing on Intel buildbots. Cannot reproduce on Intel-internal Broadwell server. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D95159: [ASTReader] Allow controlling separately whether validation should be disabled for a PCH vs a module file

mibintc added a subscriber: MaskRay. mibintc added a comment. More info about the test failure I'm seeing for clang/test/Index/preamble-reparse-changed-module.m It appears it might be a non-deterministic failure, perhaps some test dependencies are missing? Yesterday before I pushed my clang pa

[PATCH] D93769: [clang] Add support for option -ffp-eval-method and extend #pragma float_control similarly

mibintc added a comment. @MaskRay I experience that the failing test clang/test/Index/preamble-reparse-changed-module.m is non-deterministic and currently I cannot reproduce the fail. I added details in D95159 . Are you able to reproduce if you clean your bui

[PATCH] D95159: [ASTReader] Allow controlling separately whether validation should be disabled for a PCH vs a module file

mibintc added a comment. @bnbarham I think you mean a patch like this, is it right? I'd like to fix the test in a pre-commit and then re-push my patch git diff diff --git a/clang/test/Index/preamble-reparse-changed-module.m b/clang/test/Index/preamble-reparse-changed-module.m index 1c6

[PATCH] D95159: [ASTReader] Allow controlling separately whether validation should be disabled for a PCH vs a module file

mibintc added a comment. Whoops, shouldn't mess with the mkdir line diff --git a/clang/test/Index/preamble-reparse-changed-module.m b/clang/test/Index/preamble-reparse-changed-module.m index 1c63e802ce0c..349ed0db27d0 100644 - a/clang/test/Index/preamble-reparse-changed-module.m +++ b/clang/te

[PATCH] D105951: [clang] P2266 implicit moves STL workaround

mibintc accepted this revision. mibintc added a comment. This revision is now accepted and ready to land. I tested this patch downstream on Windows with Microsoft (R) C/C++ Optimizing Compiler Version 19.28.29334 for x64 I used c++20, x++latest default and c++17 with the stl header files (standa

[PATCH] D106863: Allow #pragma float_control(push|pop) within a language linkage specification

mibintc accepted this revision. mibintc added a comment. Thanks for fixing this Aaron, just curious was there a bug report? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106863/new/ https://reviews.llvm.org/D106863

[PATCH] D106863: Allow #pragma float_control(push|pop) within a language linkage specification

mibintc added a reviewer: zahiraam. mibintc added a subscriber: zahiraam. mibintc added a comment. Adding @zahiraam FYI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106863/new/ https://reviews.llvm.org/D106863

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

This revision was automatically updated to reflect the committed changes. Closed by commit rG48ad446a0fb2: [clang][fpenv][patch] Change clang option -ffp-model=precise to select ffp… (authored by mibintc). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D93769: [clang] Add support for option -ffp-eval-method and extend #pragma float_control similarly

This revision was automatically updated to reflect the committed changes. Closed by commit rG66ddac22e2a7: [CLANG][PATCH][FPEnv] Add support for option -ffp-eval-method and extend… (authored by mibintc). Changed prior to commit: https://reviews.llvm.org/D93769?vs=360247&id=362385#toc Repositor

[PATCH] D102343: [clang][patch][FPEnv} Initialization of C++ globals not strictfp aware

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbc5b5ea037db: [clang][patch][FPEnv] Make initialization of C++ globals strictfp aware (authored by mibintc). Repository: rG LLVM Github Monorepo

[PATCH] D102343: [clang][patch][FPEnv] Make Initialization of C++ globals strictfp aware

mibintc added a comment. @MaskRay Thanks a lot -- yes! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102343/new/ https://reviews.llvm.org/D102343 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

mibintc added a comment. ping, looking for a code review, especially from front end folks. thank you! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62731/new/ https://reviews.llvm.org/D62731 ___ cfe-commits mailing l

[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

mibintc marked 2 inline comments as done. mibintc added inline comments. Comment at: clang/docs/UsersManual.rst:1305 + and ``noexcept``. Note that -fp-model=[no]except can be combined with the + other three settings for this option. Details: + rjmccall wrote:

[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

mibintc updated this revision to Diff 217426. mibintc added a comment. I made a couple changes to the UserManual in response to @rjmccall review Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62731/new/ https://reviews.llvm.org/D62731 Files: clang/docs/UsersManu

[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

mibintc marked 3 inline comments as done. mibintc added inline comments. Comment at: clang/docs/UsersManual.rst:1305 + and ``noexcept``. Note that -fp-model=[no]except can be combined with the + other three settings for this option. Details: + andrew.w.kaylor

[PATCH] D62731: [RFC] Add support for options -frounding-math -fp-model= and -fp-exception-behavior= : specify floating point behavior

mibintc updated this revision to Diff 219364. mibintc retitled this revision from "[RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior" to "[RFC] Add support for options -frounding-math -fp-model= and -fp-exception-behavior= : specify floating point be

[PATCH] D62731: [RFC] Add support for options -frounding-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

mibintc marked 2 inline comments as done. mibintc added inline comments. Comment at: clang/docs/UsersManual.rst:1314 + ``-ffp-model=strict``, or merely establish the rounding mode setting + parameter to the llvm floating point constrained intrinsics. + rjmcca

[PATCH] D62731: [RFC] Add support for options -frounding-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

mibintc added a comment. In D62731#1663748 , @rjmccall wrote: > Hmm, you know, there are enough different FP options that I think we should > probably split them all out into their own section in the manual instead of > just listing them under "code gene

[PATCH] D34158: For standards compatibility, preinclude if the file is available

mibintc planned changes to this revision. mibintc added a comment. @erichkeane contacted me offline and pointed out I'm twine-ing with " not <. i'm planning to change the option name from "finclude if exists" to "fsystem include if exists", then i'll quote with < not ". hope to get this updated

[PATCH] D34158: For standards compatibility, preinclude if the file is available

mibintc updated this revision to Diff 108669. mibintc added a comment. Here's an updated patch which is using angle brackets to do the include, so the search for stdc-predef.h is limited to system directories. Also my previous revision was missing the new test cases since i had gotten a new sand

[PATCH] D34158: For standards compatibility, preinclude if the file is available

mibintc updated this revision to Diff 108999. mibintc added a comment. This patch responds to @fedor.sergeev 's feedback from earlier today. This is a change to the test case test/Driver/stdc-predef.c in the situation that the system does not supply a version of stdc-predef.h. Fedor had suggeste

[PATCH] D34158: For standards compatibility, preinclude if the file is available

mibintc planned changes to this revision. mibintc added a comment. I will prepare another patch responding to joerg's comment: > Quoted Text I had a long discussion with James about this on IRC without reaching a clear consensus. I consider forcing this behavior on all targets to be a major bug

[PATCH] D34158: For Linux/gnu compatibility, preinclude if the file is available

mibintc updated this revision to Diff 110055. mibintc added a comment. In the last review, it was deemed less controversial if I move these updates back into the gnu/Linux tool chain. This revision is responding to that feedback. I also simplified the test case. I tested on Linux with check-all

[PATCH] D34624: extra test modifications for D34158

mibintc updated this revision to Diff 110059. mibintc added a comment. Updating this patch to latest revision of tools/extra https://reviews.llvm.org/D34624 Files: test/clang-tidy/llvm-include-order.cpp test/pp-trace/pp-trace-conditional.cpp test/pp-trace/pp-trace-ident.cpp test/pp-trac

[PATCH] D34158: For Linux/gnu compatibility, preinclude if the file is available

mibintc updated this revision to Diff 110193. mibintc added a comment. Responding to @fedor.sergeev 's comment. This is an updated patch which pulls out the "isValid" check on GCCInstallation. Also I'm putting back the dummy sysroot tree which contains stdc-predef.h and adding a new test run to

[PATCH] D34158: For Linux/gnu compatibility, preinclude if the file is available

mibintc updated this revision to Diff 110627. mibintc added a comment. This patch is responding to @jyknight 's concern about preprocessed input. The patch as it stands doesn't have this issue. I added 2 test cases, one using option -x cpp-output, and another for a source file suffixed with .i

[PATCH] D34158: For Linux/gnu compatibility, preinclude if the file is available

mibintc planned changes to this revision. mibintc added a comment. Need TO FIX: We should be stripping the new arg as well: add "-fsystem-include-if-exists" argument to the list of include things in the skipArgs() function in lib/Driver/Job.cpp https://reviews.llvm.org/D34158 __

[PATCH] D34158: For Linux/gnu compatibility, preinclude if the file is available

mibintc updated this revision to Diff 111019. mibintc added a comment. @jyknight recommended adding the new option to skipArgs in Job.cpp. This revision makes that change and tests that in crash-report.c; look OK? https://reviews.llvm.org/D34158 Files: include/clang/Driver/CC1Options.td i

[PATCH] D34158: For Linux/gnu compatibility, preinclude if the file is available

mibintc added a comment. ping https://reviews.llvm.org/D34158 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D87528: Enable '#pragma STDC FENV_ACCESS' in frontend cf. D69272 - Work in Progress

mibintc created this revision. mibintc added reviewers: sepavloff, rjmccall. Herald added a project: clang. mibintc requested review of this revision. I rebased https://reviews.llvm.org/D69272 to work on the blocking comment from @rsmith @sepavloff Is it OK if I continue work on this item? Not

[PATCH] D69272: Enable '#pragma STDC FENV_ACCESS' in frontend

mibintc added a comment. Hello, I rebased this and made a few changes here, https://reviews.llvm.org/D87528 ; I added a question about floating point constant folding in that review, I'm going to duplicate it here, My question is about constant folding. I am working on a task to ensure that cl

[PATCH] D69272: Enable '#pragma STDC FENV_ACCESS' in frontend

mibintc added a comment. In D69272#2271338 , @sepavloff wrote: > In D69272#2268337 , @mibintc wrote: > >> I am working on a task to ensure that clang is doing floating point constant >> folding correctly. > > Could

[PATCH] D87528: Enable '#pragma STDC FENV_ACCESS' in frontend cf. D69272 - Work in Progress

mibintc updated this revision to Diff 291736. mibintc added a comment. This update uses context information from Expr->getFPFeaturesInEffect() to disable fp constant folding in ExprConstant.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87528/ne

[PATCH] D87528: Enable '#pragma STDC FENV_ACCESS' in frontend cf. D69272 - Work in Progress

mibintc updated this revision to Diff 292343. mibintc added a comment. I pulled out the isStrictFP boolean from EvalInfo and used the FPOptions when visiting floating point BinaryOperator, CastExpr and builtin CallExpr. I created the diagnostic note explaining why constant evaluation failed. No

<    1   2   3   4   5   >