> On Dec 4, 2015, at 9:14 AM, Teresa Johnson wrote:
>
> tejohnson added inline comments.
>
>
> Comment at: lib/CodeGen/CodeGenAction.cpp:822
> @@ +821,3 @@
> + TheModule = std::move(Combined);
> +}
> +
>
> joker.eph wrote:
>> tejohnson wrote:
>>> joker
joker.eph accepted this revision.
joker.eph added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
http://reviews.llvm.org/D15025
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
Sent from my iPhone
> On Dec 18, 2015, at 4:06 AM, Rafael Ávila de Espíndola
> wrote:
>
> rafael added a subscriber: rafael.
> rafael added a comment.
>
> This introduces a meaning to -ON during the link. That normally show up by
> people passing CFLAGS when linking.
I'm not sure what you
Sent from my iPhone
> On Dec 18, 2015, at 11:11 PM, James Molloy wrote:
>
> Hi Mehdi,
>
>> On 18 Dec 2015, at 23:17, Mehdi Amini wrote:
>>
>> The alternative to the command line flag is to encode the optimization level
>> in the bitcode itself.
>
> You may have answered Joerg's question h
d be used to change the
pipeline theoretically. It is not a problem at the time since (AFAIK) the
CodeGen pipeline is intrinsically per function, but this may change with the
new instruction selector.
—
Mehdi
>
> James
> On Sat, 19 Dec 2015 at 17:17, Mehdi Amini via cfe-commits
&
https://github.com/joker-eph created
https://github.com/llvm/llvm-project/pull/82296
This is addressing a long-time TODO to rename this misleading API. The old one
is preserved for now but marked deprecated.
>From d381cf98345ff6a817958519a5aa456fbfdea1d2 Mon Sep 17 00:00:00 2001
From: Mehdi Am
https://github.com/joker-eph updated
https://github.com/llvm/llvm-project/pull/82296
>From 8c236920e5eb5703a64cd89a45f2cc89607b96fd Mon Sep 17 00:00:00 2001
From: Mehdi Amini
Date: Mon, 19 Feb 2024 17:34:33 -0800
Subject: [PATCH] Rename `ThreadPool::getThreadCount()` to
`getMaxConcurrency()` (
https://github.com/joker-eph closed
https://github.com/llvm/llvm-project/pull/82296
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
joker-eph wrote:
The premerge config seems broken because of this PR.
https://github.com/llvm/llvm-project/pull/96282
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -322,24 +306,20 @@ struct hash_state {
}
};
-
-/// A global, fixed seed-override variable.
-///
-/// This variable can be set using the \see llvm::set_fixed_execution_seed
-/// function. See that function for details. Do not, under any circumstances,
-/// set or read this
joker-eph wrote:
Hi, thanks for trying to cleanup the codebase.
Can you provide more context on the motivation / what you're trying to achieve
here?
Did you know that LLVM intentionally does not follow IWYU and favors forward
declarations:
https://llvm.org/docs/CodingStandards.html#include-
joker-eph wrote:
> The motivation is as usual IWYU and similar refactoring - to reduce build
> time and probablility of non-related source(s) recompile.
I'm confused: as far as I know IWYU achieves the opposite of what you're
describing actually: it adds more includes than strictly necessary.
https://github.com/joker-eph approved this pull request.
https://github.com/llvm/llvm-project/pull/94886
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
joker-eph wrote:
There is a broken test in CI:
https://lab.llvm.org/buildbot/#/builders/272/builds/17864
https://github.com/llvm/llvm-project/pull/81545
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/lis
joker-eph wrote:
It also fails on Windows:
https://lab.llvm.org/buildbot/#/builders/271/builds/8095
https://github.com/llvm/llvm-project/pull/87018
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo
https://github.com/joker-eph created
https://github.com/llvm/llvm-project/pull/93767
Reverts llvm/llvm-project#87018
MacOS and Windows bots are broken.
>From a35c320e18ba2abad17eab0ed162c4115601a828 Mon Sep 17 00:00:00 2001
From: Mehdi Amini
Date: Wed, 29 May 2024 22:47:35 -0600
Subject: [PAT
https://github.com/joker-eph closed
https://github.com/llvm/llvm-project/pull/93767
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
joker-eph wrote:
Reverted in https://github.com/llvm/llvm-project/pull/93767
(maybe it's just a missing explicit triple in the test?)
https://github.com/llvm/llvm-project/pull/87018
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists
Author: Mehdi Amini
Date: 2024-05-29T21:56:59-07:00
New Revision: 7d4a45d98275e669bda40410f064891beb3480ce
URL:
https://github.com/llvm/llvm-project/commit/7d4a45d98275e669bda40410f064891beb3480ce
DIFF:
https://github.com/llvm/llvm-project/commit/7d4a45d98275e669bda40410f064891beb3480ce.diff
L
joker-eph wrote:
Reverted in 7d4a45d98275e669bda40410f064891beb3480ce ; test is failing like
this on Windows:
```
# RUN: at line 3
c:\ws\buildbot\premerge-monolithic-windows\build\bin\clang.exe -cc1
-internal-isystem
C:\ws\buildbot\premerge-monolithic-windows\build\lib\clang\19\include
-nost
https://github.com/joker-eph approved this pull request.
https://github.com/llvm/llvm-project/pull/94136
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/joker-eph created
https://github.com/llvm/llvm-project/pull/88919
Reverts llvm/llvm-project#87130
Bot is broken with clang crash:
https://lab.llvm.org/buildbot/#/builders/272/builds/14063/steps/6/logs/stdio
>From 271a8c2e5c8f57ab5d37f6056713dab530424470 Mon Sep 17 00:00:0
https://github.com/joker-eph closed
https://github.com/llvm/llvm-project/pull/88919
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
joker-eph wrote:
This broke a bot, I reverted and it's back green here:
https://lab.llvm.org/buildbot/#/builders/272/builds/14069
https://github.com/llvm/llvm-project/pull/87130
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llv
@@ -433,7 +433,7 @@ class LLVM_LIBRARY_VISIBILITY InstCombinerImpl final
Value *foldAndOrOfICmpsOfAndWithPow2(ICmpInst *LHS, ICmpInst *RHS,
Instruction *CxtI, bool IsAnd,
bool IsLogical = false);
-
https://github.com/joker-eph edited
https://github.com/llvm/llvm-project/pull/89294
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/joker-eph created
https://github.com/llvm/llvm-project/pull/89476
Reverts llvm/llvm-project#89378
Broke the windows premerge checks
https://lab.llvm.org/buildbot/#/builders/271/builds/6788
>From 7897826aa7931ffc854a88b20e5ab8bf976ad093 Mon Sep 17 00:00:00 2001
From: Mehdi
https://github.com/joker-eph closed
https://github.com/llvm/llvm-project/pull/89476
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
joker-eph wrote:
This seems to have broken the bot:
https://github.com/llvm/llvm-project/pull/89476 (you should have had an email?)
I reverted in https://github.com/llvm/llvm-project/pull/89476
https://github.com/llvm/llvm-project/pull/89378
___
cfe-
joker-eph wrote:
It seems that this broke the CI:
https://lab.llvm.org/buildbot/#/builders/153/builds/3898
https://github.com/llvm/llvm-project/pull/99898
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/l
joker-eph wrote:
PR should be named according to what they are actually achieving, I'm not sure
why the GitHub issue title is relevant?
https://github.com/llvm/llvm-project/pull/90391
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lis
joker-eph wrote:
CI failed FYI.
https://github.com/llvm/llvm-project/pull/105745
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/joker-eph edited
https://github.com/llvm/llvm-project/pull/105745
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -67,92 +68,123 @@ formatv_object_base::parseReplacementItem(StringRef Spec) {
StringRef Options;
size_t Index = 0;
RepString = RepString.trim();
- if (RepString.consumeInteger(0, Index)) {
-assert(false && "Invalid replacement sequence index!");
-return Replac
https://github.com/joker-eph commented:
Thanks, I'm wondering about the cost of this: what does it do to some
compile-time tests with clang for example?
https://github.com/llvm/llvm-project/pull/105745
___
cfe-commits mailing list
cfe-commits@lists.ll
@@ -67,92 +68,123 @@ formatv_object_base::parseReplacementItem(StringRef Spec) {
StringRef Options;
size_t Index = 0;
RepString = RepString.trim();
- if (RepString.consumeInteger(0, Index)) {
-assert(false && "Invalid replacement sequence index!");
-return Replac
joker-eph wrote:
Possible, let's try it there then
https://github.com/llvm/llvm-project/pull/105745
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
joker-eph wrote:
Having this enabled guarded by NDEBUG seems like a good option. There is
already some things already like this isn't there? I kind of remember that
using imbalanced `{` / `}` pair of something like that was checked only in
assert builds?
https://github.com/llvm/llvm-project/p
@@ -655,7 +655,7 @@ DWARFUnit::GetDIE(dw_offset_t die_offset) {
if (!ContainsDIEOffset(die_offset)) {
GetSymbolFileDWARF().GetObjectFile()->GetModule()->ReportError(
-"GetDIE for DIE {0:x16} is outside of its CU {0:x16}", die_offset,
+"GetDIE for DIE {0:x
https://github.com/joker-eph edited
https://github.com/llvm/llvm-project/pull/105745
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/joker-eph approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/105745
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -143,15 +140,76 @@ formatv_object_base::splitLiteralAndReplacement(StringRef
Fmt) {
return std::make_pair(ReplacementItem{Fmt}, StringRef());
}
+#ifndef NDEBUG
+#define ENABLE_VALIDATION 1
+#else
+#define ENABLE_VALIDATION 1 // Convienently enable validation in release m
https://github.com/joker-eph approved this pull request.
https://github.com/llvm/llvm-project/pull/106454
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
joker-eph wrote:
LG!
https://github.com/llvm/llvm-project/pull/105745
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/joker-eph created
https://github.com/llvm/llvm-project/pull/106589
Reverts llvm/llvm-project#105745
Some bots are broken apparently.
>From 89a7a0b178e406164641e3f88bd5694994b15ba8 Mon Sep 17 00:00:00 2001
From: Mehdi Amini
Date: Thu, 29 Aug 2024 10:29:20 -0700
Subject: [PAT
https://github.com/joker-eph closed
https://github.com/llvm/llvm-project/pull/106589
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
joker-eph wrote:
CI failure wasn't unrelated actually: the CI is consistently broken after this
patch (you have got an email about it?), I'll revert for now.
https://github.com/llvm/llvm-project/pull/91316
___
cfe-commits mailing list
cfe-commits@list
joker-eph wrote:
Actually your premerge failure here was an infra issue, but the CI is still
broken after this PR somehow:
https://lab.llvm.org/buildbot/#/builders/271/builds/7420
https://github.com/llvm/llvm-project/pull/91316
___
cfe-commits mailin
@@ -42,6 +47,14 @@ CreateFrontendBaseAction(CompilerInstance &CI) {
StringRef Action("unknown");
(void)Action;
+ auto UseCIR = CI.getFrontendOpts().UseClangIRPipeline;
joker-eph wrote:
MLIR isn't meant to differ from LLVM/Clang.
> Coding standard doesn'
https://github.com/joker-eph edited
https://github.com/llvm/llvm-project/pull/91007
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Mehdi Amini
Date: 2024-05-14T19:53:38-07:00
New Revision: eb103104ef08ebc2d0de63db0592e76b294cf8bb
URL:
https://github.com/llvm/llvm-project/commit/eb103104ef08ebc2d0de63db0592e76b294cf8bb
DIFF:
https://github.com/llvm/llvm-project/commit/eb103104ef08ebc2d0de63db0592e76b294cf8bb.diff
L
joker-eph wrote:
Seems like a bot is broken:
https://lab.llvm.org/buildbot/#/builders/271/builds/7701 ; can you check?
https://github.com/llvm/llvm-project/pull/90820
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-b
joker-eph wrote:
So are we reverting here or do you have quick fix available?
https://github.com/llvm/llvm-project/pull/90820
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
joker-eph wrote:
Great, thanks for the quick fix!
https://github.com/llvm/llvm-project/pull/90820
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
joker-eph wrote:
You're right, it's visible on the link I posted, the build was already broken!
Somehow I fat-fingered and didn't hit the first red build but the third one!
https://github.com/llvm/llvm-project/pull/90820
___
cfe-commits mailing list
c
https://github.com/joker-eph approved this pull request.
If you can push this to main in separate commits (one per project as it was
mentioned?), that'd be great!
https://github.com/llvm/llvm-project/pull/91857
___
cfe-commits mailing list
cfe-commits
joker-eph wrote:
> It's a sed s/== None/is None/g - what is there to review?
On my I'm not asking for more reviews, this is why I commented that this should
be **pushed** in multiple commits, I don't even need to see PRs.
Another thing also mentioned above was the problem of reverts.
If there
@@ -68,7 +68,7 @@ function compute-projects-to-test() {
done
;;
clang)
- for p in clang-tools-extra compiler-rt flang lldb cross-project-tests; do
+ for p in clang-tools-extra compiler-rt lldb cross-project-tests; do
joker-eph wrote:
Ca
@@ -68,7 +68,7 @@ function compute-projects-to-test() {
done
;;
clang)
- for p in clang-tools-extra compiler-rt flang lldb cross-project-tests; do
+ for p in clang-tools-extra compiler-rt lldb cross-project-tests; do
joker-eph wrote:
Th
https://github.com/joker-eph edited
https://github.com/llvm/llvm-project/pull/92740
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -68,7 +68,7 @@ function compute-projects-to-test() {
done
;;
clang)
- for p in clang-tools-extra compiler-rt flang lldb cross-project-tests; do
+ for p in clang-tools-extra compiler-rt lldb cross-project-tests; do
joker-eph wrote:
>
@@ -68,7 +68,7 @@ function compute-projects-to-test() {
done
;;
clang)
- for p in clang-tools-extra compiler-rt flang lldb cross-project-tests; do
+ for p in clang-tools-extra compiler-rt lldb cross-project-tests; do
joker-eph wrote:
To
https://github.com/joker-eph edited
https://github.com/llvm/llvm-project/pull/92740
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/joker-eph edited
https://github.com/llvm/llvm-project/pull/92740
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -68,7 +68,7 @@ function compute-projects-to-test() {
done
;;
clang)
- for p in clang-tools-extra compiler-rt flang lldb cross-project-tests; do
+ for p in clang-tools-extra compiler-rt lldb cross-project-tests; do
joker-eph wrote:
>
joker-eph wrote:
What part of the "camelBack" is visible to the user of the API?
(and in general the method prototype in the header should likely use the same
parameter names as the implementation file)
https://github.com/llvm/llvm-project/pull/91007
___
https://github.com/joker-eph created
https://github.com/llvm/llvm-project/pull/96388
Reverts llvm/llvm-project#95025 ; many bots are broken
>From b9ceb93bc8d7fe75365f0d9002ed8b48a0884c85 Mon Sep 17 00:00:00 2001
From: Mehdi Amini
Date: Sat, 22 Jun 2024 14:18:31 +0200
Subject: [PATCH] =?UTF-8?q
https://github.com/joker-eph closed
https://github.com/llvm/llvm-project/pull/96388
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -231,6 +245,10 @@ linux_projects_to_test=$(exclude-linux
$(compute-projects-to-test ${modified_pro
linux_check_targets=$(check-targets ${linux_projects_to_test} | sort | uniq)
linux_projects=$(add-dependencies ${linux_projects_to_test} | sort | uniq)
+linux_runtimes_to_tes
@@ -231,6 +245,10 @@ linux_projects_to_test=$(exclude-linux
$(compute-projects-to-test ${modified_pro
linux_check_targets=$(check-targets ${linux_projects_to_test} | sort | uniq)
linux_projects=$(add-dependencies ${linux_projects_to_test} | sort | uniq)
+linux_runtimes_to_tes
https://github.com/joker-eph edited
https://github.com/llvm/llvm-project/pull/93318
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -231,6 +245,10 @@ linux_projects_to_test=$(exclude-linux
$(compute-projects-to-test ${modified_pro
linux_check_targets=$(check-targets ${linux_projects_to_test} | sort | uniq)
linux_projects=$(add-dependencies ${linux_projects_to_test} | sort | uniq)
+linux_runtimes_to_tes
joker-eph wrote:
I don't quite follow the motivation for this, can you expand on this in the
description please? Right now this seems unnecessary for the changes I can see
in MLIR for example.
https://github.com/llvm/llvm-project/pull/126243
___
cfe-
joker-eph wrote:
> The linked bug seems to explain it, I think?
I don't actually see a description of what is the problem to solve really.
> It seems to be the usual "if something isn't/doesn't need to be declared in a
> header, then it should be file-local static, so as to not conflict with
401 - 474 of 474 matches
Mail list logo
