[PATCH] D25624: Added 'inline' attribute to basic_string's destructor

mehdi_amini added a comment. I think @EricWF already committed the patch with just the inline keyword? https://reviews.llvm.org/D25624 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26376: Undef stdatomic.h macro definitions that are defining functions provided in libc++

mehdi_amini created this revision. mehdi_amini added a reviewer: rsmith. mehdi_amini added a subscriber: cfe-commits. This solved compiling: #include #include https://reviews.llvm.org/D26376 Files: libcxx/include/atomic Index: libcxx/include/atomic ===

[PATCH] D24183: A clang tool for changing surrouding namespaces of class/function definitions.

mehdi_amini added inline comments. Comment at: clang-tools-extra/trunk/change-namespace/ChangeNamespace.cpp:396 + // Calculate the name of the `NsDecl` after it is moved to new namespace. + std::string OldNs = NsDecl->getQualifiedNameAsString(); + llvm::StringRef Postfix = Old

[PATCH] D26522: Improve handling of __FUNCTION__ and other predefined expression for Objective-C Blocks

mehdi_amini created this revision. mehdi_amini added a reviewer: arphaman. mehdi_amini added a subscriber: cfe-commits. Instead of always displaying the mangled name, try to do better and get something closer to regular functions. https://reviews.llvm.org/D26522 Files: clang/lib/AST/Expr.cpp

Re: r286534 - PR30937: don't devirtualize if we find that the callee is a pure virtual

Could we emit llvm.unreachable in this case? — Mehdi > On Nov 10, 2016, at 5:01 PM, Richard Smith via cfe-commits > wrote: > > Author: rsmith > Date: Thu Nov 10 19:01:31 2016 > New Revision: 286534 > > URL: http://llvm.org/viewvc/llvm-project?rev=286534&view=rev > Log: > PR30937: don't devir

Re: r286534 - PR30937: don't devirtualize if we find that the callee is a pure virtual

Thinking again, the method “can” be implemented I think. Forget it… — Mehdi > On Nov 10, 2016, at 6:11 PM, Mehdi Amini wrote: > > Could we emit llvm.unreachable in this case? > > — > Mehdi > >> On Nov 10, 2016, at 5:01 PM, Richard Smith via cfe-commits >> wrote: >> >> Author: rsmith >> D

[PATCH] D24289: Add warning when assigning enums to bitfields without an explicit unsigned underlying type

mehdi_amini added a comment. > So when this modification tells the developer to add 'unsigned' to their > enum, they are subsequently causing a warning to occur in GCC. > > I have commented on the bug on GCC for this > (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=51242#c28), but it looks > un

[PATCH] D26522: Improve handling of __FUNCTION__ and other predefined expression for Objective-C Blocks

mehdi_amini updated this revision to Diff 77680. mehdi_amini marked 3 inline comments as done. mehdi_amini added a comment. Address Alex's comment. https://reviews.llvm.org/D26522 Files: clang/lib/AST/Expr.cpp clang/lib/CodeGen/CGExpr.cpp clang/test/CodeGen/block-with-perdefinedexpr.cpp

[PATCH] D26522: Improve handling of __FUNCTION__ and other predefined expression for Objective-C Blocks

mehdi_amini updated this revision to Diff 77681. mehdi_amini added a comment. Fix warning for unused variable https://reviews.llvm.org/D26522 Files: clang/lib/AST/Expr.cpp clang/lib/CodeGen/CGExpr.cpp clang/test/CodeGen/block-with-perdefinedexpr.cpp clang/test/CodeGenCXX/predefined-expr

[PATCH] D26522: Improve handling of __FUNCTION__ and other predefined expression for Objective-C Blocks

mehdi_amini updated this revision to Diff 77682. mehdi_amini added a comment. Add a test inside a lambda https://reviews.llvm.org/D26522 Files: clang/lib/AST/Expr.cpp clang/lib/CodeGen/CGExpr.cpp clang/test/CodeGen/block-with-perdefinedexpr.cpp clang/test/CodeGenCXX/predefined-expr-cxx1

r286696 - Add instructions in clang get_started page about working with a monorepo

Author: mehdi_amini Date: Fri Nov 11 19:18:17 2016 New Revision: 286696 URL: http://llvm.org/viewvc/llvm-project?rev=286696&view=rev Log: Add instructions in clang get_started page about working with a monorepo Modified: cfe/trunk/www/get_started.html Modified: cfe/trunk/www/get_started.html

r247179 - EmitRecordWith* API change: takes an ArrayRef instead of a SmallVector (NFC)

Author: mehdi_amini Date: Wed Sep 9 15:08:51 2015 New Revision: 247179 URL: http://llvm.org/viewvc/llvm-project?rev=247179&view=rev Log: EmitRecordWith* API change: takes an ArrayRef instead of a SmallVector (NFC) From: Mehdi Amini Modified: cfe/trunk/include/clang/Serialization/ASTWriter.

Re: r247179 - EmitRecordWith* API change: takes an ArrayRef instead of a SmallVector (NFC)

Hi David, Thanks for the review. > On Sep 9, 2015, at 1:14 PM, David Blaikie wrote: > > > > On Wed, Sep 9, 2015 at 1:08 PM, Mehdi Amini via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: > Author: mehdi_amini > Date: Wed Sep 9 15:08:51 2015 > Ne

r247183 - Revert "EmitRecordWith* API change: takes an ArrayRef instead of a SmallVector (NFC)"

Author: mehdi_amini Date: Wed Sep 9 15:35:37 2015 New Revision: 247183 URL: http://llvm.org/viewvc/llvm-project?rev=247183&view=rev Log: Revert "EmitRecordWith* API change: takes an ArrayRef instead of a SmallVector (NFC)" This reverts commit r247179. From: Mehdi Amini Modified: cfe/trun

Re: r247179 - EmitRecordWith* API change: takes an ArrayRef instead of a SmallVector (NFC)

o:dblai...@gmail.com>> wrote: >> >> >> >> On Wed, Sep 9, 2015 at 1:08 PM, Mehdi Amini via cfe-commits >> mailto:cfe-commits@lists.llvm.org>> wrote: >> Author: mehdi_amini >> Date: Wed Sep 9 15:08:51 2015 >> New Revision: 247179 &

r247233 - EmitRecord* API change: accepts ArrayRef instead of a SmallVector (NFC)

Author: mehdi_amini Date: Wed Sep 9 20:46:39 2015 New Revision: 247233 URL: http://llvm.org/viewvc/llvm-project?rev=247233&view=rev Log: EmitRecord* API change: accepts ArrayRef instead of a SmallVector (NFC) This reapply a variant commit r247179 after post-commit review from D.Blaikie. Hopefull

Re: r247233 - EmitRecord* API change: accepts ArrayRef instead of a SmallVector (NFC)

> On Sep 9, 2015, at 7:06 PM, David Blaikie wrote: > > > > On Wed, Sep 9, 2015 at 6:46 PM, Mehdi Amini via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: > Author: mehdi_amini > Date: Wed Sep 9 20:46:39 2015 > New Revision: 247233 > > URL:

Re: r247233 - EmitRecord* API change: accepts ArrayRef instead of a SmallVector (NFC)

> On Sep 10, 2015, at 9:02 AM, David Blaikie wrote: > > > > On Thu, Sep 10, 2015 at 9:00 AM, Mehdi Amini <mailto:mehdi.am...@apple.com>> wrote: > >> On Sep 9, 2015, at 7:06 PM, David Blaikie > <mailto:dblai...@gmail.com>> wrote: >> >>

Re: [PATCH] D11908: Clang support for -fthinlto.

joker.eph accepted this revision. joker.eph added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D11908 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/

Re: [clang-tools-extra] r275886 - Unbreak extra tools build post r275882.

Thanks, I just checked out clang-tool-extras and was in the process of doing that :) — Mehdi > On Jul 18, 2016, at 12:21 PM, Benjamin Kramer via cfe-commits > wrote: > > Author: d0k > Date: Mon Jul 18 14:21:22 2016 > New Revision: 275886 > > URL: http://llvm.org/viewvc/llvm-project?rev=2758

Re: [PATCH] D22463: [RFC] Moving to GitHub Proposal: NOT DECISION!

mehdi_amini added a subscriber: mehdi_amini. Comment at: docs/Proposals/GitHub.rst:122 @@ +121,3 @@ +of understanding the *sequence* in which commits were added by using the +``git rev-list --count hash`` or ``git describe hash`` commands. + filcab wrote: > How ea

Re: [PATCH] D22463: [RFC] Moving to GitHub Proposal: NOT DECISION!

mehdi_amini added inline comments. Comment at: docs/Proposals/GitHub.rst:199 @@ +198,3 @@ + +Here's a proposed plan: + Annoyingly my comment does no longer show-up next to the point it was referring to, it was about your third point: > Make sure we have an llvm-

Re: [PATCH] D22463: [RFC] Moving to GitHub Proposal: NOT DECISION!

mehdi_amini added inline comments. Comment at: docs/Proposals/GitHub.rst:208 @@ +207,3 @@ +3. Make sure we have an llvm-project (with submodules) setup in the official + account, with all necessary hooks (history, update, merges). +4. Make sure bisecting with llvm-project works.

r275906 - Add missing header in ClangFuzzer (after r275882 cleanup)

Author: mehdi_amini Date: Mon Jul 18 15:33:09 2016 New Revision: 275906 URL: http://llvm.org/viewvc/llvm-project?rev=275906&view=rev Log: Add missing header in ClangFuzzer (after r275882 cleanup) Modified: cfe/trunk/tools/clang-fuzzer/ClangFuzzer.cpp Modified: cfe/trunk/tools/clang-fuzzer/Cl

Re: [PATCH] D22463: [RFC] Moving to GitHub Proposal: NOT DECISION!

mehdi_amini added inline comments. Comment at: docs/Proposals/GitHub.rst:209 @@ +208,3 @@ + well as a webhook to update the umbrella project (see below). +3. Make sure we have an llvm-project (with submodules) setup in the official + account, with all necessary hooks (history,

Re: [PATCH] D22463: [RFC] Moving to GitHub Proposal: NOT DECISION!

mehdi_amini added inline comments. Comment at: docs/Proposals/GitHub.rst:209 @@ +208,3 @@ + well as a webhook to update the umbrella project (see below). +3. Make sure we have an llvm-project (with submodules) setup in the official + account, with all necessary hooks (history,

Re: [PATCH] D22463: [RFC] Moving to GitHub Proposal: NOT DECISION!

> On Jul 18, 2016, at 8:23 PM, Tim Northover via cfe-commits > wrote: > >>> Can't handle the update of the umbrella *because of GitHub*, this could be >>> possible with our own hosting of git for instance. >>> >> Pre-commit hooks are not designed to update the umbrella. Webhooks will be >> a

Re: [PATCH] D22555: [Clang] Fix RHEL 6 build and other Include What You Use warnings

mehdi_amini added inline comments. Comment at: lib/Basic/FileManager.cpp:35 @@ -29,2 +34,3 @@ #include +#include That's a lot of includes though. Ok for the climits, but the other should be a separate patch I think. Repository: rL LLVM https://reviews.l

Re: [PATCH] D22555: [Clang] Fix RHEL 6 build and other Include What You Use warnings

I'm not necessarily disagreeing, I'm saying that if I understand correctly, there are two unrelated changes (one is a build fix, and the other is a "good practice" kind of change). > On Jul 19, 2016, at 6:43 PM, Eugene Zelenko wrote: > > Eugene.Zelenko added a comment. > > But all of them are

Re: [PATCH] D22596: Retry: [Driver] Compute effective target triples once per job (NFCI)

mehdi_amini added inline comments. Comment at: include/clang/Driver/ToolChain.h:71 @@ -70,2 +70,3 @@ const llvm::Triple Triple; + mutable llvm::Triple EffectiveTriple; const llvm::opt::ArgList &Args; Documentation would be appreciated, a mutable field is ne

Re: r276361 - Reverting r275115 which caused PR28634.

> On Jul 21, 2016, at 4:28 PM, Wolfgang Pieb via cfe-commits > wrote: > > Author: wolfgangp > Date: Thu Jul 21 18:28:18 2016 > New Revision: 276361 > > URL: http://llvm.org/viewvc/llvm-project?rev=276361&view=rev > Log: > Reverting r275115 which caused PR28634. > When empty (forwarding) basic

[libcxxabi] r278579 - Fix ASAN failures in the demangler

Author: mehdi_amini Date: Fri Aug 12 19:02:33 2016 New Revision: 278579 URL: http://llvm.org/viewvc/llvm-project?rev=278579&view=rev Log: Fix ASAN failures in the demangler These were found fuzzing with ASAN. Modified: libcxxabi/trunk/src/cxa_demangle.cpp libcxxabi/trunk/test/test_demang

Re: [libcxxabi] r278579 - Fix ASAN failures in the demangler

> Did you fix all of the known crashers? > > > > On Fri, Aug 12, 2016 at 5:02 PM, Mehdi Amini via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: > Author: mehdi_amini > Date: Fri Aug 12 19:02:33 2016 > New Revision: 278579 > > URL: http://

Re: [libcxxabi] r278579 - Fix ASAN failures in the demangler

CC hans. > On Aug 12, 2016, at 5:50 PM, Duncan P. N. Exon Smith > wrote: > > This seems like a good candidate to cherry-pick to 3.9. > >> On 2016-Aug-12, at 17:02, Mehdi Amini via cfe-commits >> wrote: >> >> Author: mehdi_amini >> D

Re: [PATCH] D17130: Debloat some headers

joker.eph added a subscriber: joker.eph. joker.eph added a comment. What the build time of clang before and after? (Your goal is to improve build time right?) http://reviews.llvm.org/D17130 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D17272: Teach clang to use the ThinLTO pipeline

joker.eph created this revision. joker.eph added a reviewer: tejohnson. joker.eph added a subscriber: cfe-commits. Herald added a subscriber: joker.eph. Use the new pipeline implemented in D17115 http://reviews.llvm.org/D17272 Files: lib/CodeGen/BackendUtil.cpp Index: lib/CodeGen/BackendUtil.

r261045 - Teach clang to use the ThinLTO pipeline

Author: mehdi_amini Date: Tue Feb 16 18:42:20 2016 New Revision: 261045 URL: http://llvm.org/viewvc/llvm-project?rev=261045&view=rev Log: Teach clang to use the ThinLTO pipeline Summary: Use the new pipeline implemented in D17115 Reviewers: tejohnson Subscribers: joker.eph, cfe-commits Differe

Re: [PATCH] D17272: Teach clang to use the ThinLTO pipeline

joker.eph closed this revision. joker.eph added a comment. r261045 http://reviews.llvm.org/D17272 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16821: Add whole-program vtable optimization feature to Clang.

> On Feb 22, 2016, at 3:47 PM, Peter Collingbourne wrote: > > On Mon, Feb 22, 2016 at 01:38:27PM -0800, Pete Cooper wrote: >> >>> On Feb 22, 2016, at 1:30 PM, Peter Collingbourne wrote: >>> >>> One thing that I'd like to do (and this would help CFI as well) is to >>> specifically recognize c

Re: [PATCH] D20374: [Driver] Fix the case when use -fembed-bitcode and -flto= together

joker.eph accepted this revision. joker.eph added a comment. This revision is now accepted and ready to land. LGTM. http://reviews.llvm.org/D20374 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

[PATCH] D18947: Emit the module hash by default with -flto=thin.

joker.eph created this revision. joker.eph added a reviewer: tejohnson. joker.eph added a subscriber: cfe-commits. Herald added a subscriber: joker.eph. http://reviews.llvm.org/D18947 Files: lib/CodeGen/BackendUtil.cpp Index: lib/CodeGen/BackendUtil.cpp

r265977 - Emit the module hash by default with -flto=thin.

Author: mehdi_amini Date: Mon Apr 11 13:45:20 2016 New Revision: 265977 URL: http://llvm.org/viewvc/llvm-project?rev=265977&view=rev Log: Emit the module hash by default with -flto=thin. Reviewers: tejohnson Subscribers: joker.eph, cfe-commits Differential Revision: http://reviews.llvm.org/D189

Re: [PATCH] D18947: Emit the module hash by default with -flto=thin.

joker.eph closed this revision. joker.eph added a comment. r265977 http://reviews.llvm.org/D18947 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r266276 - Do not use llvm:getGlobalContext() in unittests

Author: mehdi_amini Date: Thu Apr 14 00:34:32 2016 New Revision: 266276 URL: http://llvm.org/viewvc/llvm-project?rev=266276&view=rev Log: Do not use llvm:getGlobalContext() in unittests Currently trying to nuke this API from LLVM. From: Mehdi Amini Modified: cfe/trunk/unittests/CodeGen/Buf

r266277 - Make sure the LLVMContext outlive the CompilerInstance

Author: mehdi_amini Date: Thu Apr 14 00:37:41 2016 New Revision: 266277 URL: http://llvm.org/viewvc/llvm-project?rev=266277&view=rev Log: Make sure the LLVMContext outlive the CompilerInstance From: Mehdi Amini Modified: cfe/trunk/unittests/CodeGen/BufferSourceTest.cpp Modified: cfe/trunk/

Re: r266276 - Do not use llvm:getGlobalContext() in unittests

> On Apr 14, 2016, at 4:38 AM, Rafael Espíndola > wrote: > > On 14 April 2016 at 01:34, Mehdi Amini via cfe-commits > wrote: >> Author: mehdi_amini >> Date: Thu Apr 14 00:34:32 2016 >> New Revision: 266276 >> >> URL: http://llvm.org/viewvc/llvm-

r266525 - Add missing headers (fix build after headers cleanup in LLVM)

Author: mehdi_amini Date: Sat Apr 16 03:14:10 2016 New Revision: 266525 URL: http://llvm.org/viewvc/llvm-project?rev=266525&view=rev Log: Add missing headers (fix build after headers cleanup in LLVM) From: Mehdi Amini Modified: cfe/trunk/include/clang/Lex/LiteralSupport.h Modified: cfe/tru

r266594 - Add missing include for StringRef (NFC)

Author: mehdi_amini Date: Mon Apr 18 04:08:59 2016 New Revision: 266594 URL: http://llvm.org/viewvc/llvm-project?rev=266594&view=rev Log: Add missing include for StringRef (NFC) From: Mehdi Amini Modified: cfe/trunk/lib/Format/Encoding.h Modified: cfe/trunk/lib/Format/Encoding.h URL: http

r267321 - Make thinlto clang test more robust against LLVM changes.

Author: mehdi_amini Date: Sat Apr 23 22:44:55 2016 New Revision: 267321 URL: http://llvm.org/viewvc/llvm-project?rev=267321&view=rev Log: Make thinlto clang test more robust against LLVM changes. We should just test the effect of the clang level option here, i.e. that a summary is correctly emitt

Re: [PATCH] D20423: [Clang][LLVMGold] Passing LLVM arguments to gold plugin

mehdi_amini added a comment. In http://reviews.llvm.org/D20423#440539, @bunty2020 wrote: > Clang's help shows the following description: > **-mllvm Additional arguments to forward to LLVM's option > processing** > > If -mllvm sets some internal option for cc1 then its strange > for

Re: [PATCH] D21006: [Driver] Make -flto -S emit assembly

mehdi_amini added a comment. I'm not sure it is consistent with how we handle -flto, for instance -c means usually to output an object file, but adding -flto indicates to dump bitcode instead. http://reviews.llvm.org/D21006 ___ cfe-commits mailing

Re: [PATCH] D21006: [Driver] Make -flto -S emit assembly

mehdi_amini added a comment. Duncan CC for opinion. http://reviews.llvm.org/D21006 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21006: [Driver] Make -flto -S emit assembly

mehdi_amini added a comment. What makes me not comfortable with this change is that after that `-c` would not involves codegen but `-S` would. Indeed I am using sometimes `-flto -S` and I expect IR, that's what is the most logical to me considering what -c does. http://reviews.llvm.org/D21006

Re: [PATCH] D21006: [Driver] Make -flto -S emit assembly

But what pipeline do we setup? For instance with ThinLTO we reduced the amount of passes ran during the compile phase with the expectation that more will run during the link, this would get fuzzy here... > On Jun 5, 2016, at 6:49 PM, Davide Italiano wrote: > > davide added a comment. > > In h

Re: [PATCH] D21006: [Driver] Make -flto -S emit assembly

mehdi_amini added a comment. But what pipeline do we setup? For instance with ThinLTO we reduced the amount of passes ran during the compile phase with the expectation that more will run during the link, this would get fuzzy here... http://reviews.llvm.org/D21006 ___

Re: r271883 - [clang-format] make header guard identification stricter (with Lexer).

Hi Eric, > On Jun 6, 2016, at 4:00 AM, Eric Liu via cfe-commits > wrote: > > Author: ioeric > Date: Mon Jun 6 06:00:13 2016 > New Revision: 271883 > > URL: http://llvm.org/viewvc/llvm-project?rev=271883&view=rev > Log: > [clang-format] make header guard identification stricter (with Lexer). >

Re: [PATCH] D21277: Resubmit r270688: Using new TargetParser in Clang.

mehdi_amini added a comment. Why was it closed? Was it committed? It'd be nice to have a comment with the closing action. Repository: rL LLVM http://reviews.llvm.org/D21277 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llv

Re: [PATCH] D21737: [PATCH] [CodeGen] Insert TargetLibraryInfoWrapperPass before anything else.

mehdi_amini requested changes to this revision. mehdi_amini added a comment. This revision now requires changes to proceed. Missing test. Repository: rL LLVM http://reviews.llvm.org/D21737 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

Re: [PATCH] D21737: [PATCH] [CodeGen] Insert TargetLibraryInfoWrapperPass before anything else.

mehdi_amini added inline comments. Comment at: lib/CodeGen/BackendUtil.cpp:459 @@ -456,2 +458,3 @@ legacy::FunctionPassManager *FPM = getPerFunctionPasses(); + FPM->add(new TargetLibraryInfoWrapperPass(*TLII)); if (CodeGenOpts.VerifyModule) It is not super

Re: [PATCH] D21619: [Sema] Implement C++14's DR1579: Prefer moving id-expression out of functions

mehdi_amini added a subscriber: mehdi_amini. mehdi_amini added a comment. Is it also PR23849? Is it dup with PR27785? Repository: rL LLVM http://reviews.llvm.org/D21619 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org

Re: [PATCH] D15926: Do not print certain warnings when input is a header.

mehdi_amini added inline comments. Comment at: include/clang/Basic/LangOptions.h:131 @@ +130,3 @@ + /// input is a header file (i.e. -x c-header). + bool IsHeaderFile = false; + aaron.ballman wrote: > Should move the initializer to the constructor (not certain t

Re: [PATCH] D11360: Proposed patch to prevent the creation of empty (forwarding) blocks resulting from nested ifs.

mehdi_amini added inline comments. Comment at: lib/CodeGen/CGStmt.cpp:614 @@ -610,1 +613,3 @@ + SimplifyForwardingBlocks(CurBlock); + } Document Comment at: lib/CodeGen/CGStmt.cpp:633 @@ -626,1 +632,3 @@ + if (CurBlock) +Sim

Re: [PATCH] D21753: Comprehensive Static Instrumentation (2/2): Clang flag

mehdi_amini added inline comments. Comment at: docs/CSI.rst:46 @@ +45,3 @@ +allows the LTO to later elide hooks irrelevant to the tool entirely from the +program-under-test. + The long thread on llvm-dev went to conclude that LTO should not be needed. ===

Re: [PATCH] D21753: Comprehensive Static Instrumentation (2/2): Clang flag

mehdi_amini added inline comments. Comment at: docs/CSI.rst:78 @@ +77,3 @@ +Notice that in the final stage of linking, the tool user also needs to link in +the static library of the CSI runtime to produce the final TIX. The runtime +archive is distributed under the ``build/lib/cl

Re: [PATCH] D11360: Proposed patch to prevent the creation of empty (forwarding) blocks resulting from nested ifs.

mehdi_amini accepted this revision. mehdi_amini added a reviewer: mehdi_amini. mehdi_amini added a comment. This revision is now accepted and ready to land. LGTM. http://reviews.llvm.org/D11360 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D20100: [NFC] Header cleanup

mehdi_amini accepted this revision. mehdi_amini added a comment. This revision is now accepted and ready to land. Looks like a nice cleanup. http://reviews.llvm.org/D20100 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org

Re: [PATCH] D11360: Proposed patch to prevent the creation of empty (forwarding) blocks resulting from nested ifs.

mehdi_amini added a comment. This is committed r275115 for the record. Phabricator will automatically close it if the last line is "Differential Revision: ..." (You put "Differential review: ..." instead). http://reviews.llvm.org/D11360 ___ cfe-co

Re: [PATCH] D21545: CodeGen: Replace ThinLTO backend implementation with a client of LTO/Resolution.

mehdi_amini added inline comments. Comment at: lib/CodeGen/BackendUtil.cpp:740 @@ +739,3 @@ + ComputeCrossModuleImportForModule(M->getModuleIdentifier(), *CombinedIndex, +ImportList); + This should go away at some point right?

Re: [PATCH] D21545: CodeGen: Replace ThinLTO backend implementation with a client of LTO/Resolution.

mehdi_amini accepted this revision. mehdi_amini added a comment. (I didn't mark it as accepted because Teresa did, but in case you're waiting for me, don't) https://reviews.llvm.org/D21545 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

Re: [PATCH] D20100: [NFC] Header cleanup

mehdi_amini added a comment. Can you rebase? I can't apply it right now. https://reviews.llvm.org/D20100 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D18014: Allows to build libc++ with -DLLVM_USE_SANITIZER="Address; Undefined" on OSX

joker.eph created this revision. joker.eph added a reviewer: beanz. joker.eph added a subscriber: cfe-commits. joker.eph set the repository for this revision to rL LLVM. It seems some cases were missing to the configuration. Repository: rL LLVM http://reviews.llvm.org/D18014 Files: lib/CMak

Re: [PATCH] D18014: Allows to build libc++ with -DLLVM_USE_SANITIZER="Address;Undefined" on OSX

Thanks, that's a lot cleaner indeed. I'll update. -- Mehdi > On Mar 9, 2016, at 4:02 PM, Chris Bieneman wrote: > > beanz added inline comments. > > > Comment at: lib/CMakeLists.txt:51 > @@ -50,2 +50,3 @@ > if (APPLE AND LLVM_USE_SANITIZER) > - if ("${LLVM_USE_SANITIZER}" ST

[PATCH] D18024: Remove compile time PreserveName switch based on NDEBUG

joker.eph created this revision. joker.eph added a reviewer: chandlerc. joker.eph added a subscriber: cfe-commits. Following r263086, we are now relying on a flag on the Context to discard Value names in release builds. http://reviews.llvm.org/D18024 Files: lib/CodeGen/CGBuilder.h lib/CodeGe

Re: [PATCH] D18024: Remove compile time PreserveName switch based on NDEBUG

joker.eph added inline comments. Comment at: lib/CodeGen/CodeGenAction.cpp:660-663 @@ -660,1 +659,6 @@ + OwnsVMContext(!_VMContext) { +#ifdef NDEBUG + _VMContext.setDiscardValueNames(true); +#endif +} chandlerc wrote: > I'm surprised this isn't a driver-si

Re: [PATCH] D18024: Remove compile time PreserveName switch based on NDEBUG

joker.eph updated this revision to Diff 50282. joker.eph added a comment. Add a FIXME to change the compile time switch to a runtime command line flag http://reviews.llvm.org/D18024 Files: lib/CodeGen/CGBuilder.h lib/CodeGen/CGCall.cpp lib/CodeGen/CGExpr.cpp lib/CodeGen/CodeGenAction.cp

r263257 - Remove compile time PreserveName switch based on NDEBUG

Author: mehdi_amini Date: Fri Mar 11 11:15:44 2016 New Revision: 263257 URL: http://llvm.org/viewvc/llvm-project?rev=263257&view=rev Log: Remove compile time PreserveName switch based on NDEBUG Summary: Following r263086, we are now relying on a flag on the Context to discard Value names in relea

r263267 - Fix build: use -> with pointers and not .

Author: mehdi_amini Date: Fri Mar 11 11:32:58 2016 New Revision: 263267 URL: http://llvm.org/viewvc/llvm-project?rev=263267&view=rev Log: Fix build: use -> with pointers and not . Silly typo. From: Mehdi Amini Modified: cfe/trunk/lib/CodeGen/CodeGenAction.cpp Modified: cfe/trunk/lib/CodeG

r263273 - Fix clang crash: when CodeGenAction is initialized without a context, use the member and not the parameter

Author: mehdi_amini Date: Fri Mar 11 12:48:02 2016 New Revision: 263273 URL: http://llvm.org/viewvc/llvm-project?rev=263273&view=rev Log: Fix clang crash: when CodeGenAction is initialized without a context, use the member and not the parameter From: Mehdi Amini Modified: cfe/trunk/lib/Cod

[PATCH] D18127: Remove compile time PreserveName in favor of a runtime cc1 -discard-value-names option

joker.eph created this revision. joker.eph added reviewers: echristo, chandlerc. joker.eph added a subscriber: cfe-commits. This flag is enabled by default in the driver when NDEBUG is set. It is forwarded on the LLVMContext to discard all value names (but GlobalValue) for performance purpose. Th

Re: [PATCH] D18127: Remove compile time PreserveName in favor of a runtime cc1 -discard-value-names option

joker.eph updated this revision to Diff 50541. joker.eph added a comment. Use cc1 in the few tests that were relying on value names. Also add test/CodeGenCXX/discard-name-values.cpp to test the new cc1 flag. http://reviews.llvm.org/D18127 Files: include/clang/Driver/CC1Options.td include/c

Re: [PATCH] D18127: Remove compile time PreserveName in favor of a runtime cc1 -discard-value-names option

joker.eph updated this revision to Diff 50546. joker.eph added a comment. s/clang -cc1/%clang_cc1/ http://reviews.llvm.org/D18127 Files: include/clang/Driver/CC1Options.td include/clang/Frontend/CodeGenOptions.def lib/CodeGen/CGBuilder.h lib/CodeGen/CGCall.cpp lib/CodeGen/CGExpr.cpp

r263394 - Remove compile time PreserveName in favor of a runtime cc1 -discard-value-names option

Author: mehdi_amini Date: Sun Mar 13 16:05:23 2016 New Revision: 263394 URL: http://llvm.org/viewvc/llvm-project?rev=263394&view=rev Log: Remove compile time PreserveName in favor of a runtime cc1 -discard-value-names option Summary: This flag is enabled by default in the driver when NDEBUG is s

Re: [PATCH] D18127: Remove compile time PreserveName in favor of a runtime cc1 -discard-value-names option

joker.eph closed this revision. joker.eph added a comment. r263394 http://reviews.llvm.org/D18127 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17893: Sema: Add semantic analysis for the C++ ABI stability attributes and whitelist.

joker.eph added a comment. LGTM, but I'm not a clang expert, so if Richard or someone else could double-check? Comment at: lib/Sema/SemaDeclCXX.cpp:4999 @@ +4998,3 @@ +return; + } + Isn't this correct by the loop which starts with `DC = InnermostExternalDC

Re: [PATCH] D18024: Remove compile time PreserveName switch based on NDEBUG

joker.eph closed this revision. joker.eph added a comment. r263257 http://reviews.llvm.org/D18024 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17893: Sema: Add semantic analysis for the C++ ABI stability attributes and whitelist.

joker.eph added inline comments. Comment at: lib/Sema/SemaDeclCXX.cpp:4999 @@ +4998,3 @@ +return; + } + joker.eph wrote: > Isn't this correct by the loop which starts with `DC = InnermostExternalDC`? `s/correct/already covered/` http://reviews.llvm.org/D178

Re: [PATCH] D17893: Sema: Add semantic analysis for the C++ ABI stability attributes and whitelist.

joker.eph added inline comments. Comment at: lib/Sema/SemaDeclCXX.cpp:4999 @@ +4998,3 @@ +return; + } + pcc wrote: > joker.eph wrote: > > joker.eph wrote: > > > Isn't this correct by the loop which starts with `DC = > > > InnermostExternalDC`? > > `s/correct

Re: r264417 - [ASTMatchers] Add own version of VariadicFunction.

Hi, I think this broke clang-tidy somehow: http://lab.llvm.org:8011/builders/clang-x64-ninja-win7/builds/10881/steps/build%20stage%201/logs/stdio -- Mehdi > On Mar 25, 2016, at 9:29 AM, Samuel Benzaquen via cfe-commits > wrote: > > Author: sbenza > Date: Fri Mar 25 11:29:30 2016 > New Re

Re: r264417 - [ASTMatchers] Add own version of VariadicFunction.

The link I provided is testing r264430... -- Mehdi > On Mar 25, 2016, at 12:25 PM, Samuel Benzaquen wrote: > > I believe r264428 fixes this problem. > > On Fri, Mar 25, 2016 at 2:18 PM, Mehdi Amini > wrote: > Hi, > > I think this broke clang-tidy somehow: > ht

Re: r264417 - [ASTMatchers] Add own version of VariadicFunction.

Thanks! > On Mar 25, 2016, at 12:47 PM, Samuel Benzaquen wrote: > > Fixed in r264453. > Sorry for the inconvenience. > > _Sam > > On Fri, Mar 25, 2016 at 3:31 PM, Samuel Benzaquen > wrote: > Sorry, this is an unrelated problem. > It is using brace-init lists and the

Re: [PATCH] D15926: Do not print certain warnings when input is a header.

joker.eph added a subscriber: joker.eph. Comment at: include/clang/Basic/SourceManager.h:660 @@ -659,1 +659,3 @@ + bool MainFileIsHeader = false; + Document? Comment at: include/clang/Basic/SourceManager.h:764 @@ -761,1 +763,3 @@ + void set

Re: [PATCH] D16056: [Gold] Pass -mllvm options to the gold plugin

I’d fear the same thing. On our platform you have to use explicitly -Wl,-mllvm (or -Xlinker -plugin-opt). — Mehdi > On Jan 11, 2016, at 4:11 PM, Rafael Espíndola > wrote: > > Maybe. I would like a second opinion on this one. The potential issue > I see is that we are using compiler options

Re: [PATCH] D14804: [clang] Disable Unicode in asm files

joker.eph added a comment. Isn't the patch reversed or do I miss something? Repository: rL LLVM http://reviews.llvm.org/D14804 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D14804: [clang] Disable Unicode in asm files

joker.eph added a comment. LGTM, please wait for another pair of eye. Repository: rL LLVM http://reviews.llvm.org/D14804 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15025: [ThinLTO] Option to invoke ThinLTO backend passes and importing

joker.eph added inline comments. Comment at: lib/CodeGen/BackendUtil.cpp:308 @@ +307,3 @@ +return; + } + It does not seem to be nicely integrated within the context of this function. What about all the options set just a few line below? It is not clear if `

Re: [PATCH] D15025: [ThinLTO] Option to invoke ThinLTO backend passes and importing

joker.eph added inline comments. Comment at: lib/CodeGen/BackendUtil.cpp:290 @@ +289,3 @@ + // setup for LTO compiles invoked via the gold plugin and the llvm-lto tool. + if (!CodeGenOpts.ThinLTOIndexFile.empty() && !CodeGenOpts.DisableLLVMOpts) { +legacy::PassManager *MPM =

Re: [PATCH] D15025: [ThinLTO] Option to invoke ThinLTO backend passes and importing

joker.eph added a comment. Looks good to me but I'd like another opinion on the name of "-fthinlto-backend", Duncan? Comment at: include/clang/Driver/Types.h:68 @@ -66,1 +67,3 @@ + bool isLLVMIR(ID Id); + /// isCuda - Is this a CUDA input. I guess you could

Re: [PATCH] D15025: [ThinLTO] Option to invoke ThinLTO backend passes and importing

joker.eph added a comment. Talked with Duncan, we're not convinced about //-fthinlto-backend=...// for the option name: the word //backend// does not seems right here. What about //-fthinlto-index=...//? Comment at: lib/CodeGen/CodeGenAction.cpp:822 @@ +821,3 @@ + TheModu

Re: [PATCH] D15025: [ThinLTO] Option to invoke ThinLTO backend passes and importing

joker.eph added inline comments. Comment at: lib/CodeGen/CodeGenAction.cpp:822 @@ +821,3 @@ + TheModule = std::move(Combined); +} + tejohnson wrote: > joker.eph wrote: > > Could we refactor this in a helper in llvm? > I can create a new Linker interface t

Re: [PATCH] D15025: [ThinLTO] Option to invoke ThinLTO backend passes and importing

joker.eph added inline comments. Comment at: lib/CodeGen/CodeGenAction.cpp:822 @@ +821,3 @@ + TheModule = std::move(Combined); +} + tejohnson wrote: > joker.eph wrote: > > tejohnson wrote: > > > joker.eph wrote: > > > > Could we refactor this in a helper

<    1   2   3   4   5   >