[clang] [clang-tools-extra] [lld] [lldb] [llvm] [mlir] Rename llvm::ThreadPool -> llvm::DefaultThreadPool (NFC) (PR #83702)

https://github.com/joker-eph updated https://github.com/llvm/llvm-project/pull/83702 >From d1dc1dfb1bb601fe90289bf29176c74a38ac5697 Mon Sep 17 00:00:00 2001 From: Mehdi Amini Date: Tue, 5 Mar 2024 10:38:41 -0800 Subject: [PATCH] Rename llvm::ThreadPool -> llvm::DefaultThreadPool (NFC) The base

[clang] [clang-tools-extra] [lld] [lldb] [llvm] [mlir] Rename llvm::ThreadPool -> llvm::DefaultThreadPool (NFC) (PR #83702)

https://github.com/joker-eph closed https://github.com/llvm/llvm-project/pull/83702 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [lld] [lldb] [llvm] [mlir] Rename llvm::ThreadPool -> llvm::DefaultThreadPool (NFC) (PR #83702)

@@ -104,7 +104,7 @@ static std::recursive_mutex *g_debugger_list_mutex_ptr = nullptr; // NOTE: intentional leak to avoid issues with C++ destructor chain static Debugger::DebuggerList *g_debugger_list_ptr = nullptr; // NOTE: intentional leak to avoid issues with C++ de

[clang] [clang-tools-extra] [compiler-rt] [flang] [libclc] [libcxx] [lld] [lldb] [llvm] [NFC] Remove trailing whitespace across all non-test related files (PR #82838)

joker-eph wrote: Fine with me if we want to land this as is, but per-top-level subproject may be a better granularity. https://github.com/llvm/llvm-project/pull/82838 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[clang] c462160 - More fix BUILD_SHARED_LIBS=ON build for platforms which require explicit link of -lpthread (NFC)

Author: Mehdi Amini Date: 2024-03-02T19:54:35-08:00 New Revision: c4621607245a5feed42cf9f748ff796728ef579a URL: https://github.com/llvm/llvm-project/commit/c4621607245a5feed42cf9f748ff796728ef579a DIFF: https://github.com/llvm/llvm-project/commit/c4621607245a5feed42cf9f748ff796728ef579a.diff L

[clang] [clang-tools-extra] [lld] [lldb] [llvm] [mlir] Rename llvm::ThreadPool -> llvm::DefaultThreadPool (NFC) (PR #83702)

https://github.com/joker-eph updated https://github.com/llvm/llvm-project/pull/83702 >From 41e5c286c29a4fea65f6116f6844b44a3847f9db Mon Sep 17 00:00:00 2001 From: Mehdi Amini Date: Mon, 4 Mar 2024 23:21:04 -0800 Subject: [PATCH] Rename llvm::ThreadPool -> llvm::DefaultThreadPool (NFC) The base

[clang] [clang-tools-extra] [lld] [lldb] [llvm] [mlir] Rename llvm::ThreadPool -> llvm::DefaultThreadPool (NFC) (PR #83702)

https://github.com/joker-eph updated https://github.com/llvm/llvm-project/pull/83702 >From f961f22a3643673c1f3a040715dcfa2887ee1dca Mon Sep 17 00:00:00 2001 From: Mehdi Amini Date: Mon, 4 Mar 2024 23:21:04 -0800 Subject: [PATCH] Rename llvm::ThreadPool -> llvm::DefaultThreadPool (NFC) The base

[clang] [clang-tools-extra] [lld] [lldb] [llvm] [mlir] Rename llvm::ThreadPool -> llvm::DefaultThreadPool (NFC) (PR #83702)

joker-eph wrote: I did the first part of the renaming @dwblaikie : looks good? https://github.com/llvm/llvm-project/pull/83702 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Revert "[RISCV] Relax march string order constraint" (PR #79976)

joker-eph wrote: - Reverting a change that way costs me 3 clicks: it is the lowest cost on me to fix the CI. - We likely want people to be able to use the pre-merge checks independently of the reviews: you're way of tying "opening a PR" to some expectations (that aren't clear to me) seems to

[llvm] [flang] [clang] [mlir] [compiler-rt] [clang-tools-extra] [mlir][tosa] Add dialect version. (PR #79514)

https://github.com/joker-eph requested changes to this pull request. This lack some information to me: - What is the purpose of this? - What kind of compatibility is this supposed to provide? - What is the versioning scheme? https://github.com/llvm/llvm-project/pull/79514 __

[compiler-rt] [clang] [flang] [llvm] [clang-tools-extra] [mlir] [mlir][tosa] Add dialect version. (PR #79514)

joker-eph wrote: > To be able to flag incompatible bytecode files rather than have it fail later > in mysterious ways. E.g., allows for a more strict failure. That would require some sort of principles and policy around the changes that affect the serialization of this and the maintenance of t

[llvm] [clang-tools-extra] [mlir] [clang] [mlir][docs] Clarified Dialect creation tutorial + fixed typos (PR #77820)

@@ -106,6 +106,12 @@ the LINK_COMPONENTS descriptor. This allows cmake infrastructure to generate new library targets with correct linkage, in particular, when BUILD_SHARED_LIBS=on or LLVM_LINK_LLVM_DYLIB=on are specified. +Registration of the dialect can be performed global

[clang-tools-extra] [clang] [llvm] [mlir] [mlir][docs] Clarified Dialect creation tutorial + fixed typos (PR #77820)

https://github.com/joker-eph edited https://github.com/llvm/llvm-project/pull/77820 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[compiler-rt] [llvm] [mlir] [clang-tools-extra] [clang] [flang] [mlir][tosa] Add dialect version. (PR #79514)

joker-eph wrote: > I think you are assuming guarantees here that doesn't exist. I'm just going by you're writing :) You wrote: "To be able to flag incompatible bytecode files rather than have it fail later in mysterious ways" But my take is that you're not actually providing the ability to fla

[flang] [libcxx] [libc] [clang] [lldb] [llvm] [mlir] [mlir] Skip invalid test on big endian platform (s390x) (PR #80246)

https://github.com/joker-eph closed https://github.com/llvm/llvm-project/pull/80246 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[mlir] [libc] [lldb] [flang] [libcxxabi] [lld] [libcxx] [clang-tools-extra] [compiler-rt] [llvm] [clang] [mlir][complex] Prevent underflow in complex.abs (PR #76316)

joker-eph wrote: I had to revert because this broke a bot: https://lab.llvm.org/buildbot/#/builders/264/builds/6131 ``` # RUN: at line 1 /vol/worker/mlir-nvidia/mlir-nvidia-gcc7/llvm.obj/bin/mlir-opt /vol/worker/mlir-nvidia/mlir-nvidia-gcc7/llvm.src/mlir/test/Integration/Dialect/Complex/CPU/co

[llvm] [clang] Revert "[RISCV] Relax march string order constraint" (PR #79976)

https://github.com/joker-eph created https://github.com/llvm/llvm-project/pull/79976 Reverts llvm/llvm-project#78120 Buildbot is broken: llvm/lib/Support/RISCVISAInfo.cpp:910:18: error: call to deleted constructor of 'llvm::Error' return E; ^ >From 193b711e4e1596c

[llvm] [clang] Revert "[RISCV] Relax march string order constraint" (PR #79976)

https://github.com/joker-eph closed https://github.com/llvm/llvm-project/pull/79976 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [RISCV] Relax march string order constraint (PR #78120)

joker-eph wrote: Sorry, had to revert because this broke a buildbot: ``` llvm/lib/Support/RISCVISAInfo.cpp:910:18: error: call to deleted constructor of 'llvm::Error' return E; ^ ``` https://lab.llvm.org/buildbot/#/builders/61/builds/53704 https://github.com/llvm/llvm-project/pull/78120 __

[clang] [LLVM] Add new attribute `optdebug` to optimize for debugging (PR #66632)

@@ -1872,7 +1872,8 @@ example: passes make choices that keep the code size of this function as small as possible and perform optimizations that may sacrifice runtime performance in order to minimize the size of the generated code. -This attribute is incompatible

[clang-tools-extra] [mlir] Verify TestBuiltinAttributeInterfaces eltype (PR #69878)

https://github.com/joker-eph approved this pull request. https://github.com/llvm/llvm-project/pull/69878 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [mlir] Verify TestBuiltinAttributeInterfaces eltype (PR #69878)

https://github.com/joker-eph approved this pull request. https://github.com/llvm/llvm-project/pull/69878 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [mlir] Add config for PDL (PR #69927)

joker-eph wrote: Can you expand on the motivation? Why is it a problem that PDL is always included? Your description isn’t very explicit on the impact. https://github.com/llvm/llvm-project/pull/69927 ___ cfe-commits mailing list cfe-commits@lists.llvm

[clang] [mlir][doc] Improve Destination-passing-style documentation (PR #70283)

https://github.com/joker-eph updated https://github.com/llvm/llvm-project/pull/70283 >From 0bdf7a0bc1c1e3b5fc3280e9ba5f5cacfeeb5f7f Mon Sep 17 00:00:00 2001 From: Mehdi Amini Date: Wed, 25 Oct 2023 19:17:32 -0700 Subject: [PATCH 1/2] Update Bufferization.md --- mlir/docs/Bufferization.md | 39

[clang] [mlir][doc] Improve Destination-passing-style documentation (PR #70283)

https://github.com/joker-eph updated https://github.com/llvm/llvm-project/pull/70283 >From 0bdf7a0bc1c1e3b5fc3280e9ba5f5cacfeeb5f7f Mon Sep 17 00:00:00 2001 From: Mehdi Amini Date: Wed, 25 Oct 2023 19:17:32 -0700 Subject: [PATCH 1/3] Update Bufferization.md --- mlir/docs/Bufferization.md | 39

[clang] [mlir][doc] Improve Destination-passing-style documentation (PR #70283)

https://github.com/joker-eph closed https://github.com/llvm/llvm-project/pull/70283 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 0fb2203 - [Docs] Fix --print-supported-cpus option rendering

Author: Travis Finkenauer Date: 2020-09-13T05:26:18Z New Revision: 0fb2203cd6c287e7438b7ac2571645066c63eeb6 URL: https://github.com/llvm/llvm-project/commit/0fb2203cd6c287e7438b7ac2571645066c63eeb6 DIFF: https://github.com/llvm/llvm-project/commit/0fb2203cd6c287e7438b7ac2571645066c63eeb6.diff

[clang] 4fc56d7 - Revert "[NFC][llvm] Make the contructors of `ElementCount` private."

Author: Mehdi Amini Date: 2020-08-19T17:21:37Z New Revision: 4fc56d70aadea9df88e7bf408e2e203dc79ff8e6 URL: https://github.com/llvm/llvm-project/commit/4fc56d70aadea9df88e7bf408e2e203dc79ff8e6 DIFF: https://github.com/llvm/llvm-project/commit/4fc56d70aadea9df88e7bf408e2e203dc79ff8e6.diff LOG: R

[clang] a407ec9 - Revert "Revert "[NFC][llvm] Make the contructors of `ElementCount` private.""

Author: Mehdi Amini Date: 2020-08-19T17:26:36Z New Revision: a407ec9b6db1e29e9aa361819f499ad11038d2dd URL: https://github.com/llvm/llvm-project/commit/a407ec9b6db1e29e9aa361819f499ad11038d2dd DIFF: https://github.com/llvm/llvm-project/commit/a407ec9b6db1e29e9aa361819f499ad11038d2dd.diff LOG: R

[clang] f917356 - Revert "[clang][cli] Port ObjCMTAction to new option parsing system"

Author: Mehdi Amini Date: 2020-11-11T20:01:03Z New Revision: f917356f9ce026f9be9972b8c75cd3ba00e43497 URL: https://github.com/llvm/llvm-project/commit/f917356f9ce026f9be9972b8c75cd3ba00e43497 DIFF: https://github.com/llvm/llvm-project/commit/f917356f9ce026f9be9972b8c75cd3ba00e43497.diff LOG: R

[clang] 42e88bd - Replace sequences of v.push_back(v[i]); v.erase(&v[i]); with std::rotate (NFC)

Author: Mehdi Amini Date: 2020-11-14T00:55:33Z New Revision: 42e88bd6b18597fe0a46ee9663d4e2cf2f7a4e57 URL: https://github.com/llvm/llvm-project/commit/42e88bd6b18597fe0a46ee9663d4e2cf2f7a4e57 DIFF: https://github.com/llvm/llvm-project/commit/42e88bd6b18597fe0a46ee9663d4e2cf2f7a4e57.diff LOG: R

Re: [llvm-dev] Phabricator Creator Pulling the Plug

We talked about this with the IWG (Infrastructure Working Group) just last week coincidentally. Two major blocking tracks that were identified at the roundtable during the LLVM Dev Meeting exactly 2 years ago are still an issue today: 1) Replacement for Herald rules. This is what allows us to subs

Re: [llvm-dev] Phabricator Creator Pulling the Plug

On Thu, Sep 30, 2021 at 4:09 PM Brian Cain wrote: > > > > On Thu, Sep 30, 2021, 6:04 PM Brian Cain wrote: >> >> Does something like Rust's "bors" bot satisfy the herald rules need? > > > > sorry, maybe I was thinking of the high-five bot. And it looks like that's > not quite a match for herald.

Re: [llvm-dev] Phabricator Creator Pulling the Plug

On Thu, Sep 30, 2021 at 8:05 PM Hubert Tong wrote: > > On Thu, Sep 30, 2021 at 6:56 PM Mehdi AMINI via cfe-commits > wrote: >> >> We talked about this with the IWG (Infrastructure Working Group) just >> last week coincidentally. >> Two major blocking t

[clang] 28c0479 - Revert "[Matrix] Overload stride arg in matrix.columnwise.load/store."

Author: Mehdi Amini Date: 2021-08-12T11:57:19Z New Revision: 28c04794df74ad3c38155a244729d1f8d57b9400 URL: https://github.com/llvm/llvm-project/commit/28c04794df74ad3c38155a244729d1f8d57b9400 DIFF: https://github.com/llvm/llvm-project/commit/28c04794df74ad3c38155a244729d1f8d57b9400.diff LOG: R

[clang] [MLIR] Pass hostShared flag in gpu.alloc op to runtime wrappers (PR #66401)

https://github.com/joker-eph closed https://github.com/llvm/llvm-project/pull/66401 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [MLIR] Pass hostShared flag in gpu.alloc op to runtime wrappers (PR #66401)

https://github.com/joker-eph closed https://github.com/llvm/llvm-project/pull/66401 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [mlir][llvm] Fix elem type passing into `getelementptr` (PR #68136)

joker-eph wrote: Reverted, the bots have been broken all day. https://github.com/llvm/llvm-project/pull/68136 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] c49142e - Fix truncated __OPENMP_NVPTX__ preprocessor condition

Author: Ryan Burns Date: 2023-08-15T14:12:34-07:00 New Revision: c49142e4f5c8645a4d741d233f0cb55ef1ef87a2 URL: https://github.com/llvm/llvm-project/commit/c49142e4f5c8645a4d741d233f0cb55ef1ef87a2 DIFF: https://github.com/llvm/llvm-project/commit/c49142e4f5c8645a4d741d233f0cb55ef1ef87a2.diff LO

[clang] Reland "[CUDA][HIP] Fix overloading resolution in global variable ini… (PR #65606)

joker-eph wrote: Please reflow the title to avoid the `` and line wrap. https://github.com/llvm/llvm-project/pull/65606 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [MLIR] Enabling Intel GPU Integration. (PR #65539)

@@ -0,0 +1,223 @@ +//===- SyclRuntimeWrappers.cpp - MLIR SYCL wrapper library ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-

[clang] Update GoogleTest to v1.14.0 (PR #65823)

https://github.com/joker-eph approved this pull request. Agree with @MaskRay for the style: we should minimize the diff with upstream as much as possible! https://github.com/llvm/llvm-project/pull/65823 ___ cfe-commits mailing list cfe-commits@lists.l

[clang] Fix some typos in comments: evalute -> evaluate (NFC) (PR #65906)

https://github.com/joker-eph approved this pull request. https://github.com/llvm/llvm-project/pull/65906 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Replace llvm.memcpy et al's i1 isVolatile with i8 VolFlags (PR #65748)

@@ -214,14 +214,14 @@ class LLVM_MemcpyIntrOpBase : /*requiresAccessGroup=*/1, /*requiresAliasAnalysis=*/1> { dag args = (ins Arg:$dst, Arg:$src, - AnySignlessInteger:$len, I1Attr:$isVolatile); joker-eph wrote: Seems to

[clang] Enabling Intel GPU Integration. (PR #65539)

@@ -71,7 +71,8 @@ void GPUToSPIRVPass::runOnOperation() { std::unique_ptr target = spirv::getMemorySpaceToStorageClassTarget(*context); spirv::MemorySpaceToStorageClassMap memorySpaceMap = - spirv::mapMemorySpaceToVulkanStorageClass; + th

[clang] Enabling Intel GPU Integration. (PR #65539)

https://github.com/joker-eph commented: LGTM overall, this should likely get reviewed by @antiagainst / @kuhar ; and it's be great if you can split the independent changes and send them ahead of the e2e integration. https://github.com/llvm/llvm-project/pull/65539 __

[clang-tools-extra] Enabling Intel GPU Integration. (PR #65539)

@@ -71,7 +71,8 @@ void GPUToSPIRVPass::runOnOperation() { std::unique_ptr target = spirv::getMemorySpaceToStorageClassTarget(*context); spirv::MemorySpaceToStorageClassMap memorySpaceMap = - spirv::mapMemorySpaceToVulkanStorageClass; + th

[clang] Enabling Intel GPU Integration. (PR #65539)

@@ -1158,7 +1178,7 @@ LogicalResult ConvertLaunchFuncOpToGpuRuntimeCallPattern::matchAndRewrite( {function.getResult(), adaptor.getGridSizeX(), adaptor.getGridSizeY(), adaptor.getGridSizeZ(), adaptor.getBlockSizeX(), adaptor.getBlockSizeY(), adaptor.getBlo

[clang-tools-extra] Enabling Intel GPU Integration. (PR #65539)

https://github.com/joker-eph commented: LGTM overall, this should likely get reviewed by @antiagainst / @kuhar ; and it's be great if you can split the independent changes and send them ahead of the e2e integration. https://github.com/llvm/llvm-project/pull/65539 __

[clang-tools-extra] Enabling Intel GPU Integration. (PR #65539)

@@ -0,0 +1,70 @@ +//===- SerializeToSPIRV.cpp - Convert GPU kernel to SPIRV blob -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] Enabling Intel GPU Integration. (PR #65539)

@@ -811,8 +812,13 @@ LogicalResult ConvertAllocOpToGpuRuntimeCallPattern::matchAndRewrite( // descriptor. Type elementPtrType = this->getElementPtrType(memRefType); auto stream = adaptor.getAsyncDependencies().front(); + + auto isHostShared = rewriter.create( + loc

[clang] Enabling Intel GPU Integration. (PR #65539)

@@ -0,0 +1,70 @@ +//===- SerializeToSPIRV.cpp - Convert GPU kernel to SPIRV blob -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] Enabling Intel GPU Integration. (PR #65539)

@@ -811,8 +812,13 @@ LogicalResult ConvertAllocOpToGpuRuntimeCallPattern::matchAndRewrite( // descriptor. Type elementPtrType = this->getElementPtrType(memRefType); auto stream = adaptor.getAsyncDependencies().front(); + + auto isHostShared = rewriter.create( + loc

[clang] Enabling Intel GPU Integration. (PR #65539)

@@ -0,0 +1,70 @@ +//===- SerializeToSPIRV.cpp - Convert GPU kernel to SPIRV blob -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] 55c2211 - [APFloat] Add APFloat semantic support for TF32

Author: Jeremy Furtek Date: 2023-06-23T10:54:49+02:00 New Revision: 55c2211a233e11179048cf58778f40e5a62f444a URL: https://github.com/llvm/llvm-project/commit/55c2211a233e11179048cf58778f40e5a62f444a DIFF: https://github.com/llvm/llvm-project/commit/55c2211a233e11179048cf58778f40e5a62f444a.diff

r289761 - Fix os_log formating with arbitrary precision and field width

Author: mehdi_amini Date: Wed Dec 14 22:02:31 2016 New Revision: 289761 URL: http://llvm.org/viewvc/llvm-project?rev=289761&view=rev Log: Fix os_log formating with arbitrary precision and field width Modified: cfe/trunk/lib/Analysis/OSLog.cpp cfe/trunk/test/CodeGen/builtins.c Modified: c

r289762 - Fix printf specifier handling: invalid specifier should not be marked as "consuming data arguments"

Author: mehdi_amini Date: Wed Dec 14 22:51:22 2016 New Revision: 289762 URL: http://llvm.org/viewvc/llvm-project?rev=289762&view=rev Log: Fix printf specifier handling: invalid specifier should not be marked as "consuming data arguments" Modified: cfe/trunk/include/clang/Analysis/Analyses/Fo

r289763 - Revert "Fix printf specifier handling: invalid specifier should not be marked as "consuming data arguments""

Author: mehdi_amini Date: Wed Dec 14 22:58:51 2016 New Revision: 289763 URL: http://llvm.org/viewvc/llvm-project?rev=289763&view=rev Log: Revert "Fix printf specifier handling: invalid specifier should not be marked as "consuming data arguments"" This reverts commit r289762, wasn't ready to be p

r289850 - Fix printf specifier handling: invalid specifier should not be marked as "consuming data arguments"

Author: mehdi_amini Date: Thu Dec 15 12:54:00 2016 New Revision: 289850 URL: http://llvm.org/viewvc/llvm-project?rev=289850&view=rev Log: Fix printf specifier handling: invalid specifier should not be marked as "consuming data arguments" Reviewers: rsmith, bruno, dexonsmith Subscribers: cfe-com

Re: r288493 - [ClangFormat] Only insert #include into the #include block in the beginning of the file.

Hi Eric, > On Dec 2, 2016, at 3:01 AM, Eric Liu via cfe-commits > wrote: > > Author: ioeric > Date: Fri Dec 2 05:01:43 2016 > New Revision: 288493 > > URL: http://llvm.org/viewvc/llvm-project?rev=288493&view=rev > Log: > [ClangFormat] Only insert #include into the #include block in the beginn

r291276 - Use CodegenOpts::less when creating a TargetMachine for clang `-O1`

Author: mehdi_amini Date: Fri Jan 6 14:52:30 2017 New Revision: 291276 URL: http://llvm.org/viewvc/llvm-project?rev=291276&view=rev Log: Use CodegenOpts::less when creating a TargetMachine for clang `-O1` Summary: Clang was initializing the TargetMachine with CodeGenOpt::Default for O1. This cha

r291300 - Add a cc1 option to force disabling lifetime-markers emission from clang

Author: mehdi_amini Date: Fri Jan 6 17:18:09 2017 New Revision: 291300 URL: http://llvm.org/viewvc/llvm-project?rev=291300&view=rev Log: Add a cc1 option to force disabling lifetime-markers emission from clang Summary: This intended as a debugging/development flag only. Differential Revision: h

r278906 - [ThinLTO] Adapt backend invocation to llvm API changes.

Author: mehdi_amini Date: Wed Aug 17 01:23:08 2016 New Revision: 278906 URL: http://llvm.org/viewvc/llvm-project?rev=278906&view=rev Log: [ThinLTO] Adapt backend invocation to llvm API changes. Reviewers: tejohnson Subscribers: mehdi_amini, llvm-commits Differential Revision: https://reviews.ll

Re: [PATCH] D23826: Remove excessive padding from PTHStatData

mehdi_amini accepted this revision. mehdi_amini added a comment. This revision is now accepted and ready to land. LGTM, thanks. (In the future, please upload patches with full context) Repository: rL LLVM https://reviews.llvm.org/D23826 ___ cfe-

Re: [PATCH] D23826: Remove excessive padding from PTHStatData

This revision was automatically updated to reflect the committed changes. Closed by commit rL279607: Remove excessive padding from PTHStatData (NFC) (authored by mehdi_amini). Changed prior to commit: https://reviews.llvm.org/D23826?vs=69071&id=69077#toc Repository: rL LLVM https://reviews.

r279607 - Remove excessive padding from PTHStatData (NFC)

Author: mehdi_amini Date: Tue Aug 23 23:26:57 2016 New Revision: 279607 URL: http://llvm.org/viewvc/llvm-project?rev=279607&view=rev Log: Remove excessive padding from PTHStatData (NFC) This diff reorders the fields and removes excessive padding. This fixes the following warning: PTHLexer.cpp:62

Re: [PATCH] D23595: [Clang] Fix some Clang-tidy modernize-use-using and Include What You Use warnings

mehdi_amini added inline comments. Comment at: include/clang/Basic/IdentifierTable.h:103 @@ -95,1 +102,3 @@ +return getLength() == StrLen-1 && + memcmp(getNameStart(), Str, StrLen-1) == 0; } Eugene.Zelenko wrote: > memcpy result is three state, so

Re: [PATCH] D17983: Eliminate many benign instances of "potentially uninitialized local variable" warnings

mehdi_amini added a comment. @dblaikie mentioned before that it is not clear that this is something we want to do at all (initialize all local variables). Would it be something we should have policy on in the first place before integrating such a patch? (Reminds me of constructor that don't init

Re: [PATCH] D24042: [test] Add libLTO as a clang test dependency on Darwin

Alternatively, since you only need the presence of a file named libLTO for the driver to do its magic, test can create an empty file named libLTO.dylib and use the -ccc-install-dir to make sure the right flag is passed. > On Aug 30, 2016, at 10:40 AM, Vedant Kumar wrote: > > vsk created this

Re: [PATCH] D24040: codechecker tool core

mehdi_amini added a subscriber: mehdi_amini. mehdi_amini added a comment. This looks like a fairly large tool. Should it get its own "subproject level" directory in the SVN instead of being nested within clang? Comment at: tools/codechecker/README.md:50 @@ +49,3 @@ +# get sourc

Re: [PATCH] D24040: codechecker tool core

mehdi_amini added a comment. > This looks like a fairly large tool. Should it get its own "subproject level" > directory in the SVN instead of being nested within clang? I'd add that the clang-tools-extra are more closely tied to clang than what this seems to be. Is there a strong rev-lock wit

Re: [PATCH] D24040: codechecker tool core

mehdi_amini added a comment. In https://reviews.llvm.org/D24040#532719, @o.gyorgy wrote: > In https://reviews.llvm.org/D24040#530546, @mehdi_amini wrote: > > > > This looks like a fairly large tool. Should it get its own "subproject > > > level" directory in the SVN instead of being nested wit

[libcxx] r297798 - Add deployment knobs to tests (for Apple platforms)

Author: mehdi_amini Date: Tue Mar 14 19:59:54 2017 New Revision: 297798 URL: http://llvm.org/viewvc/llvm-project?rev=297798&view=rev Log: Add deployment knobs to tests (for Apple platforms) The tests for libc++ specify -target on the command-line to the compiler, but this is problematic for a few

Re: [libcxx] r281681 - [libc++] Add _LIBCPP_EXTERN_TEMPLATE_INLINE_VISIBILITY to support GCC ABI compatibility

Hi, I don't understand clang's logic here, seems like a bug to me. I changed slightly the test-case, and I'm wondering why only foo() is emitted as hidden in the following: #define INLINE_VISIBILITY __attribute__((visibility("hidden"), always_inline)) template struct Foo { void INLINE_VISIBILI

Re: [libcxx] r281681 - [libc++] Add _LIBCPP_EXTERN_TEMPLATE_INLINE_VISIBILITY to support GCC ABI compatibility

2017-03-29 20:30 GMT-07:00 Duncan P. N. Exon Smith : > > On Mar 29, 2017, at 20:16, Eric Fiselier wrote: > > > > On Wed, Mar 29, 2017 at 9:00 PM, Duncan P. N. Exon Smith < > dexonsm...@apple.com> wrote: > >> Why are we propagating the use of always_inline? >> > > The intent of this change wasn't

[libcxx] r299052 - Do not pass an explicit reexported symbol list when building libc++ dylib if also defining new/delete

Author: mehdi_amini Date: Wed Mar 29 23:40:56 2017 New Revision: 299052 URL: http://llvm.org/viewvc/llvm-project?rev=299052&view=rev Log: Do not pass an explicit reexported symbol list when building libc++ dylib if also defining new/delete Modified: libcxx/trunk/lib/CMakeLists.txt Modified:

[libcxx] r299053 - libc++ testing: allow to provide a path for `use_system_cxx_lib`

Author: mehdi_amini Date: Wed Mar 29 23:45:33 2017 New Revision: 299053 URL: http://llvm.org/viewvc/llvm-project?rev=299053&view=rev Log: libc++ testing: allow to provide a path for `use_system_cxx_lib` As we're trying to setup testing / bots for all shipping version of libc++ on macOS/iOS, we'll

[libcxx] r299054 - Reexport operator new / delete from libc++abi

Author: mehdi_amini Date: Wed Mar 29 23:47:19 2017 New Revision: 299054 URL: http://llvm.org/viewvc/llvm-project?rev=299054&view=rev Log: Reexport operator new / delete from libc++abi Both libc++ and libc++abi export a weak definition of operator new/delete. On Darwin, this can often cause dirty

[libcxx] r299055 - libc++ config testing: `use_system_cxx_lib` can be a bool

Author: mehdi_amini Date: Wed Mar 29 23:51:19 2017 New Revision: 299055 URL: http://llvm.org/viewvc/llvm-project?rev=299055&view=rev Log: libc++ config testing: `use_system_cxx_lib` can be a bool Fix the libc++ Green Dragon bot. Modified: libcxx/trunk/utils/libcxx/test/config.py Modified: l

[libcxx] r299056 - libc++ testing: fix assertion around `use_system_cxx_lib`

Author: mehdi_amini Date: Thu Mar 30 00:07:18 2017 New Revision: 299056 URL: http://llvm.org/viewvc/llvm-project?rev=299056&view=rev Log: libc++ testing: fix assertion around `use_system_cxx_lib` Actually fix (hopefully) the assertions about `use_system_cxx_lib`, the previous attempt failed becau

[libcxx] r299057 - libc++ testing: fix invalid python syntax

Author: mehdi_amini Date: Thu Mar 30 00:21:33 2017 New Revision: 299057 URL: http://llvm.org/viewvc/llvm-project?rev=299057&view=rev Log: libc++ testing: fix invalid python syntax Modified: libcxx/trunk/utils/libcxx/test/config.py Modified: libcxx/trunk/utils/libcxx/test/config.py URL: http

[libcxxabi] r299414 - Uses quote to include cxxabi.h to make sure the local one is included

Author: mehdi_amini Date: Tue Apr 4 00:38:38 2017 New Revision: 299414 URL: http://llvm.org/viewvc/llvm-project?rev=299414&view=rev Log: Uses quote to include cxxabi.h to make sure the local one is included Modified: libcxxabi/trunk/src/cxa_exception.hpp libcxxabi/trunk/src/cxa_unexpecte

[libcxx] r299606 - Use alternate string layout for ARMv7k

Author: mehdi_amini Date: Wed Apr 5 20:10:22 2017 New Revision: 299606 URL: http://llvm.org/viewvc/llvm-project?rev=299606&view=rev Log: Use alternate string layout for ARMv7k Modified: libcxx/trunk/include/__config Modified: libcxx/trunk/include/__config URL: http://llvm.org/viewvc/llvm-p

[libcxx] r299607 - Fix remote test execution in lit

Author: mehdi_amini Date: Wed Apr 5 20:14:57 2017 New Revision: 299607 URL: http://llvm.org/viewvc/llvm-project?rev=299607&view=rev Log: Fix remote test execution in lit Can be used as such: $ python /path/to/lit.py -sv /path/to/llvm/build/projects/libcxx/test/ \ --param=use_system_cxx_li

[libcxx] r299656 - Revert "Restore Missing awk regex tests. Thanks to dexonsmith for noticing, and proposing this as https://reviews.llvm.org/D16541"

Author: mehdi_amini Date: Thu Apr 6 10:56:55 2017 New Revision: 299656 URL: http://llvm.org/viewvc/llvm-project?rev=299656&view=rev Log: Revert "Restore Missing awk regex tests. Thanks to dexonsmith for noticing, and proposing this as https://reviews.llvm.org/D16541"; This reverts commit r29965

Re: [libcxx] r299652 - Restore Missing awk regex tests. Thanks to dexonsmith for noticing, and proposing this as https://reviews.llvm.org/D16541

Hi, I reverted in r299656. MacOS bot is broken both on 64 and 32 bits: http://green.lab.llvm.org/green/job/libcxx_master_cmake/83/ http://green.lab.llvm.org/green/job/libcxx_master_cmake_32/61/ It shouldn’t be too hard to fix though, it is full of the same error: /Users/buildslave/jenkins/share

Re: r291318 - PR23135: Don't instantiate constexpr functions referenced in unevaluated operands where possible.

Hi Richard, I have a link failure in WebKit following this patch, the move-assign operator for an nested class isn’t emitted (IRGen) in some context where it is needed. I’m working on running creduce the test-case which is pretty large, but in case it rings a bell, I let you know already. — M

r292960 - Split isUsingLTO() outside of embedBitcodeInObject() and embedBitcodeMarkerOnly().

Author: mehdi_amini Date: Tue Jan 24 12:12:25 2017 New Revision: 292960 URL: http://llvm.org/viewvc/llvm-project?rev=292960&view=rev Log: Split isUsingLTO() outside of embedBitcodeInObject() and embedBitcodeMarkerOnly(). Summary: These accessors maps directly to the command line option. Reviewe

r292961 - Forward -bitcode_process_mode to ld64 in marker-only mode

Author: mehdi_amini Date: Tue Jan 24 12:15:21 2017 New Revision: 292961 URL: http://llvm.org/viewvc/llvm-project?rev=292961&view=rev Log: Forward -bitcode_process_mode to ld64 in marker-only mode Reviewers: steven_wu Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D2906

r292964 - Fix test/Driver/embed-bitcode.c on non-Darwin host by setting the target explicitly

Author: mehdi_amini Date: Tue Jan 24 12:49:49 2017 New Revision: 292964 URL: http://llvm.org/viewvc/llvm-project?rev=292964&view=rev Log: Fix test/Driver/embed-bitcode.c on non-Darwin host by setting the target explicitly Modified: cfe/trunk/test/Driver/embed-bitcode.c Modified: cfe/trunk/t

[libcxx] r293071 - [libcxx] Mentions "targeting C++11 and above" instead of "targeting C++11" in the doc

Author: mehdi_amini Date: Wed Jan 25 11:00:30 2017 New Revision: 293071 URL: http://llvm.org/viewvc/llvm-project?rev=293071&view=rev Log: [libcxx] Mentions "targeting C++11 and above" instead of "targeting C++11" in the doc Modified: libcxx/trunk/docs/index.rst Modified: libcxx/trunk/docs/i

[libcxxabi] r293330 - Fix ASAN failure in cxa_demangle

Author: mehdi_amini Date: Fri Jan 27 14:32:16 2017 New Revision: 293330 URL: http://llvm.org/viewvc/llvm-project?rev=293330&view=rev Log: Fix ASAN failure in cxa_demangle Found with ASAN + libFuzzer by Kostya Serebryany Modified: libcxxabi/trunk/src/cxa_demangle.cpp libcxxabi/trunk/test

Re: [PATCH] D29233: Fix linkage of static locals in available_externally functions to be DiscardableODR/linkonce_odr

CC Hans. This is not a regression (AFAICT), but this is a quality improvement, so may be worth considering in the 4.0 branch? — Mehdi > On Jan 27, 2017, at 2:04 PM, David Blaikie via Phabricator > wrote: > > dblaikie created this revision. > > As Mehdi put it, entities should either be > a

Re: [PATCH] D29233: Fix linkage of static locals in available_externally functions to be DiscardableODR/linkonce_odr

> On Jan 27, 2017, at 2:44 PM, David Blaikie wrote: > > > > On Fri, Jan 27, 2017 at 2:11 PM Mehdi AMINI via Phabricator > mailto:revi...@reviews.llvm.org>> wrote: > mehdi_amini accepted this revision. > mehdi_amini added a comment. > This revision is now accepted and ready to land. > > LGTM.

Re: [PATCH] D29233: Fix linkage of static locals in available_externally functions to be DiscardableODR/linkonce_odr

> On Jan 27, 2017, at 2:43 PM, David Blaikie wrote: > > > > On Fri, Jan 27, 2017 at 2:13 PM Mehdi Amini > wrote: > CC Hans. > > This is not a regression (AFAICT), but this is a quality improvement, so may > be worth considering in the 4.0 branch? > > Perhaps -

r293370 - Fix typo introduced in r292960 that may affect -flto -save-temps (saving the optimized bitcode)

Author: mehdi_amini Date: Sat Jan 28 00:07:17 2017 New Revision: 293370 URL: http://llvm.org/viewvc/llvm-project?rev=293370&view=rev Log: Fix typo introduced in r292960 that may affect -flto -save-temps (saving the optimized bitcode) Modified: cfe/trunk/lib/Driver/Tools.cpp Modified: cfe/tr

Re: [PATCH] D34992: Emit static constexpr member as available_externally definition

The LLVM verifier is complaining that dllimport have to be external linkage and isn't happy with available_externally, is the verifier wrong? 2017-07-05 9:12 GMT-07:00 David Majnemer : > I don't think you need the dllimport restriction. > > On Wed, Jul 5, 2017 at 12:05 PM Alex Lorenz via Phabrica

[libcxx] r294696 - Fully qualify (preprend ::) calls to math functions from libc

Author: mehdi_amini Date: Thu Feb 9 20:44:23 2017 New Revision: 294696 URL: http://llvm.org/viewvc/llvm-project?rev=294696&view=rev Log: Fully qualify (preprend ::) calls to math functions from libc Summary: This can cause a compile failure in cases like: double log(double); namespace foo { n

Re: [libcxx] r294696 - Fully qualify (preprend ::) calls to math functions from libc

Should we get this in 4.0? — Mehdi > On Feb 9, 2017, at 6:44 PM, Mehdi Amini via cfe-commits > wrote: > > Author: mehdi_amini > Date: Thu Feb 9 20:44:23 2017 > New Revision: 294696 > > URL: http://llvm.org/viewvc/llvm-project?rev=294696&view=rev > Log: >

Re: r296554 - [PS4] Set our default dialect to C++11. NFC for other targets.

I’m not sure I find this nice to see this upstream. I not fond in general of this kind of difference in behavior. I don’t think it is good for clang to have different default for this kind of settings depending on the platform. It does not provide a very good user experience from a cross-platfo

<    1   2   3   4   5   >