[PATCH] D129456: [lldb] Add image dump pcm-info command

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. LGTM with a comment Comment at: lldb/test/API/commands/target/dump-pcm-info/TestDumpPCMInfo.py:37 + +breakpoint() +self.expect( Left over ? Repos

[PATCH] D129377: [lldb/Fuzzer] Add fuzzer for expression evaluator

mib added inline comments. Comment at: clang/cmake/modules/ProtobufMutator.cmake:4-5 + set (PBM_PREFIX clang_protobuf_mutator) +elseif(${CMAKE_CURRENT_SOURCE_DIR} MATCHES "lldb") + set (PBM_PREFIX lldb_protobuf_mutator) +endif() If feels wrong to me that the cl

[PATCH] D129377: [lldb/Fuzzer] Add fuzzer for expression evaluator

mib added a comment. In D129377#3673204 , @mstorsjo wrote: > This broke building of Clang, when it's set up by symlinking > `llvm-project/clang` into `llvm-project/llvm/tools`. In that case, cmake > configure errors out like this: > > -- Configuring d

[PATCH] D100810: Use `GNUInstallDirs` to support custom installation dirs. -- LLVM

mib added a comment. Hi @Ericson2314, I think this patch broke our macOS lldb-incremental bot on GreenDragon (https://green.lab.llvm.org/green/job/lldb-cmake/37560/console). Could you please take a look ? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D100810: Use `GNUInstallDirs` to support custom installation dirs. -- LLVM

mib added a comment. I reverted this patch locally and try building with clang modules (`-DLLVM_ENABLE_MODULE=On`) which confirmed it was causing the build failure on the bots. I had to revert your patch upstream to fix our bots. If you need some help to reproduce the build failure, let me kno

[PATCH] D159483: [Modules] Add a flag to control builtin headers being in system modules

mib added a comment. @iana I believe this is affecting lldb macOS bot: https://green.lab.llvm.org/green/view/LLDB/job/as-lldb-cmake/6316/ Can you take a look ? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159483/new/ https://reviews.llvm

[PATCH] D159064: [Modules] Make clang modules for the C standard library headers

mib added a comment. Hey @iana, I think this broke the lldb bot https://green.lab.llvm.org/green/view/LLDB/job/as-lldb-cmake/6698/ Can you take a look ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159064/new/ https://reviews.llvm.org/D159064 _

[PATCH] D154664: [NFC] Add some missing header includes

mib accepted this revision. mib added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154664/new/ https://reviews.llvm.org/D154664 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D100810: Use `GNUInstallDirs` to support custom installation dirs. -- LLVM

mib added a comment. In D100810#3186066 , @Ericson2314 wrote: > I tried again without lld in the list of enable projects, in case it that > made a difference to force it to use ld64 more, but it still worked. Hi @Ericson2314, I tried reproducing the fa