arsenm added inline comments.
Comment at: lib/CodeGen/TargetInfo.cpp:6856
@@ +6855,3 @@
+ }
+ else if (StrTy->getNumElements() == 1) {
+// Coerce single element structs to its element.
No else after return
Comment at: test/CodeGenOpenCL/amd
Author: arsenm
Date: Tue Jul 19 14:02:01 2016
New Revision: 276009
URL: http://llvm.org/viewvc/llvm-project?rev=276009&view=rev
Log:
amdgpu: Use right builtn for rsq
The r600 path has never actually worked sinced double is not implemented
there.
Modified:
libclc/trunk/amdgpu/lib/math/sqrt.cl
arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D20168
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
arsenm added a subscriber: arsenm.
Comment at: lib/Basic/Targets.cpp:2008-2010
@@ +2007,5 @@
+ uint64_t getOpenCLMaxPointerWidth() const override {
+if (GPU <= GK_CAYMAN)
+ return 32;
+return 64;
+ }
Should use ternary operator and check the triple
Author: arsenm
Date: Wed Feb 3 11:49:38 2016
New Revision: 259671
URL: http://llvm.org/viewvc/llvm-project?rev=259671&view=rev
Log:
Add builtins for bitreverse intrinsic
Follow the naming convention that bswap uses since it's a
similar sort of operation.
Modified:
cfe/trunk/include/clang/Ba
arsenm closed this revision.
arsenm added a comment.
r259671.
Should I put some documentation for these somewhere?
docs/LanguageExtensions.rst seems to be the place, but it only has a random
subset of the current builtins.
http://reviews.llvm.org/D16482
arsenm created this revision.
arsenm added a subscriber: cfe-commits.
Description copied from intrinsic
http://reviews.llvm.org/D16993
Files:
docs/LanguageExtensions.rst
Index: docs/LanguageExtensions.rst
===
--- docs/LanguageExt
Author: arsenm
Date: Fri Feb 12 19:02:06 2016
New Revision: 260778
URL: http://llvm.org/viewvc/llvm-project?rev=260778&view=rev
Log:
Update page to list supported targets
Modified:
libclc/trunk/www/index.html
Modified: libclc/trunk/www/index.html
URL:
http://llvm.org/viewvc/llvm-project/lib
Author: arsenm
Date: Fri Feb 12 19:01:59 2016
New Revision: 260777
URL: http://llvm.org/viewvc/llvm-project?rev=260777&view=rev
Log:
Split sources for amdgcn and r600
Most files remain in a common amdgpu directory.
Also switches barriers to to use convergent,
and use llvm.amdgcn.s.barrier.
This
Author: arsenm
Date: Fri Feb 12 19:03:09 2016
New Revision: 260781
URL: http://llvm.org/viewvc/llvm-project?rev=260781&view=rev
Log:
AMDGPU: Update builtin for intrinsic change
Modified:
cfe/trunk/include/clang/Basic/BuiltinsAMDGPU.def
cfe/trunk/lib/CodeGen/CGBuiltin.cpp
cfe/trunk/tes
Author: arsenm
Date: Fri Feb 12 19:21:09 2016
New Revision: 260783
URL: http://llvm.org/viewvc/llvm-project?rev=260783&view=rev
Log:
AMDGPU: Add sin/cos builtins
Modified:
cfe/trunk/include/clang/Basic/BuiltinsAMDGPU.def
cfe/trunk/lib/CodeGen/CGBuiltin.cpp
cfe/trunk/test/CodeGenOpenCL
arsenm closed this revision.
arsenm added a comment.
r260783
http://reviews.llvm.org/D17188
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: arsenm
Date: Tue Feb 16 18:27:27 2016
New Revision: 261042
URL: http://llvm.org/viewvc/llvm-project?rev=261042&view=rev
Log:
amdgcn: Use new workitem intrinsics
Added:
libclc/trunk/amdgcn/lib/workitem/
libclc/trunk/amdgcn/lib/workitem/get_group_id.ll
libclc/trunk/amdgcn/lib/wo
Author: arsenm
Date: Tue Feb 16 18:27:31 2016
New Revision: 261043
URL: http://llvm.org/viewvc/llvm-project?rev=261043&view=rev
Log:
Add .gitignore for build directories
Added:
libclc/trunk/.gitignore
Added: libclc/trunk/.gitignore
URL:
http://llvm.org/viewvc/llvm-project/libclc/trunk/.giti
arsenm created this revision.
arsenm added a reviewer: tstellarAMD.
arsenm added a subscriber: cfe-commits.
http://reviews.llvm.org/D17515
Files:
include/clang/Basic/BuiltinsAMDGPU.def
test/CodeGenOpenCL/builtins-amdgcn.cl
test/SemaOpenCL/builtins-amdgcn.cl
Index: test/SemaOpenCL/builtins-
arsenm created this revision.
arsenm added reviewers: tstellarAMD, echristo.
arsenm added a subscriber: cfe-commits.
Cleanup setup of subtarget features.
http://reviews.llvm.org/D17516
Files:
include/clang/Basic/BuiltinsAMDGPU.def
lib/Basic/Targets.cpp
test/CodeGenOpenCL/builtins-amdgcn-er
arsenm created this revision.
arsenm added a reviewer: tstellarAMD.
arsenm added a subscriber: cfe-commits.
amdgcn should not be defining __R600__
http://reviews.llvm.org/D17519
Files:
lib/Basic/Targets.cpp
test/Preprocessor/predefined-arch-macros.c
Index: test/Preprocessor/predefined-arch-
arsenm created this revision.
arsenm added a reviewer: tstellarAMD.
arsenm added a subscriber: cfe-commits.
http://reviews.llvm.org/D17520
Files:
lib/Basic/Targets.cpp
test/CodeGenOpenCL/amdgcn-flat-scratch-name.cl
Index: test/CodeGenOpenCL/amdgcn-flat-scratch-name.cl
===
arsenm added a comment.
ping
http://reviews.llvm.org/D16993
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arsenm added inline comments.
Comment at: lib/Basic/Targets.cpp:2059-2063
@@ +2058,7 @@
+
+ if (Has16BitInsts)
+Features["16-bit-insts"] = true;
+
+ if (hasSMemRealTime)
+Features["s-memrealtime"] = true;
+
echristo wrote:
> This is typically more of the
arsenm created this revision.
arsenm added a subscriber: cfe-commits.
http://reviews.llvm.org/D17558
Files:
docs/LanguageExtensions.rst
include/clang/Basic/Builtins.def
lib/CodeGen/CGBuiltin.cpp
test/CodeGen/builtins.c
Index: test/CodeGen/builtins.c
==
arsenm updated this revision to Diff 48879.
arsenm added a comment.
Add long double version. Add the short summary before linking to the intrinsic
doc
http://reviews.llvm.org/D17558
Files:
docs/LanguageExtensions.rst
include/clang/Basic/Builtins.def
lib/CodeGen/CGBuiltin.cpp
test/CodeG
On 05/06/2016 02:53 PM, Richard Smith via cfe-commits wrote:
It looks like we added the noduplicate attribute to clang to support
OpenCL's barrier function. Did we get the semantics for it wrong for
its intended use case?
Yes. Noduplicate is essentially deprecated in favor of convergent.
nodupl
On 05/06/2016 02:42 PM, David Majnemer via cfe-commits wrote:
This example looks wrong to me. It doesn't seem meaningful for a
function to be both readonly and convergent, because convergent means
the call has some side-effect visible to other threads and readonly
means the call has no side-eff
On 05/06/2016 12:11 PM, Anastasia Stulova via cfe-commits wrote:
I was just wondering whether it would make sense to restrict the usage of the attribute
to OpenCL language i.e. to add "let LangOpts = [OpenCL];" in the attribute
definition.
This seems to be a pointless arbitrary restriction to
> On May 6, 2016, at 18:12, Richard Smith via cfe-commits
> wrote:
>
> On Fri, May 6, 2016 at 4:20 PM, Matt Arsenault via cfe-commits
> mailto:cfe-commits@lists.llvm.org>> wrote:
> On 05/06/2016 02:42 PM, David Majnemer via cfe-commits wrote:
> This example looks w
> On May 9, 2016, at 10:39, Anastasia Stulova via cfe-commits
> wrote:
>
> Since it's not a part of any official spec we could of course make it
> accepted with anything.
>
> Just out of curiosity what other programming models supported by Clang do you
> think this attribute would be useful
arsenm added a comment.
Needs tests
http://reviews.llvm.org/D20168
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arsenm added a comment.
Can you add some tests that include arrays, struct within structs and arrays of
structs?
http://reviews.llvm.org/D20168
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
arsenm added a comment.
Some larger and smaller structs too. I think it would be good if single element
structs are replaced with the element type
http://reviews.llvm.org/D20168
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
Author: arsenm
Date: Wed Mar 30 16:32:37 2016
New Revision: 264931
URL: http://llvm.org/viewvc/llvm-project?rev=264931&view=rev
Log:
AMDGPU: Remove separate r600 double data layout
This is identical to the other r600 datalayout string.
Modified:
cfe/trunk/lib/Basic/Targets.cpp
Modified: cfe
arsenm closed this revision.
arsenm added a comment.
r264931
http://reviews.llvm.org/D18472
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: arsenm
Date: Wed Mar 30 17:57:40 2016
New Revision: 264960
URL: http://llvm.org/viewvc/llvm-project?rev=264960&view=rev
Log:
AMDGPU: Add frexp_mant + frexp_exp builtins
Modified:
cfe/trunk/include/clang/Basic/BuiltinsAMDGPU.def
cfe/trunk/lib/CodeGen/CGBuiltin.cpp
cfe/trunk/tes
arsenm closed this revision.
arsenm added a comment.
r264960
http://reviews.llvm.org/D18338
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D18748
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
arsenm added inline comments.
Comment at: lib/Basic/Targets.cpp:1854-1857
@@ -1853,1 +1853,6 @@
+ bool isCLZForZeroUndef() const override {
+// It is -1 instead of expected for intrinsic.
+return true;
+ }
+
tstellarAMD wrote:
> Why do we need to add t
Author: arsenm
Date: Thu Apr 14 17:34:39 2016
New Revision: 266383
URL: http://llvm.org/viewvc/llvm-project?rev=266383&view=rev
Log:
AMDGPU: Add test for generic builtin behavior
Added:
cfe/trunk/test/CodeGenOpenCL/builtins-generic-amdgcn.cl
Added: cfe/trunk/test/CodeGenOpenCL/builtins-gener
arsenm closed this revision.
arsenm added a comment.
r266383
http://reviews.llvm.org/D18473
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arsenm added a comment.
Also some tests for non-kernel functions. We might want to keep this as byval
for calling those
http://reviews.llvm.org/D20168
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
arsenm added a subscriber: arsenm.
Comment at: test/SemaOpenCL/extension-version.cl:12
@@ +11,3 @@
+#ifndef cl_clang_storage_class_specifiers
+#error "Missing cl_clang_storage_class_specifiers define"
+#endif
When the AMD compiler added these warnings a long time
arsenm added inline comments.
Comment at: test/Misc/r600.languageOptsOpenCL.cl:4
@@ +3,3 @@
+// RUN: %clang_cc1 -x cl -cl-std=CL %s -verify -triple r600-unknown-unknown
-target-cpu cypress
+// RUN: %clang_cc1 -x cl -cl-std=CL %s -verify -triple r600-unknown-unknown
-target-cpu t
Author: arsenm
Date: Fri May 27 19:43:27 2016
New Revision: 271080
URL: http://llvm.org/viewvc/llvm-project?rev=271080&view=rev
Log:
AMDGPU: Add fract builtin
Modified:
cfe/trunk/include/clang/Basic/BuiltinsAMDGPU.def
cfe/trunk/lib/CodeGen/CGBuiltin.cpp
cfe/trunk/test/CodeGenOpenCL/bu
Author: arsenm
Date: Tue May 31 11:58:18 2016
New Revision: 271297
URL: http://llvm.org/viewvc/llvm-project?rev=271297&view=rev
Log:
AMDGPU: Update datalayout string
Modified:
cfe/trunk/lib/Basic/Targets.cpp
cfe/trunk/test/CodeGen/target-data.c
Modified: cfe/trunk/lib/Basic/Targets.cpp
U
arsenm added inline comments.
Comment at: lib/Basic/Targets.cpp:2024-2025
@@ -2023,2 +2023,4 @@
Builder.defineMacro("__HAS_LDEXPF__");
+if (hasFP64)
+ Builder.defineMacro("__HAS_FP64__");
}
I don't think we need this. I want device macros for ot
arsenm created this revision.
arsenm added a subscriber: cfe-commits.
http://reviews.llvm.org/D20939
Files:
lib/CodeGen/CodeGenAction.cpp
test/Misc/backend-resource-limit-diagnostics.cl
Index: test/Misc/backend-resource-limit-diagnostics.cl
===
arsenm added a comment.
ping
http://reviews.llvm.org/D17516
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: arsenm
Date: Tue Jun 7 20:56:42 2016
New Revision: 272091
URL: http://llvm.org/viewvc/llvm-project?rev=272091&view=rev
Log:
AMDGPU: Verify subtarget specific builtins
Cleanup setup of subtarget features.
Added:
cfe/trunk/test/CodeGenOpenCL/builtins-amdgcn-error.cl
cfe/trunk/test
arsenm closed this revision.
arsenm added a comment.
r272091
http://reviews.llvm.org/D17516
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rL LLVM
http://reviews.llvm.org/D20388
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/
Author: arsenm
Date: Mon Jun 20 13:13:09 2016
New Revision: 273178
URL: http://llvm.org/viewvc/llvm-project?rev=273178&view=rev
Log:
Update for DiagnosticInfoStackSize changes
Added:
cfe/trunk/test/Misc/backend-resource-limit-diagnostics.cl
Modified:
cfe/trunk/lib/CodeGen/CodeGenAction.cp
arsenm accepted this revision.
arsenm added a reviewer: arsenm.
arsenm added a comment.
This revision is now accepted and ready to land.
r273178
http://reviews.llvm.org/D20939
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm
arsenm added a comment.
ping
http://reviews.llvm.org/D5896
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arsenm updated this revision to Diff 61432.
arsenm added a comment.
Update for trunk
http://reviews.llvm.org/D5896
Files:
include/clang/Basic/Builtins.def
lib/CodeGen/CGBuiltin.cpp
test/CodeGen/builtins.c
Index: test/CodeGen/builtins.c
arsenm added a comment.
In http://reviews.llvm.org/D5896#463883, @hfinkel wrote:
> Why are you removing 'F' from all of the builtin definitions? And if you need
> to, why are you not removing them from copysign?
That marks them as emitting a libcall. It should also be removed from copysign
h
arsenm updated this revision to Diff 61468.
arsenm added a comment.
It appears removing the F isn't actually necessary, unremove it
http://reviews.llvm.org/D5896
Files:
include/clang/Basic/Builtins.def
lib/CodeGen/CGBuiltin.cpp
test/CodeGen/builtins.c
Index: test/CodeGen/builtins.c
=
arsenm updated this revision to Diff 61472.
arsenm added a comment.
Attach right diff
http://reviews.llvm.org/D5896
Files:
lib/CodeGen/CGBuiltin.cpp
test/CodeGen/builtins.c
Index: test/CodeGen/builtins.c
===
--- test/CodeGen/b
arsenm created this revision.
arsenm added a subscriber: cfe-commits.
Herald added a reviewer: tstellarAMD.
Herald added a subscriber: kzhuravl.
http://reviews.llvm.org/D21659
Files:
include/clang/Basic/BuiltinsAMDGPU.def
lib/CodeGen/CGBuiltin.cpp
test/CodeGenOpenCL/builtins-amdgcn.cl
Inde
arsenm added a comment.
ping
http://reviews.llvm.org/D5896
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: arsenm
Date: Mon Jun 27 19:13:17 2016
New Revision: 273965
URL: http://llvm.org/viewvc/llvm-project?rev=273965&view=rev
Log:
AMDGPU: Add builtin to read exec mask
Modified:
cfe/trunk/include/clang/Basic/BuiltinsAMDGPU.def
cfe/trunk/lib/CodeGen/CGBuiltin.cpp
cfe/trunk/test/Code
arsenm closed this revision.
arsenm added a comment.
r273965
http://reviews.llvm.org/D21659
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arsenm added a comment.
ping
http://reviews.llvm.org/D5896
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: arsenm
Date: Fri Jul 1 12:38:14 2016
New Revision: 274370
URL: http://llvm.org/viewvc/llvm-project?rev=274370&view=rev
Log:
Emit more intrinsics for builtin functions
This is important for building libclc. Since r273039 tests are failing
due to now emitting calls to these functions inste
arsenm closed this revision.
arsenm added a comment.
r274370
http://reviews.llvm.org/D5896
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: arsenm
Date: Fri Jul 15 16:33:02 2016
New Revision: 275622
URL: http://llvm.org/viewvc/llvm-project?rev=275622&view=rev
Log:
AMDGPU: Update for rsq intrinsic changes
Modified:
cfe/trunk/include/clang/Basic/BuiltinsAMDGPU.def
cfe/trunk/lib/CodeGen/CGBuiltin.cpp
cfe/trunk/test/C
Author: arsenm
Date: Fri Jul 15 16:33:06 2016
New Revision: 275623
URL: http://llvm.org/viewvc/llvm-project?rev=275623&view=rev
Log:
AMDGPU: Remove legacy ldexp builtin
Modified:
cfe/trunk/include/clang/Basic/BuiltinsAMDGPU.def
cfe/trunk/lib/CodeGen/CGBuiltin.cpp
cfe/trunk/test/CodeGe
Author: arsenm
Date: Mon Jul 18 11:42:50 2016
New Revision: 275813
URL: http://llvm.org/viewvc/llvm-project?rev=275813&view=rev
Log:
Replace llvm.AMDGPU.ldexp with llvm.amdgcn.ldexp
It didn't really work on r600 to begin with, which should
get its own intrinsic.
Added:
libclc/trunk/amdgcn/li
arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D17645
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
Author: arsenm
Date: Sat Feb 27 03:06:26 2016
New Revision: 262124
URL: http://llvm.org/viewvc/llvm-project?rev=262124&view=rev
Log:
AMDGPU: Fix broken/confusing predefined macro
amdgcn should not be defining __R600__
Modified:
cfe/trunk/lib/Basic/Targets.cpp
cfe/trunk/test/Preprocessor/
arsenm closed this revision.
arsenm added a comment.
r262122
http://reviews.llvm.org/D17558
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: arsenm
Date: Sat Feb 27 03:06:18 2016
New Revision: 262122
URL: http://llvm.org/viewvc/llvm-project?rev=262122&view=rev
Log:
Add __builtin_canonicalize
Modified:
cfe/trunk/docs/LanguageExtensions.rst
cfe/trunk/include/clang/Basic/Builtins.def
cfe/trunk/lib/CodeGen/CGBuiltin.cp
Author: arsenm
Date: Sat Feb 27 03:06:22 2016
New Revision: 262123
URL: http://llvm.org/viewvc/llvm-project?rev=262123&view=rev
Log:
AMDGPU: Fix inconsistent register name for flat_scratch
Added:
cfe/trunk/test/CodeGenOpenCL/amdgcn-flat-scratch-name.cl
Modified:
cfe/trunk/lib/Basic/Target
arsenm closed this revision.
arsenm added a comment.
r262123
http://reviews.llvm.org/D17520
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arsenm closed this revision.
arsenm added a comment.
r262124
http://reviews.llvm.org/D17519
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: arsenm
Date: Sat Feb 27 03:54:43 2016
New Revision: 262126
URL: http://llvm.org/viewvc/llvm-project?rev=262126&view=rev
Log:
AMDGPU: Add builtins for recently added intrinsics
Added:
cfe/trunk/test/SemaOpenCL/builtins-amdgcn.cl
Modified:
cfe/trunk/include/clang/Basic/BuiltinsAMDGP
arsenm closed this revision.
arsenm added a comment.
r262126
http://reviews.llvm.org/D17515
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arsenm added inline comments.
Comment at: include/clang/Basic/Attr.td:993-998
@@ +992,8 @@
+
+def AMDGPUToolsInsertNops : InheritableAttr {
+ let Spellings = [GNU<"amdgpu_tools_insert_nops">];
+ let Documentation = [AMDGPUToolsInsertNopsDocs];
+ let Subjects = SubjectList<[Func
arsenm added inline comments.
Comment at: lib/CodeGen/CGCall.cpp:1601
@@ +1600,3 @@
+if (CodeGenOpts.AMDGPUToolsInsertNopsOpt)
+ FuncAttrs.addAttribute("amdgpu_tools_insert_nops");
+if (CodeGenOpts.AMDGPUToolsNumReservedVGPROpt)
Yes
http://reviews.l
arsenm retitled this revision from "Add documentation for bitreverse builtins"
to "Add missing __builtin_bitreverse8".
arsenm updated the summary for this revision.
arsenm updated this revision to Diff 49960.
http://reviews.llvm.org/D16993
Files:
docs/LanguageExtensions.rst
include/clang/Bas
arsenm added a comment.
I directly copied this from the bit reverse intrinsic documentation, so that
will need to be fixed too
From: Arthur O'Dwyer
Sent: Monday, March 7, 2016 11:56 AM
To:
reviews+http://reviews.llvm.org/d16993+public+3e6e84ed28c57...@reviews.
arsenm abandoned this revision.
arsenm added a comment.
Going to redo this with simplified names
http://reviews.llvm.org/D4507
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arsenm added a comment.
ping since there seems to be a consensus now that intrinsics should be preferred
http://reviews.llvm.org/D5896
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: arsenm
Date: Sat Mar 12 23:12:47 2016
New Revision: 263371
URL: http://llvm.org/viewvc/llvm-project?rev=263371&view=rev
Log:
Update for new argument to scalbn
Modified:
cfe/trunk/lib/AST/ExprConstant.cpp
Modified: cfe/trunk/lib/AST/ExprConstant.cpp
URL:
http://llvm.org/viewvc/llvm-p
arsenm added a comment.
ping
http://reviews.llvm.org/D16993
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arsenm added inline comments.
Comment at: docs/LanguageExtensions.rst:1533
@@ +1532,3 @@
+the bitpattern of an integer value; for example ``0b1234567`` becomes
+``0b7654321``.
+
rsmith wrote:
> This example doesn't make much sense: it looks like it's bit reversing
Author: arsenm
Date: Wed Mar 23 17:14:43 2016
New Revision: 264203
URL: http://llvm.org/viewvc/llvm-project?rev=264203&view=rev
Log:
Add missing __builtin_bitreverse8
Also add documentation for bitreverse builtins
Modified:
cfe/trunk/docs/LanguageExtensions.rst
cfe/trunk/include/clang/Ba
arsenm closed this revision.
arsenm added a comment.
r264203
http://reviews.llvm.org/D16993
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arsenm added a comment.
ping
http://reviews.llvm.org/D5896
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arsenm created this revision.
arsenm added a reviewer: tstellarAMD.
arsenm added a subscriber: cfe-commits.
This is the same as the default implementation, but
add a comment and make sure the behavior is tested.
http://reviews.llvm.org/D18473
Files:
lib/Basic/Targets.cpp
test/CodeGenOpenCL/b
arsenm updated this revision to Diff 51636.
arsenm added a comment.
Try to move more code into initFeatureMap.
I'm not sure how the booleans for features in the class are for now. X86 seems
to have them, but it seems they are only used with user specified features? The
only ones that matter rig
arsenm created this revision.
arsenm added a reviewer: tstellarAMD.
arsenm added a subscriber: cfe-commits.
Keep the one still used by libclc that works
around for now.
Emit the new amdgcn intrinsic name if not targeting r600,
in which case the old AMDGPU name is still used.
http://reviews.llvm.
arsenm created this revision.
arsenm added a reviewer: jmolloy.
arsenm added a subscriber: cfe-commits.
Follow the naming convention that bswap uses since it's a
similar sort of operation.
http://reviews.llvm.org/D16482
Files:
include/clang/Basic/Builtins.def
lib/CodeGen/CGBuiltin.cpp
test
arsenm closed this revision.
arsenm added a comment.
r258560
http://reviews.llvm.org/D16444
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: arsenm
Date: Fri Jan 22 15:30:53 2016
New Revision: 258560
URL: http://llvm.org/viewvc/llvm-project?rev=258560&view=rev
Log:
AMDGPU: Rename builtins to use amdgcn prefix
Keep the ones still used by libclc around for now.
Emit the new amdgcn intrinsic name if not targeting r600,
in which
Author: arsenm
Date: Fri Jan 22 15:56:30 2016
New Revision: 258564
URL: http://llvm.org/viewvc/llvm-project?rev=258564&view=rev
Log:
AMDGPU: Add barrier builtin
Modified:
cfe/trunk/include/clang/Basic/BuiltinsAMDGPU.def
cfe/trunk/test/CodeGenOpenCL/builtins-amdgcn.cl
Modified: cfe/trunk/
arsenm created this revision.
arsenm added a reviewer: tstellarAMD.
arsenm added a subscriber: cfe-commits.
http://reviews.llvm.org/D16498
Files:
include/clang/Basic/BuiltinsAMDGPU.def
test/CodeGenOpenCL/builtins-amdgcn.cl
Index: test/CodeGenOpenCL/builtins-amdgcn.cl
Author: arsenm
Date: Tue Jan 26 00:37:54 2016
New Revision: 258794
URL: http://llvm.org/viewvc/llvm-project?rev=258794&view=rev
Log:
AMDGPU: Add amdgcn cube builtins
Modified:
cfe/trunk/include/clang/Basic/BuiltinsAMDGPU.def
cfe/trunk/test/CodeGenOpenCL/builtins-amdgcn.cl
Modified: cfe/t
arsenm added a subscriber: arsenm.
arsenm added a comment.
Add cfe-commits
http://reviews.llvm.org/D16351
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arsenm closed this revision.
arsenm added a comment.
r258794
http://reviews.llvm.org/D16498
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arsenm wrote:
> Sorry, I should have clearly mentioned that. Yes, it is for my followup
> change #80908. In #80908, we changed the type of LLVM builtin but kept the
> corresponding clang builtin unchanged to avoid breaking existing uses.
Don't see how that could be related; you can losslessly
arsenm wrote:
We're gradually converging on something that looks like this, subject to bike
shedding the name
https://github.com/llvm/llvm-project/pull/69229
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailm
701 - 800 of 2504 matches
Mail list logo
