[clang] 3a0309c - [clang] Improve diagnostics for expansion length mismatch

Author: Matheus Izvekov Date: 2022-08-30T18:58:38+02:00 New Revision: 3a0309c53674be56b5cfce038d78a0c2c6e2a98c URL: https://github.com/llvm/llvm-project/commit/3a0309c53674be56b5cfce038d78a0c2c6e2a98c DIFF: https://github.com/llvm/llvm-project/commit/3a0309c53674be56b5cfce038d78a0c2c6e2a98c.dif

[clang] acb767f - [clang] fix profiling of template arguments of template and declaration kind

Author: Matheus Izvekov Date: 2022-09-06T18:27:39+02:00 New Revision: acb767f5cda59302aa9100afcf6133d66779d42c URL: https://github.com/llvm/llvm-project/commit/acb767f5cda59302aa9100afcf6133d66779d42c DIFF: https://github.com/llvm/llvm-project/commit/acb767f5cda59302aa9100afcf6133d66779d42c.dif

[clang] 94c6dfb - [clang] Implement setting crash_diagnostics_dir through env variable

Author: Matheus Izvekov Date: 2022-09-06T19:27:37+02:00 New Revision: 94c6dfbaebbd5b9474794b2437757dfb6aedefc3 URL: https://github.com/llvm/llvm-project/commit/94c6dfbaebbd5b9474794b2437757dfb6aedefc3 DIFF: https://github.com/llvm/llvm-project/commit/94c6dfbaebbd5b9474794b2437757dfb6aedefc3.dif

[clang-tools-extra] d200db3 - [clang] template / auto deduction deduces common sugar

Author: Matheus Izvekov Date: 2022-09-08T19:17:48+02:00 New Revision: d200db38637884fd0b421802c6094b2a03ceb29e URL: https://github.com/llvm/llvm-project/commit/d200db38637884fd0b421802c6094b2a03ceb29e DIFF: https://github.com/llvm/llvm-project/commit/d200db38637884fd0b421802c6094b2a03ceb29e.dif

[clang] d42122c - [clang] use getCommonSugar in an assortment of places

Author: Matheus Izvekov Date: 2022-09-08T19:17:53+02:00 New Revision: d42122cd5db021e6b14a90a98ad1dd09412efb4c URL: https://github.com/llvm/llvm-project/commit/d42122cd5db021e6b14a90a98ad1dd09412efb4c DIFF: https://github.com/llvm/llvm-project/commit/d42122cd5db021e6b14a90a98ad1dd09412efb4c.dif

[clang] 16e5d6d - [clang] extend getCommonSugaredType to merge sugar nodes

Author: Matheus Izvekov Date: 2022-09-08T19:17:53+02:00 New Revision: 16e5d6d7f98f1119aab3d10ec4f9e59b5aacd359 URL: https://github.com/llvm/llvm-project/commit/16e5d6d7f98f1119aab3d10ec4f9e59b5aacd359 DIFF: https://github.com/llvm/llvm-project/commit/16e5d6d7f98f1119aab3d10ec4f9e59b5aacd359.dif

[clang-tools-extra] [clangd] Add test for GH75115 (PR #75116)

https://github.com/mizvekov created https://github.com/llvm/llvm-project/pull/75116 Add test for https://github.com/llvm/llvm-project/issues/75115 >From bd01b0d71c05fa7d728b6db08d14d51fe332ae2c Mon Sep 17 00:00:00 2001 From: Matheus Izvekov Date: Mon, 11 Dec 2023 17:36:44 -0300 Subject: [PATCH

[clang-tools-extra] [clangd] Add test for GH75115 (PR #75116)

https://github.com/mizvekov updated https://github.com/llvm/llvm-project/pull/75116 >From f3c8adf8b08369ba2e90e237957d4205526f64e1 Mon Sep 17 00:00:00 2001 From: Matheus Izvekov Date: Mon, 11 Dec 2023 17:36:44 -0300 Subject: [PATCH] [clangd] Add test for GH75115 Add test for https://github.com

[clang-tools-extra] [clangd] Add test for GH75115 (PR #75116)

https://github.com/mizvekov updated https://github.com/llvm/llvm-project/pull/75116 >From a3971a65e7c7297295a6db154360c205a254c708 Mon Sep 17 00:00:00 2001 From: Matheus Izvekov Date: Mon, 11 Dec 2023 17:36:44 -0300 Subject: [PATCH] [clangd] Add test for GH75115 Add test for https://github.com

[clang-tools-extra] [clangd] Add test for GH75115 (PR #75116)

https://github.com/mizvekov updated https://github.com/llvm/llvm-project/pull/75116 >From 7c18785d74556001cf19d9ae84c8f32f8d95801e Mon Sep 17 00:00:00 2001 From: Matheus Izvekov Date: Mon, 11 Dec 2023 17:36:44 -0300 Subject: [PATCH] [clangd] Add test for GH75115 Add test for https://github.com

[clang-tools-extra] [clangd] Add test for GH75115 (PR #75116)

https://github.com/mizvekov updated https://github.com/llvm/llvm-project/pull/75116 >From 1c9690d87f3a3bbe8389cb9a852d00fe2d3cf478 Mon Sep 17 00:00:00 2001 From: Matheus Izvekov Date: Mon, 11 Dec 2023 17:36:44 -0300 Subject: [PATCH] [clangd] Add test for GH75115 Add test for https://github.com

[clang-tools-extra] [clangd] Add test for GH75115 (PR #75116)

https://github.com/mizvekov closed https://github.com/llvm/llvm-project/pull/75116 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] check for synthesized symbols when tracking include locations (PR #75128)

https://github.com/mizvekov edited https://github.com/llvm/llvm-project/pull/75128 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] check for synthesized symbols when tracking include locations (PR #75128)

https://github.com/mizvekov updated https://github.com/llvm/llvm-project/pull/75128 >From 6f4cc2d6a9af855a12feb03bd81cbc6f7cbf9caf Mon Sep 17 00:00:00 2001 From: Matheus Izvekov Date: Wed, 13 Dec 2023 01:44:16 -0300 Subject: [PATCH] [clangd] check for synthesized symbols when tracking include

[clang-tools-extra] [clangd] Add test for GH75115 (PR #75116)

mizvekov wrote: I see, thanks for pointing it out. I wonder if we support, or otherwise if we should support, a lit requires marker for this. https://github.com/llvm/llvm-project/pull/75116 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[clang-tools-extra] [clangd] check for synthesized symbols when tracking include locations (PR #75128)

https://github.com/mizvekov updated https://github.com/llvm/llvm-project/pull/75128 >From 8b5fa481b399cc49dcdc39c49ed22c7aed0cb844 Mon Sep 17 00:00:00 2001 From: Matheus Izvekov Date: Mon, 11 Dec 2023 17:36:44 -0300 Subject: [PATCH 1/2] [clangd] Add test for GH75115 Add test for https://github

[clang-tools-extra] [clangd] check for synthesized symbols when tracking include locations (PR #75128)

mizvekov wrote: @kadircet ping https://github.com/llvm/llvm-project/pull/75128 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] check for synthesized symbols when tracking include locations (PR #75128)

mizvekov wrote: @kadircet gentle ping https://github.com/llvm/llvm-project/pull/75128 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] check for synthesized symbols when tracking include locations (PR #75128)

https://github.com/mizvekov closed https://github.com/llvm/llvm-project/pull/75128 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 1d1a569 - Clang: fix AST representation of expanded template arguments.

Author: Matheus Izvekov Date: 2022-08-09T14:26:16+02:00 New Revision: 1d1a56929b725f9a79d98877f12d0a14f8418b38 URL: https://github.com/llvm/llvm-project/commit/1d1a56929b725f9a79d98877f12d0a14f8418b38 DIFF: https://github.com/llvm/llvm-project/commit/1d1a56929b725f9a79d98877f12d0a14f8418b38.dif

[clang] 1d68eca - [clang] fix oops: enable implicit moves in MSVC compatibility mode

Author: Matheus Izvekov Date: 2021-07-20T23:32:05+02:00 New Revision: 1d68ecafd6ad9ba8857c78e567abbc58810329c1 URL: https://github.com/llvm/llvm-project/commit/1d68ecafd6ad9ba8857c78e567abbc58810329c1 DIFF: https://github.com/llvm/llvm-project/commit/1d68ecafd6ad9ba8857c78e567abbc58810329c1.dif

[clang] 20555a1 - [clang] P2266 implicit moves STL workaround

Author: Matheus Izvekov Date: 2021-07-26T22:21:31+02:00 New Revision: 20555a15a596012ef827e29b665db53a4fc0b86c URL: https://github.com/llvm/llvm-project/commit/20555a15a596012ef827e29b665db53a4fc0b86c DIFF: https://github.com/llvm/llvm-project/commit/20555a15a596012ef827e29b665db53a4fc0b86c.dif

[clang] 4819b75 - [clang] NFC: change uses of `Expr->getValueKind` into `is?Value`

Author: Matheus Izvekov Date: 2021-07-28T03:09:31+02:00 New Revision: 4819b751bd875f458eb0060f7c586aa9ac41965c URL: https://github.com/llvm/llvm-project/commit/4819b751bd875f458eb0060f7c586aa9ac41965c DIFF: https://github.com/llvm/llvm-project/commit/4819b751bd875f458eb0060f7c586aa9ac41965c.dif

[clang] 0c7cd4a - [clang] NFC: refactor multiple implementations of getDecltypeForParenthesizedExpr

Author: Matheus Izvekov Date: 2021-07-28T23:27:43+02:00 New Revision: 0c7cd4a873138f2116403a733274c8cb7dbf925f URL: https://github.com/llvm/llvm-project/commit/0c7cd4a873138f2116403a733274c8cb7dbf925f DIFF: https://github.com/llvm/llvm-project/commit/0c7cd4a873138f2116403a733274c8cb7dbf925f.dif

[clang] 87aa318 - [clang] fix concepts crash on substitution failure during normalization

Author: Matheus Izvekov Date: 2021-07-28T23:28:45+02:00 New Revision: 87aa31827b293127619e2ef96e80baf709eae338 URL: https://github.com/llvm/llvm-project/commit/87aa31827b293127619e2ef96e80baf709eae338 DIFF: https://github.com/llvm/llvm-project/commit/87aa31827b293127619e2ef96e80baf709eae338.dif

[clang] [C++20] [Modules] Introduce -fskip-odr-check-in-gmf (PR #79959)

mizvekov wrote: @dwblaikie The flag is for our own use within LLVM test suite. With the previous change, we were unconditionally weakening standards conformance and runtime checking, because there are a bunch of bugs which are believed to be mostly harmless. However, if we do that without some

[clang] [C++20] [Modules] Introduce -fskip-odr-check-in-gmf (PR #79959)

https://github.com/mizvekov edited https://github.com/llvm/llvm-project/pull/79959 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [C++20] [Modules] Introduce -fskip-odr-check-in-gmf (PR #79959)

https://github.com/mizvekov commented: On the Implementation side, this looks good, just some concerns regarding documentation. https://github.com/llvm/llvm-project/pull/79959 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[clang] [C++20] [Modules] Introduce -fskip-odr-check-in-gmf (PR #79959)

@@ -457,6 +457,28 @@ Note that **currently** the compiler doesn't consider inconsistent macro definit Currently Clang would accept the above example. But it may produce surprising results if the debugging code depends on consistent use of ``NDEBUG`` also in other translation

[clang] [C++20] [Modules] Introduce -fskip-odr-check-in-gmf (PR #79959)

@@ -3940,6 +3940,14 @@ static bool RenderModulesOptions(Compilation &C, const Driver &D, Args.ClaimAllArgs(options::OPT_fmodules_disable_diagnostic_validation); } + // Don't check ODR violations for decls in the global module fragment. + // 1. To keep consistent behav

[clang] [C++20] [Modules] Introduce -fskip-odr-check-in-gmf (PR #79959)

@@ -457,6 +457,28 @@ Note that **currently** the compiler doesn't consider inconsistent macro definit Currently Clang would accept the above example. But it may produce surprising results if the debugging code depends on consistent use of ``NDEBUG`` also in other translation

[clang] [C++20] [Modules] Introduce -fskip-odr-check-in-gmf (PR #79959)

@@ -457,6 +457,28 @@ Note that **currently** the compiler doesn't consider inconsistent macro definit Currently Clang would accept the above example. But it may produce surprising results if the debugging code depends on consistent use of ``NDEBUG`` also in other translation

[clang] [C++20] [Modules] Introduce -fskip-odr-check-in-gmf (PR #79959)

@@ -457,6 +457,28 @@ Note that **currently** the compiler doesn't consider inconsistent macro definit Currently Clang would accept the above example. But it may produce surprising results if the debugging code depends on consistent use of ``NDEBUG`` also in other translation

[clang] [C++20] [Modules] Introduce -fskip-odr-check-in-gmf (PR #79959)

@@ -457,6 +457,28 @@ Note that **currently** the compiler doesn't consider inconsistent macro definit Currently Clang would accept the above example. But it may produce surprising results if the debugging code depends on consistent use of ``NDEBUG`` also in other translation

[clang] [C++20] [Modules] Introduce -fskip-odr-check-in-gmf (PR #79959)

@@ -457,6 +457,28 @@ Note that **currently** the compiler doesn't consider inconsistent macro definit Currently Clang would accept the above example. But it may produce surprising results if the debugging code depends on consistent use of ``NDEBUG`` also in other translation

[clang] [C++20] [Modules] Introduce -fskip-odr-check-in-gmf (PR #79959)

https://github.com/mizvekov approved this pull request. https://github.com/llvm/llvm-project/pull/79959 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Users/mizvekov/bug/clang merge usingshadowdecl (PR #80245)

https://github.com/mizvekov created https://github.com/llvm/llvm-project/pull/80245 [clang] fix merging of UsingShadowDecl Previously, when deciding if two UsingShadowDecls where mergeable, we would incorrectly only look for both pointing to the exact redecla ration, whereas the correct thing i

[clang] [clang] fix merging of UsingShadowDecl (PR #80245)

mizvekov wrote: Hmm I have been doing user branches for a while, this saves me time in case I want to split the patch off in a separate MR. It's already the case that this is split into test adding + fixing commits. In any case, the user branch will be deleted as soon as this is merged. Can we

[clang] [clang] fix merging of UsingShadowDecl (PR #80245)

@@ -181,6 +181,9 @@ Bug Fixes to C++ Support and (`#79745 `_) - Fix incorrect code generation caused by the object argument of ``static operator()`` and ``static operator[]`` calls not being evaluated. Fixes (`#67976

[clang] [clang] fix merging of UsingShadowDecl (PR #80245)

https://github.com/mizvekov edited https://github.com/llvm/llvm-project/pull/80245 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] fix merging of UsingShadowDecl (PR #80245)

https://github.com/mizvekov updated https://github.com/llvm/llvm-project/pull/80245 >From 23a0d731cfe8593c338fc8ad7920f7aa9270afaa Mon Sep 17 00:00:00 2001 From: Matheus Izvekov Date: Thu, 1 Feb 2024 02:07:16 -0300 Subject: [PATCH 1/2] [NFC] [clang] add test for merging of UsingShadowDecl ---

[clang] [clang] fix merging of UsingShadowDecl (PR #80245)

@@ -181,6 +181,9 @@ Bug Fixes to C++ Support and (`#79745 `_) - Fix incorrect code generation caused by the object argument of ``static operator()`` and ``static operator[]`` calls not being evaluated. Fixes (`#67976

[clang] [clang] fix merging of UsingShadowDecl (PR #80245)

@@ -0,0 +1,42 @@ +// RUN: rm -rf %t +// RUN: split-file %s %t +// RUN: cd %t +// +// RUN: %clang_cc1 -std=c++20 -I %t %t/A.cppm -emit-module-interface -o %t/A.pcm -verify +// RUN: %clang_cc1 -std=c++20 -I %t %t/B.cpp -fmodule-file=A=%t/A.pcm -fsyntax-only -verify -ast-dump-all -

[clang] [clang] fix merging of UsingShadowDecl (PR #80245)

mizvekov wrote: The issue is up: https://github.com/llvm/llvm-project/issues/80252 https://github.com/llvm/llvm-project/pull/80245 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] fix merging of UsingShadowDecl (PR #80245)

mizvekov wrote: > IIRC, in #79959, you're saying the patch have the potential to fix #78850? Is > it true? Yeah, looking at the similarities, there is a decent chance this is the same issue, it's worth trying it out. https://github.com/llvm/llvm-project/pull/80245

[clang] [clang] fix merging of UsingShadowDecl (PR #80245)

https://github.com/mizvekov updated https://github.com/llvm/llvm-project/pull/80245 >From 8823a7ec248c7220395f53634467aa25f5007206 Mon Sep 17 00:00:00 2001 From: Matheus Izvekov Date: Thu, 1 Feb 2024 02:07:16 -0300 Subject: [PATCH 1/2] [NFC] [clang] add tests for merging of UsingShadowDecl ---

[clang] [clang] fix merging of UsingShadowDecl (PR #80245)

mizvekov wrote: I have rebased on top of the change which reenables GMF ODR checker on the test suite, so I added a new regression test that exercises the false positive ODR violation. https://github.com/llvm/llvm-project/pull/80245 ___ cfe-commits m

[clang] [clang] fix merging of UsingShadowDecl (PR #80245)

mizvekov wrote: I took a look at what sort of complexity unittest would entail here. I don't think it's a good compromise complexity wise, it's a lot of boilerplate just to test a few AST nodes are correctly linked. On the other hand, these AST tests don't look particularly out of place compa

[clang] [clang] fix merging of UsingShadowDecl (PR #80245)

https://github.com/mizvekov updated https://github.com/llvm/llvm-project/pull/80245 >From f7340f3781a3e3094169c970aadb9b69414543f5 Mon Sep 17 00:00:00 2001 From: Matheus Izvekov Date: Thu, 1 Feb 2024 02:07:16 -0300 Subject: [PATCH 1/2] [NFC] [clang] add tests for merging of UsingShadowDecl ---

[clang] [clang] fix merging of UsingShadowDecl (PR #80245)

mizvekov wrote: I just pushed the change on this patch. What I meant is this patch will get, besides aforementioned regression test involving ODR checker failure, a simpler AST test that verifies just the UsingShadowDecl is correctly merged. https://github.com/llvm/llvm-project/pull/80245

[clang] [clang] fix merging of UsingShadowDecl (PR #80245)

mizvekov wrote: There is a lot of activity going on just in `clang/test/AST`, with multiple commits a day. I think there is a time and place, and the right tradeoffs for all kinds of tests we have. Shall we get others opinions? Shall we make an RFC so we get the community aligned on this new di

[clang] [clang] fix merging of UsingShadowDecl (PR #80245)

https://github.com/mizvekov updated https://github.com/llvm/llvm-project/pull/80245 >From 7bd920a14240c85442467706236e0644f320aa5c Mon Sep 17 00:00:00 2001 From: Matheus Izvekov Date: Thu, 1 Feb 2024 02:07:16 -0300 Subject: [PATCH 1/2] [NFC] [clang] add tests for merging of UsingShadowDecl ---

[clang] [clang] fix merging of UsingShadowDecl (PR #80245)

@@ -0,0 +1,40 @@ +// RUN: rm -rf %t +// RUN: split-file %s %t +// RUN: cd %t +// +// RUN: %clang_cc1 -std=c++20 -I %t %t/A.cppm -emit-module-interface -o %t/A.pcm -verify +// RUN: %clang_cc1 -std=c++20 -I %t %t/B.cppm -emit-module-interface -o %t/B.pcm -verify +// RUN: %clang_cc

[clang] [clang] Make sure the same UsingType is searched and inserted (PR #79182)

mizvekov wrote: The change is correct. The problem is subtle though. It comes from the difference in behavior between the member and non-member Profile functions. I think we could do better instead with a change which makes it harder to trip on this. I think a simplification like this should

[clang] [clang] Make sure the same UsingType is searched and inserted (PR #79182)

mizvekov wrote: > Wonder what test should I add here. This only affects the content of the > internal folding set so we always create new types but result is still > correct. One possibility is doing an AST test, there are some examples in there that show how you can test two different AST no

[clang] [clang] Make sure the same UsingType is searched and inserted (PR #79182)

mizvekov wrote: LGTM. Thanks! https://github.com/llvm/llvm-project/pull/79182 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Make sure the same UsingType is searched and inserted (PR #79182)

https://github.com/mizvekov approved this pull request. https://github.com/llvm/llvm-project/pull/79182 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [Docs][LTO] Updated HowToSubmitABug.rst for LTO crashes (PR #68389)

@@ -153,6 +153,67 @@ Please run this, then file a bug with the instructions and reduced .bc file that bugpoint emits. If something goes wrong with bugpoint, please submit the "foo.bc" file and the option that llc crashes with. +LTO bugs +--- + +If you

[clang] [Docs][LTO] Updated HowToSubmitABug.rst for LTO crashes (PR #68389)

@@ -153,6 +153,67 @@ Please run this, then file a bug with the instructions and reduced .bc file that bugpoint emits. If something goes wrong with bugpoint, please submit the "foo.bc" file and the option that llc crashes with. +LTO bugs +--- + +If you

[clang-tools-extra] [Docs][LTO] Updated HowToSubmitABug.rst for LTO crashes (PR #68389)

@@ -153,6 +153,67 @@ Please run this, then file a bug with the instructions and reduced .bc file that bugpoint emits. If something goes wrong with bugpoint, please submit the "foo.bc" file and the option that llc crashes with. +LTO bugs +--- + +If you

[clang] [Docs][LTO] Updated HowToSubmitABug.rst for LTO crashes (PR #68389)

@@ -153,6 +153,67 @@ Please run this, then file a bug with the instructions and reduced .bc file that bugpoint emits. If something goes wrong with bugpoint, please submit the "foo.bc" file and the option that llc crashes with. +LTO bugs +--- + +If you

[clang-tools-extra] [Docs][LTO] Updated HowToSubmitABug.rst for LTO crashes (PR #68389)

@@ -153,6 +153,67 @@ Please run this, then file a bug with the instructions and reduced .bc file that bugpoint emits. If something goes wrong with bugpoint, please submit the "foo.bc" file and the option that llc crashes with. +LTO bugs +--- + +If you

[clang] [Docs][LTO] Updated HowToSubmitABug.rst for LTO crashes (PR #68389)

https://github.com/mizvekov edited https://github.com/llvm/llvm-project/pull/68389 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [Docs][LTO] Updated HowToSubmitABug.rst for LTO crashes (PR #68389)

https://github.com/mizvekov edited https://github.com/llvm/llvm-project/pull/68389 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Driver] Add new flags to control machine instruction verification (PR #70282)

https://github.com/mizvekov created https://github.com/llvm/llvm-project/pull/70282 Present shortcomings are that this only works for non-LTO builds, and that this new pass doesn't work quite the same as the IR verification flag, as it runs between every machine pass and is thus much more expe

[clang] [Clang][Driver] Add new flags to control machine instruction verification (PR #70282)

https://github.com/mizvekov updated https://github.com/llvm/llvm-project/pull/70282 >From 9f3711c112159c57becae105561bc988a0caaeb5 Mon Sep 17 00:00:00 2001 From: Matheus Izvekov Date: Thu, 26 Oct 2023 06:07:57 +0200 Subject: [PATCH 1/2] [clang][driver] remove accidentally added NoXarchOption f

[clang] [Clang][Driver] Add new flags to control machine instruction verification (PR #70282)

@@ -1926,6 +1926,12 @@ def fverify_intermediate_code : Flag<["-"], "fverify-intermediate-code">, def fno_verify_intermediate_code : Flag<["-"], "fno-verify-intermediate-code">, Group, Visibility<[ClangOption, CLOption, DXCOption]>, HelpText<"Disable verification of LLVM IR

[clang] [Clang][Driver] Add new flags to control machine instruction verification (PR #70282)

https://github.com/mizvekov updated https://github.com/llvm/llvm-project/pull/70282 >From b2006f46ebfd1da17014cf6c577da4700c355d00 Mon Sep 17 00:00:00 2001 From: Matheus Izvekov Date: Wed, 4 Oct 2023 12:09:15 +0200 Subject: [PATCH] [Clang][Driver] Add new flags to control machine instruction v

[clang] [Clang][Driver] Add new flags to control machine instruction verification (PR #70282)

@@ -1926,6 +1926,12 @@ def fverify_intermediate_code : Flag<["-"], "fverify-intermediate-code">, def fno_verify_intermediate_code : Flag<["-"], "fno-verify-intermediate-code">, Group, Visibility<[ClangOption, CLOption, DXCOption]>, HelpText<"Disable verification of LLVM IR

[clang] [Clang][Driver] Add new flags to control machine instruction verification (PR #70282)

mizvekov wrote: I don't disagree that if we stop at this step, then the flag doesn't buy much. But it would be worthwhile if we ever implemented LTO integration or implemented a lightweight machine verification which runs the pass 1 or 2 times, which would work similarly to the IR verification

[clang] d9308aa - [clang] don't mark as Elidable CXXConstruct expressions used in NRVO

Author: Matheus Izvekov Date: 2021-09-21T21:41:20+02:00 New Revision: d9308aa39b236064a680ca57178af3c731e13e49 URL: https://github.com/llvm/llvm-project/commit/d9308aa39b236064a680ca57178af3c731e13e49 DIFF: https://github.com/llvm/llvm-project/commit/d9308aa39b236064a680ca57178af3c731e13e49.dif

[clang] 37adc4f - [clang] set templates as invalid when any of the parameters are invalid

Author: Matheus Izvekov Date: 2021-09-25T04:04:47+02:00 New Revision: 37adc4f957c2383a625e2e593ba1d18a25d92b91 URL: https://github.com/llvm/llvm-project/commit/37adc4f957c2383a625e2e593ba1d18a25d92b91 DIFF: https://github.com/llvm/llvm-project/commit/37adc4f957c2383a625e2e593ba1d18a25d92b91.dif

[clang] 1f6458c - [clang] NFC: remove duplicated code around type constraint and templ arg subst

Author: Matheus Izvekov Date: 2021-09-29T23:05:46+02:00 New Revision: 1f6458cb1944b69f052db463e5f2c6304f16b256 URL: https://github.com/llvm/llvm-project/commit/1f6458cb1944b69f052db463e5f2c6304f16b256 DIFF: https://github.com/llvm/llvm-project/commit/1f6458cb1944b69f052db463e5f2c6304f16b256.dif

[clang] af10d6f - [clang] don't instantiate templates with injected arguments

Author: Matheus Izvekov Date: 2021-09-29T23:19:13+02:00 New Revision: af10d6f350ff3e92c6ffae66cc9dac36884cdd55 URL: https://github.com/llvm/llvm-project/commit/af10d6f350ff3e92c6ffae66cc9dac36884cdd55 DIFF: https://github.com/llvm/llvm-project/commit/af10d6f350ff3e92c6ffae66cc9dac36884cdd55.dif

[clang] c25572b - [clang] NFC: rename SK_CastDerivedToBaseRValue to SK_CastDerivedToBasePRValue

Author: Matheus Izvekov Date: 2021-06-09T12:38:59+02:00 New Revision: c25572bf2993438f24b57d859d072e8b2aa975d2 URL: https://github.com/llvm/llvm-project/commit/c25572bf2993438f24b57d859d072e8b2aa975d2 DIFF: https://github.com/llvm/llvm-project/commit/c25572bf2993438f24b57d859d072e8b2aa975d2.dif

[clang] 667fbcd - [clang] NRVO: Improvements and handling of more cases.

Author: Matheus Izvekov Date: 2021-06-10T23:02:51+02:00 New Revision: 667fbcdd0b2ee5e78f5ce9789b862e3bbca94644 URL: https://github.com/llvm/llvm-project/commit/667fbcdd0b2ee5e78f5ce9789b862e3bbca94644 DIFF: https://github.com/llvm/llvm-project/commit/667fbcdd0b2ee5e78f5ce9789b862e3bbca94644.dif

[clang] cbd0054 - [clang] Implement P2266 Simpler implicit move

Author: Matheus Izvekov Date: 2021-06-11T00:56:06+02:00 New Revision: cbd0054b9eb17ec48f0702e3828209646c8f5ebd URL: https://github.com/llvm/llvm-project/commit/cbd0054b9eb17ec48f0702e3828209646c8f5ebd DIFF: https://github.com/llvm/llvm-project/commit/cbd0054b9eb17ec48f0702e3828209646c8f5ebd.dif

[clang] 1e50c3d - [clang] NRVO: Improvements and handling of more cases.

Author: Matheus Izvekov Date: 2021-06-12T16:43:32+02:00 New Revision: 1e50c3d785f4563873ab1ce86559f2a1285b5678 URL: https://github.com/llvm/llvm-project/commit/1e50c3d785f4563873ab1ce86559f2a1285b5678 DIFF: https://github.com/llvm/llvm-project/commit/1e50c3d785f4563873ab1ce86559f2a1285b5678.dif

[clang] bf20631 - [clang] Implement P2266 Simpler implicit move

Author: Matheus Izvekov Date: 2021-06-13T12:10:56+02:00 New Revision: bf20631782183cd19e0bb7219e908c2bbb01a75f URL: https://github.com/llvm/llvm-project/commit/bf20631782183cd19e0bb7219e908c2bbb01a75f DIFF: https://github.com/llvm/llvm-project/commit/bf20631782183cd19e0bb7219e908c2bbb01a75f.dif

[clang] 12c90e2 - [clang] NRVO: Improvements and handling of more cases.

Author: Matheus Izvekov Date: 2021-06-17T01:56:38+02:00 New Revision: 12c90e2e25dfd1d38250055efc21acb42d158912 URL: https://github.com/llvm/llvm-project/commit/12c90e2e25dfd1d38250055efc21acb42d158912 DIFF: https://github.com/llvm/llvm-project/commit/12c90e2e25dfd1d38250055efc21acb42d158912.dif

[clang] b88eb85 - [clang] use correct builtin type for defaulted comparison analyzer

Author: Matheus Izvekov Date: 2021-06-17T02:08:31+02:00 New Revision: b88eb855b53184161ad1ea0eea1962100941cf0b URL: https://github.com/llvm/llvm-project/commit/b88eb855b53184161ad1ea0eea1962100941cf0b DIFF: https://github.com/llvm/llvm-project/commit/b88eb855b53184161ad1ea0eea1962100941cf0b.dif

[clang] 7ddd15c - [clang] Exclude function pointers on DefaultedComparisonAnalyzer

Author: Matheus Izvekov Date: 2021-06-18T13:07:47+02:00 New Revision: 7ddd15cd5dea76a19a9c5315e2a9903d74a49be8 URL: https://github.com/llvm/llvm-project/commit/7ddd15cd5dea76a19a9c5315e2a9903d74a49be8 DIFF: https://github.com/llvm/llvm-project/commit/7ddd15cd5dea76a19a9c5315e2a9903d74a49be8.dif

[clang] ced6b20 - [clang] Implement P2266 Simpler implicit move

Author: Matheus Izvekov Date: 2021-06-18T17:08:59+02:00 New Revision: ced6b204d18e6eed611f8ebf27122ec19147ea7a URL: https://github.com/llvm/llvm-project/commit/ced6b204d18e6eed611f8ebf27122ec19147ea7a DIFF: https://github.com/llvm/llvm-project/commit/ced6b204d18e6eed611f8ebf27122ec19147ea7a.dif

[clang] 219790c - [clang] fix canonicalization of nested name specifiers

Author: Matheus Izvekov Date: 2021-08-03T22:39:48+02:00 New Revision: 219790c1f53665a8b5f7578472e5c2675f9bec6a URL: https://github.com/llvm/llvm-project/commit/219790c1f53665a8b5f7578472e5c2675f9bec6a DIFF: https://github.com/llvm/llvm-project/commit/219790c1f53665a8b5f7578472e5c2675f9bec6a.dif

[clang] e64e692 - [clang] fix crash on template instantiation of invalid requires expressions

Author: Matheus Izvekov Date: 2021-08-03T23:16:04+02:00 New Revision: e64e6924b8aef8d48117beb6e87162109ac2512c URL: https://github.com/llvm/llvm-project/commit/e64e6924b8aef8d48117beb6e87162109ac2512c DIFF: https://github.com/llvm/llvm-project/commit/e64e6924b8aef8d48117beb6e87162109ac2512c.dif

[clang] ad14b5b - [clang] Stop providing builtin overload candidate for relational function pointer comparisons

Author: Matheus Izvekov Date: 2021-06-26T00:08:02+02:00 New Revision: ad14b5b008e2f643cb989ec645f12bf26a8659bb URL: https://github.com/llvm/llvm-project/commit/ad14b5b008e2f643cb989ec645f12bf26a8659bb DIFF: https://github.com/llvm/llvm-project/commit/ad14b5b008e2f643cb989ec645f12bf26a8659bb.dif

[clang] d6144c3 - [clang] add C++ feature test macro for P2266 simpler implicit move

Author: Matheus Izvekov Date: 2021-06-26T23:05:23+02:00 New Revision: d6144c30fb6ae7ac15c82d512f8da7572577c2d2 URL: https://github.com/llvm/llvm-project/commit/d6144c30fb6ae7ac15c82d512f8da7572577c2d2 DIFF: https://github.com/llvm/llvm-project/commit/d6144c30fb6ae7ac15c82d512f8da7572577c2d2.dif

[clang] 7d2d5a3 - [clang] Apply P1825 as Defect Report from C++11 up to C++20.

Author: Matheus Izvekov Date: 2021-07-01T12:10:06+02:00 New Revision: 7d2d5a3a6d7aaa40468c30250bf6b0938ef02c08 URL: https://github.com/llvm/llvm-project/commit/7d2d5a3a6d7aaa40468c30250bf6b0938ef02c08 DIFF: https://github.com/llvm/llvm-project/commit/7d2d5a3a6d7aaa40468c30250bf6b0938ef02c08.dif

[clang] 2110638 - [clang] fixes named return of variables with dependent alignment

Author: Matheus Izvekov Date: 2021-07-06T02:30:44+02:00 New Revision: 21106388eb96c87b3f580c42a322c76a61605261 URL: https://github.com/llvm/llvm-project/commit/21106388eb96c87b3f580c42a322c76a61605261 DIFF: https://github.com/llvm/llvm-project/commit/21106388eb96c87b3f580c42a322c76a61605261.dif

[clang] f2d5fce - [clang] fixes named return of variables with dependent alignment

Author: Matheus Izvekov Date: 2021-07-07T02:54:55+02:00 New Revision: f2d5fce86e81a8b37fbc0829a1c68b6eb48f8365 URL: https://github.com/llvm/llvm-project/commit/f2d5fce86e81a8b37fbc0829a1c68b6eb48f8365 DIFF: https://github.com/llvm/llvm-project/commit/f2d5fce86e81a8b37fbc0829a1c68b6eb48f8365.dif

[clang] 2c60d22 - [clang] disable P2266 simpler implicit moves under -fms-compatibility

Author: Matheus Izvekov Date: 2021-07-08T00:13:11+02:00 New Revision: 2c60d22610325bcd6fb4c4bcc8b522b9fdfb46ee URL: https://github.com/llvm/llvm-project/commit/2c60d22610325bcd6fb4c4bcc8b522b9fdfb46ee DIFF: https://github.com/llvm/llvm-project/commit/2c60d22610325bcd6fb4c4bcc8b522b9fdfb46ee.dif

[clang] 5a1c504 - [clang] fix constexpr code generation for user conversions.

Author: Matheus Izvekov Date: 2021-07-08T20:23:19+02:00 New Revision: 5a1c50410ccc1973a1a0a4acca0c01677c28e9b6 URL: https://github.com/llvm/llvm-project/commit/5a1c50410ccc1973a1a0a4acca0c01677c28e9b6 DIFF: https://github.com/llvm/llvm-project/commit/5a1c50410ccc1973a1a0a4acca0c01677c28e9b6.dif

[clang] 03282f2 - [clang] C++98 implicit moves are back with a vengeance

Author: Matheus Izvekov Date: 2021-07-13T19:16:49+02:00 New Revision: 03282f2fe14e9dd61aaeeda3785f56c7ccb4f3c9 URL: https://github.com/llvm/llvm-project/commit/03282f2fe14e9dd61aaeeda3785f56c7ccb4f3c9 DIFF: https://github.com/llvm/llvm-project/commit/03282f2fe14e9dd61aaeeda3785f56c7ccb4f3c9.dif

[clang] 2d7fba5 - [clang] deprecate frelaxed-template-template-args, make it on by default

Author: Matheus Izvekov Date: 2021-10-27T22:48:27+02:00 New Revision: 2d7fba5f95f0614f6f2c4a4ed966b307d617898b URL: https://github.com/llvm/llvm-project/commit/2d7fba5f95f0614f6f2c4a4ed966b307d617898b DIFF: https://github.com/llvm/llvm-project/commit/2d7fba5f95f0614f6f2c4a4ed966b307d617898b.dif

[clang] 086e111 - [clang] NFC: include non friendly types and missing sugar in test expectations

Author: Matheus Izvekov Date: 2021-10-27T23:03:29+02:00 New Revision: 086e111216bc4fb8065aa7ef4bc226380d1c237e URL: https://github.com/llvm/llvm-project/commit/086e111216bc4fb8065aa7ef4bc226380d1c237e DIFF: https://github.com/llvm/llvm-project/commit/086e111216bc4fb8065aa7ef4bc226380d1c237e.dif

[clang] c9fd92d - [clang] Improve diagnostics on implicitly deleted defaulted comparisons

Author: Matheus Izvekov Date: 2021-03-13T01:13:52+01:00 New Revision: c9fd92d573988c59b7a613f07909596cdad36095 URL: https://github.com/llvm/llvm-project/commit/c9fd92d573988c59b7a613f07909596cdad36095 DIFF: https://github.com/llvm/llvm-project/commit/c9fd92d573988c59b7a613f07909596cdad36095.dif

[clang] d4a8c73 - [clang] Fix ICE on invalid type parameters for concepts

Author: Matheus Izvekov Date: 2021-03-13T01:23:02+01:00 New Revision: d4a8c7359b57bafc7bfa2a9dea30017fb0153c1a URL: https://github.com/llvm/llvm-project/commit/d4a8c7359b57bafc7bfa2a9dea30017fb0153c1a DIFF: https://github.com/llvm/llvm-project/commit/d4a8c7359b57bafc7bfa2a9dea30017fb0153c1a.dif

[clang] 9fec50f - [cmake] use project relative paths when generating ASTNodeAPI.json

Author: Matheus Izvekov Date: 2021-11-15T12:35:34+01:00 New Revision: 9fec50f001b1ab86ff36c6e92336ae1c1d3fcdef URL: https://github.com/llvm/llvm-project/commit/9fec50f001b1ab86ff36c6e92336ae1c1d3fcdef DIFF: https://github.com/llvm/llvm-project/commit/9fec50f001b1ab86ff36c6e92336ae1c1d3fcdef.dif

[clang] 21ed00b - [clang] NFC: rename internal `IsPossiblyOpaquelyQualifiedType` overload

Author: Matheus Izvekov Date: 2021-11-16T03:09:50+01:00 New Revision: 21ed00bc1bfd2b0b81d288f7f096a31079c24c4a URL: https://github.com/llvm/llvm-project/commit/21ed00bc1bfd2b0b81d288f7f096a31079c24c4a DIFF: https://github.com/llvm/llvm-project/commit/21ed00bc1bfd2b0b81d288f7f096a31079c24c4a.dif

[clang] 85914b7 - [clang] fix regression deducing pack expansion arguments introduced by D110216

Author: Matheus Izvekov Date: 2021-11-19T03:36:20+01:00 New Revision: 85914b757015dfbc780dc254696acb95b8dc7679 URL: https://github.com/llvm/llvm-project/commit/85914b757015dfbc780dc254696acb95b8dc7679 DIFF: https://github.com/llvm/llvm-project/commit/85914b757015dfbc780dc254696acb95b8dc7679.dif

  1   2   3   4   5   6   7   8   9   10   >