[PATCH] D97990: [clang] Improve diagnostics on implicitly deleted defaulted comparisons

mizvekov added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8968-8970 def note_defaulted_comparison_calls_deleted : Note< "defaulted %0 is implicitly deleted because it would invoke a deleted " "comparison function%select{| for member %2| f

[PATCH] D97990: [clang] Improve diagnostics on implicitly deleted defaulted comparisons

This revision was automatically updated to reflect the committed changes. Closed by commit rGc9fd92d57398: [clang] Improve diagnostics on implicitly deleted defaulted comparisons (authored by mizvekov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D9

[PATCH] D98095: [clang] Fix ICE on invalid type parameters for concepts

This revision was automatically updated to reflect the committed changes. Closed by commit rGd4a8c7359b57: [clang] Fix ICE on invalid type parameters for concepts (authored by mizvekov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98095/new/ https

[PATCH] D98160: [clang] Use decltype((E)) for compound requirement type constraint

mizvekov updated this revision to Diff 330484. mizvekov added a comment. - Uses yet another simpler approach: Since dependence should not matter (we were using the type of the expression after template instantiation anyway), we don't even need to build a `decltype` type here, and just get the ca

[PATCH] D97990: [clang] Improve diagnostics on implicitly deleted defaulted comparisons

mizvekov added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8968-8970 def note_defaulted_comparison_calls_deleted : Note< "defaulted %0 is implicitly deleted because it would invoke a deleted " "comparison function%select{| for member %2| f

[PATCH] D98160: [clang] Use decltype((E)) for compound requirement type constraint

mizvekov updated this revision to Diff 330493. mizvekov added a comment. lint Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98160/new/ https://reviews.llvm.org/D98160 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/include/clang/

[PATCH] D98160: [clang] Use decltype((E)) for compound requirement type constraint

mizvekov updated this revision to Diff 330775. mizvekov added a comment. broken bot rebuild repush Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98160/new/ https://reviews.llvm.org/D98160 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

mizvekov added a comment. Okay, libcxx pipeline passes, disregarding the clang-format failure for pre-existing badness in those files, which would need to be fixed separately or else git loses track of the rename. The AIX failures also seem completely unrelated. Repository: rG LLVM Github Mo

[PATCH] D113664: [cmake] use project relative paths when generating ASTNodeAPI.json

This revision was automatically updated to reflect the committed changes. Closed by commit rG9fec50f001b1: [cmake] use project relative paths when generating ASTNodeAPI.json (authored by mizvekov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113664

[PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

mizvekov added a comment. In D110216#3130184 , @mstorsjo wrote: > Do you happen to know what's going on here? The files mentioned are > https://code.qt.io/cgit/qt/qtbase.git/tree/src/3rdparty/angle/src/libANGLE/renderer/d3d/d3d11/ResourceManager11.cpp?h=

[PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

mizvekov reopened this revision. mizvekov added a comment. Reverting for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110216/new/ https://reviews.llvm.org/D110216 ___ cfe-commits mailing list cfe-c

[PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

mizvekov added a comment. FYI this is a minimal repro taken from Martin's preprocessed source (Thanks!): template struct a { using b = const float; }; template using d = typename a::b; template void e(d *, c) {} template void e(typename a::b *, int); Repository: rG LLVM Github

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

mizvekov updated this revision to Diff 387404. mizvekov added a comment. Herald added a project: libc++. Herald added a subscriber: libcxx-commits. Herald added a reviewer: libc++. - Add `libcxx/DELETE.ME` to trigger libcxx CI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D113954: [clang] NFC: rename internal `IsPossiblyOpaquelyQualifiedType` overload

mizvekov created this revision. mizvekov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Rename `IsPossiblyOpaquelyQualifiedType` overload taking a Type* as `IsPossiblyOpaquelyQualifiedTypeInternal` instead. Signed-off-by: Matheus Izvekov

[PATCH] D113954: [clang] NFC: rename internal `IsPossiblyOpaquelyQualifiedType` overload

mizvekov updated this revision to Diff 387449. mizvekov added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113954/new/ https://reviews.llvm.org/D113954 Files: clang/lib/Sema/SemaTemplateDeduction.cpp Index: clang/lib/Sema/SemaTem

[PATCH] D113954: [clang] NFC: rename internal `IsPossiblyOpaquelyQualifiedType` overload

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG21ed00bc1bfd: [clang] NFC: rename internal `IsPossiblyOpaquelyQualifiedType` overload (authored by mizvekov). Repository:

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

mizvekov updated this revision to Diff 387554. mizvekov added a comment. - Fix rebuilding Template Specializations Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111283/new/ https://reviews.llvm.org/D111283 Files: clang/include/clang/AST/ASTConte

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

mizvekov updated this revision to Diff 387566. mizvekov added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111283/new/ https://reviews.llvm.org/D111283 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/AST/Type.h

[PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov updated this revision to Diff 387579. mizvekov added a comment. Herald added a project: libc++. Herald added a subscriber: libcxx-commits. Herald added a reviewer: libc++. This revision now requires review to proceed. - Run libcxx CI Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D112374: [clang] WIP: Implement ElaboratedType sugaring for types written bare

mizvekov created this revision. Herald added subscribers: lxfind, jdoerfert. mizvekov updated this revision to Diff 382454. mizvekov added a comment. Herald added subscribers: carlosgalvezp, arphaman. mizvekov edited the summary of this revision. Herald added a subscriber: kristof.beyls. mizvekov u

[PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

mizvekov updated this revision to Diff 387699. mizvekov retitled this revision from "[clang] WIP: Implement ElaboratedType sugaring for types written bare" to "[clang] Implement ElaboratedType sugaring for types written bare". mizvekov edited the summary of this revision. mizvekov added a comment

[PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

mizvekov added a comment. In D110216#3135461 , @hans wrote: > We're seeing a diagnostic change in Chromium which looks funny. For the > following code (span<> is our own class): > > the diagnostic changes from: > > fatal error: no viable conversio

[PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

mizvekov added a comment. In D110216#3137375 , @hans wrote: >> I am not sure how to reproduce this. > > Attaching preprocessed source. With Clang built at > 508aa4fe0c82b3b409e2e194d591ee6d665c8623 it reproduces for me like this: > > $ clang++ -c /tmp/

[PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

mizvekov added a comment. Isolated example: template struct span {}; auto make_span() { using T = int; return span(); } void WontCompile() { span s1 = make_span(); } https://godbolt.org/z/rjd6Y6f9d testcc:9:13: error: no viable conversion from 'span' to 'span'

[PATCH] D114197: [clang-tidy] Fix false positives involving type aliases in `misc-unconventional-assign-operator` check

mizvekov accepted this revision. mizvekov added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114197/new/ https://reviews.llvm.org/D114197 ___

[PATCH] D114207: [clang] fix regression deducing pack expansion arguments introduced by D110216

mizvekov created this revision. mizvekov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This test case had been missing when the original code was introduced by 2fcb863b2b278. Signed-off-by: Matheus Izvekov Repository: rG LLVM Github

[PATCH] D114197: [clang-tidy] Fix false positives involving type aliases in `misc-unconventional-assign-operator` check

mizvekov added a comment. In D114197#3141400 , @fwolff wrote: > Thanks for the quick review! Can you also commit it for me? You can use name > and email as in commit `738e7f1231949ec248c1d8d154783338215613d1`. Thank you! Sure np, I will give some time f

[PATCH] D114207: [clang] fix regression deducing pack expansion arguments introduced by D110216

mizvekov added a comment. Thanks for testing! I am just going to push this since it's a straightforward regression fix and Richard is on vacations. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114207/new/ https://reviews.llvm.org/D114207 __

[PATCH] D114207: [clang] fix regression deducing pack expansion arguments introduced by D110216

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG85914b757015: [clang] fix regression deducing pack expansion arguments introduced by D110216 (authored by mizvekov). Chan

[PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

mizvekov added a comment. In D110216#3139129 , @lkail wrote: > Hi we found regression in our internal tests. It compiles with clang-13.0.0 > https://godbolt.org/z/3abGrcf7o and gcc https://godbolt.org/z/K9oj3Grs1, but > fails with clang-trunk https://go

[PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

mizvekov added a comment. Fix pushed to https://reviews.llvm.org/D114207 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110216/new/ https://reviews.llvm.org/D110216 ___ cfe-commits mailing list cfe-commit

[PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

mizvekov updated this revision to Diff 389298. mizvekov edited the summary of this revision. mizvekov added a comment. Herald added subscribers: llvm-commits, dexonsmith. Herald added a project: LLVM. - Avoid using any storage for an empty ElaboratedTYpeLoc. - But we still require pointer alignm

[PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

mizvekov updated this revision to Diff 389352. mizvekov added a comment. - fix IntrospectionTests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112374/new/ https://reviews.llvm.org/D112374 Files: clang-tools-extra/clang-change-namespace/ChangeN

[PATCH] D128750: [C++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions

mizvekov added a comment. Is the pre-commit CI failure here related to the patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128750/new/ https://reviews.llvm.org/D128750 ___ cfe-commits mailing list c

[PATCH] D128750: [C++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions

mizvekov accepted this revision. mizvekov added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128750/new/ https://reviews.llvm.org/D128750 __

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

mizvekov added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:513-534 + llvm::Optional MLTAL = + SetupConstraintCheckingTemplateArgumentsAndScope( + const_cast(FD), {}, Scope); + Qualifiers ThisQuals; CXXRecordDecl *Record = nullptr; if (auto

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

mizvekov added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:513-534 + llvm::Optional MLTAL = + SetupConstraintCheckingTemplateArgumentsAndScope( + const_cast(FD), {}, Scope); + Qualifiers ThisQuals; CXXRecordDecl *Record = nullptr; if (auto

[PATCH] D134453: Disambiguate type names when printing NTTP types

mizvekov added a comment. I think the type printer's purpose is for printing types for diagnostics, not for generating a lossless representation of types as strings, as the ast dumper does. So packing so much information in them that hurts readability would be against that purpose. I do agree w

[PATCH] D136533: Fix missing diagnostic of declaration use when accessing TypeDecls through typename access

mizvekov created this revision. Herald added a project: All. mizvekov requested review of this revision. Herald added projects: clang, libc++. Herald added subscribers: libcxx-commits, cfe-commits. Herald added a reviewer: libc++. Fixes GH58547. Signed-off-by: Matheus Izvekov Repository: rG

[PATCH] D136533: Fix missing diagnostic of declaration use when accessing TypeDecls through typename access

mizvekov added a comment. In D136533#3877854 , @ychen wrote: > Looks straightforward to me with one suggestion. > > Is the CI fail related? Yeah, the CI fail is because, while there is a change in libcxx diagnostics and we fix it, the same tests are run

[PATCH] D136533: Fix missing diagnostic of declaration use when accessing TypeDecls through typename access

mizvekov updated this revision to Diff 470004. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136533/new/ https://reviews.llvm.org/D136533 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Sema/Sema.h clang/lib/Sema/SemaDecl.cpp clang/li

[PATCH] D133874: [clang] Changes to produce sugared converted template arguments

mizvekov retitled this revision from "[clang] Implement sugar retention for converted template arguments" to "[clang] Changes to produce sugared converted template arguments". mizvekov edited the summary of this revision. mizvekov updated this revision to Diff 470006. Repository: rG LLVM Githu

[PATCH] D136563: [clang] Perform sugared substitution of builtin templates

mizvekov created this revision. Herald added a project: All. mizvekov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Since these are much like template type aliases, where we don't track a specialization for them and just substitute them e

[PATCH] D134604: [clang] Implement sugared substitution changes to infrastructure

mizvekov retitled this revision from "[clang] Instiantiate early substituted entities with sugared template arguments" to "[clang] Implement sugared substitution changes to infrastructure". mizvekov edited the summary of this revision. mizvekov updated this revision to Diff 470008. Herald added a

[PATCH] D136533: Fix missing diagnostic of declaration use when accessing TypeDecls through typename access

mizvekov updated this revision to Diff 470009. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136533/new/ https://reviews.llvm.org/D136533 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Sema/Sema.h clang/lib/Sema/SemaDecl.cpp clang/li

[PATCH] D136533: Fix missing diagnostic of declaration use when accessing TypeDecls through typename access

mizvekov added a comment. In D136533#3877974 , @philnik wrote: > Would it be possible to just add `#if TEST_CLANG_VER >= 1600` around the new > warnings? That works for me, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D136564: [clang] Instantiate NTTPs and template default arguments with sugar

mizvekov created this revision. Herald added a project: All. mizvekov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This makes use of the changes introduced in D134604 , in order to instantiate non-type

[PATCH] D134604: [clang] Implement sugared substitution changes to infrastructure

mizvekov updated this revision to Diff 470011. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134604/new/ https://reviews.llvm.org/D134604 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/AST/PropertiesBase.td clang/include/clang

[PATCH] D136565: [clang] Instantiate alias templates with sugar

mizvekov created this revision. Herald added subscribers: jeroen.dobbelaere, kadircet, arphaman. Herald added a project: All. mizvekov requested review of this revision. Herald added projects: clang, LLDB, clang-tools-extra. Herald added subscribers: cfe-commits, lldb-commits. This makes use of th

[PATCH] D136566: [clang] Instantiate concepts with sugared template arguments

mizvekov created this revision. Herald added a project: All. mizvekov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Since we don't unique specializations for concepts, we can just instantiate them with the sugared template arguments, at n

[PATCH] D136533: Fix missing diagnostic of declaration use when accessing TypeDecls through typename access

mizvekov added a comment. @philnik it seems that didn't work. It seems those pipelines are already running clang-16, according to the cmake logs, they are just not bootstrapping with this patch. So gating this on clang version will not work. Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D136545: [Clang] use non-template function declaration for constraints partial ordering

mizvekov accepted this revision. mizvekov added a comment. LGTM as well! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136545/new/ https://reviews.llvm.org/D136545 ___ cfe-commits mailing list cfe-commit

[PATCH] D136566: [clang] Instantiate concepts with sugared template arguments

mizvekov added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:1079 MultiLevelTemplateArgumentList MLTAL = S.getTemplateInstantiationArgs( - CSE->getNamedConcept(), /*Final=*/false, &TAL, + CSE->getNamedConcept(), /*Final=*/true, &TAL, /*RelativeTo

[PATCH] D136602: NFC: [clang] Template argument cleanups.

mizvekov created this revision. Herald added subscribers: carlosgalvezp, kadircet, arphaman, martong. Herald added a reviewer: shafik. Herald added a project: All. mizvekov requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits. R

[PATCH] D136602: NFC: [clang] Template argument cleanups.

mizvekov added inline comments. Comment at: clang/include/clang/AST/TemplateBase.h:592 + llvm::ArrayRef arguments() const { return Arguments; } + llvm::MutableArrayRef arguments() { return Arguments; } erichkeane wrote: > Ooh, really? Are the use cases ones

[PATCH] D136533: [clang] Fix missing diagnostic of declaration use when accessing TypeDecls through typename access

mizvekov retitled this revision from "Fix missing diagnostic of declaration use when accessing TypeDecls through typename access" to "[clang] Fix missing diagnostic of declaration use when accessing TypeDecls through typename access". mizvekov updated this revision to Diff 470264. Repository:

[PATCH] D136602: NFC: [clang] Template argument cleanups.

mizvekov updated this revision to Diff 470266. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136602/new/ https://reviews.llvm.org/D136602 Files: clang-tools-extra/clang-tidy/modernize/UseTransparentFunctorsCheck.cpp clang-tools-extra/clang-tidy/

[PATCH] D134453: Disambiguate type names when printing NTTP types

mizvekov added a comment. In D134453#3880403 , @dblaikie wrote: > Could you describe this in more detail? I find that to be more verbose than > is necessary/helpful and probably the variable name based option to be more > informative than the type name

[PATCH] D136602: NFC: [clang] Template argument cleanups.

mizvekov updated this revision to Diff 470278. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136602/new/ https://reviews.llvm.org/D136602 Files: clang-tools-extra/clang-tidy/modernize/UseTransparentFunctorsCheck.cpp clang-tools-extra/clang-tidy/

[PATCH] D136602: NFC: [clang] Template argument cleanups.

mizvekov updated this revision to Diff 470289. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136602/new/ https://reviews.llvm.org/D136602 Files: clang-tools-extra/clang-tidy/modernize/UseTransparentFunctorsCheck.cpp clang-tools-extra/clang-tidy/

[PATCH] D136533: [clang] Fix missing diagnostic of declaration use when accessing TypeDecls through typename access

mizvekov updated this revision to Diff 470294. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136533/new/ https://reviews.llvm.org/D136533 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Sema/Sema.h clang/lib/Sema/SemaDecl.cpp clang/li

[PATCH] D134453: Disambiguate type names when printing NTTP types

mizvekov added a comment. In D134453#3880729 , @dblaikie wrote: > I think we should restrict the discussion in this review to being only about > the case where we have the canonical type (acknowledging that there's broader > work to reduce the number of

[PATCH] D136602: NFC: [clang] Template argument cleanups.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1acffe81ee91: NFC: [clang] Template argument cleanups. (authored by mizvekov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D136533: [clang] Fix missing diagnostic of declaration use when accessing TypeDecls through typename access

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdc170433137a: [clang] Fix missing diagnostic of declaration use wh

[PATCH] D133874: [clang] Changes to produce sugared converted template arguments

mizvekov updated this revision to Diff 470346. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133874/new/ https://reviews.llvm.org/D133874 Files: clang/include/clang/Sema/Sema.h clang/include/clang/Sema/TemplateDeduction.h clang/lib/Sema/SemaLo

[PATCH] D136563: [clang] Perform sugared substitution of builtin templates

mizvekov edited the summary of this revision. mizvekov updated this revision to Diff 470347. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136563/new/ https://reviews.llvm.org/D136563 Files: clang/lib/Sema/SemaTemplate.cpp clang/test/SemaTemplat

[PATCH] D134604: [clang] Implement sugared substitution changes to infrastructure

mizvekov updated this revision to Diff 470348. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134604/new/ https://reviews.llvm.org/D134604 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/AST/PropertiesBase.td clang/include/clang

[PATCH] D136533: [clang] Fix missing diagnostic of declaration use when accessing TypeDecls through typename access

mizvekov added a subscriber: kcc. mizvekov added a comment. pinging @kcc for LibFuzzer, I believe this needs to be fixed there, if we don't want to bump the MacOs minimum version. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136533/new/ https://r

[PATCH] D133874: [clang] Changes to produce sugared converted template arguments

mizvekov added a reviewer: erichkeane. mizvekov added a subscriber: erichkeane. mizvekov added a comment. @erichkeane since you reviewed and approved 5 patches that depend on this one, can you also have a look at this please? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D133874: [clang] Changes to produce sugared converted template arguments

mizvekov added inline comments. Comment at: clang/include/clang/Sema/Sema.h:8285 + TemplateArgument &SugaredConverted, + TemplateArgument &CanonicalConverted, + CheckTemplateArgu

[PATCH] D133874: [clang] Changes to produce sugared converted template arguments

mizvekov added a comment. In D133874#3882350 , @erichkeane wrote: > The test changes are a little bizarre, are there any better tests you can > write that shows this behavior? > > Also, at the 'end' of this patch set, we should make sure we have a detai

[PATCH] D136533: [clang] Fix missing diagnostic of declaration use when accessing TypeDecls through typename access

mizvekov added a comment. I don't have access to a macOS machine, and I don't believe any of the pre-commit CI machines are running it either. So I don't have much to go on here. How do you think we shall proceed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D136602: NFC: [clang] Template argument cleanups.

mizvekov added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/UseTransparentFunctorsCheck.cpp:101 +const TemplateArgument &Arg = +FunctorParentType->template_arguments()[ArgNum]; if (Arg.getKind() != TemplateArgument::Type)

[PATCH] D136533: [clang] Fix missing diagnostic of declaration use when accessing TypeDecls through typename access

mizvekov added a comment. In D136533#3883048 , @erichkeane wrote: > One thing you might try is seeing if this is a libcxx-specific thing instead, > and try doing a self-build using libcxx. We tested this on the libc++ CI, as this patch touches a test c

[PATCH] D136533: [clang] Fix missing diagnostic of declaration use when accessing TypeDecls through typename access

mizvekov added a comment. In D136533#3883116 , @erichkeane wrote: > I don't believe that the libc++ CI does 'self build with libcxx as the host > library', so it would not have caught this. That said, this could definitely > just be an issue in the ve

[PATCH] D133874: [clang] Changes to produce sugared converted template arguments

mizvekov updated this revision to Diff 470645. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133874/new/ https://reviews.llvm.org/D133874 Files: clang/include/clang/Sema/Sema.h clang/include/clang/Sema/TemplateDeduction.h clang/lib/Sema/SemaLo

[PATCH] D133874: [clang] Changes to produce sugared converted template arguments

This revision was automatically updated to reflect the committed changes. Closed by commit rG11ce78940b4c: [clang] Changes to produce sugared converted template arguments (authored by mizvekov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133874/ne

[PATCH] D136563: [clang] Perform sugared substitution of builtin templates

This revision was automatically updated to reflect the committed changes. Closed by commit rGe5d9e802e50d: [clang] Perform sugared substitution of builtin templates (authored by mizvekov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136563/new/ ht

[PATCH] D134604: [clang] Implement sugared substitution changes to infrastructure

mizvekov updated this revision to Diff 470660. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134604/new/ https://reviews.llvm.org/D134604 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/AST/PropertiesBase.td clang/include/clang

[PATCH] D134604: [clang] Implement sugared substitution changes to infrastructure

This revision was automatically updated to reflect the committed changes. Closed by commit rGc4c2a3c65684: [clang] Implement sugared substitution changes to infrastructure (authored by mizvekov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134604/n

[PATCH] D136564: [clang] Instantiate NTTPs and template default arguments with sugar

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2560c1266993: [clang] Instantiate NTTPs and template default arguments with sugar (authored by mizvekov). Repository: rG LLVM Github Monorepo CHA

[PATCH] D136565: [clang] Instantiate alias templates with sugar

This revision was automatically updated to reflect the committed changes. Closed by commit rG4c44c91ad980: [clang] Instantiate alias templates with sugar (authored by mizvekov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136565/new/ https://revie

[PATCH] D136566: [clang] Instantiate concepts with sugared template arguments

This revision was automatically updated to reflect the committed changes. Closed by commit rGd0a6de59c780: [clang] Instantiate concepts with sugared template arguments (authored by mizvekov). Changed prior to commit: https://reviews.llvm.org/D136566?vs=470013&id=470671#toc Repository: rG LLV

[PATCH] D136564: [clang] Instantiate NTTPs and template default arguments with sugar

mizvekov added a comment. In D136564#3884470 , @glandium wrote: > This broke building Firefox with: > > In file included from Unified_cpp_dom_canvas0.cpp:65: > /tmp/gecko/dom/canvas/ClientWebGLContext.cpp:355:19: error: call to deleted > function 'Id

[PATCH] D133874: [clang] Changes to produce sugared converted template arguments

mizvekov added a comment. In D133874#3884468 , @glandium wrote: > This broke building Firefox with: Thanks for reporting. Do you have preprocessed source + cc1 flags to reproduce it, so I can have a look? Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D133874: [clang] Changes to produce sugared converted template arguments

mizvekov added a comment. In D133874#3884904 , @glandium wrote: > I'm running it through creduce (as well as the one for D136564 > . It's going to take a little while. Thank > you for the revert. That's very helpful, t

[PATCH] D136533: [clang] Fix missing diagnostic of declaration use when accessing TypeDecls through typename access

mizvekov added a subscriber: ldionne. mizvekov added a comment. In D136533#3884364 , @glandium wrote: > (And specifically, FuzzerFork.cpp doesn't use any of those declared things. > Its only sin is to `#include `, which happens to have /some/ methods >

[PATCH] D136744: [Clang] perform "maximum TLS alignment" check for template instantiation

mizvekov accepted this revision. mizvekov added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Sema/SemaDecl.cpp:14038-14039 + + if (!Context.getTargetInfo().isTLSSupported()) +return; + Is this needed? It seems `getM

[PATCH] D134453: Disambiguate type names when printing NTTP types

mizvekov added a comment. In D134453#3885423 , @aaron.ballman wrote: > I can live with this approach if folks think it's the better way to go. But > my concern still remains that the user has no idea what's being constructed > by `{3}` or `{4}` without

[PATCH] D133874: [clang] Changes to produce sugared converted template arguments

mizvekov added a comment. Thanks. Reduced to: void foo(); template void bar() {} template void bar<>(); template void bar(); Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133874/new/ https://reviews.llvm.org/D133874

[PATCH] D136533: [clang] Fix missing diagnostic of declaration use when accessing TypeDecls through typename access

mizvekov added a comment. In D136533#388 , @glandium wrote: > It's the opposite of deprecated, it's (optionally) using something that is > only available in newer versions of macos. Right, I mis-typed, but this is probably using the 'availability' a

[PATCH] D133874: [clang] Changes to produce sugared converted template arguments

mizvekov added a comment. This is surprisingly not from a bug in this patch. So `getCanonicalTemplateArgument` is broken for the types of declarations. This bug was supposedly fixed by zygoloid (https://github.com/llvm/llvm-project/commit/849c60541b630ddf8cabf9179fa771b3f4207) But then was reve

[PATCH] D133874: [clang] Changes to produce sugared converted template arguments

mizvekov added a comment. I think there is a high chance that the bug that caused richard's patch to be reverted, was actually fixed afterwards by https://github.com/llvm/llvm-project/commit/acb767f5cda59302aa9100afcf6133d66779d42c So I will try to land that one again, and then I will try to la

[PATCH] D136803: [clang] Include the type of a pointer or reference non-type template parameter in its notion of template argument identity.

mizvekov created this revision. Herald added a project: All. mizvekov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We already did this for all the other kinds of non-type template argument. We're still missing the type from the mangling,

[PATCH] D133874: [clang] Changes to produce sugared converted template arguments

mizvekov added a comment. Thanks for confirming. I have pushed a patch at: https://reviews.llvm.org/D136803 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133874/new/ https://reviews.llvm.org/D133874 ___

[PATCH] D136803: [clang] Include the type of a pointer or reference non-type template parameter in its notion of template argument identity.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG27f9b0c619c6: [clang] Include the type of a pointer or reference non-type template parameter… (authored by rsmith, committed by mizvekov). Changed

[PATCH] D136533: [clang] Fix missing diagnostic of declaration use when accessing TypeDecls through typename access

mizvekov added a comment. In D136533#3891905 , @ldionne wrote: > Is it possible that it would be one of those two bugs? > https://github.com/llvm/llvm-project/issues?q=is%3Aopen+is%3Aissue+author%3Aldionne+availability+ I don't think so. It does look l

[PATCH] D136886: [clang] [ASTImporter] RFC: Correct importer to not duplicate sugared types

mizvekov added a comment. I agree having two different val_list types is suspect, it might not have been imported and is simply referring to the va_list of the original context. One other note, is that if a problem exists for TypedefType, it probably exists for UsingType as well, as they are ve

[PATCH] D136962: [clang] Improve error recovery for pack expansion of expressions

mizvekov created this revision. Herald added a project: All. mizvekov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Closes #58673. Signed-off-by: Matheus Izvekov Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D136962

[PATCH] D136962: [clang] Improve error recovery for pack expansion of expressions

mizvekov updated this revision to Diff 471638. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136962/new/ https://reviews.llvm.org/D136962 Files: clang/docs/ReleaseNotes.rst clang/lib/AST/ComputeDependence.cpp clang/test/CXX/temp/temp.decls/tem

<    1   2   3   4   5   6   7   8   9   10   >