furdyna created this revision.
furdyna added reviewers: rsmith, ioeric.
Herald added a project: clang.
furdyna edited the summary of this revision.
By additional regex match, grouping of main include can be enabled in files
that are not normally considered as a C/C++ source code.
For example, thi
furdyna added a comment.
Hi, @krasimir @sylvestre.ledru , would you be able to help me with this patch?
I am looking for anyone interested in reviewing this :)
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67750/new/
https://reviews.llvm.org/D67750
__
furdyna added a comment.
> I think its worth mentioning, that my personal preference would STILL be to
> land this inside clang-format with default configuration of "OFF",
> I would be interested to know how many people would be unhappy if we stated
> that "sorting includes" and "namespace comm
furdyna updated this revision to Diff 228872.
furdyna marked 2 inline comments as done.
furdyna added a comment.
Hi @MyDeveloperDay, I changed the code following your advice.
Thanks for cathing the operator==(), I was not sure if this omission was
intentional or not - fixed both comparisons.
C
furdyna added a comment.
@MyDeveloperDay Thanks for the review!
I did rebase it a few hours ago. I actually made sure to use the full-context
diff (with -U99 option) - I even have this as a last command in my command
history, and the patch file on my disk is full-context. So either I still
