Re: [PATCH] D22774: [MSVC] Add ARM support to intrin.h for MSVC compatibility

2016-08-04 Thread Martin Storsjö via cfe-commits
mstorsjo added a comment. Ping - any reply from @compnerd? In any case, feel free to formulate the ifdefs whichever way you want on commit as well (since I don't have commit access), as long as the included test passes. https://reviews.llvm.org/D22774 ___

Re: [PATCH] D22774: [MSVC] Add ARM support to intrin.h for MSVC compatibility

2016-08-04 Thread Martin Storsjö via cfe-commits
mstorsjo added a comment. Ping @compnerd https://reviews.llvm.org/D22774 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22774: [MSVC] Add ARM support to intrin.h for MSVC compatibility

2016-08-05 Thread Martin Storsjö via cfe-commits
mstorsjo added a comment. In https://reviews.llvm.org/D22774#507014, @compnerd wrote: > Why `include_next` the header if not on Windows? Mostly because intrin.h uses the same logic. Normally, there's probably no such system header in other SDKs, but say if you happen to have a custom one named

Re: [PATCH] D22774: [MSVC] Add ARM support to intrin.h for MSVC compatibility

2016-08-06 Thread Martin Storsjö via cfe-commits
mstorsjo added a comment. Can someone commit this for me? https://reviews.llvm.org/D22774 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix build dllexport/dllimport issues when doing a shared build for Windows using GCC (PR #66881)

2024-02-16 Thread Martin Storsjö via cfe-commits
https://github.com/mstorsjo closed https://github.com/llvm/llvm-project/pull/66881 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix build dllexport/dllimport issues when doing a shared build for Windows using GCC (PR #66881)

2024-02-16 Thread Martin Storsjö via cfe-commits
mstorsjo wrote: > This is superseded by https://github.com/llvm/llvm-project/pull/71393 which > was merged now. I'll close this one for now, as I believe the issue has been fixed differently. https://github.com/llvm/llvm-project/pull/66881 ___ cfe-co

[clang] [compiler-rt] [asan][windows] Eliminate the static asan runtime on windows (PR #81677)

2024-02-16 Thread Martin Storsjö via cfe-commits
mstorsjo wrote: > The core reasoning is that asan is a "only one allowed per process" type > thing (you can't have one copy of the asan runtime handling a malloc while a > different one handles the corresponding free). Not to distract from the direction taken here (which I do agree seems reas

[clang] [COFF][Aarch64] Add _InterlockedAdd64 intrinsic (PR #81849)

2024-02-16 Thread Martin Storsjö via cfe-commits
mstorsjo wrote: It looks like your github account is set to keep your email address private - can you please turn that off, so we get a proper email address (when the commit is rewritten, as we do merges with "squash and merge" here)? See the "keep my email addresses private" setting at https:

[clang] [COFF][Aarch64] Add _InterlockedAdd64 intrinsic (PR #81849)

2024-02-16 Thread Martin Storsjö via cfe-commits
mstorsjo wrote: > Done 👍 Thanks, now this looks good to merge! https://github.com/llvm/llvm-project/pull/81849 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [COFF][Aarch64] Add _InterlockedAdd64 intrinsic (PR #81849)

2024-02-16 Thread Martin Storsjö via cfe-commits
https://github.com/mstorsjo closed https://github.com/llvm/llvm-project/pull/81849 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [asan][windows] Eliminate the static asan runtime on windows (PR #81677)

2024-02-16 Thread Martin Storsjö via cfe-commits
mstorsjo wrote: > > Not to distract from the direction taken here (which I do agree seems > > reasonable, even if I haven't had time to look closer at the PR yet) - but, > > when using the static CRT in general, doesn't the same concern apply there > > as well? I.e. when using the static CRT,

[clang] [clang] Disable C++14 sized deallocation by default for MinGW targets (PR #97232)

2024-06-30 Thread Martin Storsjö via cfe-commits
https://github.com/mstorsjo created https://github.com/llvm/llvm-project/pull/97232 This reverts 130e93cc26ca9d3ac50ec5a92e3109577ca2e702 for the MinGW target. This avoids the issue that is discussed in https://github.com/llvm/llvm-project/issues/96899 (and which is summarized in the code comm

[clang] [clang] Disable C++14 sized deallocation by default for MinGW targets (PR #97232)

2024-06-30 Thread Martin Storsjö via cfe-commits
https://github.com/mstorsjo updated https://github.com/llvm/llvm-project/pull/97232 From bc68b1bc25f7a04a0ddf2188ae26ed7853913b69 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20Storsj=C3=B6?= Date: Tue, 11 Jun 2024 15:50:26 +0300 Subject: [PATCH] [clang] Disable C++14 sized deallocation by d

[clang] [clang] Disable C++14 sized deallocation by default for MinGW targets (PR #97232)

2024-07-01 Thread Martin Storsjö via cfe-commits
https://github.com/mstorsjo updated https://github.com/llvm/llvm-project/pull/97232 From a70379a45f2701afbf05631b86cb14708f43243f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20Storsj=C3=B6?= Date: Tue, 11 Jun 2024 15:50:26 +0300 Subject: [PATCH] [clang] Disable C++14 sized deallocation by d

[clang] [clang] Disable C++14 sized deallocation by default for MinGW targets (PR #97232)

2024-07-01 Thread Martin Storsjö via cfe-commits
https://github.com/mstorsjo closed https://github.com/llvm/llvm-project/pull/97232 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [openmp] [OpenMP][offload] Fix dynamic schedule tracking (PR #97065)

2024-07-02 Thread Martin Storsjö via cfe-commits
mstorsjo wrote: This change broke Windows builds of OpenMP. Building succeed, but many build scenarios fail due to `__kmpc_dispatch_deinit` being undefined. It looks like it only is defined in the OpenMP device offload library, but is missing if the offload library isn't being built/used. Se

[clang] [clang][X86] Add __cpuidex function to cpuid.h (PR #97785)

2024-07-05 Thread Martin Storsjö via cfe-commits
mstorsjo wrote: Thanks - I think this is fine with me. In https://github.com/mingw-w64/mingw-w64/commit/a4c0c1d00d140d69a2c72f6ca0d49c91bdb2b08c we adjusted the mingw-w64 headers in anticipation that this gets merged in Clang 19, so it'd be good to have it settled before the 19.x branch gets m

[clang] [lld] [llvm] [clang][MIPS] Add support for mipsel-windows-* targets (PR #107744)

2024-09-08 Thread Martin Storsjö via cfe-commits
mstorsjo wrote: Overall, thanks for the PR - this looks very exciting to me! First off, I think it'd be good to set the scope for this. This is one of the historical Windows architectures, supported in early versions of NT and CE. As such, it probably has mostly hobbyist value at this point. H

[clang] [lld] [llvm] [clang][MIPS] Add support for mipsel-windows-* targets (PR #107744)

2024-09-09 Thread Martin Storsjö via cfe-commits
@@ -40,6 +40,7 @@ static const auto ARM64EC = llvm::COFF::IMAGE_FILE_MACHINE_ARM64EC; static const auto ARM64X = llvm::COFF::IMAGE_FILE_MACHINE_ARM64X; static const auto ARMNT = llvm::COFF::IMAGE_FILE_MACHINE_ARMNT; static const auto I386 = llvm::COFF::IMAGE_FILE_MACHINE_I386;

[clang] [lld] [llvm] [clang][MIPS] Add support for mipsel-windows-* targets (PR #107744)

2024-09-09 Thread Martin Storsjö via cfe-commits
https://github.com/mstorsjo edited https://github.com/llvm/llvm-project/pull/107744 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lld] [llvm] [clang][MIPS] Add support for mipsel-windows-* targets (PR #107744)

2024-09-09 Thread Martin Storsjö via cfe-commits
https://github.com/mstorsjo commented: I browsed through the first couple commits and added a couple pointers. Overall it looks reasonable, but things can probably be split up into even smaller commits for atomicity, which also would make it clearer where we'd want more test coverage. https:/

[clang] [lld] [llvm] [clang][MIPS] Add support for mipsel-windows-* targets (PR #107744)

2024-09-09 Thread Martin Storsjö via cfe-commits
@@ -51,3 +51,25 @@ MipsELFMCAsmInfo::MipsELFMCAsmInfo(const Triple &TheTriple, DwarfRegNumForCFI = true; HasMipsExpressions = true; } + +void MipsCOFFMCAsmInfoMicrosoft::anchor() { } + +MipsCOFFMCAsmInfoMicrosoft::MipsCOFFMCAsmInfoMicrosoft() { + WinEHEncodingType = WinEH:

[clang] [lld] [llvm] [clang][MIPS] Add support for mipsel-windows-* targets (PR #107744)

2024-09-09 Thread Martin Storsjö via cfe-commits
@@ -1132,6 +1132,8 @@ StringRef COFFObjectFile::getFileFormatName() const { return "COFF-ARM64EC"; case COFF::IMAGE_FILE_MACHINE_ARM64X: return "COFF-ARM64X"; + case COFF::IMAGE_FILE_MACHINE_R4000: +return "COFF-R4000"; mstorsjo wrote: Hmm, do w

[clang] [lld] [llvm] [clang][MIPS] Add support for mipsel-windows-* targets (PR #107744)

2024-09-09 Thread Martin Storsjö via cfe-commits
@@ -28,6 +28,8 @@ COFF::MachineTypes llvm::getMachineType(StringRef S) { .Case("arm64", COFF::IMAGE_FILE_MACHINE_ARM64) .Case("arm64ec", COFF::IMAGE_FILE_MACHINE_ARM64EC) .Case("arm64x", COFF::IMAGE_FILE_MACHINE_ARM64X) + .Case("mips", COFF::IMAGE_FILE_MA

[clang] [lld] [llvm] [clang][MIPS] Add support for mipsel-windows-* targets (PR #107744)

2024-09-09 Thread Martin Storsjö via cfe-commits
@@ -45,6 +47,8 @@ StringRef llvm::machineToStr(COFF::MachineTypes MT) { return "x64"; case COFF::IMAGE_FILE_MACHINE_I386: return "x86"; + case COFF::IMAGE_FILE_MACHINE_R4000: +return "mipsel"; mstorsjo wrote: This seems wrong - this should retur

[clang] [lld] [llvm] [clang][MIPS] Add support for mipsel-windows-* targets (PR #107744)

2024-09-09 Thread Martin Storsjö via cfe-commits
@@ -39,3 +39,7 @@ Sections: # BSS: Contents of section .bss: # BSS-NEXT: + +# RUN: yaml2obj %p/Inputs/COFF/mipsel.yaml | llvm-objdump -s - | FileCheck %s --check-prefix=COFF-R4000 mstorsjo wrote: This new test seems quite misplaced within this test file. Al

[clang] [lld] [llvm] [clang][MIPS] Add support for mipsel-windows-* targets (PR #107744)

2024-09-09 Thread Martin Storsjö via cfe-commits
@@ -0,0 +1,43 @@ +; RUN: llc -mtriple mipsel-windows-msvc -filetype=obj < %s | obj2yaml | FileCheck %s +; RUN: llc -mtriple mipsel-windows-gnu -filetype=obj < %s | obj2yaml | FileCheck %s mstorsjo wrote: It feels to me like this test skips a couple steps. It w

[clang] Reapply "[Clang][CWG1815] Support lifetime extension of temporary created by aggregate initialization using a default member initializer" (PR #97308)

2024-09-09 Thread Martin Storsjö via cfe-commits
mstorsjo wrote: This PR triggers failed asserts. This is reproducible with https://martin.st/temp/qtdeclarative-repro1.cpp, like this: ``` $ clang -target aarch64-w64-mingw32 -c qtdeclarative-repro1.cpp Assertion failed: ((ND->isUsed(false) || !isa(ND) || E->isNonOdrUse() || !E->getLocation().i

[clang] cca54e3 - Revert "Reapply "[Clang][CWG1815] Support lifetime extension of temporary created by aggregate initialization using a default member initializer" (#97308)"

2024-09-09 Thread Martin Storsjö via cfe-commits
Author: Martin Storsjö Date: 2024-09-09T15:09:45+03:00 New Revision: cca54e347ac34912cdfb9983533c61836db135e0 URL: https://github.com/llvm/llvm-project/commit/cca54e347ac34912cdfb9983533c61836db135e0 DIFF: https://github.com/llvm/llvm-project/commit/cca54e347ac34912cdfb9983533c61836db135e0.diff

[clang] Reapply "[Clang][CWG1815] Support lifetime extension of temporary created by aggregate initialization using a default member initializer" (PR #97308)

2024-09-09 Thread Martin Storsjö via cfe-commits
mstorsjo wrote: I pushed a revert now. My reduction did complete in the end - it's reproducible with a small snippet like this: ```c++ struct a { } constexpr b; class c { public: c(a); }; class B { public: using d = int; struct e { enum { f } g; int h; c i; d j{}; }; };

[clang] [lld] [llvm] [clang][MIPS] Add support for mipsel-windows-* targets (PR #107744)

2024-09-09 Thread Martin Storsjö via cfe-commits
mstorsjo wrote: > For the Mips backend itself, I would ask the Mips backend code maintainer... > but we don't have a maintainer for Mips. And we don't have any buildbots. I'm > really not sure about adding complexity to a backend which is already > suffering from a lack of anyone that has any

[clang] [clang-scan-deps] Infer the target from the executable name (PR #108189)

2024-09-11 Thread Martin Storsjö via cfe-commits
https://github.com/mstorsjo created https://github.com/llvm/llvm-project/pull/108189 This allows clang-scan-deps to work correctly when using cross compilers with names like -clang. From 1c7a8ffac3681ce8d662732c9489629d7d83d092 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20Storsj=C3=B6?=

[clang] [clang][driver] Fix -print-target-triple OS version for apple targets (PR #104037)

2024-08-16 Thread Martin Storsjö via cfe-commits
mstorsjo wrote: This broke things for non-darwin targets. `clang --print-target-triple` is used to evaluate the arch to use for e.g. compiler-rt builtins, and for getting the right subdirectory for per-target runtime directories. Previously, `clang -target armv7-windows-gnu --print-target-tri

[clang] [clang] Implement gcc_struct attribute on Itanium targets (PR #71148)

2024-08-16 Thread Martin Storsjö via cfe-commits
https://github.com/mstorsjo commented: I had a brief look over this, and it looks reasonable to me, although I'm not anywhere near competent enough to properly review it from the Clang perspective and approve it. I don't see any added test that actually exercises the new `gcc_struct` attribut

[clang] Revert "[clang][driver] Fix -print-target-triple OS version for apple targets" (PR #104563)

2024-08-16 Thread Martin Storsjö via cfe-commits
https://github.com/mstorsjo created https://github.com/llvm/llvm-project/pull/104563 This reverts llvm/llvm-project#104037 / 7227b44f928a87b5d7fb05bd1539fdfb6d4958dc. This change had the unintended consequence of making e.g. `clang -target armv7-windows-gnu --print-target-triple` output `thum

[clang] Revert "[clang][driver] Fix -print-target-triple OS version for apple targets" (PR #104563)

2024-08-16 Thread Martin Storsjö via cfe-commits
https://github.com/mstorsjo closed https://github.com/llvm/llvm-project/pull/104563 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Ensure ToolChain::LibraryPaths is not empty for non-Darwin (PR #87866)

2024-04-09 Thread Martin Storsjö via cfe-commits
mstorsjo wrote: This seems to have had an unexpected effect. In a build where I don't use the new path style, I used to get the old path style returned like this: ``` $ clang -target x86_64-w64-mingw32 -print-runtime-dir /home/martin/clang-nightly/lib/clang/19/lib/windows ``` However after this

[clang] [Driver] Ensure ToolChain::LibraryPaths is not empty for non-Darwin (PR #87866)

2024-04-09 Thread Martin Storsjö via cfe-commits
mstorsjo wrote: > This seems to have had an unexpected effect. In a build where I don't use the > new path style, I used to get the old path style returned like this: > > ``` > $ clang -target x86_64-w64-mingw32 -print-runtime-dir > /home/martin/clang-nightly/lib/clang/19/lib/windows > ``` > >

[clang] [Driver] Ensure ToolChain::LibraryPaths is not empty for non-Darwin (PR #87866)

2024-04-10 Thread Martin Storsjö via cfe-commits
mstorsjo wrote: > @aeubanks The problem is that in your configure, the libclang_rt is placed in > `/lib/clang/19/lib/linux/libclang_rt.builtins-arm-android.a`, > instead of > `/lib/clang/19/lib/arm-unknown-linux-android/libclang_rt.builtins.a`. The point is that both locations were supposed t

[clang] [clang] Don't use -Wno-nested-anon-types on GCC (PR #95029)

2024-06-10 Thread Martin Storsjö via cfe-commits
https://github.com/mstorsjo created https://github.com/llvm/llvm-project/pull/95029 GCC usually doesn't warn about unrecognized -Wno- options, if no diagnostics are printed. However if some diagnostics are printed, it also mentions that there were unrecognized -Wno- options. Before 4feae05c6a

[clang] [clang] Don't use -Wno-nested-anon-types on GCC (PR #95029)

2024-06-10 Thread Martin Storsjö via cfe-commits
https://github.com/mstorsjo closed https://github.com/llvm/llvm-project/pull/95029 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] [test] Skip a test that sets PATH= on Windows (PR #95096)

2024-06-11 Thread Martin Storsjö via cfe-commits
https://github.com/mstorsjo created https://github.com/llvm/llvm-project/pull/95096 The same has been done in a couple other existing tests, that also are skipped on Windows (e.g. ld-path.c). Some tests that really do want to test setting the path on Windows does it differently, see e.g. ps4-p

[clang] [clang] [test] Skip a test that sets PATH= on Windows (PR #95096)

2024-06-11 Thread Martin Storsjö via cfe-commits
mstorsjo wrote: CC @linehill https://github.com/llvm/llvm-project/pull/95096 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] [test] Skip a test that sets PATH= on Windows (PR #95096)

2024-06-11 Thread Martin Storsjö via cfe-commits
mstorsjo wrote: > Could the single test with the PATH manipulation be moved to a separate test > file which is disabled on Windows? That way we could keep running the other > tests on Windows. That's certainly an option, too. https://github.com/llvm/llvm-project/pull/95096 ___

[clang] [clang] [test] Skip a test that sets PATH= on Windows (PR #95096)

2024-06-11 Thread Martin Storsjö via cfe-commits
https://github.com/mstorsjo updated https://github.com/llvm/llvm-project/pull/95096 From 8e5e09f12124a361c06d833a9ade75bbb338be4c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20Storsj=C3=B6?= Date: Tue, 11 Jun 2024 13:14:47 +0300 Subject: [PATCH] [clang] [test] Skip a test that sets PATH= on

[clang] [clang] [test] Skip a test that sets PATH= on Windows (PR #95096)

2024-06-11 Thread Martin Storsjö via cfe-commits
https://github.com/mstorsjo edited https://github.com/llvm/llvm-project/pull/95096 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] [test] Skip a test that sets PATH= on Windows (PR #95096)

2024-06-12 Thread Martin Storsjö via cfe-commits
https://github.com/mstorsjo updated https://github.com/llvm/llvm-project/pull/95096 From 11b577825a15bcd6139863adb047ef5f7b161a36 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20Storsj=C3=B6?= Date: Tue, 11 Jun 2024 13:14:47 +0300 Subject: [PATCH] [clang] [test] Skip a test that sets PATH= on

[clang] [clang] [test] Skip a test that sets PATH= on Windows (PR #95096)

2024-06-12 Thread Martin Storsjö via cfe-commits
@@ -77,13 +77,3 @@ // XTOR: {{llvm-spirv.*"}} // BACKEND-NOT: {{llvm-spirv.*"}} - -//- -// Check llvm-spirv- is used if it is found in PATH. -// RUN: mkdir -p %t/versioned -// RUN: touch %t/versioned/l

[clang] [clang] [test] Skip a test that sets PATH= on Windows (PR #95096)

2024-06-13 Thread Martin Storsjö via cfe-commits
https://github.com/mstorsjo edited https://github.com/llvm/llvm-project/pull/95096 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] [test] Skip a test that sets PATH= on Windows (PR #95096)

2024-06-13 Thread Martin Storsjö via cfe-commits
https://github.com/mstorsjo closed https://github.com/llvm/llvm-project/pull/95096 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Add winsysroot alias to the GNU driver (PR #95320)

2024-06-13 Thread Martin Storsjö via cfe-commits
mstorsjo wrote: What's the deal with constantly force-pushing an update to the PR, with the exact same contents? With the massive inflow of commits in LLVM, you can't rebase your branch constantly on top of the latest one many times per day, I would say. And what's going on when #94731 was cl

[clang] [llvm] [llvm][AArch64] Support -mcpu=apple-m4 (PR #95478)

2024-06-14 Thread Martin Storsjö via cfe-commits
@@ -1010,6 +1034,9 @@ def : ProcessorModel<"apple-a16", CycloneModel, ProcessorFeatures.AppleA16, [TuneAppleA16]>; def : ProcessorModel<"apple-a17", CycloneModel, ProcessorFeatures.AppleA17, [TuneAppleA17]>; +def : ProcessorModel<"appl

[clang] [llvm] [llvm][AArch64] Support -mcpu=apple-m4 (PR #95478)

2024-06-14 Thread Martin Storsjö via cfe-commits
@@ -1010,6 +1034,9 @@ def : ProcessorModel<"apple-a16", CycloneModel, ProcessorFeatures.AppleA16, [TuneAppleA16]>; def : ProcessorModel<"apple-a17", CycloneModel, ProcessorFeatures.AppleA17, [TuneAppleA17]>; +def : ProcessorModel<"appl

[clang] [clang] [MinGW] Set a predefined __GXX_TYPEINFO_EQUALITY_INLINE=0 for… (PR #96062)

2024-06-19 Thread Martin Storsjö via cfe-commits
https://github.com/mstorsjo created https://github.com/llvm/llvm-project/pull/96062 … MinGW targets libstdc++ requires this define to match what is predefined in GCC for the ABI of this platform; GCC hardcodes this define for all mingw configurations in gcc/config/i386/cygming.h. (It also de

[clang] [clang] [MinGW] Set a predefined __GXX_TYPEINFO_EQUALITY_INLINE=0 for… (PR #96062)

2024-06-19 Thread Martin Storsjö via cfe-commits
mstorsjo wrote: CC @jwakely https://github.com/llvm/llvm-project/pull/96062 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] [MinGW] Set a predefined __GXX_TYPEINFO_EQUALITY_INLINE=0 for… (PR #96062)

2024-06-20 Thread Martin Storsjö via cfe-commits
https://github.com/mstorsjo updated https://github.com/llvm/llvm-project/pull/96062 From 7e6050d7e6274fe2f9b66ebecc92152f6363f025 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20Storsj=C3=B6?= Date: Wed, 19 Jun 2024 14:34:12 +0300 Subject: [PATCH] [clang] [MinGW] Set a predefined __GXX_TYPEI

[clang] [clang] [MinGW] Set a predefined __GXX_TYPEINFO_EQUALITY_INLINE=0 for… (PR #96062)

2024-06-20 Thread Martin Storsjö via cfe-commits
@@ -926,6 +926,12 @@ static void InitializePredefinedMacros(const TargetInfo &TI, if (LangOpts.GNUCVersion && LangOpts.CPlusPlus11) Builder.defineMacro("__GXX_EXPERIMENTAL_CXX0X__"); + if (TI.getTriple().isWindowsGNUEnvironment() && LangOpts.CPlusPlus) { --

[clang] [compiler-rt] [libcxx] [libunwind] [llvm] [openmp] [runtimes] remove workaround for old CMake when setting `--unwindlib=none` (PR #93429)

2024-06-20 Thread Martin Storsjö via cfe-commits
mstorsjo wrote: > Hm, this seems to affect some feature detection (and constraints) later on, > though I don't see why/how removing the specification of `--unwindlib=none` > to the driver (leaving it only to the linker) would cause that: > > https://github.com/llvm/llvm-project/blob/1c046ca3f3

[libunwind] [llvm] [runtimes] remove workaround for old CMake when setting `--unwindlib=none` (PR #93429)

2024-06-20 Thread Martin Storsjö via cfe-commits
mstorsjo wrote: > Thanks a lot for the fix, I've pulled it into the PR (also rebased on main > while I'm at it) - and CI didn't fail as previously, so this looks great! > Thank you! Ok, good! Btw, it might be good to add a reference to https://gitlab.kitware.com/cmake/cmake/-/issues/23454 in

[clang] [Driver] Ensure ToolChain::LibraryPaths is not empty for non-Darwin (PR #87866)

2024-04-16 Thread Martin Storsjö via cfe-commits
mstorsjo wrote: > > Is it expected now that `clang --print-runtime-dir` will always have the > > clang host triple appended even if `LLVM_ENABLE_PER_TARGET_RUNTIME_DIR` is > > off? I guess I was expecting to see `lib/linux` instead of > > `lib/x86_64-unknown-linux-gnu`. > > https://reviews.ll

[clang] [Driver] Ensure ToolChain::LibraryPaths is not empty for non-Darwin (PR #87866)

2024-04-23 Thread Martin Storsjö via cfe-commits
mstorsjo wrote: > This is a behavior change: In distributed build environments, neither lib > file exists at compile time. Previously, this would result in the "old" > style, now (together with #81037) it results in the "new" style (which we > disable everywhere since it causes all kinds of is

[clang] [llvm] [coroutine] Implement llvm.coro.await.suspend intrinsic (PR #79712)

2024-07-23 Thread Martin Storsjö via cfe-commits
mstorsjo wrote: FYI, as a headsup - I've bisected a regression down to this PR/commit. Before this change, all libcxx tests pass on Windows/armv7, but after this change, a bunch of coroutine tests fail on this target - see https://github.com/llvm/llvm-project/issues/100101. https://github.com

[clang] [Clang][Driver] Warn about `-c/-S` with `-fsyntax-only` (PR #98607)

2024-07-25 Thread Martin Storsjö via cfe-commits
mstorsjo wrote: FWIW, in addition to `-c` in combination with `-fsyntax-only`, this now also warns for `-c` in combination with `-E`. That sounds like a reasonable thing to do to me, so it's probably fine, but it'd be nice to have that aspect acknowledged as one intended behaviour change as w

[clang] [Driver] Ensure ToolChain::LibraryPaths is not empty for non-Darwin (PR #87866)

2024-04-23 Thread Martin Storsjö via cfe-commits
mstorsjo wrote: > I now did build clang at > [ccdebba](https://github.com/llvm/llvm-project/commit/ccdebbae4d77d3efc236af92c22941de5d437e01) > and > [ccdebba](https://github.com/llvm/llvm-project/commit/ccdebbae4d77d3efc236af92c22941de5d437e01)^. > > [ccdebba](https://github.com/llvm/llvm-pr

[clang] [Driver] Restore compiler-rt arch suffix for PS and Windows (PR #89775)

2024-04-23 Thread Martin Storsjö via cfe-commits
mstorsjo wrote: > Commit > [b876596](https://github.com/llvm/llvm-project/commit/b876596a76cdc183439b36455d26883b67f8ee51) > corrected default compiler-rt library names for many targets Are you sure it's this change? There are reports of similar changes showing up in https://github.com/llvm/l

[clang] [Driver] Ensure ToolChain::LibraryPaths is not empty for non-Darwin (PR #87866)

2024-04-23 Thread Martin Storsjö via cfe-commits
mstorsjo wrote: > > I would suggest we revert this - and at least collect all the observed side > > effects and declare them before considering relanding it. > > That sounds good to me. Do you have a list of PRs to revert? Not sure if there are follow-up fixes, sorry, but the discussed PRs are

[clang] [Driver] Restore compiler-rt arch suffix for PS and Windows (PR #89775)

2024-04-23 Thread Martin Storsjö via cfe-commits
mstorsjo wrote: > > The recent changes, #81037 and #87866, were (as far as I know) only > > intended to change what is printed as error messages, when neither is > > found, to help users correct their setup for the new style layout. But > > those changes also seem to have unexpected effects in

[clang] [clang] Don't add DWARF debug info when assembling .s with clang-cl /Z7 (PR #106686)

2024-08-30 Thread Martin Storsjö via cfe-commits
https://github.com/mstorsjo created https://github.com/llvm/llvm-project/pull/106686 This fixes a regression from f58330cbe44598eb2de0cca3b812f67fea0a71ca. That commit changed the clang-cl options /Zi and /Z7 to be implemented as aliases of -g rather than having separate handling. This had th

[clang] [clang] [docs] Clarify the issue with compiler-rt on Windows/MSVC (PR #106875)

2024-08-31 Thread Martin Storsjö via cfe-commits
https://github.com/mstorsjo created https://github.com/llvm/llvm-project/pull/106875 Compiler-rt does support Windows just fine, even if outdated docs pages didn't list it as one of the supported OSes, this is being rectified in https://github.com/llvm/llvm-project/pull/106874. MinGW is anoth

[clang] [clang] Don't add DWARF debug info when assembling .s with clang-cl /Z7 (PR #106686)

2024-09-02 Thread Martin Storsjö via cfe-commits
mstorsjo wrote: @MaskRay - IIRC you're on vacation, but in case you're lurking - any objection to merging this to fix the regression (and backporting it)? If not, I'll go ahead and merge it in a day or two. (It probably misses 19.1.0 RC 4, but can go into the later releases at least.) Also eve

[clang] [clang] [docs] Clarify the issue with compiler-rt on Windows/MSVC (PR #106875)

2024-09-03 Thread Martin Storsjö via cfe-commits
https://github.com/mstorsjo closed https://github.com/llvm/llvm-project/pull/106875 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Don't add DWARF debug info when assembling .s with clang-cl /Z7 (PR #106686)

2024-09-03 Thread Martin Storsjö via cfe-commits
https://github.com/mstorsjo closed https://github.com/llvm/llvm-project/pull/106686 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Don't add DWARF debug info when assembling .s with clang-cl /Z7 (PR #106686)

2024-09-03 Thread Martin Storsjö via cfe-commits
https://github.com/mstorsjo milestoned https://github.com/llvm/llvm-project/pull/106686 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Don't add DWARF debug info when assembling .s with clang-cl /Z7 (PR #106686)

2024-09-03 Thread Martin Storsjö via cfe-commits
mstorsjo wrote: /cherry-pick fcb7b390ccd5b4cfc71f13b5e16a846f3f400c10 https://github.com/llvm/llvm-project/pull/106686 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 70f3511 - [clang] [test] Fix the debug-options-as.c test on macOS

2024-09-03 Thread Martin Storsjö via cfe-commits
Author: Martin Storsjö Date: 2024-09-03T23:14:38+03:00 New Revision: 70f3511adaea4d3a9f8fadb23e84f518cc0654ab URL: https://github.com/llvm/llvm-project/commit/70f3511adaea4d3a9f8fadb23e84f518cc0654ab DIFF: https://github.com/llvm/llvm-project/commit/70f3511adaea4d3a9f8fadb23e84f518cc0654ab.diff

[clang] [clang] Don't add DWARF debug info when assembling .s with clang-cl /Z7 (PR #106686)

2024-09-03 Thread Martin Storsjö via cfe-commits
mstorsjo wrote: /cherry-pick fcb7b390ccd5b4cfc71f13b5e16a846f3f400c10 70f3511adaea4d3a9f8fadb23e84f518cc0654ab https://github.com/llvm/llvm-project/pull/106686 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

[clang] cbb5f03 - [clang] [test] Fix the debug-options-as.c test on PowerPC

2024-09-03 Thread Martin Storsjö via cfe-commits
Author: Martin Storsjö Date: 2024-09-03T23:50:54+03:00 New Revision: cbb5f03f5042aa6d7c5d17963eba192861c9165c URL: https://github.com/llvm/llvm-project/commit/cbb5f03f5042aa6d7c5d17963eba192861c9165c DIFF: https://github.com/llvm/llvm-project/commit/cbb5f03f5042aa6d7c5d17963eba192861c9165c.diff

[clang] [clang] Don't add DWARF debug info when assembling .s with clang-cl /Z7 (PR #106686)

2024-09-03 Thread Martin Storsjö via cfe-commits
mstorsjo wrote: /cherry-pick https://github.com/llvm/llvm-project/commit/fcb7b390ccd5b4cfc71f13b5e16a846f3f400c10 https://github.com/llvm/llvm-project/commit/70f3511adaea4d3a9f8fadb23e84f518cc0654ab cbb5f03f5042aa6d7c5d17963eba192861c9165c https://github.com/llvm/llvm-project/pull/106686 ___

[clang] [clang][X86] Add __cpuidex function to cpuid.h (PR #97785)

2024-07-11 Thread Martin Storsjö via cfe-commits
https://github.com/mstorsjo approved this pull request. LGTM, let’s reland this https://github.com/llvm/llvm-project/pull/97785 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] [Headers] Don't use unreserved name in avx512fp16intrin.h (PR #98478)

2024-07-11 Thread Martin Storsjö via cfe-commits
https://github.com/mstorsjo created https://github.com/llvm/llvm-project/pull/98478 This can cause breakage with user code that does "#define A ...". From dccf2ca991822c467225541a631cc41a8761a122 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20Storsj=C3=B6?= Date: Thu, 11 Jul 2024 16:15:59 +

[clang] [clang] [Headers] Don't use unreserved name in avx512fp16intrin.h (PR #98478)

2024-07-11 Thread Martin Storsjö via cfe-commits
mstorsjo wrote: > Hmm, what's your usage? > > #define A > > before > > #include > > ? Yes, exactly https://github.com/llvm/llvm-project/pull/98478 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/list

[clang] [clang] [Headers] Don't use unreserved name in avx512fp16intrin.h (PR #98478)

2024-07-11 Thread Martin Storsjö via cfe-commits
https://github.com/mstorsjo updated https://github.com/llvm/llvm-project/pull/98478 From dccf2ca991822c467225541a631cc41a8761a122 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20Storsj=C3=B6?= Date: Thu, 11 Jul 2024 16:15:59 +0300 Subject: [PATCH 1/2] =?UTF-8?q?[clang]=20[Headers]=C2=A0Don't=

[clang] [clang] Stub out gcc_struct attribute (PR #71148)

2024-07-11 Thread Martin Storsjö via cfe-commits
mstorsjo wrote: > Ping @MaskRay > > Changes in the force-push: > > * rebased on top of main; > * moved `defaultsToMsStruct` to `ASTContext` since it also depends on > auxiliary target. Please update the subject of the PR - this doesn't stub out the attribute, it implements it, if I understan

[clang] [llvm] [Driver] Restore compiler-rt arch suffix for PS and Windows (PR #89775)

2024-05-01 Thread Martin Storsjö via cfe-commits
mstorsjo wrote: One reason why I’m not entirely thrilled (not firmly against, but not thrilled - but I’m not sure if there are much better options either) with this direction, is that it becomes messy when cross compiling. LLVM_ENABLE_PER_TARGET_RUNTIME_DIR is automatically set based on the ho

[clang] [analyzer] Fix a test issue in mingw configurations (PR #92737)

2024-05-20 Thread Martin Storsjö via cfe-commits
https://github.com/mstorsjo created https://github.com/llvm/llvm-project/pull/92737 On Windows, long is always 32 bit, thus one can't use long for casting pointers to integers, on 64 bit architectures. Instead use long long, which should be large enough. This avoids errors like "error: cast f

[clang] [analyzer] Fix a test issue in mingw configurations (PR #92737)

2024-05-27 Thread Martin Storsjö via cfe-commits
https://github.com/mstorsjo closed https://github.com/llvm/llvm-project/pull/92737 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] f8de9aa - [llvm-rc] Add a GNU windres-like frontend to llvm-rc

2021-04-26 Thread Martin Storsjö via cfe-commits
Author: Martin Storsjö Date: 2021-04-26T22:04:29+03:00 New Revision: f8de9aaef2f472ad7572748582444083d31d5a95 URL: https://github.com/llvm/llvm-project/commit/f8de9aaef2f472ad7572748582444083d31d5a95 DIFF: https://github.com/llvm/llvm-project/commit/f8de9aaef2f472ad7572748582444083d31d5a95.diff

[clang] a8877c5 - [clang] [MinGW] Pass --no-demangle through to the mingw linker

2022-01-02 Thread Martin Storsjö via cfe-commits
Author: Martin Storsjö Date: 2022-01-03T00:22:40+02:00 New Revision: a8877c5ccc0e05495d60f1669d47826e60f373b8 URL: https://github.com/llvm/llvm-project/commit/a8877c5ccc0e05495d60f1669d47826e60f373b8 DIFF: https://github.com/llvm/llvm-project/commit/a8877c5ccc0e05495d60f1669d47826e60f373b8.diff

Re: [clang] 80e2c58 - [clang] Remove redundant member initialization (NFC)

2022-01-10 Thread Martin Storsjö via cfe-commits
On Sun, 9 Jan 2022, Kazu Hirata via cfe-commits wrote: Author: Kazu Hirata Date: 2022-01-09T00:19:51-08:00 New Revision: 80e2c587498a7b2bf14dde47a33a058da6e88a9a URL: https://github.com/llvm/llvm-project/commit/80e2c587498a7b2bf14dde47a33a058da6e88a9a DIFF: https://github.com/llvm/llvm-proje

[clang] 50ec130 - [clang] Add --start-no-unused-arguments/--end-no-unused-arguments to silence some unused argument warnings

2022-01-10 Thread Martin Storsjö via cfe-commits
Author: Martin Storsjö Date: 2022-01-11T09:22:00+02:00 New Revision: 50ec1306d060e46e0d53c9f5d8a052e1b0d10d3b URL: https://github.com/llvm/llvm-project/commit/50ec1306d060e46e0d53c9f5d8a052e1b0d10d3b DIFF: https://github.com/llvm/llvm-project/commit/50ec1306d060e46e0d53c9f5d8a052e1b0d10d3b.diff

[clang] e26bbae - [clang] [test] Remove newly added tests that fail on Darwin

2022-01-11 Thread Martin Storsjö via cfe-commits
Author: Martin Storsjö Date: 2022-01-11T11:06:29+02:00 New Revision: e26bbae30218a35d76a79fe90b0e41dd0f71b779 URL: https://github.com/llvm/llvm-project/commit/e26bbae30218a35d76a79fe90b0e41dd0f71b779 DIFF: https://github.com/llvm/llvm-project/commit/e26bbae30218a35d76a79fe90b0e41dd0f71b779.diff

[clang] 18b2385 - [clang] [test] Fix clang-cl unused argument tests on paths that start with /U

2022-01-11 Thread Martin Storsjö via cfe-commits
Author: Martin Storsjö Date: 2022-01-11T12:28:23+02:00 New Revision: 18b2385f2b09453b5e9d26459ec9e806f5ee7f86 URL: https://github.com/llvm/llvm-project/commit/18b2385f2b09453b5e9d26459ec9e806f5ee7f86 DIFF: https://github.com/llvm/llvm-project/commit/18b2385f2b09453b5e9d26459ec9e806f5ee7f86.diff

[clang] 120d44d - [clang] Fix a misadjusted path style comparison in a unittest

2021-12-09 Thread Martin Storsjö via cfe-commits
Author: Martin Storsjö Date: 2021-12-09T11:47:43+02:00 New Revision: 120d44d1a00b12b79057420eb1d89277522348b1 URL: https://github.com/llvm/llvm-project/commit/120d44d1a00b12b79057420eb1d89277522348b1 DIFF: https://github.com/llvm/llvm-project/commit/120d44d1a00b12b79057420eb1d89277522348b1.diff

[clang] 3637c5c - [clang] [AArch64] Fix Windows va_arg handling for larger structs

2021-04-14 Thread Martin Storsjö via cfe-commits
Author: Martin Storsjö Date: 2021-04-14T14:51:53+03:00 New Revision: 3637c5c8ec3d4dc0b87eb4e3ee9c9ae8816cade2 URL: https://github.com/llvm/llvm-project/commit/3637c5c8ec3d4dc0b87eb4e3ee9c9ae8816cade2 DIFF: https://github.com/llvm/llvm-project/commit/3637c5c8ec3d4dc0b87eb4e3ee9c9ae8816cade2.diff

[clang] ee570e2 - [clang] [test] Share patterns in CodeGen/ms_abi_aarch64.c between cases. NFC.

2021-04-15 Thread Martin Storsjö via cfe-commits
Author: Martin Storsjö Date: 2021-04-15T11:02:14+03:00 New Revision: ee570e215353625a867fcbfd8c3089e9e0f8660d URL: https://github.com/llvm/llvm-project/commit/ee570e215353625a867fcbfd8c3089e9e0f8660d DIFF: https://github.com/llvm/llvm-project/commit/ee570e215353625a867fcbfd8c3089e9e0f8660d.diff

[clang] 8e0f2e8 - [clang] [AArch64] Fix handling of HFAs passed to Windows variadic functions

2021-04-15 Thread Martin Storsjö via cfe-commits
Author: Martin Storsjö Date: 2021-04-15T22:21:27+03:00 New Revision: 8e0f2e89ff951c74875ed751e2215cc263b33328 URL: https://github.com/llvm/llvm-project/commit/8e0f2e89ff951c74875ed751e2215cc263b33328 DIFF: https://github.com/llvm/llvm-project/commit/8e0f2e89ff951c74875ed751e2215cc263b33328.diff

[clang] d4528cb - [clang] Fix cross compiling clang for windows after 141945f950e2f3f

2021-04-18 Thread Martin Storsjö via cfe-commits
Author: Martin Storsjö Date: 2021-04-18T15:56:18+03:00 New Revision: d4528cbb0e703ee17ee6fb4abe72b7246ccb38f1 URL: https://github.com/llvm/llvm-project/commit/d4528cbb0e703ee17ee6fb4abe72b7246ccb38f1 DIFF: https://github.com/llvm/llvm-project/commit/d4528cbb0e703ee17ee6fb4abe72b7246ccb38f1.diff

[clang] 64bc44f - [llvm-rc] Run clang to preprocess input files

2021-04-21 Thread Martin Storsjö via cfe-commits
Author: Martin Storsjö Date: 2021-04-21T11:50:10+03:00 New Revision: 64bc44f5ddfb6da4b6a8b51ea9a03f8772b3ae95 URL: https://github.com/llvm/llvm-project/commit/64bc44f5ddfb6da4b6a8b51ea9a03f8772b3ae95 DIFF: https://github.com/llvm/llvm-project/commit/64bc44f5ddfb6da4b6a8b51ea9a03f8772b3ae95.diff

[clang] 066b8f2 - [llvm-rc] Try to fix the Preprocessor/llvm-rc.rc test on non arm/x86 architectures

2021-04-21 Thread Martin Storsjö via cfe-commits
Author: Martin Storsjö Date: 2021-04-21T12:47:33+03:00 New Revision: 066b8f2fc6d584635a017a0a15494ce4460744e3 URL: https://github.com/llvm/llvm-project/commit/066b8f2fc6d584635a017a0a15494ce4460744e3 DIFF: https://github.com/llvm/llvm-project/commit/066b8f2fc6d584635a017a0a15494ce4460744e3.diff

[clang] 174e796 - [llvm-rc] Fix a new test to disambiguate macOS paths like /Users/... from options starting with a slash

2021-04-21 Thread Martin Storsjö via cfe-commits
Author: Martin Storsjö Date: 2021-04-21T13:34:33+03:00 New Revision: 174e796c7d41e720e2a78e3de451b893d9e3a43f URL: https://github.com/llvm/llvm-project/commit/174e796c7d41e720e2a78e3de451b893d9e3a43f DIFF: https://github.com/llvm/llvm-project/commit/174e796c7d41e720e2a78e3de451b893d9e3a43f.diff

<    1   2   3   4   5   6   7   >