mclow.lists added inline comments.
Comment at: src/cxa_personality.cpp:363
+ "Unexpected TTypeEncoding");
(void)ttypeEncoding;
logan wrote:
> mclow.lists wrote:
> > It's not clear to me how this accomplishes what you want.
> > You're looking for
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
LGTM. One minor suggestion (adding a comment to a test).
Comment at: libcxx/test/std/re/re.alg/re.alg.match/ecma.pass.cpp:374
std::cmatch m;
cons
Author: marshall
Date: Thu Oct 27 10:10:07 2016
New Revision: 285300
URL: http://llvm.org/viewvc/llvm-project?rev=285300&view=rev
Log:
Move 'quoted' for string_view from to (where the other
versions of 'quoted' live. No functional change.
Modified:
libcxx/trunk/include/iomanip
libcxx/t
mclow.lists accepted this revision.
mclow.lists added a comment.
LGTM
https://reviews.llvm.org/D26141
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mclow.lists added a comment.
This all looks ok to me - all mechanical changes.
I wonder if there's a better way to refactor these - there's all that
duplicated code.
Does this look any better to you?
Replace:
try
{
s.replace(pos1, n1, str, pos2);
LIBCPP_ASSERT(s.__invariants());
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
This looks OK to me.
https://reviews.llvm.org/D26184
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
Thanks for making these changes; I think this looks much better than before.
Feature creep: A bunch of the local variables can be marked as `const`.
Comment at:
te
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D26197
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
Thanks.
https://reviews.llvm.org/D24085
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
Author: marshall
Date: Wed Nov 2 10:30:26 2016
New Revision: 285818
URL: http://llvm.org/viewvc/llvm-project?rev=285818&view=rev
Log:
Implement another part of P0031; adding constexpr to move_iterator
Modified:
libcxx/trunk/include/iterator
libcxx/trunk/test/std/iterators/predef.iterato
mclow.lists accepted this revision.
mclow.lists added a reviewer: mclow.lists.
mclow.lists added a comment.
This revision is now accepted and ready to land.
Committed as revision 285818
https://reviews.llvm.org/D25828
___
cfe-commits mailing list
cf
Author: marshall
Date: Wed Nov 2 11:39:55 2016
New Revision: 285831
URL: http://llvm.org/viewvc/llvm-project?rev=285831&view=rev
Log:
Add conditions for PPC to libunwind. Fixes PR22200. Thanks to Jeremy for the
bug report and the patch.
Modified:
libunwind/trunk/src/config.h
Modified: libu
Author: marshall
Date: Wed Nov 2 12:56:05 2016
New Revision: 285845
URL: http://llvm.org/viewvc/llvm-project?rev=285845&view=rev
Log:
Add support for old versions of MacOS to libunwind. Fixes PR22203. Thanks to
Jeremy for the bug report and the patch.
Modified:
libunwind/trunk/include/libun
mclow.lists added a comment.
> I think it might be better to add TEST_TRY and TEST_CATCH(...) macros
> defined like
@rogfer01 said at the top that he didn't want to add "a magical TEST_TRY macro"
- and I agree. Someone tried that in another review, and I nixed it there.
https://reviews.llv
mclow.lists added a comment.
In https://reviews.llvm.org/D26596#593948, @chandlerc wrote:
> I think we want dedicated macros to disable each added [[nodiscard]].
My concern here is that I expect that there will be a lot of these.
Off the top of my head, I can name:
- Every smart pointer's `get
mclow.lists added a comment.
Note: I'm not unsympathetic to the situation that Chandler describes; I just
don't want to manage a potentially unbounded (but probably more than 20) set of
macros.
https://reviews.llvm.org/D26596
___
cfe-commits maili
Author: marshall
Date: Mon Nov 14 08:41:33 2016
New Revision: 286828
URL: http://llvm.org/viewvc/llvm-project?rev=286828&view=rev
Log:
Update C++1z status with C++17 issues from Issaquah. Still to come: LFTS issues
and papers
Modified:
libcxx/trunk/www/cxx1z_status.html
Modified: libcxx/tru
Author: marshall
Date: Mon Nov 14 08:53:07 2016
New Revision: 286834
URL: http://llvm.org/viewvc/llvm-project?rev=286834&view=rev
Log:
Update C++1z status with LFTS issues from Issaquah.
Modified:
libcxx/trunk/www/cxx1z_status.html
Modified: libcxx/trunk/www/cxx1z_status.html
URL:
http://ll
Author: marshall
Date: Mon Nov 14 09:09:45 2016
New Revision: 286835
URL: http://llvm.org/viewvc/llvm-project?rev=286835&view=rev
Log:
Update C++1z status with LWG papers from Issaquah.
Modified:
libcxx/trunk/www/cxx1z_status.html
Modified: libcxx/trunk/www/cxx1z_status.html
URL:
http://llv
Author: marshall
Date: Mon Nov 14 12:22:19 2016
New Revision: 286858
URL: http://llvm.org/viewvc/llvm-project?rev=286858&view=rev
Log:
Fixes for LWG 2598, 2686, 2739, 2742, 2747, and 2759, which were adopted last
week in Issaquah
Added:
libcxx/trunk/test/std/diagnostics/syserr/syserr.hash/e
Author: marshall
Date: Mon Nov 14 12:56:24 2016
New Revision: 286864
URL: http://llvm.org/viewvc/llvm-project?rev=286864&view=rev
Log:
Implement P0510 'Make future_error Constructible' adopted in Issaquah
Modified:
libcxx/trunk/include/future
libcxx/trunk/test/std/thread/futures/futures.f
Author: marshall
Date: Mon Nov 14 13:35:34 2016
New Revision: 286872
URL: http://llvm.org/viewvc/llvm-project?rev=286872&view=rev
Log:
Make one of the new tests fail correctly on pre-C++17 systems
Modified:
libcxx/trunk/test/std/utilities/memory/specialized.algorithms/specialized.addressof/a
Author: marshall
Date: Tue Sep 8 12:59:09 2015
New Revision: 247036
URL: http://llvm.org/viewvc/llvm-project?rev=247036&view=rev
Log:
Implementation of Boyer-Moore and Boyer-Moore-Horspool searchers for the LFTS.
Added:
libcxx/trunk/test/std/experimental/func/func.searchers/func.searchers.b
mclow.lists closed this revision.
mclow.lists added a comment.
Landed as revision 247036
http://reviews.llvm.org/D11380
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mclow.lists added a comment.
I have two concerns about this patch (w/o commenting on the actual code).
1. Until very recently, I was under the impression that C libraries _either_
defined a macro, or had a function. I was quite surprised to find that glibc
did both. Have you checked other C lib
Author: marshall
Date: Tue Sep 15 09:46:03 2015
New Revision: 247695
URL: http://llvm.org/viewvc/llvm-project?rev=247695&view=rev
Log:
Change initialization of mbstate_t objects in tests from '= {0}' to '= {}',
which does the same thing, w/o having clang and gcc warn with -Wall.
Modified:
li
Author: marshall
Date: Tue Sep 15 12:12:49 2015
New Revision: 247704
URL: http://llvm.org/viewvc/llvm-project?rev=247704&view=rev
Log:
Suppress some warnings in the tests that snuck in. That 'tmpnam' is deprecated
doesn't change the fact that we have to test it.
Modified:
libcxx/trunk/test/
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
This looks good to me.
http://reviews.llvm.org/D12895
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi
Author: marshall
Date: Tue Sep 22 12:50:11 2015
New Revision: 248304
URL: http://llvm.org/viewvc/llvm-project?rev=248304&view=rev
Log:
Change pair::swap(pair&) to call ADL swap instead of iter_swap; this fixes an
obscure bug having to do with overloaded operator&. Fixes PR#24890
Modified:
li
Author: marshall
Date: Tue Sep 22 12:57:41 2015
New Revision: 248305
URL: http://llvm.org/viewvc/llvm-project?rev=248305&view=rev
Log:
Check in the test for PR#24890 that I forgot in previous commit
Modified:
libcxx/trunk/test/std/utilities/utility/pairs/pairs.pair/swap.pass.cpp
Modified: li
Author: marshall
Date: Tue Sep 22 13:09:13 2015
New Revision: 248307
URL: http://llvm.org/viewvc/llvm-project?rev=248307&view=rev
Log:
The test I cnecked in to check the fix for PR#24890 failed (as expected) w/o
the fix, but for the wrong reason. Now it fails for the right reason.
Modified:
Author: marshall
Date: Tue Sep 22 16:58:30 2015
New Revision: 248329
URL: http://llvm.org/viewvc/llvm-project?rev=248329&view=rev
Log:
Fix Typo in GCC no RTTI detection. Fixes PR#24901. Thanks to Bernhard
Rosenkraenzer for the report and the patch.
Modified:
libcxx/trunk/include/__config
Mo
mclow.lists added a comment.
Please DO NOT commit this patch.
See http://cplusplus.github.io/LWG/lwg-active.html#2224 for a discussion of
this code, and the (proposed) resolution is that this is undefined behavior.
http://reviews.llvm.org/D13080
_
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
LGTM.
I can't reproduce the error that I was getting.
http://reviews.llvm.org/D13337
___
cfe-commits mailing list
cfe-commits@lists.llv
On Fri, Oct 2, 2015 at 1:58 PM, Eric Fiselier wrote:
> Hi Tom,
>
> I would like this patch merged into 3.7.1.
> Marshall can you please approve this?
>
Looks fine to me.
-- Marshall
>
> /Eric
>
> On Tue, Sep 22, 2015 at 12:55 PM, Dimitry Andric via cfe-commits
> wrote:
> > Author: dim
> > Da
mclow.lists added a comment.
Works for me.
Now we need to do the same for clang.
http://reviews.llvm.org/D13331
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: marshall
Date: Mon Oct 5 11:17:34 2015
New Revision: 249325
URL: http://llvm.org/viewvc/llvm-project?rev=249325&view=rev
Log:
Implement LWG#2063, and update the issues links to point to the github
generated pages
Modified:
libcxx/trunk/include/string
libcxx/trunk/test/std/strin
Author: marshall
Date: Mon Oct 5 13:40:13 2015
New Revision: 249333
URL: http://llvm.org/viewvc/llvm-project?rev=249333&view=rev
Log:
Private page for status of Kona issues and papers. Will be deleted after the
Kona meeting. Not to be linked to from other pages.
Added:
libcxx/trunk/www/kona
Author: marshall
Date: Mon Oct 5 13:48:10 2015
New Revision: 249334
URL: http://llvm.org/viewvc/llvm-project?rev=249334&view=rev
Log:
Add comments about the issues
Modified:
libcxx/trunk/www/kona.html
Modified: libcxx/trunk/www/kona.html
URL:
http://llvm.org/viewvc/llvm-project/libcxx/trun
Author: marshall
Date: Mon Oct 5 15:16:30 2015
New Revision: 249345
URL: http://llvm.org/viewvc/llvm-project?rev=249345&view=rev
Log:
Patch ready for 2127
Modified:
libcxx/trunk/www/kona.html
Modified: libcxx/trunk/www/kona.html
URL:
http://llvm.org/viewvc/llvm-project/libcxx/trunk/www/kon
Author: marshall
Date: Mon Oct 5 15:21:54 2015
New Revision: 249347
URL: http://llvm.org/viewvc/llvm-project?rev=249347&view=rev
Log:
Mark 2072 as complete; we already do this
Modified:
libcxx/trunk/www/kona.html
Modified: libcxx/trunk/www/kona.html
URL:
http://llvm.org/viewvc/llvm-project
Author: marshall
Date: Mon Oct 5 15:35:30 2015
New Revision: 249348
URL: http://llvm.org/viewvc/llvm-project?rev=249348&view=rev
Log:
Mark a couple more issues 'ready'
Modified:
libcxx/trunk/www/kona.html
Modified: libcxx/trunk/www/kona.html
URL:
http://llvm.org/viewvc/llvm-project/libcxx/
Author: marshall
Date: Mon Oct 5 15:50:25 2015
New Revision: 249349
URL: http://llvm.org/viewvc/llvm-project?rev=249349&view=rev
Log:
Fixed a possible overflow in a test of allocator::max_size().
Modified:
libcxx/trunk/test/std/utilities/memory/default.allocator/allocator.members/max_size.p
Author: marshall
Date: Mon Oct 5 16:08:49 2015
New Revision: 249352
URL: http://llvm.org/viewvc/llvm-project?rev=249352&view=rev
Log:
Patch for 2466 is ready
Modified:
libcxx/trunk/www/kona.html
Modified: libcxx/trunk/www/kona.html
URL:
http://llvm.org/viewvc/llvm-project/libcxx/trunk/www/
Author: marshall
Date: Mon Oct 5 16:11:20 2015
New Revision: 249354
URL: http://llvm.org/viewvc/llvm-project?rev=249354&view=rev
Log:
Mark 2380 and 2384 as complete; no changes needed
Modified:
libcxx/trunk/www/kona.html
Modified: libcxx/trunk/www/kona.html
URL:
http://llvm.org/viewvc/llvm
Author: marshall
Date: Mon Oct 5 18:27:10 2015
New Revision: 249363
URL: http://llvm.org/viewvc/llvm-project?rev=249363&view=rev
Log:
Mark 2259 and 2473 as complete. Add some more notes
Modified:
libcxx/trunk/www/kona.html
Modified: libcxx/trunk/www/kona.html
URL:
http://llvm.org/viewvc/ll
Author: marshall
Date: Tue Oct 6 15:30:56 2015
New Revision: 249458
URL: http://llvm.org/viewvc/llvm-project?rev=249458&view=rev
Log:
Our test allocators support move/copy construction; they should support
move/copy assignment as well
Modified:
libcxx/trunk/test/support/allocators.h
Modifi
Author: marshall
Date: Tue Oct 6 15:35:15 2015
New Revision: 249461
URL: http://llvm.org/viewvc/llvm-project?rev=249461&view=rev
Log:
Updated issue 2476
Modified:
libcxx/trunk/www/kona.html
Modified: libcxx/trunk/www/kona.html
URL:
http://llvm.org/viewvc/llvm-project/libcxx/trunk/www/kona.
Author: marshall
Date: Wed Oct 7 14:41:24 2015
New Revision: 249593
URL: http://llvm.org/viewvc/llvm-project?rev=249593&view=rev
Log:
While researching LWG#2244, I noticed we weren't testing that eofbit was being
cleared. Now we are
Modified:
libcxx/trunk/test/std/input.output/iostream.for
Author: marshall
Date: Wed Oct 7 14:45:14 2015
New Revision: 249595
URL: http://llvm.org/viewvc/llvm-project?rev=249595&view=rev
Log:
Mark 2244 as 'Patch Ready', 2477 and 2487 as 'Complete'
Modified:
libcxx/trunk/www/kona.html
Modified: libcxx/trunk/www/kona.html
URL:
http://llvm.org/viewv
On Mon, Aug 10, 2015 at 11:12 AM, Hans Wennborg wrote:
> On Mon, Aug 10, 2015 at 11:09 AM, Joerg Sonnenberger via cfe-commits
> wrote:
> > On Mon, Aug 10, 2015 at 04:58:04PM -, Joerg Sonnenberger via
> cfe-commits wrote:
> >> Author: joerg
> >> Date: Mon Aug 10 11:58:04 2015
> >> New Revisio
mclow.lists created this revision.
mclow.lists added reviewers: chandlerc, rsmith, EricWF.
mclow.lists added a subscriber: cfe-commits.
Herald added subscribers: danalbert, tberghammer.
The C standard says that calling `memcpy`, etc with null parameters is
undefined behavior.
GCC (and clang) have
mclow.lists added a subscriber: mclow.lists.
mclow.lists added a reviewer: mclow.lists.
mclow.lists added a comment.
I agree with @jroelofs that we don't want to `#include ` in
`<__config>`
Repository:
rL LLVM
http://reviews.llvm.org/D11781
___
mclow.lists added inline comments.
Comment at: include/cstring:96
@@ +95,3 @@
+int strncmp(const char* __s1, const char* __s2, size_t __n)
+{ return ::memcmp(__s1, __s2, __n); }
+
nlopes wrote:
> typo here.
Oops. Thanks!
http://reviews.llvm.org/D11948
___
mclow.lists added a comment.
In http://reviews.llvm.org/D11948#221936, @joerg wrote:
> I'm against doing this unconditionally. IMO it creates bugs without
> reasonable compensation. Just because glibc wants to hurt people doesn't mean
> anyone should get hurt.
Really? I see it as:
It tells
mclow.lists added a comment.
In http://reviews.llvm.org/D11948#221991, @joerg wrote:
> No, it doesn't. It tells the compiler that it is free to make such
> assumptions.
Again, I disagree. The compiler already knows it is free to make such
assumptions.
(LLVM has an entire optimizer pass devote
On Tue, Aug 11, 2015 at 1:34 PM, Dan Albert wrote:
> Yeah, those sound like exactly what we want. Helping people find UB is
> good, but optimizing assuming we've fixed all of the UB isn't something we
> can do.
>
Dan -- that's the situation you're in today.
GCC has done that kind of optimization
mclow.lists added inline comments.
Comment at: include/__config:19
@@ -18,1 +18,3 @@
+#include <__config_site>
+
#ifdef __GNUC__
I'm reluctant to do this; because every include file slows down compilation -
for every program that we compile.
However, this may b
mclow.lists added a comment.
How does this change interact with http://reviews.llvm.org/D11963 ?
Repository:
rL LLVM
http://reviews.llvm.org/D11781
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
mclow.lists added inline comments.
Comment at: include/__config:19
@@ -18,1 +18,3 @@
+#include <__config_site>
+
#ifdef __GNUC__
espositofulvio wrote:
> mclow.lists wrote:
> > I'm reluctant to do this; because every include file slows down compilation
> > - for
On Tue, Aug 11, 2015 at 2:28 PM, Joerg Sonnenberger via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Tue, Aug 11, 2015 at 02:06:58PM -0700, Marshall Clow via cfe-commits
> wrote:
> > On Tue, Aug 11, 2015 at 1:34 PM, Dan Albert
> wrote:
> >
> > > Ye
On Wed, Aug 12, 2015 at 4:03 PM, Dan Albert wrote:
> My testing was varied. I could not get GCC or clang to optimize it away
> for Linux, but both did for ARM Android.
>
Then I don't understand your objection to this change, then.
On your platform, the effect of this change is (therefore) a com
Author: marshall
Date: Mon Aug 17 16:14:16 2015
New Revision: 245239
URL: http://llvm.org/viewvc/llvm-project?rev=245239&view=rev
Log:
Make regex and any assert when they should throw an exception _but_ the user
has decreed 'no exceptions'. This matches the behavior of string and vector
Modified
Author: marshall
Date: Tue Aug 18 13:57:00 2015
New Revision: 245330
URL: http://llvm.org/viewvc/llvm-project?rev=245330&view=rev
Log:
implement more of N4258 - Cleaning up noexcept in the standard library.
Specifically add new noexcept stuff to vector and string's move-assignment
operations
Mo
Author: marshall
Date: Tue Aug 18 14:51:37 2015
New Revision: 245336
URL: http://llvm.org/viewvc/llvm-project?rev=245336&view=rev
Log:
Broke C++03 compatibility in 245330. Fix that.
Modified:
libcxx/trunk/include/memory
Modified: libcxx/trunk/include/memory
URL:
http://llvm.org/viewvc/llvm-
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
I think this is ready to land now. Thanks, Eric.
http://reviews.llvm.org/D11555
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: marshall
Date: Mon Aug 24 10:57:09 2015
New Revision: 245849
URL: http://llvm.org/viewvc/llvm-project?rev=245849&view=rev
Log:
Fix a crasher found by libFuzzer
Modified:
libcxx/trunk/include/regex
libcxx/trunk/test/std/re/re.alg/re.alg.search/grep.pass.cpp
Modified: libcxx/trunk/
mclow.lists added a comment.
So far, this looks good. I'm going to apply it locally and futz with it.
Comment at: include/__functional_base_03:30
@@ +29,3 @@
+typedef _Ret _Bullet2;
+typedef _Ret type;
+};
Let's be consistent. :-)
typedef _Bullet2 t
mclow.lists added a comment.
I think I'd rather see the call to `strcmp` and `wcscmp` in the char_traits
class.
http://reviews.llvm.org/D12355
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
mclow.lists added inline comments.
Comment at: include/__functional_base:521
@@ +520,3 @@
+operator() (_ArgTypes&&... __args) const {
+return __invoke(get(), _VSTD::forward<_ArgTypes>(__args)...);
+}
I know you didn't change this, but how did we ge
mclow.lists added a comment.
Everything except __functional_03 LGTM. That's not to say that that file has
problems, it's just that the diff display is not really helping :-)
http://reviews.llvm.org/D11553
___
cfe-commits mailing list
cfe-commits@
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
Ok, I think this is good to go. Thanks, Eric.
http://reviews.llvm.org/D11553
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ht
mclow.lists added a comment.
I like this because it localizes the weirdness into one routine `self`.
If we can't get D12999 applied due to ABI concerns, this will help a bunch.
http://reviews.llvm.org/D12297
___
cfe-commits mailing list
cfe-commits@
mclow.lists added a comment.
So... what do we need to do to enumerate the "ABI breakage" of this patch?
I get that there's a couple of member variables that are changing type. Can
they change (as a result of this patch) from a plain pointer to a fancy pointer
(or vice versa)? Can they change si
mclow.lists added a comment.
In http://reviews.llvm.org/D12355#233477, @bkramer wrote:
> Won't this do the wrong thing for embedded '\0' in a std::string?
>
> std::string("hello\0world", 11).compare("hello")
>
>
> should not return 0.
Good point; I think that pretty much kills this propose
Author: marshall
Date: Thu Aug 27 09:37:22 2015
New Revision: 246150
URL: http://llvm.org/viewvc/llvm-project?rev=246150&view=rev
Log:
Remove a switch statement, and replace with a bunch of ifs to silence a warning
about 'all the enumeration values covered'. No functional change.
Modified:
l
mclow.lists added inline comments.
Comment at: include/string:3801
@@ -3799,1 +3800,3 @@
+if (__lhs_len != __rhs.size()) return false;
+return _Traits::compare(__rhs.data(), __lhs, _VSTD::min(__lhs_len,
__rhs.size())) == 0;
}
If the lengths are the same
mclow.lists added a comment.
The first change LGTM. The second one needs to match it.
Comment at: include/string:3816
@@ -3808,2 +3815,3 @@
+return __lhs.compare(0, _String::npos, __rhs, __rhs_len) == 0;
}
You'll want to do the same as above here.
http:
mclow.lists added a comment.
Two comments answered. One still remaining.
Comment at: include/experimental/functional:256
@@ +255,3 @@
+
+public: // TODO private:
+_RandomAccessIterator1 __first_;
EricWF wrote:
> Is this for testing?
Well, for debuggi
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
This looks very mechanical, except for the changes to test_allocator.h, and
that's a bug fix.
http://reviews.llvm.org/D12135
___
cfe-c
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
This is just making the two halves of the #ifdef consistent. LGTM.
http://reviews.llvm.org/D12173
___
cfe-commits mailing list
cfe-comm
Author: marshall
Date: Mon Aug 31 09:43:41 2015
New Revision: 246445
URL: http://llvm.org/viewvc/llvm-project?rev=246445&view=rev
Log:
Remove unused code. NFC
Modified:
libcxx/trunk/include/type_traits
Modified: libcxx/trunk/include/type_traits
URL:
http://llvm.org/viewvc/llvm-project/libcx
mclow.lists updated this revision to Diff 33624.
mclow.lists added a comment.
Fixed a typo in the patch for `strncmp`, and added a macro
`_LIBCPP_HAS_NO_NONNULL` to allow people to disable these checks.
Marked them as disabled for non-clang and non-gcc compilers.
http://reviews.llvm.org/D11948
mclow.lists updated this revision to Diff 33770.
mclow.lists added a comment.
Updated based on Eric's comments.
http://reviews.llvm.org/D11380
Files:
include/experimental/functional
test/std/experimental/algorithms/alg.search/search.pass.cpp
test/std/experimental/func/func.searchers/func
mclow.lists marked 3 inline comments as done.
mclow.lists added a comment.
http://reviews.llvm.org/D11380
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mclow.lists abandoned this revision.
mclow.lists added a comment.
There are other suggested fixes for this problem, and this has gotten stale.
http://reviews.llvm.org/D3197
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.or
Author: marshall
Date: Thu Sep 3 10:11:32 2015
New Revision: 246772
URL: http://llvm.org/viewvc/llvm-project?rev=246772&view=rev
Log:
Make a helper routine __throw_future_error, and encapsulate the #ifdef
_LIBCPP_NO_EXCEPTIONS there, instead of duplicating it throughout the code. No
functionali
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
This looks fine to me. Thanks for the patch (and the test case).
http://reviews.llvm.org/D13192
___
cfe-commits mailing list
cfe-commi
Author: marshall
Date: Wed Oct 7 22:02:09 2015
New Revision: 249649
URL: http://llvm.org/viewvc/llvm-project?rev=249649&view=rev
Log:
Fix incorrect parsing of arguments for nested functions. Reviewed as
http://reviews.llvm.org/D13192. Thanks to Anseny Kapoulkine for the patch.
Modified:
lib
On Wed, Oct 7, 2015 at 2:38 PM, Richard Smith wrote:
> Marshall: ping, does the below satisfy your concerns about the direction
> here?
>
No, not really, because I'm worried about behavior changes with this
approach.
#include
isdigit(c);
will call different code before and after this p
On Tue, Oct 6, 2015 at 3:36 PM, Richard Smith wrote:
> Split out of . This is a big change, but the same pattern
> as the prior ones.
>
> In this patch, you replicate the #ifdef XXX, __libcpp_XXX, #undef XXX
dance for all the isXXX functions. Is that because they're not required to
be actual fun
On Tue, Oct 6, 2015 at 3:42 PM, Richard Smith wrote:
> , an easy one. We guarantee a setjmp macro exists even if this
> header is somehow included from C (the C standard allows that, so it's not
> worth checking for __cplusplus).
>
> This looks fine to me.
-- Marshall
___
On Tue, Oct 6, 2015 at 3:57 PM, Richard Smith wrote:
> . This one is tricky:
>
> 1) There's an (undocumented) interface between the C standard library and
> this header, where the macros __need_ptrdiff_t, __need_size_t,
> __need_wchar_t, __need_NULL, __need_wint_t request just a piece of this
> h
Author: marshall
Date: Mon Oct 12 11:25:21 2015
New Revision: 250061
URL: http://llvm.org/viewvc/llvm-project?rev=250061&view=rev
Log:
Mark 2447 and 2466 as completed.
Modified:
libcxx/trunk/www/kona.html
Modified: libcxx/trunk/www/kona.html
URL:
http://llvm.org/viewvc/llvm-project/libcxx/t
Author: marshall
Date: Mon Oct 12 15:45:05 2015
New Revision: 250097
URL: http://llvm.org/viewvc/llvm-project?rev=250097&view=rev
Log:
Fix Bug 25103 - _cxa_demangle improperly demangles virtual thunks. Thanks to
Jason King for the report and suggested fix
Modified:
libcxxabi/trunk/src/cxa_de
mclow.lists closed this revision.
mclow.lists added a comment.
landed as revision 249649
http://reviews.llvm.org/D13192
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: marshall
Date: Tue Oct 20 02:37:11 2015
New Revision: 250802
URL: http://llvm.org/viewvc/llvm-project?rev=250802&view=rev
Log:
Detect relaxed constexpr rules for gcc versions
Modified:
libcxx/trunk/include/__config
Modified: libcxx/trunk/include/__config
URL:
http://llvm.org/viewvc/
Author: marshall
Date: Sun Oct 25 01:02:23 2015
New Revision: 251220
URL: http://llvm.org/viewvc/llvm-project?rev=251220&view=rev
Log:
Update C++ status from Kona
Modified:
libcxx/trunk/www/cxx1z_status.html
libcxx/trunk/www/kona.html
Modified: libcxx/trunk/www/cxx1z_status.html
URL:
ht
Author: marshall
Date: Sun Oct 25 13:31:51 2015
New Revision: 251246
URL: http://llvm.org/viewvc/llvm-project?rev=251246&view=rev
Log:
Fix LWG#2244: basic_istream::seekg
Modified:
libcxx/trunk/include/istream
libcxx/trunk/test/std/input.output/iostream.format/input.streams/istream.unform
Author: marshall
Date: Sun Oct 25 13:58:07 2015
New Revision: 251247
URL: http://llvm.org/viewvc/llvm-project?rev=251247&view=rev
Log:
Fix LWG#2127: Move-construction with raw_storage_iterator.
Modified:
libcxx/trunk/include/memory
libcxx/trunk/test/std/utilities/memory/storage.iterator/
501 - 600 of 905 matches
Mail list logo
