Author: marshall
Date: Mon Mar 14 12:58:54 2016
New Revision: 263451
URL: http://llvm.org/viewvc/llvm-project?rev=263451&view=rev
Log:
Add failing tests that I forgot to add to the last commit
Added:
libcxx/trunk/test/std/containers/container.adaptors/priority.queue/types.fail.cpp
libcx
On Fri, Mar 11, 2016 at 7:32 AM, Nico Weber wrote:
> I reverted this in 263246 for now. I think the right fix is just to
> add _LIBCPP_INLINE_VISIBILITY to the new constructor, but I'm not 100% sure.
>
> On Thu, Mar 10, 2016 at 10:21 AM, Nico Weber wrote:
>
>> I think this is ABI-breaking. On OS
Author: marshall
Date: Mon Mar 14 18:07:32 2016
New Revision: 263506
URL: http://llvm.org/viewvc/llvm-project?rev=263506&view=rev
Log:
Implement LWG2577: {shared,unique}_lock should use std::addressof
Modified:
libcxx/trunk/include/__mutex_base
libcxx/trunk/include/shared_mutex
libcx
Author: marshall
Date: Mon Mar 14 18:07:58 2016
New Revision: 263507
URL: http://llvm.org/viewvc/llvm-project?rev=263507&view=rev
Log:
Missed this file in previous checkin
Modified:
libcxx/trunk/test/support/nasty_containers.hpp
Modified: libcxx/trunk/test/support/nasty_containers.hpp
URL:
mclow.lists added inline comments.
Comment at: include/__bit_reference:75
@@ -73,1 +74,3 @@
+_LIBCPP_INLINE_VISIBILITY
+__bit_reference(const __bit_reference&) _NOEXCEPT = default;
private:
Sadly, we don't get to say '=default', because we have clients th
mclow.lists added a comment.
> Okay, but should I fix the 146 cases of " = default;" that were already there?
If there are `= default` in code that can be used from C++03, then they ought
to be fixed.
Note that many of the ones that turn up in a text search are in the synopsis -
not in the cod
mclow.lists added a comment.
One idea is to do this in two steps - do the `throw()` stuff in one patch, and
the defaulted fns in a second one.
http://reviews.llvm.org/D18217
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
Minor changes; other than that, LGTM.
Comment at: include/__config:43
@@ -42,1 +42,3 @@
+// Fix undefined behavior in how std::list stores it's linked nodes.
+#defin
mclow.lists created this revision.
mclow.lists added reviewers: howard.hinnant, EricWF, rsmith.
mclow.lists added a subscriber: cfe-commits.
libc++'s basic_string class assumes that iterator operations on the iterators
that are passed to it don't throw. This is wrong, and means that we don't mee
mclow.lists added inline comments.
Comment at: include/string:1211
@@ +1210,3 @@
+// noexcept(declval<_Iter>().operator++()) &&
+// noexcept(++(declval<_Iter>())) &&
+ noexcept(declval<_Iter>() == declval<_Iter>()) &&
This is not quite right yet.
mclow.lists marked an inline comment as done.
mclow.lists added a comment.
http://reviews.llvm.org/D15862
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mclow.lists updated this revision to Diff 43906.
mclow.lists added a comment.
Howard suggested a fix for the "is incremental" problem in the type trait. I
also added assignable.
http://reviews.llvm.org/D15862
Files:
include/algorithm
include/iterator
include/string
Index: include/string
mclow.lists added a comment.
ping?
http://reviews.llvm.org/D15121
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: marshall
Date: Tue Jan 5 13:32:41 2016
New Revision: 256859
URL: http://llvm.org/viewvc/llvm-project?rev=256859&view=rev
Log:
First half of LWG#2354: 'Unnecessary copying when inserting into maps with
braced-init syntax'
Modified:
libcxx/trunk/include/__tree
libcxx/trunk/include
Author: marshall
Date: Tue Jan 5 13:44:58 2016
New Revision: 256861
URL: http://llvm.org/viewvc/llvm-project?rev=256861&view=rev
Log:
Remove some test scaffolding that I added and then didn't need. No functional
change
Modified:
libcxx/trunk/test/support/MoveOnly.h
Modified: libcxx/trunk/t
Author: marshall
Date: Tue Jan 5 13:53:31 2016
New Revision: 256864
URL: http://llvm.org/viewvc/llvm-project?rev=256864&view=rev
Log:
Add explicit include directives; the file was getting implicitly included
already. NFC
Modified:
libcxx/trunk/test/std/containers/associative/map/map.modifi
mclow.lists updated this revision to Diff 44220.
mclow.lists added a comment.
Fixed a problem in the `__is_exactly_input_iterator` trait where it would fail
to compile if `<_Iter>` was not an iterator.
Added the cases for `append`, `insert`, and `replace`.
I have updated the tests (not included
mclow.lists marked an inline comment as done.
mclow.lists added a comment.
http://reviews.llvm.org/D15862
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mclow.lists updated this revision to Diff 44496.
mclow.lists added a comment.
Updated to address Tim's comments.
http://reviews.llvm.org/D15862
Files:
include/algorithm
include/iterator
include/string
test/std/strings/basic.string/string.modifiers/string_append/initializer_list.pass.cp
mclow.lists marked 2 inline comments as done.
Comment at: include/string:2677-2678
@@ +2676,4 @@
+#endif
+for (; __first != __last; ++__first)
+push_back(*__first);
+
tcanens wrote:
> If an exception is thrown after a `push_back()` causes reall
Author: marshall
Date: Mon Jan 11 13:27:10 2016
New Revision: 257368
URL: http://llvm.org/viewvc/llvm-project?rev=257368&view=rev
Log:
Preemptively disable unsigned integer sanitization in 32 and 64 bit versions of
__murmur2_or_cityhash. This lets people use the unsigned integer overflow
checker
Author: marshall
Date: Mon Jan 11 18:38:04 2016
New Revision: 257422
URL: http://llvm.org/viewvc/llvm-project?rev=257422&view=rev
Log:
Put the definition of _LIBCPP_DISABLE_UBSAN_UNSIGNED_INTEGER_CHECK in the right
place.
Modified:
libcxx/trunk/include/__config
Modified: libcxx/trunk/includ
Author: marshall
Date: Tue Jan 12 08:51:04 2016
New Revision: 257474
URL: http://llvm.org/viewvc/llvm-project?rev=257474&view=rev
Log:
Add a bunch of missing includes in the test suite to make it more portable.
Fixes bugs #26120 and #26121. Thanks to Jonathan Wakely for the reports and the
patch
mclow.lists added a comment.
Ping? I'd like to land this before the branch for release tomorrow.
http://reviews.llvm.org/D15862
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: marshall
Date: Tue Jan 12 13:15:10 2016
New Revision: 257506
URL: http://llvm.org/viewvc/llvm-project?rev=257506&view=rev
Log:
One more missing std:: qualification from Jonathan
Modified:
libcxx/trunk/test/std/utilities/function.objects/unord.hash/integral.pass.cpp
Modified:
libcxx
mclow.lists added a comment.
I think the best way to handle Richard's question is to specialize
`__libcpp_string_gets_noexcept_iterator` to always return true when exceptions
are turned off.
http://reviews.llvm.org/D15862
___
cfe-commits mailing l
mclow.lists updated this revision to Diff 44659.
mclow.lists added a comment.
Made all iterators "noexcept" when building with exceptions turned off.
http://reviews.llvm.org/D15862
Files:
include/algorithm
include/iterator
include/string
test/libcxx/iterators/trivial_iterators.pass.cpp
mclow.lists added inline comments.
Comment at: include/iterator:442
@@ +441,3 @@
+struct __is_exactly_input_iterator
+: public integral_constant::iterator_category, input_iterator_tag>::value> {};
+
Sigh. Yes, `boost::input_output_iterator_tag` (and probably o
mclow.lists updated this revision to Diff 44703.
mclow.lists added a comment.
Last change, I hope. I added some more tests to make sure that string was
correctly identifying throwing vs. non-throwing iterators, and I discovered
that I had an `#ifdef` backwards. Fixing that revealed a bug in
`__
mclow.lists marked 3 inline comments as done.
mclow.lists added a comment.
http://reviews.llvm.org/D15862
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mclow.lists added inline comments.
Comment at: include/iterator:1418
@@ +1417,3 @@
+template
+struct __libcpp_is_trivial_iterator >
+ : public
_LIBCPP_BOOL_CONSTANT(__libcpp_is_trivial_iterator<_Iter>::value) {};
EricWF wrote:
> Should this trait handle `c
Author: marshall
Date: Wed Jan 13 15:54:34 2016
New Revision: 257682
URL: http://llvm.org/viewvc/llvm-project?rev=257682&view=rev
Log:
Fix PR#25973 : 'basic_string::assign(InputIt, InputIt) doesn't provide the
strong exception safety guarantee'. This turned out to be a pervasive problem
in , whi
Author: marshall
Date: Wed Jan 13 16:52:36 2016
New Revision: 257696
URL: http://llvm.org/viewvc/llvm-project?rev=257696&view=rev
Log:
Fix test for C++03 - lacking noexcept
Modified:
libcxx/trunk/test/libcxx/strings/iterators.exceptions.pass.cpp
Modified: libcxx/trunk/test/libcxx/strings/ite
Author: marshall
Date: Wed Jan 13 17:05:15 2016
New Revision: 257702
URL: http://llvm.org/viewvc/llvm-project?rev=257702&view=rev
Log:
Better comments in test. NFC
Modified:
libcxx/trunk/test/libcxx/strings/iterators.noexcept.pass.cpp
Modified: libcxx/trunk/test/libcxx/strings/iterators.noex
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
This looks good to me. A quick search for `\\` in regex didn't find any other
obvious instances of this anti-pattern. For the record, the bug is
https://llvm.org/bugs/show_bug.cgi?
Author: marshall
Date: Mon Jan 18 18:50:37 2016
New Revision: 258107
URL: http://llvm.org/viewvc/llvm-project?rev=258107&view=rev
Log:
Fix PR#26175. Thanks to Josh Petrie for the report and the patch. Reviewed as
http://reviews.llvm.org/D16262
Modified:
libcxx/trunk/include/regex
libcxx/
On Tue, Jan 19, 2016 at 3:48 PM, Eric Fiselier wrote:
> Hi Hans,
>
> I fixed the problem that caused Nico to revert this. I would like to
> re-land this in 3.8.
> This depends on libc++ commit r258217 also landing in 3.8.
>
> @Marshall can you OK this?
>
>
This is fine with me. (both r258217 and
On Tue, Jan 19, 2016 at 3:34 PM, Eric Fiselier wrote:
> Hi Hans,
>
> I would like to merge the following commits into 3.8.
>
> 1. r258196 (libc++)
> 2. r258198 (libc++)
> 3. r258201 (libc++abi)
>
> These commits simply add missing license headers.
>
> @Marshall Can you please OK this?
>
>
I am fi
On Wed, Jan 13, 2016 at 9:42 AM, Hans Wennborg wrote:
> Marshall, Eric,
>
> Please check that this was OK, as I don't usually commit to libc++.
>
> It's good.
-- Marshall
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi
Author: marshall
Date: Tue Jan 19 21:19:15 2016
New Revision: 258279
URL: http://llvm.org/viewvc/llvm-project?rev=258279&view=rev
Log:
Fix up the tests I added for string exceptions to be skipped when exceptions
are disabled
Modified:
libcxx/trunk/test/std/strings/basic.string/string.modifi
Author: marshall
Date: Tue Jan 19 21:37:46 2016
New Revision: 258281
URL: http://llvm.org/viewvc/llvm-project?rev=258281&view=rev
Log:
Got the test backwards in r258279. Fixed that and de-tabbed
Modified:
libcxx/trunk/test/support/test_iterators.h
Modified: libcxx/trunk/test/support/test_ite
Author: marshall
Date: Tue Jan 19 23:41:24 2016
New Revision: 258291
URL: http://llvm.org/viewvc/llvm-project?rev=258291&view=rev
Log:
More string fixes for noexcept cases. Apparently I didn't get them all in
r258281.
Modified:
libcxx/trunk/test/libcxx/strings/iterators.exceptions.pass.cpp
On Thu, Jan 21, 2016 at 9:05 AM, Hans Wennborg wrote:
> Hi Marshall,
>
> Is this OK for 3.8?
>
I have no idea; this is the first I've seen of it.
Apparently it was posted on phab, no one approved it, and it was committed.
In an hour.
-- Marshall
>
> Daniel, I assume we want reviews.llvm.or
On Thu, Jan 21, 2016 at 9:27 AM, Daniel Sanders
wrote:
> Hi,
>
>
>
> It was LGTM'd by bcraig.
>
Specifically, he said "LGTM, but that doesn't mean much."
-- Marshall
>
>
> *From:* Marshall Clow [mailto:mclow.li...@gmail.com]
> *Sent:*
Author: marshall
Date: Thu Jan 21 12:22:43 2016
New Revision: 258418
URL: http://llvm.org/viewvc/llvm-project?rev=258418&view=rev
Log:
Implement LWG#2101 'Some transformation types can produce impossible types'
Introduced a new (internal) type trait '__is_referenceable' with tests. Use
that tra
Author: marshall
Date: Fri Jan 22 19:02:29 2016
New Revision: 258593
URL: http://llvm.org/viewvc/llvm-project?rev=258593&view=rev
Log:
Fix test to pass in C++03
Modified:
libcxx/trunk/test/libcxx/utilities/meta/is_referenceable.pass.cpp
Modified: libcxx/trunk/test/libcxx/utilities/meta/is_re
mclow.lists added a comment.
I don't have any comments on this code at this time, but I want to caution
people that this part of the standard library is **extremely** carefully
specified, and meeting all the requirements is a fiddly bit of work.
For an example of this, look at LWG issue #2464,
mclow.lists closed this revision.
mclow.lists added a comment.
This was landed as r257682
http://reviews.llvm.org/D15862
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mclow.lists added a comment.
Not crashing is good; but silently returning a "wrong" answer rubs me the wrong
way. I'll do some research and get back to you on this, but maybe throwing an
exception is a better response.
The code looks fine, though; I'm just not sure it's the right thing to do.
mclow.lists added inline comments.
Comment at: include/regex:5390
@@ -5389,3 +5389,3 @@
size_t __i = *__fmt_first - '0';
-__out = _VSTD::copy(__matches_[__i].first,
- __matches_[__i].second, __out);
+
mclow.lists added a comment.
This looks good to me.
Comment at: include/forward_list:369
@@ +368,3 @@
+}
+__node_pointer __get_node_unchecked() const {
+return static_cast<__node_pointer>(
I would think about calling this `__get_node_dereferencab
Author: marshall
Date: Mon Jan 25 11:29:55 2016
New Revision: 258697
URL: http://llvm.org/viewvc/llvm-project?rev=258697&view=rev
Log:
Implement LWG#2385; remove the allocator-aware std::function::assign call. It
was useless, and didn't actually *do anything* with the allocator. Now it's
gone.
mclow.lists created this revision.
mclow.lists added reviewers: EricWF, howard.hinnant.
mclow.lists added a subscriber: cfe-commits.
This is part of the Library Fundamentals 2 TS
http://reviews.llvm.org/D16605
Files:
include/experimental/iterator
test/std/experimental/iterator/nothing_to_do.
mclow.lists added inline comments.
Comment at: include/__config:847
@@ +846,3 @@
+}
+#define _LIBCPP_THROW(E, MSG) __libcxx_noexceptions_report(MSG)
+#else // !_LIBCPP_NO_EXCEPTIONS
I don't care for having to specify something twice. (E, MSG). Maybe
"stringify
mclow.lists added inline comments.
Comment at: include/experimental/iterator:62
@@ +61,3 @@
+
+_LIBCPP_BEGIN_NAMESPACE_LFTS
+
EricWF wrote:
> Wrong namespace. This gives `std::experimental::fundamentals_v2`. This brings
> up the bigger question of how we want to
mclow.lists updated this revision to Diff 46203.
mclow.lists added a comment.
Addressed Eric's comments. (at least some of them)
http://reviews.llvm.org/D16605
Files:
test/std/experimental/iterator/nothing_to_do.pass.cpp
test/std/experimental/iterator/ostream.joiner/ostream.joiner.cons/ost
mclow.lists marked 4 inline comments as done.
mclow.lists added a comment.
http://reviews.llvm.org/D16605
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mclow.lists updated this revision to Diff 46210.
mclow.lists added a comment.
Add the tests that Eric suggested. Had to toss in a `decay`.
http://reviews.llvm.org/D16605
Files:
test/std/experimental/iterator/nothing_to_do.pass.cpp
test/std/experimental/iterator/ostream.joiner/ostream.joine
Author: marshall
Date: Wed Jan 27 22:15:35 2016
New Revision: 259015
URL: http://llvm.org/viewvc/llvm-project?rev=259015&view=rev
Log:
Left a file out of r259014
Added:
libcxx/trunk/include/experimental/iterator
Added: libcxx/trunk/include/experimental/iterator
URL:
http://llvm.org/viewvc/l
Author: marshall
Date: Wed Jan 27 22:14:56 2016
New Revision: 259014
URL: http://llvm.org/viewvc/llvm-project?rev=259014&view=rev
Log:
implement ostream_joiner. Reviewed as http://reviews.llvm.org/D16605
Added:
libcxx/trunk/test/std/experimental/iterator/
libcxx/trunk/test/std/experimenta
mclow.lists closed this revision.
mclow.lists added a comment.
Landed as r259014 and r259015.
http://reviews.llvm.org/D16605
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
This looks fine to me.
http://reviews.llvm.org/D16634
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi
mclow.lists added a comment.
Nice catch. The fix in `` is exactly right, but I think the tests
need more work.
Comment at:
test/std/algorithms/alg.modifying.operations/alg.random.shuffle/random_shuffle.pass.cpp:35
@@ -30,1 +34,3 @@
}
+
+template
This is not
Author: marshall
Date: Mon Nov 16 09:05:09 2015
New Revision: 253212
URL: http://llvm.org/viewvc/llvm-project?rev=253212&view=rev
Log:
Mark P0013 as 'in progress'
Modified:
libcxx/trunk/www/cxx1z_status.html
Modified: libcxx/trunk/www/cxx1z_status.html
URL:
http://llvm.org/viewvc/llvm-proje
Author: marshall
Date: Mon Nov 16 09:54:13 2015
New Revision: 253215
URL: http://llvm.org/viewvc/llvm-project?rev=253215&view=rev
Log:
Implement P0013R1: Logical Operator Type Traits. Make a hidden implementation
(__and_, __or_, and __not_) so that we can use them elsewhere in non-C++17 code
- f
Author: marshall
Date: Mon Nov 16 10:42:16 2015
New Revision: 253223
URL: http://llvm.org/viewvc/llvm-project?rev=253223&view=rev
Log:
LWG#2156 loosened the requirements on unordered containers 'rehash' calls. Add
tests to make sure we meet these requirements. Since we met the stricter ones,
no
Author: marshall
Date: Mon Nov 16 16:18:36 2015
New Revision: 253257
URL: http://llvm.org/viewvc/llvm-project?rev=253257&view=rev
Log:
More tests for LWG#2156
Modified:
libcxx/trunk/test/std/containers/unord/unord.map/reserve.pass.cpp
libcxx/trunk/test/std/containers/unord/unord.multimap/
Author: marshall
Date: Mon Nov 16 17:40:27 2015
New Revision: 253271
URL: http://llvm.org/viewvc/llvm-project?rev=253271&view=rev
Log:
Fix compile error in test. Can't use `operator[]` for multimap.
Modified:
libcxx/trunk/test/std/containers/unord/unord.multimap/reserve.pass.cpp
Modified: l
Author: marshall
Date: Mon Nov 16 18:08:08 2015
New Revision: 253274
URL: http://llvm.org/viewvc/llvm-project?rev=253274&view=rev
Log:
Implement P0007: Constant View: A proposal for a std::as_const helper function
template.
Added:
libcxx/trunk/test/std/utilities/utility/as_const/
libcxx/
Author: marshall
Date: Tue Nov 17 15:04:24 2015
New Revision: 253376
URL: http://llvm.org/viewvc/llvm-project?rev=253376&view=rev
Log:
Add tests for the extended integer types - as required by LWG#2119
Modified:
libcxx/trunk/test/std/utilities/function.objects/unord.hash/integral.pass.cpp
M
Author: marshall
Date: Thu Nov 19 13:41:04 2015
New Revision: 253592
URL: http://llvm.org/viewvc/llvm-project?rev=253592&view=rev
Log:
Fix some mistakes in the synopsis. No functional change. Thanks to
K-ballo for the patch
Modified:
libcxx/trunk/include/array
Modified: libcxx/trunk/includ
Author: marshall
Date: Thu Nov 19 13:45:29 2015
New Revision: 253593
URL: http://llvm.org/viewvc/llvm-project?rev=253593&view=rev
Log:
Fix some mistakes in the and synopses. No functional change.
Thannks to K-ballo for the patch
Modified:
libcxx/trunk/include/tuple
libcxx/trunk/include
mclow.lists added inline comments.
Comment at:
test/std/algorithms/alg.modifying.operations/alg.random.shuffle/random_shuffle.pass.cpp:35
@@ -30,1 +34,3 @@
}
+
+template
gribozavr wrote:
> gribozavr wrote:
> > mclow.lists wrote:
> > > This is not how I would re
Author: marshall
Date: Tue Nov 24 16:10:51 2015
New Revision: 254030
URL: http://llvm.org/viewvc/llvm-project?rev=254030&view=rev
Log:
Remove undefined behavior from tests; specifically, ensure that the value type
of the allocators match the value type of the containers
Modified:
libcxx/tru
Author: marshall
Date: Tue Nov 24 19:06:36 2015
New Revision: 254050
URL: http://llvm.org/viewvc/llvm-project?rev=254050&view=rev
Log:
Silence a -Wmissing-braces warning in the tests; mbstate_t is defined
differently on different C libraries.
Modified:
libcxx/trunk/test/std/depr/depr.c.heade
Author: marshall
Date: Wed Nov 25 19:24:04 2015
New Revision: 254119
URL: http://llvm.org/viewvc/llvm-project?rev=254119&view=rev
Log:
Add static_assert to set/multiset/map/multimap/forward_list/deque that the
allocator's value_type match the container's value_type.
vector/unordered/list/string
Author: marshall
Date: Sun Nov 29 22:30:02 2015
New Revision: 254283
URL: http://llvm.org/viewvc/llvm-project?rev=254283&view=rev
Log:
Implement more of P0006; Type Traits Variable Templates.
Modified:
libcxx/trunk/include/type_traits
libcxx/trunk/test/std/utilities/meta/meta.rel/is_base_
Author: marshall
Date: Sun Nov 29 23:03:35 2015
New Revision: 254284
URL: http://llvm.org/viewvc/llvm-project?rev=254284&view=rev
Log:
Fix bad macros in tests
Modified:
libcxx/trunk/test/std/utilities/meta/meta.rel/is_base_of.pass.cpp
libcxx/trunk/test/std/utilities/meta/meta.rel/is_conve
Author: marshall
Date: Sun Nov 29 23:04:22 2015
New Revision: 254285
URL: http://llvm.org/viewvc/llvm-project?rev=254285&view=rev
Log:
Implement more of P0006; Type Traits Variable Templates.
Modified:
libcxx/trunk/test/std/utilities/ratio/ratio.comparison/ratio_equal.pass.cpp
libcxx/tr
Author: marshall
Date: Sun Nov 29 23:04:48 2015
New Revision: 254286
URL: http://llvm.org/viewvc/llvm-project?rev=254286&view=rev
Log:
Missing file from last commit
Modified:
libcxx/trunk/include/ratio
Modified: libcxx/trunk/include/ratio
URL:
http://llvm.org/viewvc/llvm-project/libcxx/trun
Author: marshall
Date: Sun Nov 29 23:10:10 2015
New Revision: 254287
URL: http://llvm.org/viewvc/llvm-project?rev=254287&view=rev
Log:
Fix bad macros
Modified:
libcxx/trunk/test/std/utilities/meta/meta.unary.prop.query/alignment_of.pass.cpp
Modified:
libcxx/trunk/test/std/utilities/meta/me
Author: marshall
Date: Sun Nov 29 23:15:10 2015
New Revision: 254288
URL: http://llvm.org/viewvc/llvm-project?rev=254288&view=rev
Log:
Temporarily disable new tests while I figure out what's going on
Modified:
libcxx/trunk/test/std/utilities/meta/meta.unary.prop.query/alignment_of.pass.cpp
Author: marshall
Date: Sun Nov 29 23:20:00 2015
New Revision: 254289
URL: http://llvm.org/viewvc/llvm-project?rev=254289&view=rev
Log:
Fix bugs in alignment_of_v, etc. Re-enable the newly added tests
Modified:
libcxx/trunk/include/type_traits
libcxx/trunk/test/std/utilities/meta/meta.una
Author: marshall
Date: Sun Nov 29 23:39:30 2015
New Revision: 254290
URL: http://llvm.org/viewvc/llvm-project?rev=254290&view=rev
Log:
Last bit of P0006; mark it as complete
Modified:
libcxx/trunk/include/chrono
libcxx/trunk/test/std/utilities/time/time.traits/time.traits.is_fp/treat_as_
mclow.lists added a comment.
In general, this looks fine. There are a few nits.
1. There needs to be a way to disable these annotations.
The usual way in libc++ is to check to see if `_LIBCPP_THREAD_ANNOTATION` is
already defined, and if so, do not define it. We usually state things in the
neg
mclow.lists added a comment.
> We usually state things in the negative, so the controlling macro should be
> _LIBCPP_HAS_NO_THREAD_ANNOTATION
Or actually, `_LIBCPP_HAS_NO_THREAD_ANNOTATIONS`
http://reviews.llvm.org/D14731
___
cfe-commits mailin
mclow.lists added a comment.
Where are the tests?
http://reviews.llvm.org/D14731
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mclow.lists created this revision.
mclow.lists added reviewers: klimek, aaron.ballman, chandlerc.
mclow.lists added a subscriber: cfe-commits.
Motivation: LLVM has many overloads of `std::swap` for its own types. This is
technically forbidden by the standard, but is pervasive in the LLVM code bas
mclow.lists added a comment.
Also, even though the `--fix` done by the tool is (almost) correct, the display
of the fixit hint by clang is really confusing, even wrong
http://reviews.llvm.org/D15121
___
cfe-commits mailing list
cfe-commits@lists.ll
mclow.lists updated the summary for this revision.
mclow.lists updated this revision to Diff 41559.
mclow.lists added a comment.
Suggestions from @AaronBallman; now does the substitution correctly, and passes
the tests.
Note: The diagnostics that clang emits are still whacko.
http://reviews.ll
mclow.lists updated the summary for this revision.
mclow.lists updated this revision to Diff 41626.
mclow.lists marked 7 inline comments as done.
mclow.lists added a comment.
Fixed all the simple things that people commented on.
http://reviews.llvm.org/D15121
Files:
clang-tidy/misc/CMakeLists
mclow.lists added inline comments.
Comment at: clang-tidy/misc/StdSwapCheck.cpp:24
@@ +23,3 @@
+/// source location will be invalid.
+static SourceLocation findSemiAfterLocation(SourceLocation loc,
+ASTContext &Ctx,
aaro
mclow.lists added inline comments.
Comment at: clang-tidy/misc/StdSwapCheck.cpp:68
@@ +67,3 @@
+
callee(expr(ignoringParenImpCasts(declRefExpr(has(nestedNameSpecifierLoc().bind("namespace"))).bind("swap"),
+this);
+}
I believe that if you do that, you
mclow.lists updated this revision to Diff 41662.
mclow.lists added a comment.
More tests; incorporated some of the suggestions for making sure we don't step
on other people's namespaces named `std`.
http://reviews.llvm.org/D15121
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/MiscTi
mclow.lists updated this revision to Diff 41667.
mclow.lists added a comment.
Richard clued me in to the cool method `isStdNamespace()`, which made the code
simpler.
http://reviews.llvm.org/D15121
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/MiscTidyModule.cpp
clang-tidy/misc/St
mclow.lists marked 5 inline comments as done.
mclow.lists added a comment.
http://reviews.llvm.org/D15121
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mclow.lists added a comment.
I ran this on LLVM + clang, and it changed calls in 61 files. The changed LLVM
codebase compiled successfully, and passed all the tests.
Re: @dblaikie's comment, I'd rather call such a beast `llvm::swap`, and it
would have to go into a header file that everyone alr
Author: marshall
Date: Mon Dec 7 18:08:23 2015
New Revision: 254971
URL: http://llvm.org/viewvc/llvm-project?rev=254971&view=rev
Log:
Cleaned up the intro for the TS status page; really need much more info here
Modified:
libcxx/trunk/www/ts1z_status.html
Modified: libcxx/trunk/www/ts1z_stat
>
> On Tue, Dec 8, 2015 at 3:52 PM, Richard Smith
> wrote:
>
>> Ping.
>>
>
Sorry about that.
Completely missed this in my email flood.
This approach looks ok to me, but I wonder if it would be better to get
Apple to fix their iOS C library instead.
Are there other broken C libraries that we are
Author: marshall
Date: Mon Dec 14 11:34:03 2015
New Revision: 255513
URL: http://llvm.org/viewvc/llvm-project?rev=255513&view=rev
Log:
Add add_lvalue_ref tests for a few function types, with a note why not more
Modified:
libcxx/trunk/test/std/utilities/meta/meta.trans/meta.trans.ref/add_lval
801 - 900 of 1350 matches
Mail list logo
