[PATCH] D71966: [Wdocumentation][RFC] Improve identifier's of \param

Mordante marked 14 inline comments as done. Mordante added a comment. Thanks for the review! I only answered to the larger issues to get a better feeling of the direction the patch should go. Once that's clear I'll make a new patch and also address the smaller issues. Commen

[PATCH] D68912: Adds -Wrange-loop-analysis to -Wall

Mordante added a comment. Thanks for your report. I think it's similar to https://bugs.llvm.org/show_bug.cgi?id=44556. I'll look for a fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68912/new/ https://reviews.llvm.org/D68912 ___

[PATCH] D73007: [Sema] Avoid Wrange-loop-analysis false positives

Mordante created this revision. Mordante added reviewers: rsmith, rtrieu, aaron.ballman, xbolva00. Mordante added a project: clang. When Wrange-loop-analysis issues a diagnostic on a dependent type in a template the diagnostic may not be valid for all instantiations. Therefore the diagnostic is

[PATCH] D68912: Adds -Wrange-loop-analysis to -Wall

Mordante added a comment. I proposed D73007 as fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68912/new/ https://reviews.llvm.org/D68912 ___ cfe-commits mailing li

[PATCH] D73007: [Sema] Avoid Wrange-loop-analysis false positives

Mordante added a comment. In D73007#1829709 , @xbolva00 wrote: > Yes, but minimal fix is better for release branch, so @hans should merge it. > > Handling your case probably needs more work and patches.. Agreed. Repository: rG LLVM Github Monorepo C

[PATCH] D73007: [Sema] Avoid Wrange-loop-analysis false positives

Mordante added a comment. In D73007#1829597 , @aaron.ballman wrote: > LGTM! Do you think this should also be pushed onto the release branch? Thanks for the review. Yes the bug has been marked as a release blocker. Repository: rG LLVM Github Monorepo

[PATCH] D73007: [Sema] Avoid Wrange-loop-analysis false positives

Mordante marked 2 inline comments as done. Mordante added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:2703-2704 // suggest the const reference type that would do so. // For instance, given "for (const &Foo : Range)", suggest // "for (const Foo : Range)" to denote

[PATCH] D73007: [Sema] Avoid Wrange-loop-analysis false positives

This revision was automatically updated to reflect the committed changes. Mordante marked an inline comment as done. Closed by commit rG41fcd17250fa: [Sema] Avoid Wrange-loop-analysis false positives (authored by Mordante). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D73098: [clang-tidy] readability-identifier-naming disregards parameters restrictions on main like functions

Mordante added a comment. Would it make sense to also allow wmain with wchar_t? https://docs.microsoft.com/en-us/cpp/cpp/main-function-command-line-args?view=vs-2019 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73098/new/ https://reviews.llvm.org

[PATCH] D73007: [Sema] Avoid Wrange-loop-analysis false positives

Mordante added a comment. @aaronpuchert, @aaron.ballman I agree with the proposal, I'll work on a patch. @hans Once the patch is accepted I'll send you a pull request and an update for the release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D71966: [Wdocumentation][RFC] Improve identifier's of \param

Mordante marked 2 inline comments as done. Mordante added a comment. So if I understand correctly: - `getParamNameAsWritten` will become `getArgText` - The `getParamName` will do the translation from the name in the documentation to the name in the current function declaration. If the parameter

[PATCH] D73434: [Sema] Remove a -Wrange warning from -Wall

Mordante created this revision. Mordante added reviewers: aaron.ballman, aaronpuchert, rtrieu, xbolva00. Mordante added a project: clang. During the review of D73007 Aaron Puchert mentioned `warn_for_range_variable_always_copy` shouldn't be part of `-Wall` since

[PATCH] D73007: [Sema] Avoid Wrange-loop-analysis false positives

Mordante added a comment. Created D73434 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73007/new/ https://reviews.llvm.org/D73007 ___ cfe-commits mailing list cfe-com

[PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

Mordante updated this revision to Diff 500547. Mordante added a comment. Rebased to test CI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144509/new/ https://reviews.llvm.org/D144509 Files: bolt/runtime/CMakeLists.txt clang/CMakeLists.txt c

[PATCH] D144894: [clang] Documents clang-scan-deps requirements.

Mordante created this revision. Mordante added a reviewer: ChuanqiXu. Herald added a project: All. Mordante requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This was discussed in https://llvm.org/PR61006. Repository: rG LLVM Github Monor

[PATCH] D144894: [clang] Documents clang-scan-deps requirements.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8dbeb41f8ebd: [clang] Documents clang-scan-deps requirements. (authored by Mordante). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG44c6b905f852: [CMake] Bumps minimum version to 3.20.0. (authored by Mordante). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D146240: [libc++][format] Use granularized charconv.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG57e20cab5a1d: [libc++][format] Use granularized charconv. (authored by Mordante). Herald added projects: clang, clang-format. Herald added a subscrib

[PATCH] D144328: [libc++][format][chrono] Addresses LWG3842.

This revision was automatically updated to reflect the committed changes. Closed by commit rGcf07b882e2c1: [libc++][format][chrono] Addresses LWG3842. (authored by Mordante). Herald added projects: clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, Hazardy

[PATCH] D144331: [libc++][format] Implements formatter thread::id.

Mordante marked 4 inline comments as done. Mordante added a comment. Herald added projects: clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay. Thanks for the review! Comment at: libcxx/test/

[PATCH] D144331: [libc++][format] Implements formatter thread::id.

Mordante updated this revision to Diff 511705. Mordante marked 2 inline comments as done. Mordante added a comment. Rebased, addresses review comment, and get a CI run. Herald added a comment. NOTE: Clang-Format Team Automated Review Comment It looks like your clang-format review does not cont

[PATCH] D144331: [libc++][format] Implements formatter thread::id.

Mordante updated this revision to Diff 511709. Mordante added a comment. CI fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144331/new/ https://reviews.llvm.org/D144331 Files: libcxx/docs/FeatureTestMacroTable.rst libcxx/docs/ReleaseNotes

[PATCH] D144331: [libc++][format] Implements formatter thread::id.

Mordante updated this revision to Diff 511715. Mordante added a comment. CI fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144331/new/ https://reviews.llvm.org/D144331 Files: libcxx/docs/FeatureTestMacroTable.rst libcxx/docs/ReleaseNotes.

[PATCH] D144331: [libc++][format] Implements formatter thread::id.

Mordante updated this revision to Diff 511865. Mordante added a comment. Herald added a subscriber: krytarowski. CI fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144331/new/ https://reviews.llvm.org/D144331 Files: libcxx/docs/FeatureTestM

[PATCH] D144331: [libc++][format] Implements formatter thread::id.

Mordante updated this revision to Diff 511875. Mordante added a comment. CI fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144331/new/ https://reviews.llvm.org/D144331 Files: libcxx/docs/FeatureTestMacroTable.rst libcxx/docs/ReleaseNotes.

[PATCH] D146986: Downgrade reserved module identifier error into a warning

Mordante added a comment. Sorry I was not available earlier. Thanks for working on this. LGTM but one remark. Comment at: clang/docs/ReleaseNotes.rst:92 + `_ and allows easier + building of precompiled modules. This diagnost

[PATCH] D147175: [clang] Add __is_trivially_equality_comparable

Mordante added a comment. I mainly glossed over the patch and didn't do a real review. Comment at: clang/lib/AST/ASTContext.cpp:2672 +const RecordDecl *RD, +bool CheckIfTriviallyCOpy

[PATCH] D144331: [libc++][format] Implements formatter thread::id.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG88622aabf107: [libc++][format] Implements formatter thread::id. (authored by Mordante). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D147175: [clang] Add __is_trivially_equality_comparable

Mordante added inline comments. Comment at: libcxx/include/__type_traits/is_equality_comparable.h:46 template -struct __is_trivially_equality_comparable +struct __libcpp_is_trivially_equality_comparable : integral_constant Mordante wrote: > > This does not magically use th

[PATCH] D144331: [libc++][format] Implements formatter thread::id.

Mordante marked an inline comment as done. Mordante added inline comments. Comment at: libcxx/test/std/thread/thread.threads/thread.thread.class/thread.thread.id/parse.pass.cpp:49 + std::same_as auto it = formatter.parse(parse_ctx); + assert(it == fmt.end() - (!fmt.empty() &&

[PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

Mordante added a comment. In D144509#4356160 , @hans wrote: > In D144509#4350052 , @Mordante > wrote: > >> In D144509#4349921 , @thakis wrote: >> >>> Reverted this and fo

[PATCH] D151344: Reland "[CMake] Bumps minimum version to 3.20.0.

Mordante created this revision. Mordante added reviewers: glandium, hans, thakis. Herald added subscribers: libc-commits, bviyer, ekilmer, Moerafaat, zero9178, Enna1, bzcheeseman, ayermolo, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1,

[PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

Mordante added a comment. I've created D151344 @glandium @hans @thakis I really would appreciate when you can test the patch locally to avoid another revert round. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14

[PATCH] D151344: Reland "[CMake] Bumps minimum version to 3.20.0.

Mordante accepted this revision. Mordante marked 3 inline comments as done. Mordante added a comment. In D151344#4368926 , @MaskRay wrote: > Thank you for making another try for the treewide change (which is admittedly > very painful and not many people

[PATCH] D151344: Reland "[CMake] Bumps minimum version to 3.20.0.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Mordante marked an inline comment as done. Closed by commit rGcbaa3597aaf6: Reland "[CMake] Bumps minimum version to 3.20.0. (authored by Mor

[PATCH] D144497: [clang][doc] Removes obsolete comment.

Mordante created this revision. Mordante added a reviewer: ChuanqiXu. Herald added a project: All. Mordante requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. After reading about the documentation improvements on LLVM weekly this part seems ob

[PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

Mordante created this revision. Mordante added reviewers: bollu, tstellar, mehdi_amini, MaskRay, ChuanqiXu, to268, kparzysz, thieta, tschuett, mgorny, stellaraccident, mizvekov, ldionne, jdoerfert, phosek. Herald added subscribers: libc-commits, libcxx-commits, Moerafaat, zero9178, Enna1, bzchee

[PATCH] D144497: [clang][doc] Removes obsolete comment.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa7b6978285c1: [clang][doc] Removes obsolete comment. (authored by Mordante). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144497/new/ https://reviews.llvm.

[PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

Mordante updated this revision to Diff 499569. Mordante added a comment. Herald added a subscriber: mstorsjo. Try to fix AIX CI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144509/new/ https://reviews.llvm.org/D144509 Files: bolt/runtime/CMake

[PATCH] D146090: [Clang] Updating handling of defaulted comparison operators to reflect changes from P2448R2

Mordante added a comment. In D146090#4319685 , @shafik wrote: > Landed fix 7887af027ee5eff27bbc953074726ab8d9d9f592 > > > There was also 058f04ea7dcbafbeed271fa75ee65e41409b4479 >

[PATCH] D150063: [clang] Restores some -std=c++2b tests.

Mordante created this revision. Mordante added a reviewer: aaron.ballman. Herald added a project: All. Mordante updated this revision to Diff 520185. Mordante added a comment. Mordante edited the summary of this revision. Mordante published this revision for review. Herald added a project: clang. H

[PATCH] D150063: [clang] Restores some -std=c++2b tests.

This revision was automatically updated to reflect the committed changes. Closed by commit rGfd556368a1a8: [clang] Restores some -std=c++2b tests. (authored by Mordante). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150063/new/ https://reviews.llvm

[PATCH] D150450: Add C++26 compile flags.

Mordante added a comment. In D150450#4337952 , @erichkeane wrote: > In D150450#4337858 , @cor3ntin > wrote: > >> Similar PR here https://reviews.llvm.org/D149875 > > Ah! I'd not noticed that one (or maybe someon

[PATCH] D150450: Add C++26 compile flags.

Mordante accepted this revision. Mordante added a comment. This revision is now accepted and ready to land. In D150450#4338065 , @erichkeane wrote: > In D150450#4338034 , @Mordante > wrote: > >> In D150450#43379

[PATCH] D150450: Add C++26 compile flags.

Mordante added inline comments. Comment at: clang/docs/CommandGuide/clang.rst:206-210 + Working draft for ISO C++ 2026 + + | ``gnu++2c`` + + Working draft for ISO C++ 2026 with GNU extensions erichkeane wrote: > aaron.ballman wrote: > > We shouldn't call it

[PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

Mordante added a comment. In D144509#4349921 , @thakis wrote: > Reverted this and follow-ups in d763c6e5e2d0a6b34097aa7dabca31e9aff9b0b6 > for now. > > Sorry this is such a pain to lan

[PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

Mordante added a comment. In D144509#4349017 , @dyung wrote: > I'm not really sure where else to post this, but the pre-merge linux bot > still seems to be running 3.18.4. > > https://buildkite.com/llvm-project/premerge-checks/builds/152678#018828d2-1837

[PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

Mordante added a comment. In D144509#4350148 , @thakis wrote: > https://github.com/llvm/llvm-project/issues/62719 is independent of chromium > and others have reported problems above too, from what I understand. Is that > not accurate? That bug report

[PATCH] D147844: Emit warning when implicit cast from int to bool happens in an conditional operator expression

Mordante accepted this revision. Mordante added a comment. I too am not really convinced by all changes in libc++. On the other hand I don't think the change make the libc++ code looking bad. So I don't feel a reason to reject the libc++ changes. I don't like the commit message, there's only a

[PATCH] D147844: [clang][Sema]Print diagnostic warning about precedence when integer expression is used without parentheses in an conditional operator expression

Mordante added a comment. One suggestion for the commit message either use `[[maybe_unused]]` or `-Wno-unused` that way the unrelated messages aren't shown in the commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147844/new/ https://r

[PATCH] D149553: [clang] Use -std=c++23 instead of -std=c++2b

Mordante added inline comments. Comment at: libcxx/test/tools/clang_tidy_checks/uglify_attributes.cpp:46 - if (lang_opts.CPlusPlus2b) { attributes.emplace_back("assume"); philnik wrote: > You probably want to `#ifdef` this based on Clang 16/17. Yeah I not

[PATCH] D149553: [clang] Use -std=c++23 instead of -std=c++2b

Mordante added a comment. In D149553#4310478 , @aaron.ballman wrote: > Thank you for working on this! The Clang changes are mostly all good, but I > think we should hold off on changing the value of `__cplusplus` for the > moment as it's not set in sto

[PATCH] D149553: [clang] Use -std=c++23 instead of -std=c++2b

Mordante marked 3 inline comments as done. Mordante added a comment. In D149553#4313211 , @aaron.ballman wrote: > In D149553#4312788 , @Mordante > wrote: > >> In D149553#4310478

[PATCH] D153038: [Clang] Fixes a diagnostic typo.

Mordante created this revision. Mordante added a reviewer: ChuanqiXu. Herald added a project: All. Mordante requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Some small style updates as drive-by. Repository: rG LLVM Github Monorepo https

[PATCH] D153038: [Clang] Fixes a diagnostic typo.

This revision was automatically updated to reflect the committed changes. Closed by commit rG501405f1d5f0: [Clang] Fixes a diagnostic typo. (authored by Mordante). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153038/new/ https://reviews.llvm.org/D1

[PATCH] D139266: Headers: tweak inclusion condition for stdatomic.h

Mordante added a comment. Thanks for the patch! Comment at: clang/lib/Headers/stdatomic.h:21 +#if __STDC_HOSTED__ && __has_include_next() \ +&& !(defined(_MSC_VER) && __cplusplus-0 < 202002l) # include_next Is `__cplusplus-0` inten

[PATCH] D139266: Headers: tweak inclusion condition for stdatomic.h

Mordante accepted this revision. Mordante added a comment. LGTM after addressing @aaron.ballman's comments. Comment at: clang/lib/Headers/stdatomic.h:21 +#if __STDC_HOSTED__ && __has_include_next() \ +&& !(defined(_MSC_VER) && __cplusplus-0 < 202002l

[PATCH] D138042: [libc++] Trigger both Clang and libc++ CI when there are changes to both

Mordante added a comment. Sorry I overlooked this review. Based on the CI output it only runs the Clang CI right. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138042/new/ https://reviews.llvm.org/D138042 _

[PATCH] D137724: [CMake] Warn when the version is older than 3.20.0.

Mordante marked an inline comment as done. Mordante added a comment. Thanks for all reviews! In D137724#3974764 , @thieta wrote: > I think this is ready to land @Mordante or is there anything else missing? No but I've been quite busy. I needed some time

[PATCH] D137724: [CMake] Warn when the version is older than 3.20.0.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Mordante marked an inline comment as done. Closed by commit rGd40dc417389e: [CMake] Warn when the version is older than 3.20.0. (authored by Mordante). Changed prior t

[PATCH] D120160: [Clang] Add `-funstable` flag to enable unstable and experimental features

Mordante added a comment. Thanks for implementing this @egorzhdan! Thanks @ldionne for the notification. `-funstable` is an option that controls multiple flags therefore I think it would be good to have a separate flag to opt-in for unstable/incomplete libc++ features. That makes it easier to _

[PATCH] D115685: [NFC] Fix typos in release notes

Mordante accepted this revision. Mordante added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115685/new/ https://reviews.llvm.org/D115685 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D116224: Revert "[amdgpu] Enable selection of `s_cselect_b64`."

Mordante requested changes to this revision. Mordante added a comment. This revision now requires changes to proceed. This revision reverts more than intended. Since it now touches libcxx directory it requires libc++ approval. Please reduce the revert to the intended scope. Repository: rG LLV

[PATCH] D100705: Fixed Typos

Mordante accepted this revision as: Mordante. Mordante added a comment. Thanks for your contribution. Next time, please provide a patch with more context. The instructions can be found at https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface. LGTM, but please wait for

[PATCH] D100705: Fixed Typos

Mordante added a comment. In D100705#2696708 , @xgupta wrote: > Nice work @jnyfah! > > @Mordante Review is already accepted by @curdeius in > https://reviews.llvm.org/D100696. And actually, I see your message after > committing the patch. In general wh

[PATCH] D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

Mordante added a comment. Since @ldionne approved this patch it's good to land. If you don't have commit access, can you provide "Your name" , then somebody can commit the change for you. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107717/new/ https://reviews.llvm.org/D107717 _

<    1   2   3   4   5