[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

Mordante added a comment. In D112921#4535716 , @wangpc wrote: > In D112921#4532378 , @Mordante > wrote: > >> In D112921#4530916 , @wangpc wrote: >> >>> In D112921#4529182

[PATCH] D156247: [Clang] Add a warning on uses of coroutine keywords

Mordante added a comment. In D156247#4538626 , @aaron.ballman wrote: > I would like explicit buy-in from the libc++ folks on the idea of adding > `-fno-coroutines` as they're going to be impacted by Clang supporting such an > option (and they may have

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

Mordante added a comment. I see one libc++ failure, I have not looked into the other failures. Comment at: libcxx/test/libcxx/language.support/support.dynamic/libcpp_deallocate.sh.cpp:29 +// TODO(mordante) fix this test after updating clang in Docker +// UNSUPPORTED: clang-17

[PATCH] D156032: Implement CWG2137 (list-initialization from objects of the same type)

Mordante accepted this revision as: libc++. Mordante added a comment. I only looked at the libc++ changes. The libc++ AIX CI failures are unrelated to your patch. LGTM modulo one nit. Comment at: libcxx/test/std/utilities/utility/pairs/pairs.pair/ctor.pair_U_V_move.pass.cpp:1

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

Mordante accepted this revision. Mordante added a comment. I'm happy with the libc++ changes, please wait a few days for @ldionne to react. In D112921#4584704 , @aaron.ballman wrote: > In D112921#4581641 , @rnk

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

Mordante added a comment. In D112921#4594092 , @wangpc wrote: > - Rebase. > - Update tests, remove clang-17. The removal of the markers in the libc++ tests breaks these test. FYI the tests are using a Clang build of apt.llvm.org and are not using this p

[PATCH] D155064: [clang][SemaCXX] Diagnose tautological uses of consteval if and is_constant_evaluated

Mordante added inline comments. Comment at: libcxx/include/__type_traits/is_constant_evaluated.h:31 + return false; +#endif } Why is this needed? Does this mean the builtin will fail in C++03 mode? Comment at: libcxx/test/std/utilities/meta/

[PATCH] D155064: [clang][SemaCXX] Diagnose tautological uses of consteval if and is_constant_evaluated

Mordante added inline comments. Comment at: libcxx/include/__type_traits/is_constant_evaluated.h:31 + return false; +#endif } hazohelet wrote: > Mordante wrote: > > Why is this needed? Does this mean the builtin will fail in C++03 mode? > `__libcpp_is_constant_

[PATCH] D158523: [clang][doc] Mentions -Wno-reserved-module-identifiers

Mordante created this revision. Mordante added a reviewer: ChuanqiXu. Herald added a project: All. Mordante requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is a nicer way to suppress the diagnostic instead of using the pre-processor wo

[PATCH] D158523: [clang][doc] Mentions -Wno-reserved-module-identifiers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc73de2969162: [clang][doc] Mentions -Wno-reserved-module-identifiers (authored by Mordante). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D156247: [Clang] Add a warning on uses of coroutine keywords

Mordante added a comment. In D156247#4541756 , @ilya-biryukov wrote: > In D156247#4540228 , @Mordante > wrote: > >> 2. My biggest concern is the timing of this patch. The date of the branching >> is know upfron

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

Mordante added a comment. In D112921#4541063 , @wangpc wrote: > - Rebase. > - Unsupport clang-18. I see the libc++ build failed. It seems like timeouts uploading artifacts, so not related to your patch. Can you rebase and give it another run on the CI?

[PATCH] D157324: [clang] Move the Clang CI jobs off of the libc++ builders

Mordante accepted this revision. Mordante added a comment. Nice to see the Clang CI new builder! Thanks for working on this, LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157324/new/ https://reviews.llvm.org/D157324 _

[PATCH] D155078: [ci] Make libc++ and Clang CI scripts independent

Mordante added a comment. Thanks for working on this! I really like the direction. I mainly skimmed the code since the patch as already landed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155078/new/ https://reviews.llvm.org/D155078 ___

[PATCH] D155064: [clang][SemaCXX] Diagnose tautological uses of consteval if and is_constant_evaluated

Mordante added a comment. I only looked at the libc++ part. Comment at: libcxx/test/std/utilities/meta/meta.const.eval/is_constant_evaluated.verify.cpp:27 static_assert(!std::is_constant_evaluated(), ""); - // expected-warning@-1 0-1 {{'std::is_constant_evaluated' will alw

[PATCH] D155064: [clang][SemaCXX] Diagnose tautological uses of consteval if and is_constant_evaluated

Mordante added inline comments. Comment at: libcxx/test/std/utilities/meta/meta.const.eval/is_constant_evaluated.verify.cpp:27 static_assert(!std::is_constant_evaluated(), ""); - // expected-warning@-1 0-1 {{'std::is_constant_evaluated' will always evaluate to 'true' in a m

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

Mordante added inline comments. Comment at: libcxx/test/std/language.support/support.dynamic/new.delete/new.delete.array/sized_delete_array14.pass.cpp:16 +// Sized deallocation was added in macOS 10.12 and aligned OSes. +// XFAIL: use_system_cxx_lib && target={{.+}}-apple-macosx

[PATCH] D133425: Silence -Wctad-maybe-unsupported stemming from system headers

Mordante added a comment. @aaron.ballman We'd like to clean up the patches from the libc++ review queue. Is this patch is still relevant? Especially after landing https://reviews.llvm.org/D133535. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1334

[PATCH] D137337: Replace LLVM_LIBDIR_SUFFIX by CMAKE_INSTALL_LIBDIR

Mordante added a comment. Herald added subscribers: bviyer, jplehr. For libc++ we like to clean up the review queue for the GitHub PR transition. Is there still interest on working on this patch? If so would it be possible to finish it before the Phabricator is changed to read only mode? CHANG

[PATCH] D72231: [Sema] Adds the pointer-to-int-cast diagnostic

Mordante added a comment. In D72231#1882658 , @rjmccall wrote: > Okay. Can we raise this with the kernel folks instead of just assuming > they'll be opposed? An obvious patch to fix a few dozen places where they're > hit by a warning they intentionally

[PATCH] D74860: [Sema] Fix pointer-to-int-cast diagnostic for _Bool

Mordante created this revision. Mordante added reviewers: dblaikie, rjmccall, rsmith, nathanchance, nickdesaulniers. Mordante added a project: clang. The diagnostic added in D72231 also shows a diagnostic when casting to a _Bool. This is unwanted. This patch rem

[PATCH] D74860: [Sema] Fix pointer-to-int-cast diagnostic for _Bool

Mordante updated this revision to Diff 246082. Mordante added a comment. Added some C++ tests for similar c-style casts. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74860/new/ https://reviews.llvm.org/D74860 Files: clang/lib/Sema/SemaCast.cpp clang/test/Sema/MicrosoftExtensions.c

[PATCH] D74860: [Sema] Fix pointer-to-int-cast diagnostic for _Bool

Mordante added a comment. In D74860#1883415 , @rjmccall wrote: > Can we test the same thing in C++? I'll add some tests, but C++ uses a different codepath for c-style casts. In D74860#1883480 , @nickdesaulniers

[PATCH] D74860: [Sema] Fix pointer-to-int-cast diagnostic for _Bool

This revision was automatically updated to reflect the committed changes. Closed by commit rG56eb15a1c710: [Sema] Fix pointer-to-int-cast diagnostic for _Bool (authored by Mordante). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74860/new/ https://r

[PATCH] D72103: [Sema] Avoid using an invalid InsertPos

Mordante added a comment. Friendly ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72103/new/ https://reviews.llvm.org/D72103 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D75613: [Sema] Reword -Wrange-loop-analysis warning messages

Mordante added a comment. Thanks for the patch! I've some minor nits, but other then that it looks fine. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:2427 "selected '%select{begin|end}0' %select{function|template }1%2 with iterator type %3">; def warn_for_r

[PATCH] D68912: Adds -Wrange-loop-analysis to -Wall

Mordante added a comment. I haven't reviewed the list [1] properly so I don't know the number of false positives yet. [1] http://paste.debian.net/806/ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68912/new/ https://reviews.llvm.org/D68912 __

[PATCH] D69481: [Sema] Fixes templated friend member assertion

This revision was automatically updated to reflect the committed changes. Closed by commit rG743461090a20: [Sema] Fixes templated friend member assertion (authored by Mordante). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69481/new/ https://review

[PATCH] D69225: Sema: Fixes a crash with a templated destructor

This revision was automatically updated to reflect the committed changes. Closed by commit rG2b943c46873a: [Sema] Fixes a crash with a templated destructor (authored by Mordante). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69225/new/ https://revi

[PATCH] D68912: Adds -Wrange-loop-analysis to -Wall

Mordante added a comment. Thanks for the review. I also looked at some of the new warnings and I'm preparing patches to fix them. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68912/new/ https://reviews.llvm.org/D68912 ___ cfe-commits mai

[PATCH] D63975: Warn when ScopeDepthOrObjCQuals overflows

This revision was automatically updated to reflect the committed changes. Closed by commit rGb9be5ce8f3e0: [Parser] Warn when ScopeDepthOrObjCQuals overflows (authored by Mordante). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63975/new/ https://re

[PATCH] D68912: Adds -Wrange-loop-analysis to -Wall

Mordante added a comment. In D68912#1737559 , @xbolva00 wrote: > Formally unblocking this Thanks. I'll first want to reduce the number of warnings before committing this patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68912/new/ https://

[PATCH] D70045: [AST] Use an explicit copy in a range-based for

Mordante created this revision. Mordante added reviewers: rsmith, aaron.ballman, xbolva00. Mordante added a project: clang. The AssociationIteratorTy type will be copied in a range-based for loop. Make the copy explicit to avoid the -Wrange-loop-analysis warning. This avoids new warnings due to D

[PATCH] D70046: [OpenMP] Use an explicit copy in a range-based for

Mordante created this revision. Mordante added reviewers: ABataev, aaron.ballman, xbolva00. Mordante added a project: clang. Herald added a subscriber: guansong. Herald added a reviewer: jdoerfert. The `std::pair>` type will be copied in a range-based for loop. Make the copy explicit to avoid the

[PATCH] D70047: [Analyzer] Use a reference in a range-based for

Mordante created this revision. Mordante added reviewers: dcoughlin, aaron.ballman, xbolva00. Mordante added a project: clang. Herald added subscribers: Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Let the checkers use a reference ins

[PATCH] D70046: [OpenMP] Use an explicit copy in a range-based for

Mordante added a comment. `OMPMappableExprListClause::const_component_lists_iterator::operator*()` returns an object and not a reference to an object. -Wrange-loop-analysis warns to make it more visible the object is a copy and not a reference. Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D70046: [OpenMP] Use an explicit copy in a range-based for

This revision was automatically updated to reflect the committed changes. Closed by commit rG51abcebbb6e5: [OpenMP] Use an explicit copy in a range-based for (authored by Mordante). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70046/new/ https://re

[PATCH] D70045: [AST] Use an explicit copy in a range-based for

This revision was automatically updated to reflect the committed changes. Closed by commit rG2149028c49f8: [AST] Use an explicit copy in a range-based for (authored by Mordante). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70045/new/ https://revie

[PATCH] D70047: [Analyzer] Use a reference in a range-based for

Mordante added a comment. @aaron.ballman good catch, I've fixed it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70047/new/ https://reviews.llvm.org/D70047 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D70047: [Analyzer] Use a reference in a range-based for

This revision was automatically updated to reflect the committed changes. Closed by commit rG964842861c8a: [Analyzer] Use a reference in a range-based for (authored by Mordante). Changed prior to commit: https://reviews.llvm.org/D70047?vs=228582&id=228935#toc Repository: rG LLVM Github Monor

[PATCH] D64874: [Sema] Improve handling of function pointer conversions

Mordante added a comment. @rsmith I now have commit access so I can commit the patch. Any suggestions regarding the previous remark? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64874/new/ https://reviews.llvm.org/D64874 ___ cfe-commits m

[PATCH] D68912: Adds -Wrange-loop-analysis to -Wall

Mordante added a comment. In D68912#1757850 , @xbolva00 wrote: > In D68912#1754660 , @xbolva00 wrote: > > > I think you can commit it, you already fixed some warnings. > > > Oh, I hit this (-Werror bots) hard :D Som

[PATCH] D69223: WDocumentation: Implement the \anchor.

Mordante marked 5 inline comments as done. Mordante added a comment. Thanks for the review. I'll address your comments and upload a new version. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69223/new/ https://reviews.llvm.org/D69223 ___

[PATCH] D69223: WDocumentation: Implement the \anchor.

Mordante updated this revision to Diff 231592. Mordante added a comment. Addresses review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69223/new/ https://reviews.llvm.org/D69223 Files: clang/bindings/xml/comment-xml-schema.rng clang/include/clang-c/Documentation.h clan

[PATCH] D70869: [Analyzer] Use a reference in a range-based for

Mordante created this revision. Mordante added reviewers: dcoughlin, aaron.ballman, xbolva00, Szelethus. Mordante added a project: clang. Herald added subscribers: Charusso, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. This avoids unneeded copies when usi

[PATCH] D57660: [Sema] SequenceChecker: Handle references, members and structured bindings.

Mordante added a comment. I like this improvement. However I'm not a reviewer. Comment at: clang/lib/Sema/SemaChecking.cpp:12361 + /// \param RefsSeenPtr is used to avoid reference cycles. When such a cycle + /// is possible we check first if \param RefsSeenPtr is non-null. I

[PATCH] D63276: [AST] Add FunctionDecl::getParametersSourceRange()

Mordante added a comment. I've been looking at a way to get the ellipsis location so I'd like this patch to move forward. @nicolas are you still working on this patch? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63276/new/ https://reviews.llvm.org/D63276 __

[PATCH] D63276: [AST] Add FunctionDecl::getParametersSourceRange()

Mordante added a comment. Thanks for updating the patch! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63276/new/ https://reviews.llvm.org/D63276 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman

[PATCH] D65694: Properly instantiate a decltype in argument's default initializer

Mordante added a comment. Friendly ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65694/new/ https://reviews.llvm.org/D65694 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[PATCH] D69223: WDocumentation: Implement the \anchor.

Mordante marked 6 inline comments as done. Mordante added inline comments. Comment at: clang/lib/Index/CommentToXML.cpp:650 +assert(C->getNumArgs() == 1); +Result << ""; +appendToResultWithXMLEscaping(Arg0); gribozavr2 wrote: > Sholudn't this code be

[PATCH] D69223: WDocumentation: Implement the \anchor.

Mordante updated this revision to Diff 231766. Mordante marked 2 inline comments as done. Mordante added a comment. Addresses review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69223/new/ https://reviews.llvm.org/D69223 Files: clang/bindings/xml/comment-xml-schema.rng c

[PATCH] D69223: WDocumentation: Implement the \anchor.

Mordante marked an inline comment as done. Mordante added a comment. Thanks for the review! I recently acquired commit access so I'll commit it after updating the unit test. Comment at: clang/lib/AST/TextNodeDumper.cpp:493 + case comments::InlineCommandComment::RenderAnchor:

[PATCH] D71139: [Wdocumentation] Use the command marker

Mordante created this revision. Mordante added a reviewer: gribozavr2. Mordante added a project: clang. Use the proper marker for `-Wdocumentation-deprecated-sync` instead of hard-coded the backslash. Discovered while looking at https://bugs.llvm.org/show_bug.cgi?id=43753 Repository: rG LLVM

[PATCH] D71140: [Wdocumentation] Properly place deprecated attribute

Mordante created this revision. Mordante added a reviewer: gribozavr2. Mordante added a project: clang. It is now placed before the function: - allows to replace `__attribute__((deprecated))` with `[[deprecated]]`. - required for trailing returns. Fixes bug: https://bugs.llvm.org/show_bug.cgi?id

[PATCH] D71141: [Wdocumentation] Use C++14 deprecated attribute

Mordante created this revision. Mordante added a reviewer: gribozavr2. Mordante added a project: clang. This replaces the non-standard `__attribute__((deprecated))` with the standard `[[deprecated]]` when compiling in C++14 mode. Discovered while looking at https://bugs.llvm.org/show_bug.cgi?id=

[PATCH] D71142: [Sema] Validate large bitfields

Mordante created this revision. Mordante added reviewers: rsmith, majnemer, aaron.ballman. Mordante added a project: clang. Note: I'm not entirely happy with the text of the diagnostics and I'm open to suggestions. Fixes PR23505: Large bitfield: Assertion `getActiveBits() <= 64 && "Too many bit

[PATCH] D71141: [Wdocumentation] Use C++14 deprecated attribute

Mordante marked an inline comment as done. Mordante added inline comments. Comment at: clang/lib/AST/CommentSema.cpp:693 +StringRef AttributeSpelling = +CPlusPlus14 ? "[[deprecated]]" : "__attribute__((deprecated))"; if (PP) { aaron.ballman wrote

[PATCH] D71141: [Wdocumentation] Use C++14 deprecated attribute

Mordante marked an inline comment as done. Mordante added inline comments. Comment at: clang/lib/AST/CommentSema.cpp:693 +StringRef AttributeSpelling = +CPlusPlus14 ? "[[deprecated]]" : "__attribute__((deprecated))"; if (PP) { aaron.ballman wrote

[PATCH] D71142: [Sema] Validate large bitfields

Mordante marked 3 inline comments as done. Mordante added a comment. I'll have a look whether I can find a sane maximum width for a bit-field. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71142/new/ https://reviews.llvm.org/D71142 _

[PATCH] D71141: [Wdocumentation] Use C++14 deprecated attribute

Mordante marked 3 inline comments as done. Mordante added inline comments. Comment at: clang/lib/AST/CommentSema.cpp:693 +StringRef AttributeSpelling = +CPlusPlus14 ? "[[deprecated]]" : "__attribute__((deprecated))"; if (PP) { Mordante wrote: > a

[PATCH] D71141: [Wdocumentation] Use C2x/C++14 deprecated attribute

Mordante updated this revision to Diff 232695. Mordante retitled this revision from "[Wdocumentation] Use C++14 deprecated attribute" to "[Wdocumentation] Use C2x/C++14 deprecated attribute". Mordante edited the summary of this revision. Mordante added a comment. Added C2x support as requested.

[PATCH] D71141: [Wdocumentation] Use C2x/C++14 deprecated attribute

Mordante marked an inline comment as done. Mordante added a comment. Thanks for the review! I'll wait with committing until @gribozavr2 had time to review this patch and D71140 . Comment at: clang/lib/AST/CommentSema.cpp:693 +StringRef Attr

[PATCH] D71142: [Sema] Validate large bitfields

Mordante marked 2 inline comments as done. Mordante added a comment. Further testing revealed the Codegen already has decided the limit. `clang/lib/CodeGen/CGRecordLayout.h:64`: struct CGBitFieldInfo { /// The offset within a contiguous run of bitfields that are represented as /// a sin

[PATCH] D71142: [Sema] Validate large bitfields

Mordante marked an inline comment as done. Mordante added a comment. In D71142#1774270 , @xbolva00 wrote: > Maybe a bit offtopic, but it would be good to diagnose this case too: > > enum A {a, b, c = 8}; > > struct T { > enum A field : 2; > }

[PATCH] D71140: [Wdocumentation] Properly place deprecated attribute

Mordante marked 2 inline comments as done. Mordante added inline comments. Comment at: clang/test/Sema/warn-documentation-fixits.cpp:4 +// RUN: %clang_cc1 -std=c++14 -fsyntax-only -Wdocumentation -Wdocumentation-pedantic -fcomment-block-commands=foobar -fdiagnostics-parseable-f

[PATCH] D71141: [Wdocumentation] Use C2x/C++14 deprecated attribute

Mordante marked 5 inline comments as done. Mordante added a comment. Thanks for your review of this set of patches! Comment at: clang/lib/AST/CommentSema.cpp:698 + // - In C2x/C++14 we prefer [[deprecated]] + // - If not found or an older C/C++ look for __attribute__(

[PATCH] D71139: [Wdocumentation] Use the command marker

This revision was automatically updated to reflect the committed changes. Closed by commit rG85fff898bb31: [Wdocumentation] Use the command marker. (authored by Mordante). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71139/new/ https://reviews.llvm

[PATCH] D71140: [Wdocumentation] Properly place deprecated attribute

This revision was automatically updated to reflect the committed changes. Closed by commit rGb972f2d05e8b: [Wdocumentation] Properly place deprecated attribute (authored by Mordante). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71140/new/ https://

[PATCH] D71141: [Wdocumentation] Use C2x/C++14 deprecated attribute

This revision was automatically updated to reflect the committed changes. Mordante marked 2 inline comments as done. Closed by commit rGb6d386f6f996: [Wdocumentation] Use C2x/C++14 deprecated attribute (authored by Mordante). Changed prior to commit: https://reviews.llvm.org/D71141?vs=232695&id

[PATCH] D69223: WDocumentation: Implement the \anchor.

Mordante marked an inline comment as done. Mordante added inline comments. Comment at: clang/lib/AST/TextNodeDumper.cpp:493 + case comments::InlineCommandComment::RenderAnchor: +OS << " RenderAnchor"; +break; Mordante wrote: > gribozavr2 wrote: > > Pleas

[PATCH] D71526: [AST] Use a reference in a range-based for

Mordante created this revision. Mordante added reviewers: rsmith, aaron.ballman, xbolva00. Mordante added a project: clang. This avoids unneeded copies when using a range-based for loops. This avoids new warnings due to D68912 adds -Wrange-loop-analysis to -Wall

[PATCH] D71527: [Driver] Avoid copies in range-based for loops

Mordante created this revision. Mordante added reviewers: Eugene.Zelenko, sepavloff, aaron.ballman, xbolva00. Mordante added a project: clang. This avoids new warnings due to D68912 adds -Wrange-loop-analysis to -Wall. Repository: rG LLVM Github Monorepo htt

[PATCH] D71529: [Sema] Fixes -Wrange-loop-analysis warnings

Mordante created this revision. Mordante added reviewers: rsmith, aaron.ballman, xbolva00. Mordante added a project: clang. This avoids new warnings due to D68912 adds -Wrange-loop-analysis to -Wall. Repository: rG LLVM Github Monorepo https://reviews.llvm.o

[PATCH] D71530: [Frontend] Fixes -Wrange-loop-analysis warnings

Mordante created this revision. Mordante added reviewers: rsmith, aaron.ballman, xbolva00. Mordante added a project: clang. This avoids new warnings due to D68912 adds -Wrange-loop-analysis to -Wall. Repository: rG LLVM Github Monorepo https://reviews.llvm.o

[PATCH] D71526: [AST] Use a reference in a range-based for

This revision was automatically updated to reflect the committed changes. Closed by commit rG29e78ec67988: [AST] Use a reference in a range-based for (authored by Mordante). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71526/new/ https://reviews.ll

[PATCH] D71530: [Frontend] Fixes -Wrange-loop-analysis warnings

This revision was automatically updated to reflect the committed changes. Closed by commit rG385339034f08: [Frontend] Fixes -Wrange-loop-analysis warnings (authored by Mordante). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71530/new/ https://revie

[PATCH] D71527: [Driver] Avoid copies in range-based for loops

This revision was automatically updated to reflect the committed changes. Closed by commit rGb750486c5d96: [Driver] Avoid copies in range-based for loops (authored by Mordante). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71527/new/ https://review

[PATCH] D71529: [Sema] Fixes -Wrange-loop-analysis warnings

This revision was automatically updated to reflect the committed changes. Closed by commit rG3ec6128daeea: [Sema] Fixes -Wrange-loop-analysis warnings (authored by Mordante). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71529/new/ https://reviews.l

[PATCH] D68913: Adds fixit hints to the Wrange-loop-analysis

Mordante added a comment. In D68913#1787784 , @thakis wrote: > Mordante, do you need someone to land this for you? Thanks for the offer, but it's not required. I want to commit it once I fixed all issues that would be introduced by D68912

[PATCH] D70869: [Analyzer] Use a reference in a range-based for

This revision was automatically updated to reflect the committed changes. Closed by commit rG70d592d68c7a: [Analyzer] Use a reference in a range-based for (authored by Mordante). Changed prior to commit: https://reviews.llvm.org/D70869?vs=231593&id=235015#toc Repository: rG LLVM Github Monor

[PATCH] D69223: WDocumentation: Implement the \anchor.

This revision was automatically updated to reflect the committed changes. Closed by commit rGbe1a9b3863b6: [Wdocumentation] Implement \anchor (authored by Mordante). Changed prior to commit: https://reviews.llvm.org/D69223?vs=231766&id=235016#toc Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D68912: Adds -Wrange-loop-analysis to -Wall

Mordante added a comment. In D68912#1794138 , @xbolva00 wrote: > All is fixed now? Not yet :-( I ran into a false positive with rvalue references, will post a code fix for it and then I'll look into posting more error fixes. CHANGES SINCE LAST ACTION

[PATCH] D71806: Improve Wrange-loop-analyses for rvalue reference

Mordante created this revision. Mordante added reviewers: rsmith, aaron.ballman, xbolva00. Mordante added a project: clang. The Wrange-loop-analyses warns if a copy is made. Suppress this warning when a temporary is bound to a rvalue reference. While fixing this issue also found a copy-paste err

[PATCH] D71809: [Analyzer] Fixes -Wrange-loop-analysis warnings

Mordante created this revision. Mordante added reviewers: dcoughlin, aaron.ballman, xbolva00, Szelethus. Mordante added a project: clang. Herald added subscribers: Charusso, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. This avoids new warnings due to D689

[PATCH] D71809: [Analyzer] Fixes -Wrange-loop-analysis warnings

This revision was automatically updated to reflect the committed changes. Closed by commit rGb6d9e976629a: [Analyzer] Fixes -Wrange-loop-analysis warnings (authored by Mordante). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71809/new/ https://revie

[PATCH] D71857: Fixes -Wrange-loop-analysis warnings

Mordante created this revision. Mordante added reviewers: aaron.ballman, xbolva00. Mordante added projects: LLVM, LLDB, clang. Herald added subscribers: bmahjour, usaxena95, kadircet, arphaman, jkorous, kbarton, hiraditya, nemanjai, qcolombet, MatzeB. This avoids new warnings due to D68912

[PATCH] D72103: [Sema] Avoid using an invalid InsertPos

Mordante added a comment. Friendly ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72103/new/ https://reviews.llvm.org/D72103 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D73434: [Sema] Remove a -Wrange warning from -Wall

This revision was automatically updated to reflect the committed changes. Closed by commit rGc03349e40f21: [Sema] Remove a -Wrange warning from -Wall (authored by Mordante). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73434/new/ https://reviews.ll

[PATCH] D73434: [Sema] Remove a -Wrange warning from -Wall

Mordante added a comment. Created D73834 to cherry-pick the changes to the release branch and updates the release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73434/new/ https://reviews.llvm.org/D73434

[PATCH] D73834: Update for Clang 10 release notes

Mordante created this revision. Mordante added a reviewer: hans. Mordante added a project: clang. Herald added a subscriber: cfe-commits. This contains the update for the release notes for D73007 and D73434 . You already cherry-p

[PATCH] D72231: [Sema] Adds the pointer-to-int-cast diagnostic

Mordante updated this revision to Diff 242393. Mordante added a comment. - Enabled the warning by default - Added an Microsoft extension, the unit tests already expected this behaviour CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72231/new/ https://reviews.llvm.org/D72231 Files: cla

[PATCH] D73834: Update for Clang 10 release notes

Mordante closed this revision. Mordante added a comment. Phab registered the commit, but didn't close this review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73834/new/ https://reviews.llvm.org/D73834 _

[PATCH] D72231: [Sema] Adds the pointer-to-int-cast diagnostic

This revision was automatically updated to reflect the committed changes. Mordante marked an inline comment as done. Closed by commit rG9658d895c81a: [Sema] Adds the pointer-to-int-cast diagnostic (authored by Mordante). Changed prior to commit: https://reviews.llvm.org/D72231?vs=242393&id=2448

[PATCH] D72231: [Sema] Adds the pointer-to-int-cast diagnostic

Mordante marked 2 inline comments as done. Mordante added a comment. Herald added a subscriber: martong. Thanks for the review. I'll have a look at your suggestion for a follow-up patch. Comment at: clang/test/Sema/cast.c:1 -// RUN: %clang_cc1 -fsyntax-only -triple x86_64-unkn

[PATCH] D71966: [Wdocumentation][RFC] Improve identifier's of \param

Mordante planned changes to this revision. Mordante marked an inline comment as done. Mordante added inline comments. Comment at: clang/lib/AST/CommentSema.cpp:1121 + if (isFunctionOrMethodVariadic() && + Typo.find_first_not_of('.') == StringRef::npos) +return ParamComm

[PATCH] D72231: [Sema] Adds the pointer-to-int-cast diagnostic

Mordante added a comment. This revision caused issue for the MSVC build bot. I created a followup patch D74694 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72231/new/ https://reviews.llvm.org/D72231 _

[PATCH] D74694: [Sema] Fix pointer-to-int-cast for MSVC build bot

Mordante created this revision. Mordante added reviewers: rsmith, dblaikie, rjmccall. Mordante added a project: clang. Herald added a subscriber: martong. Revision 9658d895c81a breaks the clang-x64-windows-msvc build bot [1].

[PATCH] D74694: [Sema] Fix pointer-to-int-cast for MSVC build bot

Mordante added a comment. Thanks for the quick review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74694/new/ https://reviews.llvm.org/D74694 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D74694: [Sema] Fix pointer-to-int-cast for MSVC build bot

This revision was automatically updated to reflect the committed changes. Closed by commit rGaf202119443b: [Sema] Fix pointer-to-int-cast for MSVC build bot (authored by Mordante). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74694/new/ https://rev

[PATCH] D72231: [Sema] Adds the pointer-to-int-cast diagnostic

Mordante added a comment. In D72231#1879347 , @rjmccall wrote: > In D72231#1878528 , @nathanchance > wrote: > > > There appear to a be semantic difference between GCC and clang with the > > current version of this

<    1   2   3   4   5   >