malaperle-ericsson added a comment.
Sorry about all the typos. I have now installed a spell checked in VS Code :)
https://reviews.llvm.org/D31887
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
malaperle-ericsson updated this revision to Diff 95078.
malaperle-ericsson added a comment.
Fix mention of "extra Clang tools"
https://reviews.llvm.org/D31887
Files:
docs/clangd.rst
docs/index.rst
Index: docs/index.rst
===
---
malaperle-ericsson added a comment.
In https://reviews.llvm.org/D31992#725866, @krasimir wrote:
> Seems that we're starting to hit some YAML/JSON mismatches, or is it that
> your YAML string support is lacking?
I don't think so. It seems like JSON and YAML are not completely aligned on
escape
malaperle-ericsson added a comment.
In https://reviews.llvm.org/D31992#725913, @joerg wrote:
> I'm strongly against this patch. Can you give an actual test case for the
> problematic behavior?
Sure I can add a test. If you meant more real work scenario, you can juste type
"é" in VS Code and i
malaperle-ericsson added a comment.
In https://reviews.llvm.org/D31992#726447, @joerg wrote:
> let's escape ... all the known ASCII control characters,
Do you mean encode all of them with \u or keep the two characters
representation for those that exist? I think \n is nicer than \u000A and i
malaperle-ericsson updated this revision to Diff 95414.
malaperle-ericsson added a comment.
Handle other control characters and add test
https://reviews.llvm.org/D31992
Files:
clangd/ASTManager.cpp
clangd/Protocol.cpp
clangd/Protocol.h
clangd/ProtocolHandlers.cpp
test/clangd/encoding.
malaperle-ericsson added a comment.
Once the use of "two characters representation" is clarified, I will update the
patch again.
https://reviews.llvm.org/D31992
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
malaperle-ericsson updated this revision to Diff 95416.
malaperle-ericsson removed a subscriber: Sarcasm.
malaperle-ericsson added a comment.
Update with comments (extra backticks, etc)
https://reviews.llvm.org/D31887
Files:
docs/clangd.rst
docs/index.rst
Index: docs/index.rst
malaperle-ericsson added a comment.
In https://reviews.llvm.org/D31992#728036, @joerg wrote:
> Just to avoid any confusion: this should be the generic YAML escape routine
> in llvm/lib/Support, i.e. IMO we don't want to have separate YAML and JSON
> escape routines.
> Effective, change YAMLPar
malaperle-ericsson updated this revision to Diff 104413.
malaperle-ericsson added a comment.
Remove use of unique_ptr
https://reviews.llvm.org/D34269
Files:
clangd/CMakeLists.txt
clangd/ClangdLSPServer.cpp
clangd/ClangdServer.cpp
clangd/ClangdServer.h
clangd/ClangdUnit.cpp
clangd/Cl
malaperle added a comment.
In the other review: "The tool is fine with spaces encoded as %20 by the way."
If that's true, wouldn't that mean the other review is the way to go?
Repository:
rL LLVM
https://reviews.llvm.org/D35215
___
cfe-commits m
malaperle added a comment.
Could you explain what the goal of this change is? It would help understand how
it will impact the indexing work I am currently doing.
https://reviews.llvm.org/D35406
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
malaperle added a comment.
In https://reviews.llvm.org/D35406#809609, @ilya-biryukov wrote:
> The idea is to allows us changing the way we manage/rebuild PCHs and ASTs.
> ASTUnit is used for many things and has a fairly complicated and verbose
> interface and does a lot of mutations all other t
malaperle requested changes to this revision.
malaperle added a comment.
This revision now requires changes to proceed.
Normally we put [clangd] in the title.
Comment at: clangd/ClangdLSPServer.cpp:11
#include "ClangdLSPServer.h"
+#include "clang/Basic/SourceManager.h"
#inclu
malaperle-ericsson added a comment.
To be honest, I don't think this needs to be merged but it makes sense to put
it somewhere people can try it.
Repository:
rL LLVM
https://reviews.llvm.org/D30476
___
cfe-commits mailing list
cfe-commits@lists.
malaperle-ericsson updated this revision to Diff 90774.
malaperle-ericsson added a comment.
[clangd] Fix not being able to attach a debugger on macOS
Clangd is often waiting for input on getline as it awaits requests.
If the getline is interrupted, it causes the system call (read) to
fail and the
malaperle-ericsson added a comment.
Please disregard the last diff, I misused arc.
https://reviews.llvm.org/D30476
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
malaperle-ericsson updated this revision to Diff 90776.
https://reviews.llvm.org/D30476
Files:
clangd/clients/lsp4e-cpp/.gitignore
clangd/clients/lsp4e-cpp/.mvn/extensions.xml
clangd/clients/lsp4e-cpp/.travis.yml
clangd/clients/lsp4e-cpp/LICENSE
clangd/clients/lsp4e-cpp/README.md
clan
malaperle-ericsson added a comment.
In https://reviews.llvm.org/D30675#695370, @bkramer wrote:
> Generally makes sense. Is there any reason for the #ifdef? Windows has errno
> and EINTR too.
I have no reasonable expectation that getline will produce a EINTR on Windows.
But perhaps there's no
malaperle-ericsson updated this revision to Diff 91246.
malaperle-ericsson added a comment.
Remove ifdexf
https://reviews.llvm.org/D30675
Files:
clangd/ClangDMain.cpp
Index: clangd/ClangDMain.cpp
===
--- clangd/ClangDMain.cpp
+
malaperle-ericsson added a comment.
Ping :)
https://reviews.llvm.org/D30675
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
malaperle-ericsson updated this revision to Diff 95809.
malaperle-ericsson added a comment.
Add test
https://reviews.llvm.org/D32234
Files:
clangd/Protocol.cpp
test/clangd/completion.test
Index: test/clangd/completion.test
==
malaperle-ericsson updated this revision to Diff 95811.
malaperle-ericsson added a comment.
Add test
https://reviews.llvm.org/D32238
Files:
clangd/Protocol.cpp
test/clangd/completion.test
Index: test/clangd/completion.test
==
malaperle-ericsson added a comment.
Could you commit it? I don't have commit access :) Thanks!
https://reviews.llvm.org/D32238
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
malaperle-ericsson added a comment.
Benjamin, I added a test, do you still think it's OK? Thanks!
https://reviews.llvm.org/D32234
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
malaperle-ericsson added a comment.
Thanks a lot!
Repository:
rL LLVM
https://reviews.llvm.org/D32234
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
malaperle-ericsson added a comment.
Ping. Any more objections?
https://reviews.llvm.org/D31887
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
malaperle-ericsson added a comment.
Would it be possible to commit this? I do not have commit rights. Thanks!
https://reviews.llvm.org/D31887
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
malaperle-ericsson added a comment.
In https://reviews.llvm.org/D31887#740747, @Prazek wrote:
> In https://reviews.llvm.org/D31887#740727, @malaperle-ericsson wrote:
>
> > Would it be possible to commit this? I do not have commit rights. Thanks!
>
>
> Why won't you get commit right? You will prob
301 - 329 of 329 matches
Mail list logo
