klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
http://reviews.llvm.org/D13810
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
Author: klimek
Date: Mon Oct 19 03:27:51 2015
New Revision: 250690
URL: http://llvm.org/viewvc/llvm-project?rev=250690&view=rev
Log:
Make test not rely on %T ending on /Output.
Modified:
cfe/trunk/test/Driver/ps4-linker-non-win.c
Modified: cfe/trunk/test/Driver/ps4-linker-non-win.c
URL:
htt
Author: klimek
Date: Mon Oct 19 03:43:46 2015
New Revision: 250691
URL: http://llvm.org/viewvc/llvm-project?rev=250691&view=rev
Log:
Fix 'will be initialized after' warning.
Modified:
cfe/trunk/lib/CodeGen/TargetInfo.cpp
Modified: cfe/trunk/lib/CodeGen/TargetInfo.cpp
URL:
http://llvm.org/vi
On Sat, Oct 17, 2015 at 3:41 AM Richard Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Fri, Oct 16, 2015 at 6:30 PM, Sean Silva wrote:
>
>> On Fri, Oct 16, 2015 at 6:26 PM, Richard Smith
>> wrote:
>>
>>> On Fri, Oct 16, 2015 at 6:25 PM, Sean Silva
>>> wrote:
>>>
On Fri, Oc
klimek accepted this revision.
klimek added a reviewer: klimek.
klimek added a comment.
This revision is now accepted and ready to land.
I'd slightly prefer if the commands were still on their own line (via escaped
newlines if that's possible), but lg.
http://reviews.llvm.org/D13852
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
Thx Milinan; this also looks fine from a binary compatibility perspective ...
http://reviews.llvm.org/D13000
___
cfe-commits mailing list
cfe-com
klimek added a comment.
+1 to "not tested before" not implying "doesn't need tests" :)
http://reviews.llvm.org/D13001
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On Tue, Oct 20, 2015 at 5:52 AM Sean Silva wrote:
> On Mon, Oct 19, 2015 at 2:10 AM, Manuel Klimek wrote:
>
>> On Sat, Oct 17, 2015 at 3:41 AM Richard Smith via cfe-commits <
>> cfe-commits@lists.llvm.org> wrote:
>>
>>> On Fri, Oct 16, 2015 at 6:30 PM, Sean Silva
>>> wrote:
>>>
On Fri, Oct
On Tue, Oct 20, 2015 at 10:41 AM Sean Silva wrote:
> On Tue, Oct 20, 2015 at 1:38 AM, Manuel Klimek wrote:
>
>> On Tue, Oct 20, 2015 at 5:52 AM Sean Silva wrote:
>>
>>> On Mon, Oct 19, 2015 at 2:10 AM, Manuel Klimek
>>> wrote:
>>>
On Sat, Oct 17, 2015 at 3:41 AM Richard Smith via cfe-comm
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
LG. Yay!
Comment at: clang-tidy/modernize/UseDefaultCheck.cpp:59-60
@@ +58,4 @@
+ "= default;");
+ // FIXME: this can generate a -Wpedantic warning if there is a sem
klimek added a reviewer: bkramer.
klimek added a comment.
+benjamin, who has been doing those changes lately...
http://reviews.llvm.org/D13890
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
klimek added a reviewer: bkramer.
klimek added a comment.
+benjamin, who has been doing those changes lately...
http://reviews.llvm.org/D13891
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
LG
http://reviews.llvm.org/D13889
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
On Tue, Oct 20, 2015 at 3:38 PM Brad King wrote:
> On 10/20/2015 04:38 AM, Manuel Klimek wrote:
> > On Tue, Oct 20, 2015 at 5:52 AM Sean Silva wrote:
> >> get cmake to generate clang module map files and add explicit module
> build steps?
> >
> > I have some experience hacking on cmake, and from
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
Yay, another yak shaved \o/
http://reviews.llvm.org/D13897
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-
On Tue, Oct 20, 2015 at 11:11 PM Sean Silva wrote:
> On Tue, Oct 20, 2015 at 6:45 AM, Manuel Klimek wrote:
>
>> On Tue, Oct 20, 2015 at 3:38 PM Brad King wrote:
>>
>>> On 10/20/2015 04:38 AM, Manuel Klimek wrote:
>>> > On Tue, Oct 20, 2015 at 5:52 AM Sean Silva wrote:
>>> >> get cmake to genera
klimek added inline comments.
Comment at: include/clang/Tooling/Core/Lookup.h:37-38
@@ +36,4 @@
+/// \param FromDecl The declaration to which the nested name points.
+/// \param ReplacementString The replacement nested name. Should be fully
+/// qualified.
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
http://reviews.llvm.org/D13975
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
klimek added a subscriber: klimek.
klimek added a comment.
A test that fails before this patch and passes afterwards is needed :) If you
need help writing that test, let me know.
http://reviews.llvm.org/D13973
___
cfe-commits mailing list
cfe-commi
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
Comment at: include/clang/AST/ASTContext.h:463
@@ +462,3 @@
+ class DynTypedNodeList {
+typedef ast_type_traits::DynTypedNode DynTypedNode;
+typedef ArrayRef ARef;
Author: klimek
Date: Thu Oct 22 06:31:44 2015
New Revision: 251010
URL: http://llvm.org/viewvc/llvm-project?rev=251010&view=rev
Log:
Add %check_clang_tidy and %clang_tidy_diff.
With this, site specific lit configs can inject parameters into the
test scripts if they need site specific parameters.
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
http://reviews.llvm.org/D13983
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
http://reviews.llvm.org/D13982
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
klimek added inline comments.
Comment at: include/clang/Tooling/Core/Lookup.h:37-38
@@ +36,4 @@
+/// \param FromDecl The declaration to which the nested name points.
+/// \param ReplacementString The replacement nested name. Should be qualified,
+/// leadi
Author: klimek
Date: Thu Oct 22 09:54:50 2015
New Revision: 251021
URL: http://llvm.org/viewvc/llvm-project?rev=251021&view=rev
Log:
Switch check_clang_tidy to argparse and add a -resource-dir argument.
-resource-dir can be used to inject non-standard resource dirs via the
lit site config.
Modif
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
http://reviews.llvm.org/D13931
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg; let's see whether it sticks this time :)
Comment at: include/clang/AST/ASTContext.h:456
@@ -455,1 +455,3 @@
+ /// pointer identity only, which are more common and we can
klimek added inline comments.
Comment at: lib/Analysis/CFG.cpp:1949-1952
@@ +1948,6 @@
+ }
+ if(!C->body_empty() && !dyn_cast(*C->body_rbegin())) {
+// If the body ends with a ReturnStmt, the dtors will be added in
VisitReturnStmt
+addAutomaticObjDtors(ScopePos, scopeBe
Author: klimek
Date: Fri Oct 23 05:00:50 2015
New Revision: 251103
URL: http://llvm.org/viewvc/llvm-project?rev=251103&view=rev
Log:
Make isExpensiveToCopy() tri-state.
This allows returning "don't know" for dependent types.
Modified:
clang-tools-extra/trunk/clang-tidy/utils/Matchers.h
c
klimek added inline comments.
Comment at: lib/Analysis/CFG.cpp:1949-1952
@@ +1948,6 @@
+ }
+ if(!C->body_empty() && !dyn_cast(*C->body_rbegin())) {
+// If the body ends with a ReturnStmt, the dtors will be added in
VisitReturnStmt
+addAutomaticObjDtors(ScopePos, scopeBe
LG. Thanks, totally missed this.
On Sun, Oct 25, 2015, 7:46 PM Matthias Gehre via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> mgehre created this revision.
> mgehre added reviewers: alexfh, sbenza, bkramer, aaron.ballman.
> mgehre added a subscriber: cfe-commits.
>
> Adapt clang-tidy/add_n
klimek added inline comments.
Comment at: lib/Format/ContinuationIndenter.cpp:334
@@ +333,3 @@
+ if (Style.AlignAfterOpenBracket == FormatStyle::BAS_AlwaysBreak &&
+ Previous.is(tok::l_paren) && State.Column > getNewLineColumn(State) &&
+ (!Previous.Previous ||
klimek added inline comments.
Comment at: lib/Format/ContinuationIndenter.cpp:334
@@ +333,3 @@
+ if (Style.AlignAfterOpenBracket == FormatStyle::BAS_AlwaysBreak &&
+ Previous.is(tok::l_paren) && State.Column > getNewLineColumn(State) &&
+ (!Previous.Previous ||
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
http://reviews.llvm.org/D14105
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
klimek added a comment.
Generally, I feel like a lot of the code would be written better as ast
matchers (by adding new matchers if necessary). You can use
tooling::ast_matchers::matches if you want to do a match inside a callback.
Comment at: clang-tidy/modernize/UseDefaultCh
Thanks!
On Wed, Oct 28, 2015 at 4:51 AM Angel Garcia wrote:
> angelgarcia added a comment.
>
> OK, thanks! I will try to refactor some of the parts into AST matchers
> then. It will probably take some time, though.
>
>
> http://reviews.llvm.org/D14145
>
>
>
>
klimek added a comment.
Please add unit tests :)
http://reviews.llvm.org/D14152
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
klimek added inline comments.
Comment at: clang-tidy/modernize/UseDefaultCheck.cpp:83-91
@@ +82,11 @@
+ const CXXMethodDecl *Method) {
+ if (Method->getNumParams() != 1)
+return false;
+ QualType ArgType = Method->getParamDecl(0)->getType();
+
+
klimek added a comment.
In http://reviews.llvm.org/D14145#277202, @angelgarcia wrote:
> > In which cases can this be false? (I assume if not all are copied?)
>
>
> This can be false is there is we do anything else than initializing the
> bases and members. So the previous code is there to ensure
klimek added a comment.
In http://reviews.llvm.org/D14145#277222, @angelgarcia wrote:
> You can initialize an indirect base if it's virtual.
Cool, those cases would be useful to have as comment, for example:
// Make sure there are no additional initializations going on (for example, of
indirec
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
http://reviews.llvm.org/D14152
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
http://reviews.llvm.org/D14176
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
http://reviews.llvm.org/D14213
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
http://reviews.llvm.org/D14212
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
klimek added inline comments.
Comment at: clang-tidy/modernize/LoopConvertCheck.cpp:371-373
@@ -370,1 +370,5 @@
+/// \brief Returns false when it can be guaranteed that no container element
+/// is going to be modified due to this expression.
+static bool canBeModified(ASTContex
klimek added a comment.
Sergey, I think you raised concerns whether this is necessary. What are your
thoughts?
http://reviews.llvm.org/D13388
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
http://reviews.llvm.org/D14145
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
klimek added a subscriber: klimek.
klimek added a comment.
Is this still the most current patch out there?
http://reviews.llvm.org/D5767
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
On Fri, Oct 23, 2015 at 9:31 PM Sean Silva wrote:
> On Tue, Oct 20, 2015 at 1:52 AM, Manuel Klimek wrote:
>
>> On Tue, Oct 20, 2015 at 10:41 AM Sean Silva
>> wrote:
>>
>>> On Tue, Oct 20, 2015 at 1:38 AM, Manuel Klimek
>>> wrote:
>>>
On Tue, Oct 20, 2015 at 5:52 AM Sean Silva
wrote:
klimek added inline comments.
Comment at: lib/Analysis/CFG.cpp:1949-1952
@@ +1948,6 @@
+ }
+ if(!C->body_empty() && !dyn_cast(*C->body_rbegin())) {
+// If the body ends with a ReturnStmt, the dtors will be added in
VisitReturnStmt
+addAutomaticObjDtors(ScopePos, scopeBe
klimek added a reviewer: jordan_rose.
klimek added a comment.
+jordan for an opinion on whether we want to fix the more general case.
My main problem is that while we're at it we need to fully understand the
change anyway, and if somebody runs into this later, they'll need a long time
debuggin
klimek added a reviewer: bkramer.
klimek added a comment.
+Benjamin to share another yak :D
http://reviews.llvm.org/D11944
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
klimek added inline comments.
Comment at: clang-tidy/modernize/LoopConvertCheck.cpp:371-374
@@ -370,1 +370,6 @@
+/// \brief Returns false when it can be guaranteed that no element of the
+/// container we are iterating over is going to be modified due to this
+/// expression.
+s
klimek added a comment.
Ok, just let me know when you have an updated patch out for review for
submission, so I can make sure we'll get the reviews done in a timely fashion.
I really want to see this go in :)
http://reviews.llvm.org/D5767
___
cfe-
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
LG. Much better, thanks!
http://reviews.llvm.org/D14198
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
http://reviews.llvm.org/D14282
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
http://reviews.llvm.org/D14289
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
http://reviews.llvm.org/D14291
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
klimek created this revision.
klimek added a reviewer: rsmith.
klimek added a subscriber: cfe-commits.
http://reviews.llvm.org/D14353
Files:
lib/Lex/ModuleMap.cpp
test/Modules/Inputs/private3/private.h
test/Modules/Inputs/private3/public.h
test/Modules/private.modulemap
Index: test/Modul
klimek updated this revision to Diff 39287.
klimek added a comment.
Remove unnecessary if and fix segfault.
http://reviews.llvm.org/D14353
Files:
lib/Lex/ModuleMap.cpp
test/Modules/Inputs/private3/private.h
test/Modules/Inputs/private3/public.h
test/Modules/private.modulemap
Index: tes
klimek marked 2 inline comments as done.
klimek added a comment.
Addressed comments.
http://reviews.llvm.org/D14353
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: klimek
Date: Thu Nov 5 09:24:47 2015
New Revision: 252170
URL: http://llvm.org/viewvc/llvm-project?rev=252170&view=rev
Log:
Allow use of private headers in different sub-modules.
Added:
cfe/trunk/test/Modules/Inputs/private3/
cfe/trunk/test/Modules/Inputs/private3/private.h
c
klimek added inline comments.
Comment at: clang-tidy/ClangTidy.cpp:382
@@ +381,3 @@
+ const CommandLineArguments &Args, StringRef Filename) {
+Context.setCurrentFile(Filename);
+const ClangTidyOptions &Opts = Context.getOptions();
My concern is still
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
http://reviews.llvm.org/D14378
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
klimek added a comment.
> I currently see the following ways forward:
>
> 1. Extend this patch to cover also "throw", fixing case B)
> 2. Do 1) plus loop over the whole body to also fix case C)
> 3. Drop this patch and instead remove unreachable blocks after the whole CFG
> has been generate
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
http://reviews.llvm.org/D14437
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
http://reviews.llvm.org/D14438
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
klimek added a comment.
Does this still do it for types with a user-provided implicit constructor?
http://reviews.llvm.org/D14442
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
klimek added inline comments.
Comment at: clang-tidy/ClangTidy.cpp:382
@@ +381,3 @@
+ const CommandLineArguments &Args, StringRef Filename) {
+Context.setCurrentFile(Filename);
+const ClangTidyOptions &Opts = Context.getOptions();
alexfh wrote:
> klim
klimek added a comment.
Can you add a test with an overloaded conversion operator?
http://reviews.llvm.org/D14442
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
klimek added inline comments.
Comment at: clang-tidy/ClangTidy.cpp:382
@@ +381,3 @@
+ const CommandLineArguments &Args, StringRef Filename) {
+Context.setCurrentFile(Filename);
+const ClangTidyOptions &Opts = Context.getOptions();
alexfh wrote:
> klim
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
http://reviews.llvm.org/D14442
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
Ok, this patch LG. I'd really like to get rid of the current-file-dependent
stuff in ClangTidyOptions though :)
http://reviews.llvm.org/D14192
_
klimek added a comment.
Jordan, your call :)
http://reviews.llvm.org/D13973
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
klimek added a comment.
Hm, the referenced style guide doesn't say anything about namespaces. I also
couldn't find anything in the qt source repo (just took a quick look though).
Do you have an example of why Qt projects shouldn't just use BS_Linux?
http://reviews.llvm.org/D11837
__
klimek added a comment.
Webkit doesn't break for classes:
class MyClass {
...
};
http://reviews.llvm.org/D11837
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
klimek added a comment.
Ah, ok. Interestingly, our current Webkit style uses BS_Stroustrup, which is
incorrect for } else {. So yep, implementing BS_Webkit sounds like a win.
http://reviews.llvm.org/D11837
___
cfe-commits mailing list
cfe-commits@
klimek added a comment.
Can you also fix the current code in getWebKitStyle?
http://reviews.llvm.org/D11837
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
klimek accepted this revision.
klimek added a reviewer: klimek.
klimek added a comment.
Ah, awesome, looks good then. Do you have commit access or need one of us to
land it?
http://reviews.llvm.org/D11837
___
cfe-commits mailing list
cfe-commits@li
Instead of forwarding this patch, which kills mail threading, I'd just
abandon the patch and create a new one where you directly add llvm-commits
when you upload it.
(we know this is a problem, and we know how to fix it, but we'd need some
php hackers to help)
On Mon, Aug 10, 2015 at 6:14 PM Tere
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
https://reviews.llvm.org/D22408
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
https://reviews.llvm.org/D22566
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
klimek added inline comments.
Comment at: include/clang/Tooling/Core/Replacement.h:145
@@ -145,4 +144,3 @@
-/// \brief A set of Replacements.
-/// FIXME: Change to a vector and deduplicate in the RefactoringTool.
-typedef std::set Replacements;
+/// \brief This maintains a set o
klimek added a comment.
Kirill, you happy with this approach?
https://reviews.llvm.org/D21814
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
klimek added inline comments.
Comment at: clang-rename/RenamingAction.cpp:48
@@ +47,3 @@
+for (unsigned I = 0; I < NewNameList.size(); ++I) {
+ HandleOneRename(Context, NewNameList[I], PrevNameList[I], USRList[I]);
+}
Question is whether if we go down
klimek added a comment.
Kirill, unless you have *specific* issues with this patch, I think it's good to
land.
Comment at: clang-rename/RenamingAction.cpp:48
@@ +47,3 @@
+for (unsigned I = 0; I < NewNameList.size(); ++I) {
+ HandleOneRename(Context, NewNameList[I], Prev
klimek added inline comments.
Comment at: unittests/Tooling/RefactoringTest.cpp:112
@@ -111,4 +111,3 @@
-TEST_F(ReplacementTest, CanApplyReplacements) {
- FileID ID = Context.createInMemoryFile("input.cpp",
- "line1\nline2\nline3\nline4")
klimek added a reviewer: rnk.
klimek added a comment.
+Reid for a windows reviewer
Repository:
rL LLVM
https://reviews.llvm.org/D21385
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
klimek added a comment.
Kirill, are your specific concerns addressed?
https://reviews.llvm.org/D21814
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On Wed, Jul 27, 2016 at 1:06 AM Piotr Padlewski via llvm-dev <
llvm-...@lists.llvm.org> wrote:
> We could also just add nothing() matcher, so debugging would be much
> easier, just add anything() or nothing() matcher as extra argument.
>
> The other pros of it is that new developers won't send the
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
https://reviews.llvm.org/D21748
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
https://reviews.llvm.org/D21749
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
klimek added a subscriber: klimek.
Comment at: clang-tidy/misc/UnusedUsingDeclsCheck.cpp:83
@@ -80,3 +82,3 @@
if (const auto *Used = Result.Nodes.getNodeAs("used")) {
-if (const auto *Specialization =
-dyn_cast(Used))
+if (const auto *FD = dyn_cast(Used)) {
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
https://reviews.llvm.org/D22957
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
Comment at: unittests/ASTMatchers/ASTMatchersTraversalTest.cpp:550
@@ +549,3 @@
+"template class Y {};"
+ "X xi;",
+classTemplateSpecializationDecl(hasAnyTempl
klimek added inline comments.
Comment at: clang-rename/tool/clang-rename.el:7
@@ +6,3 @@
+
+;; This package allows to filter code through clang-format to fix its
formatting.
+;; clang-format is a tool that formats C/C++/Obj-C code according to a set of
s/clang-fo
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
https://reviews.llvm.org/D22903
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
https://reviews.llvm.org/D21814
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
klimek added a comment.
Perhaps call it AccessModifierIntroducesScope or something?
Side-track: I find it highly confusing that in
class C {
int v1;
private:
int v2;
}
v1 & v2 have different indent, although they are in the same scope.
https://reviews.llvm.org/D22505
klimek added a comment.
In https://reviews.llvm.org/D22505#503278, @djasper wrote:
> So you'd be for #1 of the three choices from my previous comment?
Yes, because I think ultimately introducing scopes is different from simple
outdents/indents.
https://reviews.llvm.org/D22505
301 - 400 of 588 matches
Mail list logo
