manmanren added a comment.
I am not sure if we should handle this inside findAnonymousStructOrUnionIndex.
Here is the definition of anonymous structure I found: An unnamed member whose
type specifier is a structure specifier with no tag is called an anonymous
structure.
Cheers,
Manman
==
manmanren added a comment.
In http://reviews.llvm.org/D22270#483027, @spyffe wrote:
> Thank you very much for your review, Manman! I can implement all your
> individual fixes, those look fine. In answer to two of your bigger
> questions, though:
>
> - I see what you mean about the definition
manmanren accepted this revision.
manmanren added a comment.
This revision is now accepted and ready to land.
LGTM.
Thanks,
Manman
Repository:
rL LLVM
https://reviews.llvm.org/D22270
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:/
manmanren accepted this revision.
manmanren added a comment.
This revision is now accepted and ready to land.
LGTM.
Manman
https://reviews.llvm.org/D22171
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
manmanren created this revision.
manmanren added reviewers: dexonsmith, rjmccall.
manmanren added a subscriber: cfe-commits.
This can be used to display Fix-Its.
We only add this to GNU attributes. Since it now has two optional arguments,
and the common parsing does not handle "replacement = ", w
manmanren added a comment.
Ping
http://reviews.llvm.org/D17865
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
manmanren added a comment.
Ping
http://reviews.llvm.org/D15314
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
manmanren added a comment.
Hi Aaron,
Thanks for the review!
> I like the idea of a potential fixit being provided by the attribute, but I
> do not agree with the way the feature is surfaced in this patch.
>
> For the GNU-style attribute, the named argument functionality is sufficiently
> no
Author: mren
Date: Thu Mar 10 12:53:19 2016
New Revision: 263149
URL: http://llvm.org/viewvc/llvm-project?rev=263149&view=rev
Log:
Add TreatUnavailableAsInvalid for the verification-only mode in InitListChecker.
Given the following test case:
typedef struct {
const char *name;
id field;
} Tes
Author: mren
Date: Thu Mar 10 17:51:03 2016
New Revision: 263171
URL: http://llvm.org/viewvc/llvm-project?rev=263171&view=rev
Log:
Add has_feature objc_class_property.
rdar://23891898
Modified:
cfe/trunk/lib/Lex/PPMacroExpansion.cpp
cfe/trunk/test/SemaObjC/objc-class-property.m
Modified
Author: mren
Date: Thu Mar 10 17:54:12 2016
New Revision: 263172
URL: http://llvm.org/viewvc/llvm-project?rev=263172&view=rev
Log:
Print strict in Availability attribute when it is on.
Modified:
cfe/trunk/test/Sema/attr-print.c
cfe/trunk/utils/TableGen/ClangAttrEmitter.cpp
Modified: cfe/
manmanren added a comment.
Uploading a new patch addressing Aaron's comments:
1> Add an optional string argument for fix-it, instead of the original proposal
of named argument `Replacement = "xxx"`
This actually simplifies the patch a lot
2> Add testing cases to make sure we don't accept a fix-it
manmanren retitled this revision from "Add replacement = "xxx" to
DeprecatedAttr." to "Add an optional string argument to DeprecatedAttr for
Fix-It.".
manmanren updated this revision to Diff 50374.
http://reviews.llvm.org/D17865
Files:
include/clang/Basic/Attr.td
lib/Lex/PPMacroExpansion.cp
manmanren added inline comments.
Comment at: utils/TableGen/ClangAttrEmitter.cpp:1234
@@ +1233,3 @@
+if ((Spelling == "deprecated" || Spelling == "gnu::deprecated") &&
+Variety != "GNU" && index == 1)
+ continue;
This does not look pre
manmanren updated this revision to Diff 50502.
http://reviews.llvm.org/D17865
Files:
include/clang/Basic/Attr.td
lib/Lex/PPMacroExpansion.cpp
lib/Sema/SemaDeclAttr.cpp
test/SemaCXX/attr-deprecated-replacement-error.cpp
test/SemaCXX/attr-deprecated-replacement-fixit.cpp
test/SemaCXX/cx
manmanren marked 3 inline comments as done.
manmanren added a comment.
Upload patch to address review comments.
Thanks,
Manman
http://reviews.llvm.org/D17865
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mail
manmanren added a comment.
In http://reviews.llvm.org/D17865#374659, @aaron.ballman wrote:
> Aside from the missing attribute documentation, looks good to me.
Hi Aaron,
Which document are you referring to? "include/clang/Basic/AttrDocs.td"?
We don't have a section for DeprecatedAttr, should I
manmanren updated this revision to Diff 50682.
http://reviews.llvm.org/D17865
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
lib/Lex/PPMacroExpansion.cpp
lib/Sema/SemaDeclAttr.cpp
test/SemaCXX/attr-deprecated-replacement-error.cpp
test/SemaCXX/attr-deprecated-repla
g::IdentifierLoc*, clang::AvailabilityChange const&,
>> clang::AvailabilityChange const&, clang::AvailabilityChange const&,
>> clang::SourceLocation, clang::Expr const*, clang::AttributeList::Syntax,
>> clang::SourceLocation, clang::Expr const*)
>> /mnt/b/saniti
Author: mren
Date: Fri Mar 18 18:35:21 2016
New Revision: 263854
URL: http://llvm.org/viewvc/llvm-project?rev=263854&view=rev
Log:
[TLS on Darwin] use CXX_FAST_TLS calling convention for tls_init.
This makes sure we don't generate a lot of code to spill/reload
CSRs when calling tls_init from the
Author: mren
Date: Wed Mar 16 22:09:55 2016
New Revision: 263687
URL: http://llvm.org/viewvc/llvm-project?rev=263687&view=rev
Log:
Add an optional named argument (replacement = "xxx") to AvailabilityAttr.
This commit adds a named argument to AvailabilityAttr, while r263652 adds an
optional string
Author: mren
Date: Thu Mar 17 17:13:50 2016
New Revision: 263752
URL: http://llvm.org/viewvc/llvm-project?rev=263752&view=rev
Log:
Revert r263687 for ubsan bot failure.
Modified:
cfe/trunk/include/clang/Basic/Attr.td
cfe/trunk/include/clang/Basic/AttrDocs.td
cfe/trunk/include/clang/Pa
Author: mren
Date: Wed Mar 16 13:50:49 2016
New Revision: 263652
URL: http://llvm.org/viewvc/llvm-project?rev=263652&view=rev
Log:
Add an optional string argument to DeprecatedAttr for Fix-It.
We only add this to __attribute__((deprecated)).
Differential Revision: http://reviews.llvm.org/D17865
pr const*)
> /mnt/b/sanitizer-buildbot3/sanitizer-x86_64-linux-fast/build/llvm/tools/clang/include/clang/Sema/AttributeList.h:798:7
> #3 0x4465a73 in clang::Parser::Pa
>
>
>
>
> On Wed, Mar 16, 2016 at 8:09 PM, Manman Ren via cfe-commits <
> cfe-commits@lists.llvm.
Author: mren
Date: Mon Mar 21 12:26:40 2016
New Revision: 263955
URL: http://llvm.org/viewvc/llvm-project?rev=263955&view=rev
Log:
NFC: wrap Availability-related data in its own struct in AttributeList.
This makes it easy to add more data into Availability.
Modified:
cfe/trunk/include/clang/
Author: mren
Date: Mon Mar 21 12:30:55 2016
New Revision: 263958
URL: http://llvm.org/viewvc/llvm-project?rev=263958&view=rev
Log:
Add replacement = "xxx" to AvailabilityAttr.
This commit adds a named argument to AvailabilityAttr, while r263652 adds an
optional string argument to __attribute__((d
Author: mren
Date: Wed Mar 23 11:28:28 2016
New Revision: 264167
URL: http://llvm.org/viewvc/llvm-project?rev=264167&view=rev
Log:
ObjC: Handle boolean fixed type for enum.
Before this commit, we assert failure in ImplicitCastExpr
"unheralded conversion to bool". This commit fixes the assertion b
Author: mren
Date: Wed Mar 23 16:39:31 2016
New Revision: 264196
URL: http://llvm.org/viewvc/llvm-project?rev=264196&view=rev
Log:
ObjC: add getter/setter for class properties to global pool.
rdar://problem/25323072
Modified:
cfe/trunk/lib/Sema/SemaObjCProperty.cpp
cfe/trunk/test/SemaObj
manmanren created this revision.
manmanren added reviewers: rsmith, rjmccall.
manmanren added a subscriber: cfe-commits.
Instantiation dependence were not being handled correctly for OpqaueValueExpr
AST nodes. As a result, if an undeclared identifier was used in a CXXNewExpr
that is assigned to a
manmanren added a comment.
In http://reviews.llvm.org/D18461#383218, @rjmccall wrote:
> Oh, you know, this should really propagate all the dependence bits, not just
> instantiation-dependence. It would be safer, at least. You could probably
> find a contrived example involving value-dependenc
Author: mren
Date: Fri Mar 25 13:43:46 2016
New Revision: 26
URL: http://llvm.org/viewvc/llvm-project?rev=26&view=rev
Log:
[ObjCXX] Warn undeclared identifiers.
Instantiation dependence were not being handled correctly for OpqaueValueExpr
AST nodes. As a result, if an undeclared identifie
manmanren added a comment.
Ping :]
http://reviews.llvm.org/D15314
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
manmanren added a subscriber: manmanren.
manmanren added a comment.
Thanks for working on this! A few comments inline.
Manman
Comment at: lib/CodeGen/CodeGenFunction.cpp:1962
@@ +1961,3 @@
+for (auto *U : I->users())
+ InstrsToRemove.push_back(cast(U));
+
-
manmanren added a subscriber: manmanren.
manmanren added a comment.
Thanks for working on this. This looks good to me overall, but I am not the
expert on Sema :]
Cheers,
Manman
Comment at: lib/Sema/SemaChecking.cpp:6985
@@ -6984,6 +6984,3 @@
SmallString<16> PrettyTargetValu
Author: mren
Date: Mon Jan 25 15:52:26 2016
New Revision: 258727
URL: http://llvm.org/viewvc/llvm-project?rev=258727&view=rev
Log:
Move ObjCPropertyDecl to before ObjCContainerDecl.
After we add ObjCPropertyDecl::isClassProperty, we can use it in
ObjCContainerDecl to define filter to iterate over
manmanren added inline comments.
Comment at: lib/CodeGen/CodeGenFunction.cpp:1998
@@ +1997,3 @@
+ if (auto *T = EntryBB->getTerminator())
+T->eraseFromParent();
+
Yes, you are right.
http://reviews.llvm.org/D15599
Author: mren
Date: Mon Jan 25 16:37:47 2016
New Revision: 258735
URL: http://llvm.org/viewvc/llvm-project?rev=258735&view=rev
Log:
Update comments to match the implementation.
Modified:
cfe/trunk/lib/CodeGen/CGObjCMac.cpp
Modified: cfe/trunk/lib/CodeGen/CGObjCMac.cpp
URL:
http://llvm.org/vi
manmanren created this revision.
manmanren added reviewers: echristo, rafael, ahatanak.
manmanren added a subscriber: cfe-commits.
It can happen that frontend emits error message when releasing the builder.
When that happens, we emit the error message and continue to invoke backend.
Backend will
Author: mren
Date: Tue Jan 26 12:05:23 2016
New Revision: 258824
URL: http://llvm.org/viewvc/llvm-project?rev=258824&view=rev
Log:
Use instance_properties instead of properties. NFC.
All current properties are instance properties.
This is the second patch in a series of patches to support class
Author: mren
Date: Tue Jan 26 12:52:43 2016
New Revision: 258834
URL: http://llvm.org/viewvc/llvm-project?rev=258834&view=rev
Log:
Class Property: parse property attribute (class).
This is the third patch in a series of patches to support class properties
in addition to instance properties in obj
Author: mren
Date: Wed Jan 27 14:00:32 2016
New Revision: 258979
URL: http://llvm.org/viewvc/llvm-project?rev=258979&view=rev
Log:
Class Property: handle class properties.
At places where we handle instance properties, if necessary.
rdar://23891898
Modified:
cfe/trunk/lib/AST/DeclObjC.cpp
Author: mren
Date: Wed Jan 27 14:10:32 2016
New Revision: 258980
URL: http://llvm.org/viewvc/llvm-project?rev=258980&view=rev
Log:
Class Property: create accessors (class methods) for class property.
Change a few places where we assume property accessors can only be instance
methods.
rdar://2389
Author: mren
Date: Thu Jan 28 12:49:28 2016
New Revision: 259070
URL: http://llvm.org/viewvc/llvm-project?rev=259070&view=rev
Log:
Class Property: class property and instance property can have the same name.
Add "enum ObjCPropertyQueryKind" to a few APIs that used to only take the name
of the pro
manmanren updated this revision to Diff 46301.
manmanren added a comment.
Addressing comments from Akira and Justin.
http://reviews.llvm.org/D16564
Files:
lib/CodeGen/ModuleBuilder.cpp
test/CodeGen/target-builtin-error-3.c
Index: test/CodeGen/target-builtin-error-3.c
==
gt; error emitted and compilation stopped?
>
> -eric
>
>
> On Thu, Jan 28, 2016 at 9:53 AM Justin Bogner
> wrote:
>
>> Manman Ren via cfe-commits writes:
>> > manmanren created this revision.
>> > manmanren added reviewers: echristo, rafael, ahatanak.
>> &
Author: mren
Date: Thu Jan 28 17:29:02 2016
New Revision: 259116
URL: http://llvm.org/viewvc/llvm-project?rev=259116&view=rev
Log:
Check for frontend errors after releasing the Builder.
Frontend can emit errors when releaseing the Builder. If there are errors before
or when releasing the Builder,
Author: mren
Date: Thu Jan 28 17:36:05 2016
New Revision: 259119
URL: http://llvm.org/viewvc/llvm-project?rev=259119&view=rev
Log:
Class Property: change PropertyMap to include isClassProperty.
PropertyMap used to map IdentifierInfo (name of the property) to
ObjcPropertyDecl *. Now that a class p
Author: mren
Date: Fri Jan 29 13:05:57 2016
New Revision: 259224
URL: http://llvm.org/viewvc/llvm-project?rev=259224&view=rev
Log:
Class Property: parse @dynamic (class).
rdar://23891898
Modified:
cfe/trunk/lib/Parse/ParseObjc.cpp
cfe/trunk/test/SemaObjC/objc-class-property.m
Modified:
Author: mren
Date: Fri Jan 29 13:16:39 2016
New Revision: 259226
URL: http://llvm.org/viewvc/llvm-project?rev=259226&view=rev
Log:
Class Property: warn for synthesize on a class property.
rdar://23891898
Modified:
cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td
cfe/trunk/lib/Sema/Se
Author: mren
Date: Fri Jan 29 13:22:54 2016
New Revision: 259229
URL: http://llvm.org/viewvc/llvm-project?rev=259229&view=rev
Log:
Class Property: generate metadata for class properties in classes.
The list of class properties is saved in
Old ABI: cls->isa->ext->properties
New ABI: cls->isa->ro->
Author: mren
Date: Fri Jan 29 17:45:01 2016
New Revision: 259267
URL: http://llvm.org/viewvc/llvm-project?rev=259267&view=rev
Log:
Class Property: generate metadata for class properties in categories.
The list of class properties is saved in
Old ABI: category->class_properties (category->size wil
Author: mren
Date: Fri Jan 29 17:46:55 2016
New Revision: 259268
URL: http://llvm.org/viewvc/llvm-project?rev=259268&view=rev
Log:
Class Property: generate metadata for class properties in protocols.
The list of class properties is saved in
Old ABI: protocol->ext->class_properties (protocol->ext-
manmanren created this revision.
manmanren added reviewers: rjmccall, rsmith.
manmanren added a subscriber: cfe-commits.
The issue —
Given the following test case, we don’t emit any message, and will silently
ignore the variable "foo2", with a release compiler; we will get an assertio
Author: mren
Date: Wed Dec 16 18:42:36 2015
New Revision: 255860
URL: http://llvm.org/viewvc/llvm-project?rev=255860&view=rev
Log:
[TLS on Darwin] use CXX_FAST_TLS calling convention for access functions.
Also set nounwind attribute.
rdar://problem/9001553
Modified:
cfe/trunk/lib/CodeGen/It
manmanren added a comment.
Ping
Appreciate comments on the general direction.
Cheers,
Manman
http://reviews.llvm.org/D15314
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
201 - 255 of 255 matches
Mail list logo
