r355333 - Order File Instrumentation: add clang support for -forder-file-instrumentation

Author: mren Date: Mon Mar 4 12:30:30 2019 New Revision: 355333 URL: http://llvm.org/viewvc/llvm-project?rev=355333&view=rev Log: Order File Instrumentation: add clang support for -forder-file-instrumentation When -forder-file-instrumentation is on, we pass llvm flag to enable the order file in

r283145 - ObjectiveC: fix a seg fault when deserialing redeclaration of ObjCMethodDecl.

Author: mren Date: Mon Oct 3 16:26:46 2016 New Revision: 283145 URL: http://llvm.org/viewvc/llvm-project?rev=283145&view=rev Log: ObjectiveC: fix a seg fault when deserialing redeclaration of ObjCMethodDecl. The deserialization of redeclartion can cause seg fault since getCanonicalDecl of the re

[PATCH] D25436: [CodeCompletion] Improve completion for properties declared in Objective-C protocols

manmanren added a comment. Thanks for working on this! Manman Comment at: lib/Sema/SemaCodeComplete.cpp:3723 } } else if (!IsArrow && BaseType->getAsObjCInterfacePointerType()) { // Objective-C property reference. I feel like the added logic belong

[PATCH] D25283: AvailabilityAttrs: Refactor context checking when diagnosing an availability violation

manmanren added a comment. This is a nice cleanup! Manman Comment at: lib/Sema/SemaDeclAttr.cpp:6348 + + auto IsContextGreater = [&](const Decl *C) { +if (K == AR_NotYetIntroduced) { Can you add a comment for the lambda? Comment at: lib

[PATCH] D25284: AvailabilityAttrs: Delay partial availability diagnostics

manmanren added a comment. Nice cleanup! Thanks for working on this, Manman Comment at: include/clang/Sema/DelayedDiagnostic.h:232 union { /// Deprecation struct DD DeprecationData; Can you update this comment now we have generalized this to handl

[PATCH] D25436: [CodeCompletion] Improve completion for properties declared in Objective-C protocols

manmanren accepted this revision. manmanren added a comment. This revision is now accepted and ready to land. LGTM. Manman Repository: rL LLVM https://reviews.llvm.org/D25436 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.l

r283943 - Module: for ObjectiveC, be consistent when checking hidden decls.

Author: mren Date: Tue Oct 11 16:18:20 2016 New Revision: 283943 URL: http://llvm.org/viewvc/llvm-project?rev=283943&view=rev Log: Module: for ObjectiveC, be consistent when checking hidden decls. In MatchAllMethodDeclarations, when checking a hidden decl, be sure to allow hidden when searching f

[PATCH] D25519: [CodeCompletion] Refactor: Extract two Objective-C block formatting related functions from FormatFunctionParameter

manmanren added a comment. Cheers, Manman Comment at: lib/Sema/SemaCodeComplete.cpp:2165 +static void findTypeLocationForBlockDecl(const TypeSourceInfo *TSInfo, + FunctionTypeLoc &Block, Please add comments for the help

r284142 - Module: emit initializers for C/ObjC after r276159.

Author: mren Date: Thu Oct 13 13:42:14 2016 New Revision: 284142 URL: http://llvm.org/viewvc/llvm-project?rev=284142&view=rev Log: Module: emit initializers for C/ObjC after r276159. In r276159, we started to defer emitting initializers for VarDecls, but forgot to add the initializers for non-C++

r284263 - Module: emit initializers in submodules when importing the parent module.

Author: mren Date: Fri Oct 14 13:55:44 2016 New Revision: 284263 URL: http://llvm.org/viewvc/llvm-project?rev=284263&view=rev Log: Module: emit initializers in submodules when importing the parent module. When importing the parent module, module initializers in submodules should be emitted. rdar

[PATCH] D25519: [CodeCompletion] Refactor: Extract two Objective-C block formatting related functions from FormatFunctionParameter

manmanren accepted this revision. manmanren added a comment. This revision is now accepted and ready to land. LGTM. Manman Repository: rL LLVM https://reviews.llvm.org/D25519 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.l

[clang] Support MemProf on darwin (PR #69640)

https://github.com/manman-ren created https://github.com/llvm/llvm-project/pull/69640 None >From 86dc0db55bf6aa629639b1beac5c2cf5f39177ec Mon Sep 17 00:00:00 2001 From: Manman Ren Date: Tue, 10 Oct 2023 20:54:07 -0700 Subject: [PATCH 1/2] memprof support on Darwin --- clang/lib/Driver/ToolCh

[clang] Support VFE in thinLTO (PR #69735)

https://github.com/manman-ren created https://github.com/llvm/llvm-project/pull/69735 We add a run of GlobalDCEPass with ImportSummary. When ImportSummary is true, we remove virtual functions in vtables with VCallVisibility not Public. In this run, the regular GlobalDCEPass::AddVirtualFunction

[clang] Support VFE in thinLTO (PR #69735)

https://github.com/manman-ren updated https://github.com/llvm/llvm-project/pull/69735 >From 1adce63e663203f858de86cfa231527ee2284505 Mon Sep 17 00:00:00 2001 From: Manman Ren Date: Thu, 5 Oct 2023 10:56:53 -0700 Subject: [PATCH] Support VFE in thinLTO We add a run of GlobalDCEPass with ImportS

[clang] Support MemProf on darwin (PR #69640)

https://github.com/manman-ren edited https://github.com/llvm/llvm-project/pull/69640 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Port Swift's merge function pass to llvm: merging functions that differ in constants (PR #68235)

https://github.com/manman-ren updated https://github.com/llvm/llvm-project/pull/68235 >From 7e422cecbd5fc28fb0ec699b702d6bccf321f93f Mon Sep 17 00:00:00 2001 From: Manman Ren Date: Mon, 2 Oct 2023 11:16:58 -0700 Subject: [PATCH] Preliminary patch for merging functions that differ in constants

r291465 - PCH: fix a regression that reports a module is defined in both pch and pcm.

Author: mren Date: Mon Jan 9 13:20:18 2017 New Revision: 291465 URL: http://llvm.org/viewvc/llvm-project?rev=291465&view=rev Log: PCH: fix a regression that reports a module is defined in both pch and pcm. In r276159, we started to say that a module X is defined in a pch if we specify -fmodule-n

r291628 - Module: Do not create Implicit ImportDecl for module X if we

Author: mren Date: Tue Jan 10 18:48:19 2017 New Revision: 291628 URL: http://llvm.org/viewvc/llvm-project?rev=291628&view=rev Log: Module: Do not create Implicit ImportDecl for module X if we are building an implemenation of module X. This fixes a regression caused by r280409. rdar://problem/299

Re: r291628 - Module: Do not create Implicit ImportDecl for module X if we

On Tue, Jan 10, 2017 at 5:59 PM, Richard Smith wrote: > On 10 January 2017 at 17:57, Richard Smith wrote: > >> On 10 January 2017 at 16:48, Manman Ren via cfe-commits < >> cfe-commits@lists.llvm.org> wrote: >> >>> Author: mren >>> Date: T

r291688 - This reverts r291628. As suggested by Richard, we can simply

Author: mren Date: Wed Jan 11 12:32:30 2017 New Revision: 291688 URL: http://llvm.org/viewvc/llvm-project?rev=291688&view=rev Log: This reverts r291628. As suggested by Richard, we can simply filter out the implicilty imported modules at CodeGen instead of removing the implicit ImportDecl when an

r291689 - Module: Do not add any link flags when an implementation TU of a module imports

Author: mren Date: Wed Jan 11 12:47:38 2017 New Revision: 291689 URL: http://llvm.org/viewvc/llvm-project?rev=291689&view=rev Log: Module: Do not add any link flags when an implementation TU of a module imports a header of that same module. This fixes a regression caused by r280409. rdar://proble

r278742 - Objective-C diagnostics: isObjCNSObjectType should check through AttributedType.

Author: mren Date: Mon Aug 15 16:05:00 2016 New Revision: 278742 URL: http://llvm.org/viewvc/llvm-project?rev=278742&view=rev Log: Objective-C diagnostics: isObjCNSObjectType should check through AttributedType. For the following example: typedef __attribute__((NSObject)) CGColorRef ColorAttrRef;

Re: [PATCH] D23003: [ObjC Availability] Warn upon unguarded use of partially available declaration

manmanren accepted this revision. manmanren added a comment. This revision is now accepted and ready to land. > This is done so containers, such as `vector` can be used > safely provided `partially_available` is safe at the point of instantiation. > I think the way to improve this is in `Sema:

Re: [PATCH] D22929: [CodeGen][ObjC] Fix infinite recursion in getObjCEncodingForTypeImpl

manmanren added a subscriber: manmanren. manmanren added a comment. The fix looks reasonable to me. Cheers, Manman Comment at: test/CodeGenObjCXX/encode.mm:231 @@ +230,3 @@ +struct S { + typedef T Ty; + Ty *t; I wonder if we can further reduce the testing cas

Re: [PATCH] D22794: [Sema] Propagate nullability when deducing type of auto

manmanren added a subscriber: manmanren. Comment at: lib/Sema/SemaDecl.cpp:9739 @@ +9738,3 @@ + DeducedType = DeducedType.setNullability( + Init->getType()->getNullability(Context), Context); + Do we propagate other attributes for deduced types? ht

Re: [PATCH] D22929: [CodeGen][ObjC] Fix infinite recursion in getObjCEncodingForTypeImpl

manmanren accepted this revision. manmanren added a reviewer: manmanren. manmanren added a comment. This revision is now accepted and ready to land. LGTM. Manman https://reviews.llvm.org/D22929 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

Re: [PATCH] D23125: Modules: add command line option to support loading prebuilt modules on demand, without parsing any module map

manmanren added a comment. Richard, Are you okay with the patch now? Thanks, Manman https://reviews.llvm.org/D23125 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23125: Modules: add command line option to support loading prebuilt modules on demand, without parsing any module map

manmanren updated this revision to Diff 68442. https://reviews.llvm.org/D23125 Files: docs/Modules.rst include/clang/Basic/DiagnosticCommonKinds.td include/clang/Driver/Options.td include/clang/Lex/HeaderSearch.h include/clang/Lex/HeaderSearchOptions.h include/clang/Serialization/Modu

Re: [PATCH] D23125: Modules: add command line option to support loading prebuilt modules on demand, without parsing any module map

manmanren added a comment. Thanks, Manman Comment at: lib/Frontend/CompilerInstance.cpp:1502 @@ +1501,3 @@ +Module = PP->getHeaderSearchInfo().lookupModule(ModuleName); +if (!Module) { + getDiagnostics().Report(ModuleNameLoc, diag::err_module_prebuilt)

Re: [PATCH] D23125: Modules: add command line option to support loading prebuilt modules on demand, without parsing any module map

manmanren updated this revision to Diff 68456. https://reviews.llvm.org/D23125 Files: docs/Modules.rst include/clang/Basic/DiagnosticCommonKinds.td include/clang/Driver/Options.td include/clang/Lex/HeaderSearch.h include/clang/Lex/HeaderSearchOptions.h include/clang/Serialization/Modu

Re: [PATCH] D23125: Modules: add command line option to support loading prebuilt modules on demand, without parsing any module map

manmanren added a comment. Cheers, Manman Comment at: lib/Frontend/CompilerInstance.cpp:1502 @@ +1501,3 @@ +Module = PP->getHeaderSearchInfo().lookupModule(ModuleName); +if (!Module || !Module->getASTFile() || +std::string(Module->getASTFile()->getNa

Re: [PATCH] D23125: Modules: add command line option to support loading prebuilt modules on demand, without parsing any module map

manmanren added inline comments. Comment at: lib/Frontend/CompilerInstance.cpp:1503 @@ +1502,3 @@ +if (!Module || !Module->getASTFile() || +std::string(Module->getASTFile()->getName()) != ModuleFileName) { + // Error out if Module does not refer to the

r279096 - Module: add -fprebuilt-module-path to support loading prebuilt modules.

Author: mren Date: Thu Aug 18 12:42:15 2016 New Revision: 279096 URL: http://llvm.org/viewvc/llvm-project?rev=279096&view=rev Log: Module: add -fprebuilt-module-path to support loading prebuilt modules. In this mode, there is no need to load any module map and the programmer can simply use "@impo

r279351 - [NFC] Add a class ObjCProtocolQualifiers to wrap APIs for ObjC protocol list.

Author: mren Date: Fri Aug 19 19:04:21 2016 New Revision: 279351 URL: http://llvm.org/viewvc/llvm-project?rev=279351&view=rev Log: [NFC] Add a class ObjCProtocolQualifiers to wrap APIs for ObjC protocol list. This is in preparation of adding a new type class ObjCTypeParamType that can take protoc

Re: [PATCH] D23080: ObjC: Use a new type for ObjC type parameter (patch 3 out of 3)

manmanren added a comment. I will update this patch once the 2nd patch is done. Thanks for reviewing, Manman Comment at: lib/AST/Type.cpp:1095 @@ +1094,3 @@ +return ctx.getQualifiedType(argType, splitType.Quals); + // Apply protocol lists if exists. Should

Re: [PATCH] D23079: ObjC: Use a new type for ObjC type parameter (patch 2 out of 3)

manmanren added a comment. Thanks for reviewing! Manman Comment at: include/clang/AST/RecursiveASTVisitor.h:1037 @@ -1036,1 +1036,3 @@ +DEF_TRAVERSE_TYPE(ObjCTypeParamType, {}) + doug.gregor wrote: > I'm sorta shocked that we don't visit the protocol qualifie

r279357 - Fix windows bot

Author: mren Date: Fri Aug 19 21:28:15 2016 New Revision: 279357 URL: http://llvm.org/viewvc/llvm-project?rev=279357&view=rev Log: Fix windows bot Modified: cfe/trunk/include/clang/AST/Type.h Modified: cfe/trunk/include/clang/AST/Type.h URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/inc

r279358 - Revert r279351 and r279357 due to bot failures

Author: mren Date: Fri Aug 19 22:00:54 2016 New Revision: 279358 URL: http://llvm.org/viewvc/llvm-project?rev=279358&view=rev Log: Revert r279351 and r279357 due to bot failures Modified: cfe/trunk/include/clang/AST/Type.h cfe/trunk/lib/AST/Type.cpp Modified: cfe/trunk/include/clang/AST/

[PATCH] D23858: Don't diagnose non-modular includes when we are not compiling a module

manmanren created this revision. manmanren added reviewers: rsmith, benlangmuir. manmanren added a subscriber: cfe-commits. We used to have -fmodule-implementation-of and it was merged with -fmodule-name. But this causes some regression on our internal projects. We are now seeing non-modular inc

Re: [PATCH] D23858: Don't diagnose non-modular includes when we are not compiling a module

manmanren added a comment. In https://reviews.llvm.org/D23858#525647, @rsmith wrote: > It seems to me like this is papering over an issue rather than fixing it. I guess that is why we introduced fmodule-implementation-of, to work around issues like "relative includes to a VFS-mapped module". B

r279838 - Don't diagnose non-modular includes when we are not compiling a module.

Author: mren Date: Fri Aug 26 12:16:46 2016 New Revision: 279838 URL: http://llvm.org/viewvc/llvm-project?rev=279838&view=rev Log: Don't diagnose non-modular includes when we are not compiling a module. This is triggered when we are compiling an implementation of a module, it has relative include

Re: [PATCH] D23079: ObjC: Use a new type for ObjC type parameter (patch 2 out of 3)

manmanren updated this revision to Diff 69764. manmanren added a comment. Address Doug's comment. ObjCTypeParamType is a non-canonical type now, it is canonicalized to the underlying type with protocol qualifiers. https://reviews.llvm.org/D23079 Files: include/clang/AST/ASTContext.h includ

Re: [PATCH] D23080: ObjC: Use a new type for ObjC type parameter (patch 3 out of 3)

manmanren updated the summary for this revision. manmanren updated this revision to Diff 69765. manmanren added a comment. This patch is now much simpler with the updated version of https://reviews.llvm.org/D23079. https://reviews.llvm.org/D23080 Files: lib/AST/ASTContext.cpp lib/AST/DeclO

[PATCH] D24059: NFC: refactor applyObjCProtocolQualifiers from SemaType.cpp to ASTContext so it can be shared.

manmanren created this revision. manmanren added a reviewer: doug.gregor. manmanren added a subscriber: cfe-commits. To construct the canonical type of ObjCTypeParamType, we need to apply qualifiers on ObjCObjectPointerType. The updated applyObjCProtocolQualifiers handles this case by merging th

r280728 - Modules: Fix an assertion in DeclContext::buildLookup.

Author: mren Date: Tue Sep 6 13:16:54 2016 New Revision: 280728 URL: http://llvm.org/viewvc/llvm-project?rev=280728&view=rev Log: Modules: Fix an assertion in DeclContext::buildLookup. When calling getMostRecentDecl, we can pull in more definitions from a module. We call getPrimaryContext afterw

Re: r280728 - Modules: Fix an assertion in DeclContext::buildLookup.

On Tue, Sep 6, 2016 at 6:54 PM, Richard Smith wrote: > On Tue, Sep 6, 2016 at 11:16 AM, Manman Ren via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: mren >> Date: Tue Sep 6 13:16:54 2016 >> New Revision: 280728 >> >> URL: http://llv

Re: r280728 - Modules: Fix an assertion in DeclContext::buildLookup.

On Wed, Sep 7, 2016 at 4:44 PM, Richard Smith wrote: > On Wed, Sep 7, 2016 at 12:45 PM, Manman Ren wrote: > >> On Tue, Sep 6, 2016 at 6:54 PM, Richard Smith >> wrote: >> >>> On Tue, Sep 6, 2016 at 11:16 AM, Manman Ren via cfe-commits < >>> cfe-c

Re: r280728 - Modules: Fix an assertion in DeclContext::buildLookup.

On Fri, Sep 9, 2016 at 11:33 AM, Richard Smith wrote: > On Fri, Sep 9, 2016 at 11:29 AM, Manman Ren via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> On Wed, Sep 7, 2016 at 4:44 PM, Richard Smith >> wrote: >> >>> On Wed, Sep 7, 2016 at 12:45

r281078 - Modules: revert r280728.

Author: mren Date: Fri Sep 9 14:03:07 2016 New Revision: 281078 URL: http://llvm.org/viewvc/llvm-project?rev=281078&view=rev Log: Modules: revert r280728. In post-commit review, Richard suggested a better way to fix this. rdar://27926200 Removed: cfe/trunk/test/Modules/Inputs/lookup-assert/

Re: [PATCH] D23079: ObjC: Use a new type for ObjC type parameter (patch 2 out of 3)

manmanren added a comment. Hi Doug, Can you take a look at the updated version? Thanks, Manman https://reviews.llvm.org/D23079 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r281119 - Modules: for ObjectiveC try to keep the definition invariant.

Author: mren Date: Fri Sep 9 18:48:27 2016 New Revision: 281119 URL: http://llvm.org/viewvc/llvm-project?rev=281119&view=rev Log: Modules: for ObjectiveC try to keep the definition invariant. When deserializing ObjCInterfaceDecl with definition data, if we already have a definition, try to keep

Re: r280728 - Modules: Fix an assertion in DeclContext::buildLookup.

Committed r281119. Let me know if you see any problem. Cheers, Manman On Fri, Sep 9, 2016 at 12:07 PM, Manman Ren wrote: > > > On Fri, Sep 9, 2016 at 11:33 AM, Richard Smith > wrote: > >> On Fri, Sep 9, 2016 at 11:29 AM, Manman Ren via cfe-commits < >> cfe

r281351 - Add a class ObjCProtocolQualifiers to wrap APIs for ObjC protocol list.

Author: mren Date: Tue Sep 13 11:45:29 2016 New Revision: 281351 URL: http://llvm.org/viewvc/llvm-project?rev=281351&view=rev Log: Add a class ObjCProtocolQualifiers to wrap APIs for ObjC protocol list. Now ObjCObjectType extends from ObjCProtocolQualifiers. We save number of protocols in ObjCPro

r281353 - ObjectiveC: Refactor applyObjCProtocolQualifiers.

Author: mren Date: Tue Sep 13 12:03:12 2016 New Revision: 281353 URL: http://llvm.org/viewvc/llvm-project?rev=281353&view=rev Log: ObjectiveC: Refactor applyObjCProtocolQualifiers. To construct the canonical type of ObjCTypeParamType, we need to apply qualifiers on ObjCObjectPointerType. The upda

r281355 - ObjectiveC generics: Add ObjCTypeParamType in the type system.

Author: mren Date: Tue Sep 13 12:25:08 2016 New Revision: 281355 URL: http://llvm.org/viewvc/llvm-project?rev=281355&view=rev Log: ObjectiveC generics: Add ObjCTypeParamType in the type system. We also need to add ObjCTypeParamTypeLoc. ObjCTypeParamType supports the representation of "T " where T

r281358 - ObjectiveC Generics: Start using ObjCTypeParamType.

Author: mren Date: Tue Sep 13 12:41:05 2016 New Revision: 281358 URL: http://llvm.org/viewvc/llvm-project?rev=281358&view=rev Log: ObjectiveC Generics: Start using ObjCTypeParamType. For ObjC type parameter, we used to have TypedefType that is canonicalized to id or the bound type. We can't repre

r281404 - ObjectiveC Generics: follow-up commit to r281355.

Author: mren Date: Tue Sep 13 16:57:28 2016 New Revision: 281404 URL: http://llvm.org/viewvc/llvm-project?rev=281404&view=rev Log: ObjectiveC Generics: follow-up commit to r281355. Correct getExtraLocalDataSize for ObjCTypeParamTypeLoc. rdar://24619481 rdar://25060179 Modified: cfe/trunk/in

r292508 - Module: Improve diagnostic message when cxx modules are disabled and @import is used in Objective CXX.

Author: mren Date: Thu Jan 19 13:05:55 2017 New Revision: 292508 URL: http://llvm.org/viewvc/llvm-project?rev=292508&view=rev Log: Module: Improve diagnostic message when cxx modules are disabled and @import is used in Objective CXX. rdar://problem/19399671 Added: cfe/trunk/test/Modules/che

Re: r292508 - Module: Improve diagnostic message when cxx modules are disabled and @import is used in Objective CXX.

On Thu, Jan 19, 2017 at 1:27 PM, Richard Smith wrote: > On 19 Jan 2017 11:16 am, "Manman Ren via cfe-commits" < > cfe-commits@lists.llvm.org> wrote: > > Author: mren > Date: Thu Jan 19 13:05:55 2017 > New Revision: 292508 > > URL: http://llvm.org/viewv

r292639 - Revert r292508 given that we intend to remove driver options for cxx modules.

Author: mren Date: Fri Jan 20 14:03:00 2017 New Revision: 292639 URL: http://llvm.org/viewvc/llvm-project?rev=292639&view=rev Log: Revert r292508 given that we intend to remove driver options for cxx modules. Removed: cfe/trunk/test/Modules/check-syntax.mm Modified: cfe/trunk/include/clan

[PATCH] D25916: Modules: emit an error instead of a random crash (or a misleading error) due to use-after-free.

manmanren added a comment. @ Ben, We are hitting this issue when building large projects, but the reproducibility is quite low. This proposed patch is currently a little too complicated. I am thinking about just fixing the testing case for now, and adding the check later when we start to shar

[PATCH] D25916: Modules: emit an error instead of a random crash (or a misleading error) due to use-after-free.

manmanren added a comment. In https://reviews.llvm.org/D25916#594844, @benlangmuir wrote: > > Does it mean that a system module should only import system modules? If a > > system module is allowed to import non-system modules, for a non-system > > module, we will validate diagnostic options dif

[PATCH] D26503: [Parser][ObjC] Improve diagnostics and recovery when C++ keywords are used as identifiers in Objective-C++

manmanren added a comment. Cheers, Manman Comment at: include/clang/Basic/DiagnosticParseKinds.td:442 +/// Objective-C++ parser diagnostics +def err_expected_objcxx_keyword : Error< + "expected %0; %1 is a keyword in Objective-C++">; This name is a little misl

r287244 - ObjC Module: try to make objc module deterministic.

Author: mren Date: Thu Nov 17 12:41:18 2016 New Revision: 287244 URL: http://llvm.org/viewvc/llvm-project?rev=287244&view=rev Log: ObjC Module: try to make objc module deterministic. Make sure that comparing selectors in DeclarationName does its job. rdar://problem/28988750 Added: cfe/trunk/

[PATCH] D25284: AvailabilityAttrs: Delay partial availability diagnostics

manmanren accepted this revision. manmanren added a comment. This revision is now accepted and ready to land. This is better than what I asked for :] Manman https://reviews.llvm.org/D25284 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D25678: [modules] Do not report missing definitions of demoted constexpr variable templates.This is a followup to regression introduced in r284284.This should fix our libstdc++ modules builds.

manmanren added inline comments. Comment at: lib/Sema/SemaDecl.cpp:10129 +!Var->isThisDeclarationADemotedDefinition()) { + assert(Var->isThisDeclarationADemotedDefinition() && getLangOpts().Modules + && "Demoting decls is only in the contest of modules!"

[PATCH] D22638: Module: add debug_type to dump debugging messages related to modules being out of date

manmanren added a comment. Thanks a lot for the pointers! I will definitely try them. What I proposed here is something similar to what llvm does that dumps logging messages, it should be complementary to your debugging aids. Manman In https://reviews.llvm.org/D22638#572753, @v.g.vassilev wro

[PATCH] D25777: [Sema][TreeTransform] Re-create DesignatedInitExpr when it has a field designator with a valid FieldDecl

manmanren added a comment. It makes sense to rebuild the expression when a field designator stores a FieldDecl. Thanks for working on this! Manman Comment at: lib/Sema/TreeTransform.h:8926 D.getFieldLoc())); + if (D.getFiel

[PATCH] D25806: Module: correctly set the module file kind when emitting diagnostics for file_modified

manmanren created this revision. manmanren added reviewers: bruno, rsmith, benlangmuir. manmanren added a subscriber: cfe-commits. I don't quite like the if statement in the patch, but given that ASTReader::Error and DelayedDiagnostic only take strings, it is hard to just change err_fe_pch_file_

[PATCH] D25806: Module: correctly set the module file kind when emitting diagnostics for file_modified

manmanren updated this revision to Diff 75326. manmanren added a comment. Thanks Richard for the testing case. It is also obvious from the testing case that we can have another diagnostic in flight when emitting err_fe_pch_file_modified. https://reviews.llvm.org/D25806 Files: include/clang/

r284897 - Module: improve the diagnostic message for include of non-modular header.

Author: mren Date: Fri Oct 21 18:27:37 2016 New Revision: 284897 URL: http://llvm.org/viewvc/llvm-project?rev=284897&view=rev Log: Module: improve the diagnostic message for include of non-modular header. Emit the actual path to the non-modular include. rdar://28897010 Modified: cfe/trunk/i

r284899 - Module: correctly set the module file kind when emitting file_modified.

Author: mren Date: Fri Oct 21 18:35:03 2016 New Revision: 284899 URL: http://llvm.org/viewvc/llvm-project?rev=284899&view=rev Log: Module: correctly set the module file kind when emitting file_modified. rdar://28503343 Differential Revision: http://reviews.llvm.org/D25806 Added: cfe/trunk/t

[PATCH] D25916: Modules: emit an error instead of a random crash (or a misleading error) due to use-after-free.

manmanren created this revision. manmanren added reviewers: benlangmuir, rsmith. manmanren added a subscriber: cfe-commits. With implicit modules, it is hard to debug issues that depend on state of the module cache before the clang invocation. The state of the module cache can be changed by othe

[PATCH] D25916: Modules: emit an error instead of a random crash (or a misleading error) due to use-after-free.

manmanren added a comment. In this testing case, the first clang invocation builds a system module X and a non-system module Y (X imports Y). At the second clang invocation, the parent thread validates the existing module X and module Y. Because X is a system module, we don't diagnose the diffe

[PATCH] D25993: [Objective-C] Add objc_subclassing_restricted attribute

manmanren accepted this revision. manmanren added a reviewer: manmanren. manmanren added a comment. This revision is now accepted and ready to land. LGTM. Manman Repository: rL LLVM https://reviews.llvm.org/D25993 ___ cfe-commits mailing list cf

[PATCH] D26071: [CodeCompletion] Show block invocation result for block property setters

manmanren accepted this revision. manmanren added a comment. This revision is now accepted and ready to land. LGTM. Manman Repository: rL LLVM https://reviews.llvm.org/D26071 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.l

[libcxx] r249926 - Revert r249889 due to bot failure.

Author: mren Date: Fri Oct 9 20:03:55 2015 New Revision: 249926 URL: http://llvm.org/viewvc/llvm-project?rev=249926&view=rev Log: Revert r249889 due to bot failure. Removed: libcxx/trunk/include/wchar.h Modified: libcxx/trunk/include/cwchar libcxx/trunk/test/std/depr/depr.c.headers/w

Re: [libcxx] r249929 - Split out of .

Hi Richard, This is causing a failure when building povray on iOS. Compilation error: /Users/buildslave/tmp/test-suite-externals/speccpu2006/benchspec/CPU2006/453.povray/src/fileinputoutput.cpp:364:20: error: call to 'strrchr' is ambiguous const char *p=strrchr(name, '.’); iOS.sdk/usr/incl

Re: [libcxx] r249929 - Split out of .

ang feature to let us fix the > bad signature). > > Can you elaborate on how to fix the bad signature by adding a Clang feature? I want to see how hard it is before giving up on trying to fix the signatures. Thanks, Manman > On Oct 15, 2015 11:07 AM, "Manman Ren via cfe-commit

Re: [libcxx] r249929 - Split out of .

> On Oct 15, 2015, at 1:41 PM, Richard Smith wrote: > > On Thu, Oct 15, 2015 at 12:03 PM, Manman Ren via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: > >> On Oct 15, 2015, at 11:25 AM, Richard Smith > <mailto:rich...@metafoo.co.uk>> wrote: &

Stage 2 bot failure: clang-stage2-configure-Rlto_check

There are 33 commits picked up in this run and we have 107 test failures. This happened at 2pm today. I wonder if any one knows what is going on. http://lab.llvm.org:8080/green/job/clang-stage2-configure-Rlto_check/6222/ http://lab.llvm.org:8080/green/job/clang-stage2-configure-Rlto_check/6222

Re: [clang-tools-extra] r250939 - [clang-tidy] add check cppcoreguidelines-pro-type-vararg

It seems that this commit breaks the following bot http://lab.llvm.org:8080/green/job/clang-stage1-configure-RA_check/12461/ Manman > On Oct 21, 2015, at 1:09 PM, Matthias Gehre via cfe-commits > wrote: > > Author: mg

Re: [PATCH] D13304: Avoid inlining in throw statement

manmanren added a subscriber: manmanren. manmanren added a comment. Inliner currently does not include analysis passes such as BPI and BFI. With the new pass manager, we should be able to hook up inliner with BFI (and we can handle throw in BFI). Before that, maybe we can add this as part of inl

r252777 - [TLS] move setting tls_guard in tls_init.

Author: mren Date: Wed Nov 11 13:19:26 2015 New Revision: 252777 URL: http://llvm.org/viewvc/llvm-project?rev=252777&view=rev Log: [TLS] move setting tls_guard in tls_init. We used to emit the store prior to branch in the entry block. To make it more efficient, this commit moves it to the init bl

r252814 - [TLS on Darwin] change how we handle globals with linkonce or weak linkage.

Author: mren Date: Wed Nov 11 16:42:31 2015 New Revision: 252814 URL: http://llvm.org/viewvc/llvm-project?rev=252814&view=rev Log: [TLS on Darwin] change how we handle globals with linkonce or weak linkage. This is about how we handle static member of a template. Before this commit, we use intern

r252820 - [TLS on Darwin] treat all Darwin platforms in the same way.

Author: mren Date: Wed Nov 11 17:08:18 2015 New Revision: 252820 URL: http://llvm.org/viewvc/llvm-project?rev=252820&view=rev Log: [TLS on Darwin] treat all Darwin platforms in the same way. rdar://problem/9001553 Modified: cfe/trunk/lib/CodeGen/CodeGenModule.cpp cfe/trunk/lib/CodeGen/It

Re: [PATCH] D22183: [SemObjC] Fix TypoExpr handling in TransformObjCDictionaryLiteral

manmanren accepted this revision. manmanren added a comment. This revision is now accepted and ready to land. LGTM. Manman Comment at: lib/Parse/ParseObjc.cpp:3489 @@ -3478,3 +3488,3 @@ -// Parse the ellipsis that designates this as a pack expansion. -SourceLocati

[PATCH] D22636: Module: retry building modules that were just compiled by the same instance and are are out of date

manmanren created this revision. manmanren added reviewers: benlangmuir, rsmith. manmanren added a subscriber: cfe-commits. Even though this instance just built module "A", it is likely that "A" imports another module "B" and B.pcm becomes out of date when we try to load module "A", because anot

[PATCH] D22638: Module: add debug_type to dump debugging messages related to modules being out of date

manmanren created this revision. manmanren added reviewers: benlangmuir, rsmith. manmanren added a subscriber: cfe-commits. This is a patch I applied internally to debug out-of-date issues. In general is this the right way to add debugging messages in clang frontend? https://reviews.llvm.org/D2

Re: [PATCH] D22636: Module: retry building modules that were just compiled by the same instance and are are out of date

manmanren added a comment. In https://reviews.llvm.org/D22636#491679, @benlangmuir wrote: > > B.pcm becomes out of date when we try to load module "A", because another > > instance overwrites "B.pcm" > > > How can this happen? We intentionally keep the file descriptors of modules > open. If y

Re: [PATCH] D22542: [CodeGen] Fix a crash on valid when constant folding 'default:' statement in switch

manmanren accepted this revision. manmanren added a comment. This revision is now accepted and ready to land. LGTM. Manman https://reviews.llvm.org/D22542 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman

Re: [PATCH] D22636: Module: retry building modules that were just compiled by the same instance and are are out of date

manmanren added a comment. In https://reviews.llvm.org/D22636#493072, @benlangmuir wrote: > > Can you point me to the source codes where we use rename to replace the > > file? I am curious on how this all works out. > > > This is the same as clang's handling of other output files. See > {{Comp

[PATCH] D22773: Modules: add command line option fmodules-disable-diagnostic-validation to disable validation of the diagnostic options when loading the module

manmanren created this revision. manmanren added a reviewer: benlangmuir. manmanren added a subscriber: cfe-commits. With PCH+Module, sometimes compiler gives a hard error: "Module file ‘.pcm' is out of date and needs to be rebuilt" This happens when we have a PCH importing a module and the modul

Re: [PATCH] D22697: [ObjC Availability] Consider lexical context of use of declaration when emitting availability diagnostics

manmanren accepted this revision. manmanren added a comment. This revision is now accepted and ready to land. LGTM except one nit. Manman Comment at: include/clang/Sema/Sema.h:9595 @@ -9594,1 +9594,3 @@ + + VersionTuple getCurContextVersion() const; Can yo

Re: [PATCH] D22773: Modules: add command line option fmodules-disable-diagnostic-validation to disable validation of the diagnostic options when loading the module

manmanren added a comment. In https://reviews.llvm.org/D22773#495403, @benlangmuir wrote: > We need to add this option to the module hash (see getModuleHash - we already > add a bunch of other HSOpts there). Otherwise the pcm could still be > rewritten by a compilation that doesn't use a PCH,

Re: [PATCH] D22773: Modules: add command line option fmodules-disable-diagnostic-validation to disable validation of the diagnostic options when loading the module

manmanren added a comment. In https://reviews.llvm.org/D22773#495524, @benlangmuir wrote: > > the pcm could still be rewritten by a compilation that doesn't use a PCH, > > and then it would be out of date because of the timestamp instead of the > > diagnostic options > > > > > > "a compilation

Re: [PATCH] D22773: Modules: add command line option fmodules-disable-diagnostic-validation to disable validation of the diagnostic options when loading the module

manmanren updated this revision to Diff 65449. manmanren added a comment. Addressing Ben's comments https://reviews.llvm.org/D22773 Files: include/clang/Driver/Options.td include/clang/Lex/HeaderSearchOptions.h include/clang/Serialization/ASTReader.h lib/Frontend/CompilerInvocation.cpp

r276769 - Modules: add command line option fmodules-disable-diagnostic-validation

Author: mren Date: Tue Jul 26 12:12:17 2016 New Revision: 276769 URL: http://llvm.org/viewvc/llvm-project?rev=276769&view=rev Log: Modules: add command line option fmodules-disable-diagnostic-validation With PCH+Module, sometimes compiler gives a hard error: Module file ‘.pcm' is out of date and

r276797 - Modules: follow up to r276769.

Author: mren Date: Tue Jul 26 14:56:12 2016 New Revision: 276797 URL: http://llvm.org/viewvc/llvm-project?rev=276797&view=rev Log: Modules: follow up to r276769. In r276769, I forgot to forward the driver option, add that here. rdar://26675801 Modified: cfe/trunk/lib/Driver/Tools.cpp Modif

Re: [PATCH] D22636: Module: retry building modules that were just compiled by the same instance and are are out of date

manmanren abandoned this revision. manmanren added a comment. Abandon this change for now. https://reviews.llvm.org/D22636 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   3   >