[PATCH] D66122: [CodeGen] Emit dynamic initializers for static TLS vars in outlined scopes

mgrang added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:472 + + llvm::sort(OrderedVarInits.begin(), OrderedVarInits.end(), + [&VarInitDependencies](const VarDecl *a, const VarDecl *b) { You can use the range-based version of llvm::so

[PATCH] D59279: [Analyzer] Checker for non-determinism caused by iteration of unordered container of pointers

This revision was automatically updated to reflect the committed changes. Closed by commit rL361664: [Analyzer] Checker for non-determinism caused by iteration of unordered… (authored by mgrang, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior t

[PATCH] D53541: [COFF, ARM64] Do not emit x86_seh_recoverfp intrinsic

mgrang updated this revision to Diff 181106. mgrang retitled this revision from "[COFF, ARM64] Support SEH for ARM64 Windows" to "[COFF, ARM64] Do not emit x86_seh_recoverfp intrinsic". CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53541/new/ https://reviews.llvm.org/D53541 Files: lib

[PATCH] D53541: [COFF, ARM64] Do not emit x86_seh_recoverfp intrinsic

mgrang added a comment. In D53541#1282900 , @rnk wrote: > In D53541#1282764 , @mgrang wrote: > > > Updated the patch with the following changes: > > > > 1. Emit llvm.x86.seh.recoverfp only for non-aarch64 targets. F

[PATCH] D45237: [RISCV] Fix logic to check if frame pointer should be used

This revision was automatically updated to reflect the committed changes. Closed by commit rL329941: [RISCV] Fix logic to check if frame pointer should be used (authored by mgrang, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D45237?

[PATCH] D39053: [Bitfield] Add more cases to making the bitfield a separate location

mgrang added a comment. Added @apazos and myself a reviewers since this is something we would be interested in getting to work. https://reviews.llvm.org/D39053 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

[PATCH] D39053: [Bitfield] Add more cases to making the bitfield a separate location

mgrang added a comment. With this patch we get ~1800 bytes improvement on one of our internal codebases. I also ran spec2000/spec2006 validations (for RISCV) and there were no regressions. There were also no code size improvements seen in spec. https://reviews.llvm.org/D39053 __

[PATCH] D39053: [Bitfield] Add more cases to making the bitfield a separate location

mgrang added a comment. Here is a test case which improves with this patch (for RISCV target). It is able to detect load/store halfword for size 16 bitfields. struct st { int a:1; int b:8; int c:11; int d:12; int e:16; int f:16; int g:16; } S; void foo(int x)

[PATCH] D48862: Fix lib paths for OpenEmbedded targets

mgrang created this revision. mgrang added reviewers: dlj, rengolin, fedor.sergeev. Herald added a reviewer: javed.absar. Herald added a subscriber: kristof.beyls. The lib paths are not correctly picked up for OpenEmbedded sysroots (like arm-oe-linux-gnueabi) for 2 reasons: 1. OpenEmbedded sysro

[PATCH] D48862: Fix lib paths for OpenEmbedded targets

mgrang updated this revision to Diff 153845. https://reviews.llvm.org/D48862 Files: lib/Driver/ToolChains/Gnu.cpp lib/Driver/ToolChains/Linux.cpp test/Driver/Inputs/openembedded_aarch64_linux_tree/usr/lib64/aarch64-oe-linux/6.3.0/crtbegin.o test/Driver/Inputs/openembedded_aarch64_linux_

[PATCH] D48862: Fix lib paths for OpenEmbedded targets

mgrang added a comment. The prerequisite llvm patch has been committed: r336401 https://reviews.llvm.org/D48862 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D48862: Fix lib paths for OpenEmbedded targets

mgrang added a comment. Ping for reviews, please. https://reviews.llvm.org/D48862 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D48862: Fix lib paths for OpenEmbedded targets

mgrang updated this revision to Diff 155112. mgrang added a reviewer: hfinkel. mgrang added a comment. Added tests for C++ headers search. https://reviews.llvm.org/D48862 Files: lib/Driver/ToolChains/Gnu.cpp lib/Driver/ToolChains/Linux.cpp test/Driver/Inputs/openembedded_aarch64_linux_tr

[PATCH] D48862: [OpenEmbedded] Fix lib paths for OpenEmbedded targets

mgrang added a comment. Ping 2 for reviews please. https://reviews.llvm.org/D48862 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D48862: [OpenEmbedded] Fix lib paths for OpenEmbedded targets

mgrang added a comment. Ping 3 for reviews please. https://reviews.llvm.org/D48862 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D78853: [Sema] Fix null pointer dereference warnings [1/n]

mgrang created this revision. mgrang added reviewers: rsmith, efriedma, rnk, dblaikie. Running the PREfast static analysis tool on clang resulted in several null pointer dereference warnings. This is the first of several patches to fix these. The full list of warnings reported is here: https://d

[PATCH] D78853: [Sema] Fix null pointer dereference warnings [1/n]

mgrang added a comment. In D78853#2003866 , @efriedma wrote: > Please don't add null checks for pointers that can't be null. It makes the > code slower and harder to understand. And least one of the checks you added > is actively breaking the code. > >

[PATCH] D78853: [Analysis] Fix null pointer dereference warnings [1/n]

mgrang updated this revision to Diff 260517. mgrang retitled this revision from "[Sema] Fix null pointer dereference warnings [1/n]" to "[Analysis] Fix null pointer dereference warnings [1/n]". CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78853/new/ https://reviews.llvm.org/D78853 File

[PATCH] D39947: [OpenMP] Stable sort Privates to remove non-deterministic ordering

This revision was automatically updated to reflect the committed changes. Closed by commit rL319222: [OpenMP] Stable sort Privates to remove non-deterministic ordering (authored by mgrang). Changed prior to commit: https://reviews.llvm.org/D39947?vs=122751&id=124622#toc Repository: rL LLVM

[PATCH] D40618: [SourceLocations] Use stronger sort predicate to remove non-deterministic ordering

mgrang created this revision. This fixes the following failure uncovered by https://reviews.llvm.org/D39245: Clang :: Index/getcursor-preamble.m Repository: rC Clang https://reviews.llvm.org/D40618 Files: tools/libclang/CIndex.cpp Index: tools/libclang/CIndex.cpp =

[PATCH] D40618: [SourceLocations] Use stronger sort predicate to remove non-deterministic ordering

mgrang added inline comments. Comment at: tools/libclang/CIndex.cpp:1028 SourceLocation L_B = B->getLocStart(); -assert(L_A.isValid() && L_B.isValid()); -return SM.isBeforeInTranslationUnit(L_A, L_B); +return L_A != L_B ? + SM.isBeforeInTranslationUnit(

[PATCH] D40618: [SourceLocations] Use stronger sort predicate to remove non-deterministic ordering

This revision was automatically updated to reflect the committed changes. Closed by commit rL319357: [SourceLocations] Use stronger sort predicate to remove non-deterministic… (authored by mgrang). Changed prior to commit: https://reviews.llvm.org/D40618?vs=124798&id=124804#toc Repository: r

[PATCH] D40618: [SourceLocations] Use stronger sort predicate to remove non-deterministic ordering

This revision was automatically updated to reflect the committed changes. Closed by commit rC319357: [SourceLocations] Use stronger sort predicate to remove non-deterministic… (authored by mgrang). Repository: rC Clang https://reviews.llvm.org/D40618 Files: tools/libclang/CIndex.cpp Index

[PATCH] D39963: [RISCV][RFC] Add initial RISC-V target and driver support

mgrang added inline comments. Comment at: lib/Driver/ToolChains/Arch/RISCV.cpp:47 +Features.push_back("+d"); +break; + } Can you also add a case for pushing back +c here? https://reviews.llvm.org/D39963 __

[PATCH] D36098: [AArch64] Don't define __LP64__ when targeting Windows

mgrang accepted this revision. mgrang added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D36098 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

[PATCH] D36111: [COFF, ARM64] Add MS builtins __dmb, __dsb, __isb

mgrang created this revision. Herald added subscribers: kristof.beyls, javed.absar, aemerson. https://reviews.llvm.org/D36111 Files: include/clang/Basic/BuiltinsAArch64.def test/CodeGen/builtins-arm64.c Index: test/CodeGen/builtins-arm64.c ===

[PATCH] D36111: [COFF, ARM64] Add MS builtins __dmb, __dsb, __isb

mgrang added a comment. Related llvm patch: https://reviews.llvm.org/D36110 https://reviews.llvm.org/D36111 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36111: [COFF, ARM64] Add MS builtins __dmb, __dsb, __isb

mgrang added inline comments. Comment at: include/clang/Basic/BuiltinsAArch64.def:49 // Memory barrier +BUILTIN(__dmb, "vUi", "nc") +BUILTIN(__dsb, "vUi", "nc") mstorsjo wrote: > Shouldn't these be limited to MSVC mode only? Have a look at > `BuiltinsARM.def`,

[PATCH] D36111: [COFF, ARM64] Add MS builtins __dmb, __dsb, __isb

mgrang added inline comments. Comment at: include/clang/Basic/BuiltinsAArch64.def:49 // Memory barrier +BUILTIN(__dmb, "vUi", "nc") +BUILTIN(__dsb, "vUi", "nc") mstorsjo wrote: > mgrang wrote: > > mstorsjo wrote: > > > Shouldn't these be limited to MSVC mode onl

[PATCH] D36111: [COFF, ARM64] Add MS builtins __dmb, __dsb, __isb

mgrang added a comment. @mstorsjo I see that spec2000/eon calls __getReg, _ReadStatusReg and _WriteStatusReg intrinsics for ARM64. I think I would need to implement them in llvm. Do you know where can I find a doc explaining their behavior? https://reviews.llvm.org/D36111 __

[PATCH] D36363: [test] Remove an unintentional -x cl flag in an aarch64-windows test

mgrang accepted this revision. mgrang added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D36363 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

[PATCH] D36386: [clang] Remove unit test which uses reverse-iterate and fix a PointerLikeTypeTrait specialization

mgrang created this revision. This patch is in response to https://reviews.llvm.org/D35043 which removed -reverse-iterate flag and the base definition for PointerLikeTypeTrait. https://reviews.llvm.org/D36386 Files: include/clang/AST/ExternalASTSource.h test/Rewriter/objc-modern-metadata-v

[PATCH] D36105: [AArch64] Ignore stdcall and similar on aarch64/windows

mgrang added a comment. In https://reviews.llvm.org/D36105#834007, @mstorsjo wrote: > Ping @mgrang, can you check the above with MSVC? I'd like to move forward > with this in one form or another. Yes, I checked with MSVC for ARM64 and it compiles without any warnings. cl foo.c -c /W3 Micr

[PATCH] D36386: [clang] Remove unit test which uses reverse-iterate and fix a PointerLikeTypeTrait specialization

mgrang added a comment. This patch does 3 things: 1. Get rid of the unit test objc-modern-metadata-visibility2.mm because this test check uses flag -reverse-iterate. This flag will be removed in https://reviews.llvm.org/D35043. 2. https://reviews.llvm.org/D35043 gets rid of the empty base defi

[PATCH] D36386: [clang] Remove unit test which uses reverse-iterate flag

mgrang updated this revision to Diff 111557. mgrang retitled this revision from "[clang] Remove unit test which uses reverse-iterate and fix a PointerLikeTypeTrait specialization" to "[clang] Remove unit test which uses reverse-iterate flag". mgrang edited the summary of this revision. https://r

[PATCH] D36386: [clang] Remove unit test which uses reverse-iterate flag

This revision was automatically updated to reflect the committed changes. Closed by commit rL311720: [clang] Remove unit test which uses reverse-iterate flag (authored by mgrang). Changed prior to commit: https://reviews.llvm.org/D36386?vs=111557&id=112624#toc Repository: rL LLVM https://re

[PATCH] D36386: [clang] Remove unit test which uses reverse-iterate flag

mgrang added a comment. In https://reviews.llvm.org/D36386#851853, @dblaikie wrote: > sounds good - so long as other tests would fail if the fix this test was > testing wasn't present (on a reverse iteration enabled build) Thanks! Yes, I verified that the test objc-modern-metadata-visibility.m

[PATCH] D65249: [NFC] use C++11 in AlignOf.h, remove AlignedCharArray

mgrang added a comment. Herald added a subscriber: JDevlieghere. Hi @jfb This patch results in a compiler crash when building a simple C program on a Windows X86 Debug build. I have filed this issue to track it. Repository: rG LLVM Github Monorep

[PATCH] D44804: [StaticAnalyzer] Silence an unused variable warning. NFC.

mgrang created this revision. mgrang added reviewers: george.karpenkov, dcoughlin, dergachev.a. Herald added subscribers: a.sidorin, szepet. Repository: rC Clang https://reviews.llvm.org/D44804 Files: lib/StaticAnalyzer/Checkers/RetainCountChecker.cpp Index: lib/StaticAnalyzer/Checkers/Ret

[PATCH] D44804: [StaticAnalyzer] Silence an unused variable warning. NFC.

mgrang updated this revision to Diff 139503. mgrang added a comment. Addressed comment. Repository: rC Clang https://reviews.llvm.org/D44804 Files: lib/StaticAnalyzer/Checkers/RetainCountChecker.cpp Index: lib/StaticAnalyzer/Checkers/RetainCountChecker.cpp ===

[PATCH] D44804: [StaticAnalyzer] Silence an unused variable warning. NFC.

mgrang added a comment. In https://reviews.llvm.org/D44804#1046086, @george.karpenkov wrote: > LGTM, provided it compiles and tests run (`ninja check-clang`) Thanks! Yes, I have already verified it compiles and ninja check-clang is clean. Repository: rC Clang https://reviews.llvm.org/D4480

[PATCH] D44804: [StaticAnalyzer] Silence an unused variable warning. NFC.

mgrang abandoned this revision. mgrang added a comment. This seems to already have been fixed in r327802. Abandoning this patch. Repository: rC Clang https://reviews.llvm.org/D44804 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://l

[PATCH] D45237: [RISCV] Fix logic check if frame pointer should be used

mgrang created this revision. mgrang added a reviewer: asb. Herald added subscribers: shiva0217, kito-cheng. The logic was broken for Linux triples as it returns true in the switch for Triple.isOSLinux(). Repository: rC Clang https://reviews.llvm.org/D45237 Files: lib/Driver/ToolChains/Cl

[PATCH] D45237: [RISCV] Fix logic check if frame pointer should be used

mgrang added a comment. @asb Should we keep frame pointer enabled for debug builds? Internally, for ARM/Thumb we leave frame pointer ON if debug is enabled. Repository: rC Clang https://reviews.llvm.org/D45237 ___ cfe-commits mailing list cfe-co

[PATCH] D45237: [RISCV] Fix logic to check if frame pointer should be used

mgrang updated this revision to Diff 141584. mgrang retitled this revision from "[RISCV] Fix logic check if frame pointer should be used" to "[RISCV] Fix logic to check if frame pointer should be used". mgrang added a comment. Added unit tests. https://reviews.llvm.org/D45237 Files: lib/Driv

[PATCH] D39915: [clang] Remove redundant return [NFC]

mgrang created this revision. mgrang added a project: clang. Herald added a subscriber: jholewinski. https://reviews.llvm.org/D39915 Files: lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp lib/Driver/Driver.cpp lib/StaticAnalyzer/Checkers/ObjCSuperDeallocChecker.cpp Index: lib/StaticAnalyzer/Checkers

[PATCH] D39944: [Sema] Stable sort OverloadCandidates to remove non-deterministic ordering

mgrang created this revision. mgrang added a project: clang. This fixes failure in Misc/diag-template-diffing.cpp uncovered by https://reviews.llvm.org/D39245. https://reviews.llvm.org/D39944 Files: lib/Sema/SemaOverload.cpp Index: lib/Sema/SemaOverload.cpp

[PATCH] D39947: [OpenMP] Stable sort Privates to remove non-deterministic ordering

mgrang created this revision. mgrang added a project: clang. This fixes the following failures uncovered by https://reviews.llvm.org/D39245: Clang :: OpenMP/task_firstprivate_codegen.cpp Clang :: OpenMP/task_private_codegen.cpp Clang :: OpenMP/taskloop_firstprivate_codegen.cpp Clang :: Op

[PATCH] D39947: [OpenMP] Stable sort Privates to remove non-deterministic ordering

mgrang added a comment. Although this patches fixes the above unit test failures, the generated code is very different from the one that the tests expect. As a result, these tests need to be adjusted. Could the reviewers please comment/suggest on whether it is ok to fix the tests as a result of

[PATCH] D39947: [OpenMP] Stable sort Privates to remove non-deterministic ordering

mgrang added a comment. In https://reviews.llvm.org/D39947#922889, @rjmccall wrote: > In https://reviews.llvm.org/D39947#922870, @mgrang wrote: > > > Although this patches fixes the above unit test failures, the generated > > code is very different from the one that the tests expect. As a result

[PATCH] D39915: [clang] Remove redundant return [NFC]

This revision was automatically updated to reflect the committed changes. Closed by commit rL318074: [clang] Remove redundant return [NFC] (authored by mgrang). Changed prior to commit: https://reviews.llvm.org/D39915?vs=122494&id=122693#toc Repository: rL LLVM https://reviews.llvm.org/D39

[PATCH] D39944: [Sema] Stable sort OverloadCandidates to remove non-deterministic ordering

This revision was automatically updated to reflect the committed changes. Closed by commit rL318121: [Sema] Stable sort OverloadCandidates to remove non-deterministic ordering (authored by mgrang). Changed prior to commit: https://reviews.llvm.org/D39944?vs=122598&id=122744#toc Repository: r

[PATCH] D39963: [RISCV][RFC] Add initial RISC-V target and driver support

mgrang added inline comments. Comment at: lib/Driver/ToolChains/RISCV.cpp:86 +CmdArgs.push_back("-lc"); +CmdArgs.push_back("-lgloss"); +CmdArgs.push_back("--end-group"); How about if our sysroot is linux (as opposed to elf)? There won't be any libglo

[PATCH] D39947: [OpenMP] Stable sort Privates to remove non-deterministic ordering

mgrang updated this revision to Diff 122751. mgrang added a comment. Fixed the sorting order for stable_sort. Repository: rL LLVM https://reviews.llvm.org/D39947 Files: lib/CodeGen/CGOpenMPRuntime.cpp Index: lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D39947: [OpenMP] Stable sort Privates to remove non-deterministic ordering

mgrang added a comment. In https://reviews.llvm.org/D39947#922987, @rjmccall wrote: > In https://reviews.llvm.org/D39947#922922, @mgrang wrote: > > > In https://reviews.llvm.org/D39947#922889, @rjmccall wrote: > > > > > In https://reviews.llvm.org/D39947#922870, @mgrang wrote: > > > > > > > Altho

[PATCH] D39963: [RISCV][RFC] Add initial RISC-V target and driver support

mgrang added a comment. @asb I cherry-picked this patch and was able to compile a simple program for elf triple. By manually adding a few libs on the link line I was also able to make it link for linux triple. Could you please respond to the comment about risv32-ld? Other than that this patch L

[PATCH] D39963: [RISCV][RFC] Add initial RISC-V target and driver support

mgrang added inline comments. Comment at: test/Driver/riscv64-toolchain.c:1 +// A basic clang -cc1 command-line, and simple environment check. + I just saw that this test fails with the error: error: backend data layout 'e-m:e-i64:64-n32:64-S128' does not match

[PATCH] D40023: [RISCV] Implement ABI lowering

mgrang added inline comments. Comment at: lib/CodeGen/TargetInfo.cpp:8845 + + // Structures with either a non-trivial destructor or a non-trivial + // copy constructor are always indirectly. Comment sounds incomplete. Comment at: lib/CodeGen/

[PATCH] D39963: [RISCV][RFC] Add initial RISC-V target and driver support

mgrang added inline comments. Comment at: test/Driver/riscv64-toolchain.c:1 +// A basic clang -cc1 command-line, and simple environment check. + mgrang wrote: > I just saw that this test fails with the error: > > error: backend data layout 'e-m:e-i64:64-n32:64-S

[PATCH] D39963: [RISCV][RFC] Add initial RISC-V target and driver support

mgrang added inline comments. Comment at: lib/Driver/ToolChains/Gnu.cpp:1823 + "riscv64-unknown-linux-gnu", + "riscv32-unknown-elf"}; + I suppose we need riscv64-unknown-elf h

[PATCH] D40234: [AutoComplete] Stable sort autocomplete candidates to remove non-deterministic ordering

mgrang created this revision. mgrang added a project: clang. This fixes the failure in test/Driver/autocomplete.c uncovered by https://reviews.llvm.org/D39245. https://reviews.llvm.org/D40234 Files: lib/Driver/Driver.cpp Index: lib/Driver/Driver.cpp

[PATCH] D40234: [AutoComplete] Stable sort autocomplete candidates to remove non-deterministic ordering

mgrang added a comment. This is the order of options observed when the candidates are randomly shuffled: Run 1: cl CL cl1.1 CL1.1 cl1.2 CL1.2 cl2.0 CL2.0 Run 2: CL cl cl1.1 CL1.1 cl1.2 CL1.2 CL2.0 cl2.0 https://reviews.llvm.org/D40234

[PATCH] D40234: [AutoComplete] Use stronger sort predicate for autocomplete candidates to remove non-deterministic ordering

mgrang added a comment. In https://reviews.llvm.org/D40234#929919, @ruiu wrote: > Maybe we should do case-insensitive string comparison first, and if two > strings are considered the same, try again in case-sensitive manner? > Otherwise, even though the output is now deterministic, the output o

[PATCH] D40234: [AutoComplete] Use stronger sort predicate for autocomplete candidates to remove non-deterministic ordering

mgrang updated this revision to Diff 123538. mgrang retitled this revision from "[AutoComplete] Stable sort autocomplete candidates to remove non-deterministic ordering" to "[AutoComplete] Use stronger sort predicate for autocomplete candidates to remove non-deterministic ordering". mgrang added

[PATCH] D40234: [AutoComplete] Use stronger sort predicate for autocomplete candidates to remove non-deterministic ordering

mgrang updated this revision to Diff 123546. https://reviews.llvm.org/D40234 Files: lib/Driver/Driver.cpp Index: lib/Driver/Driver.cpp === --- lib/Driver/Driver.cpp +++ lib/Driver/Driver.cpp @@ -1197,8 +1197,11 @@ // determini

[PATCH] D40234: [AutoComplete] Use stronger sort predicate for autocomplete candidates to remove non-deterministic ordering

mgrang added a comment. In https://reviews.llvm.org/D40234#929943, @ruiu wrote: > Perhaps, this is a bit more straightforward. > > if (int X = A.compare_lower(B)) > return X < 0; > return A.compare(B) < 0; Thanks. Done. https://reviews.llvm.org/D40234 __

[PATCH] D40234: [AutoComplete] Use stronger sort predicate for autocomplete candidates to remove non-deterministic ordering

This revision was automatically updated to reflect the committed changes. Closed by commit rL318681: [AutoComplete] Use stronger sort predicate for autocomplete candidates to… (authored by mgrang). Changed prior to commit: https://reviews.llvm.org/D40234?vs=123546&id=123623#toc Repository: r

[PATCH] D39947: [OpenMP] Stable sort Privates to remove non-deterministic ordering

mgrang added a comment. Ping for reviews please. Repository: rL LLVM https://reviews.llvm.org/D39947 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40023: [RISCV] Implement ABI lowering

mgrang added inline comments. Comment at: lib/CodeGen/TargetInfo.cpp:8790 +private: + unsigned XLen; + static const int NumArgGPRs = 8; rjmccall wrote: > Is "XLen" a term that anyone working with RISCV would recognize? Because > even if it is, it feels like s

[PATCH] D34706: [COFF, ARM64] Add support for Windows ARM64 COFF format

mgrang created this revision. Herald added subscribers: kristof.beyls, aemerson. This is the clang part of the initial implementation to support Windows ARM64 COFF format. https://reviews.llvm.org/D34706 Files: lib/Basic/Targets.cpp test/Preprocessor/predefined-macros.c Index: test/Prepr

[PATCH] D34706: [COFF, ARM64] Add support for Windows ARM64 COFF format

mgrang added a comment. Here is the llvm part of this patch: https://reviews.llvm.org/D34705 https://reviews.llvm.org/D34706 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34706: [COFF, ARM64] Add support for Windows ARM64 COFF format

mgrang updated this revision to Diff 104308. mgrang added a comment. Comments addressed. https://reviews.llvm.org/D34706 Files: lib/Basic/Targets.cpp test/Preprocessor/predefined-macros.c Index: test/Preprocessor/predefined-macros.c

[PATCH] D34706: [COFF, ARM64] Add support for Windows ARM64 COFF format

This revision was automatically updated to reflect the committed changes. Closed by commit rL306489: [COFF, ARM64] Add support for Windows ARM64 COFF format (authored by mgrang). Changed prior to commit: https://reviews.llvm.org/D34706?vs=104308&id=104317#toc Repository: rL LLVM https://rev

[PATCH] D34859: [COFF, ARM64] Set the data type widths and the data layout string for COFF ARM64

mgrang created this revision. Herald added subscribers: kristof.beyls, aemerson. COFF ARM64 is LLP64 platform. So int is 4 bytes, long is 4 bytes and long long is 8 bytes. https://reviews.llvm.org/D34859 Files: lib/Basic/Targets.cpp Index: lib/Basic/Targets.cpp

[PATCH] D34860: [Objective-C] Fix non-determinism in clang

mgrang created this revision. Iteration of the unordered Ivars causes objc-modern-metadata-visibility.mm (uncovered by reverse iterating SmallPtrSet). https://reviews.llvm.org/D34860 Files: lib/Frontend/Rewrite/RewriteModernObjC.cpp test/Rewriter/objc-modern-metadata-visibility2.mm Index

[PATCH] D34860: [Objective-C] Fix non-determinism in clang

mgrang added a comment. Ping for reviews please. https://reviews.llvm.org/D34860 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34860: [Objective-C] Fix non-determinism in clang

This revision was automatically updated to reflect the committed changes. Closed by commit rL307296: [Objective-C] Fix non-determinism in clang (authored by mgrang). Changed prior to commit: https://reviews.llvm.org/D34860?vs=104811&id=105498#toc Repository: rL LLVM https://reviews.llvm.or

[PATCH] D35426: [clang] Add abi-breaking-checks support to clang

mgrang created this revision. You can now use REQUIRES:abi-breaking-checks in clang too https://reviews.llvm.org/D35426 Files: test/lit.cfg test/lit.site.cfg.in Index: test/lit.site.cfg.in === --- test/lit.site.cfg.in +++ tes

[PATCH] D35426: [clang] Add abi-breaking-checks support to clang

mgrang added a comment. The test clang/test/Rewriter/objc-modern-metadata-visibility2.mm is listed as UNSUPPORTED since the test contains REQUIRES:abi-breaking-checks but clang does not support this yet. https://reviews.llvm.org/D35426 ___ cfe-com

[PATCH] D34859: [COFF, ARM64] Set the data type widths and the data layout string for COFF ARM64

mgrang updated this revision to Diff 106811. mgrang added a comment. Herald added a subscriber: javed.absar. Fixed typo. Added size for long double. Added test cases. https://reviews.llvm.org/D34859 Files: lib/Basic/Targets.cpp test/CodeGen/coff-aarch64-type-sizes.c Index: test/CodeGen/cof

[PATCH] D35465: [clang] Remove redundant check-prefix=CHECK from tests. NFC.

mgrang created this revision. Herald added a subscriber: javed.absar. https://reviews.llvm.org/D35465 Files: test/CodeGen/aarch64-type-sizes.c test/CodeGen/aarch64-varargs-ms.c test/CodeGenCXX/implicit-exception-spec.cpp test/Index/complete-available.m test/Misc/ast-dump-decl.c test/M

[PATCH] D35465: [clang] Remove redundant check-prefix=CHECK from tests. NFC.

This revision was automatically updated to reflect the committed changes. Closed by commit rL308192: [clang] Remove redundant check-prefix=CHECK from tests. NFC. (authored by mgrang). Changed prior to commit: https://reviews.llvm.org/D35465?vs=106821&id=106901#toc Repository: rL LLVM https:

[PATCH] D34859: [COFF, ARM64] Set the data type widths and the data layout string

mgrang updated this revision to Diff 106925. mgrang retitled this revision from "[COFF, ARM64] Set the data type widths and the data layout string for COFF ARM64" to "[COFF, ARM64] Set the data type widths and the data layout string". mgrang set the repository for this revision to rL LLVM. Repos

[PATCH] D34859: [COFF, ARM64] Set the data type widths and the data layout string

This revision was automatically updated to reflect the committed changes. Closed by commit rL308222: [COFF, ARM64] Set the data type widths and the data layout string (authored by mgrang). Changed prior to commit: https://reviews.llvm.org/D34859?vs=106925&id=106952#toc Repository: rL LLVM h

[PATCH] D35529: [COFF, ARM64] Make +reserve-x18 the default

mgrang created this revision. Herald added subscribers: kristof.beyls, javed.absar, aemerson. https://reviews.llvm.org/D35529 Files: docs/ClangCommandLineReference.rst lib/Basic/Targets.cpp test/Driver/coff-aarch64-fixed-x18.c Index: test/Driver/coff-aarch64-fixed-x18.c ==

[PATCH] D35529: [COFF, ARM64] Make +reserve-x18 the default

mgrang added a comment. In https://reviews.llvm.org/D35529#812427, @mstorsjo wrote: > Wouldn't it make more sense to set this by default within LLVM, where it's > already enabled by default for darwin? > > Currently there's this code there: > > AArch64Subtarget::AArch64Subtarget(const Triple &

[PATCH] D35529: [COFF, ARM64] Make +reserve-x18 the default

mgrang added a comment. I pushed a new patch D35531 . This implements the logic in llvm AArch64SubTarget which seems to be the proper place to do this. Once that patch is reviewed/accepted, I will abandon this one. https://reviews.llvm.org/D35529 ___

[PATCH] D35426: [clang] Add abi-breaking-checks support to clang

mgrang added a comment. Ping for reviews please. https://reviews.llvm.org/D35426 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35426: [clang] Add abi-breaking-checks support to clang

mgrang added a comment. Ping 2 for reviews please! https://reviews.llvm.org/D35426 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35862: [clang] Add ARM64 support to armintr.h for MSVC compatibility

mgrang created this revision. Herald added subscribers: kristof.beyls, javed.absar, aemerson. This fixes compiling with headers from the Windows SDK for ARM64. https://reviews.llvm.org/D35862 Files: lib/Headers/armintr.h Index: lib/Headers/armintr.h =

[PATCH] D35862: [clang] Add ARM64 support to armintr.h for MSVC compatibility

mgrang added a comment. Refer http://infocenter.arm.com/help/topic/com.arm.doc.ihi0053c/IHI0053C_acle_2_0.pdf for memory barriers. https://reviews.llvm.org/D35862 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

[PATCH] D35426: [clang] Add abi-breaking-checks support to clang

This revision was automatically updated to reflect the committed changes. Closed by commit rL309049: [clang] Add abi-breaking-checks support to clang (authored by mgrang). Changed prior to commit: https://reviews.llvm.org/D35426?vs=106671&id=108180#toc Repository: rL LLVM https://reviews.ll

[PATCH] D35862: [clang] Add ARM64 support to armintr.h for MSVC compatibility

mgrang updated this revision to Diff 108208. Herald added a subscriber: mgorny. https://reviews.llvm.org/D35862 Files: lib/Headers/CMakeLists.txt lib/Headers/arm64intr.h lib/Headers/intrin.h Index: lib/Headers/intrin.h === --

[PATCH] D35862: [clang] Add ARM64 support to armintr.h for MSVC compatibility

mgrang added a comment. Patch updated as per comments. https://reviews.llvm.org/D35862 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35862: [clang] Add ARM64 support to armintr.h for MSVC compatibility

This revision was automatically updated to reflect the committed changes. Closed by commit rL309081: [clang] Add ARM64 support to armintr.h for MSVC compatibility (authored by mgrang). Changed prior to commit: https://reviews.llvm.org/D35862?vs=108208&id=108222#toc Repository: rL LLVM https

[PATCH] D35934: [Headers] Add a test for arm64intr.h

mgrang accepted this revision. mgrang added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D35934 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

[PATCH] D42673: [RISCV] Pick the correct RISCV linker instead of calling riscv-gcc to link

mgrang created this revision. mgrang added reviewers: asb, apazos. mgrang added a project: clang. Herald added subscribers: cfe-commits, hintonda, niosHD, sabuasal, jordy.potman.lists, simoncook, johnrusso, rbar, mgorny. Currently we are invoking riscv-gcc to link. This causes all flags passed to

[PATCH] D42673: [RISCV] Pick the correct RISCV linker instead of calling riscv-gcc to link

mgrang added a comment. In https://reviews.llvm.org/D42673#992056, @asb wrote: > My main concern with this patch is that the description doesn't really match > what it does. The current in-tree code _doesn't_ call gcc to link for the > tested configuration (a multilib toolchain), and this is ve

[PATCH] D42673: [RISCV] Pick the correct RISCV linker instead of calling riscv-gcc to link

mgrang abandoned this revision. mgrang added a comment. For now, by setting the full triple (riscv-unknown-linux-gnu) we are able to invoke the correct gnu linker. So will abandon this patch. Repository: rC Clang https://reviews.llvm.org/D42673

[PATCH] D27360: Fix D26214: Move error handling out of MC and to the callers.

mgrang created this revision. mgrang added reviewers: dgross, echristo, t.p.northover, rengolin, compnerd. mgrang added subscribers: llvm-commits, cfe-commits. mgrang added a project: clang-c. Herald added a subscriber: mehdi_amini. Related llvm patch: https://reviews.llvm.org/D27359 https://rev

<    1   2   3   4   >