[PATCH] D133236: [clang-format] Use utf-8 for JSON object load

ldrumm accepted this revision. ldrumm added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133236/new/ https://reviews.llvm.org/D133236 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D133236: [clang-format] Use utf-8 for JSON object load

ldrumm added a comment. Do you have commit access? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133236/new/ https://reviews.llvm.org/D133236 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[PATCH] D133236: [clang-format] Use utf-8 for JSON object load

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8f4e6cfe73d8: [clang-format] Use utf-8 for JSON object load (authored by kaitingwang, committed by ldrumm). Repository: rG LLVM Github Monorepo C

[PATCH] D98411: [OpenCL] Respect calling convention for builtin

ldrumm created this revision. ldrumm added reviewers: Anastasia, mibintc, bader, yaxunl. ldrumm added a project: clang. Herald added a subscriber: wenlei. ldrumm requested review of this revision. `__translate_sampler_initializer` has a calling convention of `spir_func`, but clang generated calls

[PATCH] D98411: [OpenCL] Respect calling convention for builtin

ldrumm added a subscriber: svenvh. ldrumm added a comment. @Anastasia @svenvh is this already covered by https://reviews.llvm.org/D98039 ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98411/new/ https://reviews.llvm.org/D98411 ___

[PATCH] D98411: [OpenCL] Respect calling convention for builtin

This revision was automatically updated to reflect the committed changes. Closed by commit rGfcfd3fda7190: [OpenCL] Respect calling convention for builtin (authored by ldrumm). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98411/new/ https://reviews

[PATCH] D98411: [OpenCL] Respect calling convention for builtin

ldrumm added a comment. Given this fixes a runtime crash bug, should it be backported to the relevant release branch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98411/new/ https://reviews.llvm.org/D98411 ___

[PATCH] D151701: [HIP] Add missing __hip_atomic_fetch_sub support

ldrumm created this revision. ldrumm added reviewers: yaxunl, nikic, gandhi21299. Herald added a subscriber: StephenFan. Herald added a project: All. ldrumm requested review of this revision. Herald added a project: clang. The rest of the fetch/op intrinsics were added in e13246a2ec3

[PATCH] D151701: [HIP] Add missing __hip_atomic_fetch_sub support

ldrumm added a comment. In D151701#4380666 , @yaxunl wrote: > HIP did not add fetch/sub since fetch/sub x can be trivially implemented > through fetch/add -x and performance-wise equivalent. There is existing isel for `global_atomic_sub` for RDNA target

[PATCH] D151701: [HIP] Add missing __hip_atomic_fetch_sub support

This revision was automatically updated to reflect the committed changes. Closed by commit rGe3fbede7f3fd: [HIP] Add missing __hip_atomic_fetch_sub support (authored by ldrumm). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151701/new/ https://revie

[PATCH] D98411: [OpenCL] Respect calling convention for builtin

ldrumm added a comment. In D98411#2628592 , @Anastasia wrote: > In D98411#2626613 , @ldrumm wrote: > >> Given this fixes a runtime crash bug, should it be backported to the >> relevant release branch? > > Sure, tha

[PATCH] D98411: [OpenCL] Respect calling convention for builtin

ldrumm added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:6268 + auto *FTy = llvm::FunctionType::get(SamplerT, {C->getType()}, false); + auto *Call = CGF.Builder.CreateCall( + CreateRuntimeFunction(FTy, "__translate_sampler_initializer"), {C});

[PATCH] D98705: [OpenCL] Prefer CodeGenFunction::EmitRuntimeCall

ldrumm created this revision. ldrumm added reviewers: Anastasia, bader. ldrumm added a project: clang. Herald added a subscriber: yaxunl. ldrumm requested review of this revision. Herald added a subscriber: cfe-commits. CodeGenFunction::EmitRuntimeCall automatically sets the right calling │ c

[PATCH] D98705: [OpenCL] Prefer CodeGenFunction::EmitRuntimeCall

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG440f6bdf34f4: [OpenCL][NFCI] Prefer CodeGenFunction::EmitRuntimeCall (authored by ldrumm). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D111315: Workaround build error for mingw-g++

ldrumm created this revision. ldrumm added reviewers: v.g.vassilev, rsmith. ldrumm added a project: clang. Herald added a subscriber: mstorsjo. ldrumm requested review of this revision. Workaround build error for mingw-g++ mingw-g++ does not correctly support the full std::errc namespace

[PATCH] D111315: Workaround build error for mingw-g++

ldrumm updated this revision to Diff 377864. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111315/new/ https://reviews.llvm.org/D111315 Files: clang/lib/Interpreter/Interpreter.cpp Index: clang/lib/Interpreter/Interpreter.cpp ==

[PATCH] D111315: Workaround build error for mingw-g++

ldrumm added a comment. In D111315#3048459 , @v.g.vassilev wrote: > Can you map `state_not_recoverable` to `not_supported`? Sure. I wasn't really sure that the io_error and not_enough_memory were appropriate. Thanks for the confirmation CHANGES SINCE

[PATCH] D111315: Workaround build error for mingw-g++

ldrumm updated this revision to Diff 377905. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111315/new/ https://reviews.llvm.org/D111315 Files: clang/lib/Interpreter/Interpreter.cpp Index: clang/lib/Interpreter/Interpreter.cpp ==

[PATCH] D111315: Workaround build error for mingw-g++

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6283d468e28b: Workaround build error for mingw-g++ (authored by ldrumm). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://