LukeCheeseman added a comment.
ping
https://reviews.llvm.org/D49793
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL340018: [AArch64] - Generate pointer authentication
instructions (authored by LukeCheeseman, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D4
LukeCheeseman created this revision.
LukeCheeseman added reviewers: kcc, pcc, eugenis, vlad.tsyrklevich.
Herald added a reviewer: javed.absar.
Herald added subscribers: cfe-commits, kristof.beyls.
- Add command line options for selecting the B key when enabling return address
signing (also tidy u
LukeCheeseman created this revision.
LukeCheeseman added reviewers: pcc, kcc, eugenis, vlad.tsyrklevich.
Herald added a reviewer: javed.absar.
Herald added subscribers: cfe-commits, chrib, JDevlieghere, kristof.beyls.
- When return address signing is enabled, the LR may be signed on function entry
LukeCheeseman updated this revision to Diff 165467.
LukeCheeseman added a comment.
- updated tests to check the default a_key attribute is included in functions
that have the return address signing scope attribute
- setting the return-address-sign-key attribute of global static constructors
htt
LukeCheeseman updated this revision to Diff 157266.
LukeCheeseman edited the summary of this revision.
https://reviews.llvm.org/D49793
Files:
include/clang/Driver/Options.td
include/clang/Frontend/CodeGenOptions.def
include/clang/Frontend/CodeGenOptions.h
lib/CodeGen/TargetInfo.cpp
lib/
LukeCheeseman updated this revision to Diff 157444.
LukeCheeseman added a comment.
Change codegen option partial to non-leaf to match msign-return-address scope
values
https://reviews.llvm.org/D49793
Files:
include/clang/Driver/Options.td
include/clang/Frontend/CodeGenOptions.def
include
LukeCheeseman added inline comments.
Comment at: include/clang/Frontend/CodeGenOptions.h:114
+Partial,// Sign the return address of functions that spill LR
+All // Sign the return address of all functions
+ };
kcc wrote:
> what's the
LukeCheeseman updated this revision to Diff 158491.
LukeCheeseman added a comment.
Move -msign-return-address argument handling into AArch64TargetArgs
https://reviews.llvm.org/D49793
Files:
include/clang/Driver/Options.td
include/clang/Frontend/CodeGenOptions.def
include/clang/Frontend/Co
LukeCheeseman created this revision.
LukeCheeseman added a reviewer: marsupial.
Herald added subscribers: cfe-commits, mgorny.
Add in a space when appending the export to the linker options. Without
the space the export is appeneded onto whatever the last link option
was, which might be a file.
LukeCheeseman updated this revision to Diff 169430.
LukeCheeseman added a comment.
- Stop parsing msign-return-address as a scope and key pair
- pass bti value through to the CC1 driver and handle it, this adds the
branch-target-enforce attribute to functions
https://reviews.llvm.org/D51429
Fi
LukeCheeseman updated this revision to Diff 170869.
https://reviews.llvm.org/D51429
Files:
include/clang/Basic/DiagnosticDriverKinds.td
include/clang/Driver/CC1Options.td
include/clang/Driver/Options.td
include/clang/Frontend/CodeGenOptions.def
include/clang/Frontend/CodeGenOptions.h
LukeCheeseman closed this revision.
LukeCheeseman added a comment.
This was committed under 345273. (Forgot to mention the revision in the commit
message)
https://reviews.llvm.org/D51429
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:
LukeCheeseman updated this revision to Diff 188364.
LukeCheeseman added a comment.
- Test cpus Cortex-M33 and Cortex-M35P seperately
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57765/new/
https://reviews.llvm.org/D57765
Files:
test/Driver/arm-cortex-cpus.c
Index: test/Driver/arm-
LukeCheeseman added a comment.
ping
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57765/new/
https://reviews.llvm.org/D57765
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL356742: [ARM] Add Cortex-M35P Support (authored by
LukeCheeseman, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org
LukeCheeseman added inline comments.
Comment at: src/Registers.hpp:1835
+ if (((regNum >= 0) && (regNum < 32)) || regNum == UNW_ARM64_RA_SIGN_STATE)
return _registers.__x[regNum];
+
olista01 wrote:
> When regNum == UNW_ARM64_RA_SIGN_STATE, the index into __
LukeCheeseman updated this revision to Diff 165775.
LukeCheeseman added a comment.
return an error code when trying to sign return addresses and cross unwinding
https://reviews.llvm.org/D51432
Files:
include/libunwind.h
src/DwarfInstructions.hpp
src/DwarfParser.hpp
src/Registers.hpp
s
This revision was automatically updated to reflect the committed changes.
Closed by commit rL342895: [AArch64] Unwinding support for return address
signing (authored by LukeCheeseman, committed by ).
Herald added subscribers: llvm-commits, christof.
Changed prior to commit:
https://reviews.llvm
LukeCheeseman updated this revision to Diff 167723.
LukeCheeseman added a comment.
- Introduce the -mbranch-protection option. This is to be used for both pointer
authentication and branch protection security features.
- The branch protection compiler support will follow later
- The options ava
LukeCheeseman added inline comments.
Comment at: include/clang/Frontend/CodeGenOptions.h:117
+ enum SignReturnAddressKeyValue { AKey, BKey };
+
javed.absar wrote:
> Perhaps a line of comment on each enum-value would be useful (much like the
> code around).
I'
LukeCheeseman created this revision.
LukeCheeseman added a reviewer: olista01.
Herald added subscribers: cfe-commits, kristof.beyls, javed.absar.
Herald added a project: clang.
- Add clang frontend testing for cortex-a76 and cortex-a76ae
Repository:
rC Clang
https://reviews.llvm.org/D57764
F
LukeCheeseman created this revision.
LukeCheeseman added a reviewer: olista01.
Herald added subscribers: cfe-commits, kristof.beyls, javed.absar.
Herald added a project: clang.
- Add clang frontend testing for Cortex-M35P
Repository:
rC Clang
https://reviews.llvm.org/D57765
Files:
test/Dri
This revision was automatically updated to reflect the committed changes.
Closed by commit rL354789: [AArch64] Add support for Cortex-A76 and
Cortex-A76AE (authored by LukeCheeseman, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
LukeCheeseman added a comment.
Are there some changes/addition to tests attached to this?
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64210/new/
https://reviews.llvm.org/D64210
___
cfe-commits mailing list
cfe-comm
LukeCheeseman added a comment.
Are there some changes/addition to tests attached to this?
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64211/new/
https://reviews.llvm.org/D64211
___
cfe-commits mailing list
cfe-comm
LukeCheeseman updated this revision to Diff 220067.
LukeCheeseman added a comment.
- Add a requires shell
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67542/new/
https://reviews.llvm.org/D67542
Files:
clang/lib/Driver/ToolChains/Clang.cpp
clang/test/Driver/metadata-with-dots.c
I
This revision was automatically updated to reflect the committed changes.
Closed by commit rL371853: Fix depfile name construction (authored by
LukeCheeseman, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org
LukeCheeseman closed this revision.
LukeCheeseman added a comment.
closed by https://reviews.llvm.org/rC328092
Repository:
rC Clang
https://reviews.llvm.org/D44555
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-
29 matches
Mail list logo
