[PATCH] D120188: Fix extraneous whitespace addition in line comments on clang-format directives

penagos created this revision. penagos requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D120188 Files: clang/lib/Format/BreakableToken.cpp clang/unittests/Format/FormatTest

[PATCH] D120188: Fix extraneous whitespace addition in line comments on clang-format directives

penagos updated this revision to Diff 410115. penagos added a comment. - Split AllowsSpaceChange conditional over multiple variables to enhance readability. - Remove unnecessary column limit from unittest. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D120188: Fix extraneous whitespace addition in line comments on clang-format directives

penagos marked 3 inline comments as done. penagos added inline comments. Comment at: clang/lib/Format/BreakableToken.cpp:818-822 const auto AllowsSpaceChange = -SpacesInPrefix != 0 || -(!NoSpaceBeforeFirstCommentChar() || - (FirstNonSp

[PATCH] D120188: Fix extraneous whitespace addition in line comments on clang-format directives

penagos marked an inline comment as done. penagos added a comment. In D120188#674 , @HazardyKnusperkeks wrote: > Thanks for working on it. Happy to help! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D120188: Fix extraneous whitespace addition in line comments on clang-format directives

penagos added a comment. I don’t have commit rights; if someone could commit on my behalf that’d be great. - Luis Penagos - l...@penagos.co Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120188/new/ https://reviews.llvm.org/D120188 _

[PATCH] D120374: [clang-format] Do not insert space after new/delete keywords in C function declarations

penagos created this revision. penagos added reviewers: curdeius, MyDeveloperDay, HazardyKnusperkeks. penagos updated this revision to Diff 410700. penagos added a comment. penagos published this revision for review. penagos added a comment. Herald added a project: clang. Herald added a subscriber:

[PATCH] D101322: [clang-format] Add comment justification for https://reviews.llvm.org/D100778

penagos abandoned this revision. penagos added a comment. Closing old review request. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101322/new/ https://reviews.llvm.org/D101322 ___ cfe-commits mailing li

[PATCH] D120374: [clang-format] Do not insert space after new/delete keywords in C function declarations

penagos updated this revision to Diff 410788. penagos added a comment. Add missing space in unittest. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120374/new/ https://reviews.llvm.org/D120374 Files: clang/lib/Format/TokenAnnotator.cpp clang/u

[PATCH] D120374: [clang-format] Do not insert space after new/delete keywords in C function declarations

penagos marked an inline comment as done. penagos added a comment. In D120374#3339554 , @curdeius wrote: > In D120374#3339337 , @penagos wrote: > >> Though it's still unclear to me whether or not it'd make more se

[PATCH] D120445: [clang-format] Treat && followed by noexcept operator as a binary operator inside template arguments

penagos created this revision. penagos added reviewers: curdeius, MyDeveloperDay. penagos published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://github.com/llvm/llvm-project/issues/44544. Repository: rG LLVM Github Monorepo htt

[PATCH] D120445: [clang-format] Treat && followed by noexcept operator as a binary operator inside template arguments

penagos updated this revision to Diff 411272. penagos added a comment. Rebase to trigger CI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120445/new/ https://reviews.llvm.org/D120445 Files: clang/lib/Format/TokenAnnotator.cpp clang/unittests/

[PATCH] D120445: [clang-format] Treat && followed by noexcept operator as a binary operator inside template arguments

penagos added a comment. I went ahead and did a git rebase but CI still appears to be failing (though tests pass in my local clone). Also, I’ll need someone to commit this on my behalf: - Luis Penagos - l...@penagos.co Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D100778: [clang-format] Prevent extraneous space insertion in bitshift operators

penagos added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:125 + CurrentToken->Next->getStartOfNonWhitespace().getLocWithOffset( + -1))) return false; krasimir wrote: > penagos wrote: > > MyDevel

[PATCH] D101322: [clang-format] Add comment justification for https://reviews.llvm.org/D100778

penagos created this revision. penagos requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D101322 Files: clang/lib/Format/TokenAnnotator.cpp Index: clang/lib/Format/TokenAnno

[PATCH] D101322: [clang-format] Add comment justification for https://reviews.llvm.org/D100778

penagos added a comment. Please ignore this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101322/new/ https://reviews.llvm.org/D101322 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D100778: [clang-format] Prevent extraneous space insertion in bitshift operators

penagos updated this revision to Diff 340656. penagos added a comment. Add justification comment for changes in parseAngle() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100778/new/ https://reviews.llvm.org/D100778 Files: clang/lib/Format/Token

[PATCH] D100778: [clang-format] Prevent extraneous space insertion in bitshift operators

penagos added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:125 + CurrentToken->Next->getStartOfNonWhitespace().getLocWithOffset( + -1))) return false; krasimir wrote: > penagos wrote: > > krasimi

[PATCH] D100778: [clang-format] Prevent extraneous space insertion in bitshift operators

penagos added a comment. Friendly reminder that I need someone to land this for me as I do not have commit access. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100778/new/ https://reviews.llvm.org/D100778

[PATCH] D100778: [clang-format] Prevent extraneous space insertion in bitshift operators

penagos created this revision. penagos added reviewers: Saldivarcher, MyDeveloperDay, JakeMerdichAMD, krasimir. penagos requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This serves to augment the improvements made in https://reviews.llvm.or

[PATCH] D100778: [clang-format] Prevent extraneous space insertion in bitshift operators

penagos updated this revision to Diff 338641. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100778/new/ https://reviews.llvm.org/D100778 Files: clang/unittests/Format/FormatTest.cpp Index: clang/unittests/Format/FormatTest.cpp =

[PATCH] D100778: [clang-format] Prevent extraneous space insertion in bitshift operators

penagos marked an inline comment as done. penagos added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:7652 + verifyFormat("test < a - 1 >> 1;"); verifyFormat("test >> a >> b;"); Quuxplusone wrote: > Quuxplusone wrote: > > IMO you should

[PATCH] D100778: [clang-format] Prevent extraneous space insertion in bitshift operators

penagos updated this revision to Diff 338648. penagos added a comment. Update Format test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100778/new/ https://reviews.llvm.org/D100778 Files: clang/lib/Format/TokenAnnotator.cpp clang/unittests/For

[PATCH] D100778: [clang-format] Prevent extraneous space insertion in bitshift operators

penagos added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:125 + CurrentToken->Next->getStartOfNonWhitespace().getLocWithOffset( + -1))) return false; MyDeveloperDay wrote: > I don't really under

[PATCH] D100778: [clang-format] Prevent extraneous space insertion in bitshift operators

penagos added a comment. Additionally; barring any other feedback, I'll need someone to land this change as I do not have commit access. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100778/new/ https://reviews.llvm.org/D100778 __