[PATCH] D91556: [OpenMPIRBuilder} Add capturing of parameters to pass to omp::parallel

llitchev updated this revision to Diff 311557. llitchev added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Merged in master. Removed unnecessary (now) code from D92189 . Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D91556: [OpenMPIRBuilder} Add capturing of parameters to pass to omp::parallel

llitchev updated this revision to Diff 311648. llitchev added a comment. Fixed a failing Windows test. The issue is that that the order of the operands for add operation has changed. I cant see how these changes could cause the issue, but it is a failing test that blocks push of this Diff. Rep

[PATCH] D91556: [OpenMPIRBuilder} Add capturing of parameters to pass to omp::parallel

llitchev updated this revision to Diff 311698. llitchev added a comment. Added separate tests for Windows for specific tests. On Windows the registers for the add operation are swapped. This test is completely unrelated to this change, but it fails. Repository: rG LLVM Github Monorepo CHANG

[PATCH] D91556: [OpenMPIRBuilder} Add capturing of parameters to pass to omp::parallel

llitchev updated this revision to Diff 313039. llitchev marked 10 inline comments as done. llitchev added a comment. Addressed CR. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91556/new/ https://reviews.llvm.org/D91556 Files: clang/test/OpenMP/

[PATCH] D91556: [OpenMPIRBuilder} Add capturing of parameters to pass to omp::parallel

llitchev added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:119 /// should be placed. - /// \param Original The value being copied/created, should not be used in the - /// generated IR. - /// \param Inner The

[PATCH] D91556: [OpenMPIRBuilder} Add capturing of parameters to pass to omp::parallel

llitchev updated this revision to Diff 313041. llitchev added a comment. Removed the changes from threads.ll. I'll pull this is a new Diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91556/new/ https://reviews.llvm.org/D91556 Files: clang/te

[PATCH] D91556: [OpenMPIRBuilder} Add capturing of parameters to pass to omp::parallel

llitchev updated this revision to Diff 313048. llitchev added a comment. Some minor optimizations related to CR. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91556/new/ https://reviews.llvm.org/D91556 Files: clang/test/OpenMP/parallel_codegen.c

[PATCH] D91556: [OpenMPIRBuilder} Add capturing of parameters to pass to omp::parallel

llitchev updated this revision to Diff 313077. llitchev added a comment. Fixed a casing issue with a local var. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91556/new/ https://reviews.llvm.org/D91556 Files: clang/test/OpenMP/parallel_codegen.cp

[PATCH] D92189: [OpenMPIRBuilder] forward arguments as pointers to outlined function

llitchev added a comment. In D92189#2425639 , @jdoerfert wrote: > While only partially related, can you leave a FIXME saying that more than 15 > arguments need to be packed in a structure? Yes, the number of varargs that is guarantee to work is 15, if mo