[libcxx] [libcxxabi] [libunwind] [llvm] [libc++] Unify the benchmarks with the test suite (PR #101399)

2024-11-05 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/101399 >From 504518235aa19ab517b59e41c003b86dc610bbb0 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Thu, 25 Jul 2024 10:41:10 -0400 Subject: [PATCH] [libc++] Unify the benchmarks with the test suite Instead of bui

[libcxx] [libcxxabi] [libunwind] [llvm] [libc++] Unify the benchmarks with the test suite (PR #101399)

2024-11-05 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/101399 >From 2e50f00dfc6636abbaf0c8350c6e7c92b7b3dba0 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Thu, 25 Jul 2024 10:41:10 -0400 Subject: [PATCH] [libc++] Unify the benchmarks with the test suite Instead of bui

[libcxx] [libcxxabi] [libunwind] [llvm] [libc++] Unify the benchmarks with the test suite (PR #101399)

2024-11-05 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/101399 >From b52b55d2c25c6b0800c934885d0c6a389145bbf6 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Thu, 25 Jul 2024 10:41:10 -0400 Subject: [PATCH] [libc++] Unify the benchmarks with the test suite Instead of bui

[libcxx] [libcxxabi] [libunwind] [llvm] [libc++] Unify the benchmarks with the test suite (PR #101399)

2024-11-05 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/101399 >From dd2d2ee9ff54b5263d0f65bcac64407ffb0c9e12 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Thu, 25 Jul 2024 10:41:10 -0400 Subject: [PATCH] [libc++] Unify the benchmarks with the test suite Instead of bui

[libcxx] [libcxxabi] [libunwind] [llvm] [libc++] Unify the benchmarks with the test suite (PR #101399)

2024-11-05 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/101399 >From f19ffaabcf0fdf6fc2dbb02200973418fe32be13 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Thu, 25 Jul 2024 10:41:10 -0400 Subject: [PATCH] [libc++] Unify the benchmarks with the test suite Instead of bui

[clang] clang/AMDGPU: Emit grid size builtins with range metadata (PR #113038)

2024-11-05 Thread Louis Dionne via cfe-commits
ldionne wrote: I'm not sure what's special about your usage of Graphite, but I've seen other people use it without triggering these notifications to everyone. This is disruptive: if everyone started doing this, our Github notification system with CODEOWNERS.txt would break down completely beca

[clang] [compiler-rt] [libcxx] [llvm] [libc++] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY & friends by a new LIBCXX_CXX_ABI choice (PR #112978)

2024-11-04 Thread Louis Dionne via cfe-commits
ldionne wrote: @petrhosek I'm curious to know what you think of this design. https://github.com/llvm/llvm-project/pull/112978 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] [libcxxabi] [libunwind] [llvm] [libc++] Unify the benchmarks with the test suite (PR #101399)

2024-10-30 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/101399 >From a50fa3f81b486c949f20c614101a66e38e0f92e6 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Wed, 31 Jul 2024 13:00:25 -0400 Subject: [PATCH 1/4] [libc++] Make benchmarks forward-compatible with the test su

[libcxx] [libcxxabi] [libunwind] [llvm] [libc++] Unify the benchmarks with the test suite (PR #101399)

2024-10-23 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/101399 >From 0faad749460f8858b87064f97de62e5029090ac9 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Wed, 31 Jul 2024 13:00:25 -0400 Subject: [PATCH 1/2] [libc++] Make benchmarks forward-compatible with the test su

[libcxx] [libcxxabi] [libunwind] [llvm] [libc++] Unify the benchmarks with the test suite (PR #101399)

2024-10-23 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/101399 >From 0faad749460f8858b87064f97de62e5029090ac9 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Wed, 31 Jul 2024 13:00:25 -0400 Subject: [PATCH 1/2] [libc++] Make benchmarks forward-compatible with the test su

[libcxx] [libcxxabi] [libunwind] [llvm] [libc++] Unify the benchmarks with the test suite (PR #101399)

2024-10-31 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/101399 >From cff8de9231ad461b82f9522d7a93b73ea0641e52 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Wed, 31 Jul 2024 13:00:25 -0400 Subject: [PATCH 1/4] [libc++] Make benchmarks forward-compatible with the test su

[libcxx] [libcxxabi] [libunwind] [llvm] [runtimes] Run backdeployment CI on Github hosted runners (PR #109984)

2024-09-26 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/109984 >From 6567a45fca93b81da2ccb0d596aa0be84666eab1 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Wed, 25 Sep 2024 09:55:53 -0400 Subject: [PATCH 1/4] [runtimes] Run backdeployment CI on Github hosted runners Th

[libcxx] [libcxxabi] [libunwind] [llvm] [runtimes] Run backdeployment CI on Github hosted runners (PR #109984)

2024-09-26 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/109984 >From 6567a45fca93b81da2ccb0d596aa0be84666eab1 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Wed, 25 Sep 2024 09:55:53 -0400 Subject: [PATCH 1/3] [runtimes] Run backdeployment CI on Github hosted runners Th

[libcxx] [libcxxabi] [libunwind] [llvm] [runtimes] Run backdeployment CI on Github hosted runners (PR #109984)

2024-09-26 Thread Louis Dionne via cfe-commits
https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/109984 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [libunwind] Introduce LIBUNWIND_LIBRARY_VERSION and drop outdated Apple flags (PR #110178)

2024-09-26 Thread Louis Dionne via cfe-commits
https://github.com/ldionne created https://github.com/llvm/llvm-project/pull/110178 This patch introduces the LIBUNWIND_LIBRARY_VERSION setting to control the dylib version of libunwind. This allows expressing the dylib version in CMake instead of adding custom compiler flags. As a drive-by,

[libunwind] [libunwind][CMake] Remove LIBUNWIND_BUILD_32_BITS which has been an error for 3 years (PR #110175)

2024-09-26 Thread Louis Dionne via cfe-commits
https://github.com/ldionne created https://github.com/llvm/llvm-project/pull/110175 None >From 77b8da53c769106ac75e818c4ea8a37b6e927a4f Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Thu, 26 Sep 2024 17:48:24 -0400 Subject: [PATCH] [libunwind][CMake] Remove LIBUNWIND_BUILD_32_BITS which has

[libcxxabi] [libunwind] [libc++abi][libunwind] Run c++abi and unwind tests against a fake install root (PR #110171)

2024-09-26 Thread Louis Dionne via cfe-commits
https://github.com/ldionne created https://github.com/llvm/llvm-project/pull/110171 This is what we started doing in libc++ and it straightens up a lot of things that only happened to work before, notably the presence of relative rpaths in dylibs when running from the build tree. This unlocks

[libcxx] [libcxxabi] [libunwind] [libc++abi][libunwind] Run c++abi and unwind tests against a fake install root (PR #110171)

2024-09-27 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/110171 >From f6c1590f9513ecab8fe0ea6db8b5367513ce95a1 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Thu, 26 Sep 2024 17:09:32 -0400 Subject: [PATCH 1/2] [libc++abi][libunwind] Run c++abi and unwind tests against a

[libunwind] [libunwind][CMake] Remove LIBUNWIND_BUILD_32_BITS which has been an error for 3 years (PR #110175)

2024-09-27 Thread Louis Dionne via cfe-commits
https://github.com/ldionne closed https://github.com/llvm/llvm-project/pull/110175 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [libunwind] Introduce LIBUNWIND_LIBRARY_VERSION and drop outdated Apple flags (PR #110178)

2024-09-27 Thread Louis Dionne via cfe-commits
https://github.com/ldionne closed https://github.com/llvm/llvm-project/pull/110178 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] [libcxxabi] [libunwind] [libc++abi][libunwind] Run c++abi and unwind tests against a fake install root (PR #110171)

2024-09-27 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/110171 >From f6c1590f9513ecab8fe0ea6db8b5367513ce95a1 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Thu, 26 Sep 2024 17:09:32 -0400 Subject: [PATCH] [libc++abi][libunwind] Run c++abi and unwind tests against a fak

[clang] [libcxx] [Clang] Add __builtin_common_type (PR #99473)

2024-09-30 Thread Louis Dionne via cfe-commits
@@ -14,16 +14,30 @@ #include <__type_traits/decay.h> #include <__type_traits/is_same.h> #include <__type_traits/remove_cvref.h> +#include <__type_traits/type_identity.h> #include <__type_traits/void_t.h> #include <__utility/declval.h> +#include <__utility/empty.h> #if !def

[clang] [libcxx] [libc++][modules] Rewrite the modulemap to have fewer top-level modules (PR #110501)

2024-09-30 Thread Louis Dionne via cfe-commits
@@ -1,2125 +1,2235 @@ -// Main C++ standard library interfaces -module std_algorithm [system] { - header "algorithm" - export * -} -module std_any [system] { - header "any" - export * -} -module std_array [system] { - header "array" - export * -} -module std_atomic [system]

[clang] [libcxx] [Clang] Add __builtin_common_type (PR #99473)

2024-09-30 Thread Louis Dionne via cfe-commits
@@ -14,16 +14,30 @@ #include <__type_traits/decay.h> #include <__type_traits/is_same.h> #include <__type_traits/remove_cvref.h> +#include <__type_traits/type_identity.h> #include <__type_traits/void_t.h> #include <__utility/declval.h> +#include <__utility/empty.h> #if !def

[libcxx] [libcxxabi] [libunwind] [libc++abi][libunwind] Run c++abi and unwind tests against a fake install root (PR #110171)

2024-09-30 Thread Louis Dionne via cfe-commits
https://github.com/ldionne closed https://github.com/llvm/llvm-project/pull/110171 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] [libcxxabi] [libunwind] [llvm] [runtimes] Run backdeployment CI on Github hosted runners (PR #109984)

2024-09-30 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/109984 >From 8b98482170459226ddfe7ba77f6b88f20d27d319 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Wed, 25 Sep 2024 09:55:53 -0400 Subject: [PATCH] [runtimes] Run backdeployment CI on Github hosted runners This r

[libcxx] [libcxxabi] [libunwind] [llvm] [runtimes] Run backdeployment CI on Github hosted runners (PR #109984)

2024-09-30 Thread Louis Dionne via cfe-commits
https://github.com/ldionne closed https://github.com/llvm/llvm-project/pull/109984 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] [libcxxabi] [libunwind] [llvm] [runtimes] Probe for -nostdlib++ and -nostdinc++ with the C compiler (PR #108357)

2024-10-01 Thread Louis Dionne via cfe-commits
@@ -38,9 +38,13 @@ check_cxx_compiler_flag(-nolibc CXX_SUPPORTS_NOLIBC_FLAG) # required during compilation (which has the -nostdlib++ or -nodefaultlibs). libc is # required for the link to go through. We remove sanitizers from the # configuration checks to avoid spurious link

[libcxx] [libcxxabi] [libunwind] [llvm] [runtimes] Run backdeployment CI on Github hosted runners (PR #109984)

2024-09-25 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/109984 >From 6567a45fca93b81da2ccb0d596aa0be84666eab1 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Wed, 25 Sep 2024 09:55:53 -0400 Subject: [PATCH] [runtimes] Run backdeployment CI on Github hosted runners This r

[libcxx] [libcxxabi] [libunwind] [llvm] [runtimes] Run backdeployment CI on Github hosted runners (PR #109984)

2024-09-25 Thread Louis Dionne via cfe-commits
https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/109984 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] [libcxxabi] [libunwind] [llvm] [runtimes] Run backdeployment CI on Github hosted runners (PR #109984)

2024-09-25 Thread Louis Dionne via cfe-commits
https://github.com/ldionne ready_for_review https://github.com/llvm/llvm-project/pull/109984 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] [libcxxabi] [libunwind] [llvm] [runtimes] Run backdeployment CI on Github hosted runners (PR #109984)

2024-09-25 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/109984 >From b03b189897358070290549af67bfd3705ec3c203 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Wed, 25 Sep 2024 09:55:53 -0400 Subject: [PATCH 1/2] [runtimes] Run backdeployment CI on Github hosted runners Th

[libcxx] [libcxxabi] [libunwind] [llvm] [runtimes] Run backdeployment CI on Github hosted runners (PR #109984)

2024-09-25 Thread Louis Dionne via cfe-commits
https://github.com/ldionne created https://github.com/llvm/llvm-project/pull/109984 This removes the need for macOS nodes in Buildkite. It also moves to the proper way of testing backdeployment, which is to actually run on the target OS itself, instead of using packaged dylibs from previous OS

[libcxx] [libcxxabi] [libunwind] [llvm] [runtimes] Run backdeployment CI on Github hosted runners (PR #109984)

2024-09-25 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/109984 >From b03b189897358070290549af67bfd3705ec3c203 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Wed, 25 Sep 2024 09:55:53 -0400 Subject: [PATCH 1/3] [runtimes] Run backdeployment CI on Github hosted runners Th

[libcxx] [libcxxabi] [libunwind] [llvm] [runtimes] Run backdeployment CI on Github hosted runners (PR #109984)

2024-09-25 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/109984 >From b03b189897358070290549af67bfd3705ec3c203 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Wed, 25 Sep 2024 09:55:53 -0400 Subject: [PATCH 1/4] [runtimes] Run backdeployment CI on Github hosted runners Th

[libcxx] [libcxxabi] [libunwind] [llvm] [runtimes] Run backdeployment CI on Github hosted runners (PR #109984)

2024-09-25 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/109984 >From 6567a45fca93b81da2ccb0d596aa0be84666eab1 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Wed, 25 Sep 2024 09:55:53 -0400 Subject: [PATCH 1/2] [runtimes] Run backdeployment CI on Github hosted runners Th

[libcxx] [libcxxabi] [libunwind] [libc++abi][libunwind] Run c++abi and unwind tests against a fake install root (PR #110171)

2024-10-01 Thread Louis Dionne via cfe-commits
ldionne wrote: Thanks for the analysis. Per-target runtime dir strikes again! That setting keeps on creating issues (by no fault of its own) because it's not the default. Can we do something like this instead, then? ``` config.substitutions.append(('%{lib}', '@LIBUNWIND_TESTING_INSTALL_PREFIX

[clang] [compiler-rt] [libcxx] [cmake] Add hexagon-linux cmake cache files (PR #98712)

2024-10-01 Thread Louis Dionne via cfe-commits
@@ -0,0 +1,25 @@ + ldionne wrote: Ack. Just be aware that so long as there's no CI job, the platform is not officially supported so it may happen that we'll make changes that will make your life harder. We won't do it on purpose, of course, but it could happen

[clang] [compiler-rt] [libcxx] [cmake] Add hexagon-linux cmake cache files (PR #98712)

2024-10-01 Thread Louis Dionne via cfe-commits
https://github.com/ldionne approved this pull request. https://github.com/llvm/llvm-project/pull/98712 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[compiler-rt] [libcxx] [libcxxabi] [libunwind] [libunwind][libcxx][libcxxabi][compiler-rt-builtins] Fix Exception Handling build for wasm (PR #79667)

2024-10-02 Thread Louis Dionne via cfe-commits
https://github.com/ldionne requested changes to this pull request. I think support for wasm mandates a short RFC, like most projects to support new platforms that require non-trivial changes. There's not a huge amount of changes in this patch, but it's also unclear to me that this is sufficient

[libunwind] [libunwind] Fix libunwind library path for runtime test (PR #110777)

2024-10-02 Thread Louis Dionne via cfe-commits
https://github.com/ldionne approved this pull request. LGTM assuming the CI is green. https://github.com/llvm/llvm-project/pull/110777 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [libunwind] Fix libunwind library path for runtime test (PR #110777)

2024-10-02 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/110777 >From cb81337ae2828f330424b3c45a4161bc1e88ae18 Mon Sep 17 00:00:00 2001 From: Haowei Wu Date: Tue, 1 Oct 2024 18:16:44 -0700 Subject: [PATCH] [libunwind] Fix libunwind library path for runtime test This patch f

[libunwind] [libunwind] Fix libunwind library path for runtime test (PR #110777)

2024-10-02 Thread Louis Dionne via cfe-commits
ldionne wrote: I rebased onto `main` to trigger the CI again. https://github.com/llvm/llvm-project/pull/110777 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [libunwind] Fix libunwind library path for runtime test (PR #110777)

2024-10-02 Thread Louis Dionne via cfe-commits
ldionne wrote: This can be merged by whoever sees the CI green first. https://github.com/llvm/llvm-project/pull/110777 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libcxx] [clang] remove extra space in warn_atomic_op_oversized (NFC) (PR #110955)

2024-10-03 Thread Louis Dionne via cfe-commits
https://github.com/ldionne approved this pull request. https://github.com/llvm/llvm-project/pull/110955 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libcxx] [clang] remove extra space in warn_atomic_op_oversized (NFC) (PR #110955)

2024-10-03 Thread Louis Dionne via cfe-commits
ldionne wrote: I'm not a codeowner for Clang, but in this case I think the change is simple enough that this is good to go. https://github.com/llvm/llvm-project/pull/110955 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[libcxx] [libcxxabi] [libunwind] [runtimes] Always define cxx_shared, cxx_static & other targets (PR #80007)

2024-10-03 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/80007 >From 33a4c2504236f47ef244d808bebc9a01b916b7c3 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Wed, 12 Oct 2022 18:06:32 -0400 Subject: [PATCH] [runtimes] Always define cxx_shared, cxx_static & other targets

[libcxx] [libcxxabi] [libunwind] [runtimes] Always define cxx_shared, cxx_static & other targets (PR #80007)

2024-10-03 Thread Louis Dionne via cfe-commits
ldionne wrote: @petrhosek @vitalybuka Gentle ping. If the CI is green, I will land this next week unless someone objects to it. I don't want to purposefully break anyone's build, but I also don't want to hold off on this change forever if there's nothing actionable. Last time in https://revie

[clang] [libc++] Remove unused HAVE_LIBCXXABI variable from Android cache (PR #111007)

2024-10-03 Thread Louis Dionne via cfe-commits
https://github.com/ldionne created https://github.com/llvm/llvm-project/pull/111007 This variable isn't used anymore in libc++'s build and hasn't been for a few years, so this is likely a remnant of the past. >From 7b29252b9150e0b4d2939afe1c6b33a6e9d52a0b Mon Sep 17 00:00:00 2001 From: Louis D

[libcxx] [libcxxabi] [libunwind] [llvm] [libc++] Unify the benchmarks with the test suite (PR #101399)

2024-11-07 Thread Louis Dionne via cfe-commits
https://github.com/ldionne closed https://github.com/llvm/llvm-project/pull/101399 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [ci] New script to generate test reports as Buildkite Annotations (PR #113447)

2024-10-25 Thread Louis Dionne via cfe-commits
ldionne wrote: Ack, thanks for the confirmation. > If we wanted to send the report as a comment on GitHub, we can certainly look > into that as mentioned here > https://discourse.llvm.org/t/using-plugins-in-buildkite-ci-that-require-docker/82701/6?u=davidspickett. > The Buildkite specific par

[clang] [Clang] Add a flag to include GPU startup files (PR #112025)

2024-10-25 Thread Louis Dionne via cfe-commits
ldionne wrote: Just to clarify, I'm mostly neutral on this. A Clang reviewer should chime in and evaluate the change for what it is. It does simplify the setup of the libc++ test suite for GPU, but it's not required since we have other options to set things up. https://github.com/llvm/llvm-pr

[libcxx] [libcxxabi] [libunwind] [runtimes] Improve the documentation for LIBCXX_ADDITIONAL_COMPILE_FLAGS (PR #112733)

2024-10-17 Thread Louis Dionne via cfe-commits
https://github.com/ldionne created https://github.com/llvm/llvm-project/pull/112733 This clarifies how that option is meant to be used to avoid confusion. As a drive-by, also fix an incorrect usage in the recently-added GPU caches. >From 32dbc3a85d37be3b7e7331671d7faa0c47d7ef70 Mon Sep 17 00:0

[libcxx] [libcxxabi] [libunwind] [CMake] Handle multiple flags in ADDITIONAL_COMPILE_FLAGS properly (PR #112703)

2024-10-17 Thread Louis Dionne via cfe-commits
ldionne wrote: https://github.com/llvm/llvm-project/pull/112733 https://github.com/llvm/llvm-project/pull/112703 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[compiler-rt] [libunwind] [llvm] [cmake] Remove obsolete files, docs and CMake variables related to the standalone build (PR #112741)

2024-10-17 Thread Louis Dionne via cfe-commits
https://github.com/ldionne created https://github.com/llvm/llvm-project/pull/112741 The runtimes used to support a build mode called the "Standalone build", which isn't supported anymore (and hasn't been for a few years). However, various places in the code still contained stuff whose only pur

[libcxx] [libcxxabi] [libunwind] [runtimes] Avoid cluttering the top-level build directory with test artifacts (PR #112717)

2024-10-17 Thread Louis Dionne via cfe-commits
https://github.com/ldionne created https://github.com/llvm/llvm-project/pull/112717 Instead of placing artifacts for testing the runtimes at /test, place those artifacts at //test. This prevents cluttering the build directory with the runtimes' test artifacts for everyone else. As a drive-by,

[libcxx] [libcxxabi] [libunwind] [CMake] Handle multiple flags in ADDITIONAL_COMPILE_FLAGS properly (PR #112703)

2024-10-17 Thread Louis Dionne via cfe-commits
ldionne wrote: This is really tricky, however I believe the current behavior is correct (and in fact it's the only correct way of handling this). The `{LIBCXX,LIBCXXABI,LIBUNWIND}_ADDITIONAL_COMPILE_FLAGS` options expect to be passed something that is already formatted as a CMake list with `;`

[libcxx] [libcxxabi] [libunwind] [llvm] [libc++] Unify the benchmarks with the test suite (PR #101399)

2024-11-06 Thread Louis Dionne via cfe-commits
ldionne wrote: > I do care. I sometimes like to compare benchmarks from different iterations. > Currently when I build a benchmark I get a message where the executable is > stored. The new approach makes harder to find the location of the executable. > I wonder whether we can show a message wh

[clang] [compiler-rt] [libcxx] [libcxxabi] [llvm] [libc++] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY & friends by a new LIBCXX_CXX_ABI choice (PR #112978)

2024-11-29 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/112978 >From 7c156ea8545fd9b5211c488ba5c4386c368d5f82 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Fri, 13 May 2022 09:26:01 -0400 Subject: [PATCH 1/5] [libc++] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY & friends

[clang] [compiler-rt] [libcxx] [llvm] [libc++] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY & friends by a new LIBCXX_CXX_ABI choice (PR #112978)

2024-11-28 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/112978 >From 3db70453e07f1378ed4d07023dc2a6cf2541b935 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Fri, 13 May 2022 09:26:01 -0400 Subject: [PATCH 1/4] [libc++] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY & friends

[clang] [libcxx] [libcxx] Support for using timespec_get (PR #117362)

2024-11-28 Thread Louis Dionne via cfe-commits
https://github.com/ldionne approved this pull request. The libc++ part LGTM. I don't really understand the `Fuchsia-stage2.cmake` changes but I'm not sure I need to. However, please rebase this on top of `main` and make sure that the CI is green before you merge. https://github.com/llvm/llvm-

[libunwind] [libunwind] Make sure `__STDC_FORMAT_MACROS` is defined to ensure `PRId64` is available (PR #117491)

2024-11-28 Thread Louis Dionne via cfe-commits
https://github.com/ldionne approved this pull request. https://github.com/llvm/llvm-project/pull/117491 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxxabi] [libunwind] [libcxxabi][libunwind] Support for using LLVM libc (PR #101688)

2024-11-28 Thread Louis Dionne via cfe-commits
https://github.com/ldionne closed https://github.com/llvm/llvm-project/pull/101688 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxxabi] [libunwind] [libcxxabi][libunwind] Support for using LLVM libc (PR #101688)

2024-11-28 Thread Louis Dionne via cfe-commits
ldionne wrote: Closing as stale, please reopen if you still want to pursue. https://github.com/llvm/llvm-project/pull/101688 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [libcxx] [libcxxabi] [llvm] [libc++] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY & friends by a new LIBCXX_CXX_ABI choice (PR #112978)

2024-11-29 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/112978 >From 7c156ea8545fd9b5211c488ba5c4386c368d5f82 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Fri, 13 May 2022 09:26:01 -0400 Subject: [PATCH 1/6] [libc++] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY & friends

[libunwind] [libunwind] Make sure `__STDC_FORMAT_MACROS` is defined to ensure `PRId64` is available (PR #117491)

2024-11-29 Thread Louis Dionne via cfe-commits
ldionne wrote: Ah, I didn't realize this was only required for much older compilers. In that case, indeed we don't support GCC 8 so we probably don't want to merge this. https://github.com/llvm/llvm-project/pull/117491 ___ cfe-commits mailing list cfe

[clang] [compiler-rt] [libcxx] [llvm] [libc++] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY & friends by a new LIBCXX_CXX_ABI choice (PR #112978)

2024-11-19 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/112978 >From e42db172b2397e6358dc60850e4c8b085c6bd4bf Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Fri, 13 May 2022 09:26:01 -0400 Subject: [PATCH 1/4] [libc++] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY & friends

[clang] [libcxx] [Clang] Add __builtin_invoke and detect std::invoke as a builtin (PR #116709)

2024-11-26 Thread Louis Dionne via cfe-commits
ldionne wrote: > > AFAICT we have one test for `invoke` plus a constexpr test which should > really just be rolled into the generic `invoke` test. That test is ~400 LoC, > which is definitely not nothing, but also not unmanageable IMO. We could > probably also simplify that by not explicitly

[clang] [compiler-rt] [libcxx] [libcxxabi] [llvm] [libc++] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY & friends by a new LIBCXX_CXX_ABI choice (PR #112978)

2024-12-02 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/112978 >From fbb6db25d2d52b19486c395d0855e7af4b8812a3 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Fri, 13 May 2022 09:26:01 -0400 Subject: [PATCH 1/6] [libc++] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY & friends

[libcxx] [libunwind] [llvm] [libc++][libunwind] Fix documentation CI job after #118159 (PR #118555)

2024-12-03 Thread Louis Dionne via cfe-commits
https://github.com/ldionne created https://github.com/llvm/llvm-project/pull/118555 None >From b3b1cb221aa7388a3d72f1774c70392042139b04 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Tue, 3 Dec 2024 17:06:22 -0500 Subject: [PATCH 1/2] [libc++][libunwind] Fix documentation CI job after #118

[libunwind] [libunwind] Make sure `__STDC_FORMAT_MACROS` is defined to ensure `PRId64` is available (PR #117491)

2024-12-05 Thread Louis Dionne via cfe-commits
https://github.com/ldionne closed https://github.com/llvm/llvm-project/pull/117491 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [libunwind] Make sure `__STDC_FORMAT_MACROS` is defined to ensure `PRId64` is available (PR #117491)

2024-12-05 Thread Louis Dionne via cfe-commits
ldionne wrote: Since we support only the latest released GCC in the runtimes, so I don't think it makes sense to merge this. Newer GCCs don't seem to have this issue. Closing, please reopen if you'd like to pursue this despite the above information and we can chat. https://github.com/llvm/llv

[libclc] [libcxx] [llvm] [polly] [llvm] Move sub-project lead maintainers into their own Maintainers.md files (PR #118309)

2024-12-06 Thread Louis Dionne via cfe-commits
https://github.com/ldionne approved this pull request. https://github.com/llvm/llvm-project/pull/118309 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libcxx] [libc++] Rename `__` prefix to `__libcpp_` for locale related functions (PR #119241)

2024-12-09 Thread Louis Dionne via cfe-commits
https://github.com/ldionne requested changes to this pull request. Instead, can't you `#undef` these macros? We're trying to move away from defining names with `__libcpp`. https://github.com/llvm/llvm-project/pull/119241 ___ cfe-commits mailing list c

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #120149)

2025-01-07 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/120149 >From ac165075f270af65395a3709a1457b61ed97ea31 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Mon, 16 Dec 2024 13:28:38 -0500 Subject: [PATCH 1/6] [clang][Darwin] Remove legacy framework search path logic in

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #120149)

2025-01-07 Thread Louis Dionne via cfe-commits
@@ -8265,6 +8265,11 @@ def internal_externc_isystem : Separate<["-"], "internal-externc-isystem">, "implicit extern \"C\" semantics; these are assumed to not be " "user-provided and are used to model system and standard headers' " "paths.">; +d

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #120149)

2025-01-07 Thread Louis Dionne via cfe-commits
@@ -2539,6 +2550,18 @@ void DarwinClang::AddClangSystemIncludeArgs(const llvm::opt::ArgList &DriverArgs llvm::sys::path::append(P, "usr", "include"); addExternCSystemInclude(DriverArgs, CC1Args, P.str()); } + + // Add default framework search paths + auto addFramew

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #120149)

2025-01-07 Thread Louis Dionne via cfe-commits
@@ -8265,6 +8265,11 @@ def internal_externc_isystem : Separate<["-"], "internal-externc-isystem">, "implicit extern \"C\" semantics; these are assumed to not be " "user-provided and are used to model system and standard headers' " "paths.">; +d

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #120149)

2025-01-07 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/120149 >From ac165075f270af65395a3709a1457b61ed97ea31 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Mon, 16 Dec 2024 13:28:38 -0500 Subject: [PATCH 1/8] [clang][Darwin] Remove legacy framework search path logic in

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #120149)

2025-01-07 Thread Louis Dionne via cfe-commits
@@ -8265,6 +8265,11 @@ def internal_externc_isystem : Separate<["-"], "internal-externc-isystem">, "implicit extern \"C\" semantics; these are assumed to not be " "user-provided and are used to model system and standard headers' " "paths.">; +d

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #120149)

2025-01-07 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/120149 >From ac165075f270af65395a3709a1457b61ed97ea31 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Mon, 16 Dec 2024 13:28:38 -0500 Subject: [PATCH 1/7] [clang][Darwin] Remove legacy framework search path logic in

[clang] [libcxx] [libc++] Rename `__` prefix to `__libcpp_` for locale related functions (PR #119241)

2025-01-30 Thread Louis Dionne via cfe-commits
https://github.com/ldionne closed https://github.com/llvm/llvm-project/pull/119241 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] Silence -Wunused-parameter warnings in Unwind-wasm.c (PR #125412)

2025-02-05 Thread Louis Dionne via cfe-commits
@@ -102,8 +102,9 @@ _LIBUNWIND_EXPORT uintptr_t _Unwind_GetIP(struct _Unwind_Context *context) { } /// Not used in Wasm. -_LIBUNWIND_EXPORT void _Unwind_SetIP(struct _Unwind_Context *context, - uintptr_t value) {} +_LIBUNWIND_EXPORT void +_

[libunwind] Silence -Wunused-parameter warnings in Unwind-wasm.c (PR #125412)

2025-02-05 Thread Louis Dionne via cfe-commits
@@ -116,7 +117,7 @@ _Unwind_GetLanguageSpecificData(struct _Unwind_Context *context) { /// Not used in Wasm. _LIBUNWIND_EXPORT uintptr_t -_Unwind_GetRegionStart(struct _Unwind_Context *context) { +_Unwind_GetRegionStart([[maybe_unused]] struct _Unwind_Context *context) {

[libunwind] Silence -Wunused-parameter warnings in Unwind-wasm.c (PR #125412)

2025-02-05 Thread Louis Dionne via cfe-commits
https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/125412 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] Silence -Wunused-parameter warnings in Unwind-wasm.c (PR #125412)

2025-02-05 Thread Louis Dionne via cfe-commits
https://github.com/ldionne commented: IMO this is reasonable but it's simpler to drop the parameter names in this case, no need for `[[maybe_unused]]`. https://github.com/llvm/llvm-project/pull/125412 ___ cfe-commits mailing list cfe-commits@lists.llv

[clang] [libcxx] [libc++] Rename `__` prefix to `__libcpp_` for locale related functions (PR #119241)

2025-01-30 Thread Louis Dionne via cfe-commits
ldionne wrote: Closing in the meantime, please reopen this PR or create a new one with the new approach whenever you're ready! https://github.com/llvm/llvm-project/pull/119241 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[libcxxabi] [libunwind] [libc++abi] Provide an explicit error when trying to build for MSVC (PR #119370)

2024-12-11 Thread Louis Dionne via cfe-commits
https://github.com/ldionne closed https://github.com/llvm/llvm-project/pull/119370 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libcxx] [libcxx] Support for using timespec_get (PR #117362)

2024-12-10 Thread Louis Dionne via cfe-commits
ldionne wrote: Gentle ping https://github.com/llvm/llvm-project/pull/117362 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxxabi] [libunwind] [libc++abi] Provide an explicit error when trying to build for MSVC (PR #119370)

2024-12-10 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/119370 >From 259f1eecac3abf0ffdc5c41ef9edae35c604ee26 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Tue, 10 Dec 2024 07:42:00 -0500 Subject: [PATCH] [libc++abi][libunwind] Provide an explicit error when trying to

[libcxxabi] [libunwind] [libc++abi] Provide an explicit error when trying to build for MSVC (PR #119370)

2024-12-10 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/119370 >From c9f83596fbfa0423245eecbc9c4d9f65163648f1 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Tue, 10 Dec 2024 07:42:00 -0500 Subject: [PATCH] [libc++abi][libunwind] Provide an explicit error when trying to

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #120149)

2024-12-16 Thread Louis Dionne via cfe-commits
https://github.com/ldionne created https://github.com/llvm/llvm-project/pull/120149 This removes a long standing piece of technical debt. Most other platforms have moved all their header search path logic to the driver, but Darwin still had some logic for setting framework search paths present

[clang] [Clang][Darwin] Centralize framework search paths for headers & libraries. (PR #118543)

2024-12-16 Thread Louis Dionne via cfe-commits
@@ -339,13 +340,11 @@ void InitHeaderSearch::AddDefaultIncludePaths( if (triple.isOSDarwin()) { ldionne wrote: I'm trying to revive this as https://github.com/llvm/llvm-project/pull/120149 https://github.com/llvm/llvm-project/pull/118543 _

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #75841)

2024-12-16 Thread Louis Dionne via cfe-commits
ldionne wrote: @brad0 Revived as https://github.com/llvm/llvm-project/pull/120149 https://github.com/llvm/llvm-project/pull/75841 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #75841)

2024-12-16 Thread Louis Dionne via cfe-commits
ldionne wrote: Sorry for the spurious request for review here, this is the wrong PR. https://github.com/llvm/llvm-project/pull/75841 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #120149)

2024-12-16 Thread Louis Dionne via cfe-commits
@@ -1,13 +1,6 @@ -// RUN: %clang -cc1 -fcuda-is-device -isysroot /var/empty \ -// RUN: -triple nvptx-nvidia-cuda -aux-triple i386-apple-macosx \ -// RUN: -E -fcuda-is-device -v -o /dev/null -x cuda %s 2>&1 | FileCheck %s - -// RUN: %clang -cc1 -isysroot /var/empty \ -// RUN:

[clang] [compiler-rt] [libcxx] [libcxxabi] [llvm] [libc++] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY & friends by a new LIBCXX_CXX_ABI choice (PR #112978)

2024-12-16 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/112978 >From 7b8f1538b452d6c16874d0f076baa2d54abb66b0 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Fri, 13 May 2022 09:26:01 -0400 Subject: [PATCH 1/2] [libc++] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY & friends

[libunwind] [Libunwind] Don't XFAIL tests with msan (PR #120013)

2024-12-16 Thread Louis Dionne via cfe-commits
ldionne wrote: Rebased onto `main` to re-trigger CI, which should solve the errors you were seeing. I don't remember why these `XFAIL`s were added, but if the CI passes with them removed, I'm happy. https://github.com/llvm/llvm-project/pull/120013 _

[libunwind] [Libunwind] Don't XFAIL tests with msan (PR #120013)

2024-12-16 Thread Louis Dionne via cfe-commits
https://github.com/ldionne approved this pull request. LGTM if the CI is green. https://github.com/llvm/llvm-project/pull/120013 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [Libunwind] Don't XFAIL tests with msan (PR #120013)

2024-12-16 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/120013 >From 51c5f794e4c3253675f83821fd58bdefdfcf0c67 Mon Sep 17 00:00:00 2001 From: Dmitry Chestnykh Date: Sun, 15 Dec 2024 21:18:23 +0300 Subject: [PATCH] [Libunwind] Don't XFAIL tests with msan --- libunwind/test/

<    4   5   6   7   8   9   10   >