https://github.com/ldionne approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/95374
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,807 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/ldionne edited
https://github.com/llvm/llvm-project/pull/75371
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ldionne updated
https://github.com/llvm/llvm-project/pull/94791
>From 783f2820037dbe25673a67bbbf15297738466184 Mon Sep 17 00:00:00 2001
From: Louis Dionne
Date: Fri, 31 May 2024 10:55:53 -0700
Subject: [PATCH] [libc++] Fix deployment target Lit features
We were not making an
https://github.com/ldionne updated
https://github.com/llvm/llvm-project/pull/94791
>From ba1b9edc06ce05f1112895dbbd965a64c5838c98 Mon Sep 17 00:00:00 2001
From: Louis Dionne
Date: Fri, 31 May 2024 10:55:53 -0700
Subject: [PATCH 1/2] [libc++] Fix deployment target Lit features
We were not makin
https://github.com/ldionne edited
https://github.com/llvm/llvm-project/pull/94791
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ldionne edited
https://github.com/llvm/llvm-project/pull/94791
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ldionne updated
https://github.com/llvm/llvm-project/pull/94791
>From ba1b9edc06ce05f1112895dbbd965a64c5838c98 Mon Sep 17 00:00:00 2001
From: Louis Dionne
Date: Fri, 31 May 2024 10:55:53 -0700
Subject: [PATCH 1/2] [libc++] Fix deployment target Lit features
We were not makin
https://github.com/ldionne approved this pull request.
LGTM. The CI failures are flakes.
https://github.com/llvm/llvm-project/pull/93429
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ldionne requested changes to this pull request.
Actually, I think some of the libunwind failures on BuildKite are legitimate.
See https://buildkite.com/llvm-project/libcxx-ci/builds/35920.
https://github.com/llvm/llvm-project/pull/93429
___
ldionne wrote:
The Bootstraping build seems to be failing with a real error:
https://github.com/llvm/llvm-project/actions/runs/9596576098/job/26465655299?pr=96171
https://github.com/llvm/llvm-project/pull/96171
___
cfe-commits mailing list
cfe-commits
https://github.com/ldionne edited
https://github.com/llvm/llvm-project/pull/94791
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ldionne wrote:
I looked into it and I don't quite understand. We should definitely be building
with `-fno-exceptions` in that configuration (and I can see that in the logs),
so I don't understand why we have things like:
```
| ld.lld: error: undefined symbol: __cxa_begin_catch
| >>> referenced
ldionne wrote:
Yeah I think this is a great cleanup, I think we just need to fix the CI issues.
https://github.com/llvm/llvm-project/pull/96171
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
https://github.com/ldionne closed
https://github.com/llvm/llvm-project/pull/94791
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1,82 +0,0 @@
-#===--===##
ldionne wrote:
I did check and it can be removed. I wrote that script so hopefully I’m not
mistaken!
I will also go and clean up (remove the clang-ci pipeline on B
https://github.com/ldionne created
https://github.com/llvm/llvm-project/pull/93542
A while back, the cxx_under_test Lit parameter was removed. This patch
reintroduces a Lit parameter called "compiler" which controls the value of the
%{cxx} substitution used in the test suite.
To run the test
https://github.com/ldionne created
https://github.com/llvm/llvm-project/pull/93558
Instead of using FOO_TEST_DEPS global variables that don't get updated properly
from subdirectories, use targets to propagate the dependencies across
directories.
>From 1681e650b2fa0f0efab760eec341d2372873218b
https://github.com/ldionne updated
https://github.com/llvm/llvm-project/pull/93542
>From 95ca5b389506f0a2e32abd0af632af5a87d3c356 Mon Sep 17 00:00:00 2001
From: Louis Dionne
Date: Tue, 28 May 2024 07:43:34 -0400
Subject: [PATCH 1/2] [runtimes] Reintroduce a way to select the compiler used
for
https://github.com/ldionne approved this pull request.
libcxx/ changes LGTM.
https://github.com/llvm/llvm-project/pull/93417
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ldionne wrote:
Can we either finish this up or close it, please? I'd like to tidy up the
libc++ review queue.
https://github.com/llvm/llvm-project/pull/86806
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailma
https://github.com/ldionne closed
https://github.com/llvm/llvm-project/pull/93542
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ldionne closed
https://github.com/llvm/llvm-project/pull/93558
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ldionne wrote:
CI failure is an android fluke, merging!
https://github.com/llvm/llvm-project/pull/93558
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ldionne closed
https://github.com/llvm/llvm-project/pull/66265
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ldionne wrote:
Not pursuing anymore, closing to clean up the queue.
https://github.com/llvm/llvm-project/pull/66265
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ldionne edited
https://github.com/llvm/llvm-project/pull/93354
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ldionne approved this pull request.
https://github.com/llvm/llvm-project/pull/93354
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ldionne wrote:
I just approved the CI runs. I think this can be merged once the CI is all
green. Whoever sees this first with push access can merge.
https://github.com/llvm/llvm-project/pull/88406
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
https://github.com/ldionne approved this pull request.
LGTM, the equivalent patch was approved on Phab too.
https://github.com/llvm/llvm-project/pull/89425
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/l
ldionne wrote:
> > > > For SystemZ the correct value is 256.
> > >
> > >
> > > Thanks! Double-checking: for both constructive and destructive?
> >
> >
> > Yes, for both. Every SystemZ model (supported by GCC/LLVM) has a L1 cache
> > line size of 256 bytes.
>
> Excellent, thank you!
>
> > >
https://github.com/ldionne approved this pull request.
https://github.com/llvm/llvm-project/pull/97534
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ldionne wrote:
@AaronBallman Should this be added to the 19.x milestone and cherry-picked?
https://github.com/llvm/llvm-project/pull/99727
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
https://github.com/ldionne milestoned
https://github.com/llvm/llvm-project/pull/99727
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ldionne wrote:
@ian-twilightcoder Cherry-picking is easy. Once this is merged, follow the
guidelines here to get it cherry-picked:
https://llvm.org/docs/GitHub.html#backporting-fixes-to-the-release-branches
Basically you only need to add a comment to this PR like `/cherry-pick
COMMIT-SHA` and
ldionne wrote:
@AaronBallman Just FYI you can also add the Milestone to the PR directly and
use the /cherry-pick command right here. This is a bit simpler.
https://github.com/llvm/llvm-project/pull/97534
___
cfe-commits mailing list
cfe-commits@lists.
ldionne wrote:
@ian-twilightcoder You can create an issue if you want, but you can also say
/cherry-pick directly from the PR as long as you add the release
milestone to it.
That being said, the cherry-pick failed so you will need to create a PR
manually.
https://github.com/llvm/llvm-projec
ldionne wrote:
It seems like the bot looks for the command anywhere in any comment :)
https://github.com/llvm/llvm-project/pull/97534
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ldionne approved this pull request.
libc++ changes LGTM.
https://github.com/llvm/llvm-project/pull/100425
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ldionne approved this pull request.
https://github.com/llvm/llvm-project/pull/101196
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -6,7 +6,7 @@
//
//===--===//
-// REQUIRES: target={{powerpc.*-ibm-aix.*}}
+// REQUIRES: target={{.+}}-aix{{.*}}
ldionne wrote:
`libcxx/test/vendor` is a bit mis-named, I guess. It's more
https://github.com/ldionne approved this pull request.
https://github.com/llvm/llvm-project/pull/96171
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ldionne closed
https://github.com/llvm/llvm-project/pull/96171
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Louis Dionne
Date: 2024-07-31T10:50:34-04:00
New Revision: 7ab643383fe49d5bb22e45610cb52476bf7a922e
URL:
https://github.com/llvm/llvm-project/commit/7ab643383fe49d5bb22e45610cb52476bf7a922e
DIFF:
https://github.com/llvm/llvm-project/commit/7ab643383fe49d5bb22e45610cb52476bf7a922e.diff
ldionne wrote:
@rorth Please check if this is still broken after
https://github.com/llvm/llvm-project/commit/7ab643383fe49d5bb22e45610cb52476bf7a922e
https://github.com/llvm/llvm-project/pull/96171
___
cfe-commits mailing list
cfe-commits@lists.llvm.o
https://github.com/ldionne commented:
This seems reasonable to me, but I have basically no knowledge of risvc or the
rv32e ABI so I'll let someone else stamp this.
https://github.com/llvm/llvm-project/pull/98855
___
cfe-commits mailing list
cfe-commit
ldionne wrote:
@premanandrao There are instructions here:
https://libcxx.llvm.org/BuildingLibcxx.html#bootstrapping-build
You can also use e.g. `run-buildbot` for this job:
https://github.com/llvm/llvm-project/blob/c7961538ff5c73ad03cbf2470e56cdc10cedc83b/libcxx/utils/ci/run-buildbot#L366
You
ldionne wrote:
Is it possible to add a test case for this?
https://github.com/llvm/llvm-project/pull/92291
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ldionne edited
https://github.com/llvm/llvm-project/pull/99287
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -293,6 +293,7 @@ option(LIBCXX_ENABLE_THREADS "Build libc++ with support for
threads." ON)
option(LIBCXX_ENABLE_MONOTONIC_CLOCK
"Build libc++ with support for a monotonic clock.
This option may only be set to OFF when LIBCXX_ENABLE_THREADS=OFF." ON)
+option(LIBCXX_USE_
https://github.com/ldionne requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/99287
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -293,6 +293,7 @@ option(LIBCXX_ENABLE_THREADS "Build libc++ with support for
threads." ON)
option(LIBCXX_ENABLE_MONOTONIC_CLOCK
"Build libc++ with support for a monotonic clock.
This option may only be set to OFF when LIBCXX_ENABLE_THREADS=OFF." ON)
+option(LIBCXX_USE_
@@ -293,6 +293,7 @@ option(LIBCXX_ENABLE_THREADS "Build libc++ with support for
threads." ON)
option(LIBCXX_ENABLE_MONOTONIC_CLOCK
"Build libc++ with support for a monotonic clock.
This option may only be set to OFF when LIBCXX_ENABLE_THREADS=OFF." ON)
+option(LIBCXX_USE_
@@ -293,6 +293,7 @@ option(LIBCXX_ENABLE_THREADS "Build libc++ with support for
threads." ON)
option(LIBCXX_ENABLE_MONOTONIC_CLOCK
"Build libc++ with support for a monotonic clock.
This option may only be set to OFF when LIBCXX_ENABLE_THREADS=OFF." ON)
+option(LIBCXX_USE_
https://github.com/ldionne edited
https://github.com/llvm/llvm-project/pull/99287
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ldionne commented:
I like this approach much better. In a future refactor, I would move
`-nostdlibinc` and `-nostdlib` to the interface target, and eventually
libc++abi and libunwind should use those targets too when building. But this is
a fine first step.
https://github.c
@@ -0,0 +1,34 @@
+#===
+# Define targets for linking against the selected C library
+#
+# After including this file, the following targets are defined:
+# - libcxx-libc-headers: An interface target that al
@@ -226,6 +226,15 @@ set(LIBCXX_ABI_DEFINES "" CACHE STRING "A semicolon
separated list of ABI macros
set(LIBCXX_EXTRA_SITE_DEFINES "" CACHE STRING "Extra defines to add into
__config_site")
option(LIBCXX_USE_COMPILER_RT "Use compiler-rt instead of libgcc" OFF)
+# C Library
@@ -27,6 +27,9 @@ if (NOT LIBCXX_USE_COMPILER_RT)
endif()
endif()
+check_cxx_compiler_flag(-nostdlibinc CXX_SUPPORTS_NOSTDLIBINC_FLAG)
+check_cxx_compiler_flag(-nolibc CXX_SUPPORTS_NOLIBC_FLAG)
ldionne wrote:
Those don't seem needed here, at least not in th
@@ -0,0 +1,34 @@
+#===
+# Define targets for linking against the selected C library
+#
+# After including this file, the following targets are defined:
+# - libcxx-libc-headers: An interface target that al
@@ -784,6 +794,10 @@ config_define_if_not(LIBCXX_ENABLE_WIDE_CHARACTERS
_LIBCPP_HAS_NO_WIDE_CHARACTER
config_define_if_not(LIBCXX_ENABLE_TIME_ZONE_DATABASE
_LIBCPP_HAS_NO_TIME_ZONE_DATABASE)
config_define_if_not(LIBCXX_ENABLE_VENDOR_AVAILABILITY_ANNOTATIONS
_LIBCPP_HAS_NO_VEN
https://github.com/ldionne approved this pull request.
I really like this patch. It introduces the hook we need to clean up a lot of
stuff in our CMake and it also adds the flexibility you need to unblock LLVM
libc work. I think we ended up in a good place.
https://github.com/llvm/llvm-project
@@ -3058,6 +3058,141 @@ void Sema::NoteAllFoundTemplates(TemplateName Name) {
}
}
+static std::optional commonTypeImpl(Sema &S,
+ TemplateName BaseTemplate,
+ SourceLocation TemplateLoc
@@ -3058,6 +3058,141 @@ void Sema::NoteAllFoundTemplates(TemplateName Name) {
}
}
+static std::optional commonTypeImpl(Sema &S,
+ TemplateName BaseTemplate,
+ SourceLocation TemplateLoc
https://github.com/ldionne approved this pull request.
I'd rather keep the libc++ tests green while landing this PR. I tried something
out, let's see if that works.
Otherwise LGTM, thanks for tackling this long-standing item on our TODO list :-)
https://github.com/llvm/llvm-project/pull/89446
ldionne wrote:
> > I'd rather keep the libc++ tests green while landing this PR. I tried
> > something out, let's see if that works.
>
> It looks like some further adjustments may be needed as some stage1 builders
> are failing:
>
> ```
> [...]
> ```
Ah, yes, we're using the nightly clang wh
https://github.com/ldionne approved this pull request.
The libc++abi changes look fine to me.
https://github.com/llvm/llvm-project/pull/90391
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
@@ -284,7 +284,7 @@ def sync_csv(rows: List[Tuple], from_github:
List[PaperInfo]) -> List[Tuple]:
results.append(gh.for_printing())
continue
elif paper.status != gh.status:
-print(f"We found a CSV row and a Github issue with differen
https://github.com/ldionne edited
https://github.com/llvm/llvm-project/pull/105990
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -257,7 +257,7 @@ General purpose options
A semicolon list of arguments to pass when running the libc++ benchmarks
using the
``check-cxx-benchmarks`` rule. By default we run the benchmarks for a very
short amount of time,
- since the primary use of ``check-cxx-benchma
ldionne wrote:
> > Gentle ping @petrhosek
>
> I'd like to go ahead and merge this PR but I still need someone to approve
> this change.
Sorry, somehow I thought this was waiting on a reply from you.
https://github.com/llvm/llvm-project/pull/101259
_
https://github.com/ldionne approved this pull request.
LGTM. I don't own the driver, but this is how we want libc++ to be used (as
generically as possible).
https://github.com/llvm/llvm-project/pull/101259
___
cfe-commits mailing list
cfe-commits@list
@@ -0,0 +1,55 @@
+// Test the output of -print-libgcc-file-name on Darwin.
+
+//
+// All platforms
+//
+
+// RUN: %clang -rtlib=compiler-rt -print-libgcc-file-name \
+// RUN: --target=x86_64-apple-macos \
+// RUN: -resource-dir=%S/Inputs/resource_dir 2>&1 \
+// RUN: | Fi
@@ -2271,6 +2271,12 @@ bool Driver::HandleImmediateArgs(const Compilation &C) {
if (C.getArgs().hasArg(options::OPT_print_libgcc_file_name)) {
ToolChain::RuntimeLibType RLT = TC.GetRuntimeLibType(C.getArgs());
const llvm::Triple Triple(TC.ComputeEffectiveClangTriple(C
@@ -0,0 +1,55 @@
+// Test the output of -print-libgcc-file-name on Darwin.
+
+//
+// All platforms
+//
+
+// RUN: %clang -rtlib=compiler-rt -print-libgcc-file-name \
+// RUN: --target=x86_64-apple-macos \
+// RUN: -resource-dir=%S/Inputs/resource_dir 2>&1 \
+// RUN: | Fi
@@ -0,0 +1,55 @@
+// Test the output of -print-libgcc-file-name on Darwin.
+
+//
+// All platforms
+//
+
+// RUN: %clang -rtlib=compiler-rt -print-libgcc-file-name \
+// RUN: --target=x86_64-apple-macos \
+// RUN: -resource-dir=%S/Inputs/resource_dir 2>&1 \
+// RUN: | Fi
@@ -223,6 +223,11 @@ class LLVM_LIBRARY_VISIBILITY MachO : public ToolChain {
// There aren't any profiling libs for embedded targets currently.
}
+ // Return the full path of the compiler-rt library on a Darwin MachO system.
+ // Those are under /lib/darwin/<...>(.dyl
@@ -0,0 +1,55 @@
+// Test the output of -print-libgcc-file-name on Darwin.
+
+//
+// All platforms
+//
+
+// RUN: %clang -rtlib=compiler-rt -print-libgcc-file-name \
+// RUN: --target=x86_64-apple-macos \
+// RUN: -resource-dir=%S/Inputs/resource_dir 2>&1 \
+// RUN: | Fi
https://github.com/ldionne edited
https://github.com/llvm/llvm-project/pull/98325
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ldionne edited
https://github.com/llvm/llvm-project/pull/98325
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ldionne ready_for_review
https://github.com/llvm/llvm-project/pull/98325
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ldionne requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/98325
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,97 @@
+// Test the output of -print-libgcc-file-name on Darwin.
+
+//
+// All platforms
+//
+
+// RUN: %clang -rtlib=compiler-rt -print-libgcc-file-name \
+// RUN: --target=x86_64-apple-macos \
+// RUN: -resource-dir=%S/Inputs/resource_dir 2>&1 \
+// RUN: | Fi
@@ -2230,6 +2239,7 @@ bool Driver::HandleImmediateArgs(const Compilation &C) {
}
if (C.getArgs().hasArg(options::OPT_print_runtime_dir)) {
+initDarwinTarget();
ldionne wrote:
We should also add tests for this behavior. We were not printing the right
@@ -0,0 +1,97 @@
+// Test the output of -print-libgcc-file-name on Darwin.
+
+//
+// All platforms
+//
+
+// RUN: %clang -rtlib=compiler-rt -print-libgcc-file-name \
+// RUN: --target=x86_64-apple-macos \
+// RUN: -resource-dir=%S/Inputs/resource_dir 2>&1 \
+// RUN: | Fi
@@ -0,0 +1,97 @@
+// Test the output of -print-libgcc-file-name on Darwin.
ldionne wrote:
It looks like the embedded targets are already tested to some extent inside
`clang/test/Driver/darwin-embedded.c`. I would add a new test file
`clang/test/Driver/darwin-em
@@ -1303,18 +1288,55 @@ void MachO::AddLinkRuntimeLib(const ArgList &Args,
ArgStringList &CmdArgs,
// rpaths. This is currently true from this place, but we need to be
// careful if this function is ever called before user's rpaths are emitted.
if (Opts & RLO_AddRPath) {
@@ -223,6 +223,13 @@ class LLVM_LIBRARY_VISIBILITY MachO : public ToolChain {
// There aren't any profiling libs for embedded targets currently.
}
+ // Return the full path of the compiler-rt library on a non-Darwin MachO
+ // system. Those are under
+ // /lib/darwin/
@@ -223,6 +223,11 @@ class LLVM_LIBRARY_VISIBILITY MachO : public ToolChain {
// There aren't any profiling libs for embedded targets currently.
}
+ // Return the full path of the compiler-rt library on a Darwin MachO system.
+ // Those are under /lib/darwin/<...>(.dyl
@@ -356,6 +363,12 @@ class LLVM_LIBRARY_VISIBILITY Darwin : public MachO {
void addProfileRTLibs(const llvm::opt::ArgList &Args,
llvm::opt::ArgStringList &CmdArgs) const override;
+ // Return the full path of the compiler-rt library on a Darwin MachO
https://github.com/ldionne edited
https://github.com/llvm/llvm-project/pull/98325
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ldionne edited
https://github.com/llvm/llvm-project/pull/98325
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,97 @@
+// Test the output of -print-libgcc-file-name on Darwin.
ldionne wrote:
Ack. I think it's reasonable not to try to fix everything in one go since it
seems really involved. However, my thinking is more that the Darwin driver is
the odd one out
ldionne wrote:
The patch LGTM, but I'd like actual Clang folks to stamp this.
https://github.com/llvm/llvm-project/pull/98325
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ldionne approved this pull request.
https://github.com/llvm/llvm-project/pull/98325
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ldionne wrote:
I just ran the bootstrapping build with this patch applied and ran
`check-runtimes`, and nothing failed. This might not be sufficient (perhaps I
missed something important), but at first glance it doesn't seem to break
anything on our side.
https://github.com/llvm/llvm-project/
https://github.com/ldionne edited
https://github.com/llvm/llvm-project/pull/98712
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ldionne requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/98712
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,25 @@
+
+set(CMAKE_EXE_LINKER_FLAGS "-lclang_rt.builtins-hexagon -nostdlib" CACHE
STRING "")
+set(CMAKE_SHARED_LINKER_FLAGS "-lclang_rt.builtins-hexagon -nostdlib" CACHE
STRING "")
+set(CMAKE_CXX_COMPILER_TARGET hexagon-unknown-linux-musl CACHE STRING "")
+
+set(LLVM_
@@ -0,0 +1,25 @@
+
ldionne wrote:
Meta comment: As part of our support policy, we would like to have a CI job
that builds and tests libc++ for Hexagon. I'm not very familiar with that
target, but do you think you could set that up?
https://github.com/llvm/llvm
601 - 700 of 962 matches
Mail list logo
