Author: ldionne
Date: Mon Aug 6 07:29:47 2018
New Revision: 339016
URL: http://llvm.org/viewvc/llvm-project?rev=339016&view=rev
Log:
[clang] Fix broken include_next in float.h
Summary:
The code defines __FLOAT_H and then includes the next , which is
guarded on __FLOAT_H so it gets skipped entire
Author: ldionne
Date: Fri Aug 10 06:24:56 2018
New Revision: 339431
URL: http://llvm.org/viewvc/llvm-project?rev=339431&view=rev
Log:
[libc++] Enable aligned allocation based on feature test macro, irrespective of
standard
Summary:
The current code enables aligned allocation functions when compi
Author: ldionne
Date: Tue Aug 14 06:29:17 2018
New Revision: 339675
URL: http://llvm.org/viewvc/llvm-project?rev=339675&view=rev
Log:
[libc++] Add missing #include in C11 features tests
Summary:
These #includes are quite important, since otherwise any
#if TEST_STD_VER > 14 && defined(TEST_HA
Author: ldionne
Date: Tue Aug 14 11:16:56 2018
New Revision: 339702
URL: http://llvm.org/viewvc/llvm-project?rev=339702&view=rev
Log:
[libc++] Fix incorrect definition of TEST_HAS_C11_FEATURES
Summary:
The macro was not defined in C++11 mode when it should have been, at least
according to how _LI
Author: ldionne
Date: Tue Aug 14 17:16:41 2018
New Revision: 339741
URL: http://llvm.org/viewvc/llvm-project?rev=339741&view=rev
Log:
[libc++] Detect C11 features on non-Clang compilers
Summary:
The macros were inside `#if defined(_LIBCPP_COMPILER_CLANG)`, which means
we would never detect C11 fe
Author: ldionne
Date: Tue Aug 14 17:18:01 2018
New Revision: 339742
URL: http://llvm.org/viewvc/llvm-project?rev=339742&view=rev
Log:
[libc++] Disable failing C11 feature tests for and
Summary:
Those tests are breaking the test bots. A Bugzilla has been filed to
make sure those tests are re-ena
Author: ldionne
Date: Tue Aug 14 17:30:03 2018
New Revision: 339743
URL: http://llvm.org/viewvc/llvm-project?rev=339743&view=rev
Log:
[libcxx] Fix XFAILs for aligned allocation tests on older OSX versions
Summary:
Since r338934, Clang emits an error when aligned allocation functions are
used in c
Author: ldionne
Date: Thu Aug 16 05:44:28 2018
New Revision: 339874
URL: http://llvm.org/viewvc/llvm-project?rev=339874&view=rev
Log:
[libcxx] By default, do not use internal_linkage to hide symbols from the ABI
Summary:
https://reviews.llvm.org/D49240 led to symbol size problems in Chromium, and
Author: ldionne
Date: Tue Aug 21 08:54:24 2018
New Revision: 340288
URL: http://llvm.org/viewvc/llvm-project?rev=340288&view=rev
Log:
[clang][NFC] Fix typo in the name of a note
Summary:
r306722 introduced a new note called
note_silence_unligned_allocation_unavailable
where I believe what was me
Author: ldionne
Date: Fri Aug 24 07:00:59 2018
New Revision: 340608
URL: http://llvm.org/viewvc/llvm-project?rev=340608&view=rev
Log:
[libc++] Remove race condition in std::async
Summary:
The state associated to the future was set in one thread (with synchronization)
but read in another thread wi
Author: ldionne
Date: Fri Aug 24 07:10:28 2018
New Revision: 340609
URL: http://llvm.org/viewvc/llvm-project?rev=340609&view=rev
Log:
[libc++] Fix handling of negated character classes in regex
Summary:
This commit fixes a regression introduced in r316095, where we don't match
inverted character
Author: ldionne
Date: Thu Sep 6 07:46:22 2018
New Revision: 341550
URL: http://llvm.org/viewvc/llvm-project?rev=341550&view=rev
Log:
[libcxx] Add ReleaseNotes.rst file for release notes
Added:
libcxx/trunk/docs/ReleaseNotes.rst
Added: libcxx/trunk/docs/ReleaseNotes.rst
URL:
http://llvm.org
Author: ldionne
Date: Thu Sep 6 08:05:43 2018
New Revision: 341551
URL: http://llvm.org/viewvc/llvm-project?rev=341551&view=rev
Log:
[libc++] Add a link to the Release notes from the main libc++ documentation
Modified:
libcxx/trunk/docs/index.rst
Modified: libcxx/trunk/docs/index.rst
URL:
Author: ldionne
Date: Fri Sep 14 07:07:16 2018
New Revision: 342238
URL: http://llvm.org/viewvc/llvm-project?rev=342238&view=rev
Log:
[clang] Make sure attributes on member classes are applied properly
Summary:
Attributes on member classes of class templates and member class templates
of class te
Author: ldionne
Date: Wed Jul 25 06:40:49 2018
New Revision: 337925
URL: http://llvm.org/viewvc/llvm-project?rev=337925&view=rev
Log:
[NFC] Fix grammatical mistakes in libc++ FileTimeType design docs
Modified:
libcxx/trunk/docs/DesignDocs/FileTimeType.rst
Modified: libcxx/trunk/docs/DesignDo
Author: ldionne
Date: Wed Jul 25 12:40:01 2018
New Revision: 337955
URL: http://llvm.org/viewvc/llvm-project?rev=337955&view=rev
Log:
[libc++] Factor duplicate code into function templates
Summary:
The exact same code was replicated 11 times for implementing the basic_istream
input operators (tho
Author: ldionne
Date: Fri Jul 27 05:46:03 2018
New Revision: 338122
URL: http://llvm.org/viewvc/llvm-project?rev=338122&view=rev
Log:
[libc++] Introduce _LIBCPP_HIDE_FROM_ABI to replace _LIBCPP_INLINE_VISIBILITY
Summary:
This commit introduces a new macro, _LIBCPP_HIDE_FROM_ABI, whose goal is to
Author: ldionne
Date: Tue Jul 31 19:08:59 2018
New Revision: 338475
URL: http://llvm.org/viewvc/llvm-project?rev=338475&view=rev
Log:
[libc++] Remove _LIBCPP_BUILDING_XXX macros, which are redundant since
_LIBCPP_BUILDING_LIBRARY
Summary: As suggested by Marshall in https://reviews.llvm.org/D499
Author: ldionne
Date: Tue Jul 31 19:08:59 2018
New Revision: 338475
URL: http://llvm.org/viewvc/llvm-project?rev=338475&view=rev
Log:
[libc++] Remove _LIBCPP_BUILDING_XXX macros, which are redundant since
_LIBCPP_BUILDING_LIBRARY
Summary: As suggested by Marshall in https://reviews.llvm.org/D499
Author: ldionne
Date: Wed Aug 1 06:13:14 2018
New Revision: 338531
URL: http://llvm.org/viewvc/llvm-project?rev=338531&view=rev
Log:
[libc++] Fix GCC 7.2.0 macro redefinition warning
The warning happens when LIBCXX_ENABLE_EXCEPTIONS cmake option is not set,
and it fires every time __config is in
Author: ldionne
Date: Fri Aug 3 15:36:53 2018
New Revision: 338933
URL: http://llvm.org/viewvc/llvm-project?rev=338933&view=rev
Log:
[NFC][libc++] Consistently use spaces to indent
rdar://problem/19988944
Modified:
libcxx/trunk/include/__tree
libcxx/trunk/include/any
libcxx/trunk/in
Author: ldionne
Date: Mon Aug 6 07:11:50 2018
New Revision: 339012
URL: http://llvm.org/viewvc/llvm-project?rev=339012&view=rev
Log:
[libc++] Add the _LIBCPP_HIDE_FROM_ABI_AFTER_V1 macro
Summary:
This macro allows hiding symbols from the ABI when the library is built
with an ABI version after AB
Author: ldionne
Date: Wed Oct 10 08:32:29 2018
New Revision: 344146
URL: http://llvm.org/viewvc/llvm-project?rev=344146&view=rev
Log:
[clang] Properly apply attributes on explicit instantiations of static data
members
Summary: https://llvm.org/PR39118
Reviewers: aaron.ballman, rnk
Subscribers:
Author: ldionne
Date: Wed Oct 10 10:37:37 2018
New Revision: 344159
URL: http://llvm.org/viewvc/llvm-project?rev=344159&view=rev
Log:
[clang] Fix failing attribute test on Windows
The test added in r344146 was failing because the ABI on Windows is
different, and that test includes ABI-specific de
Author: ldionne
Date: Tue Mar 12 08:32:00 2019
New Revision: 355927
URL: http://llvm.org/viewvc/llvm-project?rev=355927&view=rev
Log:
[CMake] Tell libc++ that we're using compiler-rt on Apple platforms
Reviewers: beanz, arphaman, EricWF
Subscribers: dberris, mgorny, jkorous, dexonsmith, jdoerfer
Author: ldionne
Date: Thu Apr 11 09:37:07 2019
New Revision: 358191
URL: http://llvm.org/viewvc/llvm-project?rev=358191&view=rev
Log:
[NFC] Correct outdated links to the Itanium C++ ABI documentation
Those are now hosted on GitHub.
rdar://problem/36557462
Modified:
libunwind/trunk/include/u
Author: ldionne
Date: Mon Apr 15 07:14:45 2019
New Revision: 358409
URL: http://llvm.org/viewvc/llvm-project?rev=358409&view=rev
Log:
[clang] Aligned allocation is actually supported in macosx 10.13
Summary:
In r350649, I changed aligned allocation from being available starting
in macosx10.13 to
Author: ldionne
Date: Mon Apr 15 12:08:52 2019
New Revision: 358437
URL: http://llvm.org/viewvc/llvm-project?rev=358437&view=rev
Log:
Revert "[clang] Aligned allocation is actually supported in macosx 10.13"
This reverts r358409, which I think broke the bots in compiler-rt.
Since I'm having troub
Author: ldionne
Date: Wed Apr 17 07:58:59 2019
New Revision: 358582
URL: http://llvm.org/viewvc/llvm-project?rev=358582&view=rev
Log:
Explicitly say we don't define new/delete in libc++ during Apple stage1
bootstrap
This is not necessary in stage2 because we don't even build libc++.dylib
there.
Author: ldionne
Date: Mon Apr 22 08:40:50 2019
New Revision: 358896
URL: http://llvm.org/viewvc/llvm-project?rev=358896&view=rev
Log:
[NFC] Fix typo in debug log
Modified:
libunwind/trunk/src/UnwindCursor.hpp
Modified: libunwind/trunk/src/UnwindCursor.hpp
URL:
http://llvm.org/viewvc/llvm-pr
Author: ldionne
Date: Sat Sep 22 11:18:34 2018
New Revision: 342811
URL: http://llvm.org/viewvc/llvm-project?rev=342811&view=rev
Log:
[libunwind][NFC] Suppress unused parameter warnings
Reviewers: EricWF
Subscribers: christof, chrib, dexonsmith, cfe-commits
Differential Revision: https://review
Author: ldionne
Date: Thu Oct 4 08:49:42 2018
New Revision: 343790
URL: http://llvm.org/viewvc/llvm-project?rev=343790&view=rev
Log:
[clang] Add the exclude_from_explicit_instantiation attribute
Summary:
This attribute allows excluding a member of a class template from being part
of an explicit
cks-win\llvm\tools\clang\lib\Sema\SemaExprCXX.cpp
> : fatal error C1128: number of sections exceeded object file format limit:
> compile with /bigobj
>
>
> Please have a look?
> The builder was already red and did not send notifications on this.
>
> Thanks
>
> Gali
Author: ldionne
Date: Wed Feb 13 11:08:01 2019
New Revision: 353970
URL: http://llvm.org/viewvc/llvm-project?rev=353970&view=rev
Log:
[clang] Make sure C99/C11 features in are provided in C++11
Summary:
Previously, those #defines were only provided in C or when GNU extensions were
enabled. We ne
Author: ldionne
Date: Fri Feb 22 12:48:54 2019
New Revision: 354691
URL: http://llvm.org/viewvc/llvm-project?rev=354691&view=rev
Log:
[clang] Only provide C11 features in starting with C++17
Summary:
In r353970, I enabled those features in C++11 and above. To be strictly
conforming, those featur
Author: ldionne
Date: Tue May 21 10:48:04 2019
New Revision: 361278
URL: http://llvm.org/viewvc/llvm-project?rev=361278&view=rev
Log:
[clang][Darwin] Refactor header search path logic into the driver
Summary:
This commit moves the logic for determining system, resource and C++
header search paths
Author: ldionne
Date: Tue Jan 8 12:26:56 2019
New Revision: 350649
URL: http://llvm.org/viewvc/llvm-project?rev=350649&view=rev
Log:
[Sema] Teach Clang that aligned allocation is not supported with macosx10.13
Summary:
r306722 added diagnostics when aligned allocation is used with deployment
tar
Author: ldionne
Date: Thu Jul 5 09:16:03 2018
New Revision: 336368
URL: http://llvm.org/viewvc/llvm-project?rev=336368&view=rev
Log:
[NFC] Add to the synopsis of
Summary:
It is part of the synopsis in the Standard and does include it,
but it was left out of the synopsis comment.
Reviewers: E
Author: ldionne
Date: Thu Jul 5 09:49:38 2018
New Revision: 336369
URL: http://llvm.org/viewvc/llvm-project?rev=336369&view=rev
Log:
[libc++] Replace uses of _LIBCPP_ALWAYS_INLINE by _LIBCPP_INLINE_VISIBILITY
Summary:
We never actually mean to always inline a function -- all the uses of
the macr
Author: ldionne
Date: Thu Jul 5 11:41:50 2018
New Revision: 336382
URL: http://llvm.org/viewvc/llvm-project?rev=336382&view=rev
Log:
Revert "[libc++] Replace uses of _LIBCPP_ALWAYS_INLINE by
_LIBCPP_INLINE_VISIBILITY"
This reverts commit r336369. The commit had two problems:
1. __pbump was mark
Author: ldionne
Date: Tue Jul 10 06:21:03 2018
New Revision: 336665
URL: http://llvm.org/viewvc/llvm-project?rev=336665&view=rev
Log:
[libc++] Declare operators with the proper visibility attribute
Summary:
Many operators in were _defined_ with the proper visibility attribute,
but they were _de
Author: ldionne
Date: Tue Jul 10 10:38:30 2018
New Revision: 336709
URL: http://llvm.org/viewvc/llvm-project?rev=336709&view=rev
Log:
[libc++] Declare noop_coroutine() with _LIBCPP_INLINE_VISIBILITY
Summary:
It was defined with the right visibility, but declared without any visibility.
This funct
Author: ldionne
Date: Wed Jul 11 16:14:33 2018
New Revision: 336866
URL: http://llvm.org/viewvc/llvm-project?rev=336866&view=rev
Log:
[libc++] Take 2: Replace uses of _LIBCPP_ALWAYS_INLINE by
_LIBCPP_INLINE_VISIBILITY
Summary:
We never actually mean to always inline a function -- all the uses of
Author: Louis Dionne
Date: 2020-07-16T10:47:08-04:00
New Revision: 0f03626fbf40ba1a74badf2d1476a550535c184f
URL:
https://github.com/llvm/llvm-project/commit/0f03626fbf40ba1a74badf2d1476a550535c184f
DIFF:
https://github.com/llvm/llvm-project/commit/0f03626fbf40ba1a74badf2d1476a550535c184f.diff
Author: Louis Dionne
Date: 2020-07-27T16:12:59-04:00
New Revision: 145acacaea1d7fb4ffc055a3e92ee8fee7c58634
URL:
https://github.com/llvm/llvm-project/commit/145acacaea1d7fb4ffc055a3e92ee8fee7c58634
DIFF:
https://github.com/llvm/llvm-project/commit/145acacaea1d7fb4ffc055a3e92ee8fee7c58634.diff
Author: Louis Dionne
Date: 2020-04-08T10:50:09-04:00
New Revision: 6f1d558db42cf92351c649a66c00b881eb75537c
URL:
https://github.com/llvm/llvm-project/commit/6f1d558db42cf92351c649a66c00b881eb75537c
DIFF:
https://github.com/llvm/llvm-project/commit/6f1d558db42cf92351c649a66c00b881eb75537c.diff
Author: Louis Dionne
Date: 2020-04-13T18:17:18-04:00
New Revision: 5f7a0301628671b8f4d2c1d9ea90ee723d889a56
URL:
https://github.com/llvm/llvm-project/commit/5f7a0301628671b8f4d2c1d9ea90ee723d889a56
DIFF:
https://github.com/llvm/llvm-project/commit/5f7a0301628671b8f4d2c1d9ea90ee723d889a56.diff
Author: Louis Dionne
Date: 2020-06-09T15:34:29-04:00
New Revision: 0e04342ae0399876f3488464d12f5a4da5085456
URL:
https://github.com/llvm/llvm-project/commit/0e04342ae0399876f3488464d12f5a4da5085456
DIFF:
https://github.com/llvm/llvm-project/commit/0e04342ae0399876f3488464d12f5a4da5085456.diff
Author: Louis Dionne
Date: 2020-06-09T16:03:22-04:00
New Revision: 168681abce63d9cc0cec24cfc1d0caef6fa3a25f
URL:
https://github.com/llvm/llvm-project/commit/168681abce63d9cc0cec24cfc1d0caef6fa3a25f
DIFF:
https://github.com/llvm/llvm-project/commit/168681abce63d9cc0cec24cfc1d0caef6fa3a25f.diff
Author: Louis Dionne
Date: 2020-06-11T16:24:29-04:00
New Revision: 96e6cbbf941d0f937b7e823433d4c222967a1817
URL:
https://github.com/llvm/llvm-project/commit/96e6cbbf941d0f937b7e823433d4c222967a1817
DIFF:
https://github.com/llvm/llvm-project/commit/96e6cbbf941d0f937b7e823433d4c222967a1817.diff
Author: Louis Dionne
Date: 2020-06-25T12:15:15-04:00
New Revision: c55051eea5d3cd57abfd9727f519b670517704d9
URL:
https://github.com/llvm/llvm-project/commit/c55051eea5d3cd57abfd9727f519b670517704d9
DIFF:
https://github.com/llvm/llvm-project/commit/c55051eea5d3cd57abfd9727f519b670517704d9.diff
Author: Louis Dionne
Date: 2020-06-30T10:10:30-04:00
New Revision: 70f6389257a85a8fa7f128a05a1ccbd0dbba191c
URL:
https://github.com/llvm/llvm-project/commit/70f6389257a85a8fa7f128a05a1ccbd0dbba191c
DIFF:
https://github.com/llvm/llvm-project/commit/70f6389257a85a8fa7f128a05a1ccbd0dbba191c.diff
Author: Louis Dionne
Date: 2020-08-11T15:24:52-04:00
New Revision: e8dac8b3dbe7a31af291032f1f3e95e789200590
URL:
https://github.com/llvm/llvm-project/commit/e8dac8b3dbe7a31af291032f1f3e95e789200590
DIFF:
https://github.com/llvm/llvm-project/commit/e8dac8b3dbe7a31af291032f1f3e95e789200590.diff
Author: Louis Dionne
Date: 2020-08-11T15:37:57-04:00
New Revision: 9b211a5076310f14081dd257b0cbac6857534bc3
URL:
https://github.com/llvm/llvm-project/commit/9b211a5076310f14081dd257b0cbac6857534bc3
DIFF:
https://github.com/llvm/llvm-project/commit/9b211a5076310f14081dd257b0cbac6857534bc3.diff
Author: Kamlesh Kumar
Date: 2020-05-11T10:48:35-04:00
New Revision: 9aee35bcc90faa9db3ea0111c0a80ebee7446cac
URL:
https://github.com/llvm/llvm-project/commit/9aee35bcc90faa9db3ea0111c0a80ebee7446cac
DIFF:
https://github.com/llvm/llvm-project/commit/9aee35bcc90faa9db3ea0111c0a80ebee7446cac.diff
Author: Ryan Prichard
Date: 2022-09-07T22:18:09-04:00
New Revision: 6332a00d696d37942f2743851c86f1d4493968f0
URL:
https://github.com/llvm/llvm-project/commit/6332a00d696d37942f2743851c86f1d4493968f0
DIFF:
https://github.com/llvm/llvm-project/commit/6332a00d696d37942f2743851c86f1d4493968f0.diff
https://github.com/ldionne updated
https://github.com/llvm/llvm-project/pull/69498
>From 77c0256c3ae99808a8def68bfcf5eee2fad704ca Mon Sep 17 00:00:00 2001
From: Louis Dionne
Date: Wed, 14 Jun 2023 17:49:22 -0700
Subject: [PATCH 1/8] [libc++] Fix the behavior of throwing `operator new`
under -f
https://github.com/ldionne requested changes to this pull request.
I think this is generally reasonable but I'm requesting a few changes.
https://github.com/llvm/llvm-project/pull/70817
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://li
@@ -2494,6 +2494,19 @@ void DarwinClang::AddClangCXXStdlibIncludeArgs(
<< "\"\n";
}
+// Check for the folder where the executable is located, if different.
+if (getDriver().getInstalledDir() != getDriver().Dir) {
+ InstallBin = llvm::StringR
@@ -2494,6 +2494,19 @@ void DarwinClang::AddClangCXXStdlibIncludeArgs(
<< "\"\n";
}
+// Check for the folder where the executable is located, if different.
+if (getDriver().getInstalledDir() != getDriver().Dir) {
+ InstallBin = llvm::StringR
@@ -2494,6 +2494,19 @@ void DarwinClang::AddClangCXXStdlibIncludeArgs(
<< "\"\n";
ldionne wrote:
Please update the documentation above:
```
// On Darwin, libc++ can be installed in one of the following places:
// 1. Alongside the compiler in
@@ -2494,6 +2494,19 @@ void DarwinClang::AddClangCXXStdlibIncludeArgs(
<< "\"\n";
}
+// Check for the folder where the executable is located, if different.
ldionne wrote:
```suggestion
// (2) Check for the folder where the execu
https://github.com/ldionne edited
https://github.com/llvm/llvm-project/pull/70817
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ldionne approved this pull request.
https://github.com/llvm/llvm-project/pull/71743
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -116,7 +116,7 @@ else()
set(LIBCXX_ABI_VERSION 2 CACHE STRING "")
set(LIBCXX_ENABLE_SHARED OFF CACHE BOOL "")
set(LIBCXX_ENABLE_STATIC_ABI_LIBRARY ON CACHE BOOL "")
- set(LIBCXX_HARDENING_MODE "unchecked" CACHE STRING "")
+ set(LIBCXX_HARDENING_MODE "none" CACHE STRI
https://github.com/ldionne edited
https://github.com/llvm/llvm-project/pull/71743
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2494,6 +2494,19 @@ void DarwinClang::AddClangCXXStdlibIncludeArgs(
<< "\"\n";
}
+// Check for the folder where the executable is located, if different.
+if (getDriver().getInstalledDir() != getDriver().Dir) {
+ InstallBin = llvm::StringR
https://github.com/ldionne updated
https://github.com/llvm/llvm-project/pull/69498
>From 77c0256c3ae99808a8def68bfcf5eee2fad704ca Mon Sep 17 00:00:00 2001
From: Louis Dionne
Date: Wed, 14 Jun 2023 17:49:22 -0700
Subject: [PATCH 1/9] [libc++] Fix the behavior of throwing `operator new`
under -f
https://github.com/ldionne approved this pull request.
LGTM, we can merge once CI is green. Thanks!
https://github.com/llvm/llvm-project/pull/66033
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/
https://github.com/ldionne approved this pull request.
https://github.com/llvm/llvm-project/pull/73200
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ldionne closed
https://github.com/llvm/llvm-project/pull/73200
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ldionne created
https://github.com/llvm/llvm-project/pull/75089
When we use the -nostdlib++ flag, we don't need to explicitly link against
compiler-rt, since the compiler already links against it by default. This
simplifies the flags that we need to use when building with Cl
ldionne wrote:
LGTM, the AIX failure seems unrelated.
https://github.com/llvm/llvm-project/pull/72314
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ldionne closed
https://github.com/llvm/llvm-project/pull/72314
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ldionne wrote:
Gentle ping!
https://github.com/llvm/llvm-project/pull/67860
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -172,3 +172,32 @@
// RUN: --check-prefix=CHECK-LIBCXX-STDLIB-UNSPECIFIED %s
// CHECK-LIBCXX-STDLIB-UNSPECIFIED: "-cc1"
// CHECK-LIBCXX-STDLIB-UNSPECIFIED: "-internal-isystem"
"[[SYSROOT]]/usr/include/c++/v1"
+
+// --
@@ -172,3 +172,32 @@
// RUN: --check-prefix=CHECK-LIBCXX-STDLIB-UNSPECIFIED %s
// CHECK-LIBCXX-STDLIB-UNSPECIFIED: "-cc1"
// CHECK-LIBCXX-STDLIB-UNSPECIFIED: "-internal-isystem"
"[[SYSROOT]]/usr/include/c++/v1"
+
+// --
ldionne wrote:
This seems reasonable. I read the discussion about the size of the member but I
think this is unlikely to change much -- plus I think the compiler should be
able to diagnose in case the string becomes smaller and we'd be copying from a
past-the-end location into the data structu
https://github.com/ldionne closed
https://github.com/llvm/llvm-project/pull/72043
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ldionne wrote:
This is weird, it's the first time I see this and I couldn't find any obvious
offending commit. It looks like it shouldn't be related, but at the same time
we're not seeing this issue in any of the other builds in the Clang pipeline.
You could consider updating the PR with the l
https://github.com/ldionne approved this pull request.
LGTM assuming CI passes. Thanks!
https://github.com/llvm/llvm-project/pull/70817
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ldionne updated
https://github.com/llvm/llvm-project/pull/68753
>From 9824ef111975386152173916c1fd6a85264be0a0 Mon Sep 17 00:00:00 2001
From: Louis Dionne
Date: Tue, 10 Oct 2023 16:35:11 -0700
Subject: [PATCH 1/9] [libc++] Allow running the test suite with optimizations
This
ldionne wrote:
That's a question for the Clang regulars -- I generally don't run those tests
since I primarily work on libc++, not Clang.
https://github.com/llvm/llvm-project/pull/70817
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://l
https://github.com/ldionne approved this pull request.
LGTM. @petrhosek might want to take a quick look at the compiler-rt part though.
https://github.com/llvm/llvm-project/pull/72538
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://list
@@ -381,24 +381,22 @@ typename A::pint_t
DwarfInstructions::evaluateExpression(pint_t expression, A &addressSpace,
const R ®isters,
pint_t initialStackValue) {
- const bool log = false;
https://github.com/ldionne approved this pull request.
This looks like an improvement to me. I have a comment/question about the
`stdio.h` include which is now dangling, but apart from that I'm happy with the
patch.
https://github.com/llvm/llvm-project/pull/72040
__
ldionne wrote:
Gentle ping. There's outstanding feedback to address on this review.
@ZijunZhaoCCK if you don't think you'll have time to pursue this PR anymore,
it's all good but please let us know so we can assign it to someone else!
https://github.com/llvm/llvm-project/pull/66963
___
@@ -381,24 +381,22 @@ typename A::pint_t
DwarfInstructions::evaluateExpression(pint_t expression, A &addressSpace,
const R ®isters,
pint_t initialStackValue) {
- const bool log = false;
https://github.com/ldionne approved this pull request.
Thanks a bunch for the cleanup! We often forget these but it always feels great
to find one and clean it up!
https://github.com/llvm/llvm-project/pull/72595
___
cfe-commits mailing list
cfe-commit
https://github.com/ldionne closed
https://github.com/llvm/llvm-project/pull/72595
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -381,24 +381,22 @@ typename A::pint_t
DwarfInstructions::evaluateExpression(pint_t expression, A &addressSpace,
const R ®isters,
pint_t initialStackValue) {
- const bool log = false;
https://github.com/ldionne updated
https://github.com/llvm/llvm-project/pull/68753
>From 2a5035e7b1db4b77ec30426c988478a35b077b7b Mon Sep 17 00:00:00 2001
From: Louis Dionne
Date: Tue, 10 Oct 2023 16:35:11 -0700
Subject: [PATCH] [libc++] Allow running the test suite with optimizations
This pat
https://github.com/ldionne closed
https://github.com/llvm/llvm-project/pull/72538
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ldionne updated
https://github.com/llvm/llvm-project/pull/68753
>From 2a5035e7b1db4b77ec30426c988478a35b077b7b Mon Sep 17 00:00:00 2001
From: Louis Dionne
Date: Tue, 10 Oct 2023 16:35:11 -0700
Subject: [PATCH 1/2] [libc++] Allow running the test suite with optimizations
This
Author: Louis Dionne
Date: 2023-11-17T16:50:49-05:00
New Revision: 0133e25d99df9468ec3d9b523f14733a4b5e7180
URL:
https://github.com/llvm/llvm-project/commit/0133e25d99df9468ec3d9b523f14733a4b5e7180
DIFF:
https://github.com/llvm/llvm-project/commit/0133e25d99df9468ec3d9b523f14733a4b5e7180.diff
https://github.com/ldionne closed
https://github.com/llvm/llvm-project/pull/70817
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ldionne updated
https://github.com/llvm/llvm-project/pull/68753
>From 2a5035e7b1db4b77ec30426c988478a35b077b7b Mon Sep 17 00:00:00 2001
From: Louis Dionne
Date: Tue, 10 Oct 2023 16:35:11 -0700
Subject: [PATCH 1/3] [libc++] Allow running the test suite with optimizations
This
@@ -0,0 +1,28 @@
+// -*- C++ -*-
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-
ldionne wrote:
The CI issues are flakes (we just made major changes to our infrastructure and
we're still adjusting). I think this is good to go.
https://github.com/llvm/llvm-project/pull/72040
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
h
@@ -18,8 +18,11 @@
_LIBCPP_BEGIN_NAMESPACE_STD
-template
-struct __is_trivial_plus_operation : false_type {};
+template
ldionne wrote:
I think what we want is something like this:
```
struct __equal_tag {};
struct __plus_tag {};
// etc...
template
struc
1 - 100 of 932 matches
Mail list logo
