RE: r256854 - [OpenMP] Allow file ID to be signed in the offloading metadata.

2016-01-05 Thread Liao, Michael via cfe-commits
Hi Samual The change in CL#256842 has undefined behavior according to C++. Attached patch will avoid side-effect code during argument evaluation of a function call. That solves the problem for me on Linux with GCC 4.9. Thanks - Michael From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.o

RE: r256854 - [OpenMP] Allow file ID to be signed in the offloading metadata.

2016-01-05 Thread Liao, Michael via cfe-commits
Hi Samuel The issue is not related to capture feature but the order of evaluation which is not specified for arguments in a function call in C/C++. With the side effect in each argument evaluation, it causes the trouble. Thanks - Michael From: Samuel F Antao [mailto:sfan...@us.ibm.com] Sent: T