[PATCH] D21510: [libc++] Check hash before calling __hash_table key_eq function

2016-06-19 Thread Kwasi Mensah via cfe-commits
kmensah created this revision. kmensah added a subscriber: cfe-commits. kmensah set the repository for this revision to rL LLVM. The current implementations of __hash_table::find used by std::unordered_set/unordered_map call key_eq on each key that lands in the same bucket as the key you're look

Re: [PATCH] D21510: [libc++] Check hash before calling __hash_table key_eq function

2016-06-19 Thread Kwasi Mensah via cfe-commits
kmensah added a comment. I've run make make check-libcxx and this seems to pass fine. Repository: rL LLVM http://reviews.llvm.org/D21510 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

Re: [PATCH] D21510: [libc++] Check hash before calling __hash_table key_eq function

2016-06-22 Thread Kwasi Mensah via cfe-commits
kmensah added a subscriber: kmensah. kmensah added a comment. Friendly Ping about this Repository: rL LLVM http://reviews.llvm.org/D21510 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

Re: [PATCH] D21510: [libc++] Check hash before calling __hash_table key_eq function

2016-06-29 Thread Kwasi Mensah via cfe-commits
kmensah added a comment. Another friendly Ping Repository: rL LLVM http://reviews.llvm.org/D21510 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21510: [libc++] Check hash before calling __hash_table key_eq function

2016-07-01 Thread Kwasi Mensah via cfe-commits
Thanks. For future reference, do these benchmarking tests live some place where I can run them myself in the future? On Thu, Jun 30, 2016 at 2:15 AM, Eric Fiselier wrote: > EricWF accepted this revision. > EricWF added a comment. > This revision is now accepted and ready to land. > > LGTM. I ben

Re: [PATCH] D21510: [libc++] Check hash before calling __hash_table key_eq function

2016-07-01 Thread Kwasi Mensah via cfe-commits
kmensah added a comment. Thanks. For future reference, do these benchmarking tests live some place where I can run them myself in the future? Repository: rL LLVM http://reviews.llvm.org/D21510 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[libcxx] r274857 - [libc++] Check hash before calling __hash_table key_eq function

2016-07-08 Thread Kwasi Mensah via cfe-commits
Author: kmensah Date: Fri Jul 8 10:34:28 2016 New Revision: 274857 URL: http://llvm.org/viewvc/llvm-project?rev=274857&view=rev Log: [libc++] Check hash before calling __hash_table key_eq function Summary: The current implementations of __hash_table::find used by std::unordered_set/unordered_ma

[PATCH] D16363: Add option to specify clang-format binary for clang-format-diff

2016-01-20 Thread Kwasi Mensah via cfe-commits
kmensah created this revision. kmensah added a reviewer: djasper. kmensah added a subscriber: cfe-commits. kmensah set the repository for this revision to rL LLVM. A command line option that lets users of the script specify which clang-format binary to use. Useful if clang-format is not on PATH o