[clang] [clang][OpenMP] Make `getOpenMPCaptureRegionForClause` more generic (PR #98180)

2024-07-09 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz closed https://github.com/llvm/llvm-project/pull/98180 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Assume (PR #97535)

2024-07-10 Thread Krzysztof Parzyszek via cfe-commits
@@ -760,6 +760,9 @@ void clang::getOpenMPCaptureRegions( case OMPD_parallel: CaptureRegions.push_back(OMPD_parallel); break; +case OMPD_assume: + CaptureRegions.push_back(OMPD_unknown); + break; kparzysz wrote: Please don't push O

[clang] [llvm] Assume (PR #97535)

2024-07-10 Thread Krzysztof Parzyszek via cfe-commits
@@ -760,6 +760,9 @@ void clang::getOpenMPCaptureRegions( case OMPD_parallel: CaptureRegions.push_back(OMPD_parallel); break; +case OMPD_assume: + CaptureRegions.push_back(OMPD_unknown); + break; kparzysz wrote: Also, please add OM

[clang] [llvm] Assume (PR #97535)

2024-07-10 Thread Krzysztof Parzyszek via cfe-commits
@@ -760,6 +760,9 @@ void clang::getOpenMPCaptureRegions( case OMPD_parallel: CaptureRegions.push_back(OMPD_parallel); break; +case OMPD_assume: + CaptureRegions.push_back(OMPD_unknown); + break; kparzysz wrote: This is what happen

[clang] [llvm] Assume (PR #97535)

2024-07-10 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz edited https://github.com/llvm/llvm-project/pull/97535 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Assume (PR #97535)

2024-07-10 Thread Krzysztof Parzyszek via cfe-commits
@@ -760,6 +760,9 @@ void clang::getOpenMPCaptureRegions( case OMPD_parallel: CaptureRegions.push_back(OMPD_parallel); break; +case OMPD_assume: + CaptureRegions.push_back(OMPD_unknown); + break; kparzysz wrote: The final output fr

[clang] [clang][OpenMP] Fix region nesting check for `scan` directive (PR #98386)

2024-07-10 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz created https://github.com/llvm/llvm-project/pull/98386 The previous check was inconsistent. For example, it would allow ``` #pragma omp target #pragma omp parallel for for (...) { #pragma omp scan } ``` but not ``` #pragma omp target parallel for for (...) { #p

[clang] [clang][OpenMP] Fix region nesting check for `scan` directive (PR #98386)

2024-07-11 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz closed https://github.com/llvm/llvm-project/pull/98386 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][OpenMP] Remove compound directives from `checkNestingOfRegions` (PR #98387)

2024-07-11 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz edited https://github.com/llvm/llvm-project/pull/98387 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][OpenMP] Remove compound directives from `checkNestingOfRegions` (PR #98387)

2024-07-11 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz updated https://github.com/llvm/llvm-project/pull/98387 >From bc7e6962de9e1e44773eee89d0f552342b40 Mon Sep 17 00:00:00 2001 From: Krzysztof Parzyszek Date: Wed, 10 Jul 2024 14:38:57 -0500 Subject: [PATCH 1/3] [clang][OpenMP] Fix region nesting check for `scan` d

[clang] ba29e3a - [clang][OpenMP] Add early exit to/unindent `ActOnOpenMPLoopInitialization`

2024-07-12 Thread Krzysztof Parzyszek via cfe-commits
Author: Krzysztof Parzyszek Date: 2024-07-12T08:18:28-05:00 New Revision: ba29e3a58dcdf0012df9fdaa3e7ed10cee56d5c5 URL: https://github.com/llvm/llvm-project/commit/ba29e3a58dcdf0012df9fdaa3e7ed10cee56d5c5 DIFF: https://github.com/llvm/llvm-project/commit/ba29e3a58dcdf0012df9fdaa3e7ed10cee56d5c5

[clang] [clang][OpenMP] Remove compound directives from `checkNestingOfRegions` (PR #98387)

2024-07-12 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz updated https://github.com/llvm/llvm-project/pull/98387 >From bc7e6962de9e1e44773eee89d0f552342b40 Mon Sep 17 00:00:00 2001 From: Krzysztof Parzyszek Date: Wed, 10 Jul 2024 14:38:57 -0500 Subject: [PATCH 1/3] [clang][OpenMP] Fix region nesting check for `scan` d

[clang] [clang][OpenMP] Remove compound directives from `checkNestingOfRegions` (PR #98387)

2024-07-15 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz closed https://github.com/llvm/llvm-project/pull/98387 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][OpenMP] Update validity check for reduction with `inscan` (PR #98500)

2024-07-15 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz edited https://github.com/llvm/llvm-project/pull/98500 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][OpenMP] Update validity check for reduction with `inscan` (PR #98500)

2024-07-15 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz updated https://github.com/llvm/llvm-project/pull/98500 >From bc7e6962de9e1e44773eee89d0f552342b40 Mon Sep 17 00:00:00 2001 From: Krzysztof Parzyszek Date: Wed, 10 Jul 2024 14:38:57 -0500 Subject: [PATCH 1/4] [clang][OpenMP] Fix region nesting check for `scan` d

[clang] [clang][OpenMP] Simplify check for taskloop in `ActOnOpenMPLoopInitia… (PR #98633)

2024-07-15 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz edited https://github.com/llvm/llvm-project/pull/98633 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][OpenMP] Simplify check for taskloop in `ActOnOpenMPLoopInitia… (PR #98633)

2024-07-15 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz closed https://github.com/llvm/llvm-project/pull/98633 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 97ebc97 - [clang[OpenMP] Revert accidentally included changes from previous commit

2024-07-15 Thread Krzysztof Parzyszek via cfe-commits
Author: Krzysztof Parzyszek Date: 2024-07-15T09:10:11-05:00 New Revision: 97ebc9794941d9e73792ab9deab7abafaf750a17 URL: https://github.com/llvm/llvm-project/commit/97ebc9794941d9e73792ab9deab7abafaf750a17 DIFF: https://github.com/llvm/llvm-project/commit/97ebc9794941d9e73792ab9deab7abafaf750a17

[clang] [clang][OpenMP] Update validity check for reduction with `inscan` (PR #98500)

2024-07-15 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz updated https://github.com/llvm/llvm-project/pull/98500 >From bc7e6962de9e1e44773eee89d0f552342b40 Mon Sep 17 00:00:00 2001 From: Krzysztof Parzyszek Date: Wed, 10 Jul 2024 14:38:57 -0500 Subject: [PATCH 1/4] [clang][OpenMP] Fix region nesting check for `scan` d

[clang] [llvm] [MC] Remove UseAssemblerInfoForParsing (PR #91082)

2024-05-15 Thread Krzysztof Parzyszek via cfe-commits
kparzysz wrote: It's still used: ``` /work/kparzysz/git/llvm.org/mlir/lib/Target/LLVM/ROCDL/Target.cpp: In member function ‘std::optional > mlir::ROCDL::SerializeGPUModuleBase::assembleIsa(llvm::StringRef)’: /work/kparzysz/git/llvm.org/mlir/lib/Target/LLVM/ROCDL/Target.cpp:302:15: error: ‘clas

[clang] [llvm] [MC] Remove UseAssemblerInfoForParsing (PR #91082)

2024-05-15 Thread Krzysztof Parzyszek via cfe-commits
kparzysz wrote: > But why? I don't know what business MLIR could possibly have touching this, > for AMDGPU of all things I don't know why, but my build is failing now. https://github.com/llvm/llvm-project/pull/91082 ___ cfe-commits mailing list cfe-c

[clang] [llvm] [MC] Remove UseAssemblerInfoForParsing (PR #91082)

2024-05-15 Thread Krzysztof Parzyszek via cfe-commits
kparzysz wrote: Problem solved in 29c2475f215110d9e6b3955d5eb2832b3f719c2f. https://github.com/llvm/llvm-project/pull/91082 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Frontend][OpenMP] Remove `reduction` from allowed clauses for `target` (PR #90754)

2024-05-22 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz updated https://github.com/llvm/llvm-project/pull/90754 >From 94d79223a5c1daab292157576e8e84bb3280f22d Mon Sep 17 00:00:00 2001 From: Krzysztof Parzyszek Date: Wed, 1 May 2024 12:21:51 -0500 Subject: [PATCH] [Frontend][OpenMP] Remove `reduction` from allowed clauses

[clang] [llvm] [Frontend][OpenMP] Remove `reduction` from allowed clauses for `target` (PR #90754)

2024-05-22 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz updated https://github.com/llvm/llvm-project/pull/90754 >From 94d79223a5c1daab292157576e8e84bb3280f22d Mon Sep 17 00:00:00 2001 From: Krzysztof Parzyszek Date: Wed, 1 May 2024 12:21:51 -0500 Subject: [PATCH 1/2] [Frontend][OpenMP] Remove `reduction` from allowed cla

[clang] [llvm] [Frontend][OpenMP] Remove `reduction` from allowed clauses for `target` (PR #90754)

2024-05-22 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz updated https://github.com/llvm/llvm-project/pull/90754 >From 94d79223a5c1daab292157576e8e84bb3280f22d Mon Sep 17 00:00:00 2001 From: Krzysztof Parzyszek Date: Wed, 1 May 2024 12:21:51 -0500 Subject: [PATCH 1/3] [Frontend][OpenMP] Remove `reduction` from allowed cla

[clang] [llvm] [Frontend][OpenMP] Remove `reduction` from allowed clauses for `target` (PR #90754)

2024-05-23 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz updated https://github.com/llvm/llvm-project/pull/90754 >From 94d79223a5c1daab292157576e8e84bb3280f22d Mon Sep 17 00:00:00 2001 From: Krzysztof Parzyszek Date: Wed, 1 May 2024 12:21:51 -0500 Subject: [PATCH 1/3] [Frontend][OpenMP] Remove `reduction` from allowed cla

[clang] [clang] fix(93002): clang/lib/Sema/SemaOpenMP.cpp:7405: Possible & / && mixup ? (PR #93093)

2024-05-23 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz approved this pull request. https://github.com/llvm/llvm-project/pull/93093 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 4c8becb - [Hexagon] Add Hexagon v69 builtins to clang

2021-12-23 Thread Krzysztof Parzyszek via cfe-commits
Author: Krzysztof Parzyszek Date: 2021-12-23T09:00:15-08:00 New Revision: 4c8becbeee18a4ef83a6d8005b0e0fe19a5077ed URL: https://github.com/llvm/llvm-project/commit/4c8becbeee18a4ef83a6d8005b0e0fe19a5077ed DIFF: https://github.com/llvm/llvm-project/commit/4c8becbeee18a4ef83a6d8005b0e0fe19a5077ed

[clang] 1d1b5ef - [Hexagon] Driver/preprocessor options for Hexagon v69

2021-12-23 Thread Krzysztof Parzyszek via cfe-commits
Author: Krzysztof Parzyszek Date: 2021-12-23T10:17:08-08:00 New Revision: 1d1b5efdef49fa814a7e4feadd175a3dfc6460a0 URL: https://github.com/llvm/llvm-project/commit/1d1b5efdef49fa814a7e4feadd175a3dfc6460a0 DIFF: https://github.com/llvm/llvm-project/commit/1d1b5efdef49fa814a7e4feadd175a3dfc6460a0

[clang] a67c0fc - [Hexagon] Revamp HVX flag verification in driver

2021-12-23 Thread Krzysztof Parzyszek via cfe-commits
Author: Krzysztof Parzyszek Date: 2021-12-23T15:18:08-08:00 New Revision: a67c0fc1fbe8479eb5b3d7c189395bfe6cb98086 URL: https://github.com/llvm/llvm-project/commit/a67c0fc1fbe8479eb5b3d7c189395bfe6cb98086 DIFF: https://github.com/llvm/llvm-project/commit/a67c0fc1fbe8479eb5b3d7c189395bfe6cb98086

[clang] e05307f - [clang][OpenMP] Avoid multiple calls to getCurrentDirective in DSAChecker, NFC

2024-08-18 Thread Krzysztof Parzyszek via cfe-commits
Author: Krzysztof Parzyszek Date: 2024-08-18T10:25:52-05:00 New Revision: e05307f6633ca405834a4fd24d858ffb676c9170 URL: https://github.com/llvm/llvm-project/commit/e05307f6633ca405834a4fd24d858ffb676c9170 DIFF: https://github.com/llvm/llvm-project/commit/e05307f6633ca405834a4fd24d858ffb676c9170

[clang] de5ea2d - [clang][OpenMP] Change /* ParamName */ to /*ParamName=*/, NFC

2024-08-18 Thread Krzysztof Parzyszek via cfe-commits
Author: Krzysztof Parzyszek Date: 2024-08-18T10:48:49-05:00 New Revision: de5ea2d122c31e1551654ff506c33df299f351b8 URL: https://github.com/llvm/llvm-project/commit/de5ea2d122c31e1551654ff506c33df299f351b8 DIFF: https://github.com/llvm/llvm-project/commit/de5ea2d122c31e1551654ff506c33df299f351b8

[clang] [llvm] [OpenMP] Diagnostic check for imperfect loop collapse (PR #96087)

2024-08-19 Thread Krzysztof Parzyszek via cfe-commits
kparzysz wrote: > I think you're right for this particular test case, but I don't think that > solution works in general. Consider something like: > > ``` > int arr1[N][N], arr2[N]; > > #pragma omp parallel for collapse(2) > { > for (int i = 0; i < N; i++) { > arr2[i] = i; > for (int

[clang] [Clang] Fix ICE in SemaOpenMP with structured binding (PR #104822)

2024-08-19 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz approved this pull request. LGTM. We will complain when someone tries to capture a structure binding anyway. https://github.com/llvm/llvm-project/pull/104822 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[clang] 1c3955f - [clang][OpenMP] Fix typo in comment, NFC

2024-08-20 Thread Krzysztof Parzyszek via cfe-commits
Author: Krzysztof Parzyszek Date: 2024-08-20T10:07:19-05:00 New Revision: 1c3955f9dff9b653be88d5dea5bc3cd007904e90 URL: https://github.com/llvm/llvm-project/commit/1c3955f9dff9b653be88d5dea5bc3cd007904e90 DIFF: https://github.com/llvm/llvm-project/commit/1c3955f9dff9b653be88d5dea5bc3cd007904e90

[clang] [llvm] [clang][OpenMP] Shorten directive classification in ParseOpenMP (PR #94691)

2024-06-21 Thread Krzysztof Parzyszek via cfe-commits
kparzysz wrote: Ping. Anyone? https://github.com/llvm/llvm-project/pull/94691 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][OpenMP] Shorten directive classification in ParseOpenMP (PR #94691)

2024-06-25 Thread Krzysztof Parzyszek via cfe-commits
@@ -2374,86 +2374,209 @@ Parser::DeclGroupPtrTy Parser::ParseOpenMPDeclarativeDirectiveWithExtDecl( case OMPD_unknown: Diag(Tok, diag::err_omp_unknown_directive); break; - case OMPD_parallel: - case OMPD_simd: - case OMPD_tile: - case OMPD_unroll: - case OMPD_ta

[clang] [llvm] [clang][OpenMP] Shorten directive classification in ParseOpenMP (PR #94691)

2024-06-25 Thread Krzysztof Parzyszek via cfe-commits
@@ -2374,86 +2374,209 @@ Parser::DeclGroupPtrTy Parser::ParseOpenMPDeclarativeDirectiveWithExtDecl( case OMPD_unknown: Diag(Tok, diag::err_omp_unknown_directive); break; - case OMPD_parallel: - case OMPD_simd: - case OMPD_tile: - case OMPD_unroll: - case OMPD_ta

[clang] [llvm] [clang][OpenMP] Shorten directive classification in ParseOpenMP (PR #94691)

2024-06-25 Thread Krzysztof Parzyszek via cfe-commits
@@ -2374,88 +2374,206 @@ Parser::DeclGroupPtrTy Parser::ParseOpenMPDeclarativeDirectiveWithExtDecl( case OMPD_unknown: Diag(Tok, diag::err_omp_unknown_directive); break; - case OMPD_parallel: - case OMPD_simd: - case OMPD_tile: - case OMPD_unroll: - case OMPD_ta

[clang] [llvm] [clang][OpenMP] Shorten directive classification in ParseOpenMP (PR #94691)

2024-06-25 Thread Krzysztof Parzyszek via cfe-commits
@@ -2503,24 +2621,36 @@ StmtResult Parser::ParseOpenMPDeclarativeOrExecutableDirective( "Not an OpenMP directive!"); ParsingOpenMPDirectiveRAII DirScope(*this); ParenBraceBracketBalancer BalancerRAIIObj(*this); - SmallVector Clauses; - std::bitset SeenClauses;

[clang] [llvm] [clang][OpenMP] Shorten directive classification in ParseOpenMP (PR #94691)

2024-06-26 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz closed https://github.com/llvm/llvm-project/pull/94691 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][OpenMP] Place some common code in functions (PR #96811)

2024-06-26 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz created https://github.com/llvm/llvm-project/pull/96811 There are chunks of code repeated in a number of functions. This patch moves some of that code into individual functions. >From 0eea7de1769025333eaa90bd5022eebafe22996d Mon Sep 17 00:00:00 2001 From: Krzysztof

[clang] [clang][OpenMP] Place some common code in functions (PR #96811)

2024-06-26 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz updated https://github.com/llvm/llvm-project/pull/96811 >From 0eea7de1769025333eaa90bd5022eebafe22996d Mon Sep 17 00:00:00 2001 From: Krzysztof Parzyszek Date: Wed, 26 Jun 2024 12:15:14 -0500 Subject: [PATCH 1/3] [clang][OpenMP] Place some common code in functions T

[clang] [clang][OpenMP] Place some common code in functions (PR #96811)

2024-06-26 Thread Krzysztof Parzyszek via cfe-commits
@@ -3010,6 +3010,28 @@ static bool FinishOpenMPLinearClause(OMPLinearClause &Clause, DeclRefExpr *IV, Expr *NumIterations, Sema &SemaRef, Scope *S, DSAStackTy *Stack); +static bool finishLinearClauses(S

[clang] [clang][OpenMP] Place some common code in functions (PR #96811)

2024-06-26 Thread Krzysztof Parzyszek via cfe-commits
@@ -7994,13 +8016,9 @@ void SemaOpenMP::ActOnOpenMPDeclareVariantDirective( FD->addAttr(NewAttr); } -StmtResult -SemaOpenMP::ActOnOpenMPParallelDirective(ArrayRef Clauses, - Stmt *AStmt, SourceLocation StartLoc, -

[clang] [clang][OpenMP] Place some common code in functions (PR #96811)

2024-06-26 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz updated https://github.com/llvm/llvm-project/pull/96811 >From 0eea7de1769025333eaa90bd5022eebafe22996d Mon Sep 17 00:00:00 2001 From: Krzysztof Parzyszek Date: Wed, 26 Jun 2024 12:15:14 -0500 Subject: [PATCH 1/4] [clang][OpenMP] Place some common code in functions T

[clang] [clang][OpenMP] Place some common code in functions (PR #96811)

2024-06-27 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz closed https://github.com/llvm/llvm-project/pull/96811 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 4ed8796 - [clang][OpenMP] clang-format SemaOpenMP.cpp, NFC

2024-06-27 Thread Krzysztof Parzyszek via cfe-commits
Author: Krzysztof Parzyszek Date: 2024-06-27T09:05:48-05:00 New Revision: 4ed8796bfe7e2666b56ae9fc5b8fe9ec05e0566f URL: https://github.com/llvm/llvm-project/commit/4ed8796bfe7e2666b56ae9fc5b8fe9ec05e0566f DIFF: https://github.com/llvm/llvm-project/commit/4ed8796bfe7e2666b56ae9fc5b8fe9ec05e0566f

[clang] [clang][OpenMP] Simplify handling of `if` clause (PR #96936)

2024-06-27 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz created https://github.com/llvm/llvm-project/pull/96936 Get the allowed name modifiers from the list of constituent leaf directives. >From e42fa94623d920a216636318600c7e303ef6fc9d Mon Sep 17 00:00:00 2001 From: Krzysztof Parzyszek Date: Thu, 27 Jun 2024 12:11:06 -05

[clang] [clang][OpenMP] Simplify handling of `if` clause (PR #96936)

2024-06-28 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz closed https://github.com/llvm/llvm-project/pull/96936 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenMP] [NFC] SemaOpenMP.cpp and StmtOpenMP.cpp spelling fixes (PR #96814)

2024-06-28 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz approved this pull request. https://github.com/llvm/llvm-project/pull/96814 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenMP] [NFC] SemaOpenMP.cpp and StmtOpenMP.cpp spelling fixes (PR #96814)

2024-06-28 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz closed https://github.com/llvm/llvm-project/pull/96814 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][OpenMP] Implement `isOpenMPExecutableDirective` (PR #97089)

2024-06-28 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz created https://github.com/llvm/llvm-project/pull/97089 What is considered "executable" in clang differs slightly from the OpenMP's "executable" category. In addition to the executable category, subsidiary directives, and OMPD_error are considered executable. Imple

[clang] [clang][OpenMP] Implement `isOpenMPExecutableDirective` (PR #97089)

2024-06-28 Thread Krzysztof Parzyszek via cfe-commits
@@ -368,6 +368,14 @@ bool needsTaskBasedThreadLimit(OpenMPDirectiveKind DKind); /// is restricted only to memory order clauses of "OMPC_acquire", /// "OMPC_relaxed" and "OMPC_seq_cst". bool checkFailClauseParameter(OpenMPClauseKind FailClauseParameter); + +/// Checks if the spe

[clang] [clang][OpenMP] Implement `isOpenMPExecutableDirective` (PR #97089)

2024-06-28 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz updated https://github.com/llvm/llvm-project/pull/97089 >From 789ec614d285e3fe632aae6280f6c4cf01746cdf Mon Sep 17 00:00:00 2001 From: Krzysztof Parzyszek Date: Fri, 28 Jun 2024 12:27:10 -0500 Subject: [PATCH 1/2] [clang][OpenMP] Implement `isOpenMPExecutableDirective

[clang] [clang][OpenMP] Implement `isOpenMPExecutableDirective` (PR #97089)

2024-06-28 Thread Krzysztof Parzyszek via cfe-commits
@@ -368,6 +368,14 @@ bool needsTaskBasedThreadLimit(OpenMPDirectiveKind DKind); /// is restricted only to memory order clauses of "OMPC_acquire", /// "OMPC_relaxed" and "OMPC_seq_cst". bool checkFailClauseParameter(OpenMPClauseKind FailClauseParameter); + +/// Checks if the spe

[clang] [clang][OpenMP] Implement `isOpenMPExecutableDirective` (PR #97089)

2024-06-28 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz updated https://github.com/llvm/llvm-project/pull/97089 >From 789ec614d285e3fe632aae6280f6c4cf01746cdf Mon Sep 17 00:00:00 2001 From: Krzysztof Parzyszek Date: Fri, 28 Jun 2024 12:27:10 -0500 Subject: [PATCH 1/2] [clang][OpenMP] Implement `isOpenMPExecutableDirective

[clang] [clang][OpenMP] Implement `isOpenMPExecutableDirective` (PR #97089)

2024-06-29 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz closed https://github.com/llvm/llvm-project/pull/97089 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][OpenMP] Implement `isOpenMPCapturingDirective` (PR #97090)

2024-06-29 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz edited https://github.com/llvm/llvm-project/pull/97090 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Format clang/lib/Sema/Sema.cpp (PR #111518)

2024-10-08 Thread Krzysztof Parzyszek via cfe-commits
kparzysz wrote: > Right, use `git clang-format`, that will take care of formatting the file > over time without creating churn. I think the number of changes is relatively small for a file this size. The churn here is comparable to that created by a "normal" patch... https://github.com/llvm/

[clang] [NFC][Sema][OpenMP] Fix free-nonheap-object warning (PR #112942)

2024-10-21 Thread Krzysztof Parzyszek via cfe-commits
kparzysz wrote: Thanks! I was getting these warning too. https://github.com/llvm/llvm-project/pull/112942 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][Sema][OpenMP] Fix free-nonheap-object warning (PR #112942)

2024-10-21 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz approved this pull request. https://github.com/llvm/llvm-project/pull/112942 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC] [clang] Use std::string instead of StringRef to reduce stack usage (PR #114285)

2024-10-30 Thread Krzysztof Parzyszek via cfe-commits
kparzysz wrote: I was able to see the internal bug report. This shows up when some code on Windows runs clang (via a library call), and it ends up crashing due to stack overflow. The crash happens in this function, in "__chkstk" to be exact. https://github.com/llvm/llvm-project/pull/114285 _

[clang] [NFC] [clang] Use std::string instead of StringRef to reduce stack usage (PR #114285)

2024-10-30 Thread Krzysztof Parzyszek via cfe-commits
kparzysz wrote: > Don't see how or why this would introduce stackusage. std::string temporaries > should be avoided whenever possible The code that's included afterwards contains a lot of comparisons with string literals: ``` if (Name == "aarch64_sve_pcs" && getSyntax() == AttributeCommonInfo:

[clang] [Clang] Implement resource directory headers for common GPU intrinsics (PR #110179)

2024-09-27 Thread Krzysztof Parzyszek via cfe-commits
kparzysz wrote: > Yeah I was actually wondering if I should go for something like this: > > ```c > #ifdef __NVPTX__ > uint32_t nvptx_get_thread_id_x() { return __nvvm_ptx_read_sreg_tid_x(); } > #define IMPL nvptx > #endif > uint32_t gpu_get_thread_id_x() { return ##IMPL##_get_thread_id_x(); } >

[clang] [llvm] [clang][OpenMP] Prototype #1 of directive splitting (PR #108855)

2024-09-18 Thread Krzysztof Parzyszek via cfe-commits
kparzysz wrote: Right now it's about 400 check-clang failures for all changes together. Adding AST nodes for directives in templates causes 12 failures (mostly in slightly differing diagnostics), adding capturing regions for all constituents will have its own share, but the majority comes fro

[clang] [clang] Replace "can't" and "can not" in diagnostics with "cannot" (PR #116623)

2024-11-18 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz closed https://github.com/llvm/llvm-project/pull/116623 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Replace "can't" and "can not" in diagnostics with "cannot" (PR #116623)

2024-11-18 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz created https://github.com/llvm/llvm-project/pull/116623 See https://discourse.llvm.org/t/cant-cannot-can-not-in-diagnostic-messages/83171 >From 489d5a0c1f9cb53e87cbbf30e8ddec83820e0326 Mon Sep 17 00:00:00 2001 From: Krzysztof Parzyszek Date: Mon, 18 Nov 2024 07:51

[clang] Clarify use of contractions in diagnostic messages (PR #116803)

2024-11-19 Thread Krzysztof Parzyszek via cfe-commits
kparzysz wrote: Here's another thing---could there be tools that try to parse the messages (e.g. something that runs clang and presents the messages to the user in some form)? Having a policy such as "single quotes only come in pairs" could make it easier. I don't know if that's something we

[clang] [clang] Replace "can't" and "can not" in diagnostics with "cannot" (PR #116623)

2024-11-18 Thread Krzysztof Parzyszek via cfe-commits
kparzysz wrote: I (visually) looked at all occurrences of `can\>` in the td files, and I didn't see any occurring at the end of a line, or in a place where a `not` could be pasted into the message following the `can`. It was a "best effort" inspection, but there weren't too many of these, so

[clang] [clang][OpenMP] Slightly refactor EndOpenMPDSABlock for readability, NFC (PR #109003)

2024-09-17 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz created https://github.com/llvm/llvm-project/pull/109003 Change the loop ``` if (isOpenMPExecutableDirective) for (Clause) if (Clause is kind1) multi line do something1; else if (Clause is kind2) ... ...

[clang] [clang][OpenMP] Slightly refactor EndOpenMPDSABlock for readability, NFC (PR #109003)

2024-09-17 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz updated https://github.com/llvm/llvm-project/pull/109003 >From d9bb31da5c897aad0dbc55781df2341db75aad6d Mon Sep 17 00:00:00 2001 From: Krzysztof Parzyszek Date: Mon, 12 Aug 2024 08:46:12 -0500 Subject: [PATCH 1/2] [clang][OpenMP] Slightly refactor EndOpenMPDSABlock f

[clang] [clang][OpenMP] Slightly refactor EndOpenMPDSABlock for readability, NFC (PR #109003)

2024-09-17 Thread Krzysztof Parzyszek via cfe-commits
@@ -2861,113 +2861,120 @@ void SemaOpenMP::EndOpenMPDSABlock(Stmt *CurDirective) { // clause requires an accessible, unambiguous default constructor for the // class type, unless the list item is also specified in a firstprivate // clause. - if (const auto *D = dyn_c

[clang] [clang][OpenMP] Slightly refactor EndOpenMPDSABlock for readability, NFC (PR #109003)

2024-09-17 Thread Krzysztof Parzyszek via cfe-commits
@@ -2861,113 +2861,120 @@ void SemaOpenMP::EndOpenMPDSABlock(Stmt *CurDirective) { // clause requires an accessible, unambiguous default constructor for the // class type, unless the list item is also specified in a firstprivate // clause. - if (const auto *D = dyn_c

[clang] [clang][OpenMP] Slightly refactor EndOpenMPDSABlock for readability, NFC (PR #109003)

2024-09-17 Thread Krzysztof Parzyszek via cfe-commits
@@ -2861,113 +2861,120 @@ void SemaOpenMP::EndOpenMPDSABlock(Stmt *CurDirective) { // clause requires an accessible, unambiguous default constructor for the // class type, unless the list item is also specified in a firstprivate // clause. - if (const auto *D = dyn_c

[clang] [clang][OpenMP] Slightly refactor EndOpenMPDSABlock for readability, NFC (PR #109003)

2024-09-17 Thread Krzysztof Parzyszek via cfe-commits
@@ -2861,113 +2861,120 @@ void SemaOpenMP::EndOpenMPDSABlock(Stmt *CurDirective) { // clause requires an accessible, unambiguous default constructor for the // class type, unless the list item is also specified in a firstprivate // clause. - if (const auto *D = dyn_c

[clang] [clang][OpenMP] Slightly refactor EndOpenMPDSABlock for readability, NFC (PR #109003)

2024-09-17 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz closed https://github.com/llvm/llvm-project/pull/109003 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [Flang][OpenMP] Add -fopenmp-default-none command line flag (PR #120287)

2024-12-18 Thread Krzysztof Parzyszek via cfe-commits
kparzysz wrote: Is NONE special enough to have a dedicated option, or could we have `-fopenmp-default=` for any dsa? https://github.com/llvm/llvm-project/pull/120287 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[clang] [llvm] [Clang] [OpenMP] Add support for '#pragma omp stripe'. (PR #119891)

2025-01-08 Thread Krzysztof Parzyszek via cfe-commits
@@ -2158,6 +2158,10 @@ enum CXCursorKind { */ CXCursor_OMPAssumeDirective = 309, + /** OpenMP assume directive. + */ + CXCursor_OMPStripeDirective = 310, kparzysz wrote: Please add this to `clang/bindings/python/clang/cindex.py` as well. https://git

[clang] [flang] [Flang][Driver] Deprecate Ofast (PR #101701)

2025-01-21 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz approved this pull request. Thanks! https://github.com/llvm/llvm-project/pull/101701 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenMP] Allow GPUs to be targeted directly via `-fopenmp`. (PR #122149)

2025-01-08 Thread Krzysztof Parzyszek via cfe-commits
kparzysz wrote: To me this looks like compilation for a host, except the GPU is the host. The only functions that could be called from such a CU would be the top-level ones, not any of the auto-generated one. Additionally, the host wouldn't support offload, so we'd need to do something about

[clang] Update OpenMPSupport.rst (PR #122174)

2025-01-08 Thread Krzysztof Parzyszek via cfe-commits
@@ -343,6 +343,124 @@ implementation. | task | nowait clause on taskwait | :part:`partial` | parsing/sema done: D131830, D141531 | +--+---

[clang] [llvm] [Clang] [OpenMP] Add support for '#pragma omp stripe'. (PR #119891)

2025-01-17 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz approved this pull request. LGTM, but please address Alexey's comments before merging. https://github.com/llvm/llvm-project/pull/119891 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/m

[clang] [OpenMP] Allow GPUs to be targeted directly via `-fopenmp`. (PR #122149)

2025-01-09 Thread Krzysztof Parzyszek via cfe-commits
kparzysz wrote: > All that said, there are two cases to consider wrt. the standard: > > 1. The initial device is the CPU and the code compiled here is just part of a > GPU library, or > 2. the initial device is the GPU and the code compiled here is just part of > the "host code". > > For 1),

[clang] default clause replaced by otherwise clause for metadirective in OpenMP 5.2 (PR #128640)

2025-03-24 Thread Krzysztof Parzyszek via cfe-commits
@@ -1657,6 +1657,10 @@ def err_omp_expected_colon : Error<"missing ':' in %0">; def err_omp_missing_comma : Error< "missing ',' after %0">; def err_omp_expected_context_selector : Error<"expected valid context selector in %0">; +def err_omp_unknown_clause +: Error<"unkn

[clang] default clause replaced by otherwise clause for metadirective in OpenMP 5.2 (PR #128640)

2025-04-05 Thread Krzysztof Parzyszek via cfe-commits
@@ -2759,6 +2759,19 @@ StmtResult Parser::ParseOpenMPDeclarativeOrExecutableDirective( OpenMPClauseKind CKind = Tok.isAnnotation() ? OMPC_unknown : getOpenMPClauseKind(PP.getSpelling(Tok)); + // C

[clang] [llvm] [OpenMP] Remove "alternativeName" from Clause and Directive classes (PR #138179)

2025-05-02 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz closed https://github.com/llvm/llvm-project/pull/138179 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [OpenMP] Remove "alternativeName" from Clause and Directive classes (PR #138179)

2025-05-01 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz created https://github.com/llvm/llvm-project/pull/138179 The "alternativeName" was introduced ~5 years ago in D82405, and at the moment it has only one use, the one that the original change introduced. OpenMP 6.0 spec has introduced different spellings of some direc

[clang] [llvm] [OpenMP] Remove "alternativeName" from Clause and Directive classes (PR #138179)

2025-05-01 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz updated https://github.com/llvm/llvm-project/pull/138179 >From d991e966f12229fc4a9cc1114e3fa4651bc9d59d Mon Sep 17 00:00:00 2001 From: Krzysztof Parzyszek Date: Thu, 1 May 2025 11:42:12 -0500 Subject: [PATCH 1/2] [OpenMP] Remove "alternativeName" from Clause and Dir

[clang] [llvm] [OpenMP] Remove "alternativeName" from Clause and Directive classes (PR #138179)

2025-05-02 Thread Krzysztof Parzyszek via cfe-commits
kparzysz wrote: @alexey-bataev Are you ok with the change in SemaOpenMP? https://github.com/llvm/llvm-project/pull/138179 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [flang/clang] Adding use of Clang's diagnostics in Flang (PR #130593)

2025-03-11 Thread Krzysztof Parzyszek via cfe-commits
kparzysz wrote: > In general, we aim to only depend on libClangDriver and move it to LLVM so > that Flang need not depend on Clang or its libraries. If this patch increases > the dependency on Clang it might not be acceptable. Agreed. 👍 @JDPailleux: It may a good idea to extract the diagnost

[clang] [llvm] [clang] [OpenMP] New OpenMP 6.0 self_maps clause - CodeGen (PR #134131)

2025-04-03 Thread Krzysztof Parzyszek via cfe-commits
@@ -236,6 +236,8 @@ enum class OpenMPOffloadMappingFlags : uint64_t { // dynamic. // This is an OpenMP extension for the sake of OpenACC support. OMP_MAP_OMPX_HOLD = 0x2000, + /// Self directs mapping without creating a separate device copy. + OMP_MAP_SELF = 0x4000, ---

[clang] [flang] [llvm] [flang][OpenMP] Pass OpenMP version to getOpenMPDirectiveName (PR #139131)

2025-05-09 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz edited https://github.com/llvm/llvm-project/pull/139131 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][OpenMP] Pass OpenMP version to getOpenMPDirectiveName (PR #139115)

2025-05-09 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz edited https://github.com/llvm/llvm-project/pull/139115 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][OpenMP] Pass OpenMP version to getOpenMPDirectiveName (PR #139115)

2025-05-09 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz closed https://github.com/llvm/llvm-project/pull/139115 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [llvm] [flang][OpenMP] Pass OpenMP version to getOpenMPDirectiveName (PR #139131)

2025-05-09 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz closed https://github.com/llvm/llvm-project/pull/139131 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][OpenMP] Treat "workshare" as unknown OpenMP directive (PR #139793)

2025-05-13 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz created https://github.com/llvm/llvm-project/pull/139793 The "workshare" construct is only present in Fortran. The common OpenMP code does treat it as any other directive, but in clang we need to reject it, and do so gracefully before it encounters an internal asser

[clang] [clang][OpenMP] Treat "workshare" as unknown OpenMP directive (PR #139793)

2025-05-14 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz closed https://github.com/llvm/llvm-project/pull/139793 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] 11e804f - [clang-doc] Fix build break with BUILD_SHARED_LIBS=ON

2025-05-28 Thread Krzysztof Parzyszek via cfe-commits
Author: Krzysztof Parzyszek Date: 2025-05-28T08:13:31-05:00 New Revision: 11e804fcabce11a9fdfb4033263ef1e502cc8a72 URL: https://github.com/llvm/llvm-project/commit/11e804fcabce11a9fdfb4033263ef1e502cc8a72 DIFF: https://github.com/llvm/llvm-project/commit/11e804fcabce11a9fdfb4033263ef1e502cc8a72

[clang] [llvm] [clang][OpenMP] Improve handling of non-C/C++ directives (PR #139961)

2025-05-15 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz closed https://github.com/llvm/llvm-project/pull/139961 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    1   2   3   4   5   >