sdkrystian wrote:
@adam-smnk Should have the fix merged today
https://github.com/llvm/llvm-project/pull/111852
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/113464
>From 7542bda555601ed537dd9bacde65537021cf402d Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Wed, 23 Oct 2024 10:28:23 -0400
Subject: [PATCH 1/5] [Clang][Sema] Ignore previous partial specializatio
https://github.com/sdkrystian created
https://github.com/llvm/llvm-project/pull/115040
According to the [Doxygen
documentation](https://www.doxygen.nl/manual/commands.html#cmdrelates), the
`relates`, `related`, `relatesalso`, and `relatedalso` commands all have a
single argument. This patch c
https://github.com/sdkrystian edited
https://github.com/llvm/llvm-project/pull/115040
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sdkrystian wrote:
@asmok-g You're in luck, because I was just about to merge this now :)
https://github.com/llvm/llvm-project/pull/114258
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
https://github.com/sdkrystian closed
https://github.com/llvm/llvm-project/pull/113464
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sdkrystian wrote:
@erichkeane @felipepiovezan Given that all the failing tests relate to
expression evaluation within modules, I think the problem is in `ASTImporter`.
https://github.com/llvm/llvm-project/pull/114258
___
cfe-commits mailing list
cfe-c
sdkrystian wrote:
@asmok-g @usx95 @steelannelida I have a fix ready in #114258
https://github.com/llvm/llvm-project/pull/111852
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sdkrystian created
https://github.com/llvm/llvm-project/pull/114258
This patch fixes a couple of regressions introduced in #111852.
Consider:
```cpp
template
struct A
{
template
static constexpr bool f() requires U
{
return true;
}
};
template<>
temp
https://github.com/sdkrystian edited
https://github.com/llvm/llvm-project/pull/114258
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sdkrystian closed
https://github.com/llvm/llvm-project/pull/114258
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/113464
>From 7542bda555601ed537dd9bacde65537021cf402d Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Wed, 23 Oct 2024 10:28:23 -0400
Subject: [PATCH 1/4] [Clang][Sema] Ignore previous partial specializatio
sdkrystian wrote:
> Yup, that fixes the issue. I've also confirmed that reverting the fix brings
> back the crash!
Great!
> It is weird that you were unable to repro this 🤔 (or rather that it was also
> crashing when you reverted the original patch...) Are you 100% sure you
> recompiled LLDB
sdkrystian wrote:
@felipepiovezan I tested without this patch applied and was still seeing
crashes... could you perhaps see if
https://github.com/sdkrystian/llvm-project/tree/reapply-use-latest-primary
fixes the regression?
https://github.com/llvm/llvm-project/pull/114258
sdkrystian wrote:
Great! Hopefully this will be the last PR needed to finally get #106585 working
:)
https://github.com/llvm/llvm-project/pull/114569
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listin
https://github.com/sdkrystian created
https://github.com/llvm/llvm-project/pull/114569
This patch fixes an infinite recursion bug in `ASTImporter` that occurs when
importing the primary template of a class template specialization when the
latest redeclaration of that template is a friend decla
https://github.com/sdkrystian edited
https://github.com/llvm/llvm-project/pull/114569
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sdkrystian wrote:
Once I finish writing tests, I'll open a PR to reapply this patch
https://github.com/llvm/llvm-project/pull/114258
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/114569
>From 3764c063acd6f296b1f55f66f7cd7542d1b5c5ae Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Thu, 31 Oct 2024 13:52:21 -0400
Subject: [PATCH 1/3] Reapply "[Clang][Sema] Always use latest redeclarat
sdkrystian wrote:
I should hopefully have a fix ready tomorrow... apologies for the delay
@asmok-g! Getting this patch right is a bit hard since it touches all template
instantiation related things :)
https://github.com/llvm/llvm-project/pull/114258
https://github.com/sdkrystian closed
https://github.com/llvm/llvm-project/pull/114569
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sdkrystian wrote:
@steelannelida I'm unable to reproduce this error... by "module" do you mean
C++ module (a la `export module ...`)? If you can provide a godbolt like that
would be greatly appreciated :)
https://github.com/llvm/llvm-project/pull/111852
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/113579
>From 95c86a7036e62240ab7704f0b1e47cdc9ac437c6 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Tue, 15 Oct 2024 11:15:55 -0400
Subject: [PATCH 1/2] [Clang][AST] Store injected template arguments in
@@ -244,6 +245,17 @@ bool TemplateParameterList::hasAssociatedConstraints()
const {
return HasRequiresClause || HasConstrainedParameters;
}
+ArrayRef TemplateParameterList::getInjectedTemplateArgs() {
+ if (const auto *Context = InjectedArgs.dyn_cast()) {
+TemplateArgu
https://github.com/sdkrystian created
https://github.com/llvm/llvm-project/pull/113464
Consider the following:
```cpp
template
struct A {
template
struct B {
static constexpr int x = 0; // #1
};
template
struct B {
static constexpr int x = 1; // #2
};
};
template<>
template
https://github.com/sdkrystian edited
https://github.com/llvm/llvm-project/pull/113464
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sdkrystian wrote:
@vbe-sc I can later today or tomorrow.
https://github.com/llvm/llvm-project/pull/114978
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/115040
>From cba8a46cd0dcbdf5079712354e5d0829199e0e08 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Tue, 5 Nov 2024 12:59:42 -0500
Subject: [PATCH 1/2] [Clang][Comments] Make @relates an inline comment co
sdkrystian wrote:
@AaronBallman Test added
https://github.com/llvm/llvm-project/pull/115040
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sdkrystian closed
https://github.com/llvm/llvm-project/pull/115040
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sdkrystian wrote:
I've manually reduced the standalone reproducer to the following:
```cpp
template
struct A
{
template
static constexpr bool f();
};
template<>
template
constexpr bool A<0>::f()
{
return A<1>::f();
}
template<>
template
constexpr bool A<1>::f()
{
return true;
}
sdkrystian wrote:
Reduced further to:
```cpp
template
struct A
{
template
static constexpr bool f();
};
template<>
template
constexpr bool A<0>::f()
{
return A<1>::f(); // note: undefined function 'f' cannot be used in
a constant expression
}
template<>
template
constexpr bool A<1>
sdkrystian wrote:
Another example using class templates:
```cpp
template
struct A
{
template
struct B;
};
template<>
template
struct A<0>::B : A<1>::B { };
template<>
template
struct A<1>::B
{
static constexpr bool x = true;
};
static_assert(A<0>::B::x); // error: implicit instanti
https://github.com/sdkrystian edited
https://github.com/llvm/llvm-project/pull/109422
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sdkrystian closed
https://github.com/llvm/llvm-project/pull/106585
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2092,6 +2092,10 @@ void Sema::CheckCompatibleReinterpretCast(QualType
SrcType, QualType DestType,
}
}
+ if (SrcTy->isTemplateTypeParmType() || DestTy->isTemplateTypeParmType()) {
sdkrystian wrote:
This should probably be`if (SrcTy->isDependentType
https://github.com/sdkrystian requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/109430
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sdkrystian edited
https://github.com/llvm/llvm-project/pull/109430
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sdkrystian wrote:
> Does this need a release note?
I don't think so, since this fixes a bug introduced in the same release.
> Also, can you point out the 'diff' from the previous commit?
The condition of [the assert in
`SemaExprCXX.cpp`](https://github.com/llvm/llvm-project/pull/109422/files
https://github.com/sdkrystian created
https://github.com/llvm/llvm-project/pull/109422
Reapplies #104458, fixing a bug that occurs when a templated class declares
`operator->` to return a non-dependent class type.
>From d1b0cad696cca10c28ba32c290bc220ee917b48d Mon Sep 17 00:00:00 2001
From: Kr
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/109422
>From d1b0cad696cca10c28ba32c290bc220ee917b48d Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Thu, 15 Aug 2024 11:27:34 -0400
Subject: [PATCH 1/8] Reapply "[Clang][Sema] Use the correct lookup conte
sdkrystian wrote:
@zyn0217 I plan to reapply the patch after addressing the issues discussed
above, but I have to get some more pressing work stuff done first :)
https://github.com/llvm/llvm-project/pull/106585
___
cfe-commits mailing list
cfe-commits
https://github.com/sdkrystian created
https://github.com/llvm/llvm-project/pull/115157
This reverts commit 9381c6fd04cc16a7606633f57c96c11e58181ddb.
>From 026f442bd600bd50921bdcfe550b5ff4c376066e Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Wed, 6 Nov 2024 08:28:50 -0500
Subject: [
https://github.com/sdkrystian created
https://github.com/llvm/llvm-project/pull/115156
This reverts commit b24650e814e55d90acfc40acf045456c98f32b9c.
>From 026f442bd600bd50921bdcfe550b5ff4c376066e Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Wed, 6 Nov 2024 08:28:50 -0500
Subject: [
@@ -51,14 +51,15 @@ DefaultTemplateArgumentContainsUnexpandedPack(const
TemplateParam &P) {
P.getDefaultArgument().getArgument().containsUnexpandedParameterPack();
}
-TemplateParameterList::TemplateParameterList(const ASTContext& C,
+TemplateParameterList::TemplateP
@@ -51,14 +51,15 @@ DefaultTemplateArgumentContainsUnexpandedPack(const
TemplateParam &P) {
P.getDefaultArgument().getArgument().containsUnexpandedParameterPack();
}
-TemplateParameterList::TemplateParameterList(const ASTContext& C,
+TemplateParameterList::TemplateP
https://github.com/sdkrystian closed
https://github.com/llvm/llvm-project/pull/115172
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sdkrystian wrote:
@alexfh @wlei-llvm Please send a repro when you can!
https://github.com/llvm/llvm-project/pull/111852
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sdkrystian created
https://github.com/llvm/llvm-project/pull/115172
After #111852 was reverted in #115159, two tests now fail because they
partially depend on its changes. This patch temporarily fixes the failing cases
by updating the expected output to match the actual outp
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/115157
>From d36ee37cdba49332d36ab8204826e50614359e82 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Wed, 6 Nov 2024 08:36:04 -0500
Subject: [PATCH] Revert "[Clang][Sema] Use the correct injected template
https://github.com/sdkrystian closed
https://github.com/llvm/llvm-project/pull/115157
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sdkrystian closed
https://github.com/llvm/llvm-project/pull/115159
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sdkrystian wrote:
Reverted in #115156, #115157, and #115159.
https://github.com/llvm/llvm-project/pull/111852
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sdkrystian closed
https://github.com/llvm/llvm-project/pull/115156
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sdkrystian edited
https://github.com/llvm/llvm-project/pull/114978
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sdkrystian commented:
I don't think this patch fixes the following case:
```cpp
template
struct A
{
struct B
{
using X = int;
struct C
{
using X = void;
struct D;
};
};
};
template
struct A::B::C::D : B
sdkrystian wrote:
@ericniebler Once I merge #106585, I have a follow up patch ready that will fix
#101330.
https://github.com/llvm/llvm-project/pull/102267
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/
sdkrystian wrote:
Ping @erichkeane
https://github.com/llvm/llvm-project/pull/106585
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -585,8 +585,8 @@ static bool CheckConstraintSatisfaction(
ArrayRef TemplateArgs =
TemplateArgsLists.getNumSubstitutedLevels() > 0
- ? TemplateArgsLists.getOutermost()
- : ArrayRef {};
+ ? TemplateArgsLists.getInnermost()
s
sdkrystian wrote:
@porglezomp Sorry, I'm currently at cppcon but I'll try reland it when I have a
moment.
https://github.com/llvm/llvm-project/pull/104458
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/l
@@ -585,8 +585,8 @@ static bool CheckConstraintSatisfaction(
ArrayRef TemplateArgs =
TemplateArgsLists.getNumSubstitutedLevels() > 0
- ? TemplateArgsLists.getOutermost()
- : ArrayRef {};
+ ? TemplateArgsLists.getInnermost()
s
sdkrystian wrote:
FWIW, I'm going to try reland the `getTemplateInstantiationArgs` refactoring
again this week.
https://github.com/llvm/llvm-project/pull/102857
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/ma
sdkrystian wrote:
@zyn0217 Sorry, I've not had time to work on this recently. I have a branch
ready which _should_ address the issues encountered thus far, but I haven't
fully tested it yet. I should have time after the weekend.
https://github.com/llvm/llvm-project/pull/115159
https://github.com/sdkrystian closed
https://github.com/llvm/llvm-project/pull/109422
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sdkrystian closed
https://github.com/llvm/llvm-project/pull/123982
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/123982
>From c57b0c0bda26134131a4c846e0b81b000250709d Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Wed, 22 Jan 2025 13:43:38 -0500
Subject: [PATCH 1/2] =?UTF-8?q?Revert=20"Reapply=20"[Clang][Sema]=20Use=
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/109422
>From 6edb1455c03c8d6453ff813dd1c797dbaefc6398 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Thu, 15 Aug 2024 11:27:34 -0400
Subject: [PATCH 01/10] Reapply "[Clang][Sema] Use the correct lookup con
sdkrystian wrote:
@erichkeane I pushed a commit
([10ba129](https://github.com/llvm/llvm-project/pull/109422/commits/10ba1292798f16bc71fe8466a0ec84f146efb6f5))
which eliminates the out parameter in favor of building a
`CXXOperatorCallExpr` with type `ASTContext::DependentTy`. WDYT?
https://git
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/109422
>From 6edb1455c03c8d6453ff813dd1c797dbaefc6398 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Thu, 15 Aug 2024 11:27:34 -0400
Subject: [PATCH 01/11] Reapply "[Clang][Sema] Use the correct lookup con
https://github.com/sdkrystian created
https://github.com/llvm/llvm-project/pull/123982
Reverts llvm/llvm-project#109422
>From c57b0c0bda26134131a4c846e0b81b000250709d Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Wed, 22 Jan 2025 13:43:38 -0500
Subject: [PATCH] =?UTF-8?q?Revert=20"R
sdkrystian wrote:
Reverting due to a failure building clang.
https://github.com/llvm/llvm-project/pull/109422
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/109422
>From 6edb1455c03c8d6453ff813dd1c797dbaefc6398 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Thu, 15 Aug 2024 11:27:34 -0400
Subject: [PATCH 01/12] Reapply "[Clang][Sema] Use the correct lookup con
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/109422
>From 6edb1455c03c8d6453ff813dd1c797dbaefc6398 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Thu, 15 Aug 2024 11:27:34 -0400
Subject: [PATCH 1/8] Reapply "[Clang][Sema] Use the correct lookup conte
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/109422
>From 6edb1455c03c8d6453ff813dd1c797dbaefc6398 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Thu, 15 Aug 2024 11:27:34 -0400
Subject: [PATCH 1/9] Reapply "[Clang][Sema] Use the correct lookup conte
sdkrystian wrote:
> This appears to cause incorrect behavior in the following code:
>
> ```c++
> struct Pointee {
> template
> T *method() { return nullptr; }
> };
>
> template
> struct Pointer {
> T *pointer;
> T *operator->() { return pointer; }
> };
>
> struct Base {
>
901 - 975 of 975 matches
Mail list logo
