[clang] [Clang][Sema] Implement proposed resolution for CWG2847 (PR #80899)

https://github.com/sdkrystian updated https://github.com/llvm/llvm-project/pull/80899 >From f9079ac4098b2debf3df4ebee3e5f4f0c2b1e6a2 Mon Sep 17 00:00:00 2001 From: Krystian Stasiowski Date: Tue, 6 Feb 2024 14:22:37 -0500 Subject: [PATCH 1/2] [Clang][Sema] Implement proposed resolution for CWG28

[clang] [Clang][Sema] Implement proposed resolution for CWG2847 (PR #80899)

sdkrystian wrote: Whoops... changed it to `202002L` :) https://github.com/llvm/llvm-project/pull/80899 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Implement proposed resolution for CWG2847 (PR #80899)

https://github.com/sdkrystian updated https://github.com/llvm/llvm-project/pull/80899 >From f9079ac4098b2debf3df4ebee3e5f4f0c2b1e6a2 Mon Sep 17 00:00:00 2001 From: Krystian Stasiowski Date: Tue, 6 Feb 2024 14:22:37 -0500 Subject: [PATCH 1/2] [Clang][Sema] Implement proposed resolution for CWG28

[clang] [Clang][Sema] Implement proposed resolution for CWG2847 (PR #80899)

https://github.com/sdkrystian updated https://github.com/llvm/llvm-project/pull/80899 >From 671a0b01f0131b3d1dedfd3c9f74dcbe29a615b5 Mon Sep 17 00:00:00 2001 From: Krystian Stasiowski Date: Tue, 6 Feb 2024 14:22:37 -0500 Subject: [PATCH] [Clang][Sema] Implement proposed resolution for CWG2847

[clang] [Clang][Sema] Implement proposed resolution for CWG2847 (PR #80899)

https://github.com/sdkrystian closed https://github.com/llvm/llvm-project/pull/80899 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Diagnose friend declarations with enum elaborated-type-specifier in all language modes (PR #80171)

@@ -1637,10 +1637,8 @@ def err_inline_namespace_std : Error< def err_unexpected_friend : Error< "friends can only be classes or functions">; def ext_enum_friend : ExtWarn< - "befriending enumeration type %0 is a C++11 extension">, InGroup; -def warn_cxx98_compat_enum_friend

[clang] [Clang][Sema] Abbreviated function templates do not append invented parameters to empty template parameter lists (PR #80864)

https://github.com/sdkrystian updated https://github.com/llvm/llvm-project/pull/80864 >From 570e25f19b428fb7d2936091726727f9633eec35 Mon Sep 17 00:00:00 2001 From: Krystian Stasiowski Date: Tue, 6 Feb 2024 11:08:04 -0500 Subject: [PATCH 1/2] [Clang][Sema] Abbreviated function templates do not

[clang] [Clang][Sema] Abbreviated function templates do not append invented parameters to empty template parameter lists (PR #80864)

https://github.com/sdkrystian updated https://github.com/llvm/llvm-project/pull/80864 >From b28a6a478d021a15a6004c4f3f243ce26f6d86d8 Mon Sep 17 00:00:00 2001 From: Krystian Stasiowski Date: Tue, 6 Feb 2024 11:08:04 -0500 Subject: [PATCH 1/2] [Clang][Sema] Abbreviated function templates do not

[clang] [Clang][Sema] Abbreviated function templates do not append invented parameters to empty template parameter lists (PR #80864)

https://github.com/sdkrystian updated https://github.com/llvm/llvm-project/pull/80864 >From e4386e21a56c0d113c8f263af79fffa072d3da86 Mon Sep 17 00:00:00 2001 From: Krystian Stasiowski Date: Tue, 6 Feb 2024 11:08:04 -0500 Subject: [PATCH] [Clang][Sema] Abbreviated function templates do not appen

[clang] [Clang][Sema] Diagnose friend declarations with enum elaborated-type-specifier in all language modes (PR #80171)

@@ -2552,10 +2552,10 @@ class Parser : public CodeCompletionHandler { /// Starting with a scope specifier, identifier, or /// template-id that refers to the current class, determine whether /// this is a constructor declarator. - bool isConstructorDeclarator( - bool

[clang] [Clang][Sema] Diagnose friend declarations with enum elaborated-type-specifier in all language modes (PR #80171)

https://github.com/sdkrystian updated https://github.com/llvm/llvm-project/pull/80171 >From bcb66f80b29e6a330e28955f1e1bfc52f4c7399e Mon Sep 17 00:00:00 2001 From: Krystian Stasiowski Date: Wed, 31 Jan 2024 11:09:11 -0500 Subject: [PATCH 1/2] [Clang][Sema] Diagnose friend declarations with enum

[clang] [Clang][Sema] Diagnose friend declarations with enum elaborated-type-specifier in all language modes (PR #80171)

https://github.com/sdkrystian updated https://github.com/llvm/llvm-project/pull/80171 >From bcb66f80b29e6a330e28955f1e1bfc52f4c7399e Mon Sep 17 00:00:00 2001 From: Krystian Stasiowski Date: Wed, 31 Jan 2024 11:09:11 -0500 Subject: [PATCH 1/2] [Clang][Sema] Diagnose friend declarations with enum

[clang] [Clang][Sema] Diagnose friend declarations with enum elaborated-type-specifier in all language modes (PR #80171)

@@ -1637,10 +1637,8 @@ def err_inline_namespace_std : Error< def err_unexpected_friend : Error< "friends can only be classes or functions">; def ext_enum_friend : ExtWarn< - "befriending enumeration type %0 is a C++11 extension">, InGroup; -def warn_cxx98_compat_enum_friend

[clang] [Clang][Sema] Diagnose friend declarations with enum elaborated-type-specifier in all language modes (PR #80171)

https://github.com/sdkrystian updated https://github.com/llvm/llvm-project/pull/80171 >From 8e3524f7d4a88a7b868dc3d69bf63a5708db6a1f Mon Sep 17 00:00:00 2001 From: Krystian Stasiowski Date: Wed, 31 Jan 2024 11:09:11 -0500 Subject: [PATCH 1/2] [Clang][Sema] Diagnose friend declarations with enum

[clang] [Clang][Sema] Abbreviated function templates do not append invented parameters to empty template parameter lists (PR #80864)

https://github.com/sdkrystian updated https://github.com/llvm/llvm-project/pull/80864 >From db802e93c08ca1b490b4ad001b3d9ee4347d9eef Mon Sep 17 00:00:00 2001 From: Krystian Stasiowski Date: Tue, 6 Feb 2024 11:08:04 -0500 Subject: [PATCH] [Clang][Sema] Abbreviated function templates do not appen

[clang] [Clang][Sema] Diagnose friend declarations with enum elaborated-type-specifier in all language modes (PR #80171)

@@ -1637,10 +1637,8 @@ def err_inline_namespace_std : Error< def err_unexpected_friend : Error< "friends can only be classes or functions">; def ext_enum_friend : ExtWarn< - "befriending enumeration type %0 is a C++11 extension">, InGroup; -def warn_cxx98_compat_enum_friend

[clang] [Clang][Sema] Diagnose friend declarations with enum elaborated-type-specifier in all language modes (PR #80171)

@@ -1637,10 +1637,8 @@ def err_inline_namespace_std : Error< def err_unexpected_friend : Error< "friends can only be classes or functions">; def ext_enum_friend : ExtWarn< - "befriending enumeration type %0 is a C++11 extension">, InGroup; -def warn_cxx98_compat_enum_friend

[clang] [Clang][Sema] Diagnose friend declarations with enum elaborated-type-specifier in all language modes (PR #80171)

https://github.com/sdkrystian edited https://github.com/llvm/llvm-project/pull/80171 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Diagnose friend declarations with enum elaborated-type-specifier in all language modes (PR #80171)

https://github.com/sdkrystian updated https://github.com/llvm/llvm-project/pull/80171 >From 8e3524f7d4a88a7b868dc3d69bf63a5708db6a1f Mon Sep 17 00:00:00 2001 From: Krystian Stasiowski Date: Wed, 31 Jan 2024 11:09:11 -0500 Subject: [PATCH 1/3] [Clang][Sema] Diagnose friend declarations with enum

[clang] [Clang][Sema] Diagnose friend declarations with enum elaborated-type-specifier in all language modes (PR #80171)

https://github.com/sdkrystian updated https://github.com/llvm/llvm-project/pull/80171 >From 8e3524f7d4a88a7b868dc3d69bf63a5708db6a1f Mon Sep 17 00:00:00 2001 From: Krystian Stasiowski Date: Wed, 31 Jan 2024 11:09:11 -0500 Subject: [PATCH 1/3] [Clang][Sema] Diagnose friend declarations with enum

[clang] [Clang][Sema] Diagnose friend declarations with enum elaborated-type-specifier in all language modes (PR #80171)

@@ -1637,10 +1637,8 @@ def err_inline_namespace_std : Error< def err_unexpected_friend : Error< "friends can only be classes or functions">; def ext_enum_friend : ExtWarn< - "befriending enumeration type %0 is a C++11 extension">, InGroup; -def warn_cxx98_compat_enum_friend

[clang] [Clang][Sema] Diagnose friend declarations with enum elaborated-type-specifier in all language modes (PR #80171)

https://github.com/sdkrystian updated https://github.com/llvm/llvm-project/pull/80171 >From 8e3524f7d4a88a7b868dc3d69bf63a5708db6a1f Mon Sep 17 00:00:00 2001 From: Krystian Stasiowski Date: Wed, 31 Jan 2024 11:09:11 -0500 Subject: [PATCH 1/4] [Clang][Sema] Diagnose friend declarations with enum

[clang] [Clang][Sema] Diagnose friend declarations with enum elaborated-type-specifier in all language modes (PR #80171)

@@ -1637,10 +1637,8 @@ def err_inline_namespace_std : Error< def err_unexpected_friend : Error< "friends can only be classes or functions">; def ext_enum_friend : ExtWarn< - "befriending enumeration type %0 is a C++11 extension">, InGroup; -def warn_cxx98_compat_enum_friend

[clang] [Clang][Sema] Diagnose use of template keyword after declarative nested-name-specifiers (PR #78595)

sdkrystian wrote: @rupprecht This is intended behavior. We previously did not check qualified declarations of explicit/partial specializations of class templates for redundant qualification & invalid nested-name-specifiers (e.g. ones that begin with `decltype`). We do now, hence the new warnin

[clang] [Clang][Sema] Diagnose friend declarations with enum elaborated-type-specifier in all language modes (PR #80171)

https://github.com/sdkrystian updated https://github.com/llvm/llvm-project/pull/80171 >From 6f8851bf21ff0a6bc9b4f2ff39df6bf00f30ee34 Mon Sep 17 00:00:00 2001 From: Krystian Stasiowski Date: Wed, 31 Jan 2024 11:09:11 -0500 Subject: [PATCH] [Clang][Sema] Diagnose friend declarations with enum el

[clang] [Clang][Sema] Abbreviated function templates do not append invented parameters to empty template parameter lists (PR #80864)

https://github.com/sdkrystian updated https://github.com/llvm/llvm-project/pull/80864 >From 908b3a129ec02a7ecae0ed3b8386e4e505274315 Mon Sep 17 00:00:00 2001 From: Krystian Stasiowski Date: Tue, 6 Feb 2024 11:08:04 -0500 Subject: [PATCH] [Clang][Sema] Abbreviated function templates do not appen

[clang] [Clang][Sema] Abbreviated function templates do not append invented parameters to empty template parameter lists (PR #80864)

https://github.com/sdkrystian closed https://github.com/llvm/llvm-project/pull/80864 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Diagnose friend declarations with enum elaborated-type-specifier in all language modes (PR #80171)

https://github.com/sdkrystian updated https://github.com/llvm/llvm-project/pull/80171 >From 6f8851bf21ff0a6bc9b4f2ff39df6bf00f30ee34 Mon Sep 17 00:00:00 2001 From: Krystian Stasiowski Date: Wed, 31 Jan 2024 11:09:11 -0500 Subject: [PATCH 1/2] [Clang][Sema] Diagnose friend declarations with enum

[clang] [Clang][Sema] Diagnose friend declarations with enum elaborated-type-specifier in all language modes (PR #80171)

@@ -17242,6 +17242,23 @@ Sema::ActOnTag(Scope *S, unsigned TagSpec, TagUseKind TUK, SourceLocation KWLoc, return true; } + if (TUK == TUK_Friend && Kind == TagTypeKind::Enum) { +// C++23 [dcl.type.elab]p4: +// If an elaborated-type-specifier appears with th

[clang] [Clang][Sema] Abbreviated function templates do not append invented parameters to empty template parameter lists (PR #80864)

sdkrystian wrote: Looks like there is a test (`clang-tools-extra/test/clang-tidy/infrastructure/diagnostic.cpp`) that contains the following: ```cpp #ifdef PR64602 // Should not crash template struct S { auto foo(auto); }; template <> auto S<>::foo(auto) { return 1; } // CHECK8: error

[clang-tools-extra] [clang-tidy] Fix failing test after 17f0680f69f44d340fd0205f7763b2830357c0d5 (PR #81171)

https://github.com/sdkrystian created https://github.com/llvm/llvm-project/pull/81171 The following test case in `clang-tools-extra/test/clang-tidy/infrastructure/diagnostic.cpp` is failing: ```cpp #ifdef PR64602 // Should not crash template struct S { auto foo(auto); }; template <> auto

[clang-tools-extra] [clang-tidy] Fix failing test after #80864 (PR #81171)

https://github.com/sdkrystian edited https://github.com/llvm/llvm-project/pull/81171 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Fix failing test after #80864 (PR #81171)

https://github.com/sdkrystian updated https://github.com/llvm/llvm-project/pull/81171 >From ca871fca01e07bd1dcbdab3256cb1631dabca853 Mon Sep 17 00:00:00 2001 From: Krystian Stasiowski Date: Thu, 8 Feb 2024 13:42:38 -0500 Subject: [PATCH] [clang-tidy] Fix failing test after 17f0680f69f44d340fd0

[clang-tools-extra] [clang-tidy] Fix failing test after #80864 (PR #81171)

sdkrystian wrote: @erichkeane I'm building the check-clang-extra target locally just to make sure that the test passes... should be done in ~5 mins https://github.com/llvm/llvm-project/pull/81171 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] [clang-tidy] Fix failing test after #80864 (PR #81171)

https://github.com/sdkrystian closed https://github.com/llvm/llvm-project/pull/81171 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Diagnose friend declarations with enum elaborated-type-specifier in all language modes (PR #80171)

https://github.com/sdkrystian updated https://github.com/llvm/llvm-project/pull/80171 >From 921ee093c7366210a8e8587baab6f5d26ae506c3 Mon Sep 17 00:00:00 2001 From: Krystian Stasiowski Date: Wed, 31 Jan 2024 11:09:11 -0500 Subject: [PATCH] [Clang][Sema] Diagnose friend declarations with enum el

[clang] Reapply "[Clang][Sema] Diagnose function/variable templates that shadow their own template parameters (#78274)" (PR #79683)

sdkrystian wrote: Ping @cor3ntin https://github.com/llvm/llvm-project/pull/79683 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Diagnose declarative nested-name-specifiers naming alias templates (PR #80842)

@@ -6295,22 +6297,36 @@ bool Sema::diagnoseQualifiedDeclaration(CXXScopeSpec &SS, DeclContext *DC, << FixItHint::CreateRemoval(TemplateId->TemplateKWLoc); NestedNameSpecifierLoc SpecLoc(SS.getScopeRep(), SS.location_data()); - while (SpecLoc.getPrefix()) { + do {

[clang] [Clang][Sema] Diagnose friend declarations with enum elaborated-type-specifier in all language modes (PR #80171)

sdkrystian wrote: Ping @erichkeane @cor3ntin https://github.com/llvm/llvm-project/pull/80171 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Unify interface for accessing template arguments as written for class/variable template specializations (PR #81642)

https://github.com/sdkrystian created https://github.com/llvm/llvm-project/pull/81642 Our current method of storing the template arguments as written for `(Class/Var)Template(Partial)SpecializationDecl` suffers from a number of flaws: - We use `TypeSourceInfo` to store `TemplateArgumentLocs` fo

[clang] [Clang][Sema] Diagnose friend declarations with enum elaborated-type-specifier in all language modes (PR #80171)

https://github.com/sdkrystian updated https://github.com/llvm/llvm-project/pull/80171 >From 5de10ae0864dacf5f48daf476a4fa20177545d9b Mon Sep 17 00:00:00 2001 From: Krystian Stasiowski Date: Wed, 31 Jan 2024 11:09:11 -0500 Subject: [PATCH] [Clang][Sema] Diagnose friend declarations with enum el

[clang] [Clang][Sema] Diagnose friend declarations with enum elaborated-type-specifier in all language modes (PR #80171)

https://github.com/sdkrystian closed https://github.com/llvm/llvm-project/pull/80171 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Unify interface for accessing template arguments as written for class/variable template specializations (PR #81642)

@@ -1985,44 +1986,45 @@ class ClassTemplateSpecializationDecl SpecializedTemplate = TemplDecl; } - /// Sets the type of this specialization as it was written by - /// the user. This will be a class template specialization type. - void setTypeAsWritten(TypeSourceInfo *

[clang] [Clang] Unify interface for accessing template arguments as written for class/variable template specializations (PR #81642)

@@ -2596,23 +2582,24 @@ class VarTemplateSpecializationDecl : public VarDecl, llvm::PointerUnion SpecializedTemplate; - /// Further info for explicit template specialization/instantiation. - struct ExplicitSpecializationInfo { -/// The type-as-written. -TypeSourc

[clang] [Clang] Unify interface for accessing template arguments as written for class/variable template specializations (PR #81642)

@@ -222,7 +220,7 @@ int binTempl; template float binTempl = 1; -// CHECK: VarTemplatePartialSpecializationDecl 0x{{[^ ]*}} col:7 binTempl 'float' cinit sdkrystian wrote: I removed `cinit` because the output will contain "`explicit_specialization`" bef

[clang] [Clang] Unify interface for accessing template arguments as written for class/variable template specializations (PR #81642)

@@ -279,7 +279,7 @@ namespace dr727 { // dr727: partial // cxx98-11-error@-1 {{variable templates are a C++14 extension}} // cxx98-14-error@-2 {{inline variables are a C++17 extension}} template<> static inline int v2; // #dr727-v2-T -// cxx98-14-error@-1 {{inli

[clang] [Clang] Unify interface for accessing template arguments as written for class/variable template specializations (PR #81642)

@@ -285,30 +285,23 @@ template<> class SpecializationDecl; // CHECK: [[@LINE-1]]:7 | class(Gen,TS)/C++ | SpecializationDecl | c:@S@SpecializationDecl>#I | | Decl,RelSpecialization | rel: 1 // CHECK-NEXT: RelSpecialization | SpecializationDecl | c:@ST>1#T@SpecializationDecl -

[clang] [Clang][Sema] Diagnose class member access expressions naming non-existent members of the current instantiation prior to instantiation in the absence of dependent base classes (PR #84050)

https://github.com/sdkrystian created https://github.com/llvm/llvm-project/pull/84050 Consider the following: ```cpp template struct A { auto f() { return this->x; } }; ``` Although `A` has no dependent base classes and the lookup context for `x` is the current instantiation

[clang] [Clang][Sema] Diagnose class member access expressions naming non-existent members of the current instantiation prior to instantiation in the absence of dependent base classes (PR #84050)

https://github.com/sdkrystian edited https://github.com/llvm/llvm-project/pull/84050 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Diagnose class member access expressions naming non-existent members of the current instantiation prior to instantiation in the absence of dependent base classes (PR #84050)

https://github.com/sdkrystian updated https://github.com/llvm/llvm-project/pull/84050 >From 1495e87d7cbbab6a824d9d1d2bf53d0ef9ec9125 Mon Sep 17 00:00:00 2001 From: Krystian Stasiowski Date: Fri, 1 Mar 2024 08:08:52 -0500 Subject: [PATCH 1/7] [Clang][Sema] Earlier resolution of class member acce

[clang] [Clang][Sema] Diagnose class member access expressions naming non-existent members of the current instantiation prior to instantiation in the absence of dependent base classes (PR #84050)

https://github.com/sdkrystian edited https://github.com/llvm/llvm-project/pull/84050 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Diagnose class member access expressions naming non-existent members of the current instantiation prior to instantiation in the absence of dependent base classes (PR #84050)

https://github.com/sdkrystian updated https://github.com/llvm/llvm-project/pull/84050 >From f5ed116971fd90608b84578fdb61761924d65c98 Mon Sep 17 00:00:00 2001 From: Krystian Stasiowski Date: Fri, 1 Mar 2024 08:08:52 -0500 Subject: [PATCH 1/8] [Clang][Sema] Earlier resolution of class member acce

[clang] [Clang][Sema] Fix crash when using name of UnresolvedUsingValueDecl with template arguments (PR #83842)

sdkrystian wrote: @wlei-llvm Not a known issue... could you provide a repro? I'll look into this in the meantime. https://github.com/llvm/llvm-project/pull/83842 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[clang] Revert "[Clang][Sema] Fix crash when using name of UnresolvedUsingValueDecl with template arguments (#83842)" (PR #84457)

https://github.com/sdkrystian created https://github.com/llvm/llvm-project/pull/84457 This reverts commit a642eb89bdaf10c6b4994fc1187de27b441236ed. >From 02f98e180b94bec0c6abafeaaf8a7513f5116eab Mon Sep 17 00:00:00 2001 From: Krystian Stasiowski Date: Fri, 8 Mar 2024 05:44:48 -0500 Subject: [P

[clang] Revert "[Clang][Sema] Fix crash when using name of UnresolvedUsingValueDecl with template arguments (#83842)" (PR #84457)

https://github.com/sdkrystian edited https://github.com/llvm/llvm-project/pull/84457 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Revert "[Clang][Sema] Fix crash when using name of UnresolvedUsingValueDecl with template arguments (#83842)" (PR #84457)

https://github.com/sdkrystian closed https://github.com/llvm/llvm-project/pull/84457 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Fix crash when using name of UnresolvedUsingValueDecl with template arguments (PR #83842)

sdkrystian wrote: @bgra8 Reverted. Any sort of repro would be appreciated :) https://github.com/llvm/llvm-project/pull/83842 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Comments] Add argument parsing for @throw @throws @exception (PR #84726)

@@ -149,6 +191,76 @@ class TextTokenRetokenizer { addToken(); } + /// Extract a type argument + bool lexDataType(Token &Tok) { +if (isEnd()) + return false; +Position SavedPos = Pos; +consumeWhitespace(); +SmallString<32> NextToken; +SmallStrin

[clang] [Clang][Sema] Fix crash when using name of UnresolvedUsingValueDecl with template arguments (PR #83842)

sdkrystian wrote: @wlei-llvm Thank you! I've reduced the repro to this: ```cpp struct A { }; template void f(A); struct B { void f(); void g() { f(A()); } }; ``` https://github.com/llvm/llvm-project/pull/83842 ___ cfe-commits mailing list

[clang] [Clang][Sema] Fix crash when using name of UnresolvedUsingValueDecl with template arguments (PR #83842)

sdkrystian wrote: So, it seems that this crash occurs because we filter out all non-template functions, which will trigger ADL if the only class member we found was a non-template function. https://github.com/llvm/llvm-project/pull/83842 ___ cfe-comm

[clang] [Clang][Sema] Defer instantiation of exception specification until after partial ordering when determining primary template (PR #82417)

https://github.com/sdkrystian updated https://github.com/llvm/llvm-project/pull/82417 >From 3966e98d9eb6c04faf8a7fd0c4de804964437595 Mon Sep 17 00:00:00 2001 From: Krystian Stasiowski Date: Tue, 20 Feb 2024 14:03:50 -0500 Subject: [PATCH] [Clang][Sema] Defer instantiation of exception specifica

[clang] [Clang][Sema] Defer instantiation of exception specification until after partial ordering when determining primary template (PR #82417)

https://github.com/sdkrystian updated https://github.com/llvm/llvm-project/pull/82417 >From e669903ec50ef0fb1297f150e3a4eb6837db1b53 Mon Sep 17 00:00:00 2001 From: Krystian Stasiowski Date: Tue, 20 Feb 2024 14:03:50 -0500 Subject: [PATCH] [Clang][Sema] Defer instantiation of exception specifica

[clang] [Clang][Sema] Defer instantiation of exception specification until after partial ordering when determining primary template (PR #82417)

sdkrystian wrote: @erichkeane Added release note, relevant standardese quote, and some exposition. https://github.com/llvm/llvm-project/pull/82417 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/c

[clang] [Clang][Sema] Defer instantiation of exception specification until after partial ordering when determining primary template (PR #82417)

https://github.com/sdkrystian updated https://github.com/llvm/llvm-project/pull/82417 >From 06fe8f513866684b70b044524eba9ece9d2701c0 Mon Sep 17 00:00:00 2001 From: Krystian Stasiowski Date: Tue, 20 Feb 2024 14:03:50 -0500 Subject: [PATCH] [Clang][Sema] Defer instantiation of exception specifica

[clang] [Clang][Sema] Defer instantiation of exception specification until after partial ordering when determining primary template (PR #82417)

sdkrystian wrote: Also added a couple more tests since the diagnostics currently depend on whether instantiation occurs. https://github.com/llvm/llvm-project/pull/82417 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[clang] Reapply "[Clang][Sema] Diagnose function/variable templates that shadow their own template parameters (#78274)" (PR #79683)

@@ -885,16 +885,19 @@ bool Sema::DiagnoseUninstantiableTemplate(SourceLocation PointOfInstantiation, /// that the template parameter 'PrevDecl' is being shadowed by a new /// declaration at location Loc. Returns true to indicate that this is /// an error, and false otherwise.

[clang] [Clang][Sema] Defer instantiation of exception specification until after partial ordering when determining primary template (PR #82417)

https://github.com/sdkrystian closed https://github.com/llvm/llvm-project/pull/82417 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Fix crash when MS dependent base class lookup occurs in an incomplete context (PR #83024)

https://github.com/sdkrystian created https://github.com/llvm/llvm-project/pull/83024 When compiling the following with `-fms-compatibility`: ```cpp template struct C; // Test lookup with incomplete lookup context template auto C::f() -> decltype(x) { } ``` An assert fails because `CXXRecordDec

[clang] [Clang][Sema] Fix crash when MS dependent base class lookup occurs in an incomplete context (PR #83024)

https://github.com/sdkrystian updated https://github.com/llvm/llvm-project/pull/83024 >From 1c57410ebef490ae96b0f087426b44ce6ae37f72 Mon Sep 17 00:00:00 2001 From: Krystian Stasiowski Date: Mon, 26 Feb 2024 11:03:06 -0500 Subject: [PATCH] [Clang][Sema] Fix crash when MS dependent base class loo

[clang] [Clang][Sema] Fix crash when MS dependent base class lookup occurs in an incomplete context (PR #83024)

sdkrystian wrote: @erichkeane Added a release note. I don't believe there is an open issue (I did a cursory search), found this "in the wild". https://github.com/llvm/llvm-project/pull/83024 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[clang] [Clang][Sema] Fix crash when MS dependent base class lookup occurs in an incomplete context (PR #83024)

@@ -283,6 +283,7 @@ Bug Fixes to C++ Support (`#78524 `_) - Clang no longer instantiates the exception specification of discarded candidate function templates when determining the primary template of an explicit specializ

[clang] [Clang][Sema] Fix crash when MS dependent base class lookup occurs in an incomplete context (PR #83024)

https://github.com/sdkrystian updated https://github.com/llvm/llvm-project/pull/83024 >From 1c57410ebef490ae96b0f087426b44ce6ae37f72 Mon Sep 17 00:00:00 2001 From: Krystian Stasiowski Date: Mon, 26 Feb 2024 11:03:06 -0500 Subject: [PATCH 1/2] [Clang][Sema] Fix crash when MS dependent base class

[clang] [Clang][Sema] Fix crash when MS dependent base class lookup occurs in an incomplete context (PR #83024)

@@ -283,6 +283,7 @@ Bug Fixes to C++ Support (`#78524 `_) - Clang no longer instantiates the exception specification of discarded candidate function templates when determining the primary template of an explicit specializ

[clang] [Clang][Sema] Fix crash when MS dependent base class lookup occurs in an incomplete context (PR #83024)

https://github.com/sdkrystian updated https://github.com/llvm/llvm-project/pull/83024 >From 1c57410ebef490ae96b0f087426b44ce6ae37f72 Mon Sep 17 00:00:00 2001 From: Krystian Stasiowski Date: Mon, 26 Feb 2024 11:03:06 -0500 Subject: [PATCH 1/3] [Clang][Sema] Fix crash when MS dependent base class

[clang] [Clang][Sema] Fix crash when MS dependent base class lookup occurs in an incomplete context (PR #83024)

https://github.com/sdkrystian updated https://github.com/llvm/llvm-project/pull/83024 >From 1c57410ebef490ae96b0f087426b44ce6ae37f72 Mon Sep 17 00:00:00 2001 From: Krystian Stasiowski Date: Mon, 26 Feb 2024 11:03:06 -0500 Subject: [PATCH 1/3] [Clang][Sema] Fix crash when MS dependent base class

[clang] [Clang][Sema] Fix crash when MS dependent base class lookup occurs in an incomplete context (PR #83024)

sdkrystian wrote: > Side note: In the future can you be more descriptive with follow up commit > messages, isntead of just `[FOLD]`. That doesn't really tell me whether I > need to re-review/give context, particularly since I do much of that triage > in email. Apologies -- I'll keep this in m

[clang] [Clang][Sema] Fix crash when MS dependent base class lookup occurs in an incomplete context (PR #83024)

https://github.com/sdkrystian closed https://github.com/llvm/llvm-project/pull/83024 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Fix crash when using name of UnresolvedUsingValueDecl with template arguments (PR #83842)

https://github.com/sdkrystian created https://github.com/llvm/llvm-project/pull/83842 The following snippet causes a crash ([godbolt link](https://godbolt.org/z/E17sYfYrY)): ```cpp template struct A : T { using T::f; void f(); void g() { f(); // crash here } }; ``` This happens bec

[clang] [Clang][Sema] Fix crash when using name of UnresolvedUsingValueDecl with template arguments (PR #83842)

https://github.com/sdkrystian edited https://github.com/llvm/llvm-project/pull/83842 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Reapply "[Clang][Sema] Diagnose function/variable templates that shadow their own template parameters (#78274)" (PR #79683)

https://github.com/sdkrystian updated https://github.com/llvm/llvm-project/pull/79683 >From 7d05842505dbcabcc54cb365006c794ab9371983 Mon Sep 17 00:00:00 2001 From: Krystian Stasiowski Date: Tue, 16 Jan 2024 08:05:33 -0500 Subject: [PATCH] Reapply "[Clang][Sema] Diagnose function/variable templa

[clang] Reapply "[Clang][Sema] Diagnose function/variable templates that shadow their own template parameters (#78274)" (PR #79683)

https://github.com/sdkrystian closed https://github.com/llvm/llvm-project/pull/79683 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Fix crash when using name of UnresolvedUsingValueDecl with template arguments (PR #83842)

sdkrystian wrote: Actually, I don't think the proposed fix here is quite right. If we _only_ find an `UnresolvedUsingValueDecl`, then we shouldn't assume the name is a template per [[temp.names] p3.3](http://eel.is/c++draft/temp.names#3.3)... will work on a new fix. https://github.com/llvm/ll

[clang] [Clang][Sema] Fix crash when using name of UnresolvedUsingValueDecl with template arguments (PR #83842)

https://github.com/sdkrystian updated https://github.com/llvm/llvm-project/pull/83842 >From aeeb445a9e52a8011a008a5ee3438709f835034c Mon Sep 17 00:00:00 2001 From: Krystian Stasiowski Date: Mon, 4 Mar 2024 08:10:35 -0500 Subject: [PATCH 1/2] [Clang][Sema] Fix crash when using name of Unresolve

[clang] [Clang][Sema] Fix crash when using name of UnresolvedUsingValueDecl with template arguments (PR #83842)

https://github.com/sdkrystian updated https://github.com/llvm/llvm-project/pull/83842 >From aeeb445a9e52a8011a008a5ee3438709f835034c Mon Sep 17 00:00:00 2001 From: Krystian Stasiowski Date: Mon, 4 Mar 2024 08:10:35 -0500 Subject: [PATCH 1/2] [Clang][Sema] Fix crash when using name of Unresolve

[clang] [Clang][Sema] Fix crash when using name of UnresolvedUsingValueDecl with template arguments (PR #83842)

sdkrystian wrote: Updated with new fix https://github.com/llvm/llvm-project/pull/83842 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Fix crash when using name of UnresolvedUsingValueDecl with template arguments (PR #83842)

https://github.com/sdkrystian updated https://github.com/llvm/llvm-project/pull/83842 >From aeeb445a9e52a8011a008a5ee3438709f835034c Mon Sep 17 00:00:00 2001 From: Krystian Stasiowski Date: Mon, 4 Mar 2024 08:10:35 -0500 Subject: [PATCH 1/2] [Clang][Sema] Fix crash when using name of Unresolve

[clang] [Clang][Sema] Fix crash when using name of UnresolvedUsingValueDecl with template arguments (PR #83842)

https://github.com/sdkrystian edited https://github.com/llvm/llvm-project/pull/83842 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Fix crash when using name of UnresolvedUsingValueDecl with template arguments (PR #83842)

https://github.com/sdkrystian updated https://github.com/llvm/llvm-project/pull/83842 >From aeeb445a9e52a8011a008a5ee3438709f835034c Mon Sep 17 00:00:00 2001 From: Krystian Stasiowski Date: Mon, 4 Mar 2024 08:10:35 -0500 Subject: [PATCH 1/3] [Clang][Sema] Fix crash when using name of Unresolve

[clang] [Clang][Sema] Fix crash when using name of UnresolvedUsingValueDecl with template arguments (PR #83842)

https://github.com/sdkrystian updated https://github.com/llvm/llvm-project/pull/83842 >From 4725321631e69c8d8480e0dba85128d177541a89 Mon Sep 17 00:00:00 2001 From: Krystian Stasiowski Date: Mon, 4 Mar 2024 08:10:35 -0500 Subject: [PATCH 1/3] [Clang][Sema] Fix crash when using name of Unresolve

[clang] [Clang][Sema] Fix crash when using name of UnresolvedUsingValueDecl with template arguments (PR #83842)

https://github.com/sdkrystian updated https://github.com/llvm/llvm-project/pull/83842 >From 4725321631e69c8d8480e0dba85128d177541a89 Mon Sep 17 00:00:00 2001 From: Krystian Stasiowski Date: Mon, 4 Mar 2024 08:10:35 -0500 Subject: [PATCH 1/4] [Clang][Sema] Fix crash when using name of Unresolve

[clang] [Clang][Sema] Fix crash when using name of UnresolvedUsingValueDecl with template arguments (PR #83842)

https://github.com/sdkrystian updated https://github.com/llvm/llvm-project/pull/83842 >From 4725321631e69c8d8480e0dba85128d177541a89 Mon Sep 17 00:00:00 2001 From: Krystian Stasiowski Date: Mon, 4 Mar 2024 08:10:35 -0500 Subject: [PATCH 1/5] [Clang][Sema] Fix crash when using name of Unresolve

[clang] [Clang][Sema] Fix crash when using name of UnresolvedUsingValueDecl with template arguments (PR #83842)

https://github.com/sdkrystian closed https://github.com/llvm/llvm-project/pull/83842 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Allow elaborated-type-specifiers that declare member class template explict specializations (PR #78720)

https://github.com/sdkrystian updated https://github.com/llvm/llvm-project/pull/78720 >From e0c682e9fd2c88554c78349bc0b4f32403959e7b Mon Sep 17 00:00:00 2001 From: Krystian Stasiowski Date: Fri, 19 Jan 2024 08:37:21 -0500 Subject: [PATCH] [Clang][Sema] Allow elaborated-type-specifiers that decl

[clang] [Clang][Sema] Allow elaborated-type-specifiers that declare member class template explict specializations (PR #78720)

https://github.com/sdkrystian updated https://github.com/llvm/llvm-project/pull/78720 >From e2cf4ed5f8f6d695ce3eea5b969357d02f42e6ab Mon Sep 17 00:00:00 2001 From: Krystian Stasiowski Date: Fri, 19 Jan 2024 08:37:21 -0500 Subject: [PATCH] [Clang][Sema] Allow elaborated-type-specifiers that decl

[clang] Reapply "[Clang][Sema] Diagnose function/variable templates that shadow their own template parameters (#78274)" (PR #79683)

https://github.com/sdkrystian updated https://github.com/llvm/llvm-project/pull/79683 >From 60e72f20f5bf74a3e62688cfcaa2bc623f0faff1 Mon Sep 17 00:00:00 2001 From: Krystian Stasiowski Date: Tue, 16 Jan 2024 08:05:33 -0500 Subject: [PATCH] Reapply "[Clang][Sema] Diagnose function/variable templa

[clang] Reapply "[Clang][Sema] Diagnose function/variable templates that shadow their own template parameters (#78274)" (PR #79683)

https://github.com/sdkrystian updated https://github.com/llvm/llvm-project/pull/79683 >From a9a6b6ea71ef57eabd136d3b00a9dad0011a86e5 Mon Sep 17 00:00:00 2001 From: Krystian Stasiowski Date: Tue, 16 Jan 2024 08:05:33 -0500 Subject: [PATCH] Reapply "[Clang][Sema] Diagnose function/variable templa

[clang] Reapply "[Clang][Sema] Diagnose function/variable templates that shadow their own template parameters (#78274)" (PR #79683)

sdkrystian wrote: @cor3ntin Addressed review comments... Please approve if it all checks out :) https://github.com/llvm/llvm-project/pull/79683 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

[clang] [Clang][Parse] Diagnose member template declarations with multiple declarators (PR #78243)

sdkrystian wrote: Ping @cor3ntin https://github.com/llvm/llvm-project/pull/78243 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Diagnose use of template keyword after declarative nested-name-specifiers (PR #78595)

@@ -3,21 +3,21 @@ template // expected-note{{previous template}} class X0 { public: typedef int size_type; - + X0(int); ~X0(); - + void f0(const T&, const U&); - + T& operator[](int i) const; - + void f1(size_type) const; void f2(size_type) const;

[clang] [Clang][Sema] Diagnose use of template keyword after declarative nested-name-specifiers (PR #78595)

@@ -4394,8 +4394,14 @@ NestedNameSpecifierLoc TreeTransform::TransformNestedNameSpecifierLoc( SS.Adopt(ETL.getQualifierLoc()); TL = ETL.getNamedTypeLoc(); } -SS.Extend(SemaRef.Context, /*FIXME:*/ SourceLocation(), TL, - Q.ge

<    1   2   3   4   5   6   7   8   9   10   >