[PATCH] D120499: [NVPTX] Fix nvvm.match.sync*.i64 intrinsics return type (i64 -> i32)

krisb updated this revision to Diff 411416. krisb added a comment. Fix a test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120499/new/ https://reviews.llvm.org/D120499 Files: clang/include/clang/Basic/BuiltinsNVPTX.def clang/lib/Headers/__cl

[PATCH] D120499: [NVPTX] Fix nvvm.match.sync*.i64 intrinsics return type (i64 -> i32)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG57aaab3b17f0: [NVPTX] Fix nvvm.match.sync*.i64 intrinsics return type (i64 -> i32) (authored by krisb). Changed prior to commit: https://reviews.l

[PATCH] D120499: [NVPTX] Fix nvvm.match.sync*.i64 intrinsics return type (i64 -> i32)

krisb added a comment. @tra thank you for looking at this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120499/new/ https://reviews.llvm.org/D120499 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D114382: [clang] Fix wrong -Wunused-local-typedef warning within a template function

krisb added a comment. Herald added a project: All. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114382/new/ https://reviews.llvm.org/D114382 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D114382: [clang] Fix wrong -Wunused-local-typedef warning within a template function

krisb added inline comments. Comment at: clang/test/SemaCXX/warn-unused-local-typedef.cpp:246 + typedef int Int; // no-diag + typedef char Char; // expected-warning {{unused typedef 'Char'}} + Int m; Quuxplusone wrote: > I haven't tried to understa

[PATCH] D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations)

krisb added a comment. Thank you! It looks more consistent now. Comment at: clang/lib/Parse/ParseDecl.cpp:3080 +// For instance this marked as unavailable: +//class __attribute((unavailable)) UnavailableClass;` +auto RemoveAccessCheckingDiagnostics = [&TemplateI

[PATCH] D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations)

krisb added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:3080 +// For instance this marked as unavailable: +//class __attribute((unavailable)) UnavailableClass;` +auto RemoveAccessCheckingDiagnostics = [&TemplateInfo, this]() { aorlo

[PATCH] D113743: [RFC][clang][DebugInfo] Allow function-local statics and types to be scoped within a lexical block

krisb added a comment. In D113743#3173981 , @JDevlieghere wrote: > Hey Kristina, this broke TestSetData.py on GreenDragon: > https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/39089/ > > Since the bot has been red for several hours I went ahead a

[PATCH] D113743: [RFC][clang][DebugInfo] Allow function-local statics and types to be scoped within a lexical block

krisb added a comment. In D113743#3175301 , @dblaikie wrote: > Not super surprising that lldb might not be able to deal with DWARF in this > shape - is LLDB support important to you/something you plan to work on for > this DWARF? Otherwise we might need

[PATCH] D114382: [clang] Fix wrong -Wunused-local-typedef warning within a template function

krisb added a comment. @rtrieu, thank you for looking at this! Do you have any comments about the rest of the patch? Do you think it makes sense? Comment at: clang/test/Modules/odr_hash.cpp:4288 S s; +// expected-error@first.h:* {{'ParameterTest::S::Foo' has different defini

[PATCH] D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations)

krisb added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:3001 DS.getStorageClassSpec() == clang::DeclSpec::SCS_typedef && -!DS.hasTypeSpecifier() && GetLookAheadToken(1).is(tok::less)) +!DS.hasTypeSpecifier() && NextToken().is(tok::less))

[PATCH] D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations)

krisb added a comment. Do we still need the following tests: - clang/test/CXX/temp/temp.spec/temp.explicit/p11.cpp - clang/test/CXX/temp/temp.spec/temp.explicit/p12.cpp ? Comment at: clang/test/CXX/temp/temp.spec/func.spec.cpp:105 +template void func10(A::B, int x) {} +templ

[PATCH] D109703: [DebugInfo] Fix scope for local static variables

krisb created this revision. krisb added reviewers: dblaikie, probinson. Herald added a subscriber: hiraditya. krisb requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This fixes https://bugs.llvm.org/show_bug.cgi?id=44695 (a

[PATCH] D109703: [DebugInfo] Fix scope for local static variables

krisb added a comment. In D109703#2998155 , @ellis wrote: > I've added this to the added test case. > > !18 = !DIImportedEntity(tag: DW_TAG_imported_declaration, scope: !4, > entity: !19, line: 122) > !19 = !DIGlobalVariable(name: "imported_static_va

<    1   2