[clang] [analyzer] Explicitly register NoStoreFuncVisitor from alpha.unix.cst… (PR #108373)

2024-09-12 Thread Kristóf Umann via cfe-commits
https://github.com/Szelethus created https://github.com/llvm/llvm-project/pull/108373 …ring.UninitRead This is a drastic simplification of #106982. If you read that patch, this is the same thing with all BugReporterVisitors.cpp and SValBuilder.cpp changes removed! (since all replies came rega

[clang] [analyzer] Implement binary operations on LazyCompoundVals (PR #106982)

2024-09-12 Thread Kristóf Umann via cfe-commits
https://github.com/Szelethus closed https://github.com/llvm/llvm-project/pull/106982 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Implement binary operations on LazyCompoundVals (PR #106982)

2024-09-12 Thread Kristóf Umann via cfe-commits
Szelethus wrote: Superceding this patch to 108373. https://github.com/llvm/llvm-project/pull/106982 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Explicitly register NoStoreFuncVisitor from alpha.unix.cst… (PR #108373)

2024-09-16 Thread Kristóf Umann via cfe-commits
@@ -263,6 +263,23 @@ bool SVal::isZeroConstant() const { // Pretty-Printing. //===--===// +StringRef SVal::getKindStr() const { + switch (getKind()) { +#define BASIC_SVAL(Id, Parent)

[clang] [analyzer] Explicitly register NoStoreFuncVisitor from alpha.unix.cst… (PR #108373)

2024-09-16 Thread Kristóf Umann via cfe-commits
https://github.com/Szelethus updated https://github.com/llvm/llvm-project/pull/108373 From cc823218d5cbb0b8f183bbadc9a32380c8e328a7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Krist=C3=B3f=20Umann?= Date: Tue, 16 Jul 2024 15:06:06 +0200 Subject: [PATCH 1/2] [analyzer] Explicitly register NoStoreFu

[clang] [analyzer] [MallocChecker] suspect all release functions as candidate for suppression (PR #104599)

2024-09-16 Thread Kristóf Umann via cfe-commits
https://github.com/Szelethus approved this pull request. LGTM! Do you have commit access? https://github.com/llvm/llvm-project/pull/104599 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

[clang] [analyzer] [MallocChecker] suspect all release functions as candidate for suppression (PR #104599)

2024-09-16 Thread Kristóf Umann via cfe-commits
Szelethus wrote: You already have a good number of quality patches under your belt. I suggest that you ask for a commit access, I have no doubt it'll be granted: https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access https://github.com/llvm/llvm-project/pull/104599 _

[clang] [analyzer] Untangle subcheckers of CStringChecker (PR #113312)

2024-10-22 Thread Kristóf Umann via cfe-commits
https://github.com/Szelethus created https://github.com/llvm/llvm-project/pull/113312 It turns out, that some checks for cstring functions happened as a side effect of other checks. For example, whether the arguments to memcpy were uninitialized happened during buffer overflow checking. The w

[clang] [analyzer] Suppress out of bounds reports after weak loop assumptions (PR #109804)

2024-10-14 Thread Kristóf Umann via cfe-commits
Szelethus wrote: Damn, look at this project, thriving as strong as ever 18 years after its conception! Great discussions! Let me throw in my two cents. Overall, I think we should go with this patch. I agree with a great many things previously said, this one summarizes the argument for the vis

[clang] [analyzer] Explicitly register NoStoreFuncVisitor from alpha.unix.cst… (PR #108373)

2024-09-19 Thread Kristóf Umann via cfe-commits
https://github.com/Szelethus closed https://github.com/llvm/llvm-project/pull/108373 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Explicitly register NoStoreFuncVisitor from alpha.unix.cst… (PR #108373)

2024-09-19 Thread Kristóf Umann via cfe-commits
https://github.com/Szelethus edited https://github.com/llvm/llvm-project/pull/108373 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Untangle subcheckers of CStringChecker (PR #113312)

2024-11-18 Thread Kristóf Umann via cfe-commits
Szelethus wrote: @steakhal, and especially @isuckatcs, I greatly appreciate the reviews! I happen to have gotten some very ugrent task on my plate that drew away my attention from this project. I will fix this PR up as soon as I'm done! https://github.com/llvm/llvm-project/pull/113312

[clang-tools-extra] [clang-tidy] Add new check bugprone-tagged-union-member-count (PR #89925)

2024-09-17 Thread Kristóf Umann via cfe-commits
Szelethus wrote: My say doesn't quite have the same weight here are many others, but I see no problems with this patch after so many rounds of reviews -- would it be okay to merge? https://github.com/llvm/llvm-project/pull/89925 ___ cfe-commits maili

[clang] [analyzer][Z3] Restore the original timeout of 15s (PR #118291)

2024-12-02 Thread Kristóf Umann via cfe-commits
Szelethus wrote: I also have some just-in-case measurements cooking to confirm that we don't observe any nondeterminism with these values. Previous measurements of mine were made with _all_ configs set to 0. Our downstream release goes off with the patch totally reverted. https://github.com/l

[clang] [analyzer][Z3] Restore the original timeout of 15s (PR #118291)

2024-12-02 Thread Kristóf Umann via cfe-commits
https://github.com/Szelethus created https://github.com/llvm/llvm-project/pull/118291 Discussion here: https://discourse.llvm.org/t/analyzer-rfc-taming-z3-query-times/79520/15?u=szelethus The original patch, #97298 introduced new timeouts backed by thorough testing and measurements to keep the

[clang] [analyzer][Z3] Restore the original timeout of 15s (PR #118291)

2024-12-03 Thread Kristóf Umann via cfe-commits
Szelethus wrote: > I also have some just-in-case measurements cooking to confirm that we don't > observe any nondeterminism with these values. Previous measurements of mine > were made with _all_ configs set to 0. Our downstream release goes off with > the patch totally reverted. Sanity check

[clang] [NFC][analyzer][docs] Document MallocChecker's ownership attributes (PR #121759)

2025-01-06 Thread Kristóf Umann via cfe-commits
https://github.com/Szelethus created https://github.com/llvm/llvm-project/pull/121759 Exactly what it says on the tin! These were written ages ago (2010s), but are still functional, only the docs are missing. ![image](https://github.com/user-attachments/assets/e119d995-27c2-43b7-bbd5-39275129a

[clang] [NFC][analyzer][docs] Document MallocChecker's ownership attributes (PR #121759)

2025-01-06 Thread Kristóf Umann via cfe-commits
@@ -1389,6 +1389,68 @@ Query for this attribute with ``__has_attribute(overloadable)``. }]; } +def OwnershipDocs : Documentation { + let Heading = "ownership_holds, ownership_returns, ownership_takes (Clang " +"Static Analyzer)"; + let Category = DocCatFun

[clang] [NFC][analyzer][docs] Document MallocChecker's ownership attributes (PR #121759)

2025-01-06 Thread Kristóf Umann via cfe-commits
https://github.com/Szelethus updated https://github.com/llvm/llvm-project/pull/121759 From 24b15119f476bf8c981618132b05357a87d98476 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Krist=C3=B3f=20Umann?= Date: Mon, 6 Jan 2025 13:14:37 +0100 Subject: [PATCH 1/2] [analyzer][docs] Document MallocChecker's

[clang] [NFC][analyzer][docs] Document MallocChecker's ownership attributes (PR #121759)

2025-01-06 Thread Kristóf Umann via cfe-commits
https://github.com/Szelethus updated https://github.com/llvm/llvm-project/pull/121759 From 24b15119f476bf8c981618132b05357a87d98476 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Krist=C3=B3f=20Umann?= Date: Mon, 6 Jan 2025 13:14:37 +0100 Subject: [PATCH 1/3] [analyzer][docs] Document MallocChecker's

[clang] [NFC][analyzer][docs] Document MallocChecker's ownership attributes (PR #121759)

2025-01-06 Thread Kristóf Umann via cfe-commits
https://github.com/Szelethus updated https://github.com/llvm/llvm-project/pull/121759 From 24b15119f476bf8c981618132b05357a87d98476 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Krist=C3=B3f=20Umann?= Date: Mon, 6 Jan 2025 13:14:37 +0100 Subject: [PATCH 1/4] [analyzer][docs] Document MallocChecker's

[clang] [NFC][analyzer][docs] Document MallocChecker's ownership attributes (PR #121759)

2025-01-06 Thread Kristóf Umann via cfe-commits
https://github.com/Szelethus edited https://github.com/llvm/llvm-project/pull/121759 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][analyzer][docs] Document MallocChecker's ownership attributes (PR #121759)

2025-01-06 Thread Kristóf Umann via cfe-commits
@@ -1389,6 +1389,68 @@ Query for this attribute with ``__has_attribute(overloadable)``. }]; } +def OwnershipDocs : Documentation { + let Heading = "ownership_holds, ownership_returns, ownership_takes (Clang " +"Static Analyzer)"; + let Category = DocCatFun

[clang] [NFC][analyzer][docs] Crosslink MallocChecker's ownership attributes (PR #121939)

2025-01-07 Thread Kristóf Umann via cfe-commits
https://github.com/Szelethus created https://github.com/llvm/llvm-project/pull/121939 Forgot to mention these in the checker docs. From 80a8cb8425c4c588659e1153fe0834d6514070d0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Krist=C3=B3f=20Umann?= Date: Tue, 7 Jan 2025 13:30:28 +0100 Subject: [PATCH]

[clang] [NFC][analyzer][docs] Crosslink MallocChecker's ownership attributes (PR #121939)

2025-01-07 Thread Kristóf Umann via cfe-commits
https://github.com/Szelethus closed https://github.com/llvm/llvm-project/pull/121939 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][analyzer][docs] Document MallocChecker's ownership attributes (PR #121759)

2025-01-07 Thread Kristóf Umann via cfe-commits
https://github.com/Szelethus updated https://github.com/llvm/llvm-project/pull/121759 From 24b15119f476bf8c981618132b05357a87d98476 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Krist=C3=B3f=20Umann?= Date: Mon, 6 Jan 2025 13:14:37 +0100 Subject: [PATCH 1/5] [analyzer][docs] Document MallocChecker's

[clang] [NFC][analyzer][docs] Document MallocChecker's ownership attributes (PR #121759)

2025-01-07 Thread Kristóf Umann via cfe-commits
https://github.com/Szelethus closed https://github.com/llvm/llvm-project/pull/121759 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer][Z3] Restore the original timeout of 15s (PR #118291)

2024-12-13 Thread Kristóf Umann via cfe-commits
https://github.com/Szelethus closed https://github.com/llvm/llvm-project/pull/118291 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer][Z3] Restore the original timeout of 15s (PR #118291)

2024-12-13 Thread Kristóf Umann via cfe-commits
Szelethus wrote: Oh, I'm so sorry I left this as-is, thank you so much for picking up the slack! Yes, everything looks great! https://github.com/llvm/llvm-project/pull/118291 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[clang] [NFC][analyzer][docs] Improve Annotations.rst (PR #122749)

2025-01-27 Thread Kristóf Umann via cfe-commits
https://github.com/Szelethus approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/122749 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][analyzer][docs] Migrate 'annotations.html' to RST (PR #122246)

2025-01-13 Thread Kristóf Umann via cfe-commits
https://github.com/Szelethus approved this pull request. Shouldn't we leave a stub in the old HTML page that the docs were moved? Or we haven't done that in the past either? I understand (and strongly agree with) you not making any meaningful changes to the docs page you moved. With that said,

[clang] [NFC][analyzer][docs] Restore/remove orphaned images (PR #122481)

2025-01-13 Thread Kristóf Umann via cfe-commits
https://github.com/Szelethus approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/122481 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][analyzer][docs] Migrate 'annotations.html' to RST (PR #122246)

2025-01-13 Thread Kristóf Umann via cfe-commits
Szelethus wrote: > Where should we _primarily_ document the `ownership_.*` attributes: here or > in the global documentation of attributes? I think we should have a section, and a single sentence pointing to the main attribution docs. https://github.com/llvm/llvm-project/pull/122246 _

<    1   2