[PATCH] D58573: [analyzer] Move UninitializedObjectChecker out of alpha

This revision was automatically updated to reflect the committed changes. Closed by commit rC358797: [analyzer] Move UninitializedObjectChecker out of alpha (authored by Szelethus, committed by ). Changed prior to commit: https://reviews.llvm.org/D58573?vs=194667&id=195937#toc Repository: rC

[PATCH] D59465: [analyzer] Add example plugin for checker option handling

Szelethus updated this revision to Diff 196079. Szelethus added a comment. - Move the existing plugin to `test/` - Implement the new plugin in there also CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59465/new/ https://reviews.llvm.org/D59465 Files: examples/CMakeLists.txt examples

[PATCH] D59464: [analyzer] Add an example plugin for checker dependency handling

Szelethus updated this revision to Diff 196083. Szelethus added a comment. - Move the existing plugin to `test/` - Implement the new plugin in there also CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59464/new/ https://reviews.llvm.org/D59464 Files: examples/CMakeLists.txt examples

[PATCH] D59465: [analyzer] Add example plugin for checker option handling

Szelethus updated this revision to Diff 196080. Szelethus added a comment. Accidentally uploaded the wrong diff. Rebase on top of D59464 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59465/new/ https://reviews.llvm.org/D59465 Files: examples/Static

[PATCH] D58573: [analyzer] Move UninitializedObjectChecker out of alpha

Szelethus added a comment. In D58573#1477581 , @gribozavr wrote: > Thanks for the checker! We are hitting a crash on `_Atomic` fields, could > you take a look? https://bugs.llvm.org/show_bug.cgi?id=41590 Thanks! Yup, consider it fixed (in a little wh

[PATCH] D61051: [analyzer] Treat functions without runtime branches as "small".

Szelethus added a comment. Nice! I have no objections (other than the nits) to this! Ill take a second look later, because I really need to play around with `CFG` a bit to give a definitive LGTM. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/ExprEngine.h:

[PATCH] D61106: [analyzer][UninitializedObjectChecker] PR41590: Regard _Atomic types as primitive

Szelethus created this revision. Szelethus added reviewers: NoQ, dcoughlin, baloghadamsoftware, Charusso, rnkovacs, xazax.hun, gribozavr. Szelethus added a project: clang. Herald added subscribers: cfe-commits, gamesh411, dkrupp, donat.nagy, jfb, mikhail.ramalho, a.sidorin, szepet, whisperity. h

[PATCH] D60925: [analyzer] Don't display implementation checkers under -analyzer-checker-help, but do under the new flag -analyzer-checker-help-hidden

Szelethus added a comment. I plan to do the same for non-checker and checker options too. I'll leave this up for just a little while to give people time to object. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60925/new/ https://reviews.llvm.org/D60925 __

[PATCH] D61106: [analyzer][UninitializedObjectChecker] PR41590: Regard _Atomic types as primitive

This revision was automatically updated to reflect the committed changes. Closed by commit rC359230: [analyzer][UninitializedObjectChecker] PR41590: Regard _Atomic types as… (authored by Szelethus, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61106

[PATCH] D61106: [analyzer][UninitializedObjectChecker] PR41590: Regard _Atomic types as primitive

Szelethus added a comment. In D61106#1479336 , @jfb wrote: > Have you checked what the C and C++ standards say about `_Atomic` / > `std::atomic` initialization, and how they should actually be initialized by > developers? No, I have not, I'll admit. Di

[PATCH] D61106: [analyzer][UninitializedObjectChecker] PR41590: Regard _Atomic types as primitive

Szelethus added a comment. Upon further investigation, this still seems to be okay. This is not a bug-finding checker, but rather a tool to enforce the idiom of every non-trivial object should be fully initialized after construction. From what I've seen, `ATOMIC_VAR_INIT` should be used here, b

[PATCH] D57860: [analyzer] Validate checker option names and values

Szelethus added a comment. Ping^3 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57860/new/ https://reviews.llvm.org/D57860 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D57858: [analyzer] Add a new frontend flag to display all checker options

Szelethus added a comment. Ping^3 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57858/new/ https://reviews.llvm.org/D57858 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D58573: [analyzer] Move UninitializedObjectChecker out of alpha

Szelethus added a comment. I suspect the problem is similar. I'll take a look at this either today or tomorrow, thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58573/new/ https://reviews.llvm.org/D58573 ___ cf

[PATCH] D61246: [analyzer][UninitializedObjectChecker] PR41611: Regard vector types as primitive

Szelethus created this revision. Szelethus added reviewers: NoQ, dcoughlin, xazax.hun, rnkovacs, baloghadamsoftware, Charusso, alexfh, gribozavr. Szelethus added a project: clang. Herald added subscribers: cfe-commits, gamesh411, dkrupp, donat.nagy, jfb, mikhail.ramalho, a.sidorin, szepet, whispe

[PATCH] D59465: [analyzer] Add example plugin for checker option handling

Szelethus planned changes to this revision. Szelethus added a comment. In D59465#1482302 , @whisperity wrote: > @Szelethus I know the dependent patch D59464 > will move `examples/analyzer-plugin` to > `test/Analysis/plug

[PATCH] D61246: [analyzer][UninitializedObjectChecker] PR41611: Regard vector types as primitive

Szelethus updated this revision to Diff 197209. Szelethus added a comment. Add `TODO:`s about missing warnings. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61246/new/ https://reviews.llvm.org/D61246 Files: lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedObject.h test

[PATCH] D59465: [analyzer] Add example plugin for checker option handling

Szelethus updated this revision to Diff 197210. Szelethus added a comment. Uploaded the correct diff. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59465/new/ https://reviews.llvm.org/D59465 Files: test/Analysis/checker-plugins.c test/Analysis/plugins/CMakeLists.txt test/Analysis

[PATCH] D59279: [Analyzer] Checker for non-determinism caused by iteration of unordered container of pointers

Szelethus added a comment. I think you can commit this. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59279/new/ https://reviews.llvm.org/D59279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[PATCH] D59464: [analyzer] Add an example plugin for checker dependency handling

Szelethus added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59464/new/ https://reviews.llvm.org/D59464 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D54757: [clang-tidy] new check: bugprone-branch-clone

Szelethus reopened this revision. Szelethus added a comment. This revision is now accepted and ready to land. Herald added a project: clang. Reverted in rCTE348344 . Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D5

[PATCH] D54757: [clang-tidy] new check: bugprone-branch-clone

Szelethus commandeered this revision. Szelethus added a reviewer: donat.nagy. Szelethus added a comment. I'll take a look at this. In D54757#1319831 , @JonasToth wrote: > I had to revert this patch because it broke (at least one) buildbot with an > asser

[PATCH] D61246: [analyzer][UninitializedObjectChecker] PR41611: Regard vector types as primitive

This revision was automatically updated to reflect the committed changes. Closed by commit rL359539: [analyzer][UninitializedObjectChecker] PR41611: Regard vector types as primitive (authored by Szelethus, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Chan

[PATCH] D61136: [Analyzer] IteratorChecker - Ensure end()>=begin() and refactor begin and end symbol creation

Szelethus requested changes to this revision. Szelethus added inline comments. This revision now requires changes to proceed. Comment at: lib/StaticAnalyzer/Checkers/IteratorChecker.cpp:1929-1930 + + auto &SymMgr = State->getSymbolManager(); + auto Sym = SymMgr.conjureSymbol(E,

[PATCH] D61051: [analyzer] Treat functions without runtime branches as "small".

Szelethus added a comment. I mean, better late then never, but LGTM :^) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61051/new/ https://reviews.llvm.org/D61051 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D57858: [analyzer] Add a new frontend flag to display all checker options

Szelethus requested review of this revision. Szelethus added a comment. Similarly to D60925 , I plan to make a patch that will hide most the implementation options. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57858/new/ https://reviews.llvm.org/D57858

[PATCH] D60925: [analyzer] Don't display implementation checkers under -analyzer-checker-help, but do under the new flag -analyzer-checker-help-hidden

Szelethus updated this revision to Diff 197609. Szelethus edited the summary of this revision. Szelethus added a comment. Hide `security.insecureAPI.SecuritySyntaxChecker` by default. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60925/new/ https://reviews.llvm.org/D60925 Files: incl

[PATCH] D60925: [analyzer] Don't display implementation checkers under -analyzer-checker-help, but do under the new flag -analyzer-checker-help-hidden

This revision was automatically updated to reflect the committed changes. Closed by commit rL359720: [analyzer] Don't display implementation checkers under -analyzer-checker-help… (authored by Szelethus, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Change

[PATCH] D54757: [clang-tidy] new check: bugprone-branch-clone

Szelethus added a comment. I actually managed to reproduce the crash. extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp:200: clang::DiagnosticBuilder clang::tidy::ClangTidyContext::diag(llvm::StringRef, clang::SourceLocation, llvm::StringRef, DiagnosticIDs::Level): Assertion `Loc.isValid()' f

[PATCH] D60925: [analyzer] Don't display implementation checkers under -analyzer-checker-help, but do under the new flag -analyzer-checker-help-hidden

Szelethus added a comment. In D60925#1489034 , @o.gyorgy wrote: > Great, at least the users will not enable the debug checkers by accident! > We will check on the CodeChecker side if any configuration needs to be > updated. > > LGTM I committed after c

[PATCH] D54757: [clang-tidy] new check: bugprone-branch-clone

Szelethus added a comment. $ cat orig.cpp #define a(b) switch (b) { #define c(b) \ b: int d; e() { a(d) c(2); c(3) $ debugBuild/bin/clang-tidy orig.cpp -checks=bugprone-branch-clone -- clang-tidy: ../extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp:200: clang::DiagnosticBuild

[PATCH] D54757: [clang-tidy] new check: bugprone-branch-clone

Szelethus updated this revision to Diff 198025. Szelethus added a comment. FIx the above mentioned crash. diff --git a/clang-tidy/bugprone/BranchCloneCheck.cpp b/clang-tidy/bugprone/BranchCloneCheck.cpp index f371231..a898311 100644 --- a/clang-tidy/bugprone/BranchCloneCheck.cpp +++ b/cl

[PATCH] D54757: [clang-tidy] new check: bugprone-branch-clone

Szelethus requested review of this revision. Szelethus marked an inline comment as done. Szelethus added a comment. I changed the testfiles quite a bit, surprisingly, I'd appreciate another accept on this one please :) Seems to me that the changes describe the actual reports far better... ===

[PATCH] D61569: [analyzer][UninitializedObjectChecker] PR41741: Regard all scalar types as primitive.

Szelethus created this revision. Szelethus added reviewers: NoQ, dcoughlin, baloghadamsoftware, gribozavr, xazax.hun, rnkovacs, Charusso, a_sidorin. Szelethus added a project: clang. Herald added subscribers: cfe-commits, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet, whisperi

[PATCH] D61569: [analyzer][UninitializedObjectChecker] PR41741: Regard all scalar types as primitive.

Szelethus updated this revision to Diff 198180. Szelethus added a comment. Add a `TODO:`, since we actually don't emit a warning when we should -- I'm afraid that this won't be an easy fix though, similarly to ``__vector_size__``: D61246#inline-543357

[PATCH] D61570: [analyzer] PR41753: Include complex integer types in NonLoc::isCompoundType

Szelethus created this revision. Szelethus added reviewers: NoQ, dcoughlin, baloghadamsoftware, xazax.hun, rnkovacs, Charusso, a_sidorin. Szelethus added a project: clang. Herald added subscribers: cfe-commits, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet, whisperity. https:

[PATCH] D61569: [analyzer][UninitializedObjectChecker] PR41741: Regard all scalar types as primitive.

This revision was automatically updated to reflect the committed changes. Closed by commit rC359998: [analyzer][UninitializedObjectChecker] PR41741: Regard all scalar types as… (authored by Szelethus, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61

[PATCH] D59464: [analyzer] Add an example plugin for checker dependency handling

Szelethus added a comment. Ping^2 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59464/new/ https://reviews.llvm.org/D59464 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D57858: [analyzer] Add a new frontend flag to display all checker options

Szelethus added a comment. Ping^4 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57858/new/ https://reviews.llvm.org/D57858 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D57860: [analyzer] Validate checker option names and values

Szelethus added a comment. Ping^4 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57860/new/ https://reviews.llvm.org/D57860 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D59465: [analyzer] Add a test plugin for checker option handling

Szelethus added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59465/new/ https://reviews.llvm.org/D59465 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D51866: [analyzer][UninitializedObjectChecker] New flag to ignore guarded uninitialized fields

This revision was automatically updated to reflect the committed changes. Closed by commit rL352959: [analyzer][UninitializedObjectChecker] New flag to ignore guarded uninitialized… (authored by Szelethus, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Chan

[PATCH] D54429: [analyzer] Creating standard Sphinx documentation

Szelethus added a comment. I'll do the honors. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54429/new/ https://reviews.llvm.org/D54429 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

[PATCH] D54429: [analyzer] Creating standard Sphinx documentation

Szelethus added a comment. I'm getting a single buildbot failure, but I'm a little unsure how to fix it. Could you help? http://lab.llvm.org:8011/builders/clang-sphinx-docs/builds/36985 24.610 [1/1/1] Generating html Sphinx documentation for clang into "/home/buildbot/llvm-build-dir/clang-sp

[PATCH] D54429: [analyzer] Creating standard Sphinx documentation

Szelethus added inline comments. Comment at: docs/analyzer/checkers.rst:1946 +Checkers used for debugging the analyzer. +:doc:`DebugChecks` page contains a detailed description. + NoQ wrote: > The error is on this line. It might be that this link should mention t

[PATCH] D35068: [analyzer] Detect usages of unsafe I/O functions

Szelethus added a comment. Could you rebase please? Many things have changed since you last update. After that I'll happily commit on your behalf if you don't have a commit access just yet. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D35068/new/ https://reviews.llvm.org/D35068 ___

[PATCH] D57850: [analyzer] Emit an error rather than assert on invalid checker option input

Szelethus created this revision. Szelethus added reviewers: george.karpenkov, NoQ, xazax.hun, rnkovacs, baloghadamsoftware. Herald added subscribers: cfe-commits, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet, whisperity. Herald added a reviewer: teemperor. Herald added a proj

[PATCH] D57855: [analyzer] Reimplement checker options

Szelethus created this revision. Szelethus added reviewers: NoQ, george.karpenkov, xazax.hun, rnkovacs, baloghadamsoftware. Herald added subscribers: cfe-commits, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, mgrang, szepet, whisperity. Herald added a project: clang. Here we go guys

[PATCH] D57858: [analyzer] Add a new frontend flag to display all checker options

Szelethus created this revision. Szelethus added reviewers: NoQ, george.karpenkov, xazax.hun, rnkovacs, baloghadamsoftware. Herald added subscribers: cfe-commits, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet, kristof.beyls, whisperity, javed.absar. Herald added a project: cla

[PATCH] D57860: [analyzer] Validate checker option names and values

Szelethus created this revision. Szelethus added reviewers: NoQ, george.karpenkov, xazax.hun, rnkovacs, baloghadamsoftware. Herald added subscribers: cfe-commits, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet, whisperity. Herald added a project: clang. Validate whether the op

[PATCH] D57893: [analyzer] Fix function macro crash

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. Cheers! Let's wait for a couple days for feedback, and I'll commit on your behalf after that. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57893/new/ h

[PATCH] D57891: [analyzer] Fix infinite recursion in printing macros

Szelethus added a comment. Is there a chance of obtaining a testcase for this? I would very strongly prefer one. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57891/new/ https://reviews.llvm.org/D57891 ___ cfe-commi

[PATCH] D57892: [analyzer] Fix macro printer crash when macro comes from another translation unit

Szelethus accepted this revision. Szelethus added a reviewer: martong. Szelethus added a comment. This revision is now accepted and ready to land. Yup, cheers! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57892/new/ https://reviews.llvm.org/D57892 ___

[PATCH] D57893: [analyzer] Fix function macro crash

Szelethus requested changes to this revision. Szelethus added a comment. This revision now requires changes to proceed. Actually, reproducing this with a testcase would be much preferred here too. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57893/new/ https://r

[PATCH] D57922: [analyzer] Insert checker options into AnalyzerOption::ConfigTable

Szelethus created this revision. Szelethus added reviewers: NoQ, george.karpenkov, xazax.hun, rnkovacs, baloghadamsoftware. Herald added subscribers: cfe-commits, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet, whisperity. Herald added a project: clang. The more entries we hav

[PATCH] D57922: [analyzer] Insert checker options into AnalyzerOption::ConfigTable

Szelethus marked an inline comment as done. Szelethus added inline comments. Comment at: lib/StaticAnalyzer/Core/AnalyzerOptions.cpp:183 SearchInParents) - .getAsInteger(10, Ret); + .getAsInteger(0

[PATCH] D57855: [analyzer] Reimplement checker options

Szelethus updated this revision to Diff 185861. Szelethus edited the summary of this revision. Szelethus added a comment. Moved all `AnalyzerOptions` related changes to a separate revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57855/new/ https://reviews.llvm.org/D57855 Files:

[PATCH] D57855: [analyzer] Reimplement checker options

Szelethus added a reviewer: aaron.ballman. Szelethus added a comment. Aaron, you recently changed these file too, if you have the time, I'll happily listen to your feedback :) Also, I was thinking that maybe we could just `std::move` `CheckerRegisrty::Checkers` and `CheckerRegisrty::Packages` t

[PATCH] D57579: [analyzer][WIP] Enable subcheckers to possess checker options

Szelethus added a comment. Herald added a subscriber: cfe-commits. Ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57579/new/ https://reviews.llvm.org/D57579 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D57893: [analyzer] Fix function macro crash

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. Awesome, thanks! Will commit around next Friday. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57893/new/ https://reviews.llvm.org/D57893

[PATCH] D35068: [analyzer] Detect usages of unsafe I/O functions

Szelethus added a comment. Hmmm, `DescFile` was removed months ago from `Checkers.td`, are you sure you uploaded the correct diff? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D35068/new/ https://reviews.llvm.org/D35068 ___ cfe-commits mai

[PATCH] D35068: [analyzer] Detect usages of unsafe I/O functions

Szelethus accepted this revision. Szelethus added a comment. This looks great, thanks! I'll commit sometime tomorrow. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D35068/new/ https://reviews.llvm.org/D35068 ___ cfe-commits mailing list cfe-

[PATCH] D54978: Move the SMT API to LLVM

Szelethus added a comment. In D54978#1391785 , @thakis wrote: > In D54978#1391436 , @mikhail.ramalho > wrote: > > > Hi everyone, I just saw your messages and reverted the commits. > > > > Sorry for the inconvenienc

[PATCH] D54978: Move the SMT API to LLVM

Szelethus added a comment. Shouldn't that be off by default? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54978/new/ https://reviews.llvm.org/D54978 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[PATCH] D57855: [analyzer] Reimplement checker options

Szelethus marked an inline comment as done. Szelethus added a comment. In D57855#1392560 , @xazax.hun wrote: > We have `examples/analyzer-plugin`. I would prefer to add an example option > to the example plugin so people do see how to do this when they ar

[PATCH] D35068: [analyzer] Detect usages of unsafe I/O functions

This revision was automatically updated to reflect the committed changes. Closed by commit rL353698: [analyzer] New checker for detecting usages of unsafe I/O functions (authored by Szelethus, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D58065: [analyzer] Document the frontend library

Szelethus created this revision. Szelethus added reviewers: NoQ, george.karpenkov, xazax.hun, dkrupp, rnkovacs, a.sidorin, aaron.ballman. Herald added subscribers: cfe-commits, gamesh411, donat.nagy, mikhail.ramalho, szepet, baloghadamsoftware, whisperity. Herald added a project: clang. Since I'

[PATCH] D57850: [analyzer] Emit an error rather than assert on invalid checker option input

Szelethus marked 2 inline comments as done. Szelethus added inline comments. Comment at: include/clang/Basic/DiagnosticDriverKinds.td:304-305 def err_analyzer_config_unknown : Error<"unknown analyzer-config '%0'">; +def err_analyzer_checker_option_invalid_input : Error< + "inva

[PATCH] D57850: [analyzer] Emit an error rather than assert on invalid checker option input

Szelethus updated this revision to Diff 186346. Szelethus added a comment. - Added a convenience method to `CheckerManager` for reporting invalid user input - Edited the error message to be more flexible CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57850/new/ https://reviews.llvm.org/

[PATCH] D57855: [analyzer] Reimplement checker options

Szelethus updated this revision to Diff 186350. Szelethus added a comment. - Removed the accidentally added `nullability:Optimistic` entry, - Reworded `unix.DynamicMemoryModeling:Optimistic`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57855/new/ https://reviews.llvm.org/D57855 Files

[PATCH] D57855: [analyzer] Reimplement checker options

Szelethus marked 5 inline comments as done. Szelethus added inline comments. Comment at: include/clang/StaticAnalyzer/Checkers/Checkers.td:384 + CheckerOptions<[ +CmdLineOption It would be great if there were a way to define options once and reuse them. I think it's possible

[PATCH] D58065: [analyzer] Document the frontend library

Szelethus added a comment. Herald added a subscriber: jdoerfert. Please, in the first round of reviews, if you could make high level comments about what should or should not be here would be great, perfectly wrapping around the 80 column limit and finding typos don't concern me as much before t

[PATCH] D50488: [Analyzer] Checker for non-determinism caused by sorting of pointer-like elements

Szelethus added a comment. @rnkovacs and @xazax.hun might be able to help with that? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50488/new/ https://reviews.llvm.org/D50488 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[PATCH] D57855: [analyzer] Reimplement checker options

Szelethus marked an inline comment as done. Szelethus added a comment. Since my changes are very invasive towards `CheckerRegistry` in general, I might `clang-format` the whole thing, and make the code follow the coding guidelines. Thanks for the review! CHANGES SINCE LAST ACTION https://rev

[PATCH] D57922: [analyzer] Insert checker options into AnalyzerOption::ConfigTable

Szelethus added a comment. Herald added a subscriber: jdoerfert. Hmm, supplying the default value for `AnalyzerOptions::getChecker*Option` is not only redundant with this patch, but also extremely bug-prone. I should remove them too in the same breath. Repository: rC Clang CHANGES SINCE LAS

[PATCH] D57855: [analyzer] Reimplement checker options

Szelethus added a comment. I guess removing some of the checker option descriptions from `lib/StataicAnalyzer/Checkers/` would be nice too, to easy on maintenance. One could always just use `-analyzer-checker-option-help` whenever in doubt. CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D58065: [analyzer] Document the frontend library

Szelethus added a comment. Thanks for the review on my patches! I'm a little busy atm (I've also wasted my second weekend trying to make Static Analyzer unit tests run under check-clang-analysis), but I'll see to fixing these in the coming weeks. In D58065#1400154

[PATCH] D58367: [analyzer] NFC: Improve upon the concept of BugReporterVisitor.

Szelethus added a comment. I love the idea! It looks way cleaner, tbh how messy visitors are have kept me away from implementing one for my own checker. Couple thoughts: 1. It would be great to have unit tests for this. Side note, I have already managed to make CSA unit tests tun under check-cl

[PATCH] D50488: [Analyzer] Checker for non-determinism caused by sorting of pointer-like elements

Szelethus added a comment. In D50488#1402699 , @mgrang wrote: > In D50488#1400823 , @whisperity > wrote: > > > Yeah, it seems upstream has moved away due to @Szelethus' implementation of > > a much more manageable

[PATCH] D50488: [Analyzer] Checker for non-determinism caused by sorting of pointer-like elements

Szelethus added a comment. In D50488#1403197 , @mgrang wrote: > > It's because it invokes CodeChecker, which by default enables > > valist.Uninitialized, but not ValistBase. Do you have assert failures after > > my hotfix? > > @Szelethus Thanks. I run in

[PATCH] D50488: [Analyzer] Checker for non-determinism caused by sorting of pointer-like elements

Szelethus added a comment. In D50488#1405094 , @mgrang wrote: > So I was able compile a couple of C++ code bases through csa-testbench. I > built cppcheck and tinyxml2 without any problems. cppcheck has one invocation > std::sort but the keys are not poi

[PATCH] D58573: [analyzer] Move UninitializedObject out of alpha

Szelethus created this revision. Szelethus added reviewers: dcoughlin, NoQ, xazax.hun, rnkovacs, whisperity, a.sidorin. Szelethus added a project: clang. Herald added subscribers: cfe-commits, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, szepet, baloghadamsoftware. I've tested the checker on

[PATCH] D50488: [Analyzer] Checker for non-determinism caused by sorting of pointer-like elements

Szelethus accepted this revision. Szelethus added a comment. But, as a work-in-progress alpha checker, the direction is set and looks great. Please let @NoQ have the final say. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50488/new/ https://reviews.llvm.org/D50488 _

[PATCH] D57892: [analyzer] Fix macro printer crash when macro comes from another translation unit

This revision was automatically updated to reflect the committed changes. Closed by commit rL354806: [analyzer] Fix infinite recursion in printing macros (authored by Szelethus, committed by ). Herald added subscribers: llvm-commits, Charusso. Herald added a project: LLVM. Changed prior to commit

[PATCH] D57892: [analyzer] Fix macro printer crash when macro comes from another translation unit

Szelethus added a comment. Whoops, incorrect commit title and description. Anyways, the committed code and the revision number is OK... Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57892/new/ https://reviews.llvm.org/D57892 ___

[PATCH] D62619: [analyzer][Dominators] Add a control dependency tree builder + a new debug checker

Szelethus added a comment. I seem to have made good progress on this, although it did require a lot of code changes on LLVM side (basically turning `BasicBlock *` to template arguments). Here's a sample: // <-- //

[PATCH] D62619: [analyzer][Dominators] Add a control dependency tree builder + a new debug checker

Szelethus added a comment. Also, I read some of the article you showed as well as the one I found on the dominance frontier file documentation[1], and I feel a lot more enlightened about the subject, thanks! I'll spend more time on them before wrapping this up. [1] Sreedhar and Gao. A linear ti

[PATCH] D62440: [analyzer] NFC: Change evalCall() to provide a CallEvent.

Szelethus accepted this revision. Szelethus added a comment. LGTM! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62440/new/ https://reviews.llvm.org/D62440 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D62883: [analyzer] Track conditions of terminator statements on which the reported node depends on

Szelethus created this revision. Szelethus added reviewers: NoQ, dcoughlin, a.sidorin, baloghadamsoftware, xazax.hun, Charusso, rnkovacs. Szelethus added a project: clang. Herald added subscribers: cfe-commits, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, szepet, whisperity. Szelethus added a

[PATCH] D62873: Avoid building analyzer plugins if CLANG_ENABLE_STATIC_ANALYZER is OFF

Szelethus added inline comments. Comment at: lib/Analysis/plugins/CMakeLists.txt:1 -if(LLVM_ENABLE_PLUGINS) +if(LLVM_ENABLE_PLUGINS AND CLANG_ENABLE_STATIC_ANALYZER) add_subdirectory(SampleAnalyzer) Is this file a thing? `lib/Analysis/plugins/CMakeLists.txt`?

[PATCH] D62883: [analyzer] Track conditions of terminator statements on which the reported node depends on

Szelethus marked an inline comment as done. Szelethus added a comment. For the test files where plist files have changed: (note to self: there has **got to be** a better way to show this off) F9062068: track_cond_undef_value_param_before.html F9062011: track_

[PATCH] D62873: Avoid building analyzer plugins if CLANG_ENABLE_STATIC_ANALYZER is OFF

Szelethus accepted this revision. Szelethus added a comment. I seem to have missed out on previous commits that moved analyzer plugins around -- would you mind adding `[analyzer]` to the revision names that affect the Static Analyzer? Many of us are automatically subscribed to such patches. In

[PATCH] D62885: [analyzer] Add werror flag for analyzer warnings

Szelethus added a comment. Interesting. Let's also have a link to your cfe-dev letter: http://lists.llvm.org/pipermail/cfe-dev/2019-June/062495.html So, you'd like to make this a frontend flag in order not to expose it to "regular" end users? Or was it because, well, every other flag we have is

[PATCH] D62441: [analyzer] NFC: Introduce a convenient CallDescriptionMap class.

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. This is why I love unit tests so much, you get the learn a lot about how things work! Thanks! The idea for the patch is great, can't wait to get rid of the mess we have in `MallocChecke

[PATCH] D62556: [analyzer] NFC: CallDescription: Implement describing C library functions.

Szelethus added a comment. I like the idea, but will need more time to get familiar with `CallEvent` to formally accept. > When matching C standard library functions in the checker, it's easy to > forget that they are often implemented as macros that are expanded to > compiler builtins. Such b

[PATCH] D62557: [analyzer] Modernize CStringChecker to use CallDescriptions.

Szelethus accepted this revision. Szelethus added a comment. That's beautiful *-* Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62557/new/ https://reviews.llvm.org/D62557 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D62899: [analyzer][UninitializedObjectChecker] Mark uninitialized regions as interesting.

Szelethus created this revision. Szelethus added reviewers: NoQ, xazax.hun, dcoughlin, baloghadamsoftware, rnkovacs. Szelethus added a project: clang. Herald added subscribers: cfe-commits, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet, whisperity. Repository: rC

[PATCH] D62619: [analyzer][Dominators] Add a control dependency tree builder + a new debug checker

Szelethus added a comment. While I managed to create a version of `llvm::IDFCalculator` that both compiles and works well with `clang::CFGBlock *`, I'm a little unsure about the specifics. I sent out a mail to reach a wider audience about the next steps: http://lists.llvm.org/pipermail/llvm-dev

[PATCH] D62926: [analyzer] ReturnVisitor: Bypass everything to see inlined calls

Szelethus added inline comments. Comment at: clang/test/Analysis/new-ctor-null-throw.cpp:1-3 +// RUN: %clang_analyze_cc1 \ +// RUN: -analyzer-checker=core,debug.ExprInspection \ +// RUN: -std=c++11 -verify %s Hmm, how come you removed `-analyzer-config c++-allo

[PATCH] D62883: [analyzer] Track conditions of terminator statements on which the reported node depends on

Szelethus added a comment. > I think we should make clear that this visitor only operates within one > function and does not track controll dependencies across functions. Hmm, maybe it's worth investigating whether if we pop the call stack, does the bug report improve if we update the visitor t

<    1   2   3   4   5   6   7   8   9   10   >