[PATCH] D80531: [clang-tidy]: Added modernize-replace-disallow-copy-and-assign-macro

kkleine added a comment. @dblaikie sorry for not getting to it for so long. I'm taking a look at the problem you've described now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80531/new/ https://reviews.llvm.org/D80531 __

[PATCH] D80531: [clang-tidy]: Added modernize-replace-disallow-copy-and-assign-macro

kkleine added a comment. Hi @dblaikie . I did run `ninja check-all` and `/bin/llvm-lit -av ../clang-tools-extra/test/clang-tidy/checkers/modernize-replace-disallow-copy-and-assign-macro.cpp` on this very new revision (abd70fb3983f342bc1c90f9c70a7b59790ad5206

[PATCH] D80531: [clang-tidy]: Added modernize-replace-disallow-copy-and-assign-macro

kkleine added a comment. @dblaikie sorry for the late feedback. The `LLVM_ENABLE_WERROR:BOOL` will "Stop and fail the build, if a compiler warning is triggered. Defaults to OFF." I wonder if any other test fails from clang tidy because. My test explicitly checks that a warning is issued (e.g. `

[PATCH] D80531: [clang-tidy]: Added modernize-replace-disallow-copy-and-assign-macro

kkleine added a comment. @njames93 I could do that but the original Macros had were defined without a semicolon at the end and one had to add it manually. See this revision in which I replaced some occurrences of `DISALLOW_COPY_AND_ASSIGN`: eaebcbc67926a18befaa297f1778edde63baec9b