kbarton created this revision.
kbarton added reviewers: power-llvm-team, hfinkel, echristo, rsmith.
Herald added a subscriber: nemanjai.
This is the clang counterpart to the patch posted in
https://reviews.llvm.org/D50988.
The patch removes Darwin support from the POWER backend. A similar approa
kbarton closed this revision.
kbarton added a comment.
Herald added a subscriber: jsji.
This landed in https://reviews.llvm.org/rL340770.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D50989/new/
https://reviews.llvm.org/D50989
___
cfe-commi
kbarton added a comment.
I think this looks straightforward, as long as people agree to have a separate
CreateConstrained* version of these functions. I'm not qualified to weigh in on
that as I don't know Clang at all and can't comment about the tradeoffs
(although I think they have been well a
kbarton added a comment.
@Meinersbur I missed the RFC and discussion on the cfe-dev mailing list. Could
you post a link here so that it's included in the history?
I don't have any opposition to this, and it seems that you have addressed all
the comments from reviewers. So, unless there was some
kbarton added a comment.
Sorry, I don't have time to go through the entire patch in detail right now.
But I did notice several places where the lines are too long, which need to get
fixed.
Comment at: lib/Headers/altivec.h:14206
kbarton requested changes to this revision.
kbarton added a comment.
This revision now requires changes to proceed.
Please make explicit the signed for the parameters to the functions you are
changing and remove unnecessary casts. I marked the first few that I found, but
stopped marking them aft
