[PATCH] D92181: [clangd] NFC: Add client-side logging for remote index requests

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5a1bc69f8110: [clangd] NFC: Add client-side logging for remote index requests (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D92198: [clangd] Log remote index connectivity status

kbobyrev updated this revision to Diff 310642. kbobyrev marked 5 inline comments as done. kbobyrev added a comment. Resolve review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92198/new/ https://reviews.llvm.org/D92198 Files: clang-to

[PATCH] D92788: [clangd] NFC: Use SmallVector where possible

kbobyrev updated this revision to Diff 310650. kbobyrev marked an inline comment as done. kbobyrev added a comment. Revert the case flagged by @njames93. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92788/new/ https://reviews.llvm.org/D92788 File

[PATCH] D92788: [clangd] NFC: Use SmallVector where possible

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/unittests/TestTU.cpp:190 const NamedDecl &findDecl(ParsedAST &AST, llvm::StringRef QName) { - llvm::SmallVector Components; + llvm::SmallVector Components; QName.split(Components, "::"); n

[PATCH] D92986: [clangd][NFC] Remove unnecessary vector.

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. Ah, I see now, thanks for the follow-up! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92986/new/ https://reviews.llvm.org/D92986 _

[PATCH] D92788: [clangd] NFC: Use SmallVector where possible

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/unittests/TestTU.cpp:190 const NamedDecl &findDecl(ParsedAST &AST, llvm::StringRef QName) { - llvm::SmallVector Components; + llvm::SmallVector Components; QName.split(Components, "::"); k

[PATCH] D92788: [clangd] NFC: Use SmallVector where possible

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGee02e20c0817: [clangd] NFC: Use SmallVector where possible (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D92788: [clangd] NFC: Use SmallVector where possible

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/unittests/TestTU.cpp:190 const NamedDecl &findDecl(ParsedAST &AST, llvm::StringRef QName) { - llvm::SmallVector Components; + llvm::SmallVector Components; QName.split(Components, "::"); k

[PATCH] D92220: [clangd] Add support for static fields in rename

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/unittests/RenameTests.cpp:630 )cpp", + R"cpp( +template struct Foo { static T Variable; }; hokein wrote: > hmm, looks like these two tests are already working at head (witho

[PATCH] D92198: [clangd] Log remote index connectivity status

kbobyrev updated this revision to Diff 311937. kbobyrev marked an inline comment as done. kbobyrev added a comment. Remove the race between ConnectionStatus access. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92198/new/ https://reviews.llvm.org/D

[PATCH] D92198: [clangd] Log remote index connectivity status

kbobyrev updated this revision to Diff 311939. kbobyrev added a comment. Cleanup includes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92198/new/ https://reviews.llvm.org/D92198 Files: clang-tools-extra/clangd/index/remote/Client.cpp Index: c

[PATCH] D92198: [clangd] Log remote index connectivity status

kbobyrev updated this revision to Diff 311942. kbobyrev added a comment. Cleanup rebase artifact. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92198/new/ https://reviews.llvm.org/D92198 Files: clang-tools-extra/clangd/index/remote/Client.cpp I

[PATCH] D92198: [clangd] Log remote index connectivity status

kbobyrev updated this revision to Diff 311943. kbobyrev added a comment. Actually clean up rebase artifacts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92198/new/ https://reviews.llvm.org/D92198 Files: clang-tools-extra/clangd/index/remote/Cl

[PATCH] D92198: [clangd] Log remote index connectivity status

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdcdef5b5b3df: [clangd] Log remote index connectivity status (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D92788: [clangd] NFC: Use SmallVector where possible

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/Headers.h:139 // Maps a file's index to that of the files it includes. - llvm::DenseMap> IncludeChildren; + llvm::DenseMap> IncludeChildren; }; arphaman wrote: > It looks like the change o

[PATCH] D90746: [clangd] Cleanup dependencies around RemoteIndex

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/CMakeLists.txt:115 LINK_LIBS + clangdRemoteIndex clangdSupport If we're moving `clangdRemoteIndex` to `clangDaemon` there is no need to link `clangd` itself to `clangdRemoteIndex` anymor

[PATCH] D90746: [clangd] Cleanup dependencies around RemoteIndex

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: clang-tools-extra/clangd/CMakeLists.txt:115 LINK_LIBS + clangdRemoteIndex clangdSupport kadircet wrote: > kbobyrev wrote

[PATCH] D71880: [clangd] Implement Decl canonicalization rules for rename

kbobyrev updated this revision to Diff 303397. kbobyrev added a comment. Continue implementation, integrate more tests from clang-rename. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71880/new/ https://reviews.llvm.org/D71880 Files: clang-tools

[PATCH] D71880: [clangd] Implement Decl canonicalization rules for rename

kbobyrev updated this revision to Diff 303733. kbobyrev added a comment. Store progress. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71880/new/ https://reviews.llvm.org/D71880 Files: clang-tools-extra/clangd/refactor/Rename.cpp clang-tools-e

[PATCH] D90116: [clangd] Escape Unicode characters to fix Windows builds

kbobyrev updated this revision to Diff 303754. kbobyrev added a comment. Rebase on top of master. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90116/new/ https://reviews.llvm.org/D90116 Files: llvm/CMakeLists.txt Index: llvm/CMakeLists.txt ==

[PATCH] D90116: [clangd] Escape Unicode characters to fix Windows builds

kbobyrev updated this revision to Diff 303753. kbobyrev added a comment. Herald added subscribers: llvm-commits, mgorny. Herald added a project: LLVM. Force MSVC to read code as UTF-8 via CMake options. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D71880: [clangd] Implement Decl canonicalization rules for rename

kbobyrev updated this revision to Diff 303940. kbobyrev added a comment. Finish fields canonicalization. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71880/new/ https://reviews.llvm.org/D71880 Files: clang-tools-extra/clangd/refactor/Rename.cpp

[PATCH] D90116: [llvm] CMake: Force MSVC to read code as UTF-8

kbobyrev updated this revision to Diff 303942. kbobyrev marked an inline comment as done. kbobyrev added a comment. Omit CXX_COMPILER_ID:MSVC since we're within MSVC section. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90116/new/ https://reviews.

[PATCH] D91102: [clangd] Enhance Clangd rename testing coverage

kbobyrev created this revision. kbobyrev added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. kbobyrev requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. We plan to eliminate error-prone and obsolete

[PATCH] D91102: [clangd] Enhance Clangd rename testing coverage

kbobyrev updated this revision to Diff 303980. kbobyrev added a comment. Move NewName constant to class field. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91102/new/ https://reviews.llvm.org/D91102 Files: clang-tools-extra/clangd/unittests/Ren

[PATCH] D71880: [clangd] Implement Decl canonicalization rules for rename

kbobyrev planned changes to this revision. kbobyrev added a comment. Still WIP, moving test changes to a separate chain of patches (starts with D91102 ) to make review easier and start the pipeline. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D90116: [llvm] CMake: Force MSVC to read code as UTF-8

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4d81c8adb6ed: [llvm] CMake: Force MSVC to read code as UTF-8 (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D90672: [clang] Simplify buildSyntaxTree API

kbobyrev updated this revision to Diff 303984. kbobyrev marked an inline comment as done. kbobyrev added a comment. Update comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90672/new/ https://reviews.llvm.org/D90672 Files: clang-tools-extra

[PATCH] D90672: [clang] Simplify buildSyntaxTree API

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG142c6f82fda8: [clang] Simplify buildSyntaxTree API (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D90116: [llvm] CMake: Force MSVC to read code as UTF-8

kbobyrev added a comment. Sigh, this doesn't work because we have things like https://docs.microsoft.com/en-us/windows/win32/api/traceloggingprovider/nf-traceloggingprovider-tracelogging_define_provider and https://docs.microsoft.com/en-us/windows/win32/tracelogging/tracelogging-native-quick-st

[PATCH] D84232: [clangd] Set minimum gRPC version to 1.27

kbobyrev planned changes to this revision. kbobyrev added a comment. Need to exclude everything between 1.26.0 and 1.27.0, not set this as the minimum (Ubuntu packages are outdated). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84232/new/ https:/

[PATCH] D91102: [clangd] Enhance Clangd rename testing coverage

kbobyrev updated this revision to Diff 304071. kbobyrev marked 3 inline comments as done. kbobyrev added a comment. Resolve comments. Since member tests seem to be covered already, add enum and alias tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D91102: [clangd] Enhance Clangd rename testing coverage

kbobyrev updated this revision to Diff 304076. kbobyrev added a comment. Also add class tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91102/new/ https://reviews.llvm.org/D91102 Files: clang-tools-extra/clangd/unittests/RenameTests.cpp In

[PATCH] D91102: [clangd] Enhance Clangd rename testing coverage

kbobyrev updated this revision to Diff 304077. kbobyrev marked 3 inline comments as done. kbobyrev added a comment. Resolve comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91102/new/ https://reviews.llvm.org/D91102 Files: clang-tools-ext

[PATCH] D91102: [clangd] Enhance Clangd rename testing coverage

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGca892f46fe12: [clangd] Enhance Clangd rename testing coverage (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D91134: [clangd] Abort rename when given the same name

kbobyrev created this revision. kbobyrev added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. kbobyrev requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. When user wants to rename the symbol to the sa

[PATCH] D91134: [clangd] Abort rename when given the same name

kbobyrev updated this revision to Diff 304423. kbobyrev marked an inline comment as done. kbobyrev added a comment. - Change error message to description rather than suggestion. - Move test to more appropriate location. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D91134: [clangd] Abort rename when given the same name

kbobyrev marked an inline comment as not done. kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:218 +case ReasonToReject::SameName: + return "new name should differ from the old name"; } hokein wrote: > sammcc

[PATCH] D91240: [clangd] Continue test adoption from Clang-Rename

kbobyrev created this revision. kbobyrev added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. kbobyrev requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Tests can not be adopted 1:1 (e.g. Clang-Renam

[PATCH] D91134: [clangd] Abort rename when given the same name

kbobyrev updated this revision to Diff 304434. kbobyrev added a comment. Add a comment to the test to make it more explicit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91134/new/ https://reviews.llvm.org/D91134 Files: clang-tools-extra/clangd

[PATCH] D91134: [clangd] Abort rename when given the same name

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG91ce6fb5a65f: [clangd] Abort rename when given the same name (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D84232: [clangd] Set minimum gRPC version to 1.27

kbobyrev abandoned this revision. kbobyrev added a comment. There are more revisions that are buggy, can't test them all :( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84232/new/ https://reviews.llvm.org/D84232 __

[PATCH] D91240: [clangd] Continue test adoption from Clang-Rename

kbobyrev updated this revision to Diff 30. kbobyrev added a comment. Check for equality with .endswith() and remove ---END--- hack Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91240/new/ https://reviews.llvm.org/D91240 Files: clang-tools-ex

[PATCH] D91240: [clangd] Continue test adoption from Clang-Rename

kbobyrev abandoned this revision. kbobyrev added a comment. As discussed offline, these tests are for qualified rename paths so not really useful :( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91240/new/ https://reviews.llvm.org/D91240

[PATCH] D71880: [clangd] Implement Decl canonicalization rules for rename

kbobyrev updated this revision to Diff 304463. kbobyrev added a comment. Reset unittests to HEAD. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71880/new/ https://reviews.llvm.org/D71880 Files: clang-tools-extra/clangd/refactor/Rename.cpp clan

[PATCH] D71880: [clangd] Implement Decl canonicalization rules for rename

kbobyrev updated this revision to Diff 304464. kbobyrev added a comment. Actually reset RenameTests.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71880/new/ https://reviews.llvm.org/D71880 Files: clang-tools-extra/clangd/refactor/Rename.cpp

[PATCH] D71880: [clangd] Implement Decl canonicalization rules for rename

kbobyrev planned changes to this revision. kbobyrev added a comment. Still WIP. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71880/new/ https://reviews.llvm.org/D71880 ___ cfe-commits mailing list cfe-c

[PATCH] D71880: [clangd] Implement Decl canonicalization rules for rename

kbobyrev updated this revision to Diff 304466. kbobyrev added a comment. Rebase on top of master. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71880/new/ https://reviews.llvm.org/D71880 Files: clang-tools-extra/clangd/refactor/Rename.cpp Index

[PATCH] D71880: [clangd] Implement Decl canonicalization rules for rename

kbobyrev updated this revision to Diff 304500. kbobyrev added a comment. I think this is the first version that is ready for a review. Let me know if you have any questions, @hokein! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71880/new/ https://

[PATCH] D71880: [clangd] Implement Decl canonicalization rules for rename

kbobyrev updated this revision to Diff 304729. kbobyrev added a comment. Use early return in FieldDecl canonicalization. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71880/new/ https://reviews.llvm.org/D71880 Files: clang-tools-extra/clangd/ref

[PATCH] D71880: [clangd] Implement Decl canonicalization rules for rename

kbobyrev updated this revision to Diff 304776. kbobyrev marked 5 inline comments as done. kbobyrev added a comment. - Handle VarDecl - Handle FunctionTemplateDecl - Remove FieldDecl handling (leave for the future patches) - Simplify code - Prevent regressions by adding more tests Repository: r

[PATCH] D71880: [clangd] Implement Decl canonicalization rules for rename

kbobyrev updated this revision to Diff 304783. kbobyrev added a comment. Add missing user-defined conversion test and a couple of missing cases with ctor/dtor out-of-line implementation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71880/new/ http

[PATCH] D71880: [clangd] Implement Decl canonicalization rules for rename

kbobyrev updated this revision to Diff 304784. kbobyrev added a comment. Add a test with static class member. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71880/new/ https://reviews.llvm.org/D71880 Files: clang-tools-extra/clangd/refactor/Renam

[PATCH] D71880: [clangd] Implement Decl canonicalization rules for rename

kbobyrev updated this revision to Diff 304785. kbobyrev added a comment. Remove (now) outdated comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71880/new/ https://reviews.llvm.org/D71880 Files: clang-tools-extra/clangd/refactor/Rename.cpp

[PATCH] D71880: [clangd] Implement Decl canonicalization rules for rename

kbobyrev updated this revision to Diff 304787. kbobyrev added a comment. Completely remove new tests from this patch (to be provided in a different one). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71880/new/ https://reviews.llvm.org/D71880 File

[PATCH] D91337: [clangd] Add missing tests to rename feature

kbobyrev created this revision. kbobyrev added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman. Herald added a project: clang. kbobyrev requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. This adds a couple of missed tests f

[PATCH] D71880: [clangd] Implement Decl canonicalization rules for rename

kbobyrev updated this revision to Diff 304893. kbobyrev added a comment. Remove unused header (was added for llvm_unreachable). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71880/new/ https://reviews.llvm.org/D71880 Files: clang-tools-extra/cla

[PATCH] D91337: [clangd] Add missing tests to rename feature

kbobyrev updated this revision to Diff 305047. kbobyrev marked 4 inline comments as done. kbobyrev added a comment. Address the comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91337/new/ https://reviews.llvm.org/D91337 Files: clang-tools

[PATCH] D91337: [clangd] Add missing tests to rename feature

kbobyrev updated this revision to Diff 305070. kbobyrev added a comment. Move the rest of templated cases to appropriate location. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91337/new/ https://reviews.llvm.org/D91337 Files: clang-tools-extra/

[PATCH] D91337: [clangd] Add missing tests to rename feature

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa1152482826c: [clangd] Add missing tests to rename feature (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D71880: [clangd] Implement Decl canonicalization rules for rename

kbobyrev updated this revision to Diff 306026. kbobyrev marked 2 inline comments as done. kbobyrev added a comment. Resolve some comments, simplify the code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71880/new/ https://reviews.llvm.org/D71880

[PATCH] D71880: [clangd] Implement Decl canonicalization rules for rename

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:239 + if (const auto *Template = D->getPrimaryTemplate()) +return canonicalRenameDecl(Template); + return D; hokein wrote: > the `auto` + varies `canonicalRenameDecl` o

[PATCH] D71880: [clangd] Implement Decl canonicalization rules for rename

kbobyrev updated this revision to Diff 306027. kbobyrev added a comment. Remove leftover test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71880/new/ https://reviews.llvm.org/D71880 Files: clang-tools-extra/clangd/refactor/Rename.cpp Index: c

[PATCH] D71880: [clangd] Implement Decl canonicalization rules for rename

kbobyrev planned changes to this revision. kbobyrev added a comment. Need to address the comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71880/new/ https://reviews.llvm.org/D71880 ___ cfe-commits

[PATCH] D71880: [clangd] Implement Decl canonicalization rules for rename

kbobyrev updated this revision to Diff 306334. kbobyrev marked 8 inline comments as done. kbobyrev added a comment. Resolve review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71880/new/ https://reviews.llvm.org/D71880 Files: clang-to

[PATCH] D91859: [clangd] Fix shared-lib builds

kbobyrev requested changes to this revision. kbobyrev added a comment. This revision now requires changes to proceed. Thank you for taking care of thiis! The complete fix, however, should include two more things: 1. Moving this if (CLANGD_ENABLE_REMOTE) include(FindGRPC) endif() before

[PATCH] D91859: [clangd] Fix shared-lib builds

kbobyrev added a comment. Actually, it would be safer if `FindGRPC` was also higher than `add_subdirectory(tool)`: right now it only includes `remote/index/Client.h` and `Client.h` does not depend on any gRPC/Protobuf headers for now but that might change at some point and break builds unexpect

[PATCH] D88507: [clangd][remote] Make sure relative paths are absolute with respect to posix style

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. Ahh, good catch! Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88507/new/ https://reviews.llvm.org/D88507 __

[PATCH] D88470: [clangd] Extract options struct for ClangdLSPServer. NFC

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: clang-tools-extra/clangd/ClangdLSPServer.h:56 + // Features like indexing must be enabled if desired. + static Options optsForTest(); + --

[PATCH] D88553: [clangd] Stash a patch piece

kbobyrev created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman. Herald added a project: clang. kbobyrev requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D88553

[PATCH] D88427: [clangd] Remove Tweak::Intent, use CodeAction kind directly

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. LGTM; maybe mark as refactoring/NFC ;) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88427/new/ https://reviews.llvm.org/D88427 ___

[PATCH] D88724: [clangd] Make the tweak filter a parameter to enumerateTweaks. NFC

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88724/new/ https://reviews.llvm.org/D88724 _

[PATCH] D89220: [clang-rename] Simplify the code of handling class paritial specializations, NFC.

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89220/new/ https://reviews.llvm.org/D89220

[PATCH] D89300: [clang-rename] Fix rename on variable templates.

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. Oh, that's neat, thanks! Comment at: clang/include/clang/AST/DeclTemplate.h:3098 llvm::FoldingSetVector & - getPartialSpecializations(); + getPartialSpecializations(

[PATCH] D89300: [clang-rename] Fix rename on variable templates.

kbobyrev added inline comments. Comment at: clang/include/clang/AST/DeclTemplate.h:3098 llvm::FoldingSetVector & - getPartialSpecializations(); + getPartialSpecializations() const; hokein wrote: > kbobyrev wrote: > > I believe these are from https://review

[PATCH] D89221: [clang-rename] Fix rename on function template specializations.

kbobyrev requested changes to this revision. kbobyrev added a comment. This revision now requires changes to proceed. And indeed I did miss that :( Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89221/new/ https://reviews.llvm.org/D89221

[PATCH] D89529: [clangd][remote] Add Windows paths support

kbobyrev requested changes to this revision. kbobyrev added a comment. This revision now requires changes to proceed. Hi, thanks for flagging the issue! Could you please give more information where exactly the tests fail (e.g. logs with assertions)? This way I could understand where exactly the

[PATCH] D89529: [clangd][remote] Add Windows paths support

kbobyrev added a comment. In D89529#2334475 , @ArcsinX wrote: > In D89529#2334407 , @kbobyrev wrote: > >> Hi, thanks for flagging the issue! Could you please give more information >> where exactly the tests fail (e

[PATCH] D91859: [clangd] Fix shared-lib builds

kbobyrev added a comment. In D91859#2408064 , @sammccall wrote: > I'm not totally following the discussion on the more complete fix (LMK if you > want me to dig into that), but if the build is broken in some configurations > we should likely prioritize f

[PATCH] D91859: [clangd] Fix shared-lib builds

kbobyrev added a comment. (also please add "Fixes https://github.com/clangd/clangd/issues/598"; to the patch description to close the related issue on GH) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91859/new/ https://reviews.llvm.org/D91859 __

[PATCH] D91859: [clangd] Fix shared-lib builds

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. Ah, right. I think `clangd-remote-index` needs `protobuf` dependency. @nridge, I believe this should fix the problem you're seeing. I'm somewhat confused as to why I'm not seeing the same

[PATCH] D91859: [clangd] Fix shared-lib builds

kbobyrev added a comment. In D91859#2410166 , @kadircet wrote: > In D91859#2409743 , @nridge wrote: > >> I applied the patch locally and it fixes most of the linker errors but I'm >> still seeing one: >> >> [6/39

[PATCH] D91859: [clangd] Fix shared-lib builds

kbobyrev added a comment. In D91859#2410252 , @nridge wrote: > In D91859#2410002 , @kbobyrev wrote: > >> Ah, right. I think `clangd-remote-index` needs `protobuf` dependency. >> @nridge, I believe this should fix t

[PATCH] D71880: [clangd] Implement Decl canonicalization rules for rename

kbobyrev updated this revision to Diff 306987. kbobyrev marked 4 inline comments as done. kbobyrev added a comment. Resolve comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71880/new/ https://reviews.llvm.org/D71880 Files: clang-tools-ext

[PATCH] D71880: [clangd] Implement Decl canonicalization rules for rename

kbobyrev updated this revision to Diff 306988. kbobyrev added a comment. Make use of TemplatedDecl. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71880/new/ https://reviews.llvm.org/D71880 Files: clang-tools-extra/clangd/refactor/Rename.cpp Ind

[PATCH] D71880: [clangd] Implement Decl canonicalization rules for rename

kbobyrev updated this revision to Diff 307013. kbobyrev marked an inline comment as done. kbobyrev added a comment. Get rid of forward declaration. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71880/new/ https://reviews.llvm.org/D71880 Files: c

[PATCH] D71880: [clangd] Implement Decl canonicalization rules for rename

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcf39bdb49086: [clangd] Implement Decl canonicalization rules for rename (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D91951: [clangd] Get rid of clangToolingRefactoring dependency

kbobyrev created this revision. kbobyrev added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, mgorny. Herald added a project: clang. kbobyrev requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. D71880

[PATCH] D91952: [clangd] Add support for within-file rename of complicated fields

kbobyrev created this revision. kbobyrev added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. kbobyrev requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. This was originally a part of D71880

[PATCH] D91951: [clangd] Get rid of clangToolingRefactoring dependency

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1319c6624ed6: [clangd] Get rid of clangToolingRefactoring dependency (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D91952: [clangd] Add support for within-file rename of complicated fields

kbobyrev updated this revision to Diff 307317. kbobyrev marked 4 inline comments as done. kbobyrev added a comment. Resolve most actionable comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91952/new/ https://reviews.llvm.org/D91952 Files:

[PATCH] D91952: [clangd] Add support for within-file rename of complicated fields

kbobyrev planned changes to this revision. kbobyrev added a comment. template struct Foo { static T [[Var^iable]]; }; template <> int Foo::[[Variable^]] = 42; template <> bool Foo::[[Variable^]] = true; void foo() { int LocalInt = Foo::[[Variable^]]; bool Local

[PATCH] D91952: [clangd] Add support for within-file rename of complicated fields

kbobyrev updated this revision to Diff 307327. kbobyrev added a comment. Added support for static templated fields. Ready for the review again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91952/new/ https://reviews.llvm.org/D91952 Files: clang

[PATCH] D88172: [clangd] Extract common file-caching logic from ConfigProvider.

kbobyrev added a comment. Sorry for such a tremendous delay. Mostly looks good functionally, I just have a few questions about semantics and several stylistic nits. Also, thanks for the amount of documentation - it makes it really nice to navigate around and review. Comment

[PATCH] D88172: [clangd] Extract common file-caching logic from ConfigProvider.

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/unittests/support/FileCacheTests.cpp:15 +#include +#include + njames93 wrote: > kbobyrev wrote: > > Please sort the includes here (clangd should have a Code Action here). > The includes are so

[PATCH] D88172: [clangd] Extract common file-caching logic from ConfigProvider.

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. LGTM with `std::numeric_limits` in the second place :) Thanks! Comment at: clang-tools-extra/clangd/support/FileCache.cpp:21 +// The cached value reflects that the file d

[PATCH] D91952: [clangd] Add support for within-file rename of complicated fields

kbobyrev updated this revision to Diff 307818. kbobyrev marked 6 inline comments as done. kbobyrev added a comment. Resolve remaining comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91952/new/ https://reviews.llvm.org/D91952 Files: clang

[PATCH] D91952: [clangd] Add support for within-file rename of complicated fields

kbobyrev updated this revision to Diff 307834. kbobyrev marked 3 inline comments as done. kbobyrev added a comment. Resolve another round of comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91952/new/ https://reviews.llvm.org/D91952 Files:

[PATCH] D92181: [clangd] NFC: Add client-side logging for remote index requests

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. kbobyrev requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Figuring out whether the server is respondi

[PATCH] D92181: [clangd] NFC: Add client-side logging for remote index requests

kbobyrev updated this revision to Diff 307869. kbobyrev added a comment. Switch Deadline type to `const auto`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92181/new/ https://reviews.llvm.org/D92181 Files: clang-tools-extra/clangd/index/remote/

<    4   5   6   7   8   9   10   11   12   13   >