raj.khem added a comment.
@bcraig, right, check for __GLIBC__ can be moved after including features.h.
https://chromium.googlesource.com/native_client/pnacl-libcxx/+/master%5E!/
seems to add needed tweaks which can be enabled by passing -D__musl__ in CFLAGS
may be it can be backported to 3.8 bran
raj.khem added a comment.
3.8 has it in there. So may be this is just not required. I will add
-DLIBCXX_HAS_MUSL_LIBC=ON to Cmake and see what comes out
http://reviews.llvm.org/D18174
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://l
raj.khem added a comment.
I think my problem was that while compiling libcxxabi, it wants to peek into
libcxx headers but then libcxxabi cmake infra doesnt have the musl support like
libcxx. So Now I solved it by adding -D_LIBCPP_HAS_MUSL_LIBC to CXXFLAGS.
http://reviews.llvm.org/D18174
___
raj.khem added a comment.
libcxx still has problem compiling on musl/aarch64 though. I fixed it with this
patch
https://github.com/kraj/meta-clang/blob/master/recipes-devtools/clang/libcxx/0001-use-constexpr-when-using-glibc.patch
does this make sense ?
http://reviews.llvm.org/D18174
_
kraj wrote:
> @kraj, you approved this and you are a project member, are you comfortable
> merging this? If so, please go ahead.
>
> From my point of view as a clangd maintainer, I'm supportive of having such
> an option, but I have ~zero CMake knowledge, so if you think this needs more
> rev
https://github.com/kraj approved this pull request.
looks good to me.
https://github.com/llvm/llvm-project/pull/133124
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
