Re: [PATCH] D18174: Fix libcxx build on musl

raj.khem added a comment. @bcraig, right, check for __GLIBC__ can be moved after including features.h. https://chromium.googlesource.com/native_client/pnacl-libcxx/+/master%5E!/ seems to add needed tweaks which can be enabled by passing -D__musl__ in CFLAGS may be it can be backported to 3.8 bran

Re: [PATCH] D18174: Fix libcxx build on musl

raj.khem added a comment. 3.8 has it in there. So may be this is just not required. I will add -DLIBCXX_HAS_MUSL_LIBC=ON to Cmake and see what comes out http://reviews.llvm.org/D18174 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://l

Re: [PATCH] D18174: Fix libcxx build on musl

raj.khem added a comment. I think my problem was that while compiling libcxxabi, it wants to peek into libcxx headers but then libcxxabi cmake infra doesnt have the musl support like libcxx. So Now I solved it by adding -D_LIBCPP_HAS_MUSL_LIBC to CXXFLAGS. http://reviews.llvm.org/D18174 ___

Re: [PATCH] D18174: Fix libcxx build on musl

raj.khem added a comment. libcxx still has problem compiling on musl/aarch64 though. I fixed it with this patch https://github.com/kraj/meta-clang/blob/master/recipes-devtools/clang/libcxx/0001-use-constexpr-when-using-glibc.patch does this make sense ? http://reviews.llvm.org/D18174 _

[clang-tools-extra] clangd: Add a build option to disable building dexp (PR #133124)

https://github.com/kraj approved this pull request. looks good to me. https://github.com/llvm/llvm-project/pull/133124 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] libunwind: Do not use __attribute__((target("gcs"))) with non-clang … (PR #138077)

https://github.com/kraj updated https://github.com/llvm/llvm-project/pull/138077 >From 399e475a17022e6806803ddb7e83599403ffb53d Mon Sep 17 00:00:00 2001 From: Khem Raj Date: Wed, 30 Apr 2025 19:51:19 -0700 Subject: [PATCH] libunwind: Do not use __attribute__((target("gcs"))) with non-clang comp

[libunwind] libunwind: Do not use __attribute__((target("gcs"))) with non-clang … (PR #138077)

https://github.com/kraj updated https://github.com/llvm/llvm-project/pull/138077 >From aabc92ee06f3ccf89bcccf759c50a667d4eada0c Mon Sep 17 00:00:00 2001 From: Khem Raj Date: Wed, 30 Apr 2025 19:51:19 -0700 Subject: [PATCH] libunwind: Use +gcs instead of gcs target attribute __attribute__((targe

[libunwind] libunwind: Do not use __attribute__((target("gcs"))) with non-clang … (PR #138077)

https://github.com/kraj updated https://github.com/llvm/llvm-project/pull/138077 >From bcc31a9384d2df1c0f27ef140e1f0f9ee493034f Mon Sep 17 00:00:00 2001 From: Khem Raj Date: Wed, 30 Apr 2025 19:51:19 -0700 Subject: [PATCH] libunwind: Use +gcs instead of gcs target attribute __attribute__((targe

[libunwind] libunwind: Do not use __attribute__((target("gcs"))) with non-clang … (PR #138077)

https://github.com/kraj updated https://github.com/llvm/llvm-project/pull/138077 >From e9870d6a848a95cf58f890a7e6d3a93a27e7c061 Mon Sep 17 00:00:00 2001 From: Khem Raj Date: Wed, 30 Apr 2025 19:51:19 -0700 Subject: [PATCH] libunwind: Do not use __attribute__((target("gcs"))) with non-clang comp

[libunwind] libunwind: Do not use __attribute__((target("gcs"))) with non-clang … (PR #138077)

https://github.com/kraj created https://github.com/llvm/llvm-project/pull/138077 …compilers This attribute is unsupported in GCC, so far it worked because before GCC15 did not define this macros in _CHKFEAT_GCS in arm_acle.h [1] With gcc15 compiler libunwind's check for this macros is succeedi

[clang-tools-extra] clangd: Add a build option to disable building dexp (PR #133124)

kraj wrote: > @kraj, you approved this and you are a project member, are you comfortable > merging this? If so, please go ahead. > > From my point of view as a clangd maintainer, I'm supportive of having such > an option, but I have ~zero CMake knowledge, so if you think this needs more > rev