Re: [PATCH] D35961: [llvm] Update MachOObjectFile::exports interface

> On Jul 27, 2017, at 9:50 PM, Saleem Abdulrasool via Phabricator > wrote: > > compnerd added a comment. > > Does anyone use the overload with the `O` for `exports` with `nullptr` > instead of `this`? If not, we could just inline `this` throughout. This will break lld as it needs the defaul

Re: [PATCH] D35961: [llvm] Update MachOObjectFile::exports interface

> On Jul 28, 2017, at 10:30 AM, David Blaikie wrote: > > > > On Fri, Jul 28, 2017 at 10:24 AM Kevin Enderby > wrote: >> On Jul 27, 2017, at 9:50 PM, Saleem Abdulrasool via Phabricator >> mailto:revi...@reviews.llvm.org>> wrote: >> >> compnerd added a comment. >> >

Re: [PATCH] D35961: [llvm] Update MachOObjectFile::exports interface

Looks fine to me. Kev > On Jul 28, 2017, at 3:49 PM, Alexander Shaposhnikov > wrote: > > Hi, > many thanks for looking at the diff. > (i started working on this because this interface change broke some > out-of-tree code, but that's expected and not a big issue, i just wanted to > clean it