[PATCH] D33705: [CGVTables] Finalize SP before attempting to clone it

loladiro created this revision. LLVM commit https://reviews.llvm.org/D33655 was reverted, because it exposed an assertion failure, in `GenerateVarArgsThunk`. That function attempts to clone a function before clang is entirely done generating the debug info for the current compliation unit. That i

[PATCH] D24371: Add diagnostics to require_constant_initialization

loladiro added a comment. Sure, I'll commit it. https://reviews.llvm.org/D24371 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33705: [CGVTables] Finalize SP before attempting to clone it

loladiro updated this revision to Diff 101092. loladiro added a comment. Finalize all subprograms when we're done emitting them. The one we're interested in is a side effect, but doing this uniformly might be cleaner and help avoid similar errors in the future. https://reviews.llvm.org/D33705 F

[PATCH] D33705: [CGVTables] Finalize SP before attempting to clone it

loladiro added a comment. @aprantl @dblaikie See if you like this better. https://reviews.llvm.org/D33705 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33705: [CGVTables] Finalize SP before attempting to clone it

loladiro added a comment. There's already such a test case, but the cloning currently doesn't assert properly (but it can generate incorrect code). https://reviews.llvm.org/D33655 fixes that up, so I think the testing is covered once that LLVM commit goes in. I'll hold off a little while to giv

[PATCH] D33705: [CGVTables] Finalize SP before attempting to clone it

loladiro added a comment. I don't think that change is entirely necessary. I don't have any strong objections to it, but I also don't see a good reason to require it. In any case, let me get this in to be able to re-land https://reviews.llvm.org/D33655 and we can revisit the more disruptive cha

[PATCH] D62885: [analyzer] Add werror flag for analyzer warnings

loladiro created this revision. loladiro added a reviewer: NoQ. Herald added subscribers: cfe-commits, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. We're using the clang static analyzer together with a n

[PATCH] D62885: [analyzer] Add werror flag for analyzer warnings

loladiro marked an inline comment as done. loladiro added a comment. > So, you'd like to make this a frontend flag in order not to expose it to > "regular" end users? Or was it because, well, every other flag we have is a > frontend flag? Little bit of both? We already need to pass a bunch of `

[PATCH] D66035: [WebAssembly] WIP: Add support for reference types

loladiro updated this revision to Diff 214467. loladiro added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Accidentally only pushed half the changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66035/new/ https

[PATCH] D88630: [clang/CMake] Respect LLVM_TOOLS_INSTALL_DIR

loladiro created this revision. loladiro added a reviewer: tstellar. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. loladiro requested review of this revision. Otherwise clang installs all of its tools into `bin/` while LLVM installs its tools into (LLVM_TOOLS_INSTAL

[PATCH] D114533: LLVM IR should allow bitcast between address spaces with the same size.

loladiro added a comment. @jrtc27 is correct. This absolutely must not apply to non-integral address spaces. It is not legal for LLVM to introduce additional ptrtoint instructions for non-integral address spaces that were not present in the original input IR. That doesn't change if the spelling

[PATCH] D30589: [ExprInspectionChecker] Improve usability for C

loladiro created this revision. Some of the magic functions take arguments of arbitrary type. However, for semantic correctness, the compiler still requires a declaration of these functions with the correct type. Since C does not have argument-type-overloaded function, this made those functions ha

[PATCH] D27564: [libcxx] Fix __compressed_pair so it doesn't copy the argument multiple times

loladiro added a comment. I take it this supersedes https://reviews.llvm.org/D24372? I apologize for not getting around to commiting that yet, but if it does supersede that revision, we should probably keep the tests that we have there. https://reviews.llvm.org/D27564 __