[PATCH] D80225: [Driver] Recognize -fuse-ld={bfd, gold, lld} but don't prepend "ld." or "ld64." for other values

keith added a comment. I've submitted a related change to accept relative paths for `-fuse-ld` https://reviews.llvm.org/D80660 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80225/new/ https://reviews.llvm.org/D80225

[PATCH] D80660: clang: Add support for relative linker paths with -fuse-ld

keith created this revision. keith added reviewers: kastiglione, MaskRay, theraven, rnk. Herald added a project: clang. This adds support for resolving linker executable paths relatively instead of requiring them to be names, or absolute paths. This is useful if you're vendoring an in-tree linker,

[PATCH] D80660: clang: Add support for relative linker paths with -fuse-ld

keith updated this revision to Diff 267069. keith added a comment. Update tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80660/new/ https://reviews.llvm.org/D80660 Files: clang/lib/Driver/ToolChain.cpp clang/test/Driver/fuse-ld.c Index:

[PATCH] D80660: clang: Add support for relative linker paths with -fuse-ld

keith added a comment. Thanks I moved them to the bottom and I believe I fixed them on windows! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80660/new/ https://reviews.llvm.org/D80660 ___ cfe-commits

[PATCH] D80660: clang: Add support for relative linker paths with -fuse-ld

keith added a comment. The new test failure appears unrelated to my changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80660/new/ https://reviews.llvm.org/D80660 ___ cfe-commits mailing list cfe-com

[PATCH] D80660: clang: Add support for relative linker paths with -fuse-ld

keith updated this revision to Diff 267991. keith added a comment. Fix test on windows Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80660/new/ https://reviews.llvm.org/D80660 Files: clang/lib/Driver/ToolChain.cpp clang/test/Driver/fuse-ld.c

[PATCH] D81122: Reland: Use -fdebug-compilation-dir to form absolute paths in coverage mappings

keith created this revision. keith added reviewers: arphaman, vsk, rnk, cfe-commits, kastiglione. Herald added subscribers: llvm-commits, dexonsmith. Herald added projects: clang, LLVM. This reverts commit 62808631acceaa8b78f8ab9b407eb6b943ff5f77. This was previously reverted because llvm-cov's -

[PATCH] D81122: Reland: Use -fdebug-compilation-dir to form absolute paths in coverage mappings

keith updated this revision to Diff 268510. keith added a comment. Update relative paths to include the leading ./ This makes these remappings more analogous to lldb's source remapping, and makes using `-path-equivalence` with `llvm-cov` more familiar. Repository: rG LLVM Github Monorepo CHA

[PATCH] D81122: Reland: Use -fdebug-compilation-dir to form absolute paths in coverage mappings

keith added a comment. FYI I actually removed that piece this morning since I felt like since this now supports `-path-equivalence=.,foo` which is the "expected" behavior from lldb, that was "good enough". lmk if you want me to add it back! Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D83015: [Driver] Add -fld-path= and deprecate -fuse-ld=/abs/path and -fuse-ld=rel/path

keith accepted this revision. keith added a comment. Awesome! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83015/new/ https://reviews.llvm.org/D83015 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D80660: clang: Add support for relative linker paths with -fuse-ld

keith abandoned this revision. keith added a comment. https://reviews.llvm.org/D83015 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80660/new/ https://reviews.llvm.org/D80660 ___ cfe-commits mailing li

[PATCH] D83154: clang: Add -fcoverage-prefix-map

keith created this revision. keith added reviewers: vsk, arphaman, rnk. Herald added a subscriber: dexonsmith. Herald added a project: clang. keith added a comment. Open question: I don't know how all the toolchains fit together, but I noticed that only Clang.cpp handles -fmacro-prefix-map, but C

[PATCH] D81122: Reland: Use -fdebug-compilation-dir to form absolute paths in coverage mappings

keith abandoned this revision. keith added a comment. https://reviews.llvm.org/D83154 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81122/new/ https://reviews.llvm.org/D81122 ___ cfe-commits mailing li

[PATCH] D83154: clang: Add -fcoverage-prefix-map

keith added a comment. Open question: I don't know how all the toolchains fit together, but I noticed that only Clang.cpp handles -fmacro-prefix-map, but Clang.cpp, FreeBSD.cpp, and Gnu.cpp all handle -fdebug-prefix-map. I wasn't sure which pattern I should follow here, so right now this only a

[PATCH] D83154: clang: Add -fcoverage-prefix-map

keith updated this revision to Diff 275506. keith added a comment. Fix tests on Windows Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83154/new/ https://reviews.llvm.org/D83154 Files: clang/include/clang/Basic/CodeGenOptions.h clang/include/cl

[PATCH] D83154: clang: Add -fcoverage-prefix-map

keith added a comment. I originally implemented this behavior behind `-fdebug-prefix-map` but there was some pushback, more context: https://lists.llvm.org/pipermail/cfe-dev/2020-June/065668.html Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83154

[PATCH] D119788: [AArch64] Add support for -march=native for Apple M1 CPU

This revision was automatically updated to reflect the committed changes. Closed by commit rGfcca10c69aaa: [AArch64] Add support for -march=native for Apple M1 CPU (authored by keith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119788/new/ https:

[PATCH] D100692: clang-tidy: discover binaries in build dir

keith added a comment. Herald added subscribers: cfe-commits, carlosgalvezp. Herald added a project: All. Ping, it seems like https://reviews.llvm.org/D101037 is stalled but the docs at this point state py >=3.6 is required for working on llvm so I think we're good here https://llvm.org/docs/Get

[PATCH] D119788: [AArch64] Add support for -march=native for Apple M1 CPU

keith updated this revision to Diff 414866. keith added a comment. Herald added a project: All. Update default to latest known CPU Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119788/new/ https://reviews.llvm.org/D119788 Files: clang/lib/Driver

[PATCH] D119788: [AArch64] Add support for -march=native for Apple M1 CPU

keith updated this revision to Diff 414878. keith added a comment. Fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119788/new/ https://reviews.llvm.org/D119788 Files: clang/lib/Driver/ToolChains/Arch/AArch64.cpp llvm/lib/Support/Host.cp

[PATCH] D100692: clang-tidy: discover binaries in build dir

keith updated this revision to Diff 414975. keith added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100692/new/ https://reviews.llvm.org/D100692 Files: clang-tools-extra/clang-tidy/tool/run-clang-tidy.py Index: clang-tools-e

[PATCH] D111579: [clang] Fix DIFile directory root on Windows

keith updated this revision to Diff 414976. keith added a comment. Herald added a project: All. Remove variables from test expectations This didn't work out because of the double vs single slash of the expansions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D111457: [test] Add lit helper for windows paths

keith added a comment. Herald added a project: All. @compnerd can you re-review here? I think I covered your feedback, let me know! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111457/new/ https://reviews.llvm.org/D111457

[PATCH] D111579: [clang] Fix DIFile directory root on Windows

keith updated this revision to Diff 415004. keith added a comment. Replace \w with . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111579/new/ https://reviews.llvm.org/D111579 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/CodeGen/debug-p

[PATCH] D111579: [clang] Fix DIFile directory root on Windows

keith added a comment. Ping, all green here, I just had to mess with the test regex a bit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111579/new/ https://reviews.llvm.org/D111579 ___ cfe-commits mailin

[PATCH] D100692: clang-tidy: discover binaries in build dir

This revision was automatically updated to reflect the committed changes. Closed by commit rG5da83eeb91ba: clang-tidy: discover binaries in build dir (authored by keith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100692/new/ https://reviews.llvm

[PATCH] D111457: [test] Add lit helper for windows paths

keith updated this revision to Diff 415290. keith added a comment. Update substitutions to use dashes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111457/new/ https://reviews.llvm.org/D111457 Files: llvm/docs/CommandGuide/lit.rst llvm/docs/Te

[PATCH] D111579: [clang] Fix DIFile directory root on Windows

keith updated this revision to Diff 415291. keith marked an inline comment as done. keith added a comment. Update subsitutions with dashes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111579/new/ https://reviews.llvm.org/D111579 Files: clang/li

[PATCH] D111587: re-land: [clang] Fix absolute file paths with -fdebug-prefix-map

keith updated this revision to Diff 415292. keith added a comment. Herald added a project: All. Update subsitutions with slashes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111587/new/ https://reviews.llvm.org/D111587 Files: clang/lib/CodeGen/

[PATCH] D111457: [test] Add lit helper for windows paths

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6541d3e979c1: [test] Add lit helper for windows paths (authored by keith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D119788: [AArch64] Add support for -march=native for Apple M1 CPU

keith added a comment. Bump, I think I've covered everything here, let me know if not! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119788/new/ https://reviews.llvm.org/D119788 ___ cfe-commits mailing l

[PATCH] D111579: [clang] Fix DIFile directory root on Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rGcb22d71806b7: [clang] Fix DIFile directory root on Windows (authored by keith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111579/new/ https://reviews.ll

[PATCH] D111587: re-land: [clang] Fix absolute file paths with -fdebug-prefix-map

keith updated this revision to Diff 415307. keith added a comment. Fix tests with dwarf 6 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111587/new/ https://reviews.llvm.org/D111587 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/CodeGen/re

[PATCH] D121663: reland: [clang] Don't append the working directory to absolute paths

keith created this revision. keith added a reviewer: aprantl. Herald added a project: All. keith requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This fixes a bug that happens when using -fdebug-prefix-map to remap an absolute path to a rela

[PATCH] D111587: re-land: [clang] Fix absolute file paths with -fdebug-prefix-map

keith added a comment. I actually mean dwarf 6, which appears to be partially implemented according to https://lists.llvm.org/pipermail/llvm-dev/2020-April/141055.html I discovered the issue from the failed tests on https://reviews.llvm.org/D113718 where you can see the test output contains a

[PATCH] D111587: re-land: [clang] Fix absolute file paths with -fdebug-prefix-map

keith added inline comments. Comment at: clang/test/Modules/module-debuginfo-prefix.m:24 -// Dir should always be empty, but on Windows we can't recognize /var -// as being an absolute path. -// CHECK: !DIFile(filename: "/OVERRIDE/DebugObjC.h", directory: "{{()|(.*:.*)}}") +//

[PATCH] D111587: re-land: [clang] Fix absolute file paths with -fdebug-prefix-map

keith added a comment. You're right it's version 5 not 4, maybe the issue is that some platforms (like macOS) are defaulting to 4 intentionally for now? I guess I thought 6 because passing 6 also reproduces, but I didn't also try 5. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D121663: reland: [clang] Don't append the working directory to absolute paths

This revision was automatically updated to reflect the committed changes. Closed by commit rGa2db7d5e9c52: reland: [clang] Don't append the working directory to absolute paths (authored by keith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121663/

[PATCH] D111587: re-land: [clang] Fix absolute file paths with -fdebug-prefix-map

keith abandoned this revision. keith added a comment. There were 2 competing revisions for this bug fix, I landed https://reviews.llvm.org/D121663 instead since it sounds like having an empty `directory` is more correct in this case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D117937: [VFS] Add a "redirecting-with" field to overlays

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG502f14d6f2ee: [VFS] Add a "redirecting-with" field to overlays (authored by bnbarham, committed by keith). Changed prior to commit: https://review

[PATCH] D119788: [AArch64] Add support for -march=native for Apple M1 CPU

keith created this revision. Herald added subscribers: dexonsmith, pengfei, hiraditya, kristof.beyls. keith requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This improves the getHostCPUName check for Apple M1

[PATCH] D119788: [AArch64] Add support for -march=native for Apple M1 CPU

keith added reviewers: beanz, efriedma. keith added a comment. Adding folks from https://reviews.llvm.org/D69597 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119788/new/ https://reviews.llvm.org/D119788 ___

[PATCH] D124767: [Clang] Map .gcda paths according to -fcoverage-prefix-map

keith added a comment. Based on the issue it sounds like this should be gated behind a new `-fprofile-prefix-map` flag? I assume we'd also want `-ffile-prefix-map` to apply to it as well, similar to the others. And we'll definitely want some tests here! Repository: rG LLVM Github Monorepo

[PATCH] D124767: [Clang] Map .gcda paths according to -fcoverage-prefix-map

keith added a comment. I took this comment from the issue: > Since the feature you're proposing is specific to gcov, using a separate flag > that matches the name used by GCC would be preferable to me. To mean that we should introduce a new flag matching gcc's name. I think in general fewer fl

[PATCH] D83154: clang: Add -fcoverage-prefix-map

keith added inline comments. Comment at: clang/lib/CodeGen/CoverageMappingGen.cpp:1334 + llvm::SmallString<256> Path(Filename); + llvm::sys::fs::make_absolute(Path); + llvm::sys::path::remove_dots(Path, /*remove_dot_dot=*/true); rnk wrote: > keith wrote: > > r

[PATCH] D83154: clang: Add -fcoverage-prefix-map

keith added inline comments. Comment at: clang/lib/CodeGen/CoverageMappingGen.cpp:1334 + llvm::SmallString<256> Path(Filename); + llvm::sys::fs::make_absolute(Path); + llvm::sys::path::remove_dots(Path, /*remove_dot_dot=*/true); phosek wrote: > andrewjcg wrote

[PATCH] D87928: Provide -fsource-dir flag in Clang

keith added a comment. In D87928#2282609 , @phosek wrote: > This change is trying to address the issues raised in D83154 > . There are still some open questions: > > - Is `-fsource-dir` the best name for this flag? I thin

[PATCH] D83154: clang: Add -fcoverage-prefix-map

keith added a comment. With D87928 do you think we would want this flag as well? The only difference I can think of (besides general UX) is if you need to remap paths outside of your source root, I believe having a `*-prefix-map` style flag makes that a bit mor

[PATCH] D83154: clang: Add -fcoverage-prefix-map

keith added a comment. Should we wait for that one to land and then pick this one up? Otherwise any thoughts on the outstanding discussion? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83154/new/ https://reviews.llvm.org/D83154 _

[PATCH] D83154: clang: Add -fcoverage-prefix-map

keith added a comment. Yes I do, sorry I've been a bit busy, I will try to get to this later this week Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83154/new/ https://reviews.llvm.org/D83154 ___ cfe-com

[PATCH] D83154: clang: Add -fcoverage-prefix-map

keith updated this revision to Diff 290610. keith retitled this revision from "clang: Add -fprofile-prefix-map" to "clang: Add -fcoverage-prefix-map". keith edited the summary of this revision. keith added a comment. Rename from fcoverage-prefix-map to fprofile-prefix-map Repository: rG LLVM

[PATCH] D83154: clang: Add -fcoverage-prefix-map

keith added inline comments. Comment at: clang/lib/CodeGen/CoverageMappingGen.cpp:1334 + llvm::SmallString<256> Path(Filename); + llvm::sys::fs::make_absolute(Path); + llvm::sys::path::remove_dots(Path, /*remove_dot_dot=*/true); rnk wrote: > Please only make t

[PATCH] D83154: clang: Add -fcoverage-prefix-map

keith updated this revision to Diff 290851. keith marked 2 inline comments as done. keith added a comment. Small fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83154/new/ https://reviews.llvm.org/D83154 Files: clang/include/clang/Basic/Code

[PATCH] D17922: [clang-format] Don't add a space before Obj-C selector methods that are also clang-format keywords

keith commandeered this revision. keith added a reviewer: ksuther. keith added a comment. Note the test case shown here passes on master, so we can drop this CHANGES SINCE LAST ACTION https://reviews.llvm.org/D17922/new/ https://reviews.llvm.org/D17922 ___

[PATCH] D91669: Don’t break before nested block param when prior param is not a block

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG244022a3cd75: Don’t break before nested block param when prior param is not a block (authored by segiddins, committed by keith). Repository: rG LL

[PATCH] D92357: clang/darwin: Don't use response files with ld64, do use them with ld64.lld.darwinnew

keith added a comment. Note in your repro case the issue is that the response file doesn't end in a trailing newline CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92357/new/ https://reviews.llvm.org/D92357 ___ cfe-commits mailing list cfe-co

[PATCH] D92357: clang/darwin: Don't use response files with ld64, do use them with ld64.lld.darwinnew

keith added a comment. It looks like at least in the `-Wl` case clang passes the file through directly, so I'm not surprises that it repros there: % clang -Wl,@shell_dialogs_unittests.rsp -v Apple clang version 12.0.0 (clang-1200.0.32.27) Target: x86_64-apple-darwin19.6.0 Thread model: p

[PATCH] D92357: clang/darwin: Don't use response files with ld64

keith added a comment. I'm a bit worried that without a repro case (outside of the missing newline) Apple won't get around to fixing this, and in the meantime I'm wondering if outside of the chromium build system folks will experience this. I wonder if there's an acceptable alternative here suc

[PATCH] D90430: [clang][NFC] Remove unused FileCheck prefix

keith created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. keith requested review of this revision. This is to enable --allow-unused-duplicates=false. This prefix appears to be outdated and intentionally unused. Repository: rG LLVM Github Monorepo http

[PATCH] D90430: [clang][NFC] Remove unused FileCheck prefix

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbbf02e18f536: [clang][NFC] Remove unused FileCheck prefix (authored by keith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D90646: [clang] Add warning when `-include-pch` is passed multiple times

keith created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. keith requested review of this revision. Previously this argument passed multiple times would result in the first being silently ignored. Repository: rG LLVM Github Monorepo https://reviews.llv

[PATCH] D83154: clang: Add -fprofile-prefix-map

keith updated this revision to Diff 319045. keith added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83154/new/ https://reviews.llvm.org/D83154 Files: clang/include/clang/Basic/CodeGenOptions.h clang/include/clang/Driver/Opt

[PATCH] D83154: [clang] Add -fprofile-prefix-map

keith closed this revision. keith added a comment. Something went wrong with this being attached to the commit (I believe because I committed from a different machine than I originally wrote this on), landed here https://github.com/llvm/llvm-project/commit/c3324450b204392169d4ec7172cb32f74c03e3

[PATCH] D95385: Revert "[clangd][NFC] Simplify handing on methods with no params"

keith created this revision. keith added a reviewer: njames93. Herald added subscribers: usaxena95, kadircet, arphaman. keith requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. This broke the build http://lab.llvm.org:80

[PATCH] D95385: Revert "[clangd][NFC] Simplify handing on methods with no params"

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9d9ceb37453f: Revert "[clangd][NFC] Simplify handing on methods wi

[PATCH] D95385: Revert "[clangd][NFC] Simplify handing on methods with no params"

keith added a comment. No problem, thanks!! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95385/new/ https://reviews.llvm.org/D95385 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D90646: [clang] Add warning when `-include-pch` is passed multiple times

keith updated this revision to Diff 319138. keith added a comment. Herald added a reviewer: jansvoboda11. Add group to warning Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90646/new/ https://reviews.llvm.org/D90646 Files: clang/include/clang/Ba

[PATCH] D90646: [clang] Add warning when `-include-pch` is passed multiple times

keith added a comment. Fair question! I think this case is a bit different since it's quite subtle. The strange thing here is that the header you're intending to provide a pch for can still be read successfully, but not getting the benefits of the pch that you were expecting without knowing abo

[PATCH] D109461: [clang][darwin] Add support for --emit-static-lib

This revision was automatically updated to reflect the committed changes. Closed by commit rG80d62993d072: [clang][darwin] Add support for --emit-static-lib (authored by keith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109461/new/ https://revie

[PATCH] D90646: [clang] Add warning when `-include-pch` is passed multiple times

keith added a comment. Yea seems like a reasonable request, looking through the uses nothing immediately pops out as being not supporting multiple PCHs but I guess before I went down that path I'd want someone who knew the code better to agree on that Repository: rG LLVM Github Monorepo CHA

[PATCH] D103934: clang/darwin: use response files with ld64

keith created this revision. keith added a reviewer: thakis. keith requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This crasher was fixed with Xcode 13.0 beta 1 / ld64 705. This is an updated revert of https://reviews.llvm.org/D92357 Repo

[PATCH] D103934: clang/darwin: use response files with ld64

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1c7f3395b8ec: clang/darwin: use response files with ld64 (authored by keith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D101037: [clang-tidy] Change shebang from python to python3

keith added a comment. Doesn't seem like anything changed on the mailing list side, should we land this now? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101037/new/ https://reviews.llvm.org/D101037 __

[PATCH] D112767: [clang][driver] Fix multiarch output name with -Wl arg

keith created this revision. keith added reviewers: ddunbar, JDevlieghere. keith requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously if you passed a `-Wl,-foo` _before_ the source filename, the first `InputInfos`, which is used for t

[PATCH] D112767: [clang][driver] Fix multiarch output name with -Wl arg

keith updated this revision to Diff 383213. keith marked an inline comment as done. keith added a comment. Update comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112767/new/ https://reviews.llvm.org/D112767 Files: clang/lib/Driver/Driver.c

[PATCH] D109128: [VFS] Use original path when falling back to external FS

keith updated this revision to Diff 383406. keith added a comment. Remove broken test for now Turns out this fails on main as well, so I'll punt this to another change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109128/new/ https://reviews.llvm.

[PATCH] D109128: [VFS] Use original path when falling back to external FS

keith added a comment. @dexonsmith turns out the test I was adding is broken on main today too. If it's alright with you I will punt that to another diff to not increase the scope of this one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109128/n

[PATCH] D112767: [clang][driver] Fix multiarch output name with -Wl arg

This revision was automatically updated to reflect the committed changes. Closed by commit rGbd8a9507ef8c: [clang][driver] Fix multiarch output name with -Wl arg (authored by keith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112767/new/ https://

[PATCH] D109128: [VFS] Use original path when falling back to external FS

keith added a comment. @dexonsmith can you take another look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109128/new/ https://reviews.llvm.org/D109128 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D109128: [VFS] Use original path when falling back to external FS

keith added a comment. @JDevlieghere can you take another pass? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109128/new/ https://reviews.llvm.org/D109128 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D113645: [clangd] Allow Unix config paths on Darwin

keith created this revision. Herald added subscribers: dexonsmith, usaxena95, kadircet, arphaman, hiraditya. keith requested review of this revision. Herald added subscribers: cfe-commits, llvm-commits, MaskRay, ilya-biryukov. Herald added projects: LLVM, clang-tools-extra. It's common for CLIs on

[PATCH] D97434: [Driver] Rename -fprofile-{prefix-map,compilation-dir} to -fcoverage-{prefix-map,compilation-dir}

keith accepted this revision. keith added a comment. This revision is now accepted and ready to land. I personally prefer this, and this is what I landed in swiftc a while back, but I changed to -fprofile-prefix-map based on feedback from you 😛 https://reviews.llvm.org/D83154?id=275480#2146086

[PATCH] D97434: [Driver] Rename -fprofile-{prefix-map,compilation-dir} to -fcoverage-{prefix-map,compilation-dir}

keith added a comment. No worries! Makes sense, I think this is a good change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97434/new/ https://reviews.llvm.org/D97434 ___ cfe-commits mailing list cfe-com

[PATCH] D113645: [clangd] Allow Unix config paths on Darwin

keith added a comment. In D113645#3126652 , @kadircet wrote: > I got a couple of concerns about the general ideas in the change. Even though > the convenience of using ~/.config/clangd/config.yaml seems nice, I think > it'll just end up creating confusi

[PATCH] D109128: [VFS] Use original path when falling back to external FS

keith updated this revision to Diff 387030. keith added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109128/new/ https://reviews.llvm.org/D109128 Files: clang/test/VFS/relative-path-errors.c llvm/include/llvm/Support/Virtual

[PATCH] D109128: [VFS] Use original path when falling back to external FS

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc972175649f4: [VFS] Use original path when falling back to external FS (authored by keith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D113832: reland: [VFS] Use original path when falling back to external FS

keith created this revision. keith added a reviewer: dexonsmith. Herald added subscribers: pengfei, hiraditya. keith requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This reverts commit f0cf544d6f6fe6cbca4c07772998272d6bb43

[PATCH] D113832: reland: [VFS] Use original path when falling back to external FS

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG86e2af8043c7: reland: [VFS] Use original path when falling back to external FS (authored by keith). Repository: rG LLVM

[PATCH] D114842: [lld-macho] Remove old macho darwin lld

keith added a comment. I chose to remove the darwinnew / darwinold symlinks here as well. Let me know if you all think we should leave those around for a while for some reason Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114842/new/ https://revie

[PATCH] D114842: [lld-macho] Remove old macho darwin lld

keith added a comment. In D114842#3163232 , @MaskRay wrote: > Consider moving the clang driver change to a separate change so that the > removal is a more pure file deletion (other than some build system changes) Fair enough, I'll submit as a follow up

[PATCH] D114842: [lld-macho] Remove old macho darwin lld

keith added a comment. In D114842#3163229 , @int3 wrote: > lgtm. Could you make a post to llvm-dev before landing this? Thanks! Sent! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114842/new/ https://revi

[PATCH] D114842: [lld-macho] Remove old macho darwin lld

keith updated this revision to Diff 390908. keith added a comment. Herald added subscribers: dang, sstefan1, mgrang. Herald added a reviewer: jdoerfert. Herald added a project: lld-macho. Herald added a reviewer: lld-macho. More deletions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D114842: [lld-macho] Remove old macho darwin lld

keith updated this revision to Diff 390910. keith added a comment. Stragglers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114842/new/ https://reviews.llvm.org/D114842 Files: lld/CMakeLists.txt lld/include/lld/Common/Driver.h lld/include/ll

[PATCH] D114842: [lld-macho] Remove old macho darwin lld

keith updated this revision to Diff 390911. keith added a comment. Formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114842/new/ https://reviews.llvm.org/D114842 Files: lld/CMakeLists.txt lld/include/lld/Common/Driver.h lld/include/ll

[PATCH] D114842: [lld-macho] Remove old macho darwin lld

keith updated this revision to Diff 391065. keith marked an inline comment as done. keith added a comment. Remove lld/lib directory Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114842/new/ https://reviews.llvm.org/D114842 Files: lld/CMakeLists.

[PATCH] D114842: [lld-macho] Remove old macho darwin lld

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9e3552523ebd: [lld-macho] Remove old macho darwin lld (authored by keith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D114974: [clang][Darwin] Remove old lld implementation handling

keith created this revision. keith added reviewers: int3, MaskRay, oontvoo, thakis. keith requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This now assumes that for the darwin driver any lld is the "new" macho lld implementation. Repositor

[PATCH] D114974: [clang][Darwin] Remove old lld implementation handling

This revision was automatically updated to reflect the committed changes. Closed by commit rGace03d0df4fa: [clang][Darwin] Remove old lld implementation handling (authored by keith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114974/new/ https://

[PATCH] D126598: Fixed typo in hmaptool CMakeLists.txt

This revision was automatically updated to reflect the committed changes. Closed by commit rG50f2e4992456: [clang][cmake] Fixed typo in hmaptool CMakeLists.txt (authored by danielh2942, committed by keith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D147561: [clang] don't serialize MODULE_DIRECTORY with ModuleFileHomeIsCwd

keith accepted this revision. keith added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/Modules/module-file-home-is-cwd.m:7-8 // RUN: -o %t/mod.pcm // RUN: llvm-bcanalyzer --dump --disable-histogram %t/mod.pcm | FileCheck %s +// RU

  1   2   >