[PATCH] D47814: Teach libc++ to use native NetBSD's max_align_t

krytarowski added a comment. I saw this and I think that it shall be handled in libc++. NetBSD doesn't care if c++ runtime library is libstdc++, libc++, none or a different one. Repository: rL LLVM https://reviews.llvm.org/D47814 ___ cfe-commits

[PATCH] D47814: Teach libc++ to use native NetBSD's max_align_t

krytarowski added a comment. It's similar to MUSL, __DEFINED_max_align_t is musl specific and they don't care about libc++ or not on top of it. Repository: rL LLVM https://reviews.llvm.org/D47814 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D47814: Teach libc++ to use native NetBSD's max_align_t

krytarowski added a comment. ping^3 Repository: rL LLVM https://reviews.llvm.org/D47814 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D56554: [ELF] Add '-z nognustack' opt to suppress emitting PT_GNU_STACK

krytarowski added a comment. This looks good as an intermediate step to make lld saner. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56554/new/ https://reviews.llvm.org/D56554 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[PATCH] D39114: [XRay][darwin] Initial XRay in Darwin Support

krytarowski added inline comments. Comment at: compiler-rt/lib/xray/xray_x86_64.cc:25 + size_t Len = 0; + if (sysctlbyname("hw.cpufrequency_max", &CPUFreq, &Len, NULL, 0) == -1) { +Report("Unable to determine CPU frequency for TSC accounting; errno = %d\n", ---

[PATCH] D41054: Teach clang/NetBSD about additional dependencies for sanitizers

krytarowski created this revision. krytarowski added a project: Sanitizers. Sanitizers on NetBSD require additional linkage: - libutil for forkpty(3) - libexecinfo for backtrace(3) Sponsored by Repository: rL LLVM https://reviews.llvm.org/D41054 Files: lib/Driver/ToolChains/CommonArgs.c

[PATCH] D66361: Improve behavior in the case of stack exhaustion.

krytarowski added a comment. This change broke on NetBSD. http://lab.llvm.org:8011/builders/netbsd-amd64/builds/22003/steps/run%20unit%20tests/logs/FAIL%3A%20Clang%3A%3Astack-exhaustion.cpp (view as text) TEST 'Clang :: SemaTemplate/stack-exhaustion.cpp' FAILED

[PATCH] D66361: Improve behavior in the case of stack exhaustion.

krytarowski added a comment. In D66361#1656037 , @rsmith wrote: > In D66361#1655903 , @krytarowski > wrote: > > > This change broke on NetBSD. > > > > http://lab.llvm.org:8011/builders/netbsd-amd64/builds/22003/ste

[PATCH] D36378: Enable LLVM asan support for NetBSD/i386

krytarowski created this revision. krytarowski added a project: Sanitizers. Verified to work and useful to run check-asan, as this target tests 32-bit and 64-bit execution. Sponsored by Repository: rL LLVM https://reviews.llvm.org/D36378 Files: lib/Driver/ToolChains/NetBSD.cpp Index:

[PATCH] D36482: Enable SanitizerKind::Vptr on NetBSD/X86 and X86_64

krytarowski created this revision. krytarowski added a project: Sanitizers. vptr is required for ubsan, which is reported to work on NetBSD. Sponsored by Repository: rL LLVM https://reviews.llvm.org/D36482 Files: lib/Driver/ToolChains/NetBSD.cpp Index: lib/Driver/ToolChains/NetBSD.cpp

[PATCH] D36482: Enable SanitizerKind::Vptr on NetBSD/X86 and X86_64

krytarowski added a comment. check-ubsan -- Testing: 172 tests, 8 threads -- Testing: 0 .. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90.. Testing Time: 20.19s Expected Passes: 156 Unsupported Tests : 16 I will enable more options and extend this commit. Repository: rL LLVM

[PATCH] D36482: Enable SanitizerKind::Vptr on NetBSD/X86 and X86_64

krytarowski updated this revision to Diff 110420. krytarowski edited the summary of this revision. krytarowski added a comment. Enable more sanitizers. Repository: rL LLVM https://reviews.llvm.org/D36482 Files: lib/Driver/ToolChains/NetBSD.cpp Index: lib/Driver/ToolChains/NetBSD.cpp

[PATCH] D36482: Enable SanitizerKind::Vptr on NetBSD/X86 and X86_64

krytarowski added a comment. check-safestack -- Testing: 8 tests, 8 threads -- Testing: 0 .. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90.. Testing Time: 0.56s Expected Passes: 7 Unsupported Tests : 1 I will research how to add the requested tests. Repository: rL LLVM http

[PATCH] D36482: Enable bunch of sanitizers on NetBSD/X86 and X86_64

krytarowski updated this revision to Diff 110442. krytarowski edited the summary of this revision. krytarowski added a comment. Fix lsan entry. Add tests. Repository: rL LLVM https://reviews.llvm.org/D36482 Files: lib/Driver/ToolChains/NetBSD.cpp test/Driver/fsanitize.c Index: test/Dri

[PATCH] D36935: Enable libfuzzer on NetBSD/amd64

krytarowski created this revision. krytarowski added a project: Sanitizers. Enable SanitizerKind::Fuzzer and SanitizerKind::FuzzerNoLink on x86_64. Sponsored by Repository: rL LLVM https://reviews.llvm.org/D36935 Files: lib/Driver/ToolChains/NetBSD.cpp Index: lib/Driver/ToolChains/NetB

[PATCH] D70048: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld)

krytarowski added a comment. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70048/new/ https://reviews.llvm.org/D70048 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D70048: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld)

krytarowski added a comment. LLVM Release Schedule: 10.0.0: Jan 15, 2020: branch, then rc1 It would be nice to get a reply to my mail proposal before the branch.. so we could push the code for LLVM 10. (If it was lost, I can resend it) It can likely upset both sides, but with the proposal in th

[PATCH] D69755: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld)

krytarowski created this revision. krytarowski added reviewers: ruiu, joerg, mgorny, MaskRay. krytarowski added a project: lld. Herald added subscribers: llvm-commits, cfe-commits, fedor.sergeev, aheejin, emaste, dschuff. Herald added projects: clang, LLVM. The NetBSD target wraps the default Lin

[PATCH] D69755: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld)

krytarowski updated this revision to Diff 227593. krytarowski added a comment. - upload diff with wider context Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69755/new/ https://reviews.llvm.org/D69755 Files: clang/lib/Driver/ToolChain.cpp lld/

[PATCH] D69755: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld)

krytarowski marked an inline comment as done. krytarowski added inline comments. Comment at: lld/tools/nb.lld/nb.lld.cpp:94 + + // disable superfluous RUNPATH on NetBSD + args.push_back("--disable-new-dtags"); MaskRay wrote: > You can't use DT_RUNPATH probably

[PATCH] D69755: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld)

krytarowski added a comment. In D69755#1731394 , @MaskRay wrote: > I still have the feeling that such configurations should be added to > clangDriver/gcc specs or a shell script wrapper of lld. OK, as you allow now a shell wrapper of lld, this is a prog

[PATCH] D69755: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld)

krytarowski added a comment. I don't want to diverge this patch on offtopic or general discussion. Does it look good for landing? We need this support to be functional out of the box and as a part of LLVM. E.g. `clang -fuse-ld=` currently tries to call `ld.lld`, with this patch it will go throu

[PATCH] D69755: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld)

krytarowski added a comment. > burden with the upstream We are the part of mainstream and have 4 developers in LLVM + few others contributing. We run the NetBSD buildbot that builds and runs test of LLD. http://lab.llvm.org:8014/builders/netbsd-amd64 Repository: rG LLVM Github Monorepo CHA

[PATCH] D70048: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld)

krytarowski created this revision. krytarowski added reviewers: joerg, mgorny, ruiu, MaskRay. krytarowski added a project: lld. Herald added subscribers: llvm-commits, cfe-commits, mstorsjo, fedor.sergeev, aheejin, emaste, dschuff. Herald added projects: clang, LLVM. The NetBSD target wraps the d

[PATCH] D70048: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld)

krytarowski added a comment. Another approach to achieve the same goal as previous attempts. It is already better as it avoids two forks. Does this one look like fine for merging? The previous one for the reference: https://reviews.llvm.org/D69755 Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D70048: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld)

krytarowski updated this revision to Diff 228591. krytarowski added a comment. - fix a typo in a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70048/new/ https://reviews.llvm.org/D70048 Files: clang/lib/Driver/ToolChain.cpp lld/CMakeL

[PATCH] D69755: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld)

krytarowski abandoned this revision. krytarowski added a comment. Better patch in https://reviews.llvm.org/D70048 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69755/new/ https://reviews.llvm.org/D69755 __

[PATCH] D70048: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld)

krytarowski added a comment. Short summary: - FreeBSD/OpenBSD ship with mutations of the behavior of ELF/GNU/Linux in certain nits, we do the same with our driver. - MinGW ships with a frontend driver to COFF, we do the same with a driver to ELF/GNU/Linux. - Darwin ships with default search pat

[PATCH] D70048: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld)

krytarowski added a comment. ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70048/new/ https://reviews.llvm.org/D70048 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D70048: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld)

krytarowski added a reviewer: chandlerc. krytarowski added a comment. Ping? We are in the process of switching our buildbot to newer NetBSD snapshot (-8 to -9) and we keep waiting for this patch to land. If we could get this patch merged, we could build and link the whole LLVM with lld on NetB

[PATCH] D70048: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld)

krytarowski added a comment. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70048/new/ https://reviews.llvm.org/D70048 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D70958: [compiler-rt] [test] Disable ASLR on ASAN/MSAN/TSAN tests on NetBSD

krytarowski added a comment. In D70958#1767912 , @eugenis wrote: > Could this go into the common lit config in compiler-rt/test? Do you mean to run this for all tests in compiler-rt? We intend to disable it only when needed and prevent leaking regressio

[PATCH] D70958: [compiler-rt] [test] Disable ASLR on ASAN/MSAN/TSAN tests on NetBSD

krytarowski added inline comments. Comment at: compiler-rt/test/sanitizer_common/netbsd_commands/run_noaslr.sh:4 +PATH=${PATH}:/usr/sbin +paxctl +a "${1}" +exec "${@}" eugenis wrote: > krytarowski wrote: > > I propose to use `/usr/bin/paxctl` as it will be PATH a

[PATCH] D70048: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld)

krytarowski added a comment. We attempted to patch internally LLD rebasing our code for the buildbot purposes but LLD without being used rots quickly, see: https://reviews.llvm.org/D58892 We use LD as `ld` and there are no plans neither intentions to break it. It was already decided internally

[PATCH] D70048: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld)

krytarowski added a comment. @joerg works on the ELF loader and we just need to wait for him. We wrote our temporary patch, but it was not ideal as the long term solution. compiler-rt is nicely maintained from our perspective and we have almost feature parity with Linux. We maintain and develo

[PATCH] D70048: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld)

krytarowski added a comment. Stating it from a different side. If you do not care about GNU ld drop-in replacement property for Linux it's not our business, but we do care about this in NetBSD and we restrict this to our project only (from ELF targets). If you do not care about NetBSD, you sha

[PATCH] D70048: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld)

krytarowski added a comment. Herald added a subscriber: arichardson. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70048/new/ https://reviews.llvm.org/D70048 ___ cfe-commits mailing list cfe-comm

[PATCH] D70048: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld)

krytarowski added a comment. @MaskRay I will mail you off-list with one question. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70048/new/ https://reviews.llvm.org/D70048 ___ cfe-commits mailing list c

[PATCH] D73245: Depend stddef.h to provide max_align_t for C++11 and provide better fallback in

krytarowski added inline comments. Comment at: libcxx/include/new:240 return __align > __STDCPP_DEFAULT_NEW_ALIGNMENT__; +#elif defined(_LIBCPP_CXX03_LANG) + return __align > alignment_of<__libcpp_max_align_t>::value; ldionne wrote: > joerg wrote: > > ldionne

[PATCH] D34018: Support __float128 on NetBSD libstdc++ x86/x86_64

krytarowski planned changes to this revision. krytarowski added a comment. Rescheduled for future. Maybe I will need to check and improve how good is this i386 __float128 support. Repository: rL LLVM https://reviews.llvm.org/D34018 ___ cfe-commi

[PATCH] D35755: [Solaris] gcc toolchain handling revamp

krytarowski added a comment. In https://reviews.llvm.org/D35755#930789, @fedor.sergeev wrote: > In https://reviews.llvm.org/D35755#930030, @ro wrote: > > > What's the status here? This patch is required for my WIP > > sanitizers-on-Solaris work. > > > since @tstellar just resolved the only rema

[PATCH] D31375: Add docs for libunwind

krytarowski added inline comments. Comment at: docs/index.rst:51 +LinuxARM Clang, GCC EHABI +Bare Metal ARM Clang, GCC EHABI + NetBSD amd64 Clan

[PATCH] D34018: Support __float128 on NetBSD libstdc++ x86/x86_64

krytarowski added a comment. Joerg declines to take this patch as it is, as there is no compiler-rt support for __float128 on i386 in compiler-rt. GCC knows __float128 on i386, amd64, i64, hppa, powerpc [some variations]; currently I focus on i386/amd64. My proposal was to check if there is use

[PATCH] D35701: Break up Targets.cpp into a header/impl pair per target type[NFCI]

krytarowski added a comment. Bitrig has to be eliminated - it's dead upstream and will be removed from LLVM. (confirmed from ex developers, nobody needs it any more) https://reviews.llvm.org/D35701 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D35701: Break up Targets.cpp into a header/impl pair per target type[NFCI]

krytarowski added a comment. In https://reviews.llvm.org/D35701#816703, @erichkeane wrote: > In https://reviews.llvm.org/D35701#816680, @krytarowski wrote: > > > Bitrig has to be eliminated - it's dead upstream and will be removed from > > LLVM. (confirmed from ex developers, nobody needs it any

[PATCH] D41809: Clang counterpart change for fuzzer FreeBSD support

krytarowski added a comment. Looks good, please improve the description of the commit (and not your authorship that will be preserved in the commit message). Once accepted by another developer, I can commit it for you. https://reviews.llvm.org/D41809

[PATCH] D42017: Link sanitized programs on NetBSD with -lkvm

krytarowski created this revision. krytarowski added reviewers: joerg, vitalybuka, dvyukov. krytarowski added a project: Sanitizers. Herald added a subscriber: llvm-commits. kvm - kernel memory interface This set of functions is defined in the libkvm library. The kvm(3) functions are used in pro

[PATCH] D41809: Clang counterpart change for fuzzer FreeBSD support

krytarowski added a comment. Committed as SVN r. 322469. Repository: rL LLVM https://reviews.llvm.org/D41809 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42467: FreeBSD needs also execinfo and libutil

krytarowski added a comment. Do you plan to use MSan? If so, `-lkvm` might be useful as well. Comment at: lib/Driver/ToolChains/CommonArgs.cpp:552 CmdArgs.push_back("-ldl"); // Required for forkpty on some OSes + if (TC.getTriple().getOS() == llvm::Triple::NetBSD || --

[PATCH] D42467: FreeBSD needs also execinfo, libutil and libkvm

krytarowski added a comment. Please update the `-lutil` comment in the code according to the comment. I can land this for you once it will be accepted. Repository: rC Clang https://reviews.llvm.org/D42467 ___ cfe-commits mailing list cfe-commits

[PATCH] D42467: FreeBSD needs also execinfo, libutil and libkvm

krytarowski added a comment. In https://reviews.llvm.org/D42467#986280, @devnexen wrote: > In https://reviews.llvm.org/D42467#986279, @krytarowski wrote: > > > Please update the `-lutil` comment in the code according to the comment. I > > can land this for you once it will be accepted. > > > In

[PATCH] D42467: FreeBSD needs also execinfo, libutil and libkvm

krytarowski added a comment. I propose to skip now `-lkvm` and `-lutil` for FreeBSD. I'm researching now an option to rebuild these libraries against sanitizers and so stop teaching the world how to handle its API. Please keep these patches locally for now. Repository: rC Clang https://rev

[PATCH] D42310: Formalize FreeBSD support of compiler rt

krytarowski added a comment. What's wrong with the symlink approach? Repository: rC Clang https://reviews.llvm.org/D42310 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    1   2   3