[PATCH] D80294: Add support for vmsumudm

This revision was automatically updated to reflect the committed changes. Closed by commit rGa28e9f120860: [PowerPC] Add support for vmsumudm (authored by saghir, committed by kamaub). Changed prior to commit: https://reviews.llvm.org/D80294?vs=265332&id=265790#toc Repository: rG LLVM Github

[PATCH] D83500: [PowerPC][Power10] Implement custom codegen for the vec_replace_elt and vec_replace_unaligned builtins.

kamaub accepted this revision as: kamaub. kamaub added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83500/new/ https://reviews.llvm.org/D83500

[PATCH] D83364: [PowerPC][Power10] Implement Instruction definition and MC Tests for Load and Store VSX Vector with Zero or Sign Extend

kamaub accepted this revision. kamaub added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83364/new/ https://reviews.llvm.org/D83364 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D85545: [Diagnostics] Diagnose missing comma in string array initialization

kamaub added a comment. Hello, sorry but can you please revert this commit and recommit it when you have a fix or work around that doesn't break our bots: It breaks http://lab.llvm.org:8011/builders/ppc64le-lld-multistage-test/builds/11228 which builds with `-Werror` Please also note that it in

[PATCH] D85978: [clang-tools-extra] Added missing comma

kamaub accepted this revision. kamaub added a comment. This revision is now accepted and ready to land. This LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85978/new/ https://reviews.llvm.org/D85978

[PATCH] D122271: [Clang] -Wunused-but-set-variable warning - handle also pre/post unary operators

kamaub added a comment. This option appears to incorrectly warn warning that `unsigned NumEntries = getNumEntries();` is "set but not used" in llvm/include/llvm/ADT/DenseMap.h:129 and so it is breaking the ppc64le-ll

[PATCH] D122271: [Clang] -Wunused-but-set-variable warning - handle also pre/post unary operators

kamaub added a comment. I'm sorry I took so long to notify you but I need to bring these bots back to green as soon as possible, they have been broken too long. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122271/new/ https://reviews.llvm.org/D12

[PATCH] D105360: [PowerPC] Fix popcntb XL Compat Builtin for 32bit

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGde3956605a70: [PowerPC] Fix popcntb XL Compat Builtin for 32bit (authored by quinnp, committed by kamaub). Changed prior to commit: https://review

[PATCH] D106150: [PowerPC] swdiv_nochk Builtins for XL Compat

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0268e123bea5: [PowerPC] swdiv_nochk Builtins for XL Compat (authored by quinnp, committed by kamaub). Changed prior to commit: https://reviews.llv

[PATCH] D105984: [PowerPC] Restore FastMathFlags of Builder for Vector FDiv Builtins

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfd855c24c72c: [PowerPC] Restore FastMathFlags of Builder for Vector FDiv Builtins (authored by quinnp, committed by kamaub). Changed prior to commit

[PATCH] D105834: [PowerPC] Semachecking for XL compat builtin icbt

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG59d2ba2a3de9: [PowerPC] Semachecking for XL compat builtin icbt (authored by quinnp, committed by kamaub). Changed prior to commit: https://review

[PATCH] D121837: [OpenMP][FIX] Allow device constructors for AMD GPU

kamaub added a comment. The test cases added with this commit failed on clang-ppc64be-linux-lnt # 13809 could you please revert this change, and recommit with the test case corrected? thank you. Repository: rG LLVM Github Monorepo

[PATCH] D125499: Enabling the detection of devtoolset-11 toolchain.

kamaub created this revision. kamaub added reviewers: phosek, tstellar, nemanjai, lei. Herald added a project: All. kamaub requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. This patch allows systems to build the llvm-project with the

[PATCH] D125499: Enabling the detection of devtoolset-11 toolchain.

This revision was automatically updated to reflect the committed changes. Closed by commit rG99639e5a3e6e: Enabling the detection of devtoolset-11 toolchain. (authored by kamaub). Changed prior to commit: https://reviews.llvm.org/D125499?vs=429059&id=430013#toc Repository: rG LLVM Github Mon

[PATCH] D109902: [PowerPC] Improved codegen related to xscvdpsxws/xscvdpuxws

kamaub added a reviewer: kamaub. kamaub added a comment. This patch seems almost ready to land to me, I'm just a bit concerned about the testing coverage, is the little endian testing case suppose to target `pwr7` as the big endian test does? The default FileCheck line seems redundant to me, d

[PATCH] D109437: [PowerPC] FP compare and test XL compat builtins.

kamaub added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:3518 +// valid. The argument must be either a 'float' or a 'double'. +bool Sema::CheckPPCTestDataClassType(CallExpr *TheCall) { + QualType ArgType = TheCall->getArg(0)->getType(); lei wrot

[PATCH] D110824: [PowerPC] Fix to guard fetch and cas 64-bit builtin versions

kamaub created this revision. kamaub added reviewers: PowerPC, nemanjai, lei, amyk, stefanp. Herald added subscribers: shchenz, kbarton. kamaub requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The builtins: `__compare_and_swaplp`, `__fetch_a

[PATCH] D109599: [PowerPC][MMA] Allow MMA builtin types in pre-P10 compilation units

kamaub updated this revision to Diff 376300. kamaub added a comment. Rebasing this patch and addressing review comments An upstream commit removed the need for this patch to modify a few test cases so it has been rebased to remain up-to-date, also addressing review comments. Repository: rG LL

[PATCH] D110824: [PowerPC] Fix to guard fetch and cas 64-bit builtin versions

kamaub updated this revision to Diff 376312. kamaub added a comment. Rebasing patch to get past intermittent test-suite failure Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110824/new/ https://reviews.llvm.org/D110824 Files: clang/lib/Sema/Sema

[PATCH] D110824: [PowerPC] Fix to guard fetch and cas 64-bit builtin versions

kamaub updated this revision to Diff 376962. kamaub added a comment. Moving test case to correct file before commiting as request in review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110824/new/ https://reviews.llvm.org/D110824 Files:

[PATCH] D110824: [PowerPC] Fix to guard fetch and cas 64-bit builtin versions

This revision was automatically updated to reflect the committed changes. Closed by commit rG83289665200b: [PowerPC] Fix to guard fetch and cas 64-bit builtin versions (authored by kamaub). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110824/new/ h

[PATCH] D109599: [PowerPC][MMA] Allow MMA builtin types in pre-P10 compilation units

This revision was automatically updated to reflect the committed changes. Closed by commit rG8737c74fab3a: [PowerPC][MMA] Allow MMA builtin types in pre-P10 compilation units (authored by kamaub). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: ht

[PATCH] D109599: [PowerPC][MMA] Allow MMA builtin types in pre-P10 compilation units

kamaub marked an inline comment as done. kamaub added a comment. Updated an existing test for the backend with pwr8 and pwr9 be/le targets during commit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109599/new/ https://reviews.llvm.org/D109599 __

[PATCH] D113451: [PowerPC] [Clang] Enable Intel intrinsics support on FreeBSD

kamaub added a comment. Test case `clang/test/CodeGen/ppc-mm-malloc.c` fails on powerpc BE buildbots with this changeset https://lab.llvm.org/buildbot/#/builders/93/builds/6031 https://lab.llvm.org/buildbot/#/builders/100/builds/10836 https://lab.llvm.org/buildbot/#/builders/52/builds/12719 **

[PATCH] D135245: [clang][Tooling] Move STL recognizer to its own library

kamaub added a comment. This change causes a linking failure during the `check-all` testing of 'clang-tools-extra' on the clang-ppc64le-rhel #22596 and clang-ppc64le-linux-multistage #23864

[PATCH] D125499: Enabling the detection of devtoolset-11 toolchain.

kamaub added a comment. In D125499#3541689 , @tstellar wrote: > I'm curious what is your system configuration where this patch actually > allows for detection of devtoolset? I noticed that if clang and gcc are both > installed to /usr/, then driver wil

[PATCH] D143467: [PowerPC] Add target feature requirement to builtins

kamaub added a comment. Can you add a PowerPC codegen test case for `__attribute__((target(`? All of the updated test cases seem to only test `-target-feature`. The only test case we have for `__attribute((target(` is a sema test `./clang/test/Sema/ppc-attr-target-inline.c`. Converting the dele

[PATCH] D143467: [PowerPC] Add target feature requirement to builtins

kamaub requested changes to this revision. kamaub added a comment. This revision now requires changes to proceed. Sorry I should have requested changes before for this comment below, but I do want these test moved to codegen and expanded, please let me know if anything is unclear. In D143467#42

[PATCH] D143210: [PowerPC] Include vector bool and pixel when emitting lax warning

kamaub added a comment. We may also need an associated test case for the changed behaviour for using `areCompatibleVectorTypes()` instead of `areSameVectorElemTypes()`. The test coverage should display when warnings are emitted now that we account for vector bool, vector pixel and type qualifier

[PATCH] D143467: [PowerPC] Add target feature requirement to builtins

kamaub accepted this revision. kamaub added a comment. This revision is now accepted and ready to land. Hello, sorry for missing you ping and delaying the patch so long just for test case adjustments, thank you for addressing them. Everything LGTM but lei and I had one request that can be made be

[PATCH] D111229: [PowerPC][Builtin] Allowing __rlwnm to accept a variable as a shift parameter

kamaub created this revision. kamaub added reviewers: PowerPC, nemanjai, lei, stefanp. Herald added subscribers: shchenz, kbarton. kamaub requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The builtin __rlwnm is currently constrained to accept

[PATCH] D110934: [NFC] Update return type of vec_popcnt to vector unsigned.

kamaub added a comment. Yeah this LTGM as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110934/new/ https://reviews.llvm.org/D110934 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D110934: [NFC] Update return type of vec_popcnt to vector unsigned.

kamaub accepted this revision. kamaub added a comment. This revision is now accepted and ready to land. Yeah this LGTM as well, accidentally commented without accepting a moment before. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110934/new/ htt

[PATCH] D111229: [PowerPC][Builtin] Allowing __rlwnm to accept a variable as a shift parameter

kamaub updated this revision to Diff 379103. kamaub added a comment. Addressing review request to remove unnecessary testing line. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111229/new/ https://reviews.llvm.org/D111229 Files: clang/include/cl

[PATCH] D111229: [PowerPC][Builtin] Allowing __rlwnm to accept a variable as a shift parameter

kamaub updated this revision to Diff 379149. kamaub added a comment. Adding shift variable test case to `builtins-ppc-xlcompat-rotate.c` as per review comment request. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111229/new/ https://reviews.llvm.o

[PATCH] D111229: [PowerPC][Builtin] Allowing __rlwnm to accept a variable as a shift parameter

This revision was automatically updated to reflect the committed changes. Closed by commit rG89ec99c77894: [PowerPC][Builtin] Allowing __rlwnm to accept a variable as a shift parameter (authored by kamaub). Changed prior to commit: https://reviews.llvm.org/D111229?vs=379149&id=379375#toc Repos

[PATCH] D108302: [PowerPC] Fixed the crash due to early if conversion with fixed CR fields.

kamaub accepted this revision as: kamaub. kamaub added a comment. This LGTM, small nit on the comment, but that can be fixed on commit Comment at: llvm/lib/Target/PowerPC/PPCInstrInfo.cpp:1544 + // If the condition branch uses a physical register, then it cannot be turned +

[PATCH] D109599: [PowerPC][MMA] Allow MMA builtin types in pre-P10 compilation units

kamaub created this revision. kamaub added reviewers: PowerPC, nemanjai, lei, saghir, stefanp. Herald added subscribers: steven.zhang, shchenz, kbarton. kamaub requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch allows the use of__ve

[PATCH] D109599: [PowerPC][MMA] Allow MMA builtin types in pre-P10 compilation units

kamaub updated this revision to Diff 371954. kamaub added a comment. The condition for failing semantic chequing on mma builtins was incorrect, updating this patch to correctly check the semantics and associated testing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://