Re: [PATCH] D19194: fix for clang-tidy modernize-pass-by-value on copy constructor

2016-04-21 Thread Kamal Essoufi via cfe-commits
Kessoufi marked an inline comment as done. Kessoufi added a comment. Done http://reviews.llvm.org/D19194 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19194: fix for clang-tidy modernize-pass-by-value on copy constructor

2016-04-21 Thread Kamal Essoufi via cfe-commits
Kessoufi updated this revision to Diff 54524. Kessoufi added a comment. removed the redundant matcher http://reviews.llvm.org/D19194 Files: clang-tidy/modernize/PassByValueCheck.cpp Index: clang-tidy/modernize/PassByValueCheck.cpp =

Re: [PATCH] D19194: fix for clang-tidy modernize-pass-by-value on copy constructor

2016-04-23 Thread Kamal Essoufi via cfe-commits
Kessoufi updated this revision to Diff 54762. Kessoufi added a comment. - my previous fix was applied on the wrong location and accidentally worked. now applied on the right location - previous tests still pass - added a specific test to highlight my issue http://reviews.llvm.org/D19194 Files