[PATCH] D126651: [clang-diff] Fix getStmtValue when dealing with wide chars

2022-05-30 Thread Kaining Zhong via Phabricator via cfe-commits
PRESIDENT810 created this revision. PRESIDENT810 added reviewers: klimek, arphaman, johannes. Herald added a project: All. PRESIDENT810 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This fixes https://github.com/llvm/llvm-project/issues/5

[PATCH] D126651: [clang-diff] Fix getStmtValue when dealing with wide chars

2022-06-01 Thread Kaining Zhong via Phabricator via cfe-commits
PRESIDENT810 updated this revision to Diff 433375. PRESIDENT810 added a comment. Refactored some code and add support of U16 & U32 characters, as well as tests for them. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126651/new/ https://reviews.llvm.org/D126651 Files: clang/lib/Tooli

[PATCH] D126651: [clang-diff] Fix getStmtValue when dealing with wide chars

2022-06-06 Thread Kaining Zhong via Phabricator via cfe-commits
PRESIDENT810 updated this revision to Diff 434690. PRESIDENT810 added a comment. More refactoring following Johannes's suggestion CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126651/new/ https://reviews.llvm.org/D126651 Files: clang/lib/Tooling/ASTDiff/ASTDiff.cpp clang/test/Tooli

[PATCH] D126651: [clang-diff] Fix getStmtValue when dealing with wide, UTF16 UTF32 chars

2022-06-06 Thread Kaining Zhong via Phabricator via cfe-commits
PRESIDENT810 updated this revision to Diff 434691. PRESIDENT810 retitled this revision from "[clang-diff] Fix getStmtValue when dealing with wide chars" to "[clang-diff] Fix getStmtValue when dealing with wide, UTF16 UTF32 chars". PRESIDENT810 edited the summary of this revision. CHANGES SINCE L

[PATCH] D126651: [clang-diff] Fix getStmtValue when dealing with wide, UTF16 UTF32 chars

2022-06-07 Thread Kaining Zhong via Phabricator via cfe-commits
PRESIDENT810 updated this revision to Diff 434717. PRESIDENT810 added a comment. Sorry! I'm a novice at LLVM and I just didn't realize that those types can be implicitly cast to ArrayRef ... I have changed those and it should be fine now! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D12