[PATCH] D75996: [clangd] Populate PreambleData::CompileCommand and make use of it inside buildPreamble

kadircet updated this revision to Diff 250149. kadircet added a comment. - Rebase on top of master Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75996/new/ https://reviews.llvm.org/D75996 Files: clang-tools-extra/clangd/Preamble.cpp clang-tool

[PATCH] D75996: [clangd] Populate PreambleData::CompileCommand and make use of it inside buildPreamble

This revision was automatically updated to reflect the committed changes. Closed by commit rGecd3e678bbb1: [clangd] Populate PreambleData::CompileCommand and make use of it inside… (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D76125: [clangd] Decouple preambleworker from astworker, NFCI

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, javed.absar, ilya-biryukov. Herald added a project: clang. First step to enable deferred preamble builds. Not intending to land it alone, will have f

[PATCH] D76098: [WIP] [clangd] Do not trigger go-to-def textual fallback inside string literals

kadircet added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:380 + TokenFlavor Flavor = getTokenFlavor(Loc, SM, AST.getLangOpts()); + // Only consider comment and (raw) identifier tokens. you can rather use `AST.getTokens().spelledTokenAt(Lo

[PATCH] D75687: [clangd] Only minimally escape text when rendering to markdown.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Comment at: clang-tools-extra/clangd/FormattedString.cpp:150 +// Not a delimiter if surrounded by space. +return !SpaceSurrounds(); + case '-': //

[PATCH] D75446: [clang][Syntax] Handle macro arguments in spelledForExpanded

kadircet added a comment. In D75446#1924496 , @sammccall wrote: > I think per offline discussion, this was going to have some additional docs > clarifying the contracts of this function, and maybe extra tests? > > The conclusion IIRC was that this functio

[PATCH] D76125: [clangd] Decouple preambleworker from astworker, NFCI

kadircet updated this revision to Diff 250705. kadircet marked 2 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76125/new/ https://reviews.llvm.org/D76125 Files: clang-tools-ex

[PATCH] D76125: [clangd] Decouple preambleworker from astworker, NFCI

kadircet marked 16 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/TUScheduler.cpp:218 +PreambleRequested.wait(Lock, [this] { return PreambleReq || Done; }); +// No request means we are done. +if (!PreambleReq)

[PATCH] D75687: [clangd] Only minimally escape text when rendering to markdown.

kadircet added a comment. thanks, still LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75687/new/ https://reviews.llvm.org/D75687 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[PATCH] D76304: [clangd] Update TUStatus api to accommodate preamble thread

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, javed.absar, ilya-biryukov. Herald added a project: clang. TUStatus api had a single thread in mind. This introudces a section action to represent st

[PATCH] D76125: [clangd] Decouple preambleworker from astworker, NFCI

kadircet marked 16 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/TUScheduler.cpp:265 + /// Updates the TUStatus and emits it. Only called in the worker thread. + void emitTUStatus(TUAction Action, +const TUStat

[PATCH] D76125: [clangd] Decouple preambleworker from astworker, NFCI

kadircet updated this revision to Diff 251011. kadircet marked 2 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76125/new/ https://reviews.llvm.org/D76125 Files: clang-tools-ex

[PATCH] D76125: [clangd] Decouple preambleworker from astworker, NFCI

kadircet updated this revision to Diff 251021. kadircet added a comment. - Reset CurrentReq inside run loop, rather than inside build. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76125/new/ https://reviews.llvm.org/D76125 Files: clang-tools-ex

[PATCH] D76304: [clangd] Update TUStatus api to accommodate preamble thread

kadircet added inline comments. Comment at: clang-tools-extra/clangd/TUScheduler.cpp:161 +/// update. +class TUStatusManager { +public: sammccall wrote: > nit: "manager" doesn't really explain what this is, and it's used both as the > class name and the main des

[PATCH] D76304: [clangd] Update TUStatus api to accommodate preamble thread

kadircet updated this revision to Diff 251022. kadircet marked 8 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76304/new/ https://reviews.llvm.org/D76304 Files: clang-tools-ex

[PATCH] D73780: [clangd] Separate protobuf-related functions to a dedicated file.

kadircet added a comment. In D73780#1851920 , @hokein wrote: > In D73780#1851654 , @kadircet wrote: > > > LG. I might be missing some context though, what's the reasoning behind? > > Because, I think it is not nece

[PATCH] D73453: Preserve -nostdinc and --sysroot when calling query driver

kadircet added a comment. it seems like the last diff is same as the previous one, maybe you've uploaded the wrong diff ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73453/new/ https://reviews.llvm.org/D73453 ___ cfe-commits mailing list

[PATCH] D73960: [clangd] Don't assert when completing a lambda variable inside the lambda.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Comment at: clang-tools-extra/clangd/CodeComplete.cpp:1007 Result.Quality = Signal; -Result.IDForDoc = -Result.Signature.documentation.empt

[PATCH] D73453: Preserve -nostdinc and --sysroot when calling query driver

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks let me know if you need me to commit this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73453/new/ https://reviews.llvm.org/D73453 __

[PATCH] D73453: Preserve -nostdinc and --sysroot when calling query driver

kadircet closed this revision. kadircet added a comment. closed by 6e8d6bc9ec8739ec22b73a23f740f171f452e234 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73453/new/ https://reviews.llvm.org/D73453

[PATCH] D73780: [clangd] Separate protobuf-related functions to a dedicated file.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: clang-tools-extra/clangd/SourceCode.cpp:1139 + // Double check that this is an actual protobuf header. + if (!SM.getBufferData(FID).startswith

[PATCH] D74036: [clangd] don't rename on protobuf symbols.

kadircet accepted this revision. kadircet added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:99 bool isBlacklisted(const NamedDecl &RenameDecl) { + if (isProtoFile(RenameDecl.getLocation(),

[PATCH] D73693: [clang][DeclPrinter] Implement visitors for {TemplateType,NonTypeTemplate}Parms

kadircet updated this revision to Diff 242883. kadircet added a comment. - Add unittests to ASTDeclPrinter Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73693/new/ https://reviews.llvm.org/D73693 Files: clang-tools-extra/clangd/unittests/FindTar

[PATCH] D74125: [clangd] Set "spelled" flag for constructor references.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:597 +bool IsTargetKind = NameKind == DeclarationName::Identifier || + NameKind == DeclarationName::CXXConstructorName; +bool Spelled = IdentifierToken && IsTarg

[PATCH] D74127: [clangd] Bump index version number.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. i've thought change introducing `RefKind::Spelled` would've already bumped it. Please make sure to bump it only if it didn't Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D73696: [clang][Index] Introduce a TemplateParm SymbolKind

kadircet updated this revision to Diff 243091. kadircet marked 2 inline comments as done. kadircet added a comment. - As discussed offline, do not expose new symbol kinds to libclang - Set types for templateparms in HoverInfo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D73696: [clang][Index] Introduce a TemplateParm SymbolKind

kadircet marked an inline comment as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/Protocol.cpp:265 case index::SymbolKind::Parameter: + case index::SymbolKind::TemplateParm: return SymbolKind::Variable; sammccall wrote: > th

[PATCH] D72304: [OpenMP][OMPIRBuilder] Add Directives (master and critical) to OMPBuilder.

kadircet added a comment. this breaks under asan http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/38597/steps/check-clang%20asan/logs/stdio Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72304/new/ https://reviews.llvm.org/D7230

[PATCH] D74555: [clangd] Add a flag for setting isIncomplete flag true in all responses

kadircet added a comment. some drive-by comments: if this is a client-specific option, wouldn't it be equally hard for client to just set this in the LSP layer, instead of telling clangd to do that? by looking at the current patch, it rather seems like a user-specific option, which will help u

[PATCH] D73696: [clang][Index] Introduce a TemplateParm SymbolKind

kadircet added a comment. ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73696/new/ https://reviews.llvm.org/D73696 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D73369: [clangd] Simplify "preferred" vs "definition" logic a bit in XRefs AST code.

kadircet added a comment. ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73369/new/ https://reviews.llvm.org/D73369 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D73693: [clang][DeclPrinter] Implement visitors for {TemplateType,NonTypeTemplate}Parms

This revision was automatically updated to reflect the committed changes. Closed by commit rGc45fb35b5e0b: [clang][DeclPrinter] Implement visitors for {TemplateType,NonTypeTemplate}Parms (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D73696: [clang][Index] Introduce a TemplateParm SymbolKind

kadircet updated this revision to Diff 244619. kadircet marked an inline comment as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73696/new/ https://reviews.llvm.org/D73696 Files: clang-tools-ex

[PATCH] D73696: [clang][Index] Introduce a TemplateParm SymbolKind

kadircet marked 3 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:98 + case SK::TemplateTypeParm: + case SK::TemplateTemplateParm: return CompletionItemKind::Class; hokein wrote: > I think thes

[PATCH] D73696: [clang][Index] Introduce a TemplateParm SymbolKind

This revision was automatically updated to reflect the committed changes. Closed by commit rG84240e0db8ab: [clang][Index] Introduce a TemplateParm SymbolKind (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73696/new/ https://re

[PATCH] D74609: [clangd] Update the CompletionItemKind.

kadircet accepted this revision. kadircet added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:106 + case SK::ConversionFunction: +return CompletionItemKind::Operator; case SK::Variable:

[PATCH] D74610: [clang][Index] Visit the default parameter arguements in libindex.

kadircet added a comment. Oh god, this code is a mess, so many knobs, and apparently I made it worst in the past sorry for that :D I totally understand if you want to make minimal changes to the code like this, but it would be great to simplify it a little bit without regressing too much, curr

[PATCH] D74610: [clang][Index] Visit the default parameter arguements in libindex.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, just wondering though if you've tried the solution we discussed offline regarding updating `indexTypeSourceInfo` instead of this call site, could you mention the results in here? So

[PATCH] D74731: [Clangd] Fixed assertion when processing extended ASCII characters.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/SourceCode.cpp:62 unsigned char C = static_cast(U8[I]); -if (LLVM_LIKELY(!(C & 0x80))) { // ASCII character. +if (LLVM_LIKELY(!(C & 0x100))) { // ASCII or extended ASCII character. if (CB(1,

[PATCH] D74731: [Clangd] Fixed assertion when processing extended ASCII characters.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/SourceCode.cpp:62 unsigned char C = static_cast(U8[I]); -if (LLVM_LIKELY(!(C & 0x80))) { // ASCII character. +if (LLVM_LIKELY(!(C & 0x100))) { // ASCII or extended ASCII character. if (CB(1,

[PATCH] D74731: [Clangd] Fixed assertion when processing extended ASCII characters.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/SourceCode.cpp:62 unsigned char C = static_cast(U8[I]); -if (LLVM_LIKELY(!(C & 0x80))) { // ASCII character. +if (LLVM_LIKELY(!(C & 0x100))) { // ASCII or extended ASCII character. if (CB(1,

[PATCH] D72826: [clangd] Make output order of allTargetDecls deterministic

kadircet updated this revision to Diff 238456. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72826/new/ https://reviews.llvm.org/D72826 Files: clang-tools-extra/clangd/FindTarget.cpp Index: clang-too

[PATCH] D72826: [clangd] Make output order of allTargetDecls deterministic

kadircet updated this revision to Diff 238469. kadircet marked 3 inline comments as done. kadircet added a comment. - Get rid of redundant sorting step Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72826/new/ https://reviews.llvm.org/D72826 Files:

[PATCH] D72826: [clangd] Make output order of allTargetDecls deterministic

kadircet added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:224 +using ValTy = std::pair; +llvm::SmallVector Result; +for (const auto &Elem : Decls) sammccall wrote: > no need for lookups I think > ``` > Result.resize(Decls.siz

[PATCH] D72826: [clangd] Make output order of allTargetDecls deterministic

This revision was automatically updated to reflect the committed changes. Closed by commit rGd54d71b67e60: [clangd] Make output order of allTargetDecls deterministic (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72826/new/ ht

[PATCH] D72498: [clangd] Print underlying type for decltypes in hover

kadircet updated this revision to Diff 238474. kadircet added a comment. - Handle return and parameter types as well Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72498/new/ https://reviews.llvm.org/D72498 Files: clang-tools-extra/clangd/Hover.c

[PATCH] D72840: [clangd] Make define outline code action visible

kadircet created this revision. kadircet added reviewers: sammccall, usaxena95. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This got forgotten during the process. Repository: rG LLVM Github Monorepo https://reviews.llvm.org

[PATCH] D72840: [clangd] Make define outline code action visible

This revision was automatically updated to reflect the committed changes. Closed by commit rGa881fcafaa5a: [clangd] Make define outline code action visible (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72840/new/ https://revi

[PATCH] D72498: [clangd] Print underlying type for decltypes in hover

This revision was automatically updated to reflect the committed changes. Closed by commit rG0474fe465d8f: [clangd] Print underlying type for decltypes in hover (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72498/new/ https:/

[PATCH] D72883: [clangd][test] Disable a particular testcase in FindExplicitReferencesTest when LLVM_ENABLE_EXPENSIVE_CHECKS

kadircet added a comment. Hi @jkorous, reverting this as d54d71b67e60 should've fixed this. Please let us know if that's not the case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D72746: [clangd] Add a flag for implicit references in the Index

kadircet added a comment. In D72746#1827608 , @kbobyrev wrote: > I started using TokenBuffer, but I ran into the following issue: when I'm > creating `TokenBuffer` and `TokenCollector`, they do not contain any tokens. > `Preprocessor` does not seem to ha

[PATCH] D72715: [clang][CodeComplete] Propogate printing policy to FunctionDecl

This revision was automatically updated to reflect the committed changes. Closed by commit rG1f946ee2faba: [clang][CodeComplete] Propogate printing policy to FunctionDecl (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72715/new

[PATCH] D72638: [clangd] Fix rename for explicit destructor calls

kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/FindTargetTests.cpp:887 + public: + $1^operator int(); + }; could you rather have a conversion operator to a tag (like `struct Bar`), with

[PATCH] D73056: [clangd] Fix DocumentOutline for concepts

kadircet created this revision. kadircet added a reviewer: kbobyrev. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Fixes https://github.com/clangd/clangd/issues/256 Repository: rG LLVM Github Monorepo https://revie

[PATCH] D73056: [clangd] Fix DocumentOutline for concepts

This revision was automatically updated to reflect the committed changes. Closed by commit rGfb3d9153c01b: [clangd] Fix DocumentOutline for concepts (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73056/new/ https://reviews.llv

[PATCH] D73088: [clangd] Capture the missing injected class names in findExplicitReferences.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/FindTargetTests.cpp:736 + template + class $1^$2^Bar { +~$3^Bar(); looks like we are getting duplicates here Repository: rG LLVM Github M

[PATCH] D73088: [clangd] Capture the missing injected class names in findExplicitReferences.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang-tools-extra/clangd/unittests/FindTargetTests.cpp:736 + template + class $1^$2^Bar { +~$3^Bar();

[PATCH] D73101: [clangd] Do not duplicate TemplatedDecls in findExplicitReferences

kadircet created this revision. kadircet added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D73101 Files: clang-tools-extra/clangd/

[PATCH] D73101: [clangd] Do not duplicate TemplatedDecls in findExplicitReferences

kadircet updated this revision to Diff 239310. kadircet added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73101/new/ https://reviews.llvm.org/D73101 Files: clang-tools-extra/clangd/FindTarget.cpp clang-tools-extra/clangd/

[PATCH] D73101: [clangd] Do not duplicate TemplatedDecls in findExplicitReferences

kadircet marked 3 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:584 +void VisitRedeclarableTemplateDecl(const RedeclarableTemplateDecl *TD) { + // {Class,Function,Var,TypeAlias}TemplateDecls are visited as pa

[PATCH] D73101: [clangd] Do not duplicate TemplatedDecls in findExplicitReferences

kadircet marked 2 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:584 +void VisitRedeclarableTemplateDecl(const RedeclarableTemplateDecl *TD) { + // {Class,Function,Var,TypeAlias}TemplateDecls are visited as pa

[PATCH] D73101: [clangd] Do not duplicate TemplatedDecls in findExplicitReferences

kadircet updated this revision to Diff 239320. kadircet marked an inline comment as done. kadircet added a comment. - Filter out templateddecls in VisitNamedDecls, instead of defining a new Visit method. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D73110: [clangd] Drop returntype/type when hovering over type-ish names

kadircet created this revision. kadircet added reviewers: sammccall, ilya-biryukov. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay. Herald added a project: clang. Some names, e.g. constructor/destructor/conversions, already contain the type info, no need to duplicate

[PATCH] D73109: [clang][index] Index the injected class name types.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. Thanks this LG (please apply clang-format fixes though) Have you checked if this class is missing any other typelocs? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D73110: [clangd] Drop returntype/type when hovering over type-ish names

This revision was automatically updated to reflect the committed changes. Closed by commit rG1fbb1d6df011: [clangd] Drop returntype/type when hovering over type-ish names (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73110/new

[PATCH] D72746: [clangd] Add a flag for implicit references in the Index

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/Ref.h:34 + Spelled = 1 << 3, + All = Declaration | Definition | Reference | Spelled, }; hokein wrote: > The `All` now indicates all spelled refs. I think `All` should include both > no

[PATCH] D73101: [clangd] Do not duplicate TemplatedDecls in findExplicitReferences

kadircet updated this revision to Diff 239523. kadircet marked 2 inline comments as done. kadircet added a comment. - Update comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73101/new/ https://reviews.llvm.org/D73101 Files: clang-tools-ext

[PATCH] D73101: [clangd] Do not duplicate TemplatedDecls in findExplicitReferences

This revision was automatically updated to reflect the committed changes. Closed by commit rG9570f1e5a612: [clangd] Do not duplicate TemplatedDecls in findExplicitReferences (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73101/

[PATCH] D73177: [clang][CodeComplete] Make completion work after initializer lists

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added a project: clang. Herald added a subscriber: cfe-commits. CodeCompletion was not being triggered after successfully parsed initializer lists, e.g. cpp void foo(int, bool); void bar() { foo({1}^, false);

[PATCH] D73177: [clang][CodeComplete] Make completion work after initializer lists

kadircet updated this revision to Diff 239555. kadircet added a comment. - Add comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73177/new/ https://reviews.llvm.org/D73177 Files: clang/lib/Parse/ParseExpr.cpp clang/test/CodeCompletion/cal

[PATCH] D73199: [clangd] Errors in TestTU cause test failures unless suppressed with error-ok.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks for the cleanup! Comment at: clang-tools-extra/clangd/unittests/TestTU.cpp:84 + if (llvm::none_of(Files, [](const auto &KV) { +return llvm::StringRe

[PATCH] D73218: [clangd] Show background index status using LSP 3.15 work-done progress notifications

kadircet added inline comments. Comment at: clang-tools-extra/clangd/ClangdLSPServer.h:223 +// We've requested the client to create a progress bar. +// Meanwhile, the state is buffered in PendingBackgraundIndexProgress. +Creating, s/PendingBackgraundI

[PATCH] D73271: [clang][CodeComplete] Support for designated initializers

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D73271 Files: clang/include/clang/Parse/Parser.h clang/include/clang/Sema/Sema.h clang

[PATCH] D73177: [clang][CodeComplete] Make completion work after initializer lists

This revision was automatically updated to reflect the committed changes. Closed by commit rG24364cd12bbf: [clang][CodeComplete] Make completion work after initializer lists (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73177/

[PATCH] D73218: [clangd] Show background index status using LSP 3.15 work-done progress notifications

kadircet accepted this revision. kadircet added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/Protocol.cpp:383 + +llvm::json::Value toJSON(const WorkDoneProgressBegin &P) { + llvm::json::Object Result{ sam

[PATCH] D73336: [clangd][Hover] Change arrow in return type back to →

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Currently 🡺 is used in hover response to represent return types, but it is not widely available. Changi

[PATCH] D73336: [clangd][Hover] Change arrow in return type back to →

This revision was automatically updated to reflect the committed changes. Closed by commit rG1b996faa1575: [clangd][Hover] Change arrow in return type back to → (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73336/new/ https:/

[PATCH] D73344: [clangd][Hover] Handle uninstantiated templates

kadircet created this revision. kadircet added reviewers: hokein, sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Fixes https://github.com/clangd/clangd/issues/263 Repository: rG LLVM Github Monorepo https

[PATCH] D73450: [clangd] Add a symbol-name-based blacklist for rename.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:138 IsMainFileOnly = false; - bool IsIndexable = - isa(RenameDecl) && - SymbolCollector::shouldCollectSymbol( - cast(RenameDecl), RenameDecl.getASTContext(), -

[PATCH] D73451: [clangd] Update the include mappings for std symbols.

kadircet added a comment. we seem to be missing some symbols now, like `polymorphic_allocator` `random_shuffle` `gets` etc. and there seems to be a functional change to the parser. Are they intentional, if so why? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D73451: [clangd] Update the include mappings for std symbols.

kadircet added a comment. In D73451#1841595 , @hokein wrote: > In D73451#1841510 , @kadircet wrote: > > > we seem to be missing some symbols now, like `polymorphic_allocator` > > `random_shuffle` `gets` etc. > > >

[PATCH] D73453: Preserve -nostdinc and --sysroot when calling query driver

kadircet added a comment. Hi @topisani, thanks for working on clangd! Yes that bug fell through the cracks since the logs proposed in the comments were not making use of `-query-driver` option. Do you mind adding some logs to the bug report, without your patch so that we can clearly see its eff

[PATCH] D73271: [clang][CodeComplete] Support for designated initializers

kadircet updated this revision to Diff 240551. kadircet marked 7 inline comments as done. kadircet added a comment. - Propogate types in more cases - Add more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73271/new/ https://reviews.llvm.org/D

[PATCH] D73271: [clang][CodeComplete] Support for designated initializers

kadircet marked 7 inline comments as done. kadircet added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:2463 +PreferredType.enterVariableInit(Tok.getLocation(), ThisDecl); ExprResult Init(ParseBraceInitializer()); sammccall wrote: > oops,

[PATCH] D73344: [clangd][Hover] Handle uninstantiated templates

kadircet updated this revision to Diff 240559. kadircet marked 3 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73344/new/ https://reviews.llvm.org/D73344 Files: clang-tools-ex

[PATCH] D73369: [clangd] Simplify "preferred" vs "definition" logic a bit in XRefs AST code.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:257 const NamedDecl *Def = getDefinition(D); -const NamedDecl *Preferred = Def ? Def : D; +if (const NamedDecl *C = llvm::dyn_cast(D->getCanonicalDecl())) + D = C; Is

[PATCH] D73369: [clangd] Simplify "preferred" vs "definition" logic a bit in XRefs AST code.

kadircet added a comment. also please fix clang-tidy and format warnings Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73369/new/ https://reviews.llvm.org/D73369 ___ cfe-commits mailing list cfe-commit

[PATCH] D73450: [clangd] Add a symbol-name-based blacklist for rename.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:466 auto DeclsUnderCursor = locateDeclAt(AST, IdentifierToken->location()); if (DeclsUnderCursor.empty()) hokein wrote: > kadircet wrote: > > `locateDeclAt` is alread

[PATCH] D73367: [clangd] Go-to-definition on 'override' jumps to overridden method(s)

kadircet added a comment. please fix clang-format and tidy warnings Comment at: clang-tools-extra/clangd/XRefs.cpp:287 +// We may be overridding multiple methods - offer them all. +for (const NamedDecl* ND : CMD->overridden_methods()) { + AddResultDecl(

[PATCH] D73453: Preserve -nostdinc and --sysroot when calling query driver

kadircet added a comment. tests look good, but please upload the logs to the bug report for investigation. Comment at: clang-tools-extra/clangd/QueryDriverDatabase.cpp:137 +llvm::StringRef Arg = CommandLine[I]; +if (llvm::any_of(FlagsToPreserve, [&Arg](auto &&S) { retur

[PATCH] D71965: include missing for std::abort

kadircet closed this revision. kadircet added a comment. Looks like this has landed with https://github.com/llvm/llvm-project/commit/58592f6c49249293f79698cfcb31dba532e12603 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71965/new/ https://reviews.

[PATCH] D73344: [clangd][Hover] Handle uninstantiated templates

This revision was automatically updated to reflect the committed changes. Closed by commit rGa31a61dafeaa: [clangd][Hover] Handle uninstantiated templates (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73344/new/ https://revie

[PATCH] D73538: [clangd] Make bin/llvm-lit run standalone clangd tests

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov, mgorny. Herald added a project: clang. Currently clangd lit tests can't be run in isolation because we don't set some of the config pa

[PATCH] D73453: Preserve -nostdinc and --sysroot when calling query driver

kadircet added inline comments. Comment at: clang-tools-extra/clangd/QueryDriverDatabase.cpp:144 + }); + if (Found != std::end(ArgsToPreserve)) { +Arg.consume_front(*Found); nit: early exit with ``` if(Found == std::end(ArgsToPreserve)) co

[PATCH] D73450: [clangd] Add a symbol-name-based blacklist for rename.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:466 auto DeclsUnderCursor = locateDeclAt(AST, IdentifierToken->location()); if (DeclsUnderCursor.empty()) hokein wrote: > kadircet wrote: > > hokein wrote: > > > kadi

[PATCH] D73367: [clangd] Go-to-definition on 'override' jumps to overridden method(s)

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. Thanks, LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73367/new/ https://reviews.llvm.org/D73367 ___

[PATCH] D73450: [clangd] Add a symbol-name-based blacklist for rename.

kadircet accepted this revision. kadircet added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:225 TargetIDs.insert(SymbolID(USR)); - std::vector Results; nit: maybe revert this o

[PATCH] D73538: [clangd] Make bin/llvm-lit run standalone clangd tests

This revision was automatically updated to reflect the committed changes. Closed by commit rGcb74d2e1bdec: [clangd] Make bin/llvm-lit run standalone clangd tests (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73538/new/ https:

[PATCH] D73271: [clang][CodeComplete] Support for designated initializers

This revision was automatically updated to reflect the committed changes. kadircet marked 2 inline comments as done. Closed by commit rG42e9478e0bbb: [clang][CodeComplete] Support for designated initializers (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D73613: [clangd][Hover] Make tests hermetic by setting target triplet

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Fixes https://bugs.llvm.org/show_bug.cgi?id=44696 Repository: rG LLVM Github Monorepo https://revi

<    28   29   30   31   32   33   34   35   36   37   >