jlebar updated this revision to Diff 45305.
jlebar added a comment.
Rename test file.
http://reviews.llvm.org/D16331
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaExpr.cpp
test/SemaCUDA/va-arg.cu
Index: test/SemaCUDA/va-arg.cu
jlebar added inline comments.
Comment at: lib/Sema/SemaDeclAttr.cpp:3620-3629
@@ -3619,2 +3619,12 @@
}
+ if (const auto *Method = dyn_cast(FD)) {
+if (Method->isInstance()) {
+ S.Diag(Method->getLocStart(), diag::err_kern_is_nonstatic_method)
+ << Method;
+
Author: jlebar
Date: Tue Jan 19 18:27:00 2016
New Revision: 258264
URL: http://llvm.org/viewvc/llvm-project?rev=258264&view=rev
Log:
[CUDA] Bail, rather than crash, on va_arg in device code.
Reviewers: tra
Subscribers: echristo, jhen, cfe-commits
Differential Revision: http://reviews.llvm.org/D
Author: jlebar
Date: Tue Jan 19 18:26:57 2016
New Revision: 258263
URL: http://llvm.org/viewvc/llvm-project?rev=258263&view=rev
Log:
[CUDA] Only allow __global__ on free functions and static member functions.
Summary:
Warn for NVCC compatibility if you declare a static member function or
inline f
This revision was automatically updated to reflect the committed changes.
jlebar marked 2 inline comments as done.
Closed by commit rL258264: [CUDA] Bail, rather than crash, on va_arg in device
code. (authored by jlebar).
Changed prior to commit:
http://reviews.llvm.org/D16331?vs=45305&id=45325
This revision was automatically updated to reflect the committed changes.
jlebar marked 3 inline comments as done.
Closed by commit rL258263: [CUDA] Only allow __global__ on free functions and
static member functions. (authored by jlebar).
Changed prior to commit:
http://reviews.llvm.org/D16261
jlebar added a comment.
Fixed and submitted.
Repository:
rL LLVM
http://reviews.llvm.org/D16331
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jlebar created this revision.
jlebar added a reviewer: tra.
jlebar added subscribers: jhen, echristo, cfe-commits.
The code in CGCUDACall is largely based on a patch written by Eli
Bendersky:
http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20140324/210218.html
That patch implemented an L
jlebar updated this revision to Diff 45446.
jlebar added a comment.
Remove {} around an if statement.
http://reviews.llvm.org/D16372
Files:
lib/CodeGen/CGBuiltin.cpp
lib/CodeGen/CGCUDACall.cpp
lib/CodeGen/CMakeLists.txt
lib/CodeGen/CodeGenFunction.h
lib/Headers/__clang_cuda_runtime_wr
jlebar added inline comments.
Comment at: test/CodeGenCUDA/printf.cu:12
@@ +11,3 @@
+// Check a simple call to printf end-to-end.
+__device__ int CheckSimple() {
+ // CHECK: [[FMT:%[0-9]+]] = load{{.*}}%fmt
tra wrote:
> You may want to add a test case for printf(
jlebar updated this revision to Diff 45456.
jlebar marked 3 inline comments as done.
jlebar added a comment.
Address tra's review comments.
http://reviews.llvm.org/D16372
Files:
lib/CodeGen/CGBuiltin.cpp
lib/CodeGen/CGCUDABuiltin.cpp
lib/CodeGen/CMakeLists.txt
lib/CodeGen/CodeGenFunctio
jlebar created this revision.
jlebar added a reviewer: tra.
jlebar added subscribers: jhen, echristo, cfe-commits.
http://reviews.llvm.org/D16484
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaDecl.cpp
test/SemaCUDA/va-arg.cu
test/SemaCUDA/vararg.cu
Index: test/SemaCUDA/v
jlebar added inline comments.
Comment at: lib/Sema/SemaDecl.cpp:8291-8293
@@ +8290,5 @@
+// in device-side CUDA code.
+if (NewFD->isVariadic() && (NewFD->hasAttr() ||
+NewFD->hasAttr()) &&
+!(II && II->isStr("printf") && !D.isFunctio
jlebar updated this revision to Diff 45736.
jlebar marked an inline comment as done.
jlebar added a comment.
Add check for extern "C" printf -- we don't want to take just any printf!
http://reviews.llvm.org/D16484
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaDecl.cpp
tes
jlebar created this revision.
jlebar added a reviewer: tra.
jlebar added subscribers: cfe-commits, jhen, echristo.
No functional changes.
http://reviews.llvm.org/D16495
Files:
lib/Driver/Tools.cpp
Index: lib/Driver/Tools.cpp
===
jlebar created this revision.
jlebar added a reviewer: tra.
jlebar added subscribers: echristo, jhen, cfe-commits.
NVPTX doesn't support aliases, so don't generate them.
http://reviews.llvm.org/D16499
Files:
lib/Driver/Tools.cpp
test/Driver/cuda-constructor-alias.cu
Index: test/Driver/cuda-
jlebar created this revision.
jlebar added a reviewer: tra.
jlebar added subscribers: echristo, jhen, cfe-commits.
These aliases are done to support inline asm, but there's nothing we can
do: NVPTX doesn't support aliases.
http://reviews.llvm.org/D16501
Files:
lib/CodeGen/CodeGenModule.cpp
t
jlebar created this revision.
jlebar added a reviewer: tra.
jlebar added subscribers: echristo, jhen, cfe-commits.
CUDA (well, strictly speaking, NVPTX) doesn't support aliases.
http://reviews.llvm.org/D16502
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaDeclAttr.cpp
test/
jlebar added inline comments.
Comment at: test/SemaCUDA/alias.cu:1-2
@@ +1,3 @@
+// REQUIRES: x86-registered-target
+// REQUIRES: nvptx-registered-target
+// RUN: %clang_cc1 -triple nvptx-unknown-cuda -fsyntax-only -fcuda-is-device
-verify -DEXPECT_ERR %s
echrist
jlebar created this revision.
jlebar added a reviewer: tra.
jlebar added subscribers: echristo, cfe-commits, jhen.
When compiling CUDA, we run the frontend N times, once for each device
arch. This means that if you have a compile error in your file, you'll
see that error N times.
Relatedly, if p
jlebar added inline comments.
Comment at: test/SemaCUDA/alias.cu:1-2
@@ +1,3 @@
+// REQUIRES: x86-registered-target
+// REQUIRES: nvptx-registered-target
+// RUN: %clang_cc1 -triple nvptx-unknown-cuda -fsyntax-only -fcuda-is-device
-verify -DEXPECT_ERR %s
jlebar
Author: jlebar
Date: Sat Jan 23 15:28:08 2016
New Revision: 258640
URL: http://llvm.org/viewvc/llvm-project?rev=258640&view=rev
Log:
[CUDA] Use Triple::isNVPTX() instead of enumerating nvptx && nvptx64.
Summary: No functional changes.
Subscribers: tra, echristo, jhen, cfe-commits
Differential R
jlebar added a comment.
In http://reviews.llvm.org/D16495#334383, @echristo wrote:
> Probably qualifies as obvious. Also can you add some text to the assert
> while you're there?
Done in my local tree, will submit with that change.
http://reviews.llvm.org/D16495
__
Author: jlebar
Date: Sat Jan 23 15:28:10 2016
New Revision: 258641
URL: http://llvm.org/viewvc/llvm-project?rev=258641&view=rev
Log:
[CUDA] Reject the alias attribute in CUDA device code.
Summary: CUDA (well, strictly speaking, NVPTX) doesn't support aliases.
Reviewers: echristo
Subscribers: cf
Author: jlebar
Date: Sat Jan 23 15:28:17 2016
New Revision: 258643
URL: http://llvm.org/viewvc/llvm-project?rev=258643&view=rev
Log:
[CUDA] Disallow variadic functions other than printf in device code.
Reviewers: tra
Subscribers: cfe-commits, echristo, jhen
Differential Revision: http://reviews
This revision was automatically updated to reflect the committed changes.
Closed by commit rL258641: [CUDA] Reject the alias attribute in CUDA device
code. (authored by jlebar).
Changed prior to commit:
http://reviews.llvm.org/D16502?vs=45783&id=45809#toc
Repository:
rL LLVM
http://reviews.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL258640: [CUDA] Use Triple::isNVPTX() instead of enumerating
nvptx && nvptx64. (authored by jlebar).
Changed prior to commit:
http://reviews.llvm.org/D16495?vs=45775&id=45808#toc
Repository:
rL LLVM
This revision was automatically updated to reflect the committed changes.
Closed by commit rL258643: [CUDA] Disallow variadic functions other than printf
in device code. (authored by jlebar).
Changed prior to commit:
http://reviews.llvm.org/D16484?vs=45736&id=45811#toc
Repository:
rL LLVM
h
Author: jlebar
Date: Sat Jan 23 15:28:14 2016
New Revision: 258642
URL: http://llvm.org/viewvc/llvm-project?rev=258642&view=rev
Log:
[CUDA] Make printf work.
Summary:
The code in CGCUDACall is largely based on a patch written by Eli
Bendersky:
http://lists.llvm.org/pipermail/llvm-commits/Week-of-
This revision was automatically updated to reflect the committed changes.
Closed by commit rL258642: [CUDA] Make printf work. (authored by jlebar).
Changed prior to commit:
http://reviews.llvm.org/D16372?vs=45456&id=45810#toc
Repository:
rL LLVM
http://reviews.llvm.org/D16372
Files:
cfe/t
jlebar added a comment.
In http://reviews.llvm.org/D16501#335225, @tra wrote:
> Failing silently is not a good idea. At the very least there should produce
> an error.
> The right thing to do here, IMO, would be to generate a stub with alias name
> that just jumps to or calls aliasee.
Discus
jlebar created this revision.
jlebar added a reviewer: tra.
jlebar added subscribers: bkramer, echristo, jhen, cfe-commits.
Turns out the variadic function checking added in r258643 was too strict
for some existing users; give them an escape valve. When
-fcuda-allow-variadic-functions is passed,
Author: jlebar
Date: Mon Jan 25 16:36:37 2016
New Revision: 258734
URL: http://llvm.org/viewvc/llvm-project?rev=258734&view=rev
Log:
[CUDA] Don't generate aliases for static extern "C" functions.
Summary:
These aliases are done to support inline asm, but there's nothing we can
do: NVPTX doesn't s
This revision was automatically updated to reflect the committed changes.
Closed by commit rL258734: [CUDA] Don't generate aliases for static extern "C"
functions. (authored by jlebar).
Changed prior to commit:
http://reviews.llvm.org/D16501?vs=45781&id=45919#toc
Repository:
rL LLVM
http://
This revision was automatically updated to reflect the committed changes.
Closed by commit rL258733: [CUDA] Disable ctor/dtor aliases in device code.
(authored by jlebar).
Changed prior to commit:
http://reviews.llvm.org/D16499?vs=45779&id=45918#toc
Repository:
rL LLVM
http://reviews.llvm.o
Author: jlebar
Date: Mon Jan 25 16:36:35 2016
New Revision: 258733
URL: http://llvm.org/viewvc/llvm-project?rev=258733&view=rev
Log:
[CUDA] Disable ctor/dtor aliases in device code.
Summary: NVPTX doesn't support aliases, so don't generate them.
Reviewers: tra
Subscribers: cfe-commits, jhen, ec
Author: jlebar
Date: Mon Jan 25 16:52:31 2016
New Revision: 258737
URL: http://llvm.org/viewvc/llvm-project?rev=258737&view=rev
Log:
[CUDA] Add -target to cuda-constructor-alias.cu test so it doesn't fail on Mac.
The test was checking that we passed -mconstructor-alias to host
compilation, but th
Author: jlebar
Date: Tue Jan 26 11:47:20 2016
New Revision: 258822
URL: http://llvm.org/viewvc/llvm-project?rev=258822&view=rev
Log:
[CUDA] Add -fcuda-allow-variadic-functions.
Summary:
Turns out the variadic function checking added in r258643 was too strict
for some existing users; give them an
This revision was automatically updated to reflect the committed changes.
Closed by commit rL258822: [CUDA] Add -fcuda-allow-variadic-functions.
(authored by jlebar).
Changed prior to commit:
http://reviews.llvm.org/D16559?vs=45915&id=46005#toc
Repository:
rL LLVM
http://reviews.llvm.org/D1
jlebar added a comment.
Missing (?) functions:
- div, ldiv, lldiv, imaxdiv
- imaxabs
If you left these out intentionally (I forget if nvidia supports div_t), that's
probably fine, but maybe add a comment?
wrt the "::" comments, some are nits because I think we end up calling the
right thing,
jlebar accepted this revision.
This revision is now accepted and ready to land.
Comment at: lib/Headers/__clang_cuda_cmath.h:222
@@ +221,3 @@
+__DEVICE__ void free(void *__ptr) { return ::free(__ptr); }
+__DEVICE__ void *malloc(size_t __size) { return ::malloc(__size); }
+
---
jlebar added a comment.
Friendly ping.
http://reviews.llvm.org/D16514
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jlebar created this revision.
jlebar added a reviewer: rnk.
jlebar added subscribers: tra, echristo, jhen, cfe-commits.
This is necessary to prevent llvm from generating stacksave intrinsics
around this alloca. NVVM doesn't have a stack, and we don't handle said
intrinsics.
I'm not sure if appen
jlebar updated this revision to Diff 46293.
jlebar added a comment.
Address echristo's review comments.
http://reviews.llvm.org/D16664
Files:
lib/CodeGen/CGCUDABuiltin.cpp
test/CodeGenCUDA/printf.cu
Index: test/CodeGenCUDA/printf.cu
=
jlebar marked an inline comment as done.
Comment at: lib/CodeGen/CGCUDABuiltin.cpp:109
@@ -106,1 +108,3 @@
+// stacksave/stackrestore intrinsics, which cause ptxas to choke.
+auto *Alloca = new llvm::AllocaInst(
llvm::Type::getInt8Ty(Ctx), llvm::ConstantInt::get(I
jlebar marked an inline comment as done.
jlebar added a comment.
http://reviews.llvm.org/D16664
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jlebar updated this revision to Diff 46300.
jlebar marked an inline comment as done.
jlebar added a comment.
Address tra's review comment (rename flag).
http://reviews.llvm.org/D16514
Files:
include/clang/Driver/Compilation.h
include/clang/Driver/Driver.h
include/clang/Driver/Options.td
jlebar added inline comments.
Comment at: lib/Driver/Driver.cpp:650
@@ -638,3 +649,3 @@
SmallVector, 4> FailingCommands;
- C.ExecuteJobs(C.getJobs(), FailingCommands);
+ C.ExecuteJobs(C.getJobs(), /* StopOnFailure = */ false, FailingCommands);
tra wrote:
>
jlebar added a comment.
In http://reviews.llvm.org/D16514#338631, @echristo wrote:
> In general it feels like keeping 2 errors might make the most sense:
>
> #if _NOT_ARCH4_
> #error "aiee!"
> #endif
>
> clang -arch arch1 -arch arch2 -arch arch3 -arch arch4 t.c
>
> seems like it might be nice t
jlebar updated this revision to Diff 46314.
jlebar marked an inline comment as done.
jlebar added a comment.
Use a struct rather than an i8 buffer.
http://reviews.llvm.org/D16664
Files:
lib/CodeGen/CGCUDABuiltin.cpp
test/CodeGenCUDA/printf.cu
Index: test/CodeGenCUDA/printf.cu
=
jlebar marked 3 inline comments as done.
jlebar added a comment.
Thank you for the reviews.
Please have another look; I switched to using a struct proper. It's a lot
cleaner! We're now assuming that the struct is aligned in the same way as
vprintf wants, but if anything I expect this new code
jlebar updated this revision to Diff 46315.
jlebar marked 3 inline comments as done.
jlebar added a comment.
Pass StopOnFailure = true when running the preprocessor after an ICE.
http://reviews.llvm.org/D16514
Files:
include/clang/Driver/Compilation.h
include/clang/Driver/Driver.h
include
jlebar added inline comments.
Comment at: lib/Driver/Driver.cpp:652
@@ -640,3 +651,3 @@
SmallVector, 4> FailingCommands;
- C.ExecuteJobs(C.getJobs(), FailingCommands);
+ C.ExecuteJobs(C.getJobs(), /* StopOnFailure = */ false, FailingCommands);
tra wrote:
>
jlebar marked an inline comment as done.
Comment at: lib/CodeGen/CGCUDABuiltin.cpp:87
@@ +86,3 @@
+ // Construct and fill the args buffer that we'll pass to vprintf.
+ llvm::Value* BufferPtr;
+ if (Args.size() <= 1) {
echristo wrote:
> * on the wrong side ;)
Ar
This revision was automatically updated to reflect the committed changes.
jlebar marked an inline comment as done.
Closed by commit rL259122: [CUDA] Generate CUDA's printf alloca in its
function's entry block. (authored by jlebar).
Changed prior to commit:
http://reviews.llvm.org/D16664?vs=4631
Author: jlebar
Date: Thu Jan 28 17:58:28 2016
New Revision: 259122
URL: http://llvm.org/viewvc/llvm-project?rev=259122&view=rev
Log:
[CUDA] Generate CUDA's printf alloca in its function's entry block.
Summary:
This is necessary to prevent llvm from generating stacksave intrinsics
around this allo
Do you have a script that will take as input a commit range and git
commit --amend clang-tidy fixes for lines modified in that range?
Because if so,
a) I would be your best friend forever, and
b) It should be simple to convert that into a linter for arc to catch
the case when I forget to run said
Hm, well,
https://llvm.org/svn/llvm-project/cfe/trunk/tools/clang-format/git-clang-format
is close... Not sure if that triggers the bff clause, will consult my
attorney.
On Thu, Jan 28, 2016 at 4:09 PM, Justin Lebar wrote:
> Do you have a script that will take as input a commit range and git
>
jlebar added a comment.
Eric, are you OK with this going in, or do you want to consider alternatives?
http://reviews.llvm.org/D16514
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jlebar added a comment.
jingyue/jpienaar/rsmith - friendly ping? Without this, -O0 builds don't work,
because they emit empty global initializers that don't get optimized out.
http://reviews.llvm.org/D15305
___
cfe-commits mailing list
cfe-commits
jlebar added a comment.
Talking to echristo irl, he would like to know why we don't have this problem
with mac universal binaries -- or, do we? He would like to be consistent; I'm
onboard with that.
http://reviews.llvm.org/D16514
___
cfe-commits
jlebar wrote:
@Artem-B
https://github.com/llvm/llvm-project/pull/96561
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jlebar wrote:
@Artem-B
https://github.com/llvm/llvm-project/pull/96015
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Daniele Castagna
Date: 2022-01-28T14:50:39-08:00
New Revision: 6eb826567af03c2b43cda78836b1065e12df84e4
URL:
https://github.com/llvm/llvm-project/commit/6eb826567af03c2b43cda78836b1065e12df84e4
DIFF:
https://github.com/llvm/llvm-project/commit/6eb826567af03c2b43cda78836b1065e12df84e4.di
Author: Shangwu Yao
Date: 2022-02-24T20:51:43-08:00
New Revision: c2f501f39589a59db9cebc839d0a63dcdc3c5c81
URL:
https://github.com/llvm/llvm-project/commit/c2f501f39589a59db9cebc839d0a63dcdc3c5c81
DIFF:
https://github.com/llvm/llvm-project/commit/c2f501f39589a59db9cebc839d0a63dcdc3c5c81.diff
L
I guess you need me or Michael to push this. Happy to do so once you're
happy with it.
On Mon, Apr 12, 2021 at 11:33 AM Daniele Castagna via Phabricator <
revi...@reviews.llvm.org> wrote:
> dcastagna updated this revision to Diff 336912.
> dcastagna added a comment.
>
> clang-format again
>
>
>
Author: Daniele Castagna
Date: 2021-04-12T13:15:14-07:00
New Revision: 7dd60688992526bb7ee0c7846e9abd591fc3e297
URL:
https://github.com/llvm/llvm-project/commit/7dd60688992526bb7ee0c7846e9abd591fc3e297
DIFF:
https://github.com/llvm/llvm-project/commit/7dd60688992526bb7ee0c7846e9abd591fc3e297.di
jlebar wrote:
@Artem-B asked me to review nvptx patches while he's OOO, but this one is
pretty far outside my depth. Are you OK waiting until he's back? I don't know
exactly when that will be, but based on his IMs to me, he should be back early
July.
https://github.com/llvm/llvm-project/pul
https://github.com/jlebar requested changes to this pull request.
This needs to be documented in the langref in this section, right?
https://llvm.org/docs/LangRef.html#supported-constraint-code-list
https://github.com/llvm/llvm-project/pull/97113
___
https://github.com/jlebar commented:
LGTM other than the previous comment.
https://github.com/llvm/llvm-project/pull/97113
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jlebar wrote:
> Which file should I modify?
Use `git grep` to find where the text from that section of the langref lives?
https://github.com/llvm/llvm-project/pull/97113
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cg
https://github.com/jlebar approved this pull request.
https://github.com/llvm/llvm-project/pull/97113
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -599,14 +599,6 @@ TARGET_BUILTIN(__nvvm_e4m3x2_to_f16x2_rn_relu, "V2hs", "",
AND(SM_89,PTX81))
TARGET_BUILTIN(__nvvm_e5m2x2_to_f16x2_rn, "V2hs", "", AND(SM_89,PTX81))
TARGET_BUILTIN(__nvvm_e5m2x2_to_f16x2_rn_relu, "V2hs", "", AND(SM_89,PTX81))
-// Bitcast
https://github.com/jlebar approved this pull request.
sgtm
https://github.com/llvm/llvm-project/pull/110316
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
801 - 874 of 874 matches
Mail list logo
