[PATCH] D25403: [CUDA] Mark __libcpp_{isnan, isinf, isfinite} as constexpr.

2016-10-09 Thread Justin Lebar via cfe-commits
jlebar created this revision. jlebar added a reviewer: hfinkel. jlebar added a subscriber: cfe-commits. This makes these functions available on host and device, which is necessary to compile for the device. https://reviews.llvm.org/D25403 Files: libcxx/include/cmath Index: libcxx/include/c

Re: r283680 - [CUDA] Support and std::min/max on the device.

2016-10-09 Thread Justin Lebar via cfe-commits
se with >>> -ffast-math >>> -ffinite-math-only. GCC can do it. Clang gets std::isnan. >>> https://godbolt.org/g/vZB55a >>> >>> By the way, the changes you made to libc++ unfortunately break this >>> patch with libc++, because e.g. __libcpp_isnan is no

[PATCH] D25403: [CUDA] Mark __libcpp_{isnan, isinf, isfinite} as constexpr.

2016-10-09 Thread Justin Lebar via cfe-commits
jlebar added a comment. Although these pass the CUDA test-suite tests (which I haven't yet committed because they're broken without this change), I could use some help running the libcxx tests. I cannot find any documentation explaining how to run the libcxx tests with just-built clang. Presu

[PATCH] D25405: [Sema] Use unique_ptr instead of raw pointers in the late-parsed templates map.

2016-10-09 Thread Justin Lebar via cfe-commits
jlebar created this revision. jlebar added a reviewer: timshen. jlebar added a subscriber: cfe-commits. jlebar added a dependency: D25404: [ADT] Let MapVector handle non-copyable values.. This is possible now that MapVector supports move-only values. Depends on https://reviews.llvm.org/D25404.

[PATCH] D25419: Use unique_ptr in LLVMContextImpl's constant maps.

2016-10-09 Thread Justin Lebar via cfe-commits
jlebar created this revision. jlebar added a reviewer: timshen. jlebar added a subscriber: cfe-commits. https://reviews.llvm.org/D25419 Files: llvm/lib/IR/Constants.cpp llvm/lib/IR/LLVMContextImpl.cpp llvm/lib/IR/LLVMContextImpl.h Index: llvm/lib/IR/LLVMContextImpl.h ==

[PATCH] D25420: [AST] Convert MangleNumberingContext to a unique_ptr.

2016-10-09 Thread Justin Lebar via cfe-commits
jlebar created this revision. jlebar added a reviewer: timshen. jlebar added a subscriber: cfe-commits. It doesn't need to be refcounted anymore, either. https://reviews.llvm.org/D25420 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/AST/MangleNumberingContext.h clang/incl

[PATCH] D25421: [AST] Use unique_ptr for VTableLayout.

2016-10-09 Thread Justin Lebar via cfe-commits
jlebar created this revision. jlebar added a reviewer: timshen. jlebar added a subscriber: cfe-commits. https://reviews.llvm.org/D25421 Files: clang/include/clang/AST/VTableBuilder.h clang/lib/AST/VTableBuilder.cpp Index: clang/lib/AST/VTableBuilder.cpp =

[PATCH] D25423: Use unique_ptr for VTableBuilder::VFTableLayouts map.

2016-10-09 Thread Justin Lebar via cfe-commits
jlebar created this revision. jlebar added a reviewer: timshen. jlebar added a subscriber: cfe-commits. https://reviews.llvm.org/D25423 Files: clang/include/clang/AST/VTableBuilder.h clang/lib/AST/VTableBuilder.cpp Index: clang/lib/AST/VTableBuilder.cpp =

[PATCH] D25422: Use unique_ptr for VPtrLocationsMap and VPtrInfoVector.

2016-10-09 Thread Justin Lebar via cfe-commits
jlebar created this revision. jlebar added a reviewer: timshen. jlebar added a subscriber: cfe-commits. https://reviews.llvm.org/D25422 Files: clang/include/clang/AST/VTableBuilder.h clang/lib/AST/VTableBuilder.cpp clang/lib/CodeGen/MicrosoftCXXABI.cpp Index: clang/lib/CodeGen/MicrosoftCXX

[PATCH] D25424: Use unique_ptr for VTableBuilder::VBaseInfo map.

2016-10-09 Thread Justin Lebar via cfe-commits
jlebar created this revision. jlebar added a reviewer: timshen. jlebar added a subscriber: cfe-commits. https://reviews.llvm.org/D25424 Files: clang/include/clang/AST/VTableBuilder.h clang/lib/AST/VTableBuilder.cpp Index: clang/lib/AST/VTableBuilder.cpp =

[PATCH] D25425: [AST] Convert Marshallers to use unique_ptr.

2016-10-09 Thread Justin Lebar via cfe-commits
jlebar created this revision. jlebar added a reviewer: timshen. jlebar added a subscriber: cfe-commits. Herald added a subscriber: klimek. https://reviews.llvm.org/D25425 Files: clang/lib/ASTMatchers/Dynamic/Marshallers.h clang/lib/ASTMatchers/Dynamic/Registry.cpp Index: clang/lib/ASTMatcher

[PATCH] D25426: [Analysis] Use unique_ptr in AnalyaisDeclContextManager's ContextMap.

2016-10-09 Thread Justin Lebar via cfe-commits
jlebar created this revision. jlebar added a reviewer: timshen. jlebar added a subscriber: cfe-commits. https://reviews.llvm.org/D25426 Files: clang/include/clang/Analysis/AnalysisContext.h clang/lib/Analysis/AnalysisDeclContext.cpp Index: clang/lib/Analysis/AnalysisDeclContext.cpp

[PATCH] D25427: [Analysis] Use unique_ptr for CallGraph::FunctionMap.

2016-10-09 Thread Justin Lebar via cfe-commits
jlebar created this revision. jlebar added a reviewer: timshen. jlebar added a subscriber: cfe-commits. The decltype(declval) dance in the iterator traits is necessary because DenseMap iterators aren't over std::pairs, but rather are over a pair-like type defined in DenseMap. It used to work beca

Re: r283680 - [CUDA] Support and std::min/max on the device.

2016-10-10 Thread Justin Lebar via cfe-commits
rap builds, I reverted it for now in r283747. > > On Sat, Oct 8, 2016 at 6:16 PM, Justin Lebar via cfe-commits > wrote: >> >> Author: jlebar >> Date: Sat Oct 8 17:16:12 2016 >> New Revision: 283680 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=28

[PATCH] D25425: [AST] Convert Marshallers to use unique_ptr.

2016-10-10 Thread Justin Lebar via cfe-commits
jlebar marked 2 inline comments as done. jlebar added inline comments. Comment at: clang/lib/ASTMatchers/Dynamic/Marshallers.h:514 + MutableArrayRef> Callbacks) + : Overloads(std::make_move_iterator(Callbacks.begin()), + std::make_move_iterator(Callback

[PATCH] D25427: [Analysis] Use unique_ptr for CallGraph::FunctionMap.

2016-10-10 Thread Justin Lebar via cfe-commits
jlebar marked an inline comment as done. jlebar added inline comments. Comment at: clang/include/clang/Analysis/CallGraph.h:204 + static clang::CallGraphNode * + CGGetValue(decltype(*std::declval()) &P) { +return P.second.get(); timshen wrote: > Does clang:

[PATCH] D25419: Use unique_ptr in LLVMContextImpl's constant maps.

2016-10-10 Thread Justin Lebar via cfe-commits
jlebar marked an inline comment as done. jlebar added inline comments. Comment at: llvm/lib/IR/LLVMContextImpl.cpp:106 for (auto &CDSConstant : CDSConstants) delete CDSConstant.second; CDSConstants.clear(); timshen wrote: > Do you want to change this o

[PATCH] D25419: Use unique_ptr in LLVMContextImpl's constant maps.

2016-10-10 Thread Justin Lebar via cfe-commits
jlebar added inline comments. Comment at: llvm/lib/IR/LLVMContextImpl.cpp:106 for (auto &CDSConstant : CDSConstants) delete CDSConstant.second; CDSConstants.clear(); jlebar wrote: > timshen wrote: > > Do you want to change this one as well? > Sure, but

r283766 - [Sema] Use unique_ptr instead of raw pointers in the late-parsed templates map.

2016-10-10 Thread Justin Lebar via cfe-commits
Author: jlebar Date: Mon Oct 10 11:26:08 2016 New Revision: 283766 URL: http://llvm.org/viewvc/llvm-project?rev=283766&view=rev Log: [Sema] Use unique_ptr instead of raw pointers in the late-parsed templates map. Summary: This is possible now that MapVector supports move-only values. Depends on

r283768 - [AST] Convert MangleNumberingContext to a unique_ptr.

2016-10-10 Thread Justin Lebar via cfe-commits
Author: jlebar Date: Mon Oct 10 11:26:19 2016 New Revision: 283768 URL: http://llvm.org/viewvc/llvm-project?rev=283768&view=rev Log: [AST] Convert MangleNumberingContext to a unique_ptr. Summary: It doesn't need to be refcounted anymore, either. Reviewers: timshen Subscribers: cfe-commits Diff

r283771 - Use unique_ptr for VTableBuilder::VFTableLayouts map.

2016-10-10 Thread Justin Lebar via cfe-commits
Author: jlebar Date: Mon Oct 10 11:26:33 2016 New Revision: 283771 URL: http://llvm.org/viewvc/llvm-project?rev=283771&view=rev Log: Use unique_ptr for VTableBuilder::VFTableLayouts map. Reviewers: timshen Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D25423 Modified

r283769 - [AST] Use unique_ptr for VTableLayout.

2016-10-10 Thread Justin Lebar via cfe-commits
Author: jlebar Date: Mon Oct 10 11:26:24 2016 New Revision: 283769 URL: http://llvm.org/viewvc/llvm-project?rev=283769&view=rev Log: [AST] Use unique_ptr for VTableLayout. Reviewers: timshen Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D25421 Modified: cfe/trunk

r283773 - [AST] Convert Marshallers to use unique_ptr.

2016-10-10 Thread Justin Lebar via cfe-commits
Author: jlebar Date: Mon Oct 10 11:26:40 2016 New Revision: 283773 URL: http://llvm.org/viewvc/llvm-project?rev=283773&view=rev Log: [AST] Convert Marshallers to use unique_ptr. Reviewers: timshen Subscribers: cfe-commits, klimek Differential Revision: https://reviews.llvm.org/D25425 Modified:

r283772 - Use unique_ptr for VTableBuilder::VBaseInfo map.

2016-10-10 Thread Justin Lebar via cfe-commits
Author: jlebar Date: Mon Oct 10 11:26:36 2016 New Revision: 283772 URL: http://llvm.org/viewvc/llvm-project?rev=283772&view=rev Log: Use unique_ptr for VTableBuilder::VBaseInfo map. Reviewers: timshen Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D25424 Modified:

r283770 - Use unique_ptr for VPtrLocationsMap and VPtrInfoVector.

2016-10-10 Thread Justin Lebar via cfe-commits
Author: jlebar Date: Mon Oct 10 11:26:29 2016 New Revision: 283770 URL: http://llvm.org/viewvc/llvm-project?rev=283770&view=rev Log: Use unique_ptr for VPtrLocationsMap and VPtrInfoVector. Reviewers: timshen Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D25422 Modifi

r283775 - [Analysis] Use unique_ptr for CallGraph::FunctionMap.

2016-10-10 Thread Justin Lebar via cfe-commits
Author: jlebar Date: Mon Oct 10 11:26:48 2016 New Revision: 283775 URL: http://llvm.org/viewvc/llvm-project?rev=283775&view=rev Log: [Analysis] Use unique_ptr for CallGraph::FunctionMap. Reviewers: timshen Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D25427 Modified

r283774 - [Analysis] Use unique_ptr in AnalyaisDeclContextManager's ContextMap.

2016-10-10 Thread Justin Lebar via cfe-commits
Author: jlebar Date: Mon Oct 10 11:26:44 2016 New Revision: 283774 URL: http://llvm.org/viewvc/llvm-project?rev=283774&view=rev Log: [Analysis] Use unique_ptr in AnalyaisDeclContextManager's ContextMap. Reviewers: timshen Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/

r283778 - [Examples] Fix use of sema.LateParsedTemplateMap in clang/examples.

2016-10-10 Thread Justin Lebar via cfe-commits
Author: jlebar Date: Mon Oct 10 11:41:00 2016 New Revision: 283778 URL: http://llvm.org/viewvc/llvm-project?rev=283778&view=rev Log: [Examples] Fix use of sema.LateParsedTemplateMap in clang/examples. Modified: cfe/trunk/examples/PrintFunctionNames/PrintFunctionNames.cpp Modified: cfe/trunk/

r283790 - [AST] Don't use make_pointee_iterator in VTableBuilder.

2016-10-10 Thread Justin Lebar via cfe-commits
Author: jlebar Date: Mon Oct 10 14:26:22 2016 New Revision: 283790 URL: http://llvm.org/viewvc/llvm-project?rev=283790&view=rev Log: [AST] Don't use make_pointee_iterator in VTableBuilder. Our implementation of make_pointee_iterator seems to be causing MSVC 2015 to crash, so I'm going to remove i

Re: r283766 - [Sema] Use unique_ptr instead of raw pointers in the late-parsed templates map.

2016-10-10 Thread Justin Lebar via cfe-commits
Some of your resent commits broke the next builder: > http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/12710 > > Please have a look at it? > > Thanks > > Galina > > > > On Mon, Oct 10, 2016 at 9:26 AM, Justin Lebar via cfe-commits &

[PATCH] D25426: [Analysis] Use unique_ptr in AnalyaisDeclContextManager's ContextMap.

2016-10-10 Thread Justin Lebar via cfe-commits
jlebar added a comment. Do you know why phab didn't pick up this change when I pushed it? https://reviews.llvm.org/D25426 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25426: [Analysis] Use unique_ptr in AnalyaisDeclContextManager's ContextMap.

2016-10-10 Thread Justin Lebar via cfe-commits
jlebar added a comment. Heh, all right. So long as I didn't screw anything up, I'm happy with it being a mystery. https://reviews.llvm.org/D25426 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinf

[PATCH] D25427: [Analysis] Use unique_ptr for CallGraph::FunctionMap.

2016-10-10 Thread Justin Lebar via cfe-commits
jlebar accepted this revision. jlebar added a reviewer: jlebar. jlebar marked an inline comment as done. jlebar added a comment. This revision is now accepted and ready to land. https://github.com/llvm-mirror/clang/commit/b28828e8b38c7e208386f783e6502305c42cb479 https://reviews.llvm.org/D25427

[PATCH] D25424: Use unique_ptr for VTableBuilder::VBaseInfo map.

2016-10-10 Thread Justin Lebar via cfe-commits
jlebar closed this revision. jlebar added a comment. Phab seemed to be having trouble closing revisions today. https://github.com/llvm-mirror/clang/commit/c4e9e7b35a2d113c8aa3bcdaf858c5bac4d78b03 https://reviews.llvm.org/D25424 ___ cfe-commits mail

[PATCH] D25422: Use unique_ptr for VPtrLocationsMap and VPtrInfoVector.

2016-10-10 Thread Justin Lebar via cfe-commits
jlebar closed this revision. jlebar added a comment. https://github.com/llvm-mirror/clang/commit/dd0969a0ae3b6421685a9d78953bb1127a8cfe9c https://reviews.llvm.org/D25422 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/c

[PATCH] D25423: Use unique_ptr for VTableBuilder::VFTableLayouts map.

2016-10-10 Thread Justin Lebar via cfe-commits
jlebar closed this revision. jlebar added a comment. https://github.com/llvm-mirror/clang/commit/be96a853a5dd33cce210617fb11575d33df7 https://reviews.llvm.org/D25423 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/c

[PATCH] D25421: [AST] Use unique_ptr for VTableLayout.

2016-10-10 Thread Justin Lebar via cfe-commits
jlebar closed this revision. jlebar added a comment. https://github.com/llvm-mirror/clang/commit/7b7c816e52feba6f89acde8b43bb0d67b5042697 https://reviews.llvm.org/D25421 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/c

[PATCH] D25420: [AST] Convert MangleNumberingContext to a unique_ptr.

2016-10-10 Thread Justin Lebar via cfe-commits
jlebar closed this revision. jlebar added a comment. https://github.com/llvm-mirror/clang/commit/7c4b8c0a7921b999f5a73d6ba47ee8350676f747 https://reviews.llvm.org/D25420 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/c

[PATCH] D25405: [Sema] Use unique_ptr instead of raw pointers in the late-parsed templates map.

2016-10-10 Thread Justin Lebar via cfe-commits
jlebar closed this revision. jlebar added a comment. https://github.com/llvm-mirror/clang/commit/1f062cda84f537547021640c8bcd9c589c418d96 https://reviews.llvm.org/D25405 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/c

r283833 - [Sema] Add explicit move constructor for ExpressionEvaluationContextRecord.

2016-10-10 Thread Justin Lebar via cfe-commits
Author: jlebar Date: Mon Oct 10 19:23:53 2016 New Revision: 283833 URL: http://llvm.org/viewvc/llvm-project?rev=283833&view=rev Log: [Sema] Add explicit move constructor for ExpressionEvaluationContextRecord. This is needed to keep MSVC 2013 happy. Modified: cfe/trunk/include/clang/Sema/Sema

[PATCH] D25419: Use unique_ptr in LLVMContextImpl's constant maps.

2016-10-11 Thread Justin Lebar via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL283767: Use unique_ptr in LLVMContextImpl's constant maps. (authored by jlebar). Changed prior to commit: https://reviews.llvm.org/D25419?vs=74097&id=74206#toc Repository: rL LLVM https://reviews.ll

[PATCH] D25425: [AST] Convert Marshallers to use unique_ptr.

2016-10-11 Thread Justin Lebar via cfe-commits
This revision was automatically updated to reflect the committed changes. jlebar marked an inline comment as done. Closed by commit rL283773: [AST] Convert Marshallers to use unique_ptr. (authored by jlebar). Changed prior to commit: https://reviews.llvm.org/D25425?vs=74103&id=74207#toc Reposi

Re: r283680 - [CUDA] Support and std::min/max on the device.

2016-10-11 Thread Justin Lebar via cfe-commits
>> >> Easiest fix at this point would be to find someone with ssh access to >> the buildbots to rm -rf the stage 1 directory. >> >> On Mon, Oct 10, 2016 at 7:19 AM, Nico Weber wrote: >> > This broke bootstrap builds, I reverted it for now in r283747. >>

r283907 - [CUDA] Re-land support for (r283683 and r283680).

2016-10-11 Thread Justin Lebar via cfe-commits
Author: jlebar Date: Tue Oct 11 12:36:03 2016 New Revision: 283907 URL: http://llvm.org/viewvc/llvm-project?rev=283907&view=rev Log: [CUDA] Re-land support for (r283683 and r283680). These were reverted in r283753 and r283747. The first patch added a header to the root 'Headers' install directo

r283963 - [CUDA] Make touching a kernel from a __host__ __device__ function a deferred error.

2016-10-11 Thread Justin Lebar via cfe-commits
Author: jlebar Date: Tue Oct 11 20:30:08 2016 New Revision: 283963 URL: http://llvm.org/viewvc/llvm-project?rev=283963&view=rev Log: [CUDA] Make touching a kernel from a __host__ __device__ function a deferred error. Previously, this was an immediate, don't pass go, don't collect $200 error. Bu

Re: r283963 - [CUDA] Make touching a kernel from a __host__ __device__ function a deferred error.

2016-10-11 Thread Justin Lebar via cfe-commits
Yes, I have yet to figure out when that REQUIRES comment is, erm, required. Sorry. :-/ I believe Art checked in a fix. On Oct 11, 2016 7:22 PM, "Chandler Carruth" wrote: > On Tue, Oct 11, 2016 at 6:39 PM Justin Lebar via cfe-commits < > cfe-commits@lists.llvm.org> wrot

[PATCH] D25139: [CUDA] Add Sema::CUDADiagBuilder and Sema::CUDADiagIfDeviceCode().

2016-10-12 Thread Justin Lebar via cfe-commits
jlebar added a comment. If you're busy with other stuff, that's cool, this is not urgent, but pinging in case this got lost. https://reviews.llvm.org/D25139 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailm

[PATCH] D25541: [CUDA] Emit deferred diagnostics during Sema rather than during codegen.

2016-10-12 Thread Justin Lebar via cfe-commits
jlebar created this revision. jlebar added a reviewer: rnk. jlebar added subscribers: tra, rsmith, cfe-commits. Emitting deferred diagnostics during codegen was a hack. It did work, but usability was poor, both for us as compiler devs and for users. We don't codegen if there are any sema errors,

[PATCH] D25571: Add and use isDiscardableGVALinkage function.

2016-10-13 Thread Justin Lebar via cfe-commits
jlebar created this revision. jlebar added a reviewer: rnk. jlebar added a subscriber: cfe-commits. https://reviews.llvm.org/D25571 Files: clang/include/clang/Basic/Linkage.h clang/include/clang/Sema/Sema.h clang/lib/AST/ASTContext.cpp clang/lib/Sema/SemaCUDA.cpp Index: clang/lib/Sema/S

[PATCH] D25541: [CUDA] Emit deferred diagnostics during Sema rather than during codegen.

2016-10-13 Thread Justin Lebar via cfe-commits
jlebar marked 2 inline comments as done. jlebar added a comment. In https://reviews.llvm.org/D25541#569360, @rnk wrote: > Nice! Looks like this wasn't too bad. Like many things in my life lately, it wasn't after Richard explained to me how to do it. :) Thank you for the review. =

r284144 - [CUDA] Disallow __shared__ variables in host functions.

2016-10-13 Thread Justin Lebar via cfe-commits
Author: jlebar Date: Thu Oct 13 13:45:13 2016 New Revision: 284144 URL: http://llvm.org/viewvc/llvm-project?rev=284144&view=rev Log: [CUDA] Disallow __shared__ variables in host functions. Reviewers: tra, rnk Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D25143 Modif

r284143 - [CUDA] Add Sema::CUDADiagBuilder and Sema::CUDADiagIf{Device, Host}Code().

2016-10-13 Thread Justin Lebar via cfe-commits
Author: jlebar Date: Thu Oct 13 13:45:08 2016 New Revision: 284143 URL: http://llvm.org/viewvc/llvm-project?rev=284143&view=rev Log: [CUDA] Add Sema::CUDADiagBuilder and Sema::CUDADiagIf{Device,Host}Code(). Summary: Together these let you easily create diagnostics that - are never emitted for h

r284145 - [CUDA] Allow static variables in __host__ __device__ functions, so long as they're never codegen'ed for device.

2016-10-13 Thread Justin Lebar via cfe-commits
Author: jlebar Date: Thu Oct 13 13:45:17 2016 New Revision: 284145 URL: http://llvm.org/viewvc/llvm-project?rev=284145&view=rev Log: [CUDA] Allow static variables in __host__ __device__ functions, so long as they're never codegen'ed for device. Reviewers: tra, rnk Subscribers: cfe-commits Diff

[PATCH] D25143: [CUDA] Disallow __shared__ variables in host functions.

2016-10-13 Thread Justin Lebar via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL284144: [CUDA] Disallow __shared__ variables in host functions. (authored by jlebar). Changed prior to commit: https://reviews.llvm.org/D25143?vs=73172&id=74565#toc Repository: rL LLVM https://revie

[PATCH] D25150: [CUDA] Allow static variables in __host__ __device__ functions, so long as they're never codegen'ed for device.

2016-10-13 Thread Justin Lebar via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL284145: [CUDA] Allow static variables in __host__ __device__ functions, so long as… (authored by jlebar). Changed prior to commit: https://reviews.llvm.org/D25150?vs=73182&id=74566#toc Repository: rL

[PATCH] D25139: [CUDA] Add Sema::CUDADiagBuilder and Sema::CUDADiagIfDeviceCode().

2016-10-13 Thread Justin Lebar via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL284143: [CUDA] Add Sema::CUDADiagBuilder and Sema::CUDADiagIf{Device,Host}Code(). (authored by jlebar). Changed prior to commit: https://reviews.llvm.org/D25139?vs=73576&id=74564#toc Repository: rL L

r284158 - [CUDA] Emit deferred diagnostics during Sema rather than during codegen.

2016-10-13 Thread Justin Lebar via cfe-commits
Author: jlebar Date: Thu Oct 13 15:52:12 2016 New Revision: 284158 URL: http://llvm.org/viewvc/llvm-project?rev=284158&view=rev Log: [CUDA] Emit deferred diagnostics during Sema rather than during codegen. Summary: Emitting deferred diagnostics during codegen was a hack. It did work, but usabili

[PATCH] D25541: [CUDA] Emit deferred diagnostics during Sema rather than during codegen.

2016-10-13 Thread Justin Lebar via cfe-commits
This revision was automatically updated to reflect the committed changes. jlebar marked an inline comment as done. Closed by commit rL284158: [CUDA] Emit deferred diagnostics during Sema rather than during codegen. (authored by jlebar). Changed prior to commit: https://reviews.llvm.org/D25541?v

r284159 - Add and use isDiscardableGVALinkage function.

2016-10-13 Thread Justin Lebar via cfe-commits
Author: jlebar Date: Thu Oct 13 15:52:17 2016 New Revision: 284159 URL: http://llvm.org/viewvc/llvm-project?rev=284159&view=rev Log: Add and use isDiscardableGVALinkage function. Reviewers: rnk Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D25571 Modified: cfe/tr

[PATCH] D25571: Add and use isDiscardableGVALinkage function.

2016-10-13 Thread Justin Lebar via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL284159: Add and use isDiscardableGVALinkage function. (authored by jlebar). Changed prior to commit: https://reviews.llvm.org/D25571?vs=74562&id=74580#toc Repository: rL LLVM https://reviews.llvm.or

[PATCH] D25571: Add and use isDiscardableGVALinkage function.

2016-10-13 Thread Justin Lebar via cfe-commits
jlebar added inline comments. Comment at: clang/include/clang/Sema/Sema.h:9244 /// CUDAKnownEmittedFns. - llvm::DenseMap> CUDACallGraph; + llvm::DenseMap> CUDACallGraph; rnk wrote: > I think you meant to make this change as part of the original patch. Oop

[PATCH] D25640: [CUDA] [AST] Allow isInlineDefinitionExternallyVisible to be called on functions without bodies.

2016-10-14 Thread Justin Lebar via cfe-commits
jlebar created this revision. jlebar added reviewers: rsmith, tra. jlebar added a subscriber: cfe-commits. Herald added a subscriber: aemerson. In CUDA compilation, we call isInlineDefinitionExternallyVisible (via getGVALinkageForFunction) on functions while parsing their definitions. At the poin

[PATCH] D25647: [clang-tidy] Don't use a SmallSetVector of an enum.

2016-10-15 Thread Justin Lebar via cfe-commits
jlebar created this revision. jlebar added a reviewer: timshen. jlebar added a subscriber: cfe-commits. Herald added a subscriber: nemanjai. This doesn't work after converting SmallSetVector to use DenseSet. Instead we can just use a SmallVector. https://reviews.llvm.org/D25647 Files: clang-

r284355 - [CUDA] Fix false-positive in known-emitted handling.

2016-10-16 Thread Justin Lebar via cfe-commits
Author: jlebar Date: Sun Oct 16 21:25:55 2016 New Revision: 284355 URL: http://llvm.org/viewvc/llvm-project?rev=284355&view=rev Log: [CUDA] Fix false-positive in known-emitted handling. Previously: When compiling for host, our constructed call graph went *through* kernel calls. This meant that i

[clang] 9de4fc0 - [CUDA][SPIRV] Assign global address space to CUDA kernel arguments

2022-02-17 Thread Justin Lebar via cfe-commits
Author: Shangwu Yao Date: 2022-02-17T09:38:06-08:00 New Revision: 9de4fc0f2d3b60542956f7e5254951d049edeb1f URL: https://github.com/llvm/llvm-project/commit/9de4fc0f2d3b60542956f7e5254951d049edeb1f DIFF: https://github.com/llvm/llvm-project/commit/9de4fc0f2d3b60542956f7e5254951d049edeb1f.diff L

[clang] [clang][AMDGPU][CUDA] Handle __builtin_printf for device printf (PR #68515)

2024-02-03 Thread Justin Lebar via cfe-commits
jlebar wrote: It looks reasonable to me, although I'm not really an AMDGPU person. /me summons @arsenm ? https://github.com/llvm/llvm-project/pull/68515 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[clang] [NVPTX] Add support for -march=native in standalone NVPTX (PR #79373)

2024-01-24 Thread Justin Lebar via cfe-commits
jlebar wrote: I think I'm with Art on this one. >> Problem #2 [...] The arch=native will create a working configuration, but >> would build more than necessary. > > It will target the first GPU it finds. We could maybe change the behavior to > detect the newest, but the idea is just to target

[lld] [lldb] [clang-tools-extra] [clang] [libcxx] [libc] [flang] [llvm] [compiler-rt] [NVPTX] Add support for -march=native in standalone NVPTX (PR #79373)

2024-01-25 Thread Justin Lebar via cfe-commits
jlebar wrote: > This method of compilation is not like CUDA, so we can't target all the GPUs > at the same time. Can you clarify for me -- what are you compiling where it's impossible to target multiple GPUs in the binary? I'm confused because Art is understanding that it's not CUDA, but we

[lld] [lldb] [libcxx] [compiler-rt] [clang-tools-extra] [llvm] [libc] [clang] [flang] [NVPTX] Add support for -march=native in standalone NVPTX (PR #79373)

2024-01-25 Thread Justin Lebar via cfe-commits
jlebar wrote: I...think I understand. Is the output of this compilation step a cubin, then? https://github.com/llvm/llvm-project/pull/79373 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[flang] [libc] [compiler-rt] [clang] [clang-tools-extra] [llvm] [libcxx] [lld] [lldb] [NVPTX] Add support for -march=native in standalone NVPTX (PR #79373)

2024-01-25 Thread Justin Lebar via cfe-commits
jlebar wrote: Got it, okay, thanks. Since this change only applies to `--target=nvptx64-nvidia-cuda`, fine by me. Thanks for putting up with our scrutiny. :) https://github.com/llvm/llvm-project/pull/79373 ___ cfe-commits mailing list cfe-commits@l

[llvm] [clang] [NVPTX] Add builtin support for 'globaltimer' (PR #79765)

2024-01-29 Thread Justin Lebar via cfe-commits
https://github.com/jlebar edited https://github.com/llvm/llvm-project/pull/79765 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [NVPTX] Add builtin support for 'globaltimer' (PR #79765)

2024-01-29 Thread Justin Lebar via cfe-commits
https://github.com/jlebar approved this pull request. https://github.com/llvm/llvm-project/pull/79765 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [NVPTX] Add builtin for 'exit' handling (PR #79777)

2024-01-29 Thread Justin Lebar via cfe-commits
https://github.com/jlebar approved this pull request. https://github.com/llvm/llvm-project/pull/79777 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [NVPTX] Add 'activemask' builtin and intrinsic support (PR #79768)

2024-01-29 Thread Justin Lebar via cfe-commits
jlebar wrote: Unlike the other PRs, this one has a CUDA function, `__activemask()`. Presumably we should make that one work by hacking our headers? https://github.com/llvm/llvm-project/pull/79768 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[clang] [NVPTX] Allow compiling LLVM-IR without `-march` set (PR #79873)

2024-01-29 Thread Justin Lebar via cfe-commits
https://github.com/jlebar approved this pull request. https://github.com/llvm/llvm-project/pull/79873 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [NVPTX] Add 'activemask' builtin and intrinsic support (PR #79768)

2024-01-29 Thread Justin Lebar via cfe-commits
jlebar wrote: > I was planning on updating this to use the new instrinsic for the newer > version. Alternatively we could make __activemask the builtin which expands > to both versions, but I'm somewhat averse since we should target the > instruction directly I feel. Yes, I agree that the bui

[clang] [llvm] [NVPTX] Add 'activemask' builtin and intrinsic support (PR #79768)

2024-01-29 Thread Justin Lebar via cfe-commits
https://github.com/jlebar approved this pull request. https://github.com/llvm/llvm-project/pull/79768 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CUDA] Change '__activemask' to use '__nvvm_activemask()' (PR #79892)

2024-01-29 Thread Justin Lebar via cfe-commits
https://github.com/jlebar approved this pull request. https://github.com/llvm/llvm-project/pull/79892 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] c90dac2 - [clang] Print 32 candidates on the first failure, with -fshow-overloads=best.

2021-02-25 Thread Justin Lebar via cfe-commits
Author: Justin Lebar Date: 2021-02-25T17:45:19-08:00 New Revision: c90dac27e94ec354a3e8919556ac5bc89b62c731 URL: https://github.com/llvm/llvm-project/commit/c90dac27e94ec354a3e8919556ac5bc89b62c731 DIFF: https://github.com/llvm/llvm-project/commit/c90dac27e94ec354a3e8919556ac5bc89b62c731.diff

[clang] e890fff - Fix signed-compare warning.

2021-02-25 Thread Justin Lebar via cfe-commits
Author: Justin Lebar Date: 2021-02-25T18:14:40-08:00 New Revision: e890fffcab8b7e95deba4269c14db9fab003a737 URL: https://github.com/llvm/llvm-project/commit/e890fffcab8b7e95deba4269c14db9fab003a737 DIFF: https://github.com/llvm/llvm-project/commit/e890fffcab8b7e95deba4269c14db9fab003a737.diff

Re: [PATCH] D75811: [CUDA] Choose default architecture based on CUDA installation

2020-03-09 Thread Justin Lebar via cfe-commits
From the peanut gallery: Perhaps something like --cuda_arch=min_supported would solve your problem while still meeting tra's request not to change behavior of the compiler based on something external. On Mon, Mar 9, 2020 at 12:58 PM Raul Tambre via Phabricator wrote: > > tambre added a comment. >

[clang] f0fd852 - Fix SFINAE in CFG.cpp.

2020-02-11 Thread Justin Lebar via cfe-commits
Author: Justin Lebar Date: 2020-02-11T10:37:08-08:00 New Revision: f0fd852fcd054297f2b07e2ca87551de9b2a39c0 URL: https://github.com/llvm/llvm-project/commit/f0fd852fcd054297f2b07e2ca87551de9b2a39c0 DIFF: https://github.com/llvm/llvm-project/commit/f0fd852fcd054297f2b07e2ca87551de9b2a39c0.diff

[clang] 027eb71 - Use std::foo_t rather than std::foo in clang.

2020-02-11 Thread Justin Lebar via cfe-commits
Author: Justin Lebar Date: 2020-02-11T10:37:08-08:00 New Revision: 027eb71696f6ce4fdeb63f68c8c6b66e147ad407 URL: https://github.com/llvm/llvm-project/commit/027eb71696f6ce4fdeb63f68c8c6b66e147ad407 DIFF: https://github.com/llvm/llvm-project/commit/027eb71696f6ce4fdeb63f68c8c6b66e147ad407.diff

[clang] ac66c61 - Use C++14-style return type deduction in clang.

2020-02-11 Thread Justin Lebar via cfe-commits
Author: Justin Lebar Date: 2020-02-11T14:41:22-08:00 New Revision: ac66c61bf9463bf419102ad8b6565dcbc495b0ab URL: https://github.com/llvm/llvm-project/commit/ac66c61bf9463bf419102ad8b6565dcbc495b0ab DIFF: https://github.com/llvm/llvm-project/commit/ac66c61bf9463bf419102ad8b6565dcbc495b0ab.diff

r316611 - [CUDA] Print an error if you try to compile with < sm_30 on CUDA 9.

2017-10-25 Thread Justin Lebar via cfe-commits
Author: jlebar Date: Wed Oct 25 14:32:06 2017 New Revision: 316611 URL: http://llvm.org/viewvc/llvm-project?rev=316611&view=rev Log: [CUDA] Print an error if you try to compile with < sm_30 on CUDA 9. Summary: CUDA 9's minimum sm is sm_30. Ideally we should also make sm_30 the default when compi

r317297 - [CUDA] Mark CUDA as a no-errno platform.

2017-11-02 Thread Justin Lebar via cfe-commits
Author: jlebar Date: Thu Nov 2 19:30:00 2017 New Revision: 317297 URL: http://llvm.org/viewvc/llvm-project?rev=317297&view=rev Log: [CUDA] Mark CUDA as a no-errno platform. Summary: CUDA doesn't support errno at all, so this is the right thing -- or at least, in the right direction. But also, t

r317623 - [NVPTX] Implement __nvvm_atom_add_gen_d builtin.

2017-11-07 Thread Justin Lebar via cfe-commits
Author: jlebar Date: Tue Nov 7 14:10:54 2017 New Revision: 317623 URL: http://llvm.org/viewvc/llvm-project?rev=317623&view=rev Log: [NVPTX] Implement __nvvm_atom_add_gen_d builtin. Summary: This just seems to have been an oversight. We already supported the f64 atomic add with an explicit scope

r317961 - [CUDA] Fix std::min on device side to return the min, not the max.

2017-11-10 Thread Justin Lebar via cfe-commits
Author: jlebar Date: Fri Nov 10 17:25:44 2017 New Revision: 317961 URL: http://llvm.org/viewvc/llvm-project?rev=317961&view=rev Log: [CUDA] Fix std::min on device side to return the min, not the max. Summary: How embarrassing. This is tested in the test-suite -- fix to come there in a separate p

r318494 - [CUDA] Remove implementations of nexttoward.

2017-11-16 Thread Justin Lebar via cfe-commits
Author: jlebar Date: Thu Nov 16 17:15:43 2017 New Revision: 318494 URL: http://llvm.org/viewvc/llvm-project?rev=318494&view=rev Log: [CUDA] Remove implementations of nexttoward. Summary: __builtin_nexttoward lowers to a libcall, e.g. nexttowardf(), that CUDA does not have. Rather than try to imp

r289847 - [CUDA] Add --ptxas-path= flag.

2016-12-15 Thread Justin Lebar via cfe-commits
Author: jlebar Date: Thu Dec 15 12:44:57 2016 New Revision: 289847 URL: http://llvm.org/viewvc/llvm-project?rev=289847&view=rev Log: [CUDA] Add --ptxas-path= flag. Summary: This lets you build with one CUDA installation but use ptxas from another install. This is useful e.g. if you want to avoid

r290717 - [ADT] Delete RefCountedBaseVPTR.

2016-12-29 Thread Justin Lebar via cfe-commits
Author: jlebar Date: Thu Dec 29 13:59:26 2016 New Revision: 290717 URL: http://llvm.org/viewvc/llvm-project?rev=290717&view=rev Log: [ADT] Delete RefCountedBaseVPTR. Summary: This class is unnecessary. Its comment indicated that it was a compile error to allocate an instance of a class that inhe

r291128 - [Windows] Remove functions in intrin.h that are defined in Builtin.def.

2017-01-05 Thread Justin Lebar via cfe-commits
Author: jlebar Date: Thu Jan 5 10:51:37 2017 New Revision: 291128 URL: http://llvm.org/viewvc/llvm-project?rev=291128&view=rev Log: [Windows] Remove functions in intrin.h that are defined in Builtin.def. Summary: These duplicate declarations cause a problem for CUDA compiles on Windows. All imp

r291129 - [TableGen] Only normalize the spelling of GNU-style attributes.

2017-01-05 Thread Justin Lebar via cfe-commits
Author: jlebar Date: Thu Jan 5 10:51:54 2017 New Revision: 291129 URL: http://llvm.org/viewvc/llvm-project?rev=291129&view=rev Log: [TableGen] Only normalize the spelling of GNU-style attributes. Summary: When Sema looks up an attribute name, it strips off leading and trailing "__" if the attrib

r291130 - [CUDA] Make CUDAInstallationDetector take the host triple in its constructor.

2017-01-05 Thread Justin Lebar via cfe-commits
Author: jlebar Date: Thu Jan 5 10:52:11 2017 New Revision: 291130 URL: http://llvm.org/viewvc/llvm-project?rev=291130&view=rev Log: [CUDA] Make CUDAInstallationDetector take the host triple in its constructor. Summary: Previously it was taking the true target triple, which is not really what it

r291131 - [Driver] Driver changes to support CUDA compilation on Windows.

2017-01-05 Thread Justin Lebar via cfe-commits
Author: jlebar Date: Thu Jan 5 10:52:29 2017 New Revision: 291131 URL: http://llvm.org/viewvc/llvm-project?rev=291131&view=rev Log: [Driver] Driver changes to support CUDA compilation on Windows. Summary: For the most part this is straightforward: Just add a CudaInstallation object to the MSVC a

r291133 - [ToolChains] Use "static" instead of an anonymous namespace for a function. NFC

2017-01-05 Thread Justin Lebar via cfe-commits
Author: jlebar Date: Thu Jan 5 10:52:47 2017 New Revision: 291133 URL: http://llvm.org/viewvc/llvm-project?rev=291133&view=rev Log: [ToolChains] Use "static" instead of an anonymous namespace for a function. NFC Modified: cfe/trunk/lib/Driver/MinGWToolChain.cpp Modified: cfe/trunk/lib/Driv

r291134 - [CUDA] Add __declspec spellings for CUDA attributes.

2017-01-05 Thread Justin Lebar via cfe-commits
Author: jlebar Date: Thu Jan 5 10:53:04 2017 New Revision: 291134 URL: http://llvm.org/viewvc/llvm-project?rev=291134&view=rev Log: [CUDA] Add __declspec spellings for CUDA attributes. Summary: CUDA attributes are spelled __declspec(__foo__) on Windows. Reviewers: tra Subscribers: cfe-commits,

r291135 - [CUDA] More correctly inherit primitive types from the host during device compilation.

2017-01-05 Thread Justin Lebar via cfe-commits
Author: jlebar Date: Thu Jan 5 10:53:21 2017 New Revision: 291135 URL: http://llvm.org/viewvc/llvm-project?rev=291135&view=rev Log: [CUDA] More correctly inherit primitive types from the host during device compilation. Summary: CUDA lets users share structs between the host and device, so for t

r291136 - [CUDA] Let NVPTX inherit the host's calling conventions.

2017-01-05 Thread Justin Lebar via cfe-commits
Author: jlebar Date: Thu Jan 5 10:53:38 2017 New Revision: 291136 URL: http://llvm.org/viewvc/llvm-project?rev=291136&view=rev Log: [CUDA] Let NVPTX inherit the host's calling conventions. Summary: When compiling device code, we may still see host code with explicit calling conventions. NVPTX n

r291137 - [CUDA] Don't define functions that the CUDA headers themselves define on Windows.

2017-01-05 Thread Justin Lebar via cfe-commits
Author: jlebar Date: Thu Jan 5 10:53:55 2017 New Revision: 291137 URL: http://llvm.org/viewvc/llvm-project?rev=291137&view=rev Log: [CUDA] Don't define functions that the CUDA headers themselves define on Windows. Reviewers: tra Subscribers: cfe-commits Differential Revision: https://reviews.

<    1   2   3   4   5   6   7   8   9   >