[PATCH] D126682: [Interpreter][ClangRepl] Implement undo command

junaire added inline comments. Comment at: clang/lib/Interpreter/IncrementalParser.cpp:180 DiagnosticsEngine &Diags = getCI()->getDiagnostics(); if (Diags.hasErrorOccurred()) { TranslationUnitDecl *MostRecentTU = C.getTranslationUnitDecl(); v.g.vassile

[PATCH] D156858: Add Documentation for Execution Results Handling in Clang-REPL

junaire added a comment. I want to clarify: We offer two features: 1. capture the execution results and bring it back to the compiled program. 2. dump the captured value (value printing/automatic printf) and all the parsing, ast transform and balabala, these are all implementation details. The

[PATCH] D139202: Link with missing libs to fix broken shared build

junaire created this revision. Herald added a subscriber: kadircet. Herald added a project: All. junaire requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Signed-off-by: Jun Zhang Repository: rG LLVM Github Monorepo https://

[PATCH] D139202: Link with missing libs to fix broken shared build

junaire added a comment. This is caused by https://reviews.llvm.org/D139013 I should mention. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139202/new/ https://reviews.llvm.org/D139202 ___ cfe-commits ma

[PATCH] D139202: Link with missing libs to fix broken shared build

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8431436e543f: Link with missing libs to fix broken shared build (authored by junaire). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D146041: Fix weirdly apologetic diagnostic messages

junaire added a comment. I'm not certain if it's bad to say 'sorry', IMHO it's fine? Anyway, you can't just simply delete those words (in diagnostic messages and regression tests), that doesn't work. To verify the patch is good, you can run `ninja check-all` to make sure the testsuite passes.

[PATCH] D141215: [clang-repl] Introduce Value and implement pretty printing

junaire updated this revision to Diff 508068. junaire added a comment. Update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/Basic/TokenKinds.def clang/include/clang/Inter

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire updated this revision to Diff 508072. junaire added a comment. Update comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/Basic/TokenKinds.def clang/include/cla

[PATCH] D146809: [WIP][clang-repl] Implement Value pretty printing

junaire created this revision. Herald added a subscriber: mstorsjo. Herald added a project: All. junaire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch implements Value::dump related code so the pretty printing will work. The p

[PATCH] D146867: [Diagnostic] printing name of uninitialized subobject instead of its type

junaire added reviewers: aaron.ballman, tbaeder, shafik. junaire added a comment. I don't have enough context on this patch, but obviously, there's something you can improve. 1. You need to add a test, maybe somewhere in `clang/test/Sema/` 2. Please make a detailed summary of your patch so revie

[PATCH] D146867: [Diagnostic] printing name of uninitialized subobject instead of its type

junaire added a comment. BTW, does this patch overlaps with https://reviews.llvm.org/D146358? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146867/new/ https://reviews.llvm.org/D146867 ___ cfe-commits ma

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire updated this revision to Diff 509305. junaire added a comment. Update + Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/Basic/TokenKinds.def clang/include/cla

[PATCH] D146809: [WIP][clang-repl] Implement Value pretty printing

junaire updated this revision to Diff 509306. junaire added a comment. Update + Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146809/new/ https://reviews.llvm.org/D146809 Files: clang/lib/Headers/CMakeLists.txt clang/lib/Headers/__clang

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire updated this revision to Diff 509307. junaire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/Basic/TokenKinds.def clang/include/clang/Interp

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire updated this revision to Diff 509311. junaire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/Basic/TokenKinds.def clang/include/clang/Interp

[PATCH] D141215: [clang-repl][WIP] Implement pretty printing

junaire updated this revision to Diff 501360. junaire added a comment. Support printing temporaries. Note there's a ugly hack because I didn't find the right way to synthesize the AST for explicit destructor call. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D141215: [clang-repl] Introduce Value and implement pretty printing

junaire updated this revision to Diff 501363. junaire edited the summary of this revision. junaire added a comment. Remove extra includes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/inc

[PATCH] D141215: [clang-repl] Introduce Value and implement pretty printing

junaire updated this revision to Diff 501365. junaire added a comment. Add more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/Interpreter/Interpreter.h clang/include

[PATCH] D145316: [Clang][Lex] Generate an annotation token for clang-repl

junaire created this revision. Herald added a project: All. junaire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patches adds a new annotation token called annot_input_end, which can be used to capture expression in value printing.

[PATCH] D141215: [clang-repl] Introduce Value and implement pretty printing

junaire updated this revision to Diff 502402. junaire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/Interpreter/Interpreter.h clang/include/clang/I

[PATCH] D141215: [clang-repl] Introduce Value and implement pretty printing

junaire updated this revision to Diff 502405. junaire added a comment. Prefer one patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/Basic/TokenKinds.def clang/include/cl

[PATCH] D145316: [Clang][Lex] Generate an annotation token for clang-repl

junaire abandoned this revision. junaire added a comment. Merged changes into the child revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145316/new/ https://reviews.llvm.org/D145316 ___ cfe-commit

[PATCH] D141215: [clang-repl] Introduce Value and implement pretty printing

junaire updated this revision to Diff 502406. junaire added a comment. Fix patch application failed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/Basic/TokenKinds.def clan

[PATCH] D141215: [clang-repl] Introduce Value and implement pretty printing

junaire updated this revision to Diff 502407. junaire added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/Basic/TokenKinds.def clang/include/clang/Interp

[PATCH] D141215: [clang-repl] Introduce Value and implement pretty printing

junaire updated this revision to Diff 502646. junaire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/Basic/TokenKinds.def clang/include/clang/Interp

[PATCH] D141215: [clang-repl] Introduce Value and implement pretty printing

junaire updated this revision to Diff 504038. junaire added a comment. Update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/Basic/TokenKinds.def clang/include/clang/Inter

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire updated this revision to Diff 509958. junaire added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/Basic/TokenKinds.def clang/include/c

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire marked 3 inline comments as done. junaire added inline comments. Comment at: clang/lib/Interpreter/IncrementalParser.cpp:162 + if (P->getCurToken().is(tok::annot_input_end)) { +P->ConsumeAnyToken(); // FIXME: Clang does not call ExitScope on finalizing the regul

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire updated this revision to Diff 510014. junaire added a comment. Address more comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/Basic/TokenKinds.def clang/inclu

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire marked 9 inline comments as done. junaire added inline comments. Comment at: clang/include/clang/Interpreter/Interpreter.h:119 + + std::unique_ptr GenModule(); + v.g.vassilev wrote: > We should not need this interface. `Interpreter::CompileDecl` needs it

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire updated this revision to Diff 510017. junaire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/Basic/TokenKinds.def clang/include/clang/Interp

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire updated this revision to Diff 510167. junaire added a comment. Update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/Basic/TokenKinds.def clang/include/clang/Inter

[PATCH] D146809: [WIP][clang-repl] Implement Value pretty printing

junaire updated this revision to Diff 510168. junaire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146809/new/ https://reviews.llvm.org/D146809 Files: clang/include/clang/Interpreter/Interpreter.h clang/lib/Headers/CMa

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire updated this revision to Diff 510226. junaire added a comment. I dont know why the premerge tests are failling, let me try to do a update... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files:

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire updated this revision to Diff 510286. junaire added a comment. Fix known memory issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/Basic/TokenKinds.def clang/in

[PATCH] D146809: [WIP][clang-repl] Implement Value pretty printing

junaire updated this revision to Diff 510288. junaire added a comment. CHANGELOG: 1. Add constant array tests. 2. Fix misc issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146809/new/ https://reviews.llvm.org/D146809 Files: clang/include/c

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire updated this revision to Diff 510885. junaire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/AST/Decl.h clang/include/clang/Basic/TokenKinds

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire updated this revision to Diff 511084. junaire added a comment. Add IncrementalASTConsumer Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/AST/Decl.h clang/include/cl

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire updated this revision to Diff 511090. junaire added a comment. Remove old code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/AST/Decl.h clang/include/clang/Basic/T

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire updated this revision to Diff 511857. junaire added a comment. Update... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/AST/Decl.h clang/include/clang/Basic/TokenKi

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire updated this revision to Diff 511862. junaire added a comment. Clean up the patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/AST/Decl.h clang/include/clang/Basi

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire updated this revision to Diff 511867. junaire added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/AST/Decl.h clang/include/clang/Basic/

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire updated this revision to Diff 511870. junaire added a comment. Remove some unnecessary code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/AST/Decl.h clang/include

[PATCH] D146809: [WIP][clang-repl] Implement Value pretty printing

junaire updated this revision to Diff 511871. junaire added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146809/new/ https://reviews.llvm.org/D146809 Files: clang/include/clang/Interpreter/Interpreter.h clang/lib/Headers/CMa

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire updated this revision to Diff 511984. junaire added a comment. Refactor how we compile a destructor Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/AST/Decl.h clang/

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire added inline comments. Comment at: clang/include/clang/Interpreter/Interpreter.h:97 + + enum InterfaceKind { NoAlloc, WithAlloc, CopyArray }; + v.g.vassilev wrote: > This can probably go in the RuntimeInterfaceBuilder class. We need it. See: ``` class R

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire updated this revision to Diff 511999. junaire added a comment. Address some comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/AST/Decl.h clang/include/clang/B

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire added inline comments. Comment at: clang/include/clang/Interpreter/Interpreter.h:97 + + enum InterfaceKind { NoAlloc, WithAlloc, CopyArray }; + v.g.vassilev wrote: > junaire wrote: > > v.g.vassilev wrote: > > > This can probably go in the RuntimeInterfac

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire updated this revision to Diff 512072. junaire added a comment. Address some comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/AST/Decl.h clang/include/clang/B

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire updated this revision to Diff 512073. junaire added a comment. fix some nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/AST/Decl.h clang/include/clang/Basic/Tok

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire marked 6 inline comments as done. junaire added inline comments. Comment at: clang/include/clang/Interpreter/Interpreter.h:67 create(std::unique_ptr CI); + ASTContext &getASTContext() const; const CompilerInstance *getCompilerInstance() const; v.g.

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire updated this revision to Diff 512075. junaire added a comment. Use IncrementalParser::GetMangledName instead Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/AST/Decl.h

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire updated this revision to Diff 512801. junaire added a comment. use unsigned long instead of std::size_t when including the runtimes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/i

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire updated this revision to Diff 512837. junaire added a comment. dont include if we don't have it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/AST/Decl.h clang/inc

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire updated this revision to Diff 512869. junaire added a comment. fix ci Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/AST/Decl.h clang/include/clang/Basic/TokenKinds

[PATCH] D146809: [WIP][clang-repl] Implement Value pretty printing

junaire updated this revision to Diff 513024. junaire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146809/new/ https://reviews.llvm.org/D146809 Files: clang/include/clang/Interpreter/Interpreter.h clang/lib/Headers/CMa

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire updated this revision to Diff 513918. junaire added a comment. Address some comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/AST/Decl.h clang/include/clang/B

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire marked 16 inline comments as done. junaire added inline comments. Comment at: clang/include/clang/Interpreter/Interpreter.h:72 + llvm::Error ParseAndExecute(llvm::StringRef Code, Value *V = nullptr); + llvm::Expected CompileDtorCall(CXXRecordDecl *CXXRD);

[PATCH] D148434: [clang-repl] JITTargetAddress --> ExecutorAddr

junaire created this revision. Herald added a project: All. junaire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Signed-off-by: Jun Zhang Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D148434 Files: clang/include/

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire marked 4 inline comments as done. junaire added inline comments. Comment at: clang/include/clang/Interpreter/Interpreter.h:83 /// mangled name. llvm::Expected getSymbolAddress(GlobalDecl GD) const; sgraenitz wrote: > Most of the Orc and JITLink mo

[PATCH] D148434: [clang-repl] JITTargetAddress --> ExecutorAddr

junaire updated this revision to Diff 513924. junaire added a comment. Avoid unnecessary changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148434/new/ https://reviews.llvm.org/D148434 Files: clang/include/clang/Interpreter/Interpreter.h cl

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire updated this revision to Diff 513926. junaire marked an inline comment as done. junaire added a comment. Address more comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/includ

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire marked an inline comment as done. junaire added inline comments. Comment at: clang/include/clang/Interpreter/Value.h:83 + Value() = default; + Value(void /*Interpreter*/ *In, void /*QualType*/ *Ty); + Value(const Value &RHS); aaron.ballman wrote: > Why

[PATCH] D146809: [WIP][clang-repl] Implement Value pretty printing

junaire updated this revision to Diff 513927. junaire added a comment. Sync Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146809/new/ https://reviews.llvm.org/D146809 Files: clang/include/clang/Interpreter/Interpreter.h clang/lib/Headers/CMake

[PATCH] D148434: [clang-repl] JITTargetAddress --> ExecutorAddr

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. junaire marked an inline comment as done. Closed by commit rGfe1f34453d7e: [clang-repl] JITTargetAddress --> ExecutorAddr, NFC (authored by junaire). Changed prior to

[PATCH] D148434: [clang-repl] JITTargetAddress --> ExecutorAddr

junaire marked an inline comment as done. junaire added inline comments. Comment at: clang/lib/Interpreter/IncrementalExecutor.cpp:88 return Sym.takeError(); - return Sym->getValue(); + return llvm::orc::ExecutorAddr(Sym->getValue()); } sgraenitz wrote: >

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire updated this revision to Diff 513954. junaire marked an inline comment as done. junaire added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/AST/Dec

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire marked an inline comment as done. junaire added inline comments. Comment at: clang/include/clang/Interpreter/Value.h:98 + QualType getType() const; + Interpreter &getInterpreter() const; + sgraenitz wrote: > Can we make this private and try not to intro

[PATCH] D146809: [WIP][clang-repl] Implement Value pretty printing

junaire updated this revision to Diff 513971. junaire added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146809/new/ https://reviews.llvm.org/D146809 Files: clang/include/clang/Interpreter/Interpreter.h clang/lib/Headers/CMa

[PATCH] D146809: [WIP][clang-repl] Implement Value pretty printing

junaire updated this revision to Diff 514160. junaire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146809/new/ https://reviews.llvm.org/D146809 Files: clang/include/clang/Interpreter/Interpreter.h clang/include/clang/I

[PATCH] D148435: [clang-repl] Do not assert if we have weak references left.

junaire accepted this revision. junaire added a comment. This revision is now accepted and ready to land. This patch fixes issues that have not been found in the past. This unblocks D141215 and D146809 . Since it's only relevan

[PATCH] D146809: [clang-repl] Implement Value pretty printing

junaire updated this revision to Diff 524088. junaire added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146809/new/ https://reviews.llvm.org/D146809 Files: clang/include/clang/Interpreter/Interpreter.h clang/include/clang/Interp

[PATCH] D146809: [clang-repl] Implement Value pretty printing

junaire added a comment. Invite more people to the party :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146809/new/ https://reviews.llvm.org/D146809 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D146809: [clang-repl] Implement Value pretty printing

junaire updated this revision to Diff 524091. junaire added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146809/new/ https://reviews.llvm.org/D146809 Files: clang/include/clang/Interpreter/Interpreter.h clang/include/clang/Interp

[PATCH] D146809: [clang-repl] Implement Value pretty printing

junaire updated this revision to Diff 524093. junaire added a comment. add `caas` namespace Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146809/new/ https://reviews.llvm.org/D146809 Files: clang/include/clang/Interpreter/Interpreter.h clang/i

[PATCH] D146809: [clang-repl] Implement Value pretty printing

junaire updated this revision to Diff 524096. junaire added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146809/new/ https://reviews.llvm.org/D146809 Files: clang/include/clang/Interpreter/Interpreter.h clang/include/clang/Interp

[PATCH] D150937: [clang-repl] Disable all tests on unsupported platforms

junaire abandoned this revision. junaire added a comment. This isn't an ideal solution after an off-list discussion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150937/new/ https://reviews.llvm.org/D150937 ___

[PATCH] D146809: [clang-repl] Implement Value pretty printing

junaire updated this revision to Diff 525420. junaire marked 15 inline comments as done. junaire added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146809/new/ https://reviews.llvm.org/D146809 Files: clang/include/c

[PATCH] D146809: [clang-repl] Implement Value pretty printing

junaire added inline comments. Comment at: clang/lib/Interpreter/Interpreter.cpp:434 + +llvm::Expected Interpreter::CompileDecl(Decl *D) { + assert(D && "The Decl being compiled can't be null"); aaron.ballman wrote: > Any way to make this take a `const Decl *` i

[PATCH] D146809: [clang-repl] Implement Value pretty printing

junaire updated this revision to Diff 525425. junaire added a comment. Remove `Interpereter::getParser` + More clean up Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146809/new/ https://reviews.llvm.org/D146809 Files: clang/include/clang/Interpr

[PATCH] D146809: [clang-repl] Implement Value pretty printing

junaire updated this revision to Diff 526256. junaire added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146809/new/ https://reviews.llvm.org/D146809 Files: clang/include/clang/Interpreter/Interpreter.h clang/include/clang/I

[PATCH] D151620: [clang-repl] Fix REPL_EXTERNAL_VISIBILITY and building libclang-cpp.dll for MinGW configurations

junaire accepted this revision. junaire added a comment. This revision is now accepted and ready to land. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151620/new/ https://reviews.llvm.org/D151620 __

[PATCH] D146809: [clang-repl] Implement Value pretty printing

junaire updated this revision to Diff 526383. junaire added a comment. Make CreateUniqName a static helper Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146809/new/ https://reviews.llvm.org/D146809 Files: clang/include/clang/Interpreter/Interpre

[PATCH] D146809: [clang-repl] Implement Value pretty printing

junaire added inline comments. Comment at: clang/tools/clang-repl/CMakeLists.txt:40 + ??6?$basic_ostream@DU?$char_traits@D@std@@@std@@QEAAAEAV01@PEBX@Z + ??6?$basic_ostream@DU?$char_traits@D@std@@@std@@QEAAAEAV01@P6AAEAV01@AEAV01@@Z@Z + ??$?6U?$char_traits@D@std@

[PATCH] D146809: [clang-repl] Implement Value pretty printing

junaire updated this revision to Diff 526566. junaire marked 2 inline comments as done. junaire added a comment. Add LLVM preamble Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146809/new/ https://reviews.llvm.org/D146809 Files: clang/include/cl

[PATCH] D146809: [clang-repl] Implement Value pretty printing

junaire added inline comments. Comment at: clang/lib/Interpreter/ValuePrinter.cpp:262 + +static llvm::Expected CompileDecl(Interpreter &Interp, + Decl *D) { v.g.vassilev wrote: > Let's add a FIXME here. Th

[PATCH] D141215: [clang-repl][WIP] Implement pretty printing

junaire updated this revision to Diff 497011. junaire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/Interpreter/Interpreter.h clang/include/clang/I

[PATCH] D141215: [clang-repl][WIP] Implement pretty printing

junaire updated this revision to Diff 497531. junaire added a comment. Herald added a subscriber: mstorsjo. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/Interpreter/

[PATCH] D141215: [clang-repl][WIP] Implement pretty printing

junaire updated this revision to Diff 498655. junaire added a comment. Update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/Interpreter/Interpreter.h clang/include/clang/

[PATCH] D141215: [clang-repl][WIP] Implement pretty printing

junaire updated this revision to Diff 499801. junaire added a comment. Update tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/Interpreter/Interpreter.h clang/include/

[PATCH] D141215: [clang-repl][WIP] Implement pretty printing

junaire updated this revision to Diff 499804. junaire added a comment. Rename the interface. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/Interpreter/Interpreter.h clang/

[PATCH] D148997: [clang] Add a new annotation token: annot_repl_input_end

junaire updated this revision to Diff 520313. junaire added a comment. Update + Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148997/new/ https://reviews.llvm.org/D148997 Files: clang/include/clang/AST/Decl.h clang/include/clang/Basic/T

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire updated this revision to Diff 520324. junaire added a comment. Rebase + Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/AST/Decl.h clang/include/clang/Basic/T

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire updated this revision to Diff 520326. junaire marked an inline comment as done. junaire added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/Interpreter/

[PATCH] D146809: [clang-repl] Implement Value pretty printing

junaire updated this revision to Diff 520912. junaire added a comment. Fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146809/new/ https://reviews.llvm.org/D146809 Files: clang/include/clang/Interpreter/Interpreter.h clang/include/clang/Inte

[PATCH] D146809: [clang-repl] Implement Value pretty printing

junaire updated this revision to Diff 520913. junaire added a comment. Remove unused code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146809/new/ https://reviews.llvm.org/D146809 Files: clang/include/clang/Interpreter/Interpreter.h clang/in

[PATCH] D146809: [clang-repl] Implement Value pretty printing

junaire updated this revision to Diff 520914. junaire added a comment. Add some comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146809/new/ https://reviews.llvm.org/D146809 Files: clang/include/clang/Interpreter/Interpreter.h clang/incl

[PATCH] D146809: [clang-repl] Implement Value pretty printing

junaire updated this revision to Diff 520998. junaire added a comment. Export symbols in Windows. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146809/new/ https://reviews.llvm.org/D146809 Files: clang/include/clang/Interpreter/Interpreter.h c

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire marked 10 inline comments as done. junaire added inline comments. Comment at: clang/include/clang/Interpreter/Value.h:160-162 + // Interpreter, QualType are stored as void* to reduce dependencies. + void *Interp = nullptr; + void *OpaqueType = nullptr;

[PATCH] D146809: [clang-repl] Implement Value pretty printing

junaire updated this revision to Diff 521961. junaire added a comment. Don't use C++17 because Clang on Windows is not default to that :( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146809/new/ https://reviews.llvm.org/D146809 Files: clang/inc

<    1   2   3   4   >