[PATCH] D114688: [Clang] Add __builtin_elementwise_ceil

junaire updated this revision to Diff 390914. junaire added a comment. Adjust code style CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114688/new/ https://reviews.llvm.org/D114688 Files: clang/include/clang/Basic/Builtins.def clang/include/clang/Basic/DiagnosticSemaKinds.td clang

[PATCH] D114688: [Clang] Add __builtin_elementwise_ceil

junaire updated this revision to Diff 391016. junaire marked an inline comment as done. junaire added a comment. Apply some awesome suggestions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114688/new/ https://reviews.llvm.org/D114688 Files: clang/include/clang/Basic/Builtins.def

[PATCH] D114688: [Clang] Add __builtin_elementwise_ceil

junaire updated this revision to Diff 391316. junaire added a comment. I didn't know if I understand Aaron's words right, but I think I can update the patch first... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114688/new/ https://reviews.llvm.org/D114688 Files: clang/include/clang

[PATCH] D114688: [Clang] Add __builtin_elementwise_ceil

junaire updated this revision to Diff 391574. junaire added a comment. No more lambdas CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114688/new/ https://reviews.llvm.org/D114688 Files: clang/include/clang/Basic/Builtins.def clang/include/clang/Basic/DiagnosticSemaKinds.td clang/i

[PATCH] D136018: [Clang] Fix crash when checking misaligned member with dependent type

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. junaire marked an inline comment as done. Closed by commit rG2946b252993d: [Clang] Fix crash when checking misaligned member with dependent type (authored by junaire).

[PATCH] D131657: Remove redundant condition check, NFC

junaire created this revision. Herald added a project: All. junaire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Signed-off-by: Jun Zhang Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D131657 Files: clang/lib/Pars

[PATCH] D131657: Remove redundant condition check, NFC

junaire added a comment. In D131657#3715976 , @erichkeane wrote: > LGTM! Let us know if you need this committed for you. Thanks! But I already have commit access :^) Closed in efc75a2baedc7405193e3e0f5ea9aaa881783cec

[PATCH] D124434: [Clang][Test] Run tests in C++14 mode explicitly.

junaire abandoned this revision. junaire added a comment. Herald added a subscriber: bzcheeseman. Prefer https://reviews.llvm.org/D131464 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124434/new/ https://reviews.llvm.org/D124434 __

[PATCH] D130831: [CodeGen] Track DeferredDecls that have been emitted

junaire added a comment. gentle ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130831/new/ https://reviews.llvm.org/D130831 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D133941: [clang][Interp] Record item types in InterpStack

junaire added a comment. Do you think `std::is_same_v` will be even better? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133941/new/ https://reviews.llvm.org/D133941 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D134105: [Docs] Add a link that refers to C++ standard modules in Clang modules doc

junaire created this revision. junaire added a reviewer: ChuanqiXu. Herald added a project: All. junaire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Currently there're two pages that both talk about "Modules" in clang, but they're diffe

[PATCH] D134105: [Docs] Add a link that refers to C++ standard modules in Clang modules doc

junaire updated this revision to Diff 461040. junaire added a comment. I bet now it rendered correctly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134105/new/ https://reviews.llvm.org/D134105 Files: clang/docs/Modules.rst Index: clang/docs/

[PATCH] D134105: [Docs] Add a link that refers to C++ standard modules in Clang modules doc

junaire added a comment. F24597444: image.png Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134105/new/ https://reviews.llvm.org/D134105 ___ cfe-commits mailing list

[PATCH] D134105: [Docs] Add a link that refers to C++ standard modules in Clang modules doc

This revision was automatically updated to reflect the committed changes. Closed by commit rG303526ef3aa2: [Docs] Add a link that refers to C++ standard modules in Clang modules doc (authored by junaire). Changed prior to commit: https://reviews.llvm.org/D134105?vs=461040&id=461058#toc Reposit

[PATCH] D134461: [Clang] Diagnose an error when trying to deferencing void pointers in C

junaire created this revision. junaire added reviewers: aaron.ballman, pmor13. Herald added a project: All. junaire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously we only have an extension that warn void pointer deferencing in C

[PATCH] D134461: [Clang] Diagnose an error when trying to deferencing void pointers in C

junaire added a comment. I'd admit that passing a boolean between these functions is ugly but surprisingly it works! even for `&(void_ptr)! But yeah, please suggest if you have better solutions ;D Comment at: clang/test/C/drs/dr1xx.c:142 /* The behavior of all three of the

[PATCH] D134461: [Clang] Diagnose an error when trying to deferencing void pointers in C

junaire added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:14541 + Kind = diag::ext_typecheck_indirection_through_void_pointer; +else if (S.getLangOpts().C99 && !IsAfterAmp) + Kind = diag::warn_deference_void_pointer; I don't know why we

[PATCH] D134461: [Clang] Diagnose an error when trying to deferencing void pointers in C

junaire updated this revision to Diff 462426. junaire added a comment. Address comments from reviewers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134461/new/ https://reviews.llvm.org/D134461 Files: clang/docs/ReleaseNotes.rst clang/include

[PATCH] D134461: [Clang] Diagnose an error when trying to deferencing void pointers in C

junaire marked 3 inline comments as done. junaire added a comment. > So I thought 'isAddressOfOperand' might be good enough for this, is this not > the case? Yeah, that works, I somehow missed it ;D Thank you, Erich! Comment at: clang/lib/Sema/SemaExpr.cpp:14541 + Kind =

[PATCH] D134461: [Clang] Warn when trying to deferencing void pointers in C

junaire updated this revision to Diff 462428. junaire marked an inline comment as done. junaire added a comment. Add `&(*p)` test case in dr1xx.c. (Previous seperate test is removed as it mostly duplicate with the DR test) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D134461: [Clang] Warn when trying to deferencing void pointers in C

junaire added inline comments. Comment at: clang/test/C/drs/dr1xx.c:140 /* The behavior changed between C89 and C99. */ - (void)&*p; /* c89only-warning {{ISO C forbids taking the address of an expression of type 'void'}} */ + (void)&*p; /* c89only-warning {{ISO C forbids ta

[PATCH] D134461: [Clang] Warn when trying to deferencing void pointers in C

junaire updated this revision to Diff 462643. junaire added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134461/new/ https://reviews.llvm.org/D134461 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/Di

[PATCH] D134461: [Clang] Warn when trying to deferencing void pointers in C

This revision was automatically updated to reflect the committed changes. Closed by commit rGe07ead85a368: [Clang] Warn when trying to dereference void pointers in C (authored by junaire). Changed prior to commit: https://reviews.llvm.org/D134461?vs=462643&id=462671#toc Repository: rG LLVM G

[PATCH] D134461: [Clang] Warn when trying to deferencing void pointers in C

junaire added a comment. Sorry for missing the conversation, I was in sleeping mode at that time ;D > This warning is quite noisy for the Linux kernel due to a couple of places > where a void * is dereferenced as part of compile time checking. I'm actually surprised to see that, I thought Clang

[PATCH] D134702: [Clang] Don't warn if deferencing void pointers in unevaluated context

junaire created this revision. junaire added reviewers: aaron.ballman, nathanchance, nickdesaulniers. Herald added a project: All. junaire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. After https://reviews.llvm.org/D134461, Clang will di

[PATCH] D134702: [Clang] Don't warn if deferencing void pointers in unevaluated context

junaire added a comment. In D134702#3818274 , @nathanchance wrote: > Thanks a lot for fixing this! I took it for a spin against the Linux kernel > and all instances of `-Wvoid-ptr-dereference` disappeared :) Awesome! Glad to hear this fixed your proble

[PATCH] D134702: [Clang] Don't warn if deferencing void pointers in unevaluated context

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG89e56e732d5e: [Clang] Don't warn if deferencing void pointers in unevaluated context (authored by junaire). Repository: rG LLVM Github Monorepo C

[PATCH] D136018: [Clang] Fix crash when checking misaligned member with dependent type

junaire created this revision. junaire added reviewers: aaron.ballman, shafik. Herald added a project: All. junaire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. If the type is dependent, we should just discard it and not checking its ali

[PATCH] D136018: [Clang] Fix crash when checking misaligned member with dependent type

junaire updated this revision to Diff 468193. junaire added a comment. Address Aaron's comments, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136018/new/ https://reviews.llvm.org/D136018 Files: clang/lib/Sema/SemaChecking.cpp clang/te

[PATCH] D136018: [Clang] Fix crash when checking misaligned member with dependent type

junaire updated this revision to Diff 468409. junaire added a comment. Add the original mailformed test case, thanks Shafik! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136018/new/ https://reviews.llvm.org/D136018 Files: clang/lib/Sema/SemaChe

[PATCH] D136018: [Clang] Fix crash when checking misaligned member with dependent type

junaire marked 5 inline comments as done. junaire added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:17398-17399 + const bool IsDiscardMisalignedPointer = + T->isPointerType() && + (T->getPointeeType()->isIncompleteType() || T->isDependentTy

[PATCH] D140753: [clang][dataflow] Check both operand's type in mergeDistinctValues

junaire created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. junaire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously we assume RHS is a BoolValue if LHS i

[PATCH] D140753: [clang][dataflow] Check both operand's type in mergeDistinctValues

junaire added a comment. In D140753#4019322 , @gribozavr2 wrote: > Thank you for your contribution! > > While adding a conditional check fixes the crash, the problem's root cause > must be deeper. Mismatched types indicate that one code path in dataflow

[PATCH] D140753: [clang][dataflow] Check both operand's type in mergeDistinctValues

junaire updated this revision to Diff 485654. junaire added a comment. Update patch according to @ymandel 's suggestion. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140753/new/ https://reviews.llvm.org/D140753 Files: clang/lib/Analysis

[PATCH] D140753: [clang][dataflow] Fix crash when having boolean-to-integral casts.

junaire updated this revision to Diff 485657. junaire added a comment. Fix typos Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140753/new/ https://reviews.llvm.org/D140753 Files: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp clang/u

[PATCH] D140753: [clang][dataflow] Fix crash when having boolean-to-integral casts.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeda2eaabf294: [clang][dataflow] Fix crash when having boolean-to-integral casts. (authored by junaire). Changed prior to commit: https://reviews.l

[PATCH] D141215: [clang-repl][WIP] Implement pretty printing

junaire created this revision. Herald added a project: All. junaire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch implements the initial value pretty printing for clang-repl. In general, when clang-repl finds something need to

[PATCH] D141215: [clang-repl][WIP] Implement pretty printing

junaire updated this revision to Diff 488158. junaire added a comment. Make build bots happy Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/Interpreter/Interpreter.h clang/

[PATCH] D137494: [Clangd] Fix the code action `RemoveUsingNamespace`

junaire added a comment. In D137494#3910500 , @v1nh1shungry wrote: > @tom-anders Thank you for reviewing! > > I tried adding a test but I don't know how to run the tests. > > And I just found that operators declared in a class context are already > hand

[PATCH] D137494: [Clangd] Fix the code action `RemoveUsingNamespace`

junaire added inline comments. Comment at: clang-tools-extra/clangd/unittests/tweaks/RemoveUsingNamespaceTests.cpp:236 + } + using namespace n^s; + int main() { v1nh1shungry wrote: > junaire wrote: > > is this a typo? > I guess not. I refer to the

[PATCH] D141215: [clang-repl][WIP] Implement pretty printing

junaire updated this revision to Diff 492665. junaire added a comment. Herald added a subscriber: ChuanqiXu. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/Interpreter

[PATCH] D141215: [clang-repl][WIP] Implement pretty printing

junaire updated this revision to Diff 494865. junaire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/Interpreter/Interpreter.h clang/include/clang/I

[PATCH] D141215: [clang-repl][WIP] Implement pretty printing

junaire updated this revision to Diff 488466. junaire added a comment. Let's try a better approach to determine whether we should pretty print the expression. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D1412

[PATCH] D141215: [clang-repl][WIP] Implement pretty printing

junaire updated this revision to Diff 488502. junaire added a comment. Introduce `Value` class Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/Interpreter/Interpreter.h clan

[PATCH] D126682: [Interpreter][ClangRepl] Implement undo command

junaire updated this revision to Diff 436214. junaire added a comment. Address Vassil's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126682/new/ https://reviews.llvm.org/D126682 Files: clang/include/clang/Interpreter/Interpreter.h cl

[PATCH] D126682: [Interpreter][ClangRepl] Implement undo command

junaire updated this revision to Diff 436219. junaire added a comment. Fix the unintentional format by clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126682/new/ https://reviews.llvm.org/D126682 Files: clang/include/clang/Interpreter

[PATCH] D126682: [Interpreter][ClangRepl] Implement undo command

junaire updated this revision to Diff 436229. junaire added a comment. Fix the build Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126682/new/ https://reviews.llvm.org/D126682 Files: clang/include/clang/Interpreter/Interpreter.h clang/lib/Inte

[PATCH] D127730: Reland "[CodeGen] Keep track info of lazy-emitted symbols in ModuleBuilder"

junaire created this revision. Herald added a project: All. junaire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This reverts commits: d3ddc251acae631bf5ab4da13878f7e8b5b5a451

[PATCH] D127730: Reland "[CodeGen] Keep track info of lazy-emitted symbols in ModuleBuilder"

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG781ee538da18: Reland "[CodeGen] Keep track info of lazy-emitted symbols in ModuleBuilder" (authored by junaire). Reposito

[PATCH] D126682: [Interpreter][ClangRepl] Implement undo command

junaire updated this revision to Diff 438892. junaire added a comment. - Add unittest - Fix a crash when previous input failed to parse Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126682/new/ https://reviews.llvm.org/D126682 Files: clang/inclu

[PATCH] D126682: [Interpreter][ClangRepl] Implement undo command

junaire updated this revision to Diff 439744. junaire added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126682/new/ https://reviews.llvm.org/D126682 Files: clang/include/clang/Interpreter/Interpreter.h clang/lib/Interpreter

[PATCH] D126682: [Interpreter][ClangRepl] Implement undo command

junaire updated this revision to Diff 440027. junaire added a comment. Address @v.g.vassilev 's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126682/new/ https://reviews.llvm.org/D126682 Files: clang/include/clang/Interpreter/Interpret

[PATCH] D126682: [Interpreter][ClangRepl] Implement undo command

junaire marked 3 inline comments as done. junaire added inline comments. Comment at: clang/lib/Interpreter/IncrementalParser.cpp:281 +void IncrementalParser::Restore(PartialTranslationUnit &PTU) { + TranslationUnitDecl *MostRecentTU = PTU.TUPart; v.g.vassilev

[PATCH] D126682: [Interpreter][clang-repl] Implement undo command

junaire updated this revision to Diff 440036. junaire added a comment. - Rename IncrementalParser::Restore to IncrementalParser::CleanupPTU - Drop unused code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126682/new/ https://reviews.llvm.org/D12668

[PATCH] D126682: [clang-repl] Implement undo command

junaire updated this revision to Diff 440038. junaire added a comment. - Update a comment - Add a FIXME back Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126682/new/ https://reviews.llvm.org/D126682 Files: clang/include/clang/Interpreter/Interp

[PATCH] D126682: [clang-repl] Implement undo command

junaire updated this revision to Diff 440042. junaire added a comment. Update commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126682/new/ https://reviews.llvm.org/D126682 Files: clang/include/clang/Interpreter/Interpreter.h clang/

[PATCH] D126682: [clang-repl] Implement code undo

junaire updated this revision to Diff 440043. junaire edited the summary of this revision. junaire added a comment. Rename CleanupPTU => CleanUpPTU Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126682/new/ https://reviews.llvm.org/D126682 Files:

[PATCH] D126682: [clang-repl] Implement code undo

junaire updated this revision to Diff 440050. junaire added a comment. Try to fix the failing permerge test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126682/new/ https://reviews.llvm.org/D126682 Files: clang/include/clang/Interpreter/Interp

[PATCH] D126682: [clang-repl] Implement code undo

junaire closed this revision. junaire added a comment. land in https://reviews.llvm.org/rGdea5a9cc929048be261a4c030407e4d7e1e70fec Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126682/new/ https://reviews.llvm.org/D126682 _

[PATCH] D126682: [WIP][Interpreter] Implement undo command

junaire created this revision. junaire added a reviewer: v.g.vassilev. Herald added a project: All. junaire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Signed-off-by: Jun Zhang Repository: rG LLVM Github Monorepo https://reviews.l

[PATCH] D126682: [WIP][Interpreter] Implement undo command

junaire updated this revision to Diff 433008. junaire added a comment. Also remove PTU in PTU list Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126682/new/ https://reviews.llvm.org/D126682 Files: clang/include/clang/Interpreter/Interpreter.h

[PATCH] D126682: [WIP][Interpreter] Implement undo command

junaire updated this revision to Diff 433009. junaire added a comment. Improve code a little bit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126682/new/ https://reviews.llvm.org/D126682 Files: clang/include/clang/Interpreter/Interpreter.h cl

[PATCH] D126682: [WIP][Interpreter] Implement undo command

junaire updated this revision to Diff 433011. junaire added a comment. Remove a NFC change to make review easier Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126682/new/ https://reviews.llvm.org/D126682 Files: clang/include/clang/Interpreter/In

[PATCH] D126684: [Interpreter] Implment Interpreter::Restore to clean up lookup table

junaire created this revision. junaire added a reviewer: v.g.vassilev. Herald added a project: All. junaire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds a new method to the clang::Interpreter, enables us to explictly clea

[PATCH] D126684: [Interpreter] Implment Interpreter::Restore to clean up lookup table

junaire updated this revision to Diff 433022. junaire added a comment. Format the patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126684/new/ https://reviews.llvm.org/D126684 Files: clang/include/clang/Interpreter/Interpreter.h clang/lib/I

[PATCH] D126682: [WIP][Interpreter] Implement undo command

junaire updated this revision to Diff 433029. junaire added a comment. - Support undo N times - Add a comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126682/new/ https://reviews.llvm.org/D126682 Files: clang/include/clang/Interpreter/Inter

[PATCH] D126682: [WIP][Interpreter] Implement undo command

junaire updated this revision to Diff 433030. junaire added a comment. Pass PTU by reference as it can't be NULL, this makes our code safer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126682/new/ https://reviews.llvm.org/D126682 Files: clang/

[PATCH] D126682: [WIP][Interpreter] Implement undo command

junaire updated this revision to Diff 433031. junaire added a comment. Fix the build Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126682/new/ https://reviews.llvm.org/D126682 Files: clang/include/clang/Interpreter/Interpreter.h clang/lib/Inte

[PATCH] D126682: [WIP][Interpreter] Implement undo command

junaire updated this revision to Diff 433038. junaire added a comment. - Add prefix for meta commands - Add more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126682/new/ https://reviews.llvm.org/D126682 Files: clang/include/clang/Interpre

[PATCH] D126682: [Interpreter][ClangRepl] Implement undo command

junaire added a comment. this depends on https://reviews.llvm.org/D126684 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126682/new/ https://reviews.llvm.org/D126682 ___ cfe-commits mailing list cfe-commi

[PATCH] D126781: [CodeGen] Correctly handle weak symbols in the codegen

junaire created this revision. junaire added reviewers: v.g.vassilev, rjmccall. Herald added a project: All. junaire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This used to be several downstream patches of Cling, it aims to fix errors

[PATCH] D126781: [CodeGen] Correctly handle weak symbols in the codegen

junaire updated this revision to Diff 433607. junaire added a comment. Fix the broken build Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126781/new/ https://reviews.llvm.org/D126781 Files: clang/lib/CodeGen/CodeGenModule.cpp clang/lib/CodeGen

[PATCH] D126781: [CodeGen] Correctly handle weak symbols in the codegen

junaire updated this revision to Diff 433610. junaire added a comment. Only use heplers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126781/new/ https://reviews.llvm.org/D126781 Files: clang/lib/CodeGen/CodeGenModule.cpp clang/lib/CodeGen/Cod

[PATCH] D126781: [CodeGen] Correctly handle weak symbols in the codegen

junaire updated this revision to Diff 433623. junaire added a comment. Fix the build Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126781/new/ https://reviews.llvm.org/D126781 Files: clang/lib/CodeGen/CodeGenModule.cpp clang/lib/CodeGen/CodeGe

[PATCH] D126781: [CodeGen] Correctly handle weak symbols in the codegen

junaire updated this revision to Diff 433624. junaire added a comment. Forget to use helpers again... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126781/new/ https://reviews.llvm.org/D126781 Files: clang/lib/CodeGen/CodeGenModule.cpp clang/l

[PATCH] D126781: [CodeGen] Correctly handle weak symbols in the codegen

junaire updated this revision to Diff 433659. junaire added a comment. Fix the unittest failure Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126781/new/ https://reviews.llvm.org/D126781 Files: clang/lib/CodeGen/CodeGenModule.cpp clang/lib/Cod

[PATCH] D126781: [CodeGen] Correctly handle weak symbols in the codegen

junaire updated this revision to Diff 433694. junaire added a comment. also swap TBAA Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126781/new/ https://reviews.llvm.org/D126781 Files: clang/lib/CodeGen/CodeGenModule.cpp clang/lib/CodeGen/CodeG

[PATCH] D126781: [CodeGen] Correctly handle weak symbols in the codegen

junaire updated this revision to Diff 433965. junaire added a comment. remove `EmittedDeferredDecls` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126781/new/ https://reviews.llvm.org/D126781 Files: clang/lib/CodeGen/CodeGenModule.h clang/lib/

[PATCH] D126781: [CodeGen] Correctly handle weak symbols in the codegen

junaire updated this revision to Diff 433976. junaire added a comment. Update commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126781/new/ https://reviews.llvm.org/D126781 Files: clang/lib/CodeGen/CodeGenModule.h clang/lib/CodeGen/

[PATCH] D126781: [CodeGen] Keep track info of lazy-emitted symbols in ModuleBuilder

junaire updated this revision to Diff 434236. junaire retitled this revision from " [CodeGen] Keep track info of lazy-emitted symbols in ModuleBuilder" to "[CodeGen] Keep track info of lazy-emitted symbols in ModuleBuilder". junaire edited the summary of this revision. junaire added a comment. A

[PATCH] D126781: [CodeGen] Keep track info of lazy-emitted symbols in ModuleBuilder

junaire updated this revision to Diff 434238. junaire added a comment. Fix the broken build Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126781/new/ https://reviews.llvm.org/D126781 Files: clang/lib/CodeGen/CodeGenModule.h clang/lib/CodeGen/M

[PATCH] D126781: [CodeGen] Keep track info of lazy-emitted symbols in ModuleBuilder

junaire updated this revision to Diff 434251. junaire added a comment. I think std::swap makes the logic more clear Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126781/new/ https://reviews.llvm.org/D126781 Files: clang/lib/CodeGen/CodeGenModule

[PATCH] D126781: [CodeGen] Keep track info of lazy-emitted symbols in ModuleBuilder

junaire updated this revision to Diff 434473. junaire added a comment. friend class comes to the rescue! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126781/new/ https://reviews.llvm.org/D126781 Files: clang/lib/CodeGen/CodeGenModule.h clang/

[PATCH] D126781: [CodeGen] Keep track info of lazy-emitted symbols in ModuleBuilder

junaire updated this revision to Diff 434474. junaire marked an inline comment as done. junaire added a comment. fix a typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126781/new/ https://reviews.llvm.org/D126781 Files: clang/lib/CodeGen/CodeG

[PATCH] D126781: [CodeGen] Keep track info of lazy-emitted symbols in ModuleBuilder

junaire added inline comments. Comment at: clang/lib/CodeGen/ModuleBuilder.cpp:138 + { +CodeGenModule::KeepLazyEmiitedSymRAII RAIIKeeper(Builder); +M.reset(new llvm::Module(ExpandModuleName(ModuleName, CodeGenOpts), C)); v.g.vassilev wrote:

[PATCH] D126781: [CodeGen] Keep track info of lazy-emitted symbols in ModuleBuilder

junaire updated this revision to Diff 434479. junaire added a comment. Remove extra brackets Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126781/new/ https://reviews.llvm.org/D126781 Files: clang/lib/CodeGen/CodeGenModule.h clang/lib/CodeGen/

[PATCH] D126781: [CodeGen] Keep track info of lazy-emitted symbols in ModuleBuilder

junaire added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.h:1482 + + struct KeepLazyEmiitedSymRAII { +std::unique_ptr OldBuilder; rjmccall wrote: > I think a RAII object is an odd way to express this API; there's not really a > natural reas

[PATCH] D126781: [CodeGen] Keep track info of lazy-emitted symbols in ModuleBuilder

junaire updated this revision to Diff 434714. junaire added a comment. Try to address @rjmccall 's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126781/new/ https://reviews.llvm.org/D126781 Files: clang/lib/CodeGen/CodeGenModule.h cla

[PATCH] D126781: [CodeGen] Keep track info of lazy-emitted symbols in ModuleBuilder

junaire added inline comments. Comment at: clang/lib/CodeGen/ModuleBuilder.cpp:163 for (auto &&Lib : CodeGenOpts.DependentLibraries) Builder->AddDependentLib(Lib); I left I may doing something wrong here, after invoking `Initialize` we set `Bui

[PATCH] D126781: [CodeGen] Keep track info of lazy-emitted symbols in ModuleBuilder

junaire updated this revision to Diff 435000. junaire added a comment. Address @rjmccall 's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126781/new/ https://reviews.llvm.org/D126781 Files: clang/lib/CodeGen/CodeGenModule.h clang/lib/

[PATCH] D126781: [CodeGen] Keep track info of lazy-emitted symbols in ModuleBuilder

junaire updated this revision to Diff 435004. junaire added a comment. I believe that `OldBuilder` is always valid in the normal cases, so remove the if condition and replace it with an assertion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126781

[PATCH] D126781: [CodeGen] Keep track info of lazy-emitted symbols in ModuleBuilder

junaire updated this revision to Diff 435460. junaire added a comment. OK, then we'd better to roll the condition back. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126781/new/ https://reviews.llvm.org/D126781 Files: clang/lib/CodeGen/CodeGenMo

[PATCH] D126781: [CodeGen] Keep track info of lazy-emitted symbols in ModuleBuilder

junaire added a comment. In D126781#3570147 , @rjmccall wrote: > Okay, LGTM Thanks for the review ☺️ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126781/new/ https://reviews.llvm.org/D126781 ___

[PATCH] D126781: [CodeGen] Keep track info of lazy-emitted symbols in ModuleBuilder

This revision was automatically updated to reflect the committed changes. Closed by commit rGb8f945971581: [CodeGen] Keep track info of lazy-emitted symbols in ModuleBuilder (authored by junaire). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126781/

[PATCH] D126682: [Interpreter][ClangRepl] Implement undo command

junaire updated this revision to Diff 435779. junaire added a subscriber: Purva-Chaudhari. junaire added a comment. Merge D126684 into this patch. Consider D126684 is almost @Purva-Chaudhari 's work, I'll list her as co-author

[PATCH] D126684: [Interpreter] Implment Interpreter::Restore to clean up lookup table

junaire abandoned this revision. junaire added a comment. work moved to D126682 , so abandon this Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126684/new/ https://reviews.llvm.org/D126684

[PATCH] D126682: [Interpreter][ClangRepl] Implement undo command

junaire updated this revision to Diff 435781. junaire added a comment. Restore PTU in Interpreter::Undo, this should fix the broken tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126682/new/ https://reviews.llvm.org/D126682 Files: clang/in

[PATCH] D126682: [Interpreter][ClangRepl] Implement undo command

junaire updated this revision to Diff 435782. junaire added a comment. Allow undo command failed in the edge cases like undoed too many times. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126682/new/ https://reviews.llvm.org/D126682 Files: clan

[PATCH] D126781: [CodeGen] Keep track info of lazy-emitted symbols in ModuleBuilder

junaire added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.h:1500 + +assert(WeakRefReferences.empty() && + "Not all WeakRefRefs have been applied"); v.g.vassilev wrote: > It seems that we forgot to move the `WeakRefReferences`? Thank

[PATCH] D126682: [Interpreter][ClangRepl] Implement undo command

junaire updated this revision to Diff 435826. junaire added a comment. - split the tests - add % to all meta commands Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126682/new/ https://reviews.llvm.org/D126682 Files: clang/include/clang/Interpret

<    1   2   3   4   >